Re: [PATCHv2 bluetooth-next 01/10] 6lowpan: add private neighbour data

2016-05-03 Thread Stefan Schmidt
Hello. On 20/04/16 10:19, Alexander Aring wrote: This patch will introduce a 6lowpan neighbour private data. Like the interface private data we handle private data for generic 6lowpan and for link-layer specific 6lowpan. The current first use case if to save the short address for a 802.15.4

Re: [PATCHv2 bluetooth-next 03/10] 6lowpan: remove ipv6 module request

2016-05-03 Thread Stefan Schmidt
Hello. On 20/04/16 10:19, Alexander Aring wrote: Since we use exported function from ipv6 kernel module we don't need to request the module anymore to have ipv6 functionality. Signed-off-by: Alexander Aring --- net/6lowpan/core.c | 2 -- 1 file changed, 2 deletions(-)

Re: [PATCHv2 bluetooth-next 02/10] 6lowpan: add 802.15.4 short addr slaac

2016-05-03 Thread Stefan Schmidt
Hello. On 20/04/16 10:19, Alexander Aring wrote: This patch adds the autoconfiguration if a valid 802.15.4 short address is available for 802.15.4 6LoWPAN interfaces. Cc: David S. Miller Cc: Alexey Kuznetsov Cc: James Morris Cc:

Re: [PATCHv2 bluetooth-next 04/10] ndisc: add addr_len parameter to ndisc_opt_addr_space

2016-05-03 Thread Stefan Schmidt
Hello. On 20/04/16 10:19, Alexander Aring wrote: This patch makes the address length as argument for the ndisc_opt_addr_space function. This is necessary to handle addresses which don't use dev->addr_len as address length. Cc: David S. Miller Cc: Alexey

Re: [PATCHv2 bluetooth-next 06/10] ndisc: add addr_len parameter to ndisc_fill_addr_option

2016-05-03 Thread Stefan Schmidt
Hello. On 20/04/16 10:19, Alexander Aring wrote: This patch makes the address length as argument for the ndisc_fill_addr_option function. This is necessary to handle addresses which don't use dev->addr_len as address length. Cc: David S. Miller Cc: Alexey

Re: [PATCHv2 bluetooth-next 05/10] ndisc: add addr_len parameter to ndisc_opt_addr_data

2016-05-03 Thread Stefan Schmidt
Hello. On 20/04/16 10:19, Alexander Aring wrote: This patch makes the address length as argument for the ndisc_opt_addr_data function. This is necessary to handle addresses which don't use dev->addr_len as address length. Cc: David S. Miller Cc: Alexey

Re: [PATCH] pxa168_eth: fix mdiobus_scan() error check

2016-05-03 Thread David Miller
From: Sergei Shtylyov Date: Sat, 30 Apr 2016 23:35:11 +0300 > Since mdiobus_scan() returns either an error code or NULL on error, the > driver should check for both, not only for NULL, otherwise a crash is > imminent... > > Reported-by: Arnd Bergmann

Re: [PATCH 2/3] usbnet: correct speed testing

2016-05-03 Thread David Miller
From: Oliver Neukum Date: Mon, 2 May 2016 13:06:13 +0200 > Allow for SS+ USB > > Signed-off-by: Oliver Neukum Applied.

Re: [PATCH 3/3] rtl8152: correct speed testing

2016-05-03 Thread David Miller
From: Oliver Neukum Date: Mon, 2 May 2016 13:06:14 +0200 > Allow for SS+ USB > > Signed-off-by: Oliver Neukum Applied.

[PATCH net-next v2] macvtap: add namespace support to the sysfs device class

2016-05-03 Thread Marc Angel
When creating macvtaps that are expected to have the same ifindex in different network namespaces, only the first one will succeed. The others will fail with a sysfs_warn_dup warning due to them trying to create the following sysfs link (with 'NN' the ifindex of macvtapX):

[PATCH v2 net-next] dmfe: kill DEVICE define

2016-05-03 Thread Florian Westphal
use net_device directly. Compile tested, objdiff shows no changes. Signed-off-by: Florian Westphal --- resending this separately as it's not related to the rest of the dev->trans_start removal series. drivers/net/ethernet/dec/tulip/dmfe.c | 39

Re: [PATCH] macb: fix mdiobus_scan() error check

2016-05-03 Thread David Miller
From: Sergei Shtylyov Date: Sun, 01 May 2016 01:47:36 +0300 > Now mdiobus_scan() returns ERR_PTR(-ENODEV) instead of NULL if the PHY > device ID was read as all ones. As this was not an error before, this > value should be filtered out now in this driver. >

Re: [PATCH net-next 1/1] qed: Apply tunnel configurations after PF start

2016-05-03 Thread David Miller
From: Manish Chopra Date: Mon, 2 May 2016 06:16:04 -0400 > Configure and enable various tunnels on the > adapter after PF start. > > This change was missed as a part of > 'commit 464f664501816ef5fbbc00b8de96f4ae5a1c9325 > ("qed: Add infrastructure support for

Re: [PATCH net] net: macb: Probe MDIO bus before registering netdev

2016-05-03 Thread David Miller
From: Florian Fainelli Date: Mon, 2 May 2016 18:38:45 -0700 > The current sequence makes us register for a network device prior to > registering and probing the MDIO bus which could lead to some unwanted > consequences, like a thread of execution calling into ndo_open

Re: [PATCHv2 bluetooth-next 00/10] 6lowpan: introduce basic 6lowpan-nd

2016-05-03 Thread David Miller
From: Marcel Holtmann Date: Mon, 2 May 2016 16:17:41 -0700 >> My proposal would be that the IPv6 patches go via net-next to reduce >> merge conflicts with maybe upcoming changes. If they are split up, they >> seem very much self contained and easy to review. The rest seems

Re: [PATCH nf-next 3/9] netfilter: conntrack: don't attempt to iterate over empty table

2016-05-03 Thread Florian Westphal
Pablo Neira Ayuso wrote: > > I was thinking of the cleanup we do in the netns exit path > > (in nf_conntrack_cleanup_net_list() ). > > Right, but in that path we still have entries in the table. Not necessarily, they might have already been removed (timeout, close). > > If

Re: [PATCH v2] net: mvneta: Remove superfluous SMP function call

2016-05-03 Thread David Miller
From: Anna-Maria Gleixner Date: Mon, 2 May 2016 11:02:51 +0200 > Since commit 3b9d6da67e11 ("cpu/hotplug: Fix rollback during error-out > in __cpu_disable()") it is ensured that callbacks of CPU_ONLINE and > CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to

Re: [net-next PATCH v3 0/8] Fix Tunnel features and enable GSO partial for several drivers

2016-05-03 Thread David Miller
From: Alexander Duyck Date: Mon, 02 May 2016 09:38:06 -0700 > v3: Moved 2 patches into series for net as they were generic fixes. > Added patch to disable GSO partial if frame is less than 2x size of MSS I'll therefore apply this series after my next net --> net-next

Re: [PATCH net-next] net: add __sock_wfree() helper

2016-05-03 Thread David Miller
From: Eric Dumazet Date: Mon, 02 May 2016 10:56:27 -0700 > From: Eric Dumazet > > Hosts sending lot of ACK packets exhibit high sock_wfree() cost > because of cache line miss to test SOCK_USE_WRITE_QUEUE > > We could move this flag close to

Re: [PATCHv2 bluetooth-next 07/10] ipv6: introduce neighbour discovery ops

2016-05-03 Thread Stefan Schmidt
Hello. On 02/05/16 21:36, Hannes Frederic Sowa wrote: On 20.04.2016 10:19, Alexander Aring wrote: This patch introduces neighbour discovery ops callback structure. The structure contains at first receive and transmit handling for NS/NA and userspace option field functionality. These callback

Re: [PATCH v6 00/21] Add HiSilicon RoCE driver

2016-05-03 Thread Leon Romanovsky
On Thu, Apr 28, 2016 at 08:09:35PM +0800, Lijun Ou wrote: > The HiSilicon Network Substem is a long term evolution IP which is > supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network > Sybsystem) also has a hardware support of performing RDMA with > RoCEE. > The driver for HiSilicon

Re: [PATCH 2/2] mac80211_hwsim: Allow managing radios from non-initial namespaces

2016-05-03 Thread Johannes Berg
On Tue, 2016-05-03 at 08:53 +0200, Martin Willi wrote: >  > +static __net_init int hwsim_init_net(struct net *net) > +{ > + struct mac80211_hwsim_data *data; > + bool exists = true; > + int netgroup = 0; > + > + spin_lock_bh(_radio_lock); > + while (exists) { > +

Re: [PATCH v1 net] net/mlx4: Avoid wrong virtual mappings

2016-05-03 Thread Or Gerlitz
On Tue, May 3, 2016, David Miller wrote: > From: Or Gerlitz >> The patch changes the driver to do single allocation for potentially >> very large HW WQE descriptor buffers such as those used by the RDMA >> (mlx5_ib) driver. > I know exactly what this

Re: [PATCH nf-next 5/9] netfilter: conntrack: small refactoring of conntrack seq_printf

2016-05-03 Thread Pablo Neira Ayuso
On Thu, Apr 28, 2016 at 07:13:44PM +0200, Florian Westphal wrote: > The iteration process is lockless, so we test if the conntrack object is > eligible for printing (e.g. is AF_INET) after obtaining the reference > count. > > Once we put all conntracks into same hash table we might see more >

Re: Cannot use NFS with linux-next 20160429

2016-05-03 Thread Fabio Estevam
[7.606456] #0: wm8962-audio [7.672659] VFS: Mounted root (nfs filesystem) readonly on device 0:14. [7.680860] devtmpfs: mounted [7.685664] Freeing unused kernel memory: 1024K (c0c0 - c0d0) [7.871481] [7.873004] = [7.877381]

Re: [net-next PATCH v2 0/5] stmmac: dwmac-socfpga refactor+cleanup

2016-05-03 Thread David Miller
From: Joachim Eastwood Date: Sun, 1 May 2016 22:58:18 +0200 > This patch aims to remove the init/exit callbacks from the dwmac- > socfpga driver and instead use standard PM callbacks. Doing this > will also allow us to cleanup the driver. > > Eventually the init/exit

Re: [PATCH net v2 0/2] RDS: TCP: sychronization during connection startup

2016-05-03 Thread David Miller
From: Sowmini Varadhan Date: Mon, 2 May 2016 11:24:50 -0700 > This patch series ensures that the passive (accept) side of the > TCP connection used for RDS-TCP is correctly synchronized with > any concurrent active (connect) attempts for a given pair of peers. > >

Re: [PATCH nf-next 3/9] netfilter: conntrack: don't attempt to iterate over empty table

2016-05-03 Thread Pablo Neira Ayuso
On Tue, May 03, 2016 at 07:17:44PM +0200, Florian Westphal wrote: > Pablo Neira Ayuso wrote: > > On Thu, Apr 28, 2016 at 07:13:42PM +0200, Florian Westphal wrote: > > > Once we place all conntracks into same table iteration becomes more > > > costly because the table contains

Re: [PATCH 1/3] brcm80211: correct speed testing

2016-05-03 Thread David Miller
From: Oliver Neukum Date: Mon, 2 May 2016 13:06:12 +0200 > Allow for SS+ USB > > Signed-off-by: Oliver Neukum Applied.

Re: [PATCH net-next 0/3] tipc: redesign socket-level flow control

2016-05-03 Thread David Miller
From: Jon Maloy Date: Mon, 2 May 2016 10:22:33 -0400 > The socket-level flow control in TIPC has long been due for a major > overhaul. This series fixes this. Series applied, thanks Jon.

Re: [net PATCH 0/2] Fixes for tunnel checksum and segmentation offloads

2016-05-03 Thread David Miller
From: Alexander Duyck Date: Mon, 02 May 2016 09:25:04 -0700 > This patch series is a subset of patches I had submitted for net-next. I > plan to drop these two patches from the v3 of "Fix Tunnel features and > enable GSO partial for several drivers" and I am instead

Re: [PATCH 2/2] mac80211_hwsim: Allow managing radios from non-initial namespaces

2016-05-03 Thread Johannes Berg
On Tue, 2016-05-03 at 08:53 +0200, Martin Willi wrote: > While wiphys can be moved into network namespaces over nl80211, the > creation and removal of hwsim radios is currently limited to the > initial namespace. This patch allows management of namespaced radios > from the owning namespace by

[PATCH 2/2] mac80211_hwsim: Allow managing radios from non-initial namespaces

2016-05-03 Thread Martin Willi
While wiphys can be moved into network namespaces over nl80211, the creation and removal of hwsim radios is currently limited to the initial namespace. This patch allows management of namespaced radios from the owning namespace by setting genetlink netnsok. To prevent two arbitrary namespaces

[PATCH 1/2] nl80211: Allow privileged operations from user namespaces

2016-05-03 Thread Martin Willi
While a wiphy can be transferred to network namespaces, a process having CAP_NET_ADMIN in a non-initial user namespace can not administrate such devices due to the genetlink GENL_ADMIN_PERM restrictions. For openvswitch having the same issue, a new GENL_UNS_ADMIN_PERM flag has been introduced,

[PATCH 0/2] wireless: Allow wiphy/hwsim management from user namespaces

2016-05-03 Thread Martin Willi
This patch set enables user namespaces having CAP_NET_ADMIN to manage wiphy devices and create/destroy hwsim radios. The first patch allows a caller from a non-initial user namespace to run privileged nl80211 phy/dev operations. The second patch enables hwsim radio management over Netlink from

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-03 Thread Dean Jenkins
On 03/05/16 05:55, John Stultz wrote: In testing with HiKey, we found that since commit 3f30b158eba5c60 (asix: On RX avoid creating bad Ethernet frames), we're seeing lots of noise during network transfers: [ 239.027993] asix 1-1.1:1.0 eth0: asix_rx_fixup() Data Header synchronisation was

Re: [PATCH net-next] block/drbd: use nla_put_u64_64bit()

2016-05-03 Thread Nicolas Dichtel
Le 03/05/2016 10:50, Nicolas Dichtel a écrit : > I had to define an intermediate function (nla_magic_put_flag()) because > handlers in genl_magic_struct.h expect a function with three arguments. > > Note that this patch is only compile-tested. > > Signed-off-by: Nicolas Dichtel

[PATCH net-next] block/drbd: use nla_put_u64_64bit()

2016-05-03 Thread Nicolas Dichtel
I had to define an intermediate function (nla_magic_put_flag()) because handlers in genl_magic_struct.h expect a function with three arguments. Note that this patch is only compile-tested. Signed-off-by: Nicolas Dichtel --- drivers/block/drbd/drbd_nl.c | 29

Re: [Question] Should `CAP_NET_ADMIN` be needed when opening `/dev/ppp`?

2016-05-03 Thread Guillaume Nault
On Sun, May 01, 2016 at 09:38:57PM +0800, Wang Shanker wrote: > static int ppp_open(struct inode *inode, struct file *file) > { > /* >* This could (should?) be enforced by the permissions on /dev/ppp. >*/ > if (!capable(CAP_NET_ADMIN)) > return -EPERM; >

Re: [PATCH v1 net] net/mlx4: Avoid wrong virtual mappings

2016-05-03 Thread Or Gerlitz
On Wed, Apr 27, 2016 at 10:07 AM, Haggai Abramovsky wrote: > The dma_alloc_coherent() function returns a virtual address which can > be used for coherent access to the underlying memory. On some > architectures, like arm64, undefined behavior results if this memory is > also

Re: [PATCH v5 09/21] IB/hns: Add hca support

2016-05-03 Thread Wei Hu (Xavier)
On 2016/5/3 16:14, Or Gerlitz wrote: On Tue, May 3, 2016 at 10:57 AM, Wei Hu (Xavier) wrote: On 2016/4/30 12:33, Or Gerlitz wrote: Can you elaborate what design aspects in the driver or anywhere else should impose that limitation? 1. Oulijun resolved the

Re: [PATCH v5 09/21] IB/hns: Add hca support

2016-05-03 Thread Or Gerlitz
On Tue, May 3, 2016 at 10:57 AM, Wei Hu (Xavier) wrote: > On 2016/4/30 12:33, Or Gerlitz wrote: >> Can you elaborate what design aspects in the driver or anywhere else >> should impose that limitation? > 1. Oulijun resolved the problem, and sent PATCH V6 on 2016-4-28.

Re: [PATCH net-next v2] block/drbd: use nla_put_u64_64bit()

2016-05-03 Thread Lars Ellenberg
On Tue, May 03, 2016 at 11:39:18AM +0200, Nicolas Dichtel wrote: > Two new handlers have been defined in genl_magic_ headers: > - __field2: the corresponding nla_put() function (nla_put_flag()) takes > only two args > - __field4: the corresponding nla_put() function

[PATCH iproute2 v2] tc: add bash-completion function

2016-05-03 Thread Quentin Monnet
Add function for command completion for tc in bash, and update Makefile to install it under /usr/share/bash-completion/completions/. Inside iproute2 repository, the completion code is in a new `bash-completion` toplevel directory. v2: Remove `if` statement in Makefile: do not try to install in

[PATCH net v1] ipv6/ila: fix nlsize calculation for lwtunnel

2016-05-03 Thread Nicolas Dichtel
The handler 'ila_fill_encap_info' adds one attribute: ILA_ATTR_LOCATOR. Fixes: 65d7ab8de582 ("net: Identifier Locator Addressing module") CC: Tom Herbert Signed-off-by: Nicolas Dichtel --- RFC -> v1: - rebase on last net tree

[PATCH net-next v2] block/drbd: use nla_put_u64_64bit()

2016-05-03 Thread Nicolas Dichtel
Two new handlers have been defined in genl_magic_ headers: - __field2: the corresponding nla_put() function (nla_put_flag()) takes only two args - __field4: the corresponding nla_put() function (nla_put_u64_64bit()) takes four args __field2 allows us to define

Re: [PATCH net] net: macb: Probe MDIO bus before registering netdev

2016-05-03 Thread Nicolas Ferre
Le 03/05/2016 03:38, Florian Fainelli a écrit : > The current sequence makes us register for a network device prior to > registering and probing the MDIO bus which could lead to some unwanted > consequences, like a thread of execution calling into ndo_open before > register_netdev() returns, while

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-03 Thread Guodong Xu
On 3 May 2016 at 17:23, Dean Jenkins wrote: > On 03/05/16 05:55, John Stultz wrote: >> >> In testing with HiKey, we found that since commit 3f30b158eba5c60 >> (asix: On RX avoid creating bad Ethernet frames), we're seeing lots of >> noise during network transfers: >> >> [

Re: [PATCH net-next] tcp: guarantee forward progress in tcp_sendmsg()

2016-05-03 Thread David Miller
From: Eric Dumazet Date: Mon, 02 May 2016 21:49:25 -0700 > From: Eric Dumazet > > Under high rx pressure, it is possible tcp_sendmsg() never has a > chance to allocate an skb and loop forever as sk_flush_backlog() > would always return true. > >

Re: [PATCH net-next v2] ipv6: add new struct ipcm6_cookie

2016-05-03 Thread David Miller
From: Wei Wang Date: Mon, 2 May 2016 21:40:07 -0700 > From: Wei Wang > > In the sendmsg function of UDP, raw, ICMP and l2tp sockets, we use local > variables like hlimits, tclass, opt and dontfrag and pass them to > corresponding > functions like

Re: [PATCH] fix infoleak in wireless

2016-05-03 Thread Greg Kroah-Hartman
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I

[PATCH] mdio_bus: don't return NULL from mdiobus_scan()

2016-05-03 Thread Sergei Shtylyov
I've finally noticed that mdiobus_scan() also returns either NULL or error value on failure. Return ERR_PTR(-ENODEV) instead of NULL since this is the error value already filtered out by the callers that want to ignore the MDIO address scan failure... Signed-off-by: Sergei Shtylyov

Re: [PATCH net] bridge: fix igmp / mld query parsing

2016-05-03 Thread Stephen Hemminger
On Tue, 3 May 2016 22:18:54 +0200 Linus Lüssing wrote: > diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c > index 03661d9..7105cdf 100644 > --- a/net/bridge/br_multicast.c > +++ b/net/bridge/br_multicast.c > @@ -1271,6 +1271,7 @@ static int

[PATCH] fix infoleak in wireless

2016-05-03 Thread Kangjie Lu
The 6-bytes array “mac_addr” is not initialized in the dump_station implementations of “drivers/staging/wilc1000/wilc_wfi_cfgoperations.c” and “drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c”, so all 6 bytes may be leaked. Signed-off-by: Kangjie Lu --- net/wireless/nl80211.c

[PATCH 06/15] batman-adv: use to_delayed_work

2016-05-03 Thread Antonio Quartulli
From: Geliang Tang Use to_delayed_work() instead of open-coding it. Signed-off-by: Geliang Tang Reviewed-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli

[PATCH 07/15] batman-adv: fix wrong names in kerneldoc

2016-05-03 Thread Antonio Quartulli
Signed-off-by: Antonio Quartulli [s...@narfation.org: Fix additional names] Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner --- net/batman-adv/bridge_loop_avoidance.c | 2 +- net/batman-adv/distributed-arp-table.c |

[PATCH 09/15] batman-adv: Fix kerneldoc for batadv_compare_claim

2016-05-03 Thread Antonio Quartulli
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bridge_loop_avoidance.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 08/15] batman-adv: Fix checkpatch warning about 'unsigned' type

2016-05-03 Thread Antonio Quartulli
From: Sven Eckelmann checkpatch.pl warns about the use of 'unsigned' as a short form for 'unsigned int'. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli ---

[PATCH 05/15] batman-adv: use list_for_each_entry_safe

2016-05-03 Thread Antonio Quartulli
From: Geliang Tang Use list_for_each_entry_safe() instead of list_for_each_safe() to simplify the code. Signed-off-by: Geliang Tang Acked-by: Antonio Quartulli Reviewed-by: Sven Eckelmann Signed-off-by: Marek

[PATCH 01/15] MAINTAINERS: Mark BATMAN ADVANCED mailing list as moderated

2016-05-03 Thread Antonio Quartulli
From: Sven Eckelmann The mailing list of b.a.t.m@lists.open-mesh.org is moderated for non-subscribers and non-whitelisted addresses. Such mails will be delayed but the sender will not be informed about the moderation. Signed-off-by: Sven Eckelmann

Re: [PATCH] fix infoleak in wireless

2016-05-03 Thread Greg Kroah-Hartman
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Tue, May 03, 2016 at 04:47:16PM -0400, Kangjie Lu wrote: > Hi Greg, > > Could you please take a look at this issue. > mac_addr is not initialized is some implementations of dump_station(), which >

[no subject]

2016-05-03 Thread t...@a.microletter.net
�S著中��的高速�l展,不少企�I都在��子商�者@��行�I�l展�_�恚�市�龈�得非常激烈。 此�r,如何及�r�蚀_的找到客�粜畔�,��於企�I�碚f��得��常重要,因�檫@不�H可以���s�r�g成本,更重要的是可以��占先�C。 如果你缺少客�簦�也�]有客�糍Y料,那�N你已��慢你的同行一步了。 �]有捷�剑�只有付出汗水,天�崃四闳绾稳フ铱��簦� 很多人�x�窳穗���,�Q定付出自己的口舌,但�Y料�哪��恚}又出�F了,又一次迷失在了�ふ铱��舻碾��F中。

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-03 Thread Dean Jenkins
On 03/05/16 15:42, David B. Robins wrote: I don't think the first one is giving you problems (except as triggered by the second) but I had concerns about the second myself (and emailed the author off-list, but received no reply), and we did not take that commit for our own product. Sorry,

Re: [PATCH] fix infoleak in wireless

2016-05-03 Thread Greg Kroah-Hartman
On Tue, May 03, 2016 at 05:11:07PM -0400, Kangjie Lu wrote: > Opps, I did not notice the patch is not attached. > > From 34a82a734388d07eb10f91770f86938e38f7575a Mon Sep 17 00:00:00 2001 > From: Kangjie Lu > Date: Tue, 3 May 2016 14:15:18 -0400 > Subject: [PATCH] fix infoleak in

[PATCH 03/15] batman-adv: Start new development cycle

2016-05-03 Thread Antonio Quartulli
From: Simon Wunderlich Signed-off-by: Simon Wunderlich Signed-off-by: Antonio Quartulli --- net/batman-adv/main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/main.h

pull request: batman-adv 20160504

2016-05-03 Thread Antonio Quartulli
Hello David, this is a pull request intended for net-next. In this batch you don't have any patch that depends on our fixes, therefore you can safely merge it even if the net tree has not been merged yet. In this patchset you basically have some cleanup work, code refactoring, style fixes and

[PATCH 04/15] batman-adv: use static string for table headers

2016-05-03 Thread Antonio Quartulli
Use a static string when showing table headers rather then a nonsense parametric one with fixed arguments. It is easier to grep and it does not need to be recomputed at runtime each time. Reported-by: Joe Perches Signed-off-by: Antonio Quartulli

[PATCH] fix infoleak in rtnetlink

2016-05-03 Thread Kangjie Lu
The stack object “map” has a total size of 32 bytes. Its last 4 bytes are padding generated by compiler. These padding bytes are not initialized and sent out via “nla_put”. Signed-off-by: Kangjie Lu --- net/core/rtnetlink.c | 18 ++ 1 file changed, 10

Re: [PATCH net v1] ipv6/ila: fix nlsize calculation for lwtunnel

2016-05-03 Thread David Miller
From: Nicolas Dichtel Date: Tue, 3 May 2016 09:58:27 +0200 > The handler 'ila_fill_encap_info' adds one attribute: ILA_ATTR_LOCATOR. > > Fixes: 65d7ab8de582 ("net: Identifier Locator Addressing module") > CC: Tom Herbert > Signed-off-by:

[PATCH net] bridge: fix igmp / mld query parsing

2016-05-03 Thread Linus Lüssing
With the newly introduced helper functions the skb pulling is hidden in the checksumming function - and undone before returning to the caller. The IGMP and MLD query parsing functions in the bridge still assumed that the skb is pointing to the beginning of the IGMP/MLD message while it is now

Re: [PATCH] fix infoleak in wireless

2016-05-03 Thread Johannes Berg
On Tue, 2016-05-03 at 16:40 -0400, Kangjie Lu wrote: > The 6-bytes array “mac_addr” is not initialized in the dump_station > implementations of > “drivers/staging/wilc1000/wilc_wfi_cfgoperations.c” > and “drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c”, so all 6 > bytes may be leaked. Like I

Re: [PATCH nf-next 3/9] netfilter: conntrack: don't attempt to iterate over empty table

2016-05-03 Thread Pablo Neira Ayuso
On Tue, May 03, 2016 at 07:55:59PM +0200, Florian Westphal wrote: > > Otherwise, every time we'll go container destruction path, we'll hit > > slow path, ie. scanning the full table. > > Yes, but I see no other choice. Fair enough, will place this in nf-next, thanks.

Re: [Question] Should `CAP_NET_ADMIN` be needed when opening `/dev/ppp`?

2016-05-03 Thread Richard Weinberger
On Tue, May 3, 2016 at 12:12 PM, Guillaume Nault wrote: > On Sun, May 01, 2016 at 09:38:57PM +0800, Wang Shanker wrote: >> static int ppp_open(struct inode *inode, struct file *file) >> { >> /* >>* This could (should?) be enforced by the permissions on

Re: [Intel-wired-lan] NULL dereference on v4.1.x while enabling VF

2016-05-03 Thread William Dauchy
Hello Don, Thank you for your reply. On Mon, May 2, 2016 at 11:33 PM, Skidmore, Donald C wrote: > Thanks for reporting the dereference. Could you provide a little more detail > on how you created this issue? Are you just running the two commands (ip, >

Re: [Question] Should `CAP_NET_ADMIN` be needed when opening `/dev/ppp`?

2016-05-03 Thread Hannes Frederic Sowa
On Tue, May 3, 2016, at 12:35, Richard Weinberger wrote: > On Tue, May 3, 2016 at 12:12 PM, Guillaume Nault > wrote: > > On Sun, May 01, 2016 at 09:38:57PM +0800, Wang Shanker wrote: > >> static int ppp_open(struct inode *inode, struct file *file) > >> { > >> /* > >>

Re: [net-next PATCH v2 5/9] mlx4: Add support for UDP tunnel segmentation with outer checksum offload

2016-05-03 Thread Or Gerlitz
On 5/2/2016 6:41 PM, Alexander Duyck wrote: >Just one more piece to clarify... in the general case (e.g inner >packet size 1.5k...64k), the last segment would not have the same >length as the other segments, what happens on that case? Actually in the case of GSO partial we have go through the

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-03 Thread Dean Jenkins
On 03/05/16 11:04, Guodong Xu wrote: On 3 May 2016 at 17:23, Dean Jenkins wrote: On 03/05/16 05:55, John Stultz wrote: In testing with HiKey, we found that since commit 3f30b158eba5c60 (asix: On RX avoid creating bad Ethernet frames), we're seeing lots of noise during

Re: [PATCH next-next 2/7] gre: Move utility functions to common headers

2016-05-03 Thread Jiri Benc
On Fri, 29 Apr 2016 17:12:16 -0700, Tom Herbert wrote: > - iptunnel_pull_header is taken out of gre_parse_header. This is now > done by caller. The header length is returned from gre_parse_header > in an int* argument. Seems we conflicted here, I've done the same for net.git to fix ICMP

[PATCH] drivers: net: emac: add Atheros AR8035 phy initialization code

2016-05-03 Thread Christian Lamparter
This patch adds the phy initialization code for Qualcomm Atheros AR8035 phy. This configuration is found in the Cisco Meraki MR24. Signed-off-by: Christian Lamparter --- drivers/net/ethernet/ibm/emac/phy.c | 26 ++ 1 file changed, 26

Re: [PATCH net-next v2] block/drbd: use nla_put_u64_64bit()

2016-05-03 Thread Nicolas Dichtel
Le 03/05/2016 12:06, Lars Ellenberg a écrit : > On Tue, May 03, 2016 at 11:39:18AM +0200, Nicolas Dichtel wrote: >> Two new handlers have been defined in genl_magic_ headers: >> - __field2: the corresponding nla_put() function (nla_put_flag()) takes >> only two args >> - __field4:

[PATCH net-next] gre: change gre_parse_header to return the header length

2016-05-03 Thread Jiri Benc
It's easier for gre_parse_header to return the header length instead of filing it into a parameter. That way, the callers that don't care about the header length can just check whether the returned value is lower than zero. In gre_err, the tunnel header must not be pulled. See commit b7f8fe251e46

Re: [PATCH 0/2] sctp: Add GSO support

2016-05-03 Thread Marcelo Ricardo Leitner
On Mon, May 02, 2016 at 07:16:14PM -0400, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Fri, 29 Apr 2016 18:33:31 -0300 > > > This patchset adds sctp GSO support. > > > > Performance tests indicates that increases throughput by 10% if using > > bigger

Re: [PATCH] net: fec: only clear a queue's work bit if the queue was emptied

2016-05-03 Thread Lucas Stach
Am Dienstag, den 03.05.2016, 16:38 +0200 schrieb Uwe Kleine-König: > In the receive path a queue's work bit was cleared unconditionally even > if fec_enet_rx_queue only read out a part of the available packets from > the hardware. This resulted in not reading any packets in the next napi > turn

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-03 Thread David B. Robins
On 2016-05-03 00:55, John Stultz wrote: In testing with HiKey, we found that since commit 3f30b158eba5c60 (asix: On RX avoid creating bad Ethernet frames), we're seeing lots of noise during network transfers: [ 239.027993] asix 1-1.1:1.0 eth0: asix_rx_fixup() Data Header synchronisation was

Re: pull request [net]: batman-adv 20160430

2016-05-03 Thread Antonio Quartulli
On Tue, May 03, 2016 at 12:18:13AM -0400, David Miller wrote: > Pulled, thanks Antonio. Thanks a lot David. We now have some patches for net-next that somewhat depend on the fixes you have recently pulled. Do you have any plan on merging net into net-next in the following days ? I am asking

[PATCH] gre6: add Kconfig dependency for NET_IPGRE_DEMUX

2016-05-03 Thread Arnd Bergmann
The ipv6 gre implementation was cleaned up to share more code with the ipv4 version, but it can be enabled even when NET_IPGRE_DEMUX is disabled, resulting in a link error: net/built-in.o: In function `gre_rcv': :(.text+0x17f5d0): undefined reference to `gre_parse_header' ERROR:

Re: Davicom DM9162 PHY supported in the kernel?

2016-05-03 Thread Amr Bekhit
Hi Florian, Thanks for your response. I had look through the bootup messages on my Linux board and saw the following: [5.398437] libphy: MACB_mii_bus: probed [5.484375] macb f802c000.ethernet eth0: Cadence MACB rev 0x0001010c at 0xf802c000 irq 39 (70:b3:d5:ba:b8:90) [5.492187] macb

[PATCH] net: fec: only clear a queue's work bit if the queue was emptied

2016-05-03 Thread Uwe Kleine-König
In the receive path a queue's work bit was cleared unconditionally even if fec_enet_rx_queue only read out a part of the available packets from the hardware. This resulted in not reading any packets in the next napi turn and so packets were delayed or lost. The obvious fix is to only clear a

[PATCH net-next 2/3] gre: move iptunnel_pull_header down to ipgre_rcv

2016-05-03 Thread Jiri Benc
This will allow to make the pull dependent on the tunnel type. Signed-off-by: Jiri Benc --- net/ipv4/ip_gre.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c index 8260a707b9b8..8f377dad5489 100644 ---

[PATCH net-next 3/3] gre: receive also TEB packets for lwtunnels

2016-05-03 Thread Jiri Benc
For ipgre interfaces in collect metadata mode, receive also traffic with encapsulated Ethernet headers. The lwtunnel users are supposed to sort this out correctly. This allows to have mixed Ethernet + L3-only traffic on the same lwtunnel interface. This is the same way as VXLAN-GPE behaves. To

[PATCH net-next 1/3] gre: remove superfluous pskb_may_pull

2016-05-03 Thread Jiri Benc
The call to gre_parse_header is either followed by iptunnel_pull_header, or in the case of ICMP error path, the actual header is not accessed at all. In the first case, iptunnel_pull_header will call pskb_may_pull anyway and it's pointless to do it twice. The only difference is what call will

[PATCH net-next 0/3] gre: receive also TEB packets for lwtunnels

2016-05-03 Thread Jiri Benc
NOTE: this patchset needs net merged to net-next. This allows lwtunnel users to get also packets with ETH_P_TEB protocol specified in GRE header through an ipgre interface. There's really nothing special about these packets in the case of lwtunnels - it's just an inner protocol like any other.

[PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

2016-05-03 Thread Florian Westphal
Replace all trans_start updates with netif_trans_update helper. change was done via spatch: struct net_device *d; @@ - d->trans_start = jiffies + netif_trans_update(d) Compile tested only. Cc: user-mode-linux-de...@lists.sourceforge.net Cc: linux-xte...@linux-xtensa.org Cc:

[PATCH net v2] vlan: Propagate MAC address to VLANs unless explicitly set

2016-05-03 Thread Mike Manning
The MAC address of the physical interface is only copied to the VLAN when it is first created, resulting in an inconsistency after MAC address changes of only newly created VLANs having an up-to-date MAC. Continuing to inherit the MAC address unless explicitly changed for the VLAN allows IPv6

Re: [PATCH net-next] gre: change gre_parse_header to return the header length

2016-05-03 Thread Tom Herbert
On Tue, May 3, 2016 at 6:00 AM, Jiri Benc wrote: > It's easier for gre_parse_header to return the header length instead of > filing it into a parameter. That way, the callers that don't care about the > header length can just check whether the returned value is lower than zero.

Re: [PATCH net] vlan: Propagate MAC address changes properly

2016-05-03 Thread Mike Manning
On 05/03/2016 05:16 AM, David Miller wrote: > From: Mike Manning > Date: Sat, 30 Apr 2016 11:32:37 +0100 > >> The MAC address of the physical interface is only copied to the VLAN >> when it is first created, resulting in an inconsistency after MAC >> address changes of only

Re: [PATCH v5 09/21] IB/hns: Add hca support

2016-05-03 Thread Wei Hu (Xavier)
On 2016/4/30 12:33, Or Gerlitz wrote: On Wed, Apr 27, 2016 at 6:34 AM, oulijun wrote: On 2016/4/26 22:25, Jiri Pirko wrote: Tue, Apr 26, 2016 at 04:18:21PM CEST, l...@kernel.org wrote: I appreciate your keen eye. this code is meant for ARM64bit therefore should

[PATCH net-next 1/5] dmfe: kill DEVICE define

2016-05-03 Thread Florian Westphal
use net_device directly. Compile tested, objdiff shows no changes. Cc: linux-par...@vger.kernel.org Signed-off-by: Florian Westphal --- drivers/net/ethernet/dec/tulip/dmfe.c | 39 --- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git

[PATCH net-next 2/5] drivers: replace dev->trans_start accesses with dev_trans_start

2016-05-03 Thread Florian Westphal
a trans_start struct member exists twice: - in struct net_device (legacy) - in struct netdev_queue Instead of open-coding dev->trans_start usage to obtain the current trans_start value, use dev_trans_start() instead. This is not exactly the same, as dev_trans_start also considers the trans_start

[PATCH net-next 3/5] netdevice: add helper to update trans_start

2016-05-03 Thread Florian Westphal
trans_start exists twice: - as member of net_device (legacy) - as member of netdev_queue In order to get rid of the legacy case, add a helper for the dev->trans_update (this patch), then convert spots that do dev->trans_start = jiffies to use this helper (next patch). This would then allow us

  1   2   >