[PATCH net v2 0/3] Documentation: dsa: misc fixes

2016-05-24 Thread Florian Fainelli
Hi David, Here are some miscelaneous documentation fixes for DSA, I targeted "net" because these are not functional code changes, but still documentation fixes per-se. Changes in v2: - reword what the port_vlan_filtering is about based on feedback from Vivien and Ido Florian Fainelli (3):

[PATCH net v2 1/3] Documentation: networking: dsa: Remove poll_link description

2016-05-24 Thread Florian Fainelli
This function has been removed in 4baee937b8d5 ("net: dsa: remove DSA link polling") in favor of using the PHYLIB polling mechanism. Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli --- Documentation/networking/dsa/dsa.txt |

[PATCH net v2 2/3] Documentation: networking: dsa: Remove priv_size description

2016-05-24 Thread Florian Fainelli
We no longer have a priv_size structure member since 5feebd0a8a79 ("net: dsa: Remove allocation of driver private memory") Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli --- Documentation/networking/dsa/dsa.txt | 2 -- 1

[PATCH net v2 3/3] Documentation: networking: dsa: Describe port_vlan_filtering

2016-05-24 Thread Florian Fainelli
Described what the port_vlan_filtering function is supposed to accomplish. Fixes: fb2dabad69f0 ("net: dsa: support VLAN filtering switchdev attr") Signed-off-by: Florian Fainelli --- Documentation/networking/dsa/dsa.txt | 10 ++ 1 file changed, 10 insertions(+)

Re: [RFC 08/12] ipv6: introduce neighbour discovery ops

2016-05-24 Thread YOSHIFUJI Hideaki
Hi, Alexander Aring wrote: > This patch introduces neighbour discovery ops callback structure. The > idea is to separate the handling for 6LoWPAN into the 6lowpan module. > > These callback offers 6lowpan different handling, such as 802.15.4 short > address handling or RFC6775 (Neighbor

Re: [PATCH] net: alx: use custom skb allocator

2016-05-24 Thread Feng Tang
Hi Jarod, On Fri, May 20, 2016 at 02:26:57PM -0400, Jarod Wilson wrote: > On Fri, May 20, 2016 at 03:56:23PM +0800, Feng Tang wrote: > > Hi, > > > > Please ignore this patch. > > > > I found the problem and made the patch with kernel 4.4 with Ubuntu 12.04 > > on Lenovo Y580. > > > > After

Re: [RFC 04/12] ndisc: get rid off dev parameter in ndisc_opt_addr_space

2016-05-24 Thread YOSHIFUJI Hideaki
Alexander Aring wrote: > This patch removes the net_device parameter from ndisc_opt_addr_space > function. This can be useful for calling such functionality which > doesn't depends on dev parameter. For current existing functionality > which depends on dev parameter, we introduce

Re: [RFC 00/12] 6lowpan: introduce 6lowpan-nd

2016-05-24 Thread YOSHIFUJI Hideaki
Hi. Alexander Aring wrote: > Hi, > > this patch series introduces the ndisc ops callback structure to add different > handling for IPv6 neighbour discovery cache functionality. It implements at > first > the two following use-cases: > > - 6CO handling as userspace option (For all 6LoWPAN

Re: [PATCH v2] ethernet:arc: Fix racing of TX ring buffer

2016-05-24 Thread Lino Sanfilippo
Francois, Shuyu, this is the patch with the discussed changes. Shuyu it would be great if you could test this one. If it passes and there are no further objections I will resend it as a regular patch (including commit message, etc.) to the mailing list. diff --git

Re: [PATCH net v2] fou: avoid using sk_user_data before it is initialised

2016-05-24 Thread David Miller
From: Cong Wang Date: Mon, 23 May 2016 14:05:17 -0700 > On Mon, May 23, 2016 at 1:59 PM, David Miller wrote: >> From: Simon Horman >> Date: Fri, 20 May 2016 14:57:17 +0900 >> >>> During initialisation sk->sk_user_data

Re: [net PATCH v2 1/1] net sched actions: policer missing timestamp processing

2016-05-24 Thread David Miller
From: Jamal Hadi Salim Date: Mon, 23 May 2016 21:07:20 -0400 > From: Jamal Hadi Salim > > Policer was not dumping or updating timestamps > > Signed-off-by: Jamal Hadi Salim Applied.

Re: [RFC PATCH 1/7] fou: Get net from sock_net if dev_net unavailable

2016-05-24 Thread Tom Herbert
On Tue, May 24, 2016 at 3:01 PM, David Miller wrote: > From: Tom Herbert > Date: Mon, 23 May 2016 15:48:20 -0700 > >> diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c >> index 5f9207c..96260c6 100644 >> --- a/net/ipv4/fou.c >> +++ b/net/ipv4/fou.c >> @@

Re: [ethtool 0/3][pull request] Intel Wired LAN Driver Updates 2016-05-03

2016-05-24 Thread Jeff Kirsher
On Wed, 2016-05-04 at 09:44 -0700, Jeff Kirsher wrote: > This series contains updates to ixgbe in ethtool. > > Preethi adds missing device IDs and mac_type definitions, also updated > the display registers for x550, x550em_x/a.  Cleaned up the format string > storage by taking advantage of "for"

Re: bpf: use-after-free in array_map_alloc

2016-05-24 Thread Vlastimil Babka
[+CC Marco who reported the CVE, forgot that earlier] On 05/23/2016 11:35 PM, Tejun Heo wrote: Hello, Can you please test whether this patch resolves the issue? While adding support for atomic allocations, I reduced alloc_mutex covered region too much. Thanks. Ugh, this makes the code even

iputils ping -I interface no longer functional for ipv4 addresses (unknown iface)

2016-05-24 Thread Chris Severance
% ping -V ping utility, iputils-s20160308 # https://www.archlinux.org/packages/core/x86_64/iputils/ % ping -I enp3s0 192.168.50.1 PING 192.168.50.1 (192.168.50.1) from 192.168.50.10 enp3s0: 56(84) bytes of data. 64 bytes from 192.168.50.1: icmp_seq=1 ttl=64 time=0.127 ms % ip addr 2: enp3s0:

Re: [PATCH 0/2 (linux-stable-4.5.y)] net: stmmac: MDIO fixes

2016-05-24 Thread Giuseppe CAVALLARO
On 5/23/2016 5:36 PM, Greg KH wrote: On Mon, May 23, 2016 at 03:17:41PM +0200, Giuseppe Cavallaro wrote: These patches port some recent fixes for linux-4.5.y stable branch. They fix the MDIO settings trying to cover the all possible scenario when the stmmac is connected to a real transceiver or

[PATCH] brcmfmac: fix setting AP channel with new firmwares

2016-05-24 Thread Rafał Miłecki
Firmware for new chipsets is based on a new major version of code internally maintained at Broadcom. E.g. brcmfmac4366b-pcie.bin (used for BCM4366B1) is based on 10.10.69.3309 while brcmfmac43602-pcie.ap.bin was based on 7.35.177.56. Currently setting AP 5 GHz channel doesn't work reliably with

[PATCH RESEND 8/8] af_unix: charge buffers to kmemcg

2016-05-24 Thread Vladimir Davydov
Unix sockets can consume a significant amount of system memory, hence they should be accounted to kmemcg. Since unix socket buffers are always allocated from process context, all we need to do to charge them to kmemcg is set __GFP_ACCOUNT in sock->sk_allocation mask. Signed-off-by: Vladimir

Re: [PATCH v5 2/2] skb_array: ring test

2016-05-24 Thread Jesper Dangaard Brouer
On Mon, 23 May 2016 23:52:47 +0300 "Michael S. Tsirkin" wrote: > On Mon, May 23, 2016 at 03:09:18PM +0200, Jesper Dangaard Brouer wrote: > > On Mon, 23 May 2016 13:43:46 +0300 > > "Michael S. Tsirkin" wrote: > > > > > Add ringtest based unit test for skb

Re: [PATCH v5 2/2] skb_array: ring test

2016-05-24 Thread Michael S. Tsirkin
On Tue, May 24, 2016 at 12:28:09PM +0200, Jesper Dangaard Brouer wrote: > On Mon, 23 May 2016 23:52:47 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, May 23, 2016 at 03:09:18PM +0200, Jesper Dangaard Brouer wrote: > > > On Mon, 23 May 2016 13:43:46 +0300 > > > "Michael S.

[PATCH RESEND 5/8] mm: memcontrol: teach uncharge_list to deal with kmem pages

2016-05-24 Thread Vladimir Davydov
Page table pages are batched-freed in release_pages on most architectures. If we want to charge them to kmemcg (this is what is done later in this series), we need to teach mem_cgroup_uncharge_list to handle kmem pages. Signed-off-by: Vladimir Davydov --- mm/memcontrol.c

[PATCH RESEND 3/8] mm: memcontrol: cleanup kmem charge functions

2016-05-24 Thread Vladimir Davydov
- Handle memcg_kmem_enabled check out to the caller. This reduces the number of function definitions making the code easier to follow. At the same time it doesn't result in code bloat, because all of these functions are used only in one or two places. - Move __GFP_ACCOUNT check to the

[PATCH RESEND 1/8] mm: remove pointless struct in struct page definition

2016-05-24 Thread Vladimir Davydov
... to reduce indentation level thus leaving more space for comments. Signed-off-by: Vladimir Davydov --- include/linux/mm_types.h | 68 +++- 1 file changed, 32 insertions(+), 36 deletions(-) diff --git

[RFC PATCH V3 1/3] vhost: introduce vhost memory accessors

2016-05-24 Thread Jason Wang
This patch introduces vhost memory accessors which were just wrappers for userspace address access helpers. This is a requirement for vhost device iotlb implementation which will add iotlb translations in those accessors. Signed-off-by: Jason Wang --- drivers/vhost/net.c

[RFC PATCH V3 0/3] basic device IOTLB support

2016-05-24 Thread Jason Wang
This patch tries to implement an device IOTLB for vhost. This could be used with for co-operation with userspace IOMMU implementation (qemu) for a secure DMA environment (DMAR) in guest. The idea is simple. When vhost meets an IOTLB miss, it will request the assistance of userspace to do the

[RFC PATCH V3 2/3] vhost: convert pre sorted vhost memory array to interval tree

2016-05-24 Thread Jason Wang
Current pre-sorted memory region array has some limitations for future device IOTLB conversion: 1) need extra work for adding and removing a single region, and it's expected to be slow because of sorting or memory re-allocation. 2) need extra work of removing a large range which may intersect

[PATCH net 1/1] qed: Reset the enable flag for eth protocol.

2016-05-24 Thread Sudarsana Reddy Kalluru
This patch fixes the coding error in determining the enable flag for the application/protocol. The enable flag should be set for all protocols but the eth. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz ---

Re: [iproute2 1/1] tc simple action: bug fix

2016-05-24 Thread Daniel Borkmann
On 05/24/2016 03:04 AM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim Failed compile m_simple.c: In function ‘parse_simple’: m_simple.c:154:6: warning: too many arguments for format [-Wformat-extra-args] *argv); ^ m_simple.c:103:14: warning: unused variable

[PATCH RESEND 7/8] pipe: account to kmemcg

2016-05-24 Thread Vladimir Davydov
Pipes can consume a significant amount of system memory, hence they should be accounted to kmemcg. This patch marks pipe_inode_info and anonymous pipe buffer page allocations as __GFP_ACCOUNT so that they would be charged to kmemcg. Note, since a pipe buffer page can be "stolen" and get reused

[PATCH RESEND 6/8] arch: x86: charge page tables to kmemcg

2016-05-24 Thread Vladimir Davydov
Page tables can bite a relatively big chunk off system memory and their allocations are easy to trigger from userspace, so they should be accounted to kmemcg. This patch marks page table allocations as __GFP_ACCOUNT for x86. Note we must not charge allocations of kernel page tables, because they

[PATCH RESEND 0/8] More stuff to charge to kmemcg

2016-05-24 Thread Vladimir Davydov
[resending with all relevant lists in Cc] Hi, This patch implements per kmemcg accounting of page tables (x86-only), pipe buffers, and unix socket buffers. Basically, this is v2 of my earlier attempt [1], addressing comments by Andrew, namely: lack of comments to non-standard _mapcount usage,

[PATCH RESEND 4/8] mm: charge/uncharge kmemcg from generic page allocator paths

2016-05-24 Thread Vladimir Davydov
Currently, to charge a non-slab allocation to kmemcg one has to use alloc_kmem_pages helper with __GFP_ACCOUNT flag. A page allocated with this helper should finally be freed using free_kmem_pages, otherwise it won't be uncharged. This API suits its current users fine, but it turns out to be

[PATCH RESEND 2/8] mm: clean up non-standard page->_mapcount users

2016-05-24 Thread Vladimir Davydov
- Add a proper comment to page->_mapcount. - Introduce a macro for generating helper functions. - Place all special page->_mapcount values next to each other so that readers can see all possible values and so we don't get duplicates. Signed-off-by: Vladimir Davydov

Re: [PATCH 8/8] af_unix: charge buffers to kmemcg

2016-05-24 Thread Vladimir Davydov
[adding netdev to Cc] On Mon, May 23, 2016 at 01:20:29PM +0300, Vladimir Davydov wrote: > Unix sockets can consume a significant amount of system memory, hence > they should be accounted to kmemcg. > > Since unix socket buffers are always allocated from process context, > all we need to do to

[RFC PATCH V3 3/3] vhost: device IOTLB API

2016-05-24 Thread Jason Wang
This patch tries to implement an device IOTLB for vhost. This could be used with for co-operation with userspace(qemu) implementation of DMA remapping. The idea is simple, cache the translation in a software device IOTLB (interval tree) implementation in vhost and make vhost_net file descriptor

Re: [iproute2 1/1] tc simple action: bug fix

2016-05-24 Thread Jamal Hadi Salim
On 16-05-24 06:30 AM, Daniel Borkmann wrote: On 05/24/2016 03:04 AM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim Failed compile m_simple.c: In function ‘parse_simple’: m_simple.c:154:6: warning: too many arguments for format [-Wformat-extra-args] *argv); ^

[iproute2 PATCH v2 1/1] vv4.6.0

2016-05-24 Thread Jamal Hadi Salim
From: Stephen Hemminger --- include/SNAPSHOT.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/SNAPSHOT.h b/include/SNAPSHOT.h index 9220f77..cc67058 100644 --- a/include/SNAPSHOT.h +++ b/include/SNAPSHOT.h @@ -1 +1 @@ -static const char

[iproute2 PATCH v2 1/1] tc simple action: bug fix

2016-05-24 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Failed compile m_simple.c: In function ‘parse_simple’: m_simple.c:154:6: warning: too many arguments for format [-Wformat-extra-args] *argv); ^ m_simple.c:103:14: warning: unused variable ‘maybe_bind’ [-Wunused-variable] Reported-by: Daniel

Re: [PATCH iproute2 v3 1/5] add missing if_macsec.h header from kernel

2016-05-24 Thread Sabrina Dubroca
2016-05-23, 16:07:20 -0700, Stephen Hemminger wrote: > On Wed, 18 May 2016 17:35:09 +0200 > Sabrina Dubroca wrote: > > > Signed-off-by: Sabrina Dubroca > > Acked-by: Phil Sutter > > This header already exists in master branch of

[PULL] vhost: cleanups and fixes

2016-05-24 Thread Michael S. Tsirkin
The following changes since commit 2dcd0af568b0cf583645c8a317dd12e344b1c72a: Linux 4.6 (2016-05-15 15:43:13 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to

Re: [PATCH RESEND 8/8] af_unix: charge buffers to kmemcg

2016-05-24 Thread Eric Dumazet
On Tue, 2016-05-24 at 11:49 +0300, Vladimir Davydov wrote: > Unix sockets can consume a significant amount of system memory, hence > they should be accounted to kmemcg. > > Since unix socket buffers are always allocated from process context, > all we need to do to charge them to kmemcg is set

Re: [PATCH iproute2 v3 5/5] ip: add MACsec support

2016-05-24 Thread Sabrina Dubroca
Hello Stephen, 2016-05-23, 16:21:42 -0700, Stephen Hemminger wrote: > On Wed, 18 May 2016 17:35:13 +0200 > Sabrina Dubroca wrote: > > > + > > +static void print_rx_sc(const char *prefix, __u64 sci, __u8 active, struct > > rtattr *rxsc_stats, struct rtattr *sa) > > +{ > >

Re: [PATCH v5 2/2] skb_array: ring test

2016-05-24 Thread Michael S. Tsirkin
On Tue, May 24, 2016 at 12:28:09PM +0200, Jesper Dangaard Brouer wrote: > On Mon, 23 May 2016 23:52:47 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, May 23, 2016 at 03:09:18PM +0200, Jesper Dangaard Brouer wrote: > > > On Mon, 23 May 2016 13:43:46 +0300 > > > "Michael S.

Re: [PATCH v5 2/2] skb_array: ring test

2016-05-24 Thread Michael S. Tsirkin
On Tue, May 24, 2016 at 12:28:09PM +0200, Jesper Dangaard Brouer wrote: > On Mon, 23 May 2016 23:52:47 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, May 23, 2016 at 03:09:18PM +0200, Jesper Dangaard Brouer wrote: > > > On Mon, 23 May 2016 13:43:46 +0300 > > > "Michael S.

Re: [PATCH RESEND 7/8] pipe: account to kmemcg

2016-05-24 Thread Eric Dumazet
On Tue, 2016-05-24 at 11:49 +0300, Vladimir Davydov wrote: > Pipes can consume a significant amount of system memory, hence they > should be accounted to kmemcg. > > This patch marks pipe_inode_info and anonymous pipe buffer page > allocations as __GFP_ACCOUNT so that they would be charged to

Re: [iproute2 PATCH v2 1/1] vv4.6.0

2016-05-24 Thread Jamal Hadi Salim
More git foo. I have no idea how this went out ;-> Please ignore this but not the other. cheers, jamal On 16-05-24 07:52 AM, Jamal Hadi Salim wrote: From: Stephen Hemminger --- include/SNAPSHOT.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

RE: [RFC] net: remove busylock

2016-05-24 Thread David Laight
From: Jesper Dangaard Brouer > Sent: 20 May 2016 18:50 ... > If would be cool if you could run a test with removed busylock and > allow HTB to bulk dequeue. (Without having looked ) Could you have two queues and separate queue and dequeue locks. The enqueue code would acquire the enqueue

Re: [RFC] net: remove busylock

2016-05-24 Thread Eric Dumazet
On Tue, 2016-05-24 at 13:50 +, David Laight wrote: > From: Jesper Dangaard Brouer > > Sent: 20 May 2016 18:50 > ... > > If would be cool if you could run a test with removed busylock and > > allow HTB to bulk dequeue. > > (Without having looked ) > Could you have two queues and separate

Re: [PATCH net 3/3] Documentation: networking: dsa: Describe port_vlan_filtering

2016-05-24 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > Described what the port_vlan_filtering function is supposed to > accomplish. > > Fixes: fb2dabad69f0 ("net: dsa: support VLAN filtering switchdev attr") > Signed-off-by: Florian Fainelli > --- >

Re: [PATCH net 2/3] Documentation: networking: dsa: Remove priv_size description

2016-05-24 Thread Vivien Didelot
Florian Fainelli writes: > We no longer have a priv_size structure member since 5feebd0a8a79 ("net: > dsa: Remove allocation of driver private memory") > > Signed-off-by: Florian Fainelli Reviewed-by: Vivien Didelot

Re: [PATCH net 1/3] Documentation: networking: dsa: Remove poll_link description

2016-05-24 Thread Vivien Didelot
Florian Fainelli writes: > This function has been removed in 4baee937b8d5 ("net: dsa: remove DSA > link polling") in favor of using the PHYLIB polling mechanism. > > Signed-off-by: Florian Fainelli Reviewed-by: Vivien Didelot

[PATCH v2] tipc: fix potential null pointer dereferences in some compat functions

2016-05-24 Thread Baozeng Ding
Before calling the nla_parse_nested function, make sure the pointer to the attribute is not null. This patch fixes several potential null pointer dereference vulnerabilities in the tipc netlink functions. Signed-off-by: Baozeng Ding --- v2: declare local variable as reverse

Re: [PATCH net 3/3] Documentation: networking: dsa: Describe port_vlan_filtering

2016-05-24 Thread Ido Schimmel
Hi Vivien, Florian, Tue, May 24, 2016 at 05:32:33PM IDT, vivien.dide...@savoirfairelinux.com wrote: >Hi Florian, > >Florian Fainelli writes: > >> Described what the port_vlan_filtering function is supposed to >> accomplish. >> >> Fixes: fb2dabad69f0 ("net: dsa: support VLAN

kernel panic with kernel 3.14.70, LVS on keepalived restart

2016-05-24 Thread Patrick Schaaf
Dear LVS users / netdev readers, today I've got a pretty peculiar problem. I've been running 3.14.48 (and some earlier 3.14 kernels) for a long time now in an LVS / keepalived driven loadbalancing cluster. See below for more detail on the setup. Today I started to upgrade to the current

[PATCH net 0/2] Fix spinlock usage in HWBM

2016-05-24 Thread Gregory CLEMENT
Hi, these two patches fix spinlock related issues introduced in v4.6. They have been reported by Russell King and Jean-Jacques Hiblot. Thanks to them, Gregory Gregory CLEMENT (2): net: mvneta: Fix lacking spinlock initialization net: hwbm: Fix unbalanced spinlock in error case

Re: bpf: use-after-free in array_map_alloc

2016-05-24 Thread Tejun Heo
Hello, On Tue, May 24, 2016 at 10:40:54AM +0200, Vlastimil Babka wrote: > [+CC Marco who reported the CVE, forgot that earlier] > > On 05/23/2016 11:35 PM, Tejun Heo wrote: > > Hello, > > > > Can you please test whether this patch resolves the issue? While > > adding support for atomic

[PATCH net 1/2] net: mvneta: Fix lacking spinlock initialization

2016-05-24 Thread Gregory CLEMENT
The spinlock used by the hwbm functions must be initialized by the network driver. This commit fixes this lack and the following erros when lockdep is enabled: INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. []

[PATCH net 2/2] net: hwbm: Fix unbalanced spinlock in error case

2016-05-24 Thread Gregory CLEMENT
When hwbm_pool_add exited in error the spinlock was not released. This patch fixes this issue. Fixes: 8cb2d8bf57e6 ("net: add a hardware buffer management helper API") Reported-by: Jean-Jacques Hiblot Cc: Signed-off-by: Gregory CLEMENT

Re: [RFC PATCH 7/7] tou: Support for GSO

2016-05-24 Thread Alexander Duyck
On Mon, May 23, 2016 at 3:48 PM, Tom Herbert wrote: > Add SKB_GSO_TOU. In udp[64]_ufo_fragment check for SKB_GSO_TOU. If this > is set call skb_udp_tou_segment. skb_udp_tou_segment is very similar > to skb_udp_tunnel_segment except that we only need to deal with the > L4

Re: Davicom DM9162 PHY supported in the kernel?

2016-05-24 Thread Amr Bekhit
Hi Andrew, > How about adding a printk() in genphy_read_status(). Would you be able to point me to some more information about these status bits, please? I'm struggling to find information about what they are, where I read them from, etc. I'm happy to write some debug printk's in the code, I

Re: [PATCH v5 2/2] skb_array: ring test

2016-05-24 Thread Jesper Dangaard Brouer
On Tue, 24 May 2016 12:28:09 +0200 Jesper Dangaard Brouer wrote: > I do like perf, but it does not answer my questions about the > performance of this queue. I will code something up in my own > framework[2] to answer my own performance questions. > > Like what is be minimum

Re: Davicom DM9162 PHY supported in the kernel?

2016-05-24 Thread Andrew Lunn
On Tue, May 24, 2016 at 05:09:35PM +0100, Amr Bekhit wrote: > Hi Andrew, > > > How about adding a printk() in genphy_read_status(). > > Would you be able to point me to some more information about these > status bits, please? You can get the datasheet from here:

Re: [PATCH RESEND 7/8] pipe: account to kmemcg

2016-05-24 Thread Vladimir Davydov
On Tue, May 24, 2016 at 05:59:02AM -0700, Eric Dumazet wrote: ... > > +static int anon_pipe_buf_steal(struct pipe_inode_info *pipe, > > + struct pipe_buffer *buf) > > +{ > > + struct page *page = buf->page; > > + > > + if (page_count(page) == 1) { > > This looks racy

Re: [PATCH RESEND 8/8] af_unix: charge buffers to kmemcg

2016-05-24 Thread Vladimir Davydov
On Tue, May 24, 2016 at 06:02:06AM -0700, Eric Dumazet wrote: > On Tue, 2016-05-24 at 11:49 +0300, Vladimir Davydov wrote: > > Unix sockets can consume a significant amount of system memory, hence > > they should be accounted to kmemcg. > > > > Since unix socket buffers are always allocated from

[PATCH net] sfc: on MC reset, clear PIO buffer linkage in TXQs

2016-05-24 Thread Edward Cree
Otherwise, if we fail to allocate new PIO buffers, our TXQs will try to use the old ones, which aren't there any more. Fixes: 183233bec810 "sfc: Allocate and link PIO buffers; map them with write-combining" Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/ef10.c |

[4.2.y-ckt stable] Patch "VSOCK: do not disconnect socket when peer has shutdown SEND only" has been added to the 4.2.y-ckt tree

2016-05-24 Thread Kamal Mostafa
This is a note to let you know that I have just added a patch titled VSOCK: do not disconnect socket when peer has shutdown SEND only to the linux-4.2.y-queue branch of the 4.2.y-ckt extended stable tree which can be found at:

[PATCH 4.2.y-ckt 48/53] VSOCK: do not disconnect socket when peer has shutdown SEND only

2016-05-24 Thread Kamal Mostafa
4.2.8-ckt11 -stable review patch. If anyone has any objections, please let me know. ---8< From: Ian Campbell [ Upstream commit dedc58e067d8c379a15a8a183c5db318201295bb ] The peer may be expecting a reply

Re: [RFC PATCH 7/7] tou: Support for GSO

2016-05-24 Thread Tom Herbert
On Tue, May 24, 2016 at 7:59 AM, Alexander Duyck wrote: > On Mon, May 23, 2016 at 3:48 PM, Tom Herbert wrote: >> Add SKB_GSO_TOU. In udp[64]_ufo_fragment check for SKB_GSO_TOU. If this >> is set call skb_udp_tou_segment. skb_udp_tou_segment is

Re: ixgbe: ksoftirqd consumes 100% CPU w/ ~50 TCP conns

2016-05-24 Thread Brandon Philips
Hello Everyone- So we tracked it down to IOMMU causing CPU affinity getting broken[1]. Can we provide any further details or is this a known issue? Thank You, Brandon [1] https://github.com/coreos/bugs/issues/1275#issuecomment-219866601 On Tue, May 17, 2016 at 12:44 PM, Brandon Philips

Re: [PATCH iproute2] Make builds default to quiet mode

2016-05-24 Thread Andreas Schwab
David Ahern writes: > @@ -50,7 +54,7 @@ LDLIBS += $(LIBNETLINK) > all: Config > @set -e; \ > for i in $(SUBDIRS); \ > - do $(MAKE) $(MFLAGS) -C $$i; done > + do echo "\n$$i"; $(MAKE) $(MFLAGS) -C $$i; done echo "\n" is not portable. Andreas. --

Re: [net-next PATCH 0/2] Follow-ups for GUEoIPv6 patches

2016-05-24 Thread Alex Duyck
On Tue, May 24, 2016 at 10:14 AM, Jeff Kirsher wrote: > On Wed, 2016-05-18 at 21:10 -0700, David Miller wrote: >> From: Jeff Kirsher >> Date: Wed, 18 May 2016 14:27:58 -0700 >> >> > On Wed, 2016-05-18 at 10:44 -0700, Alexander Duyck

Re: [net-next PATCH 0/2] Follow-ups for GUEoIPv6 patches

2016-05-24 Thread Jeff Kirsher
On Wed, 2016-05-18 at 21:10 -0700, David Miller wrote: > From: Jeff Kirsher > Date: Wed, 18 May 2016 14:27:58 -0700 > > > On Wed, 2016-05-18 at 10:44 -0700, Alexander Duyck wrote: > >> This patch series is meant to be applied after: > >> [PATCH v7 net-next 00/16]

[PATCH iproute2] Make builds default to quiet mode

2016-05-24 Thread David Ahern
Similar to the Linux kernel and perf add infrastructure to reduce the amount of output tossed to a user during a build. Full build output can be obtained with 'make V=1' Builds go from: make[1]: Leaving directory `/home/dsa/iproute2.git/lib' make[1]: Entering directory

Re: [PATCH v2] ethernet:arc: Fix racing of TX ring buffer

2016-05-24 Thread Francois Romieu
Lino Sanfilippo : [...] > I dont agree here. A dma_wmb would have an effect to "data" and "info", yes, > but it would have absolutely no effect to skb_tx_timestamp(), since there > is no dma access involved here. In fact skb_tx_timestamp() could probably > be even reordered

Re: bpf: use-after-free in array_map_alloc

2016-05-24 Thread Tejun Heo
Hello, Alexei, can you please verify this patch? Map extension got rolled into balance work so that there's no sync issues between the two async operations. Thanks. Index: work/mm/percpu.c === --- work.orig/mm/percpu.c +++

Re: rtk8168 driver help needed

2016-05-24 Thread Murali Karicheri
On 05/19/2016 08:31 PM, Francois Romieu wrote: > Murali Karicheri : > [...] >> Do you what could be wrong with rtk8168? > > Hardly. > > What do the device registers (ethtool -d) and device stats (ethtool -S) > look like ? Will dump in the next opportunity and respond > >

[PATCH] brcmfmac: print error in p2p_ifadd firmware command fails

2016-05-24 Thread Rafał Miłecki
This is helpful for debugging, without this all I was getting from "iw" command on device with BCM43602 was: > command failed: Too many open files in system (-23) Signed-off-by: Rafał Miłecki --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +- 1 file changed, 1

Re: [PATCH net] net_sched: avoid too many hrtimer_start() calls

2016-05-24 Thread David Miller
From: Eric Dumazet Date: Mon, 23 May 2016 14:24:56 -0700 > From: Eric Dumazet > > I found a serious performance bug in packet schedulers using hrtimers. > > sch_htb and sch_fq are definitely impacted by this problem. > > We constantly rearm high

Re: [PATCH v2 1/2] ip6_gre: Fix MTU setting for ip6gretap

2016-05-24 Thread David Miller
From: Haishuang Yan Date: Sat, 21 May 2016 18:17:34 +0800 > When creat an ip6gretap interface with an unreachable route, > the MTU is about 14 bytes larger than what was needed. ... > Because rt is not NULL here, so dev->mtu will subtract the ethernet > header

Re: [PATCH v2 2/2] ip6_gre: Set flowi6_proto as IPPROTO_GRE in xmit path.

2016-05-24 Thread David Miller
From: Haishuang Yan Date: Sat, 21 May 2016 18:17:35 +0800 > In gre6 xmit path, we are sending a GRE packet, so set fl6 proto > to IPPROTO_GRE properly. > > Signed-off-by: Haishuang Yan Applied.

Re: [PATCH] net/qlge: Avoids recursive EEH error

2016-05-24 Thread David Miller
From: Gavin Shan Date: Mon, 23 May 2016 11:58:28 +1000 > One timer, whose handler keeps reading on MMIO register for EEH > core to detect error in time, is started when the PCI device driver > is loaded. MMIO register can't be accessed during PE reset in EEH >

[PATCH v2] Make builds default to quiet mode

2016-05-24 Thread David Ahern
Similar to the Linux kernel and perf add infrastructure to reduce the amount of output tossed to a user during a build. Full build output can be obtained with 'make V=1' Builds go from: make[1]: Leaving directory `/home/dsa/iproute2.git/lib' make[1]: Entering directory

Re: [PATCH RESEND 7/8] pipe: account to kmemcg

2016-05-24 Thread Eric Dumazet
On Tue, 2016-05-24 at 19:13 +0300, Vladimir Davydov wrote: > On Tue, May 24, 2016 at 05:59:02AM -0700, Eric Dumazet wrote: > ... > > > +static int anon_pipe_buf_steal(struct pipe_inode_info *pipe, > > > +struct pipe_buffer *buf) > > > +{ > > > + struct page *page =

Re: ixgbe: ksoftirqd consumes 100% CPU w/ ~50 TCP conns

2016-05-24 Thread Jesper Dangaard Brouer
On Tue, 24 May 2016 12:46:56 -0700 Alexander Duyck wrote: > I'm guessing the issue is lock contention on the IOMMU resource table. > I resolved most of that for the Rx side back when we implemented the > Rx page reuse but the Tx side still has to perform a DMA mapping

Re: bpf: use-after-free in array_map_alloc

2016-05-24 Thread Alexei Starovoitov
On Tue, May 24, 2016 at 12:04 PM, Tejun Heo wrote: > Hello, > > Alexei, can you please verify this patch? Map extension got rolled > into balance work so that there's no sync issues between the two async > operations. tests look good. No uaf and basic bpf tests exercise per-cpu

Re: [RFC PATCH 1/7] fou: Get net from sock_net if dev_net unavailable

2016-05-24 Thread David Miller
From: Tom Herbert Date: Mon, 23 May 2016 15:48:20 -0700 > diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c > index 5f9207c..96260c6 100644 > --- a/net/ipv4/fou.c > +++ b/net/ipv4/fou.c > @@ -807,13 +807,20 @@ int __fou_build_header(struct sk_buff *skb, struct > ip_tunnel_encap

[PATCH V2] brcmfmac: print error if p2p_ifadd firmware command fails

2016-05-24 Thread Rafał Miłecki
This is helpful for debugging, without this all I was getting from "iw" command on device with BCM43602 was: > command failed: Too many open files in system (-23) Signed-off-by: Rafał Miłecki --- V2: s/in/if/ in commit message ---

Re: [RFC PATCH 2/7] tou: Base infrastructure for Transport over UDP

2016-05-24 Thread David Miller
From: Tom Herbert Date: Mon, 23 May 2016 15:48:21 -0700 > +int tou_encap_setsockopt(struct sock *sk, char __user *optval, int optlen, > + bool is_ipv6) > +{ > + struct tou_encap te; > + struct ip_tunnel_encap encap; > + struct inet_sock

Re: ixgbe: ksoftirqd consumes 100% CPU w/ ~50 TCP conns

2016-05-24 Thread Alexander Duyck
I'm guessing the issue is lock contention on the IOMMU resource table. I resolved most of that for the Rx side back when we implemented the Rx page reuse but the Tx side still has to perform a DMA mapping for each individual buffer. Depending on the needs of the user if they still need the IOMMU

Re: [PATCH v5 2/2] skb_array: ring test

2016-05-24 Thread Michael S. Tsirkin
On Tue, May 24, 2016 at 07:03:20PM +0200, Jesper Dangaard Brouer wrote: > > On Tue, 24 May 2016 12:28:09 +0200 > Jesper Dangaard Brouer wrote: > > > I do like perf, but it does not answer my questions about the > > performance of this queue. I will code something up in my own