Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain().

On Tue, 2016-06-28 at 08:22 +0200, Eric Dumazet wrote: > Follow the stack trace and add another cond_resched() where it is needed > then ? > > Lot of this code was written decade ago where nobody expected a root > user was going to try hard to crash its host ;) > > I did not check if the

[PATCH net-next 0/2] qed*: Fix the static checker warnings.

The patch series addresses the static checker warnings introduced by the earlier patches related to qed/qede coalesce configuration support. Sudarsana Reddy Kalluru (2): qed: Fix static checker warnings. qede: Fix the static checker warnings. drivers/net/ethernet/qlogic/qed/qed.h

Re: [PATCH v10 04/22] IB/hns: Add RoCE engine reset function

On 2016/6/27 16:31, oulijun wrote: Hi, Leon 在 2016/6/27 16:01, Leon Romanovsky 写道: On Sat, Jun 25, 2016 at 06:25:37PM +0800, Wei Hu (Xavier) wrote: On 2016/6/24 22:59, Leon Romanovsky wrote: On Thu, Jun 16, 2016 at 10:35:12PM +0800, Lijun Ou wrote: This patch mainly added reset flow of

Re: [PATCH v10 05/22] IB/hns: Add initial profile resource

Hi, leon 在 2016/6/24 23:10, Leon Romanovsky 写道: > On Thu, Jun 16, 2016 at 10:35:13PM +0800, Lijun Ou wrote: >> This patch added the operation for cmd, and added some functions >> for initializing eq table and selecting cmd mode. >> >> Signed-off-by: Wei Hu >>

Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain().

On Tue, 2016-06-28 at 14:09 +0800, Ding Tianhong wrote: > On 2016/6/28 13:13, Eric Dumazet wrote: > > On Tue, 2016-06-28 at 12:56 +0800, Ding Tianhong wrote: > >> The problem was occurs in my system that a lot of drviers register > >> its own handler to the notifiler call chain for netdev_chain,

[PATCH net-next 2/2] qede: Fix the static checker warnings.

Static checker warnings: drivers/net/ethernet/qlogic/qede/qede_ethtool.c:435 qede_get_coalesce() warn: passing casted pointer '>rx_coalesce_usecs' to 'edev->ops->common->get_coalesce()' 32 vs 16. The u32 pointer is being typecasted to u16 which may fail for big-endian platforms. Fixes:

[PATCH net-next 1/2] qed: Fix static checker warnings.

Static checker warnings: drivers/net/ethernet/qlogic/qed/qed_int.c:2450 qed_init_cau_sb_entry() warn: always true condition '(cdev->rx_coalesce_usecs <= 255) => (0-255 <= 255)' drivers/net/ethernet/qlogic/qed/qed_int.c:2511 qed_int_cau_conf_sb() warn: always true condition

Re: [PATCH net-next V2] tun: introduce tx skb ring

On Thu, Jun 23, 2016 at 01:14:07PM +0800, Jason Wang wrote: > > > On 2016年06月23日 02:18, Michael S. Tsirkin wrote: > > On Fri, Jun 17, 2016 at 03:41:20AM +0300, Michael S. Tsirkin wrote: > > > >Would it help to have ptr_ring_resize that gets an array of > > > >rings and resizes them both to same

Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain().

On 2016/6/28 13:13, Eric Dumazet wrote: > On Tue, 2016-06-28 at 12:56 +0800, Ding Tianhong wrote: >> The problem was occurs in my system that a lot of drviers register >> its own handler to the notifiler call chain for netdev_chain, and >> then create 4095 vlan dev for one nic, and add several

[PATCH net-next] tcp: increase size at which tcp_bound_to_half_wnd bounds to > TCP_MSS_DEFAULT

In previous commit 01f83d69844d307be2aa6fea88b0e8fe5cbdb2f4 the following comments were added: "When peer uses tiny windows, there is no use in packetizing to sub-MSS pieces for the sake of SWS or making sure there are enough packets in the pipe for fast recovery." The test should be >

[PATCH net-next] net_sched: netem: do not call qdisc_drop() with a NULL skb

From: Eric Dumazet If skb_unshare() fails, we call qdisc_drop() with a NULL skb, which is no longer supported. Fixes: 520ac30f4551 ("net_sched: drop packets after root qdisc lock is released") Signed-off-by: Eric Dumazet Reported-by: Dan Carpenter

Re: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets

From: Dexuan Cui Date: Fri, 24 Jun 2016 07:45:24 + > + while ((ret = vmalloc(size)) == NULL) > + ssleep(1); This is completely, and entirely, unacceptable. If the allocation fails, you return an error and release your resources. You don't just loop

Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

> static void can_dellink(struct net_device *dev, struct list_head *head); > > and > > static void can_dellink(struct net_device *dev, struct list_head *head) > { > return; > } Wouldn't the canonical form be this: static void can_dellink(struct net_device *dev, struct list_head *head) { }

Re: IP ID check (flush_id) in inet_gro_receive is necessary or not？

On 2016/6/28 12:57, Eric Dumazet wrote: > On Tue, 2016-06-28 at 12:40 +0800, Tan Xiaojun wrote: >> Hi everyone, >> >> I'm sorry to bother you. But I was confused. >> >> The IP ID check (flush_id) in inet_gro_receive is only used by >> tcp_gro_receive, and in tcp_gro_receive we have

[PATCH] neigh: Explicitly declare RCU-bh read side critical section in neigh_xmit()

From: David Barroso neigh_xmit() expects to be called inside an RCU-bh read side critical section, and while one of its two current callers gets this right, the other one doesn't. More specifically, neigh_xmit() has two callers, mpls_forward() and mpls_output(), and while

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

From: Jay Vosburgh Date: Thu, 23 Jun 2016 14:20:51 -0700 > > Since commit 7bb11dc9f59d ("bonding: unify all places where > actor-oper key needs to be updated."), the logic in bonding to handle > selection between multiple aggregators has not functioned. > >

Re: [PATCH 2/2] net: ethernet: dnet: use phy_ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Thu, 23 Jun 2016 23:48:59 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/2] net: ethernet: dnet: use phydev from struct net_device

From: Philippe Reynes Date: Thu, 23 Jun 2016 23:48:58 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one

Re: [PATCH V5 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

My fault, I wasn't testing against building as module, was always building as part of the kernel. I'll get it fixed and put another patch for review. Thanks Tien Hock On Tue, 2016-06-28 at 05:48 -0400, David Miller wrote: > From: David Miller > Date: Tue, 28 Jun 2016

[PATCH stable] sfc: report supported link speeds on SFP connections

Hello David, Can you queue up this commit for -stable please? The sfc 8000-series NICs are less tolerant of missing supported link speeds. It applies cleanly on to 4.5.7 and 4.6.3. The Fixes: commit below is the commit that introduced the 8000-series PCI IDs. commit

Re: [PATCH v10 04/22] IB/hns: Add RoCE engine reset function

On Tue, Jun 28, 2016 at 02:31:41PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/27 16:31, oulijun wrote: > >Hi, Leon > >在 2016/6/27 16:01, Leon Romanovsky 写道: > >>On Sat, Jun 25, 2016 at 06:25:37PM +0800, Wei Hu (Xavier) wrote: > >>> > >>>On 2016/6/24 22:59, Leon Romanovsky wrote: > On Thu,

Backported alx driver fix for stable 4.4 kernel and older

Hi David, Greg KH has picked up the alx driver fix for 4.6 stable kernel, and people are asking about plan for 4.4/4.1 stable kernel in https://bugzilla.kernel.org/show_bug.cgi?id=70761 Since the fix patch in your "net" git can't be applied to 4.4 and older kernel as is, so I backport it

Re: [PATCH] caif: Remove unneeded header file

From: Amitoj Kaur Chawla Date: Fri, 24 Jun 2016 11:53:54 +0530 > Drop redundant include of moduleparam.h > > The Coccinelle semantic patch used to make this change is as follows: > @ includesmodule @ > @@ > > #include > > @ depends on includesmodule @ > @@ > > -

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

On Tuesday, June 28, 2016 5:21:19 PM CEST Dongpo Li wrote: > On 2016/6/15 5:20, Arnd Bergmann wrote: > > On Tuesday, June 14, 2016 9:17:44 PM CEST Li Dongpo wrote: > >> On 2016/6/13 17:06, Arnd Bergmann wrote: > >>> On Monday, June 13, 2016 2:07:56 PM CEST Dongpo Li wrote: > >>> You tx function

Re: [PATCH net] Bridge: Fix ipv6 mc snooping if bridge has no ipv6 address

From: Daniel Danzberger Date: Fri, 24 Jun 2016 12:35:18 +0200 > The bridge is falsly dropping ipv6 mulitcast packets if there is: > 1. No ipv6 address assigned on the brigde. > 2. No external mld querier present. > 3. The internal querier enabled. > > When the bridge fails

Re: [PATCH V5 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

From: David Miller Date: Tue, 28 Jun 2016 05:34:50 -0400 (EDT) > From: > Date: Fri, 24 Jun 2016 02:13:23 -0700 > >> From: Tien Hock Loh >> >> This adds support for TSE PCS that uses SGMII adapter when the phy-mode of >> the dwmac is

Re: [PATCH net 0/3] net: bgmac: Random fixes

From: Florian Fainelli Date: Thu, 23 Jun 2016 14:23:11 -0700 > This patch series fixes a few issues spotted by code inspection and > actual testing. Series applied, thanks.

Re: [PATCH v3] net/mlx5: use mlx5_buf_alloc_node instead of mlx5_buf_alloc in mlx5_wq_ll_create

From: Wang Sheng-Hui Date: Fri, 24 Jun 2016 08:52:11 +0800 > Commit 311c7c71c9bb ("net/mlx5e: Allocate DMA coherent memory on > reader NUMA node") introduced mlx5_*_alloc_node() but missed changing > some calling and warn messages. This patch introduces 2 changes: > *

Re: [PATCH net-next] net: diag: Add support to filter on device index

From: David Ahern Date: Thu, 23 Jun 2016 18:42:51 -0700 > Add support to inet_diag facility to filter sockets based on device > index. If an interface index is in the filter only sockets bound > to that index (sk_bound_dev_if) are returned. > > Signed-off-by: David

Re: [PATCH] of_mdio: select fixed phy support unconditionally

From: Arnd Bergmann Date: Fri, 24 Jun 2016 11:24:08 +0200 > Calling the fixed-phy functions when CONFIG_FIXED_PHY=m as a previous > change tried cannot work if the caller is in built-in code: > > drivers/of/built-in.o: In function `of_phy_register_fixed_link': >

Re: [PATCH] mpls: Add missing RCU-bh read side critical section locking in output path

On Thu, Jun 23, 2016 at 12:00:55PM -0400, David Miller wrote: > > From: David Barroso > > > > When locally originated IP traffic hits a route that says to push > > MPLS labels, we'll get a call chain dst_output() -> lwtunnel_output() > > -> mpls_output() -> neigh_xmit() ->

Re: [PATCH usbnet v2.1] mtu change needs to stop RX

From: Soohoon Lee Date: Fri, 24 Jun 2016 00:30:16 + > > When MTU is changed unlink_urbs() flushes RX Q but mean while usbnet_bh() can > fill up the Q at the same time. > Depends on which HCD is down there unlink takes long time then the flush > never ends. > >

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

On 2016/6/15 5:20, Arnd Bergmann wrote: > On Tuesday, June 14, 2016 9:17:44 PM CEST Li Dongpo wrote: >> On 2016/6/13 17:06, Arnd Bergmann wrote: >>> On Monday, June 13, 2016 2:07:56 PM CEST Dongpo Li wrote: >>> You tx function uses BQL to optimize the queue length, and that >>> is great. You

Re: [PATCH V5 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

From: Date: Fri, 24 Jun 2016 02:13:23 -0700 > From: Tien Hock Loh > > This adds support for TSE PCS that uses SGMII adapter when the phy-mode of > the dwmac is set to sgmii. > > Signed-off-by: Tien Hock Loh > Acked-by: Giuseppe Cavallaro

Re: [PATCH] of_mdio: select fixed phy support unconditionally

On Tuesday, June 28, 2016 5:43:42 AM CEST David Miller wrote: > Applied to net-next, thanks Arnd. > > In the future, please be explicit about what tree a patch is > targetting by specifying it in your Subject line, as: > > [PATCH net-next] ... > Sure, will do. Arnd

[PATCH] wlcore/wl18xx: mesh: added initial mesh support for wl8

From: Maital Hahn 1. Added support for interface and role of mesh type. 2. Enabled enable/start of mesh-point role, and opening and closing a connection with a mesh peer. 3. Added multirole combination of mesh and ap under the same limits of dual ap mode. 4. Add support for

[PATCH net-next 4/6] bpf: don't use raw processor id in generic helper

Use smp_processor_id() for the generic helper bpf_get_smp_processor_id() instead of the raw variant. This allows for preemption checks when we have DEBUG_PREEMPT, and otherwise uses the raw variant anyway. We only need to keep the raw variant for socket filters, but we can reuse the helper that is

[PATCH net-next 5/6] bpf: add bpf_skb_change_proto helper

This patch adds a minimal helper for doing the groundwork of changing the skb->protocol in a controlled way. Currently supported is v4 to v6 and vice versa transitions, which allows f.e. for a minimal, static nat64 implementation where applications in containers that still require IPv4 can be

[PATCH net-next 6/6] bpf: add bpf_skb_change_type helper

This work adds a helper for changing skb->pkt_type in a controlled way. We only allow a subset of possible values and can extend that in future should other use cases come up. Doing this as a helper has the advantage that errors can be handeled gracefully and thus helper kept extensible. It's a

[PATCH net-next 3/6] bpf, trace: add BPF_F_CURRENT_CPU flag for bpf_perf_event_read

Follow-up commit to 1e33759c788c ("bpf, trace: add BPF_F_CURRENT_CPU flag for bpf_perf_event_output") to add the same functionality into bpf_perf_event_read() helper. The split of index into flags and index component is also safe here, since such large maps are rejected during map allocation time.

[PATCH 0/4] Mesh mpm fixes and enhancements

This patch set is addressing some issues found in the current 802.11s implementation, specifically when using hostap mpm. It's aligning the beacon format and handling some corner cases. Maital Hahn (2): mac80211: mesh: flush stations before beacons are stopped mac80211/cfg: mesh: fix

[PATCH] mac80211: rx: frames received out of order

From: Meirav Kama MP received data frames from another MP. Frames are forwarded from Rx to Tx to be transmitted to a third MP. Upon cloning the skb, the tx_info was zeroed, and the hw_queue wasn't set correctly, causing frames to be inserted to queue 0 (VOICE). If re-queue

[PATCH] mac80211: util: mesh is not connected properly after recovery

From: Maital Hahn In the reconfigure process for mesh interface, moved the reconfiguration of the mesh peers to be done only after restarting the beacons, the same as it is done for AP. Signed-off-by: Maital Hahn Acked-by: Yaniv Machani ---

Re: [PATCH net-next] tcp: increase size at which tcp_bound_to_half_wnd bounds to > TCP_MSS_DEFAULT

On Tue, 2016-06-28 at 04:33 +, Seymour, Shane M wrote: > In previous commit 01f83d69844d307be2aa6fea88b0e8fe5cbdb2f4 > the following comments were added: > > "When peer uses tiny windows, there is no use in packetizing to sub-MSS > pieces for the sake of SWS or making sure there are enough

Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support

On Thu, 2016-05-12 at 17:34 +0800, Wei-Ning Huang wrote: >  > Johannes, I feel like being able to set calibration data at runtime > is something common to all wireless drivers, so instead of using > vendor commands what do you think if I pass the calibration data name > instead of using those

Re: [Bridge] [PATCH net-next] net: bridge: add support for IGMP/MLD stats and export them via netlink

On Mon, Jun 27, 2016 at 08:10:48PM +0200, Nikolay Aleksandrov via Bridge wrote: > These are invaluable when monitoring or debugging complex multicast setups > with bridges. Indeed! Great patch :). Especially if people are unable to provide pcap files for debugging (due to whatever reason).

[PATCH 1/4] mac80211: mesh: flush stations before beacons are stopped

From: Maital Hahn Some drivers (e.g. wl18xx) expect that the last stage in the de-initialization process will be stopping the beacons, similar to ap. Update ieee80211_stop_mesh() flow accordingly. Signed-off-by: Maital Hahn Acked-by: Yaniv Machani

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

On 6/28/2016 8:57 AM, John Fastabend wrote: On 16-06-27 09:07 AM, Saeed Mahameed wrote: Add the commands to set and show the mode of SRIOV E-Switch, two modes are supported: * legacy : operating in the "old" L2 based mode (DMAC --> VF vport) * offloads : offloading SW rules/policy (e.g

[PATCH net-next 2/6] bpf, trace: fetch current cpu only once

We currently have two invocations, which is unnecessary. Fetch it only once and use the smp_processor_id() variant, so we also get preemption checks along with it when DEBUG_PREEMPT is set. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov ---

Re: [PATCH] nl80211: improve nl80211_parse_mesh_config type checking

On Wed, 2016-06-15 at 22:29 +0200, Arnd Bergmann wrote: > When building a kernel with W=1, the nl80211.c file causes a number > of > warnings, all about the same problem: > > net/wireless/nl80211.c: In function 'nl80211_parse_mesh_config': > net/wireless/nl80211.c:5287:103: error: comparison is

[PATCH net-next 0/6] BPF helper improvements

This set adds various BPF helper improvements, that is, cleaning up and adding BPF_F_CURRENT_CPU flag for tracing helper, allowing for preemption checks on bpf_get_smp_processor_id() helper, and adding two new helpers bpf_skb_change_{proto, type} for tc related programs. For further details please

[PATCH net-next 1/6] bpf: minor cleanups on fd maps and helpers

Some minor cleanups: i) Remove the unlikely() from fd array map lookups and let the CPU branch predictor do its job, scenarios where there is not always a map entry are very well valid. ii) Move the attribute type check in the bpf_perf_event_read() helper a bit earlier so it's consistent wrt

RE: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets

> From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, June 28, 2016 17:34 > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com;

[PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template

From: Meirav Kama There are several values in HT info elements of mesh beacon (built by the mac80211) that are incorrect. To fix them: 1. mac80211 will check configuration from cfg and will build accordingly. 2. changes made in mesh default values. Signed-off-by: Meirav Kama

[PATCH 4/4] mac80211: sta_info: max_peers reached falsely

From: Meirav Kama Issue happened when receiving delete_sta command without changing plink_state from ESTAB to HOLDING before. When receiving delete_sta command for mesh interface verify plink_state is not ESTAB and if so, decrease plink count and update beacon. Signed-off-by:

[PATCH 2/4] mac80211/cfg: mesh: fix healing time when a mesh peer is disconnecting

From: Maital Hahn Once receiving a CLOSE action frame from the disconnecting peer, flush all entries in the path table which has this peer as the next hop. In addition, upon receiving a packet, if next hop is not found, trigger PERQ immidiatly, instead of just putting it in the

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-06-24 0:20 GMT+03:00 Jay Vosburgh : > > Since commit 7bb11dc9f59d ("bonding: unify all places where > actor-oper key needs to be updated."), the logic in bonding to handle > selection between multiple aggregators has not functioned. > > This affects

Re: [PATCH] rtlwifi: Create _rtl_dbg_trace function to reduce RT_TRACE code size

On 06/27/2016 10:55 PM, Joe Perches wrote: On Mon, 2016-06-27 at 19:53 -0500, Larry Finger wrote: On 06/25/2016 05:46 PM, Joe Perches wrote: This debugging macro can expand to a lot of code. Make it a function to reduce code size. (x86-64 defconfig w/ all rtlwifi drivers and allyesconfig) $

Re: [PATCH net-next 10/16] net/mlx5e: Add devlink based SRIOV mode changes (legacy --> offloads)

On Tue, Jun 28, 2016 at 05:25:11PM +0300, Or Gerlitz wrote: > On 6/28/2016 4:42 PM, Andy Gospodarek wrote: > >On Mon, Jun 27, 2016 at 07:07:23PM +0300, Saeed Mahameed wrote: > >>From: Or Gerlitz > >> > >>Implement handlers for the devlink commands to get and set the SRIOV >

RE: [PATCH 2/4] mac80211/cfg: mesh: fix healing time when a mesh peer is disconnecting

On Tue, Jun 28, 2016 at 15:27:47, Bob Copeland wrote: > linux- wirel...@vger.kernel.org; netdev@vger.kernel.org; Hahn, Maital > Subject: Re: [PATCH 2/4] mac80211/cfg: mesh: fix healing time when a > mesh peer is disconnecting > > On Tue, Jun 28, 2016 at 02:13:05PM +0300, Yaniv Machani wrote: > >

Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

On 06/28/2016 09:36 AM, Holger Schurig wrote: static void can_dellink(struct net_device *dev, struct list_head *head); and static void can_dellink(struct net_device *dev, struct list_head *head) { return; } Wouldn't the canonical form be this: static void can_dellink(struct

Re: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets

On 06/28/2016 02:59 AM, Dexuan Cui wrote: The idea here is: IMO the syscalls sys_read()/write() shoudn't return -ENOMEM, so I have to make sure the buffer allocation succeeds? I tried to use kmalloc with __GFP_NOFAIL, but I hit a warning in in mm/page_alloc.c: WARN_ON_ONCE((gfp_flags &

Re: [Patch net] mlx4: set csum_complete_sw bit when fixing complete csum

On Tue, Jun 28, 2016 at 12:44 AM, Cong Wang wrote: > On Mon, Jun 27, 2016 at 2:08 PM, Or Gerlitz wrote: >> On Mon, Jun 27, 2016 at 9:22 PM, Cong Wang wrote: >> can you point/paste the exact warning and how to reproduce

RE: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets

> From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, June 28, 2016 21:45 > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com;

[RFC] WireGuard: next generation secure network tunnel

Hi Dave & Folks, Today I'm releasing WireGuard, an encrypted and authenticated tunneling virtual interface for the kernel. It uses next-generation cryptography and is designed to be both easy to use and simple to implement (only ~4000 LoC, which compared to xfrm or openvpn is spectacular),

Re: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets

From: Dexuan Cui Date: Tue, 28 Jun 2016 09:59:21 + > The idea here is: IMO the syscalls sys_read()/write() shoudn't return > -ENOMEM, so I have to make sure the buffer allocation succeeds? You have to fail if resources cannot be allocated.

[PATCH net-next v2 0/2] net: bridge: add support for IGMP/MLD stats

Hi all, This patchset adds support for the new IFLA_STATS_LINK_XSTATS_SLAVE attribute which can be used with RTM_GETSTATS in order to export per-slave statistics. It works by passing the attribute to the linkxstats callback and if the callback user supports it - it should dump that slave's stats.

[PATCH net-next v2 1/2] net: rtnetlink: add support for the IFLA_STATS_LINK_XSTATS_SLAVE attribute

This patch adds support for the IFLA_STATS_LINK_XSTATS_SLAVE attribute which allows to export per-slave statistics if the master device supports the linkxstats callback. The attribute is passed down to the linkxstats callback and it is up to the callback user to use it (an example has been added

[PATCH net-next v2 2/2] net: bridge: add support for IGMP/MLD stats and export them via netlink

This patch adds stats support for the currently used IGMP/MLD types by the bridge. The stats are per-port (plus one stat per-bridge) and per-direction (RX/TX). The stats are exported via netlink via the new linkxstats API (RTM_GETSTATS). In order to minimize the performance impact, a new option is

[PATCH] net: can: Introduce MEN 16Z192-00 CAN controller driver

This CAN Controller is found on MEN Chameleon FPGAs. The driver/device supports the CAN2.0 specification. There are 255 RX and 255 Tx buffer within the IP. The pointer for the buffer are handled by HW to make the access from within the driver as simple as possible. The driver also supports

Re: [PATCH net-next 10/16] net/mlx5e: Add devlink based SRIOV mode changes (legacy --> offloads)

On 6/28/2016 4:42 PM, Andy Gospodarek wrote: On Mon, Jun 27, 2016 at 07:07:23PM +0300, Saeed Mahameed wrote: From: Or Gerlitz Implement handlers for the devlink commands to get and set the SRIOV E-Switch mode. When turning to the offloads mode, we disable the e-switch

[PATCH net v2] openvswitch: fix conntrack netlink event delivery

Only the first and last netlink message for a particular conntrack are actually sent. The first message is sent through nf_conntrack_confirm when the conntrack is committed. The last one is sent when the conntrack is destroyed on timeout. The other conntrack state change messages are not

Re: [PATCH net-next 0/6] net: dsa: Platform data for dsa2.c

On Mon, Jun 27, 2016 at 06:19:28PM -0700, Florian Fainelli wrote: > 2016-06-27 18:05 GMT-07:00 Andrew Lunn : > > On Mon, Jun 27, 2016 at 05:52:37PM -0700, Florian Fainelli wrote: > >> Hi all, > >> > >> This patch series adds support for platform data using the new code from > >>

Re: Doing crypto in small stack buffers (bluetooth vs vmalloc-stack crash, etc)

> We have actually gained quite a bit of documentation recently. > Have you looked at Documentation/DocBook/crypto-API.tmpl? > > More is always welcome of course. It's improved since I last looked at it, but there are still many structures that aren't described: - struct crypto_instance -

Re: Deleting child qdisc doesn't reset parent to default qdisc?

On Fri, 15 Apr 2016, Eric Dumazet wrote: > > TBF is probably a bad example because it started life as a classless > > qdisc. There was only one built-in fifo queue that was shaped. Then > > someone made it classful and changed this behavior. To me it sounds > > reasonable to have the default

Re: [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template

On Tue, Jun 28, 2016 at 02:13:06PM +0300, Yaniv Machani wrote: > From: Meirav Kama > > There are several values in HT info elements of mesh beacon (built by the > mac80211) that are incorrect. Would be good to enumerate the problems here. > To fix them: > 1. mac80211 will check

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

On 16-06-28 03:25 AM, Or Gerlitz wrote: > On 6/28/2016 8:57 AM, John Fastabend wrote: >> On 16-06-27 09:07 AM, Saeed Mahameed wrote: >>> Add the commands to set and show the mode of SRIOV E-Switch, two >>> modes are supported: >>> >>> * legacy : operating in the "old" L2 based mode (DMAC --> VF

Re: [PATCH] libertas_tf: Remove create_workqueue

Bhaktipriya Shridhar writes: > Ping! I'm lagging behind, the patch is still on my queue: https://patchwork.kernel.org/patch/9162447/ Please don't top most, it's annoying. -- Kalle Valo

Re: [iproute PATCH v3 0/6] Big C99 style initializer rework

On Mon, Jun 27, 2016 at 02:10:49PM -0700, Stephen Hemminger wrote: > On Mon, 27 Jun 2016 20:23:02 +0200 > Phil Sutter wrote: > > > Hi, > > > > On Mon, Jun 27, 2016 at 10:59:12AM -0700, Stephen Hemminger wrote: > > > On Thu, 23 Jun 2016 17:34:08 + > > > Phil Sutter

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

On Mon, Jun 27, 2016 at 8:41 PM, Herbert Xu wrote: > On Mon, Jun 27, 2016 at 10:58:42AM -0700, Andy Lutomirski wrote: >> >> I wonder if it's worth switching from ahash to shash, though. It >> would probably be simpler and faster. > > No shash is not appropriate here

Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain().

On Mon, Jun 27, 2016 at 11:22 PM, Eric Dumazet wrote: > Lot of this code was written decade ago where nobody expected a root > user was going to try hard to crash its host ;) +1 Adding cond_resched() to appropriate network notifiers sounds better.

Re: [iproute PATCH v3 0/6] Big C99 style initializer rework

On 6/28/16 11:58 AM, Phil Sutter wrote: since .ifr_qlen is already referenced in that function seems like your suggestion above (struct ifreq ifr = { .ifr_qlen = 0 };) should be acceptable. You mean regarding compatibility of using that define? Or are you concerned with gcc creating suboptimal

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

On 16-06-28 09:19 AM, John Fastabend wrote: > On 16-06-28 03:25 AM, Or Gerlitz wrote: >> On 6/28/2016 8:57 AM, John Fastabend wrote: >>> On 16-06-27 09:07 AM, Saeed Mahameed wrote: Add the commands to set and show the mode of SRIOV E-Switch, two modes are supported: * legacy

Re: [iproute PATCH v3 0/6] Big C99 style initializer rework

On 6/28/16 11:37 AM, Phil Sutter wrote: I saw these too with gcc-3.4.6 but not with 5.3.0. It appears to be a gcc bug[1]. One possible workaround is to match the brace level of the first field, but it's quite ugly: [2]. Another way might be to initialize one of the fields to zero, like so: |

[RFC PATCH] sch_tbf: avoid silent fallback to noop_qdisc (was Re: Deleting child qdisc doesn't reset parent to default qdisc?)

On Fri, 15 Apr 2016, Eric Dumazet wrote: > Then you need to save the initial qdisc (bfifo for TBF) in a special > place, to make sure the delete operation is guaranteed to succeed. > > Or fail the delete if the bfifo can not be allocated. > > I can tell that determinism if far more interesting

Re: Deleting child qdisc doesn't reset parent to default qdisc?

On Tue, 28 Jun 2016, Cong Wang wrote: > > BTW, I've started to actually work on fixing this, and I've noticed that > > TBF behavior actually violates what's stated in pfifo_fast manpage: > > > > == > > Whenever an interface is created, the pfifo_fast qdisc is > >

Re: [PATCH v2 iproute2 3/3] ss: Add support to filter on device

On 6/27/16 3:13 PM, Stephen Hemminger wrote: On Mon, 27 Jun 2016 11:34:25 -0700 David Ahern wrote: + case SSF_DEVCOND: + { + struct aafilter *a = (void *)f->pred; I don't like the wandering bracket left, but all the code has that.

Re: [iproute PATCH v3 0/6] Big C99 style initializer rework

On Tue, Jun 28, 2016 at 11:59:04AM -0600, David Ahern wrote: > On 6/28/16 11:58 AM, Phil Sutter wrote: > >> since .ifr_qlen is already referenced in that function seems like your > >> suggestion above (struct ifreq ifr = { .ifr_qlen = 0 };) should be > >> acceptable. > > > > You mean regarding

Re: [PATCH] libertas_tf: Remove create_workqueue

Ping! Thanks, Bhaktipriya On Sun, Jun 12, 2016 at 4:17 AM, Tejun Heo wrote: > On Wed, Jun 08, 2016 at 01:38:53AM +0530, Bhaktipriya Shridhar wrote: >> alloc_workqueue replaces deprecated create_workqueue(). >> >> A dedicated workqueue has been used since the workitem (viz >>

Re: [Patch net] mlx4: set csum_complete_sw bit when fixing complete csum

On Tue, Jun 28, 2016 at 7:30 AM, Or Gerlitz wrote: > Wow, can you please report us the exact card type (lspci -nn | grep -i > mellanox) and firmware version (ethtool -i $DEV) See below. Does commit f8c6455bb04b944edb69e rely on any firmware change to get an expected

[iproute PATCH v4] Use ARRAY_SIZE macro everywhere

This patch was generated by the following semantic patch (a trimmed down version of what is shipped with Linux sources): @@ type T; T[] E; @@ ( - (sizeof(E)/sizeof(*E)) + ARRAY_SIZE(E) | - (sizeof(E)/sizeof(E[...])) + ARRAY_SIZE(E) | - (sizeof(E)/sizeof(T)) + ARRAY_SIZE(E) ) The only manual

Re: Deleting child qdisc doesn't reset parent to default qdisc?

On Tue, Jun 28, 2016 at 8:19 AM, Jiri Kosina wrote: > BTW, I've started to actually work on fixing this, and I've noticed that > TBF behavior actually violates what's stated in pfifo_fast manpage: > > == > Whenever an interface is created, the pfifo_fast qdisc

Re: [iproute PATCH v3 0/6] Big C99 style initializer rework

On Tue, Jun 28, 2016 at 11:37:43AM -0600, David Ahern wrote: > On 6/28/16 11:37 AM, Phil Sutter wrote: > >>> I saw these too with gcc-3.4.6 but not with 5.3.0. It appears to be a > >>> gcc bug[1]. One possible workaround is to match the brace level of the > >>> first field, but it's quite ugly:

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

Tue, Jun 28, 2016 at 07:19:06PM CEST, john.fastab...@gmail.com wrote: >On 16-06-28 09:19 AM, John Fastabend wrote: >> On 16-06-28 03:25 AM, Or Gerlitz wrote: >>> On 6/28/2016 8:57 AM, John Fastabend wrote: On 16-06-27 09:07 AM, Saeed Mahameed wrote: > Add the commands to set and show the

[RFC 2/7] net: ethernet: bgmac: add dma_dev pointer

The dma buffer allocation, etc references a dma_dev device pointer from the bcma core. In anticipation of removing the bcma requirement for this driver, these must be changed to not reference that struct. Add a dma_dev device pointer to the bgmac stuct and reference that instead. Signed-off-by:

[RFC 4/7] net: ethernet: bgmac: convert to feature flags

The bgmac driver is using the bcma provides device ID and revision, as well as the SoC ID and package, to determine which features are necessary to enable, reset, etc in the driver. In anticipation of removing the bcma requirement for this driver, these must be changed to not reference that

[RFC 0/7] net: ethernet: bgmac: Add platform device support

I'm sending out this RFC to see if this is the direction the maintainers would like to go to add support for other, non-bcma iProc SoC's to the bgmac driver. Specifically, we are interested in adding support for the NSP, Cygnus, and NS2 families (with more possible down the road). To support

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

Tue, Jun 28, 2016 at 09:04:00PM CEST, sridhar.samudr...@intel.com wrote: > > >On 6/28/2016 11:46 AM, Jiri Pirko wrote: >>Tue, Jun 28, 2016 at 07:19:06PM CEST, john.fastab...@gmail.com wrote: >>>On 16-06-28 09:19 AM, John Fastabend wrote: On 16-06-28 03:25 AM, Or Gerlitz wrote: >On

[RFC 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac

Signed-off-by: Jon Mason --- .../devicetree/bindings/net/brcm,bgmac-enet.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt diff --git

[RFC 7/7] ARM: dts: NSP: Add bgmac entries

Add device tree entries for the ethernet devices present on the Broadcom Northstar Plus SoCs Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm-nsp.dtsi | 16 arch/arm/boot/dts/bcm958625k.dts | 8 2 files changed, 24 insertions(+) diff --git

  1   2   3   >