pull-request: mac80211 2016-06-29

Hi Dave, Another (pretty old) bug showed up, and I have a single fix for it from Jouni; would be nice to still get it in, but it's in mesh which seems to mostly have users who integrate everything themselves. Let me know if there's any problem. Thanks, johannes The following changes since

Re: [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template

On Tue, 2016-06-28 at 14:13 +0300, Yaniv Machani wrote: >  >  net/mac80211/mesh.c | 33 - >  net/mac80211/util.c |  3 --- >  net/wireless/mesh.c |  2 +- That's not a good patch - one change is mac80211 and the other cfg80211. > - .ht_opmode =

Re: [PATCH] net: stmmac: Fix null-function call in ISR on stmmac1000

From: Matt Corallo Date: Sat, 25 Jun 2016 19:35:03 + > At least on Meson GXBB, the CORE_IRQ_MTL_RX_OVERFLOW interrupt is thrown > with the stmmac1000 driver, which does not support set_rx_tail_ptr. With > this patch and the clock fixes, 1G ethernet works on ODROID-C2. > >

Re: [PATCH v2] Maxim/driver: Add driver for maxim ds26522

From: Zhao Qiang Date: Mon, 27 Jun 2016 09:30:22 +0800 > Signed-off-by: Zhao Qiang Applied to net-next, thanks.

Re: [PATCH net 0/7] Mellanox 100G mlx5 fixes#2 for 4.7-rc

From: Saeed Mahameed Date: Mon, 27 Jun 2016 12:08:31 +0300 > Hi Dave, > > The following series provides one-liners fixes for mlx5 driver plus one > medium patch to reorganize ethtool counters reporting. > > Highlights: > - Added MODIFY_FLOW_TABLE to command strings

[PATCH v2 0/8] thunderbolt: Introducing Thunderbolt(TM) networking

This is version 2 of Thunderbolt(TM) driver for non-Apple hardware. Changes since v1: - Separation to 2 modules. - Moved ICM specific registers definition to ICM header file. - Added new Thunderbolt device IDs. - Renamed the Thunderbolt networking documentation. - General cleanups These

[PATCH v2 1/8] thunderbolt: Macro rename

This first patch updates the registers file to reflect that it isn't only for Cactus Ridge. No functional change intended. Signed-off-by: Amir Levy --- drivers/thunderbolt/nhi_regs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v2 4/8] thunderbolt: Kconfig for Thunderbolt(TM) networking

Updating the Kconfig Thunderbolt(TM) description. Signed-off-by: Amir Levy --- drivers/thunderbolt/Kconfig | 25 + drivers/thunderbolt/Makefile | 2 +- 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/drivers/thunderbolt/Kconfig

[PATCH V6 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

From: Tien Hock Loh This adds support for TSE PCS that uses SGMII adapter when the phy-mode of the dwmac is set to sgmii. Signed-off-by: Tien Hock Loh --- v2: - Refactored the TSE PCS out from the dwmac-socfpga.c file - Added binding documentation for TSE

Re: [PATCH net-next v3] tcp: use RFC6298 compliant TCP RTO calculation

On Tue, Jun 21, 2016 at 10:53 PM, Yuchung Cheng wrote: > > On Fri, Jun 17, 2016 at 11:56 AM, Yuchung Cheng wrote: > > > > On Fri, Jun 17, 2016 at 11:32 AM, David Miller wrote: > > > > > > From: Daniel Metz > > > Date:

Re: [PATCH 1/4] mac80211: mesh: flush stations before beacons are stopped

On Tue, 2016-06-28 at 14:13 +0300, Yaniv Machani wrote: > From: Maital Hahn > > Some drivers (e.g. wl18xx) expect that the last stage in the > de-initialization process will be stopping the beacons, similar to > ap. Update ieee80211_stop_mesh() flow accordingly. > How well have

Re: [PATCH] mac80211: util: mesh is not connected properly after recovery

On Tue, 2016-06-28 at 14:15 +0300, Yaniv Machani wrote: > From: Maital Hahn > > In the reconfigure process for mesh interface, moved the > reconfiguration > of the mesh peers to be done only after restarting the beacons, > the same as it is done for AP. > > Signed-off-by: Maital

Re: [PATCH] mac80211: util: mesh is not connected properly after recovery

Also - your subject lines should explain the *fix*, not the *bug* johannes

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

From: Timur Tabi Date: Fri, 24 Jun 2016 18:46:48 -0500 > + while (test_and_set_bit(EMAC_STATUS_RESETTING, >status)) > + msleep(20); /* Reset might take few 10s of ms */ ... > + while (test_and_set_bit(EMAC_STATUS_RESETTING, >status)) > +

Re: [PATCH net 0/5] batman-adv: Fixes for Linux 4.7

From: Sven Eckelmann Date: Sun, 26 Jun 2016 11:15:12 +0200 > Antonio currently seems to be occupied. This is currently rather > unfortunate because there are patches waiting in the batman-adv > development repository maint(enance) branch [1] since up to 6 > weeks. I am now

Re: [PATCH] net: ethernet: tundra: Correct argument for pci_free_consistent

From: Amitoj Kaur Chawla Date: Mon, 27 Jun 2016 14:34:50 +0530 > pci_free_consistent's argument 'struct pci_dev' should be NULL not 0. > > The Coccinelle semantic patch used to make this change is as follows: > @@ > @@ > > pci_free_consistent( > - 0 > + NULL > , ...) >

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

On Friday, June 24, 2016 6:46:48 PM CEST Timur Tabi wrote: > + /* The EMAC itself is capable of 64-bit DMA. If the SOC limits that > +* range, then we expect platform code to adjust the mask accordingly. > +*/ > + ret = dma_set_mask_and_coherent(>dev, DMA_BIT_MASK(64));

[PATCH v2 6/8] thunderbolt: Networking state machine

Negotiation states that a peer goes through in order to establish the communication with the second peer. This includes communication with upper layer and additional infrastructure support to communicate with the second peer through ICM. Signed-off-by: Amir Levy ---

[PATCH v2 5/8] thunderbolt: Communication with the ICM (firmware)

Firmware-based (a.k.a ICM - Intel Connection Manager) controller is used for establishing and maintaining the Thunderbolt Networking connection. We need to be able to communicate with it. Signed-off-by: Amir Levy --- drivers/thunderbolt/Makefile |2 +

Re: [PATCH] dsa: b53: avoid 'maybe-uninitialized' warning

From: Arnd Bergmann Date: Mon, 27 Jun 2016 11:19:13 +0200 > In some configurations, gcc produces a warning for correct code > in this driver: ... > I have seen the warning before and at the time thought I had fixed > it with 55e7f6abe131 ("dsa: b53: fix big-endian register

[PATCH v4] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule

When adding rule with NLM_F_EXCL flag then check if the same rule exist. If yes then exit with -EEXIST. This is already implemented in iproute2: if (cmd == RTM_NEWRULE) { req.n.nlmsg_flags |= NLM_F_CREATE|NLM_F_EXCL; req.r.rtm_type = RTN_UNICAST; }

Re: [PATCH v3] net: ethernet: ti: cpdma: switch to use genalloc

From: Grygorii Strashko Date: Mon, 27 Jun 2016 12:05:11 +0300 > TI CPDMA currently uses a bitmap for tracking descriptors alloactions > allocations, but The genalloc already handles the same and can be used > as with special memory (SRAM) as with DMA cherent memory

[PATCH v2 3/8] thunderbolt: Updating the register definitions

Adding more Thunderbolt(TM) register definitions and some helper macros. Signed-off-by: Amir Levy --- drivers/thunderbolt/nhi_regs.h | 109 + 1 file changed, 109 insertions(+) diff --git a/drivers/thunderbolt/nhi_regs.h

[PATCH v2 2/8] thunderbolt: Updating device IDs

Adding the new Thunderbolt(TM) device IDs to the list. Signed-off-by: Amir Levy --- include/linux/pci_ids.h | 44 ++-- 1 file changed, 26 insertions(+), 18 deletions(-) diff --git a/include/linux/pci_ids.h

Re: [PATCH] mac80211: rx: frames received out of order

On Tue, 2016-06-28 at 14:15 +0300, Yaniv Machani wrote: > From: Meirav Kama > > MP received data frames from another MP. Frames are forwarded > from Rx to Tx to be transmitted to a third MP. > Upon cloning the skb, the tx_info was zeroed, and the > hw_queue wasn't set correctly,

Re: [PATCH] net: marvell: Add separate config ANEG function for Marvell 88E1111

From: Harini Katakam Date: Mon, 27 Jun 2016 13:09:59 +0530 > Marvell 88E currently uses the generic marvell config ANEG function. > This function has a sequence accessing Page 5 and Register 31, > both of which are not defined or reserved for this PHY. > Hence this

[PATCH v2 7/8] thunderbolt: Networking transmit and receive

Handling the transmission to second peer and receiving from it. This includes communication with upper layer, the network stack and configuration of Thunderbolt(TM) HW. Signed-off-by: Amir Levy --- drivers/thunderbolt/icm_nhi.c | 15 + drivers/thunderbolt/net.c |

[PATCH v2 8/8] thunderbolt: Networking doc

Adding Thunderbolt(TM) networking documentation. Signed-off-by: Amir Levy --- Documentation/00-INDEX | 2 + Documentation/thunderbolt-networking.txt | 135 +++ 2 files changed, 137 insertions(+) create mode 100644

Re: [PATCH v10 07/22] IB/hns: Add event queue support

Hi, Leon 在 2016/6/24 23:46, Leon Romanovsky 写道: > On Thu, Jun 16, 2016 at 10:35:15PM +0800, Lijun Ou wrote: >> This patch added event queue support for RoCE driver. It is used >> for RoCE interrupt. RoCE includes 32 synchronous event irqs, 1 >> asynchronous event irq and 1 common overflow irq. >>

Re: [PATCH net-next 9/9] net: hns: get reset registers from DT

From: Yisen Zhuang Date: Mon, 27 Jun 2016 17:54:15 +0800 > @@ -361,9 +371,10 @@ static int hns_mdio_reset(struct mii_bus *bus) > return -ENODEV; > } > > + sc_reg = _dev->sc_reg; > /* 1. reset req, and read reset st

Re: [PATCH net-next 2/2] tipc: rename udp_port in struct udp_media_addr

From: Richard Alpe Date: Mon, 27 Jun 2016 13:34:07 +0200 > Context implies that port in struct "udp_media_addr" is referring > to a UDP port. > > Signed-off-by: Richard Alpe > Acked-by: Jon Maloy > Acked-by: Ying

Re: [ovs-dev] [PATCH net v2] openvswitch: fix conntrack netlink event delivery

On 28 June 2016 at 17:22, Samuel Gauthier wrote: > Only the first and last netlink message for a particular conntrack are > actually sent. The first message is sent through nf_conntrack_confirm when > the conntrack is committed. The last one is sent when the conntrack

DONATION OF $ 1.5 MILLION DOLLARS!!!

My wife and I have awarded you with a donation of $ 1.5 million Dollars from part of our Jackpot Lottery of 161,653,000 Million Pounds,Send your name,Address, Phone for claims Now. To verify the genuineness of this email, check this web page;

pull-request: mac80211 2016-06-29-v2

Hi Dave, Sorry to be sending a new pull request, but Felix had just submitted a fairly important fix and I decided I should send it on quickly. Now thus we have two fixes, one for the mesh refcounting issue and one for an issue with the ethertype/length field being too long when it's used as a

RE: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets

> From: Rick Jones [mailto:rick.jon...@hpe.com] > Sent: Tuesday, June 28, 2016 23:43 > To: Dexuan Cui ; David Miller > Cc: gre...@linuxfoundation.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; >

Re: [PATCH net-next 1/2] tipc: honor msg2addr return value

From: Richard Alpe Date: Mon, 27 Jun 2016 13:34:06 +0200 > The UDP msg2addr function tipc_udp_msg2addr() can return -EINVAL which > prior to this patch was unhanded in the caller. > > Signed-off-by: Richard Alpe > Acked-by: Jon Maloy

Re: [PATCH] net: the space is required before the open parenthesis '('

From: Wei Tang Date: Mon, 27 Jun 2016 18:12:46 +0800 > The space is missing before the open parenthesis '(', and this > will introduce much more noise when checking patch around. > > Signed-off-by: Wei Tang Applied.

Re: [PATCH v2 0/2] net: thunderx: Miscellaneous fixes

From: sunil.kovv...@gmail.com Date: Mon, 27 Jun 2016 15:30:01 +0530 > From: Sunil Goutham > > This 2 patch series fixes issues w.r.t physical link status > reporting and transmit datapath configuration for > secondary qsets. > > Changes from v1: > Fixed lmac disable

Re: [patch] qlcnic: use the correct ring in qlcnic_83xx_process_rcv_ring_diag()

From: Dan Carpenter Date: Mon, 27 Jun 2016 23:50:29 +0300 > There is a static checker warning here "warn: mask and shift to zero" > and the code sets "ring" to zero every time. From looking at how > QLCNIC_FETCH_RING_ID() is used in qlcnic_83xx_process_rcv_ring() the >

Re: [PATCH net-next 01/10] liquidio: Vxlan support

From: Raghu Vatsavayi Date: Tue, 28 Jun 2016 17:54:23 -0700 > @@ -3222,6 +3406,10 @@ static struct net_device_ops lionetdevops = { > .ndo_do_ioctl = liquidio_ioctl, > .ndo_fix_features = liquidio_fix_features, > .ndo_set_features

Re: [PATCH net] tcp: do not send too big packets at retransmit time

From: Eric Dumazet Date: Mon, 27 Jun 2016 17:38:50 +0200 > From: Eric Dumazet > > Arjun reported a bug in TCP stack and bisected it to a recent commit. > > In case where we process SACK, we can coalesce multiple skbs > into fat ones

Re: [PATCH net] net: bridge: fix vlan stats continue counter

From: Nikolay Aleksandrov Date: Mon, 27 Jun 2016 18:34:42 +0200 > I made a dumb off-by-one mistake when I added the vlan stats counter > dumping code. The increment should happen before the check, not after > otherwise we miss one entry when we continue dumping. > >

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

On 6/28/2016 7:19 PM, John Fastabend wrote: On 16-06-28 03:25 AM, Or Gerlitz wrote: On 6/28/2016 8:57 AM, John Fastabend wrote: hmm so in the hardware I have there is actually a l2 table and various other tables so I don't have any issue with doing table setup. I would like to see a

Re: [PATCH net] bpf, perf: delay release of BPF prog after grace period

From: Daniel Borkmann Date: Mon, 27 Jun 2016 21:38:11 +0200 > Commit dead9f29ddcc ("perf: Fix race in BPF program unregister") moved > destruction of BPF program from free_event_rcu() callback to __free_event(), > which is problematic if used with tail calls: if prog A is

Re:

Loan Offer at 3%, Feel Free to REPLY back to us for more info

Re: [PATCH 2/2] net: ethernet: mvpp2: use phy_ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Tue, 28 Jun 2016 00:08:12 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/2] net: ethernet: mvpp2: use phydev from struct net_device

From: Philippe Reynes Date: Tue, 28 Jun 2016 00:08:11 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one

Re: [PATCH net-next 0/6] net: dsa: Platform data for dsa2.c

From: Florian Fainelli Date: Mon, 27 Jun 2016 18:19:28 -0700 > 2016-06-27 18:05 GMT-07:00 Andrew Lunn : >> On Mon, Jun 27, 2016 at 05:52:37PM -0700, Florian Fainelli wrote: >>> Hi all, >>> >>> This patch series adds support for platform data using the new

Re: [PATCH] ip route: timeout for routes has to be set in seconds

Hi, On Wed, Jun 29, 2016 at 7:27 AM, Andrey Vagin wrote: > From: Andrew Vagin > > Currently a timeout is multiplied by HZ in user-space and > then it multiplied by HZ in kernel-space. > > $ ./ip/ip r add 2002::0/64 dev veth1 expires 10 > $ ./ip/ip -6 r >

RE: [net-next 02/16] i40e: add hw struct local variable

From: Jeff Kirsher > Sent: 29 June 2016 05:41 > From: Mitch Williams > > This function uses the i40e_hw struct all over the place, so why doesn't > it keep a pointer to the struct? Add this pointer as a local variable > and use it consistently throughout the function.

[GIT] Sparc

I've been travelling so this accumulates more than week or so of bug fixing. It perhaps looks a little worse than it really is. 1) Fix deadlock in ath10k driver, from Ben Greear. 2) Increase scan timeout in iwlwifi, from Luca Coelho. 3) Unbreak STP by properly reinjecting STP packets back

Re: [GIT] Sparc

Of course this should have been "[GIT] Networking", sigh...

Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

Hi Jon I know you are just refactoring code, but at some point it would be good to take a closer look at this MDIO bus driver. The MDIO bus driver should be generic, allowing access to all 32 addresses on the bus, if that makes sense. You could for example have a B53 switch hanging off the MDIO

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

On Wednesday, June 29, 2016 7:17:29 AM CEST Timur Tabi wrote: > Arnd Bergmann wrote: > > On Friday, June 24, 2016 6:46:48 PM CEST Timur Tabi wrote: > >> >+ /* The EMAC itself is capable of 64-bit DMA. If the SOC limits > >> >that > >> >+* range, then we expect platform code to

Re: [Patch net] mlx4: set csum_complete_sw bit when fixing complete csum

Hi Cong, See below. Does commit f8c6455bb04b944edb69e rely on any firmware change to get an expected checksum? $ lspci -nn | grep -i mellanox 82:00.0 Ethernet controller [0200]: Mellanox Technologies MT27500 Family [ConnectX-3] [15b3:1003] $ ethtool -i eth0 driver: mlx4_en version: 2.2-1 (Feb

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

Arnd Bergmann wrote: If the ranges property lists the bus as dma capable for only the lower 32 bits, then dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); should fail, otherwise dma_alloc_coherent() will return an invalid memory area. That seems wrong. dma_alloc_coherent() should be smart

Re: [Patch net] mlx4: set csum_complete_sw bit when fixing complete csum

On Wed, Jun 29, 2016 at 5:23 PM, Tariq Toukan wrote: > Hi Cong, > >> See below. Does commit f8c6455bb04b944edb69e rely on any firmware >> change to get an expected checksum? >> >> $ lspci -nn | grep -i mellanox >> 82:00.0 Ethernet controller [0200]: Mellanox Technologies

[PATCH] [linux-next] net: netcp: Fix a typo in keystone-netcp.txt

This patch fix a spelling typo in keystone-netcp.txt Signed-off-by: Masanari Iida --- Documentation/devicetree/bindings/net/keystone-netcp.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/keystone-netcp.txt

[patch] be2net: signedness bug in be_msix_enable()

"num_vec" needs to be signed for the error handling to work. Fixes: e261768e9e39 ('be2net: support asymmetric rx/tx queue counts') Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index

Re: [PATCH net-next v2 3/4] cgroup: bpf: Add bpf_skb_in_cgroup_proto

Hi, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Martin-KaFai-Lau/cgroup-Add-cgroup_get_from_fd/20160623-052247 config: x86_64-lkp (attached as .config) compiler: gcc-4.9 (Debian 4.9.3-14) 4.9.3 reproduce: # save the attached .config to

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

On 6/28/2016 10:31 PM, John Fastabend wrote: On 16-06-28 12:12 PM, Jiri Pirko wrote: Why?! Please, leave legacy be legacy. Use the new mode for implementing new features. Don't make things any more complicated :( OK so how I read this is there are two things going on that are being

Re: [net-next 07/16] i40e: Save PCI state before suspend

On Tue, 2016-06-28 at 21:40 -0700, Jeff Kirsher wrote: > From: Greg Rose > > The i40e_suspend() function was failing to save PCI state > and this would result in a kernel stack trace from a WARN_ONCE in the > pci_legacy_suspend() function. > > Add a call to

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

On Tue, Jun 28, 2016 at 7:23 PM, Herbert Xu wrote: > On Tue, Jun 28, 2016 at 10:35:31AM -0700, Andy Lutomirski wrote: >> >> Do you mean this code: > > Yes. > >> I'm wondering why support for scatterlists is all-or-nothing. Why >> can't we initialize a hash object and

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

On Wed, Jun 29, 2016 at 07:59:22AM -0700, Andy Lutomirski wrote: >> I suspect that, if you compare a synchronous implementation that can > use virtual addresses to a DMA based implementation that can't, you'll > find that, for short messages like tcp md5 uses, the synchronous > implementation

Re: [PATCH iproute2 1/6] ip vrf: Add name_is_vrf

On Mon, 27 Jun 2016 11:50:56 -0700 David Ahern wrote: > diff --git a/ip/ip_common.h b/ip/ip_common.h > index e8da9e034b15..410eb135774a 100644 > --- a/ip/ip_common.h > +++ b/ip/ip_common.h > @@ -90,6 +90,8 @@ struct link_util *get_link_slave_kind(const char >

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

On Wednesday, June 29, 2016 9:33:54 AM CEST Timur Tabi wrote: > Arnd Bergmann wrote: > > If the ranges property lists the bus as dma capable for only the > > lower 32 bits, then dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); > > should fail, otherwise dma_alloc_coherent() will return an invalid

Re: [PATCH v2 iproute2 0/6] Add support for vrf keyword

On Mon, 27 Jun 2016 11:50:55 -0700 David Ahern wrote: > Currently the syntax for VRF related commands is rather kludgy and > inconsistent from one subcommand to another. This set adds support > for the VRF keyword to the link, address, neigh, and route commands > to

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

Arnd Bergmann wrote: That's also not how it works: each device starts out with a 32-bit mask, because that's what historically all PCI devices can do. If a device is 64-bit DMA capable, it can extend the mask by passing DMA_BIT_MASK(64) (or whatever it can support), and the platform code checks

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

On Wed, Jun 29, 2016 at 8:02 AM, Herbert Xu wrote: > On Wed, Jun 29, 2016 at 07:59:22AM -0700, Andy Lutomirski wrote: >>> I suspect that, if you compare a synchronous implementation that can >> use virtual addresses to a DMA based implementation that can't, you'll >>

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

On Wednesday, June 29, 2016 10:10:59 AM CEST Timur Tabi wrote: > Arnd Bergmann wrote: > > That's also not how it works: each device starts out with a 32-bit mask, > > because that's what historically all PCI devices can do. If a device > > is 64-bit DMA capable, it can extend the mask by passing

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

On Wed, Jun 29, 2016 at 08:26:43AM -0700, Andy Lutomirski wrote: > > Two reasons: > > 1. Code like tcp md5 would be simpler if it could pass a scatterlist > to hash the skb but use a virtual address for the header. True. But I bet we can make it simpler in other ways without creating special

Re: brcmfmac: slightly simplify building interface combinations

Rafał Miłecki wrote: > This change reorders some operations in brcmf_setup_ifmodes in hope to > make it simpler: > 1) It allocates arrays right before filling them. This way it's easier >to follow requested array length as it's immediately followed by >code filling it. It's easier to check

Re: libertas_tf: Remove create_workqueue

Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workitem (viz > >cmd_work per priv, which maps to lbtf_cmd_work) is involved in > actual command processing and may be used on a memory

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

Arnd Bergmann wrote: Usually drivers try 64-bit mask and 32-bit masks, and the 32 bit mask is practically guaranteed to succeed. Sure, but in theory, my for-loop is correct, right? Wouldn't there be some value in setting a 36-bit or 40-bit DMA mask if it works? We have a platform where

Re: libertas: Add spinlock to avoid race condition

Pavel Andrianov wrote: > lbs_mac_event_disconnected may free priv->currenttxskb > while lbs_hard_start_xmit accesses to it. > The patch adds a spinlock for mutual exclusion. > > Tested on OLPC XO-1 (usb8388) and XO-1.5 (sd8686) with v4.7-rc3. > > Confirmed that

Re: wlcore: sdio: Fix crash on wlcore_probe_of when failing to parse/map irq

Bruno Herrera wrote: > pdev_data pointer is being freed with kfree but the pointer is not dynamic > allocated. > > Signed-off-by: Bruno Herrera Thanks, 1 patch applied to wireless-drivers-next.git: 6edc119ed3b5 wlcore: sdio: Fix crash on

Re: [v2] rtlwifi: use s8 instead of char

Arnd Bergmann wrote: > Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of > incorrect code that results from 'char' being unsigned here, e.g. > > realtek/rtlwifi/rc.c:113:18: error: comparison is always true due to limited > range of data type

Re: [1/8] wireless: airo: rename 'register' variable

Arnd Bergmann wrote: > 'register' is a keyword in C and cannot be used in place of a > variable name, as shown by this -Wextra warning: > > drivers/net/wireless/cisco/airo.c:1105:29: error: 'register' is not at > beginning of declaration [-Werror=old-style-declaration] > > This

Re: [REBASED] brcmfmac: fix lockup when removing P2P interface after event timeout

Rafał Miłecki wrote: > Removing P2P interface is handled by sending a proper request to the > firmware. On success firmware triggers an event and driver's handler > removes a matching interface. > > However on event timeout we remove interface directly from the cfg80211 > callback. Current code

Re: brcmfmac: use const char * for interface name in brcmf_add_if

Rafał Miłecki wrote: > This function can work just fine with const pointer, it only calls > alloc_netdev which take const as well. Moreover it makes this function > more flexible as some cfg80211 callback may provide const char * as > well, e.g. add_virtual_intf. This will be needed for more

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

Veli-Matti Lintu wrote: [...] >Thanks for the patch. I have been now testing it and the reselection >seems to be working now in most cases, but I hit one case that seems >to consistently fail in my test environment. > >I've been doing most of testing with

Re: brcmfmac: add missing break when deleting P2P_DEVICE

Rafał Miłecki wrote: > We obviously don't want to fall through in that switch. With this change > 1) We wait for event (triggered by p2p_disc) as expected > 2) We remove interface manually on timeout > 3) We return 0 on success instead of -ENOTSUPP > > Signed-off-by: Rafał Miłecki

Re: brcmfmac: include also core.h header in cfg80211.h

Rafał Miłecki wrote: > This header provides two inline functions using struct brcmf_if so we > need core.h to avoid: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h: In function > ‘ndev_to_prof’: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h:368:13: error: >

Re: [iproute PATCH v4] Use ARRAY_SIZE macro everywhere

On Tue, 28 Jun 2016 16:42:15 + Phil Sutter wrote: > This patch was generated by the following semantic patch (a trimmed down > version of what is shipped with Linux sources): > > @@ > type T; > T[] E; > @@ > ( > - (sizeof(E)/sizeof(*E)) > + ARRAY_SIZE(E) > | > -

Re: [PATCH] ip route: timeout for routes has to be set in seconds

> There's another issue. > now the expires transition with HZ happens in kernel when we add > route with expire, but when we dump, the expires transition is in the > user-space: > if (ci->rta_expires != 0) > fprintf(fp, " expires %dsec", >

[net 1/2] e1000e: keep Rx/Tx HW_VLAN_CTAG in sync

From: Jarod Wilson The bit in the e1000 driver that mentions explicitly that the hardware has no support for separate RX/TX VLAN accel toggling rings true for e1000e as well, and thus both NETIF_F_HW_VLAN_CTAG_RX and NETIF_F_HW_VLAN_CTAG_TX need to be kept in sync. Revert a

[net 2/2] ixgbevf: ixgbevf_write/read_posted_mbx should use IXGBE_ERR_MBX to initialize ret_val

From: Xin Long Now ixgbevf_write/read_posted_mbx use -IXGBE_ERR_MBX as the initiative return value, but it's incorrect, cause in ixgbevf_vlan_rx_add_vid(), it use err == IXGBE_ERR_MBX, the err returned from mac.ops.set_vfta, and in ixgbevf_set_vfta_vf, it return from

[net 0/2][pull request] Intel Wired LAN Driver Updates 2016-06-29

This series contains fixes to e1000e and ixgbevf. Jarod Wilson's fix for e1000e was a follow-on patch to his previous fix to keep the hardware VLAN CTAG's for receive and transmit in sync, which in turn resolves the original issue, so revert a portion of the original fix. Xin Long noticed that

Re: [net 2/2] ixgbevf: ixgbevf_write/read_posted_mbx should use IXGBE_ERR_MBX to initialize ret_val

On Wed, 2016-06-29 at 09:30 -0700, Jeff Kirsher wrote: > From: Xin Long > > Now ixgbevf_write/read_posted_mbx use -IXGBE_ERR_MBX as the initiative > return value, but it's incorrect, cause in ixgbevf_vlan_rx_add_vid(), > it use err == IXGBE_ERR_MBX, the err returned from

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

On Wed, Jun 29, 2016 at 8:38 AM, Herbert Xu wrote: > On Wed, Jun 29, 2016 at 08:26:43AM -0700, Andy Lutomirski wrote: >> >> Two reasons: >> >> 1. Code like tcp md5 would be simpler if it could pass a scatterlist >> to hash the skb but use a virtual address for the

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

On 16-06-29 07:48 AM, Or Gerlitz wrote: > On 6/28/2016 10:31 PM, John Fastabend wrote: >> On 16-06-28 12:12 PM, Jiri Pirko wrote: >>> >>> Why?! Please, leave legacy be legacy. Use the new mode for >>> implementing new features. Don't make things any more complicated :( >>> >> OK so how I read this

Re: [PATCH iproute2 1/6] ip vrf: Add name_is_vrf

On 6/29/16 9:06 AM, Stephen Hemminger wrote: On Mon, 27 Jun 2016 11:50:56 -0700 David Ahern wrote: diff --git a/ip/ip_common.h b/ip/ip_common.h index e8da9e034b15..410eb135774a 100644 --- a/ip/ip_common.h +++ b/ip/ip_common.h @@ -90,6 +90,8 @@ struct link_util

Re: [PATCH v2 iproute2 0/6] Add support for vrf keyword

On 6/29/16 9:07 AM, Stephen Hemminger wrote: On Mon, 27 Jun 2016 11:50:55 -0700 David Ahern wrote: Currently the syntax for VRF related commands is rather kludgy and inconsistent from one subcommand to another. This set adds support for the VRF keyword to the link,

[net-next 02/15] fm10k: Align Rx buffers to 512B blocks

From: Alexander Duyck While reviewing the i40e driver changes to support page based receive I realized that I had overlooked the fact that the fm10k hardware required a 512 byte alignment for Rx buffers. This patch is meant to address that by changing the alignment for Rx

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

On Wed, Jun 29, 2016 at 7:35 PM, John Fastabend wrote: > On 16-06-29 07:48 AM, Or Gerlitz wrote: >> On 6/28/2016 10:31 PM, John Fastabend wrote: >>> On 16-06-28 12:12 PM, Jiri Pirko wrote: Why?! Please, leave legacy be legacy. Use the new mode for implementing

[net-next 09/15] igb: re-use igb_ptp_reset in igb_ptp_init

From: Jacob Keller Modify igb_ptp_init to take advantage of igb_ptp_reset, and remove duplicated work that was occurring in both igb_ptp_reset and igb_ptp_init. In total, resetting the TSAUXC register, and resetting the system time both happen in igb_ptp_reset already.

[net-next 03/15] fm10k: fix incorrect index calculation in fm10k_write_reta

From: Jacob Keller The index calculated when looping through the indir array passed to fm10k_write_reta was incorrectly calculated as the first part i needs to be multiplied by 4. Fixes: 0cfea7a65738 ("fm10k: fix possible null pointer deref after kcalloc", 2016-04-13)

[net-next 14/15] ixgbe: fix spoofed packets with macvlans

From: Emil Tantilov When setting spoofing, both VLAN and MAC need to be set together. This change resolves an issue where MAC-VLANs on the VF fail to pass traffic due to spoofed packets. Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers

[net-next 11/15] igb: call igb_ptp_suspend during suspend/resume cycle

From: Jacob Keller Properly stop the extra workqueue items and ensure that we resume cleanly. This is better than using igb_ptp_init and igb_ptp_stop since these functions destroy the PHC device, which will cause other problems if we do so. Since igb_ptp_reset now

[net-next 15/15] igb: Only DMA sync frame length

From: Andrew Lunn On some platforms, syncing a buffer for DMA is expensive. Rather than sync the whole 2K receive buffer, only synchronise the length of the frame, which will typically be the MTU, or a much smaller TCP ACK. For an IMX6Q, this gives around 6% increased TCP

  1   2   3   >