Re: Fwd: Fwd: Re: [PATCH net-next 00/15] net/smc: Shared Memory Communications - RDMA

2016-07-12 Thread Benjamin Poirier
On 2016/07/12 11:08, Benjamin Poirier wrote: > On 2016/07/06 17:29, Ursula Braun wrote: > > Dave, > > > > we still like to see SMC-R included into a future Linux-kernel. After > > answering your first 2 questions, there is no longer a response. What should > > we do next? > > - Still wait for an

Re: [PATCH] net: Fragment large datagrams even when IP_HDRINCL is set.

2016-07-12 Thread David Miller
From: Alan Davey Date: Tue, 12 Jul 2016 12:34:07 + > - all future applications have to continue to implement their own > fragmentation code, duplicating that which already exists in the kernel They have to do this anyways, don't you see this? Otherwise they

Re: [PATCH v8 01/11] bpf: add XDP prog type for early driver filter

2016-07-12 Thread Jesper Dangaard Brouer
On Tue, 12 Jul 2016 00:51:24 -0700 Brenden Blanco wrote: > Add a new bpf prog type that is intended to run in early stages of the > packet rx path. Only minimal packet metadata will be available, hence a > new context type, struct xdp_md, is exposed to userspace. So far

Re: ethtool TODO list - additional info

2016-07-12 Thread Jorge Alberto Garcia
On Tue, Jul 12, 2016 at 12:55 PM, Jiri Pirko wrote: > Tue, Jul 05, 2016 at 05:37:42PM CEST, jorge.garcia.gonza...@gmail.com wrote: >>Hi ! >> >>Some days ago, Jiri Pirko was talking about some next steps to >>implement for ethtool. >> >> I haven't seen any follow up since

Re: Fwd: Fwd: Re: [PATCH net-next 00/15] net/smc: Shared Memory Communications - RDMA

2016-07-12 Thread Benjamin Poirier
On 2016/07/06 17:29, Ursula Braun wrote: > Dave, > > we still like to see SMC-R included into a future Linux-kernel. After > answering your first 2 questions, there is no longer a response. What should > we do next? > - Still wait for an answer from you? > - Resend the same whole SMC-R patch

Re: [PATCH -next] rxrpc: Fix error handling in af_rxrpc_init()

2016-07-12 Thread David Miller
From: weiyj...@163.com Date: Tue, 12 Jul 2016 11:21:17 + > From: Wei Yongjun > > security initialized after alloc workqueue, so we should exit security > before destroy workqueue in the error handing. > > Fixes: 648af7fca159 ("rxrpc: Absorb the rxkad security

Re: [PATCH -next] dwc_eth_qos: fix missing clk_disable_unprepare() on error in dwceqos_probe()

2016-07-12 Thread David Miller
From: weiyj...@163.com Date: Tue, 12 Jul 2016 11:43:37 + > From: Wei Yongjun > > Fix missing clk_disable_unprepare() call before return > from dwceqos_probe() in the error handling case of invalid > fixed-link. > > Signed-off-by: Wei Yongjun

Re: [PATCH -next] stmmac: dwmac-socfpga: fix wrong pointer passed to PTR_ERR()

2016-07-12 Thread David Miller
From: weiyj...@163.com Date: Tue, 12 Jul 2016 11:00:09 + > From: Wei Yongjun > > PTR_ERR should access the value just tested by IS_ERR, otherwise > the wrong error code will be returned. > > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH -next] net: mediatek: fix non static symbol warnings

2016-07-12 Thread David Miller
From: weiyj...@163.com Date: Tue, 12 Jul 2016 11:36:44 + > From: Wei Yongjun > > Fixes the following sparse warnings: > > drivers/net/ethernet/mediatek/mtk_eth_soc.c:79:5: warning: > symbol '_mtk_mdio_write' was not declared. Should it be static? >

Re: 4.6.3, pppoe + shaper workload, skb_panic / skb_push / ppp_start_xmit

2016-07-12 Thread nuclearcat
On 2016-07-12 21:05, Cong Wang wrote: On Tue, Jul 12, 2016 at 11:03 AM, wrote: On 2016-07-12 20:31, Cong Wang wrote: On Mon, Jul 11, 2016 at 12:45 PM, wrote: Hi On latest kernel i noticed kernel panic happening 1-2 times per day.

Re: ethtool TODO list - additional info

2016-07-12 Thread John W. Linville
On Tue, Jul 12, 2016 at 01:04:52PM -0500, Jorge Alberto Garcia wrote: > On Tue, Jul 12, 2016 at 12:55 PM, Jiri Pirko wrote: > > Tue, Jul 05, 2016 at 05:37:42PM CEST, jorge.garcia.gonza...@gmail.com wrote: > >>Hi ! > >> > >>Some days ago, Jiri Pirko was talking about some next

Re: ethtool TODO list - additional info

2016-07-12 Thread John Fastabend
On 16-07-12 11:12 AM, John W. Linville wrote: > On Tue, Jul 12, 2016 at 01:04:52PM -0500, Jorge Alberto Garcia wrote: >> On Tue, Jul 12, 2016 at 12:55 PM, Jiri Pirko wrote: >>> Tue, Jul 05, 2016 at 05:37:42PM CEST, jorge.garcia.gonza...@gmail.com wrote: Hi ! Some

[PATCH -next] net: dsa: Fix non static symbol warning

2016-07-12 Thread weiyj_lk
From: Wei Yongjun Fixes the following sparse warning: net/dsa/dsa2.c:680:6: warning: symbol '_dsa_unregister_switch' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/dsa/dsa2.c | 2 +- 1 file changed, 1

[PATCH nf-next v2 1/3] netfilter: bridge: add and use br_nf_hook_thresh

2016-07-12 Thread Aaron Conole
From: Florian Westphal This replaces the last uses of NF_HOOK_THRESH(). Followup patch will remove it and rename nf_hook_thresh. The reason is that inet (non-bridge) netfilter no longer invokes the hooks from hooks, so we do no longer need the thresh value to skip hooks with a

[PATCH nf-next v2 2/3] netfilter: call nf_hook_state_init with rcu_read_lock held

2016-07-12 Thread Aaron Conole
From: Florian Westphal This makes things simpler because we can store the head of the list in the nf_state structure without worrying about concurrent add/delete of hook elements from the list. Signed-off-by: Florian Westphal Signed-off-by: Aaron Conole

[PATCH 1/1] net: nps_enet: Fix PCS reset

2016-07-12 Thread Elad Kanfi
From: Noam Camus During commit b54b8c2d6e3c ("net: ezchip: adapt driver to little endian architecture") adapting to little endian architecture, zeroing of controller was left out. Signed-off-by: Elad Kanfi ---

[PATCH nf-next v2 0/3] Compact netfilter hooks list

2016-07-12 Thread Aaron Conole
This series makes a simple change to shrink the netfilter hook list from a double linked list, to a singly linked list. Since the hooks are always traversed in-order, there is no need to maintain a previous pointer. This was jointly developed by Florian Westphal. It has been tested with RCU and

[PATCH v2 3/3] netfilter: replace list_head with single linked list

2016-07-12 Thread Aaron Conole
The netfilter hook list never uses the prev pointer, and so can be trimmed to be a smaller singly-linked list. In addition to having a more light weight structure for hook traversal, struct net becomes 5568 bytes (down from 6400) and struct net_device becomes 2176 bytes (down from 2240).

RE: [PATCH v6 RESEND] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-07-12 Thread Mario_Limonciello
> -Original Message- > From: Michał Pecio [mailto:michal.pe...@gmail.com] > Sent: Tuesday, July 12, 2016 2:03 AM > To: David Miller > Cc: Limonciello, Mario ; linux- > ker...@vger.kernel.org; netdev@vger.kernel.org; linux- >

[PATCH -next] ixgbe: Add missing destroy_workqueue() on error in ixgbe_init_module()

2016-07-12 Thread weiyj_lk
From: Wei Yongjun Add the missing destroy_workqueue() before return from ixgbe_init_module() in the error handling case. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 1 + 1 file changed, 1

Re: [PATCH v3] Marvell phy: add fiber status check and configuration for some phys

2016-07-12 Thread Andrew Lunn
On Tue, Jul 12, 2016 at 05:00:52PM +0200, Charles-Antoine Couret wrote: > Hello, > I'm back with another patch evrsion about Marvell phys with a fiber interface. > >From the previous release, I fixed some issues reported by yours and I added > >some functions around the fiber interface to get

[PATCH v3] Marvell phy: add fiber status check and configuration for some phys

2016-07-12 Thread Charles-Antoine Couret
Hello, I'm back with another patch evrsion about Marvell phys with a fiber interface. >From the previous release, I fixed some issues reported by yours and I added >some functions around the fiber interface to get statistics, to configure the >aneg, etc. Yes, to implement that, copper and fiber

Re: [PATCH v3] Marvell phy: add fiber status check and configuration for some phys

2016-07-12 Thread Andrew Lunn
> +#define LPA_FIBER_1000HALF 0x40 > +#define LPA_FIBER_1000FULL 0x20 > + > +#define LPA_PAUSE_FIBER 0x180 > +#define LPA_PAUSE_ASYM_FIBER 0x100 > + > +#define ADVERTISE_FIBER_1000HALF 0x40 > +#define ADVERTISE_FIBER_1000FULL 0x20 > + > +#define ADVERTISE_PAUSE_FIBER

[iproute PATCH v2] ip-macsec.8: fix typo in 'examples' section

2016-07-12 Thread Davide Caratti
fix wrong 'device' keyword in 'ip link add device eth0' changes since v1: while at it, add missing description of 'validate' keyword and remove spurious bracket near 'encrypt' keyword. Also, wrong 'es' and 'encoding' keywords in MACsec section of ip-link.8 have been fixed. Signed-off-by: Davide

Re: [PATCH v8 01/11] bpf: add XDP prog type for early driver filter

2016-07-12 Thread Jakub Kicinski
On Tue, 12 Jul 2016 07:52:53 -0700, Tom Herbert wrote: > On Tue, Jul 12, 2016 at 6:14 AM, Jesper Dangaard Brouer > wrote: > > > > On Tue, 12 Jul 2016 00:51:24 -0700 Brenden Blanco > > wrote: > > > >> Add a new bpf prog type that is intended to run in

[patch net-next v2 2/2] mlxsw: core: Trace EMAD messages

2016-07-12 Thread Jiri Pirko
From: Jiri Pirko Trace EMAD messages going down to HW and up from HW. Devlink needs to be registered before EMAD init so the trace function can be called with valid devlink handle. Signed-off-by: Jiri Pirko v1->v2: - Use trace_devlink_hwmsg directly ---

[patch net-next v2 1/2] devlink: add hardware messages tracing facility

2016-07-12 Thread Jiri Pirko
From: Jiri Pirko Define a tracepoint and allow user to trace messages going to and from hardware associated with devlink instance. Signed-off-by: Jiri Pirko --- v1->v2: - Use EXPORT_TRACEPOINT_SYMBOL_GPL instead of a wrapper function as suggested by

[PATCH 0/6] Netfilter/IPVS fixes for net

2016-07-12 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter/IPVS fixes for your net tree. they are: 1) Fix leak in the error path of nft_expr_init(), from Liping Zhang. 2) Tracing from nf_tables cannot be disabled, also from Zhang. 3) Fix an integer overflow on 32bit archs when setting the number of

[PATCH 4/6] ipvs: fix bind to link-local mcast IPv6 address in backup

2016-07-12 Thread Pablo Neira Ayuso
From: Quentin Armitage When using HEAD from https://git.kernel.org/cgit/utils/kernel/ipvsadm/ipvsadm.git/, the command: ipvsadm --start-daemon backup --mcast-interface eth0.60 \ --mcast-group ff02::1:81 fails with the error message: Argument list too long whereas

[PATCH 2/6] netfilter: nft_meta: set skb->nf_trace appropriately

2016-07-12 Thread Pablo Neira Ayuso
From: Liping Zhang When user add a nft rule to set nftrace to zero, for example: # nft add rule ip filter input nftrace set 0 We should set nf_trace to zero also. Signed-off-by: Liping Zhang Signed-off-by: Pablo Neira Ayuso

[PATCH 1/6] netfilter: nf_tables: fix memory leak if expr init fails

2016-07-12 Thread Pablo Neira Ayuso
From: Liping Zhang If expr init fails then we need to free it. So when the user add a nft rule as follows: # nft add rule filter input tcp dport 22 flow table ssh \ { ip saddr limit rate 0/second } memory leak will happen. Signed-off-by: Liping Zhang

Re: [net-next PATCH RFC] mlx4: RX prefetch loop

2016-07-12 Thread Alexander Duyck
On Tue, Jul 12, 2016 at 5:45 AM, Jesper Dangaard Brouer wrote: > On Mon, 11 Jul 2016 16:05:11 -0700 > Alexei Starovoitov wrote: > >> On Mon, Jul 11, 2016 at 01:09:22PM +0200, Jesper Dangaard Brouer wrote: >> > > - /* Process all completed CQEs */

[PATCH 6/6] netfilter: conntrack: skip clash resolution if nat is in place

2016-07-12 Thread Pablo Neira Ayuso
The clash resolution is not easy to apply if the NAT table is registered. Even if no NAT rules are installed, the nul-binding ensures that a unique tuple is used, thus, the packet that loses race gets a different source port number, as described by:

[PATCH 3/6] netfilter: conntrack: avoid integer overflow when resizing

2016-07-12 Thread Pablo Neira Ayuso
From: Florian Westphal Can overflow so we might allocate very small table when bucket count is high on a 32bit platform. Note: resize is only possible from init_netns. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso ---

[PATCH 5/6] netfilter: nft_ct: fix expiration getter

2016-07-12 Thread Pablo Neira Ayuso
From: Florian Westphal We need to compute timeout.expires - jiffies, not the other way around. Add a helper, another patch can then later change more places in conntrack code where we currently open-code this. Will allow us to only change one place later when we remove per-ct

Re: eBPF tunable max instructions or max tail call?

2016-07-12 Thread Sargun Dhillon
On Mon, Jul 11, 2016 at 8:14 PM, Alexei Starovoitov wrote: > On Mon, Jul 11, 2016 at 05:56:07PM -0700, Sargun Dhillon wrote: >> It would be nice to have eBPF programs that are longer than 4096 >> instructions. I'm trying to implement XSalsa20 in eBPF, and >>

Re: [PATCH v3] Marvell phy: add fiber status check and configuration for some phys

2016-07-12 Thread Charles-Antoine Couret
Le 12/07/2016 à 17:18, Andrew Lunn a écrit : > Hi Charles It's Charles-Antoine. ;) > > It is best to submit a number of smaller patches, each doing one > thing, than a single big patch. It makes review and discussion much > simpler. I'm sorry, I will fix that. > So for example, this should

Re: [PATCH v7 04/11] net/mlx4_en: add support for fast rx drop bpf program

2016-07-12 Thread Brenden Blanco
On Mon, Jul 11, 2016 at 11:17:00PM -0700, David Miller wrote: > From: Brenden Blanco > Date: Mon, 11 Jul 2016 14:29:51 -0700 > > > + if (priv->num_frags > 1) > > + return -EOPNOTSUPP; > > I hate to be the user who has to debug why his XDP program won't > load

Re: [PATCH net v2 0/2] net: ethoc: Error path and transmit fixes

2016-07-12 Thread David Miller
From: Max Filippov Date: Tue, 12 Jul 2016 16:51:10 +0300 > Hello, > > On Mon, Jul 11, 2016 at 04:35:53PM -0700, Florian Fainelli wrote: >> This patch series contains two patches for the ethoc driver while testing on >> a >> TS-7300 board where ethoc is provided by an

Re: [RFC PATCH v3] net: sched: convert qdisc linked list to hashtable

2016-07-12 Thread Cong Wang
On Mon, Jul 11, 2016 at 7:02 AM, Jiri Kosina wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index f45929c..0b5c172e 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -52,6 +52,7 @@ > #include > #include > #include

Re: [PATCH net-next,v3] tools: hv: Add a script to help bonding synthetic and VF NICs

2016-07-12 Thread David Miller
From: Haiyang Zhang Date: Mon, 11 Jul 2016 17:06:42 -0700 > From: Haiyang Zhang > > This script helps to create bonding network devices based on synthetic NIC > (the virtual network adapter usually provided by Hyper-V) and the matching >

Re: [patch net-next v2 1/2] devlink: add hardware messages tracing facility

2016-07-12 Thread Steven Rostedt
On Tue, 12 Jul 2016 18:05:03 +0200 Jiri Pirko wrote: > From: Jiri Pirko > > Define a tracepoint and allow user to trace messages going to and from > hardware associated with devlink instance. > > Signed-off-by: Jiri Pirko > --- >

Re: [RFC PATCH net-next 1/1] Introduce skbmod action

2016-07-12 Thread Cong Wang
On Mon, Jul 11, 2016 at 5:12 AM, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > This action is intended to be an upgrade from a usability perspective > from pedit. Compare this: > Definitely agree we need a more user-friendly interface. > > pedit is

Re: [patch net-next v2 1/2] devlink: add hardware messages tracing facility

2016-07-12 Thread Jiri Pirko
Tue, Jul 12, 2016 at 06:38:26PM CEST, rost...@goodmis.org wrote: >On Tue, 12 Jul 2016 18:05:03 +0200 >Jiri Pirko wrote: > >> From: Jiri Pirko >> >> Define a tracepoint and allow user to trace messages going to and from >> hardware associated with devlink

Re: [PATCH 0/6] Netfilter/IPVS fixes for net

2016-07-12 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 12 Jul 2016 18:10:56 +0200 > The following patchset contains Netfilter/IPVS fixes for your net tree. > they are: > > 1) Fix leak in the error path of nft_expr_init(), from Liping Zhang. > > 2) Tracing from nf_tables cannot be disabled,

Re: [patch net-next v2 1/2] devlink: add hardware messages tracing facility

2016-07-12 Thread Steven Rostedt
On Tue, 12 Jul 2016 19:10:46 +0200 Jiri Pirko wrote: > Tue, Jul 12, 2016 at 06:38:26PM CEST, rost...@goodmis.org wrote: > >On Tue, 12 Jul 2016 18:05:03 +0200 > >Jiri Pirko wrote: > > > >> From: Jiri Pirko > >> > >> Define a tracepoint

Re: 4.6.3, pppoe + shaper workload, skb_panic / skb_push / ppp_start_xmit

2016-07-12 Thread Cong Wang
On Mon, Jul 11, 2016 at 12:45 PM, wrote: > Hi > > On latest kernel i noticed kernel panic happening 1-2 times per day. It is > also happening on older kernel (at least 4.5.3). > ... > [42916.426463] Call Trace: > [42916.426658] > > [42916.426719] []

Re: [PATCH] virtio-net: Remove more stack DMA

2016-07-12 Thread David Miller
From: Andy Lutomirski Date: Mon, 11 Jul 2016 14:30:28 -0700 > DaveM, is it okay for this to go in via -tip? Sure.

Re: ethtool TODO list - additional info

2016-07-12 Thread David Miller
From: "John W. Linville" Date: Tue, 12 Jul 2016 14:12:52 -0400 > I haven't heard a strong case for why it is necessary. Stats on large scale setups/systems is problematic and ethtool is a part of that problem. Extensibility in general suffers because of the ioctl()

Re: [PATCH -next] net: dsa: Fix non static symbol warning

2016-07-12 Thread David Miller
From: weiyj...@163.com Date: Tue, 12 Jul 2016 15:24:10 + > From: Wei Yongjun > > Fixes the following sparse warning: > > net/dsa/dsa2.c:680:6: warning: > symbol '_dsa_unregister_switch' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun

Re: XDP seeking input from NIC hardware vendors

2016-07-12 Thread John Fastabend
On 16-07-11 07:24 PM, Alexei Starovoitov wrote: > On Sat, Jul 09, 2016 at 01:27:26PM +0200, Jesper Dangaard Brouer wrote: >> On Fri, 8 Jul 2016 18:51:07 +0100 >> Jakub Kicinski wrote: >> >>> On Fri, 8 Jul 2016 09:45:25 -0700, John Fastabend wrote: The only

Re: XDP seeking input from NIC hardware vendors

2016-07-12 Thread Jakub Kicinski
On Tue, 12 Jul 2016 12:13:01 -0700, John Fastabend wrote: > On 16-07-11 07:24 PM, Alexei Starovoitov wrote: > > On Sat, Jul 09, 2016 at 01:27:26PM +0200, Jesper Dangaard Brouer wrote: > >> On Fri, 8 Jul 2016 18:51:07 +0100 > >> Jakub Kicinski wrote: > >> > >>> On

Re: [net-next PATCH RFC] mlx4: RX prefetch loop

2016-07-12 Thread Jesper Dangaard Brouer
On Tue, 12 Jul 2016 09:46:26 -0700 Alexander Duyck wrote: > On Tue, Jul 12, 2016 at 5:45 AM, Jesper Dangaard Brouer > wrote: > > On Mon, 11 Jul 2016 16:05:11 -0700 > > Alexei Starovoitov wrote: > > > >> On Mon, Jul

Re: [PATCH iptables 3/3] libxt_hashlimit: iptables-restore does not work as expected with xt_hashlimit

2016-07-12 Thread Vishwanath Pai
On 07/08/2016 07:54 AM, Pablo Neira Ayuso wrote: > We have to keep the existing behaviour. Yes, it's broken or ambiguos > but there may be people outthere relying on this. > > What I think we can do to resolve this scenario that you describe > abobe is to provide a new option: > >

Re: ethtool TODO list - additional info

2016-07-12 Thread John W. Linville
On Tue, Jul 12, 2016 at 11:34:06AM -0700, David Miller wrote: > From: "John W. Linville" > Date: Tue, 12 Jul 2016 14:12:52 -0400 > > > I haven't heard a strong case for why it is necessary. > > Stats on large scale setups/systems is problematic and ethtool > is a part of

<    1   2