[PATCH 0/2] net: Consider fragmentation of udp tunneled skbs in 'ip_finish_output_gso'

2016-07-18 Thread Shmulik Ladkani
Currently IP fragmentation of GSO segments that exceed dst mtu is considered only in the ipv4 forwarding case. There are cases where GSO skbs that are bridged and then udp-tunneled may have gso_size exceeding the egress device mtu. It makes sense to fragment them, as in the non GSOed code path.

Re: [PATCH v8 04/11] net/mlx4_en: add support for fast rx drop bpf program

2016-07-18 Thread Tom Herbert
On Mon, Jul 18, 2016 at 11:10 AM, Thomas Graf wrote: > On 07/15/16 at 10:49am, Tom Herbert wrote: >> I'm really missing why having a program pointer per ring could be so >> complicated. This should just a matter of maintaining a pointer to the >> BPF program program in each RX

Re: [PATCH net] bnxt_en: Fix potential race condition in bnxt_tx_enable()

2016-07-18 Thread Michael Chan
On Fri, Jul 15, 2016 at 11:20 PM, David Miller wrote: > From: Florian Fainelli > Date: Fri, 15 Jul 2016 16:42:01 -0700 > >> @@ -4599,7 +4599,9 @@ static void bnxt_tx_enable(struct bnxt *bp) >> for (i = 0; i < bp->tx_nr_rings; i++) { >>

[PATCH net-next 3/6] bnxt_en: Workaround Nitro A0 hardware RX bug (part 2).

2016-07-18 Thread Michael Chan
From: Prashant Sreedharan The hardware is unable to drop rx packets not matching the RX filters. To workaround it, we create a special VNIC and configure the hardware to direct all packets not matching the filters to it. We then setup the driver to drop

[PATCH net-next 5/6] bnxt_en: Workaround Nitro A0 RX hardware bug (part 4).

2016-07-18 Thread Michael Chan
From: Prashant Sreedharan Allocate special vnic for dropping packets not matching the RX filters. First vnic is for normal RX packets and the driver will drop all packets on the 2nd vnic. Signed-off-by: Prashant Sreedharan

[PATCH net-next 6/6] bnxt_en: Add BCM58700 PCI device ID for NS2 Nitro.

2016-07-18 Thread Michael Chan
From: Prashant Sreedharan A bridge device in NS2 has the same device ID as the ethernet controller. Add check to avoid probing the bridge device. Signed-off-by: Prashant Sreedharan Signed-off-by: Vasundhara Volam

[PATCH net-next 2/6] bnxt_en: Workaround Nitro A0 hardware RX bug (part 1).

2016-07-18 Thread Michael Chan
From: Prashant Sreedharan Nitro A0 has a hardware bug in the rx path. The workaround is to create a special COS context as a path for non-RSS (non-IP) packets. Without this workaround, the chip may stall when receiving RSS and non-RSS packets. Add

[PATCH net-next 1/6] bnxt_en: Add basic support for Nitro in North Star 2.

2016-07-18 Thread Michael Chan
From: Prashant Sreedharan Nitro is the embedded version of the ethernet controller in the North Star 2 SoC. Add basic code to recognize the chip ID and disable the features (ntuple, TPA, ring and port statistics) not supported on Nitro A0. Signed-off-by:

[PATCH net-next 0/6] bnxt_en: Add support for NS2 Nitro.

2016-07-18 Thread Michael Chan
This series adds support for the embedded version of the ethernet controller (Nitro) in the North Star 2 SoC. There are a number of features not supported and a software workaround for a hardware rx bug is required for Nitro A0. Please review. Prashant Sreedharan (6): bnxt_en: Add basic

[PATCH net-next 4/6] bnxt_en: Workaround Nitro A0 hardware RX bug (part 3).

2016-07-18 Thread Michael Chan
From: Prashant Sreedharan Allocate napi for special vnic, packets arriving on this napi will simply be dropped and the buffers will be replenished back to the HW. Signed-off-by: Prashant Sreedharan Signed-off-by: Vasundhara

Re: [PATCH 1/1] tracing, bpf: Implement function bpf_probe_write

2016-07-18 Thread Sargun Dhillon
On Sun, 17 Jul 2016, Alexei Starovoitov wrote: On Sun, Jul 17, 2016 at 03:19:13AM -0700, Sargun Dhillon wrote: +static u64 bpf_copy_to_user(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5) +{ + void *to = (void *) (long) r1; + void *from = (void *) (long) r2; + int size = (int)

Re: [PATCH v2] net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, allow segmentation for local udp tunneled skbs

2016-07-18 Thread Hannes Frederic Sowa
On 18.07.2016 12:11, Shmulik Ladkani wrote: > On Mon, 18 Jul 2016 12:06:00 +0200, han...@stressinduktion.org wrote: >>> Signed-off-by: Shmulik Ladkani >> >> I think this is reasonable, thanks! >> >> Acked-by: Hannes Frederic Sowa > > Thanks

Re: [PATCH net-next 1/1] net_sched: Introduce skbmod action

2016-07-18 Thread Jamal Hadi Salim
On 16-07-18 06:07 AM, Thomas Graf wrote: Right. I was at the same point as Jamal and it is nasty to try and reverse engineer the dumps without any further hints. I assume that's what he is referring to with difficulties. That +: if you get me a field which says "dstmac" i dont have to go

Re: [PATCH 1/2] net: ethernet: marvell: pxa168_eth: use phydev from struct net_device

2016-07-18 Thread Sergei Shtylyov
Hello. On 7/18/2016 12:30 AM, Philippe Reynes wrote: The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device.

Re: [PATCH v2] net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, allow segmentation for local udp tunneled skbs

2016-07-18 Thread Shmulik Ladkani
On Mon, 18 Jul 2016 12:06:00 +0200, han...@stressinduktion.org wrote: > > Signed-off-by: Shmulik Ladkani > > I think this is reasonable, thanks! > > Acked-by: Hannes Frederic Sowa Thanks for the feedback and assistance. I'll spin a v3

Re: [PATCH v0 06/10] arm: orion5x: Add DT-based support for Netgear WNR854T

2016-07-18 Thread Arnd Bergmann
On Monday, July 18, 2016 11:44:24 AM CEST Thomas Petazzoni wrote: > > On Sun, 17 Jul 2016 22:41:35 +0200, Arnd Bergmann wrote: > > > I would assume that the PCIe port should work out of the box with the driver > > Unfortunately, no. The PCIe on Orion5x requires a workaround for >

Re: [PATCH net-next 1/1] net_sched: Introduce skbmod action

2016-07-18 Thread Jamal Hadi Salim
On 16-07-18 05:44 AM, Daniel Borkmann wrote: On 07/18/2016 08:51 AM, Jamal Hadi Salim wrote: On 16-07-18 12:19 AM, Alexei Starovoitov wrote: Looking at that just out of curiosity on how complex it could look for src/dst mac, is it actually functional in iproute2 upstream tree? No it is a

Re: [PATCH net-next 1/1] net_sched: Introduce skbmod action

2016-07-18 Thread Thomas Graf
On 07/18/16 at 11:44am, Daniel Borkmann wrote: > Same for tcp, icmp, ipv6 bits code ... :/ Is it still planned to eventually > complete these? I agree that from a usability PoV, it might be nice to > have some kind of 'pretty printer' for it besides the existing config > parser there (e.g. when we

[PATCH v4 3/7] thunderbolt: Kconfig for Thunderbolt(TM) networking

2016-07-18 Thread Amir Levy
Updating the Kconfig Thunderbolt(TM) description. Signed-off-by: Amir Levy --- drivers/thunderbolt/Kconfig | 25 + drivers/thunderbolt/Makefile | 2 +- 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/drivers/thunderbolt/Kconfig

[PATCH v4 1/7] thunderbolt: Macro rename

2016-07-18 Thread Amir Levy
This first patch updates the registers file to reflect that it isn't only for Cactus Ridge. No functional change intended. Signed-off-by: Amir Levy --- drivers/thunderbolt/nhi_regs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v4 4/7] thunderbolt: Communication with the ICM (firmware)

2016-07-18 Thread Amir Levy
Firmware-based (a.k.a ICM - Intel Connection Manager) controller is used for establishing and maintaining the Thunderbolt Networking connection. We need to be able to communicate with it. Signed-off-by: Amir Levy --- drivers/thunderbolt/Makefile |1 +

[PATCH v4 6/7] thunderbolt: Networking transmit and receive

2016-07-18 Thread Amir Levy
Handling the transmission to second peer and receiving from it. This includes communication with upper layer, the network stack and configuration of Thunderbolt(TM) HW. Signed-off-by: Amir Levy --- drivers/thunderbolt/icm/icm_nhi.c | 15 +

[PATCH v4 2/7] thunderbolt: Updating the register definitions

2016-07-18 Thread Amir Levy
Adding more Thunderbolt(TM) register definitions and some helper macros. Signed-off-by: Amir Levy --- drivers/thunderbolt/nhi_regs.h | 109 + 1 file changed, 109 insertions(+) diff --git a/drivers/thunderbolt/nhi_regs.h

[PATCH v4 5/7] thunderbolt: Networking state machine

2016-07-18 Thread Amir Levy
Negotiation states that a peer goes through in order to establish the communication with the second peer. This includes communication with upper layer and additional infrastructure support to communicate with the second peer through ICM. Signed-off-by: Amir Levy ---

Re: [PATCH v2] net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, allow segmentation for local udp tunneled skbs

2016-07-18 Thread Hannes Frederic Sowa
On 15.07.2016 13:43, Shmulik Ladkani wrote: > Given: > - tap0 and vxlan0 are bridged > - vxlan0 stacked on eth0, eth0 having small mtu (e.g. 1400) > > Assume GSO skbs arriving from tap0 having a gso_size as determined by > user-provided virtio_net_hdr (e.g. 1460 corresponding to VM mtu of

[PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking

2016-07-18 Thread Amir Levy
This is version 4 of Thunderbolt(TM) driver for non-Apple hardware. Changes since v3: - Moved new Thunderbolt device IDs from pci_ids.h to icm_nhi.h. - Cleanup and added some comments in code. These patches were pushed to GitHub where they can be reviewed more comfortably with green/red

[PATCH v4 7/7] thunderbolt: Networking doc

2016-07-18 Thread Amir Levy
Adding Thunderbolt(TM) networking documentation. Signed-off-by: Amir Levy --- Documentation/00-INDEX | 2 + Documentation/thunderbolt-networking.txt | 135 +++ 2 files changed, 137 insertions(+) create mode 100644

RE: [PATCH v3 2/8] thunderbolt: Updating device IDs

2016-07-18 Thread Levy, Amir (Jer)
On Sat, Jul 16 2016, 12:53 AM, David Miller wrote: > From: "Levy, Amir (Jer)" > Date: Fri, 15 Jul 2016 18:56:39 + > > > On Fri, Jul 15 2016, 09:49 PM, David Miller wrote: > >> From: Amir Levy > >> Date: Thu, 14 Jul 2016 14:28:16 +0300 > >> >

Re: [PATCH v0 06/10] arm: orion5x: Add DT-based support for Netgear WNR854T

2016-07-18 Thread Thomas Petazzoni
Hello, On Sun, 17 Jul 2016 22:41:35 +0200, Arnd Bergmann wrote: > I would assume that the PCIe port should work out of the box with the driver Unfortunately, no. The PCIe on Orion5x requires a workaround for reading/writing the PCI configuration space. Instead of doing MMIO accesses to

Re: [PATCH net-next 1/1] net_sched: Introduce skbmod action

2016-07-18 Thread Daniel Borkmann
On 07/18/2016 08:51 AM, Jamal Hadi Salim wrote: On 16-07-18 12:19 AM, Alexei Starovoitov wrote: On Sun, Jul 17, 2016 at 04:41:24AM -0400, Jamal Hadi Salim wrote: From: Jamal Hadi Salim [...] I can imagine new tc command 'action skbmod dmac 02:15:15:15:15:15' that uses

[PATCH 2/4] Marvell phy: add field to get errors from fiber link.

2016-07-18 Thread Charles-Antoine Couret
Add support for the fiber receiver error counter in the statistics. Rename the current counter which is for copper errors to phy_receive_errors_copper, so it is easy to distinguish copper from fiber. Signed-off-by: Charles-Antoine Couret ---

[PATCH 4/4] Marvell phy: add functions to suspend and resume both interfaces: fiber and copper links.

2016-07-18 Thread Charles-Antoine Couret
Signed-off-by: Charles-Antoine Couret --- drivers/net/phy/marvell.c | 73 +-- 1 file changed, 71 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index

[PATCH v5 0/4] Marvell phy: manage fiber link for some phys

2016-07-18 Thread Charles-Antoine Couret
Another patchset to manage correctly the fiber link for some concerned Marvell's phy like 88E1512. This patchset fixed the commit log for the second commit and a line from the first commit moved to the second commit. Charles-Antoine Couret (4): Marvell phy: check link status in case of fiber

Re: [PATCH v8 04/11] net/mlx4_en: add support for fast rx drop bpf program

2016-07-18 Thread Thomas Graf
On 07/15/16 at 10:49am, Tom Herbert wrote: > I'm really missing why having a program pointer per ring could be so > complicated. This should just a matter of maintaining a pointer to the > BPF program program in each RX queue. If we want to latch together all > the rings to run the same program

Re: [CRIU] TCP_REPAIR MSS issue

2016-07-18 Thread Eggert, Lars
Hi, On 2016-06-16, at 23:09, Andrey Vagin wrote: > I can't reproduce this issue, now I'm trying to understand why it works > for me and doesn't work for you. just to conclude this thread for the list: Andrey and me debugged this off-list. The issue arose, because my code

[PATCH 1/4] Marvell phy: check link status in case of fiber link.

2016-07-18 Thread Charles-Antoine Couret
For concerned phy, the fiber link is checked before the copper link. According to datasheet, the link which is up is enabled. If both links are down, copper link would be used. To detect fiber link status, we used the real time status because of troubles with the copper method. Tested with

[PATCH 3/4] Marvell phy: add configuration of autonegociation for fiber link.

2016-07-18 Thread Charles-Antoine Couret
Signed-off-by: Charles-Antoine Couret --- drivers/net/phy/marvell.c | 111 +- 1 file changed, 109 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index

Re: [PATCH v8 04/11] net/mlx4_en: add support for fast rx drop bpf program

2016-07-18 Thread Daniel Borkmann
On 07/18/2016 06:01 AM, Alexei Starovoitov wrote: On Fri, Jul 15, 2016 at 09:09:52PM +0200, Jesper Dangaard Brouer wrote: On Fri, 15 Jul 2016 09:47:46 -0700 Alexei Starovoitov wrote: On Fri, Jul 15, 2016 at 09:18:13AM -0700, Tom Herbert wrote: [..] We don't

Re: [PATCH] sctp: load transport header after sk_filter

2016-07-18 Thread Daniel Borkmann
On 07/16/2016 11:33 PM, Willem de Bruijn wrote: From: Willem de Bruijn Do not cache pointers into the skb linear segment across sk_filter. The function call can trigger pskb_expand_head. Signed-off-by: Willem de Bruijn Fix looks good to me, thanks!

[patch iproute2] jsonw: Fix indentation of ending "}"

2016-07-18 Thread Jiri Pirko
From: Jiri Pirko Fix indentation of the very last "}" which is currently indented, leaving the last 2 "}" like this: \t} \t} EOF So fix it to be: \t} } EOF Fixes fcc16c2287 ("provide common json output formatter") Signed-off-by: Jiri Pirko ---

[RFC PATCH] net: macb: Handle HRESP error

2016-07-18 Thread Harini Katakam
Handle HRESP error by doing a SW reset of RX and TX and re-initializing the descriptors, RX and TX queue pointers. Signed-off-by: Harini Katakam --- drivers/net/ethernet/cadence/macb.c | 48 --- drivers/net/ethernet/cadence/macb.h |2 ++

Re: [PATCH net-next 1/1] net_sched: Introduce skbmod action

2016-07-18 Thread Jamal Hadi Salim
On 16-07-18 12:19 AM, Alexei Starovoitov wrote: On Sun, Jul 17, 2016 at 04:41:24AM -0400, Jamal Hadi Salim wrote: From: Jamal Hadi Salim This action is intended to be an upgrade from a usability perspective from pedit (as well as operational debugability). Compare this:

Re: [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers

2016-07-18 Thread David Miller
From: Sergei Shtylyov Date: Sun, 17 Jul 2016 16:06:24 +0300 >Here's a set of 2 patches against DaveM's 'net.git' repo fixing > up the DMA channel reporting by 'ifconfig'... Is some fixing some ifconfig output that is effectively meaningless appropriate

Re: [PATCH 2/2] net: ethernet: adi: bfin_mac: use phy_ethtool_{get|set}_link_ksettings

2016-07-18 Thread David Miller
From: Philippe Reynes Date: Sun, 17 Jul 2016 01:10:15 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > There was a check on CAP_NET_ADMIN in bfin_mac_ethtool_setsettings, >

Re: [PATCH 1/2] net: ethernet: adi: bfin_mac: use phydev from struct net_device

2016-07-18 Thread David Miller
From: Philippe Reynes Date: Sun, 17 Jul 2016 01:10:14 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one

Re: [PATCH 1/2] net: ethernet: marvell: pxa168_eth: use phydev from struct net_device

2016-07-18 Thread David Miller
From: Philippe Reynes Date: Sun, 17 Jul 2016 23:30:45 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one

Re: [PATCH 2/2] net: ethernet: marvell: pxa168_eth: use phy_ethtool_{get|set}_link_ksettings

2016-07-18 Thread David Miller
From: Philippe Reynes Date: Sun, 17 Jul 2016 23:30:46 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

<    1   2   3