[PATCH stable-4.1] netfilter: x_tables: fix stable backport

2016-07-19 Thread Michal Kubecek
Stable-4.1 backport of Florian Westphal's CVE-2016-4997 fixes doesn't handle correctly the fact that 4.1 kernel is missing commit 482cfc318559 ("netfilter: xtables: avoid percpu ruleset duplication"). Add code fragments needed for pre-4.2 kernels. Fixes: 8163327a3a92 ("netfilter: x_tables:

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-19 Thread Kristian Evensen
On Tue, Jul 19, 2016 at 8:20 AM, Oliver Neukum wrote: >> I had a look at some other drivers, and I think we need to be very >> careful about making setting a random MAC too generic. For example, we >> might be unlucky and break the possibly_iphdr()-code/assumption in >>

[PATCH net-next v3 0/2] bpf: add copy_to_user helper & example

2016-07-19 Thread Sargun Dhillon
This patch series contains two patches that add support for a copy_to_user helper to BPF programs. This allows them to manipulate user memory during the course of tracing. The second patch in the series has an example that uses it, in one the intended ways to divert execution. Thanks to Alexei

[PATCH net-next v3 1/2] bpf: Add bpf_copy_to_user BPF helper to be called in tracers (kprobes)

2016-07-19 Thread Sargun Dhillon
This allows user memory to be written to during the course of a kprobe. It shouldn't be used to implement any kind of security mechanism because of TOC-TOU attacks, but rather to debug, divert, and manipulate execution of semi-cooperative processes. Although it uses probe_kernel_write, we limit

[PATCH net-next v3 2/2] samples/bpf: Add example of using bpf_copy_to_user in bpf kprobes

2016-07-19 Thread Sargun Dhillon
This example shows using a kprobe to act as a dnat mechanism to divert traffic for arbitrary endpoints. It rewrite the arguments to a syscall while they're still in userspace, and before the syscall has a chance to copy the argument into kernel space. Signed-off-by: Sargun Dhillon

Re: [PATCHv2 net-next 1/3] net: Add provision to specify pf number while assigning VF mac

2016-07-19 Thread Hariprasad Shenai
On Fri, Jul 01, 2016 at 04:41:52 +, Yuval Mintz wrote: > > > > Chelsio T4/T5 cards have SR-IOV Capabilities on Physical Functions > > > > 0..3 and the administrative Driver(cxgb4) attaches to Physical Function > > > > 4. > > > > Each of the Physical Functions 0..3 can support up to 16 Virtual

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-19 Thread Oliver Neukum
On Mon, 2016-07-18 at 17:04 +0200, Kristian Evensen wrote: > On Mon, Jul 18, 2016 at 4:14 PM, Oliver Neukum wrote: > >> Ok, sounds good. So far, I have only seen the random MAC issue with > >> the three previously mentioned devices, but who knows how many else is > >> out there

Re: [PATCH v7] wlcore: spi: add wl18xx support

2016-07-19 Thread Kalle Valo
Eyal Reizer writes: > From: Eyal Reizer > > Add support for using with both wl12xx and wl18xx. > > - all wilink family needs special init command for entering wspi mode. > extra clock cycles should be sent after the spi init command while the > cs

Re: [PATCH 1/2] net/ipv4: Introduce IPSKB_FRAG_SEGS bit to inet_skb_parm.flags

2016-07-19 Thread Hannes Frederic Sowa
On 18.07.2016 13:49, Shmulik Ladkani wrote: > This flag indicates whether fragmentation of segments is allowed. > > Formerly this policy was hardcoded according to IPSKB_FORWARDED (set by > either ip_forward or ipmr_forward). > > Cc: Hannes Frederic Sowa > Cc:

[PATCH v6 1/4] Marvell phy: check link status in case of fiber link.

2016-07-19 Thread Charles-Antoine Couret
For concerned phy, the fiber link is checked before the copper link. According to datasheet, the link which is up is enabled. If both links are down, copper link would be used. To detect fiber link status, we used the real time status because of troubles with the copper method. Tested with

[PATCH v6 0/4] Marvell phy: fiber interface configuration

2016-07-19 Thread Charles-Antoine Couret
Another patchset to manage correctly the fiber link for some concerned Marvell's phy like 88E1512. This patchset fixed the commit log for the third and last commits and a comment in the first commit. Charles-Antoine Couret (4): Marvell phy: check link status in case of fiber link. Marvell

[PATCH v6 2/4] Marvell phy: add field to get errors from fiber link.

2016-07-19 Thread Charles-Antoine Couret
Add support for the fiber receiver error counter in the statistics. Rename the current counter which is for copper errors to phy_receive_errors_copper, so it is easy to distinguish copper from fiber. Reviewed-by: Andrew Lunn Signed-off-by: Charles-Antoine Couret

[PATCH net-next v2 0/2] bpf: add copy_to_user helper & example

2016-07-19 Thread Sargun Dhillon
This patch series contains two patches that add support for a copy_to_user helper to BPF programs. This allows them to manipulate user memory during the course of tracing. The second patch in the series has an example that uses it, in one the intended ways to divert execution. Thanks to Alexei

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-19 Thread Lars Melin
On 2016-07-19 13:40, Kristian Evensen wrote: I guess I can match on the VID/PID in usbnet, but won't it be cleaner to add a new bind() function (in cdc_ether) which matches the two PIDs and leave usbnet as is? Or am I misunderstanding how to add this functionality to usbnet? Matching on the

[PATCH v6] wlcore: spi: add wl18xx support

2016-07-19 Thread Reizer, Eyal
Add support for using with both wl12xx and wl18xx. - all wilink family needs special init command for entering wspi mode. extra clock cycles should be sent after the spi init command while the cs pin is high. - Use inverted chip select for sending a dummy 4 bytes command that completes the

Re: [PATCH v2 05/11] Kbuild: don't add obj tree in additional includes

2016-07-19 Thread Arnd Bergmann
On Monday, July 18, 2016 10:14:39 PM CEST Michal Marek wrote: > On Wed, Jun 15, 2016 at 05:45:47PM +0200, Arnd Bergmann wrote: > > When building with separate object directories and driver specific > > Makefiles that add additional header include paths, Kbuild adjusts > > the gcc flags so that we

Re: [PATCH v0 06/10] arm: orion5x: Add DT-based support for Netgear WNR854T

2016-07-19 Thread Jamie Lentin
On Mon, 18 Jul 2016, Arnd Bergmann wrote: On Monday, July 18, 2016 11:44:24 AM CEST Thomas Petazzoni wrote: On Sun, 17 Jul 2016 22:41:35 +0200, Arnd Bergmann wrote: I would assume that the PCIe port should work out of the box with the driver Unfortunately, no. The PCIe on Orion5x requires

RE: [PATCH v7] wlcore: spi: add wl18xx support

2016-07-19 Thread Reizer, Eyal
> > From: Eyal Reizer > > > > Add support for using with both wl12xx and wl18xx. > > > > - all wilink family needs special init command for entering wspi mode. > > extra clock cycles should be sent after the spi init command while the > > cs pin is high. > > - Use

[PATCH v6 4/4] Marvell phy: add functions to suspend and resume both interfaces: fiber and copper links.

2016-07-19 Thread Charles-Antoine Couret
These functions used standards registers in a different page for both interfaces: copper and fiber. Reviewed-by: Andrew Lunn Signed-off-by: Charles-Antoine Couret --- drivers/net/phy/marvell.c | 73

[PATCH v6 3/4] Marvell phy: add configuration of autonegociation for fiber link.

2016-07-19 Thread Charles-Antoine Couret
To be correctly initilized, the fiber interface needs to be configured via autonegociation registers which use some customs options or registers. Reviewed-by: Andrew Lunn Signed-off-by: Charles-Antoine Couret --- drivers/net/phy/marvell.c |

pull request: bluetooth-next 2016-07-19

2016-07-19 Thread Johan Hedberg
Hi Dave, Here's likely the last bluetooth-next pull request for the 4.8 kernel: - Fix for L2CAP setsockopt - Fix for is_suspending flag handling in btmrvl driver - Addition of Bluetooth HW & FW info fields to debugfs - Fix to use int instead of char for callback status. The last one (from

Re: [PATCH 1/1] tracing, bpf: Implement function bpf_probe_write

2016-07-19 Thread Alexei Starovoitov
On Mon, Jul 18, 2016 at 03:57:17AM -0700, Sargun Dhillon wrote: > > > On Sun, 17 Jul 2016, Alexei Starovoitov wrote: > > >On Sun, Jul 17, 2016 at 03:19:13AM -0700, Sargun Dhillon wrote: > >> > >>+static u64 bpf_copy_to_user(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5) > >>+{ > >>+ void *to = (void

[PATCH v7] wlcore: spi: add wl18xx support

2016-07-19 Thread Eyal Reizer
From: Eyal Reizer Add support for using with both wl12xx and wl18xx. - all wilink family needs special init command for entering wspi mode. extra clock cycles should be sent after the spi init command while the cs pin is high. - Use inverted chip select for sending a

Re: [PATCH] xfrm: fix crash in XFRM_MSG_GETSA netlink handler

2016-07-19 Thread Steffen Klassert
On Sun, Jul 10, 2016 at 02:21:13PM +0200, Steffen Klassert wrote: > On Wed, Jul 06, 2016 at 10:27:29AM +0800, Herbert Xu wrote: > > On Tue, Jul 05, 2016 at 12:13:03PM -0700, David Miller wrote: > > > From: Vegard Nossum > > > Date: Tue, 5 Jul 2016 10:18:08 +0200 > > >

Re: [PATCH 2/2] net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, allow segmentation for local udp tunneled skbs

2016-07-19 Thread Hannes Frederic Sowa
On 18.07.2016 13:49, Shmulik Ladkani wrote: > Given: > - tap0 and vxlan0 are bridged > - vxlan0 stacked on eth0, eth0 having small mtu (e.g. 1400) > > Assume GSO skbs arriving from tap0 having a gso_size as determined by > user-provided virtio_net_hdr (e.g. 1460 corresponding to VM mtu of

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-19 Thread Oliver Neukum
On Tue, 2016-07-19 at 08:40 +0200, Kristian Evensen wrote: > On Tue, Jul 19, 2016 at 8:20 AM, Oliver Neukum wrote: > >> I had a look at some other drivers, and I think we need to be very > >> careful about making setting a random MAC too generic. For example, we > >> might be

[PATCH net-next v2 2/2] Add example of using bpf_copy_to_user in bpf kprobes

2016-07-19 Thread Sargun Dhillon
This example shows using a kprobe to act as a dnat mechanism to divert traffic for arbitrary endpoints. It rewrite the arguments to a syscall while they're still in userspace, and before the syscall has a chance to copy the argument into kernel space. Signed-off-by: Sargun Dhillon

[PATCH net-next v2 1/2] Add bpf_copy_to_user BPF helper to be called in tracers (kprobes)

2016-07-19 Thread Sargun Dhillon
This allows user memory to be written to during the course of a kprobe. It shouldn't be used to implement any kind of security mechanism because of TOC-TOU attacks, but rather to debug, divert, and manipulate execution of semi-cooperative processes. Although it uses probe_kernel_write, we limit

Re: [patch 1/1] kernel/trace/bpf_trace.c: work around gcc-4.4.4 anon union initialization bug

2016-07-19 Thread Daniel Borkmann
On 07/19/2016 05:07 AM, Fengguang Wu wrote: On Mon, Jul 18, 2016 at 07:38:27PM -0700, Alexei Starovoitov wrote: On Tue, Jul 19, 2016 at 08:38:02AM +0800, Fengguang Wu wrote: On Mon, Jul 18, 2016 at 05:33:07PM -0700, Alexei Starovoitov wrote: [...] >Fengguang can you add gcc-4.4 to buildbot.

Re: [PATCH v0 06/10] arm: orion5x: Add DT-based support for Netgear WNR854T

2016-07-19 Thread Jamie Lentin
On Sun, 17 Jul 2016, Rob Herring wrote: On Sat, Jul 16, 2016 at 03:29:04PM +0100, Jamie Lentin wrote: This is a router based on the mv88f5181 chipset. http://www.netgear.com/support/product/WNR854T.aspx http://wiki.openwrt.org/toh/netgear/wnr854t Signed-off-by: Jamie Lentin

BUG: Wrong dma queue handling in ixp4 driver

2016-07-19 Thread Lino Sanfilippo
Hi, maybe I miss something, but the ixp4 ethernet driver seems to handle dma pools in a wrong way: In init_queues() it creates a dma pool for descriptors and then only allocates a single descriptor from this pool. The author seems to assume the whole table has been allocated already, since

[PATCH -next] net: axienet: Fix return value check in axienet_probe()

2016-07-19 Thread Wei Yongjun
From: Wei Yongjun In case of error, the function of_parse_phandle() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: 46aa27df8853 ('net: axienet: Use devm_* calls') Signed-off-by: Wei Yongjun

Re: [PATCH 2/4] net: ethernet: ti: cpsw: add multi queue support

2016-07-19 Thread Ivan Khoronzhuk
On 08.07.16 16:12, Grygorii Strashko wrote: On 06/30/2016 10:04 PM, Ivan Khoronzhuk wrote: The cpsw h/w supports up to 8 tx and 8 rx channels.This patch adds multi-queue support to the driver. An ability to configure h/w shaper will be added with separate patch. Default shaper mode, as

Re: [PATCH -next] net/mlx5: Use PTR_ERR_OR_ZERO() to simplify the code

2016-07-19 Thread Leon Romanovsky
On Tue, Jul 19, 2016 at 11:35:46AM +, Wei Yongjun wrote: > From: Wei Yongjun > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Wei Yongjun

Re: [PATCH net-next 1/1] net_sched: Introduce skbmod action

2016-07-19 Thread Jamal Hadi Salim
On 16-07-19 09:21 AM, Daniel Borkmann wrote: True, the 32 bit chunks are more generic and as such you need to put more effort in user space to handle them, but at the same time gain more flexibility w/o having to have a module for each and every proto. I dont see anything wrong with using

IPv6 IPSec incompatibilities between 2.6.23 and 3.6.18 (and probably later)

2016-07-19 Thread Pommnitz Jörg
Hello all, for years we have used the following manual IPsec rules to decrypt broadcast (all host multicast) messages: = snip === #!/bin/bash IP6ANYADDR=::/0 IP6BCAST=ff0e::1 KEY="0x7bef6ecaf06d29ef55b24aca6e19964b332e02e75be676a3" IFNAME=lan1 IP6ADDR=fd01:1b10:1000::1 PREFIX6=64

[patch net-next 2/2] mlxsw: spectrum: Expose per-tc counters via ethtool

2016-07-19 Thread Jiri Pirko
From: Ido Schimmel Expose the transmit queue length of each traffic class and the amount of unicast packets discarded due to insufficient room in the shared buffer. The first counter allows us to debug user priority to traffic class mapping, whereas the drop counter is

[patch net-next 0/2] mlxsw: Add per-{Prio,TC} counters

2016-07-19 Thread Jiri Pirko
From: Jiri Pirko Ido says: Add per-priority and per-tc counters, which are very useful for debugging purposes and fine-tuning. Ido Schimmel (2): mlxsw: spectrum: Expose per-priority counters via ethtool mlxsw: spectrum: Expose per-tc counters via ethtool

Re: [PATCH 4/4] net: ethernet: ti: cpsw: add ethtool channels support

2016-07-19 Thread Ivan Khoronzhuk
On 08.07.16 16:33, Grygorii Strashko wrote: On 06/30/2016 10:04 PM, Ivan Khoronzhuk wrote: These ops allow to control number of channels driver is allowed to work with. The maximum number of channels is 8 for rx and 8 for tx. After this patch the following commands are possible: $ ethtool -l

Re: [net-next v2 6/6] cxgb3i,cxgb4i: fix symbol not declared sparse warning

2016-07-19 Thread kbuild test robot
Hi, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Varun-Prakash/common-library-for-Chelsio-drivers/20160717-012538 config: x86_64-randconfig-s2-07191802 (attached as .config) compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7 reproduce: # save the

RE: [PATCH 3/3] mac80211: mesh: fixed HT ies in beacon template

2016-07-19 Thread Machani, Yaniv
On Mon, Jul 18, 2016 at 21:52:22, Johannes Berg wrote: > linux- wirel...@vger.kernel.org; netdev@vger.kernel.org > Subject: Re: [PATCH 3/3] mac80211: mesh: fixed HT ies in beacon > template > > On Mon, 2016-07-18 at 09:38 -0400, Bob Copeland wrote: > > On Wed, Jul 13, 2016 at 02:45:40PM +0300,

[patch net-next 1/2] mlxsw: spectrum: Expose per-priority counters via ethtool

2016-07-19 Thread Jiri Pirko
From: Ido Schimmel Expose per-priority bytes / packets / PFC packets counters via ethtool. These counters are very useful when debugging QoS functionality and provide a better insight into the device's forwarding plane. Signed-off-by: Ido Schimmel

RE: [RFC PATCH 00/30] Kernel NET policy

2016-07-19 Thread Liang, Kan
> > Yes, rtnl will bring some overheads. But the configuration is one time > > thing for application or socket. It only happens on receiving first > > packet. > > Thanks for destroying our connection rates. > > This kind of overhead is simply unacceptable. If so, I think I can make the

Re: [PATCH net-next 1/1] net_sched: Introduce skbmod action

2016-07-19 Thread Daniel Borkmann
On 07/18/2016 12:08 PM, Jamal Hadi Salim wrote: On 16-07-18 05:44 AM, Daniel Borkmann wrote: On 07/18/2016 08:51 AM, Jamal Hadi Salim wrote: On 16-07-18 12:19 AM, Alexei Starovoitov wrote: Looking at that just out of curiosity on how complex it could look for src/dst mac, is it actually

Re: [PATCH v0 00/10] Convert Netgear WNR854T to devicetree

2016-07-19 Thread Andrew Lunn
> However, the ethertype is reflecting the port:- > > lan1/5 : ethertype Unknown (0xc028), length 176: > lan2/7 : ethertype Unknown (0xc038), length 176: > lan3/0 : ethertype Unknown (0xc000), length 176: > lan4/1 : ethertype Unknown (0xc008), length 176: > wan/2 : ethertype Unknown (0xc010),

Re: [PATCH v0 00/10] Convert Netgear WNR854T to devicetree

2016-07-19 Thread Andrew Lunn
[Reducing the Cc: list a bit to networking people] > Okay. Frames sent from the port are EDSA-tagged (which isn't exactly > surprising), but I'm yet to see the switch receive 0xdada frames. > Even with the net-next branch which uses DSA_TAG_PROTO_EDSA for all > chip types. > > However, the

RE: [PATCH net-next v2 07/10] net/faraday: Read MAC address from chip

2016-07-19 Thread David Laight
From: Gavin Shan > Sent: 15 July 2016 11:44 > The device is assigned with random MAC address. It isn't reasonable. > An valid MAC address might have been provided by (uboot) firmware by > device-tree or in chip. It's reasonable to use it to maintain consistency. > > This uses the MAC address from

Re: [PATCH v2 2/3] mac80211: mesh: improve path resolving time

2016-07-19 Thread Bob Copeland
On Wed, Jul 13, 2016 at 02:45:25PM +0300, Yaniv Machani wrote: > When a packet is received for transmission, > a PREQ frame is sent to resolve the appropriate path to the desired > destination. > After path was established, any sequential PREQ will be sent only after >

Re: [PATCH net-next v2] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-19 Thread Kristian Evensen
On Tue, Jul 19, 2016 at 2:33 PM, Oliver Neukum wrote: > On Tue, 2016-07-19 at 13:49 +0200, Kristian Evensen wrote: >> @@ -428,10 +434,47 @@ int usbnet_cdc_bind(struct usbnet *dev, struct >> usb_interface *intf) >> return status; >> } >> >> + if

Re: [PATCH net-next 1/1] net_sched: Introduce skbmod action

2016-07-19 Thread Jamal Hadi Salim
On 16-07-18 01:38 PM, Cong Wang wrote: On Mon, Jul 18, 2016 at 3:26 AM, Jamal Hadi Salim wrote: On 16-07-18 06:07 AM, Thomas Graf wrote: Right. I was at the same point as Jamal and it is nasty to try and reverse engineer the dumps without any further hints. I assume

[PATCH net-next v2] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-19 Thread Kristian Evensen
The firmware in several ZTE devices (at least the MF823/831/910 modems/mifis) use OS fingerprinting to determine which type of device to export. In addition, these devices export a REST API which can be used to control the type of device. So far, on Linux, the devices have been seen as RNDIS or

Re: [PATCH v0 06/10] arm: orion5x: Add DT-based support for Netgear WNR854T

2016-07-19 Thread Arnd Bergmann
On Tuesday, July 19, 2016 10:40:16 AM CEST Jamie Lentin wrote: > On Mon, 18 Jul 2016, Arnd Bergmann wrote: > > > On Monday, July 18, 2016 11:44:24 AM CEST Thomas Petazzoni wrote: > >> > >> On Sun, 17 Jul 2016 22:41:35 +0200, Arnd Bergmann wrote: > >> > >>> I would assume that the PCIe port should

Re: [PATCH net-next v2 07/10] net/faraday: Read MAC address from chip

2016-07-19 Thread Benjamin Herrenschmidt
On Tue, 2016-07-19 at 10:50 +, David Laight wrote: > > + if (!is_valid_ether_addr(mac)) { > > + mac[5] = (m >> 8) & 0xff; > > + mac[4] = m & 0xff; > > + mac[3] = (l >> 24) & 0xff; > > + mac[2] = (l >> 16) & 0xff; > > + mac[1] = (l

[PATCH -next] net: cpmac: fix error handling of cpmac_probe()

2016-07-19 Thread Wei Yongjun
From: Wei Yongjun Add the missing free_netdev() before return from function cpmac_probe() in the error handling case. This patch revert commit 0465be8f4f1d ("net: cpmac: fix in releasing resources"), which changed to only free_netdev while register_netdev failed.

Re: [PATCH -next] net: ethernet: nb8800: fix error handling of nb8800_probe()

2016-07-19 Thread Måns Rullgård
Wei Yongjun writes: > From: Wei Yongjun > > In ops->reset() error handling case, clk_disable_unprepare() is missed > before return from this function. > > Signed-off-by: Wei Yongjun Acked-by: Mans Rullgard

[PATCH -next] net/mlx5: Use PTR_ERR_OR_ZERO() to simplify the code

2016-07-19 Thread Wei Yongjun
From: Wei Yongjun Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Wei Yongjun --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 10 ++ 1

Re: [PATCH v3] packet: fix second argument of sock_tx_timestamp()

2016-07-19 Thread Soheil Hassas Yeganeh
On Tue, Jul 19, 2016 at 1:40 AM, Yoshihiro Shimoda wrote: > This patch fixes an issue that a syscall (e.g. sendto syscall) cannot > work correctly. Since the sendto syscall doesn't have msg_control buffer, > the sock_tx_timestamp() in packet_snd() cannot work

Re: [PATCH v0 00/10] Convert Netgear WNR854T to devicetree

2016-07-19 Thread Jamie Lentin
On Sun, 17 Jul 2016, Andrew Lunn wrote: Firstly I've tried to to rebase against net-next[0], but after adding 6131 to mv88e6xxx_of_match, >ppu_work seems to be causing a NULL pointer ooops. I'll assume it's not done yet and ignore net-next for now. You don't need to modify mv88e6xxx_of_match,

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-19 Thread Kristian Evensen
Hi Lars, On Tue, Jul 19, 2016 at 10:30 AM, Lars Melin wrote: > On 2016-07-19 13:40, Kristian Evensen wrote: > >> I guess I can match on the VID/PID in usbnet, but won't it be cleaner >> to add a new bind() function (in cdc_ether) which matches the two PIDs >> and leave usbnet

[PATCH stable-4.1 v2] netfilter: x_tables: fix stable backport

2016-07-19 Thread Michal Kubecek
Stable-4.1 backport of mainline commit 364723410175 ("netfilter: x_tables: validate targets of jumps") doesn't handle correctly the fact that 4.1 kernel is missing commit 482cfc318559 ("netfilter: xtables: avoid percpu ruleset duplication") so that t->entries is still a per-cpu array in

Re: [PATCH net-next v3 1/2] bpf: Add bpf_copy_to_user BPF helper to be called in tracers (kprobes)

2016-07-19 Thread Daniel Borkmann
Hi Sargun, On 07/19/2016 11:32 AM, Sargun Dhillon wrote: This allows user memory to be written to during the course of a kprobe. It shouldn't be used to implement any kind of security mechanism because of TOC-TOU attacks, but rather to debug, divert, and manipulate execution of semi-cooperative

[PATCH -next] wan/fsl_ucc_hdlc: use module_platform_driver to simplify the code

2016-07-19 Thread Wei Yongjun
From: Wei Yongjun module_platform_driver() makes the code simpler by eliminating boilerplate code. Signed-off-by: Wei Yongjun --- drivers/net/wan/fsl_ucc_hdlc.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-)

[PATCH -next] wan/fsl_ucc_hdlc: remove .owner field for driver

2016-07-19 Thread Wei Yongjun
From: Wei Yongjun Remove .owner field if calls are used which set it automatically. Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Wei Yongjun --- drivers/net/wan/fsl_ucc_hdlc.c | 1 - 1 file

Aw: BUG: Wrong dma queue handling in ixp4 driver

2016-07-19 Thread Lino Sanfilippo
> Hi, > > maybe I miss something, but the ixp4 ethernet driver seems to handle dma > pools > in a wrong way: In init_queues() it creates a dma pool for descriptors and > then > only allocates a single descriptor from this pool. The author seems to > assume the whole > table has been

[PATCH -next] net: ethernet: nb8800: fix error handling of nb8800_probe()

2016-07-19 Thread Wei Yongjun
From: Wei Yongjun In ops->reset() error handling case, clk_disable_unprepare() is missed before return from this function. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/aurora/nb8800.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-07-19 Thread Netanel Belgazal
On 07/15/2016 08:00 AM, Leon Romanovsky wrote: > On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: >> This is a driver for the ENA family of networking devices. >> >> Signed-off-by: Netanel Belgazal >> --- >> >> Notes: > ... > >> - Increase driver

Re: [PATCH net-next v3 10/12] net: dsa: support switchdev ageing time attr

2016-07-19 Thread Andrew Lunn
On Mon, Jul 18, 2016 at 09:26:00PM -0700, Florian Fainelli wrote: > Le 18/07/2016 à 20:24, Andrew Lunn a écrit : > > On Mon, Jul 18, 2016 at 08:45:38PM -0400, Vivien Didelot wrote: > >> Add a new function for DSA drivers to handle the switchdev > >> SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME attribute.

[PATCH 1/3] rtlwifi: don't add include path for rtl8188ee

2016-07-19 Thread Arnd Bergmann
For rtl8188ee, we pass -Idrivers/net/wireless/rtlwifi/ to gcc, however that directy no longer exists, so evidently this option is no longer required here and can be removed to avoid a warning when building with 'make W=1' or 'gcc -Wmissing-include-dirs' Signed-off-by: Arnd Bergmann

[PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-19 Thread Arnd Bergmann
Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of incorrect code that results from 'char' being unsigned here, e.g. staging/rtl8192e/rtl8192e/r8192E_phy.c:1072:36: error: comparison is always false due to limited range of data type [-Werror=type-limits]

Re: [PATCH net-next v3 11/12] net: dsa: mv88e6xxx: add G1 helper for ageing time

2016-07-19 Thread Andrew Lunn
> Hi Vivien > > This is doing a read/modify/write, so should really hold the mutex. Upps. The mutex is held. Sorry for the noise. Andrew

[PATCH net-next v3] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-19 Thread Kristian Evensen
The firmware in several ZTE devices (at least the MF823/831/910 modems/mifis) use OS fingerprinting to determine which type of device to export. In addition, these devices export a REST API which can be used to control the type of device. So far, on Linux, the devices have been seen as RNDIS or

Re: [PATCH net-next 1/1] net_sched: Introduce skbmod action

2016-07-19 Thread Daniel Borkmann
On 07/19/2016 03:56 PM, Jamal Hadi Salim wrote: [...] But apart from this, neither pedit nor tcf_skbmod_run() here handle checksum complete, so you'll potentially get false positives wrt csum corruption and drops as a result when using either of the two. pedit maybe tricky. Any suggestions? On

Re: [PATCH v2 05/11] Kbuild: don't add obj tree in additional includes

2016-07-19 Thread Arnd Bergmann
On Tuesday, July 19, 2016 5:33:44 PM CEST Kalle Valo wrote: > Arnd Bergmann writes: > > > On Monday, July 18, 2016 10:14:39 PM CEST Michal Marek wrote: > >> On Wed, Jun 15, 2016 at 05:45:47PM +0200, Arnd Bergmann wrote: > >> > When building with separate object directories and

Re: [PATCH net-next v3 11/12] net: dsa: mv88e6xxx: add G1 helper for ageing time

2016-07-19 Thread Andrew Lunn
> +static int mv88e6xxx_g1_set_age_time(struct mv88e6xxx_chip *chip, > + unsigned int msecs) > +{ > + const unsigned int coeff = chip->info->age_time_coeff; > + const unsigned int min = 0x01 * coeff; > + const unsigned int max = 0xff * coeff; > + u8

Re: [PATCH v0 00/10] Convert Netgear WNR854T to devicetree

2016-07-19 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > [Reducing the Cc: list a bit to networking people] > >> Okay. Frames sent from the port are EDSA-tagged (which isn't exactly >> surprising), but I'm yet to see the switch receive 0xdada frames. >> Even with the net-next branch which uses

[PATCH 3/3] staging/rtl8192u: use s8 instead of char

2016-07-19 Thread Arnd Bergmann
Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of incorrect code that results from 'char' being unsigned here, e.g. staging/rtl8192u/r8192U_core.c:4150:16: error: comparison is always false due to limited range of data type [-Werror=type-limits]

Re: [PATCH v2 05/11] Kbuild: don't add obj tree in additional includes

2016-07-19 Thread Kalle Valo
Arnd Bergmann writes: > On Monday, July 18, 2016 10:14:39 PM CEST Michal Marek wrote: >> On Wed, Jun 15, 2016 at 05:45:47PM +0200, Arnd Bergmann wrote: >> > When building with separate object directories and driver specific >> > Makefiles that add additional header include paths,

Re: [PATCH V2] Add flow control to the portmapper

2016-07-19 Thread Shiraz Saleem
On Tue, Jul 19, 2016 at 08:40:06AM +0300, Leon Romanovsky wrote: > > You are the one user of this new inline function. > Why don't you directly call to netlink_unicast() in your ibnl_unicast() > without messing with widely visible header file? Since there is a non-blocking version of

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-19 Thread Arnd Bergmann
On Tuesday, July 19, 2016 11:46:04 AM CEST Jes Sorensen wrote: > > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c > > b/drivers/staging/rtl8192e/rtl819x_TSProc.c > > index 2c8a526773ed..e0a2fe5e6148 100644 > > --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c > > +++

Re: [PATCH 3/3] staging/rtl8192u: use s8 instead of char

2016-07-19 Thread Jes Sorensen
Arnd Bergmann writes: > Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of > incorrect code that results from 'char' being unsigned here, e.g. > > staging/rtl8192u/r8192U_core.c:4150:16: error: comparison is always false due > to limited range of data type

Re: [PATCH] packet: fix second argument of sock_tx_timestamp()

2016-07-19 Thread kbuild test robot
Hi, [auto build test ERROR on net-next/master] [also build test ERROR on v4.7-rc7 next-20160719] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Yoshihiro-Shimoda/packet-fix-second-argument

Re: [PATCH v3] packet: fix second argument of sock_tx_timestamp()

2016-07-19 Thread Willem de Bruijn
On Tue, Jul 19, 2016 at 8:34 AM, Soheil Hassas Yeganeh wrote: > On Tue, Jul 19, 2016 at 1:40 AM, Yoshihiro Shimoda > wrote: >> This patch fixes an issue that a syscall (e.g. sendto syscall) cannot >> work correctly. Since the sendto syscall

Re: [PATCH net-next v3 1/2] bpf: Add bpf_copy_to_user BPF helper to be called in tracers (kprobes)

2016-07-19 Thread Alexei Starovoitov
On Tue, Jul 19, 2016 at 01:17:53PM +0200, Daniel Borkmann wrote: > >+return -EINVAL; > >+ > >+/* Is this a user address, or a kernel address? */ > >+if (!access_ok(VERIFY_WRITE, to, size)) > >+return -EINVAL; > >+ > >+return probe_kernel_write(to, from, size); >

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-19 Thread Jes Sorensen
Arnd Bergmann writes: > Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of > incorrect code that results from 'char' being unsigned here, e.g. > > staging/rtl8192e/rtl8192e/r8192E_phy.c:1072:36: error: comparison is always > false due to limited range of

Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char

2016-07-19 Thread Jes Sorensen
Arnd Bergmann writes: > On Tuesday, July 19, 2016 11:46:04 AM CEST Jes Sorensen wrote: >> > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c >> > b/drivers/staging/rtl8192e/rtl819x_TSProc.c >> > index 2c8a526773ed..e0a2fe5e6148 100644 >> > ---

Re: [PATCH V2] Add flow control to the portmapper

2016-07-19 Thread Leon Romanovsky
On Tue, Jul 19, 2016 at 09:50:24AM -0500, Shiraz Saleem wrote: > On Tue, Jul 19, 2016 at 08:40:06AM +0300, Leon Romanovsky wrote: > > > > You are the one user of this new inline function. > > Why don't you directly call to netlink_unicast() in your ibnl_unicast() > > without messing with widely

Re: [PATCH net-next 1/1] net_sched: Introduce skbmod action

2016-07-19 Thread Cong Wang
On Tue, Jul 19, 2016 at 8:03 AM, Daniel Borkmann wrote: > On 07/19/2016 03:56 PM, Jamal Hadi Salim wrote: > [...] >>> >>> But apart from this, >>> neither pedit nor tcf_skbmod_run() here handle checksum complete, so >>> you'll >>> potentially get false positives wrt csum

Re: [PATCH v17 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-07-19 Thread kbuild test robot
Hi, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Dexuan-Cui/introduce-Hyper-V-VM-Sockets-hv_sock/20160715-223433 config: x86_64-randconfig-a0-07191719 (attached as .config) compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7 reproduce: # save the

Re: [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking

2016-07-19 Thread Joe Perches
On Mon, 2016-07-18 at 13:00 +0300, Amir Levy wrote: > This is version 4 of Thunderbolt(TM) driver for non-Apple hardware. [] >  Documentation/00-INDEX   |2 + >  Documentation/thunderbolt-networking.txt |  135 ++ >  drivers/thunderbolt/Kconfig  |   25 +- >  

Re: [PATCH v8 06/11] net/mlx4_en: add page recycle to prepare rx ring for tx support

2016-07-19 Thread Brenden Blanco
On Tue, Jul 19, 2016 at 04:33:28PM +0300, Tariq Toukan wrote: [...] > >So, I took Dave's suggestion to heart, and spent the last 2 days seeing > >what was possible to implement with just xdp as the focus, rather than > >an overall cleanup which Tariq will be looking at. > > > >Unfortunately, this

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-07-19 Thread Joe Perches
On Tue, 2016-07-19 at 20:26 +0300, Leon Romanovsky wrote: > On Tue, Jul 19, 2016 at 02:09:25PM +0300, Netanel Belgazal wrote: > > This is the debugging message interface. > > https://www.kernel.org/doc/Documentation/networking/netif-msg.txt > This document was updated last time in 2006 and I doubt

Re: [PATCH net-next v3 1/2] bpf: Add bpf_copy_to_user BPF helper to be called in tracers (kprobes)

2016-07-19 Thread Sargun Dhillon
On Tue, 19 Jul 2016, Daniel Borkmann wrote: Hi Sargun, On 07/19/2016 11:32 AM, Sargun Dhillon wrote: This allows user memory to be written to during the course of a kprobe. It shouldn't be used to implement any kind of security mechanism because of TOC-TOU attacks, but rather to debug,

Re: [PATCH net-next v3 10/12] net: dsa: support switchdev ageing time attr

2016-07-19 Thread Florian Fainelli
On 07/19/2016 07:20 AM, Andrew Lunn wrote: > On Mon, Jul 18, 2016 at 09:26:00PM -0700, Florian Fainelli wrote: >> Le 18/07/2016 à 20:24, Andrew Lunn a écrit : >>> On Mon, Jul 18, 2016 at 08:45:38PM -0400, Vivien Didelot wrote: Add a new function for DSA drivers to handle the switchdev

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-07-19 Thread Leon Romanovsky
On Tue, Jul 19, 2016 at 02:09:25PM +0300, Netanel Belgazal wrote: > > > On 07/15/2016 08:00 AM, Leon Romanovsky wrote: > > On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > >> This is a driver for the ENA family of networking devices. > >> > >> Signed-off-by: Netanel Belgazal

Re: [net-next v2 1/6] libcxgb: add library module for Chelsio drivers

2016-07-19 Thread David Miller
From: Varun Prakash Date: Sat, 16 Jul 2016 22:49:15 +0530 > } > + > +static int __init libcxgb_init(void) > +{ > + return 0; > +} > + > +static void __exit libcxgb_exit(void) > +{ > +} > + > +module_init(libcxgb_init); > +module_exit(libcxgb_exit); If these functions

[PATCH v10 11/12] bpf: enable direct packet data write for xdp progs

2016-07-19 Thread Brenden Blanco
For forwarding to be effective, XDP programs should be allowed to rewrite packet data. This requires that the drivers supporting XDP must all map the packet memory as TODEVICE or BIDIRECTIONAL before invoking the program. Signed-off-by: Brenden Blanco ---

[PATCH v10 03/12] net: add ndo to setup/query xdp prog in adapter rx

2016-07-19 Thread Brenden Blanco
Add one new netdev op for drivers implementing the BPF_PROG_TYPE_XDP filter. The single op is used for both setup/query of the xdp program, modelled after ndo_setup_tc. Signed-off-by: Brenden Blanco --- include/linux/netdevice.h | 34 ++

[PATCH v10 04/12] rtnl: add option for setting link xdp prog

2016-07-19 Thread Brenden Blanco
Sets the bpf program represented by fd as an early filter in the rx path of the netdev. The fd must have been created as BPF_PROG_TYPE_XDP. Providing a negative value as fd clears the program. Getting the fd back via rtnl is not possible, therefore reading of this value merely provides a bool

[PATCH v10 02/12] bpf: add XDP prog type for early driver filter

2016-07-19 Thread Brenden Blanco
Add a new bpf prog type that is intended to run in early stages of the packet rx path. Only minimal packet metadata will be available, hence a new context type, struct xdp_md, is exposed to userspace. So far only expose the packet start and end pointers, and only in read mode. An XDP program must

[PATCH v10 10/12] net/mlx4_en: add xdp forwarding and data write support

2016-07-19 Thread Brenden Blanco
A user will now be able to loop packets back out of the same port using a bpf program attached to xdp hook. Updates to the packet contents from the bpf program is also supported. For the packet write feature to work, the rx buffers are now mapped as bidirectional when the page is allocated. This

  1   2   >