Re: [PATCH net-next v2 0/3] virtio: style cleanups

2016-07-26 Thread Michael S. Tsirkin
On Tue, Jul 26, 2016 at 09:37:12AM -0700, Stephen Hemminger wrote: > Minor things found while doing some inspection code review. Acked-by: Michael S. Tsirkin I guess I'll just queue it up for this release. -- MST

Re: [PATCH v2] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue

2016-07-26 Thread Leon Romanovsky
On Tue, Jul 26, 2016 at 10:38:24PM +0530, Bhaktipriya Shridhar wrote: > The workqueue health->wq was used as per device private health thread. > This was done to perform delayed work. > > The workqueue has a single workitem(>work) and > hence doesn't require ordering. It is involved in handling

[PATCH v3 net-next 0/2] e1000e: fix PTP on e1000_pch_variants

2016-07-26 Thread Jarod Wilson
This little series factors out the systim sanitization code first, then adds e1000_pch_lpt as a new case in the switch that calls the sanitize function, fixing PTP clock issues I've had reported against an Intel I-218V NIC in an Intel NUC5ik5RYH system. Jarod Wilson (2): e1000e: factor out

[PATCH net-next v3 2/2] e1000e: fix PTP on e1000_pch_lpt variants

2016-07-26 Thread Jarod Wilson
I've got reports that the Intel I-218V NIC in Intel NUC5i5RYH systems used as a PTP slave experiences random ~10 hour clock jumps, which are resolved if the same workaround for the 82574 and 82583 is employed, so set the appropriate flag2 in e1000_pch_lpt_info too. Reported-by: Rupesh Patel

Re: [PATCH net-next 3/3] virtio: use kcalloc and kmalloc_array

2016-07-26 Thread David Miller
From: Stephen Hemminger Date: Tue, 26 Jul 2016 09:35:43 -0700 > On Tue, 26 Jul 2016 09:20:11 -0700 > Stephen Hemminger wrote: > >> Preferred style is to use kcalloc and kmalloc_array. >> >> Signed-off-by: Stephen Hemminger

[PATCH net] l2tp: Correctly return -EBADF from pppol2tp_getname.

2016-07-26 Thread Phil Turnbull
If 'tunnel' is NULL we should return -EBADF but the 'end_put_sess' path unconditionally sets 'error' back to zero. Rework the error path so it more closely matches pppol2tp_sendmsg. Fixes: fd558d186df2 ("l2tp: Split pppol2tp patch into separate l2tp and ppp parts") Signed-off-by: Phil Turnbull

Re: [PATCH net-next 0/3] qed*: Janitorial series [semantic & prints]

2016-07-26 Thread David Miller
From: Yuval Mintz Date: Tue, 26 Jul 2016 16:58:34 +0300 > Some day 1 slips in coding style exist in the qed* code > [incorrect alignments, conditions using (== 0), etc.]. > This series comes to address those, and do some additional > cosmetic changes along the way [such

Re: [iovisor-dev] XDP seeking input from NIC hardware vendors

2016-07-26 Thread Tom Herbert
On Tue, Jul 26, 2016 at 10:53 AM, John Fastabend wrote: > On 16-07-26 09:08 AM, Tom Herbert wrote: >> On Tue, Jul 26, 2016 at 6:31 AM, Thomas Monjalon >> wrote: >>> Hi, >>> >>> About RX filtering, there is an ongoing effort in DPDK to write an

question: tg3 driver/nics and inconsistent RX ring count

2016-07-26 Thread Michal Soltys
Hi, I have a few of BCM5720 and BCM5719 kinds sitting in Dell R320 and R520 servers - and all of them have certain peculiarity: they claim to have up to 4 TX and RX rings (and this can be set/verified just fine through ethtool -l/-L, with driver defaulting to 4 rings), indirection table (ethtool

Re: [iovisor-dev] XDP seeking input from NIC hardware vendors

2016-07-26 Thread Jesper Dangaard Brouer
On Tue, 26 Jul 2016 10:53:05 -0700 John Fastabend wrote: > On 16-07-26 09:08 AM, Tom Herbert wrote: > > On Tue, Jul 26, 2016 at 6:31 AM, Thomas Monjalon > > wrote: > >> Hi, > >> > >> About RX filtering, there is an ongoing effort in DPDK to

Re: [PATCH v2 09/10] netns: Add a limit on the number of net namespaces

2016-07-26 Thread Eric W. Biederman
Andrei Vagin writes: > On Thu, Jul 21, 2016 at 9:40 AM, Eric W. Biederman > wrote: >> index 2c2eb1b629b1..a489f192d619 100644 >> --- a/net/core/net_namespace.c >> +++ b/net/core/net_namespace.c >> @@ -266,6 +266,16 @@ struct net *get_net_ns_by_id(struct

Re: [iovisor-dev] XDP seeking input from NIC hardware vendors

2016-07-26 Thread John Fastabend
On 16-07-26 09:08 AM, Tom Herbert wrote: > On Tue, Jul 26, 2016 at 6:31 AM, Thomas Monjalon > wrote: >> Hi, >> >> About RX filtering, there is an ongoing effort in DPDK to write an API >> which could leverage most of the hardware capabilities of any NICs: >>

Re: question: tg3 driver/nics and inconsistent RX ring count

2016-07-26 Thread Alexander Duyck
On Tue, Jul 26, 2016 at 12:52 PM, Michal Soltys wrote: > Hi, > > I have a few of BCM5720 and BCM5719 kinds sitting in Dell R320 and R520 > servers - and all of them have certain peculiarity: they claim to have > up to 4 TX and RX rings (and this can be set/verified just fine

[PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2

2016-07-26 Thread Jarod Wilson
Per Jesse Brandeburg, e1000e should be using flags for this sort of thing. Littering functional code with device-specific checks is much messier than simply checking a flag, and having device-specific init set flags as needed. There are probably a number of other cases in the e1000e code that

Re: [PATCH v18 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-07-26 Thread David Miller
From: Dexuan Cui Date: Tue, 26 Jul 2016 07:09:41 + > I googled "S390 hypervisor socket" but didn't find anything related (I think). That would be net/iucv/ There's also VMWare's stuff under net/vmw_vsock It's just absolutely rediculous to make a new hypervisor socket

Re: [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2

2016-07-26 Thread Jeff Kirsher
On Tue, 2016-07-26 at 13:39 -0400, Jarod Wilson wrote: > Per Jesse Brandeburg, e1000e should be using flags for this sort of > thing. > > Littering functional code with device-specific checks is much messier > than > simply checking a flag, and having device-specific init set flags as > needed. >

Re: [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2

2016-07-26 Thread Jarod Wilson
On Tue, Jul 26, 2016 at 10:53:55AM -0700, Jeff Kirsher wrote: > On Tue, 2016-07-26 at 13:39 -0400, Jarod Wilson wrote: > > Per Jesse Brandeburg, e1000e should be using flags for this sort of > > thing. > > > > Littering functional code with device-specific checks is much messier > > than > >

[PATCH net-next v3 1/2] e1000e: factor out systim sanitization

2016-07-26 Thread Jarod Wilson
This is prepatory work for an expanding list of adapter families that have occasional ~10 hour clock jumps when being used for PTP. Factor out the sanitization function and convert to using a feature (bug) flag, per suggestion from Jesse Brandeburg. Littering functional code with device-specific

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

2016-07-26 Thread alexmcwhirter
On 2016-07-26 09:59, Christian Lamparter wrote: Thanks, I gave the program a try with my WNDA3100 and a WN821N v2 devices. I did not see any corruptions in any of the tests though. Can you tell me something about your wireless network too? I would like to know what router and firmware are you

[PATCH v2] net: neigh: disallow transition to NUD_STALE if lladdr is unchanged in neigh_update()

2016-07-26 Thread Chunhui He
NUD_STALE is used when the caller(e.g. arp_process()) can't guarantee neighbour reachability. If the entry was NUD_VALID and lladdr is unchanged, the entry state should not be changed. Currently the code puts an extra "NUD_CONNECTED" condition. So if old state was NUD_DELAY or NUD_PROBE (they are

Re: [PATCH v2 09/10] netns: Add a limit on the number of net namespaces

2016-07-26 Thread Andrei Vagin
On Thu, Jul 21, 2016 at 9:40 AM, Eric W. Biederman wrote: > Signed-off-by: "Eric W. Biederman" > --- > include/linux/user_namespace.h | 1 + > kernel/user_namespace.c| 1 + > net/core/net_namespace.c | 15 +++ > 3 files

Re: mlx5 SRIOV VLAN support

2016-07-26 Thread domingo montoya
Hello, I was trying to understand which flow tables/groups/rules enable the successful transfer of VLAN tagged packets from the VF. My current understanding is the PF driver creates and configures only two flow tables: 1. FDB flow table (for regular forwarding of traffic) 2. ACL Ingress and

[PATCH net] be2net: perform temperature query in adapter regardless of its interface state

2016-07-26 Thread Guilherme G. Piccoli
The be2net driver performs fw temperature queries on be_worker() routine, which is executed each second for each be_adapter. There is a frequency threshold to avoid fw query to happens at each call to be_worker(); instead, currently a fw query occurs once in 64 runs of the procedure.

Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-26 Thread Robert Foss
From: Grant Grundler For the record, I believe I am not the author of these patches. I believe the original author is Signed-off-by: Freddy Xin as recorded in the following code reviews (and testing) that I was responsible for:

Re: [PATCH 1/3] net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy()

2016-07-26 Thread ivan.khoronzhuk
On 26.07.16 19:02, Grygorii Strashko wrote: On 07/23/2016 09:24 AM, Ivan Khoronzhuk wrote: On 22.07.16 16:58, Grygorii Strashko wrote: Fix deadlock in cpdma_ctlr_destroy() which is triggered now on cpsw module removal: cpsw_remove() - cpdma_ctlr_destroy() - spin_lock_irqsave(>lock,

Re: [PATCH] macsec: ensure rx_sa is set when validation is disabled

2016-07-26 Thread David Miller
From: Beniamino Galvani Date: Tue, 26 Jul 2016 12:24:53 +0200 > macsec_decrypt() is not called when validation is disabled and so > macsec_skb_cb(skb)->rx_sa is not set; but it is used later in > macsec_post_decrypt(), ensure that it's always initialized. > > Signed-off-by:

Re: [PATCH v2] net: neigh: disallow transition to NUD_STALE if lladdr is unchanged in neigh_update()

2016-07-26 Thread David Miller
From: Chunhui He Date: Tue, 26 Jul 2016 06:16:52 + > NUD_STALE is used when the caller(e.g. arp_process()) can't guarantee > neighbour reachability. If the entry was NUD_VALID and lladdr is unchanged, > the entry state should not be changed. > > Currently the code

[PATCH] qed: Add and use specific logging functions to reduce object size

2016-07-26 Thread Joe Perches
Current DP_ macros generate a lot of code. Using functions with vsprintf extension %pV helps reduce that size. $ size drivers/net/ethernet/qlogic/built-in.o* (x86-64) textdata bss dec hex filename 165161 28470 32812 226443 3748b

Re: [PATCH net-next v2 0/5] tipc: netlink updates for neighbour monitor

2016-07-26 Thread David Miller
From: Parthasarathy Bhuvaragan Date: Tue, 26 Jul 2016 08:47:17 +0200 > This series contains the updates to configure and read the attributes for > neighbour monitor. > > v2: rebase on top of net-next Series applied, thanks.

Re: [PATCH 1/3] net: asix: Add in_pm parameter

2016-07-26 Thread Grant Grundler
On Tue, Jul 26, 2016 at 2:14 PM, Robert Foss wrote: ... > Thanks for the feedback (for this patch and the other ones)! > I'm preparing a v2 and will submit it withing a day or two. Excellent! very welcome and thanks again for picking this up. ... >> FTR, current

Re: [PATCH net-next v2] net: ipmr/ip6mr: update lastuse on entry change

2016-07-26 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 26 Jul 2016 18:54:52 +0200 > Currently lastuse is updated on entry creation and cache hit, but it should > also be updated on entry change. Since both on add and update the ttl array > is updated we can simply update the lastuse

Re: [PATCH v2] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue

2016-07-26 Thread David Miller
From: Bhaktipriya Shridhar Date: Tue, 26 Jul 2016 22:38:24 +0530 > The workqueue health->wq was used as per device private health thread. > This was done to perform delayed work. > > The workqueue has a single workitem(>work) and > hence doesn't require ordering. It is

Re: [PATCH net] l2tp: Correctly return -EBADF from pppol2tp_getname.

2016-07-26 Thread David Miller
From: Phil Turnbull Date: Tue, 26 Jul 2016 15:14:35 -0400 > If 'tunnel' is NULL we should return -EBADF but the 'end_put_sess' path > unconditionally sets 'error' back to zero. Rework the error path so it > more closely matches pppol2tp_sendmsg. > > Fixes: fd558d186df2

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

2016-07-26 Thread Alan Curry
Christian Lamparter wrote: > Thanks, I gave the program a try with my WNDA3100 and a WN821N v2 devices. > I did not see any corruptions in any of the tests though. Can you tell me > something about your wireless network too? I would like to know what router > and firmware are you using? Also

Re: [PATCH] qed: Add and use specific logging functions to reduce object size

2016-07-26 Thread Joe Perches
On Tue, 2016-07-26 at 14:25 -0700, Joe Perches wrote: > Current DP_ macros generate a lot of code. > Using functions with vsprintf extension %pV helps reduce that size. Yuval, I used the same KERN_ output types, but it is unusual that DP_INFO outputs at KERN_NOTICE. Was that a copy/paste defect

Re: [PATCH v2] net: davinci_cpdma: remove excessive dump of register values to kernel log

2016-07-26 Thread Ivan Khoronzhuk
On 26.07.16 17:26, Grygorii Strashko wrote: + CC: Ivan On 07/26/2016 05:09 PM, Grygorii Strashko wrote: On 07/26/2016 03:57 AM, David Miller wrote: From: Uwe Kleine-König Date: Mon, 25 Jul 2016 11:54:45 +0200 Such a big dump of register values is hardly

linux-next: manual merge of the net-next tree with the arm-soc tree

2016-07-26 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: arch/arm64/boot/dts/apm/apm-shadowcat.dtsi between commit: cafc4cd0c8b8 ("arm64: dts: apm: Use lowercase consistently for hex constants") from the arm-soc tree and commit: 8e694cd2762c ("dtb: xgene: Add MDIO

[PATCH 13/15] ethernet: stmicro: stmmac: dwmac-socfpga: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c| 36 -- 1 file changed, 26 insertions(+), 10 deletions(-) diff

[PATCH 09/15] ethernet: marvell: mvpp2: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/marvell/mvpp2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvpp2.c

[PATCH 14/15] ethernet: stmicro: stmmac: stmmac_platform: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH 15/15] ethernet: ti: davinci_emac: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/ti/davinci_emac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/ti/davinci_emac.c

[PATCH 12/15] ethernet: renesas: sh_eth: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/renesas/sh_eth.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/renesas/sh_eth.c

Re: [PATCH] xfrm: use printk instead of WARN for bad policy reporting

2016-07-26 Thread Herbert Xu
On Wed, Jul 20, 2016 at 01:53:12PM +0200, Vegard Nossum wrote: > On 07/20/2016 10:32 AM, Vegard Nossum wrote: > >AFAICT this message is just printed whenever input validation fails. > >This is a normal failure and we shouldn't be dumping the stack over it. > > > >Looks like it was originally a

[PATCH 08/15] ethernet: marvell: mvneta: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/marvell/mvneta.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/marvell/mvneta.c

[PATCH 11/15] ethernet: renesas: ravb_main: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/renesas/ravb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/renesas/ravb_main.c

[PATCH 06/15] ethernet: hisilicon: hns: hns_dsaf_mac: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH 10/15] ethernet: marvell: pxa168_eth: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/marvell/pxa168_eth.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c

[PATCH 04/15] ethernet: aurora: nb8800: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/aurora/nb8800.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/aurora/nb8800.c

[PATCH 05/15] ethernet: cavium: octeon: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 07/15] ethernet: hisilicon: hns: hns_dsaf_main: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 15/15] ethernet: ti: davinci_emac: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Mugunthan V N
On Wednesday 27 July 2016 07:50 AM, Peter Chen wrote: > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Signed-off-by: Peter Chen > --- > drivers/net/ethernet/ti/davinci_emac.c | 1 + > 1 file changed, 1

RE: [PATCH net] be2net: perform temperature query in adapter regardless of its interface state

2016-07-26 Thread Sathya Perla
> -Original Message- > From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com] > > The be2net driver performs fw temperature queries on be_worker() routine, which is executed each second for > each be_adapter. There is a frequency threshold to avoid fw query to happens at each call

[PATCH 03/15] ethernet: arc: emac_main: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/arc/emac_main.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git

[PATCH 01/15] ethernet: altera: add missing of_node_put

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle (or of_node_get) has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/altera/altera_tse_main.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 02/15] ethernet: apm: xgene: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 00/15] ethernet: add missing of_node_put after calling of_parse_phandle

2016-07-26 Thread Peter Chen
Hi David, This patch set fixes missing of_node_put issue at ethernet driver. of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Thanks. Peter Chen (15): ethernet: altera: add missing of_node_put ethernet: apm: xgene: add missing

RE: [v3] UCC_GETH/UCC_FAST: Use IS_ERR_VALUE_U32 API to avoid IS_ERR_VALUE abuses.

2016-07-26 Thread David Laight
From: Arvind Yadav > Sent: 23 July 2016 19:06 > IS_ERR_VALUE() assumes that its parameter is an unsigned long. > It can not be used to check if an 'unsigned int' reflects an error. > As they pass an 'unsigned int' into a function that takes an > 'unsigned long' argument. This happens to work

Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

2016-07-26 Thread Eric Dumazet
On Tue, 2016-07-26 at 11:50 +0800, Fengguang Wu wrote: > Greetings, > > This BUG message can be found in recent kernels as well as v4.4 and > linux-stable. It happens when running > > modprobe netconsole netconsole=@/,$port@$server/ > > [ 39.937534] 22 Jul 13:30:40 ntpdate[440]: step

[PATCH net-next v2 2/5] tipc: make cluster size threshold for monitoring configurable

2016-07-26 Thread Parthasarathy Bhuvaragan
In this commit, we introduce support to configure the minimum threshold to activate the new link monitoring algorithm. Reviewed-by: Jon Maloy Signed-off-by: Parthasarathy Bhuvaragan --- include/uapi/linux/tipc_netlink.h | 11

[PATCH net-next v2 4/5] tipc: add a function to get the bearer name

2016-07-26 Thread Parthasarathy Bhuvaragan
Introduce a new function to get the bearer name from its id. This is used in subsequent commit. Reviewed-by: Jon Maloy Signed-off-by: Parthasarathy Bhuvaragan --- net/tipc/bearer.c | 21 + net/tipc/bearer.h | 1

[PATCH net-next v2 1/5] tipc: introduce constants for tipc address validation

2016-07-26 Thread Parthasarathy Bhuvaragan
In this commit, we introduce defines for tipc address size, offset and mask specification for Zone.Cluster.Node. There is no functional change in this commit. Reviewed-by: Jon Maloy Signed-off-by: Parthasarathy Bhuvaragan ---

[PATCH net-next v2 3/5] tipc: get monitor threshold for the cluster

2016-07-26 Thread Parthasarathy Bhuvaragan
In this commit, we add support to fetch the configured cluster monitoring threshold. Reviewed-by: Jon Maloy Signed-off-by: Parthasarathy Bhuvaragan --- include/uapi/linux/tipc_netlink.h | 1 + net/tipc/monitor.c|

[PATCH net-next v2 5/5] tipc: dump monitor attributes

2016-07-26 Thread Parthasarathy Bhuvaragan
In this commit, we dump the monitor attributes when queried. The link monitor attributes are separated into two kinds: 1. general attributes per bearer 2. specific attributes per node/peer This style resembles the socket attributes and the nametable publications per socket. Reviewed-by: Jon Maloy

[PATCH net-next v2 0/5] tipc: netlink updates for neighbour monitor

2016-07-26 Thread Parthasarathy Bhuvaragan
This series contains the updates to configure and read the attributes for neighbour monitor. v2: rebase on top of net-next Parthasarathy Bhuvaragan (5): tipc: introduce constants for tipc address validation tipc: make cluster size threshold for monitoring configurable tipc: get monitor

RE: [PATCH v18 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-07-26 Thread Dexuan Cui
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > Behalf Of Dexuan Cui > ... > > From: David Miller [mailto:da...@davemloft.net] > > ... > > From: Dexuan Cui > > Date: Tue, 26 Jul 2016 03:09:16 + > > > > > BTW, during the past month, at least 7

Re: [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking

2016-07-26 Thread Andreas Noever
On Wed, Jul 20, 2016 at 12:02 AM, Bjorn Helgaas wrote: > On Mon, Jul 18, 2016 at 01:00:33PM +0300, Amir Levy wrote: >> This is version 4 of Thunderbolt(TM) driver for non-Apple hardware. >> >> Changes since v3: >> - Moved new Thunderbolt device IDs from pci_ids.h to

Re: [PATCH v2] net: neigh: disallow transition to NUD_STALE if lladdr is unchanged in neigh_update()

2016-07-26 Thread Hannes Frederic Sowa
On 26.07.2016 08:16, Chunhui He wrote: > NUD_STALE is used when the caller(e.g. arp_process()) can't guarantee > neighbour reachability. If the entry was NUD_VALID and lladdr is unchanged, > the entry state should not be changed. > > Currently the code puts an extra "NUD_CONNECTED" condition. So

Re: [PATCH v4 2/7] thunderbolt: Updating the register definitions

2016-07-26 Thread Andreas Noever
On Mon, Jul 18, 2016 at 12:00 PM, Amir Levy wrote: > Adding more Thunderbolt(TM) register definitions > and some helper macros. > > Signed-off-by: Amir Levy > --- > drivers/thunderbolt/nhi_regs.h | 109 >

Re: [PATCH v2] net: neigh: disallow transition to NUD_STALE if lladdr is unchanged in neigh_update()

2016-07-26 Thread Julian Anastasov
Hello, On Tue, 26 Jul 2016, Chunhui He wrote: > NUD_STALE is used when the caller(e.g. arp_process()) can't guarantee > neighbour reachability. If the entry was NUD_VALID and lladdr is unchanged, > the entry state should not be changed. > > Currently the code puts an extra

RE: [net-next PATCH 4/4] be2net: replace polling with sleeping in the FW completion path

2016-07-26 Thread Sathya Perla
> -Original Message- > From: Sathya Perla [mailto:sathya.pe...@broadcom.com] > > > -Original Message- > > From: David Miller [mailto:da...@davemloft.net] > > > > > @@ -4477,6 +4551,22 @@ static int be_if_create(struct be_adapter > *adapter) > > > u32 cap_flags =

[iproute PATCH 0/3] improve MACsec support

2016-07-26 Thread Davide Caratti
parsing of 'cipher' and 'icvlen' arguments has been improved; while at it, a couple of missing printouts have been added to usage() functions in "ip addr help" and "ip link help". Finally, some errors in the man pages have been fixed. Signed-off-by: Davide Caratti Davide

[iproute PATCH 1/3] man: macsec: fix macsec related typos

2016-07-26 Thread Davide Caratti
- ip-macsec.8: fix wrong 'device' keyword in 'ip link add device eth0'; add missing description of 'validate' keyword; remove spurious bracket near 'encrypt' keyword; add missing reference to configuration of 'port' and 'sci' - ip-link.8 fix wrong 'es' and 'encoding' keywords in MACsec section

[PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-07-26 Thread Andreas Werner
This CAN Controller is found on MEN Chameleon FPGAs. The driver/device supports the CAN2.0 specification. There are 255 RX and 255 Tx buffer within the IP. The pointer for the buffer are handled by HW to make the access from within the driver as simple as possible. The driver also supports

[iproute PATCH 3/3] macsec: cipher and icvlen can be set separately

2016-07-26 Thread Davide Caratti
since kernel driver has valid default values for 'cipher' and 'icvlen', there is no need for requiring users to specify both of them when a new link is added. Also, prompt an error message and exit with appropriate exit status in case of unsupported cipher suite. Signed-off-by: Davide Caratti

[iproute PATCH 2/3] ip {link,address}: add 'macsec' item to TYPE list

2016-07-26 Thread Davide Caratti
fix output of "ip address help" and "ip link help". Update TYPE list in man pages ip-address.8 and ip-link.8 as well. Signed-off-by: Davide Caratti --- ip/ipaddress.c | 2 +- ip/iplink.c | 2 +- man/man8/ip-address.8.in | 3 ++- man/man8/ip-link.8.in

RE: [PATCH v4 2/7] thunderbolt: Updating the register definitions

2016-07-26 Thread Levy, Amir (Jer)
On Tue, Jul 26 2016, 10:39 AM, Andreas Noever wrote: > On Mon, Jul 18, 2016 at 12:00 PM, Amir Levy > wrote: > > Adding more Thunderbolt(TM) register definitions and some helper > > macros. > > > > Signed-off-by: Amir Levy > > --- > >

Re: [PATCH net-next V2 0/2] Mellanox 100G mlx5 minimum inline header mode

2016-07-26 Thread David Miller
From: Hadar Hen Zion Date: Tue, 26 Jul 2016 13:30:46 +0300 > In the default case eth_get_headlen() won't be called, it will happen > only if PF administrator changes the mode from default to L4. > > In L4 mode, we need to copy all the packet headers including L4, do >

Re: [PATCH net-next 1/2] be2net: set temperature value for all adapter's functions

2016-07-26 Thread Guilherme G. Piccoli
On 07/26/2016 05:26 AM, Sathya Perla wrote: -Original Message- From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com] On 07/25/2016 07:48 AM, Sathya Perla wrote: -Original Message- From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com] Temperature values on

Re: question: tg3 driver/nics and inconsistent RX ring count

2016-07-26 Thread Michal Soltys
On 2016-07-26 22:06, Alexander Duyck wrote: > On Tue, Jul 26, 2016 at 12:52 PM, Michal Soltys wrote: >> Hi, >> >> I have a few of BCM5720 and BCM5719 kinds sitting in Dell R320 and R520 >> servers - and all of them have certain peculiarity: they claim to have >> up to 4 TX and RX

Re: question: tg3 driver/nics and inconsistent RX ring count

2016-07-26 Thread Michael Chan
On Tue, Jul 26, 2016 at 1:32 PM, Michal Soltys wrote: > On 2016-07-26 22:06, Alexander Duyck wrote: >> On Tue, Jul 26, 2016 at 12:52 PM, Michal Soltys wrote: >>> Hi, >>> >>> I have a few of BCM5720 and BCM5719 kinds sitting in Dell R320 and R520 >>> servers -

Re: [PATCH v2 00/10] userns: sysctl limits for namespaces

2016-07-26 Thread Kees Cook
On Tue, Jul 26, 2016 at 10:29 AM, Michael Kerrisk (man-pages) wrote: > On 26 July 2016 at 18:52, Kees Cook wrote: >> On Tue, Jul 26, 2016 at 8:06 AM, Eric W. Biederman >> wrote: >>> "Michael Kerrisk (man-pages)"

Re: [PATCH] schedule function called for e1000 driver interrupt

2016-07-26 Thread kbuild test robot
Hi, [auto build test ERROR on jkirsher-next-queue/dev-queue] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Fengguang-Wu/schedule-function-called-for-e1000-driver-interrupt/20160726-173521 base

[PATCH] macsec: ensure rx_sa is set when validation is disabled

2016-07-26 Thread Beniamino Galvani
macsec_decrypt() is not called when validation is disabled and so macsec_skb_cb(skb)->rx_sa is not set; but it is used later in macsec_post_decrypt(), ensure that it's always initialized. Signed-off-by: Beniamino Galvani --- drivers/net/macsec.c | 3 ++- 1 file changed, 2

Re: Microsemi VSC 8531/41 PHY Driver

2016-07-26 Thread Andrew Lunn
On Tue, Jul 26, 2016 at 09:49:53AM +, Raju Lakkaraju wrote: > Hello All, > > I would like to introduce myself as Nagaraju Lakkaraju (Raju), is working in > Microsemi Communications India Pvt. Ltd (Formerly known as Vitesse > Semiconductors Limited) - Hyderabad as Sr. Staff Engineer. > I do

Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

2016-07-26 Thread Thomas Gleixner
On Tue, 26 Jul 2016, Fengguang Wu wrote: > --- a/drivers/net/ethernet/intel/e1000/e1000_main.c > +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c > @@ -3797,7 +3797,7 @@ static irqreturn_t e1000_intr(int irq, void *data) > hw->get_link_status = 1; > /* guard against

Re: [PATCH v2 00/10] userns: sysctl limits for namespaces

2016-07-26 Thread Michael Kerrisk (man-pages)
Hello Eric, On 07/21/2016 06:39 PM, Eric W. Biederman wrote: This patchset addresses two use cases: - Implement a sane upper bound on the number of namespaces. - Provide a way for sandboxes to limit the attack surface from namespaces. The maximum sane case I can imagine is if every process

Re: [PATCH net-next V2 0/2] Mellanox 100G mlx5 minimum inline header mode

2016-07-26 Thread Hadar Hen Zion
In the default case eth_get_headlen() won't be called, it will happen only if PF administrator changes the mode from default to L4. In L4 mode, we need to copy all the packet headers including L4, do you know of a better/cheaper way for doing that? Thanks, Hadar On Tue, Jul 26, 2016 at 3:54 AM,

Re: [v3] UCC_GETH/UCC_FAST: Use IS_ERR_VALUE_U32 API to avoid IS_ERR_VALUE abuses.

2016-07-26 Thread Arnd Bergmann
On Saturday, July 23, 2016 11:35:51 PM CEST Arvind Yadav wrote: > diff --git a/include/linux/err.h b/include/linux/err.h > index 1e35588..a42f942 100644 > --- a/include/linux/err.h > +++ b/include/linux/err.h > @@ -19,6 +19,7 @@ > #ifndef __ASSEMBLY__ > > #define IS_ERR_VALUE(x)

Re: [PATCH] schedule function called for e1000 driver interrupt

2016-07-26 Thread kbuild test robot
Hi, [auto build test ERROR on jkirsher-next-queue/dev-queue] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Fengguang-Wu/schedule-function-called-for-e1000-driver-interrupt/20160726-173521 base

Re: [PATCH v18 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-07-26 Thread Michal Kubecek
On Tue, Jul 26, 2016 at 07:09:41AM +, Dexuan Cui wrote: > If you meant https://lkml.org/lkml/2016/7/13/382, I don't think Michal > Kubecek was suggesting I build my code using the existing AF_VSOCK > code(?) I think he was only asking me to clarify the way I used to write > the text to

Re: [PATCH net-next V2 0/2] Mellanox 100G mlx5 minimum inline header mode

2016-07-26 Thread Hadar Hen Zion
On Tue, Jul 26, 2016 at 3:54 AM, David Miller wrote: > From: Saeed Mahameed > Date: Sun, 24 Jul 2016 16:12:38 +0300 > >> This small series from Hadar adds the support for minimum inline >> header mode query in mlx5e NIC driver. >> >> Today on TX the

Re: [PATCH v2 00/10] userns: sysctl limits for namespaces

2016-07-26 Thread Michael Kerrisk (man-pages)
Hello Eric, I realized I had a question after the last mail. On 07/21/2016 06:39 PM, Eric W. Biederman wrote: This patchset addresses two use cases: - Implement a sane upper bound on the number of namespaces. - Provide a way for sandboxes to limit the attack surface from namespaces. Can

Re: [PATCH] macsec: ensure rx_sa is set when validation is disabled

2016-07-26 Thread Sabrina Dubroca
2016-07-26, 12:24:53 +0200, Beniamino Galvani wrote: > macsec_decrypt() is not called when validation is disabled and so > macsec_skb_cb(skb)->rx_sa is not set; but it is used later in > macsec_post_decrypt(), ensure that it's always initialized. > > Signed-off-by: Beniamino Galvani

Microsemi VSC 8531/41 PHY Driver

2016-07-26 Thread Raju Lakkaraju
Hello All, I would like to introduce myself as Nagaraju Lakkaraju (Raju), is working in Microsemi Communications India Pvt. Ltd (Formerly known as Vitesse Semiconductors Limited) - Hyderabad as Sr. Staff Engineer. I do work on Microsemi PHY drivers development. Microsemi is developing the new

RE: [net-next PATCH 4/4] be2net: replace polling with sleeping in the FW completion path

2016-07-26 Thread Sathya Perla
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > > > @@ -4477,6 +4551,22 @@ static int be_if_create(struct be_adapter *adapter) > > u32 cap_flags = be_if_cap_flags(adapter); > > int status; > > > > + /* alloc required memory for other filtering fields */ >

RE: [PATCH net-next 1/2] be2net: set temperature value for all adapter's functions

2016-07-26 Thread Sathya Perla
> -Original Message- > From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com] > > On 07/25/2016 07:48 AM, Sathya Perla wrote: > >> -Original Message- > >> From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com] > >> > >> Temperature values on be2net driver are made

Re: [iovisor-dev] XDP seeking input from NIC hardware vendors

2016-07-26 Thread Thomas Monjalon
Hi, About RX filtering, there is an ongoing effort in DPDK to write an API which could leverage most of the hardware capabilities of any NICs: https://rawgit.com/6WIND/rte_flow/master/rte_flow.html http://thread.gmane.org/gmane.comp.networking.dpdk.devel/43352 I understand that

Re: [iproute PATCH 0/3] improve MACsec support

2016-07-26 Thread Sabrina Dubroca
2016-07-26, 11:03:17 +0200, Davide Caratti wrote: > parsing of 'cipher' and 'icvlen' arguments has been improved; while at it, > a couple of missing printouts have been added to usage() functions in > "ip addr help" and "ip link help". Finally, some errors in the man pages > have been fixed. > >

[PATCH net-next 1/3] qed*: Semantic changes

2016-07-26 Thread Yuval Mintz
Make semantic-only adjustments to qed* drivers, such as: - Changes in code indentation. - Usage of BIT() macro. - re-naming of variables. - Re-ordering of variable declerations. - Removal of (== 0) and (!= 0) in conditions. Signed-off-by: Yuval Mintz ---

[PATCH net-next 3/3] qed*: Add and modify some prints

2016-07-26 Thread Yuval Mintz
This patch touches various prints in the driver - it reduces the verbosity of some prints [which were previously logged by default] while adding several new debug prints and modifying others. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dev.c|

  1   2   >