[PATCH net] ibmveth: Disable tx queue while changing mtu

2016-08-09 Thread Thomas Falcon
If the device is running while the MTU is changed, ibmveth is closed and the bounce buffer is freed. If a transmission is sent before ibmveth can be reopened, ibmveth_start_xmit tries to copy to the null bounce buffer, leading to a kernel oops. The proposed solution disables the tx queue until

RE: [RFC PATCH 2/3] net: macb: Add support for 1588 for Zynq Ultrascale+ MPSoC

2016-08-09 Thread Punnaiah Choudary Kalluri
Hi Nicolas, 1588 implementation in cadence GEM IP we have in Zynq Ultascale+ MPSoC is Different to the one in Zynq SOC. In earlier version, all timestamp values will be stored in registers and there is no specific Mechanism to distinguish the received ethernet frame that contains time stamp

Re: [PATCH] net: dsa: b53: constify xfrm_replay structures

2016-08-09 Thread Florian Fainelli
On 08/09/2016 10:23 AM, Florian Fainelli wrote: > On 08/09/2016 09:58 AM, Julia Lawall wrote: >> The xfrm_replay structures are never modified, so declare them as const. > > You mean b53_io_ops here, right? Other than that LTGM, but this will > have to wait for "net"next to re_open since this is

Re: size of data_segs_[in|out] and segs_[in|out]

2016-08-09 Thread rapier
On 8/8/16 7:02 PM, David Miller wrote: From: rapier Date: Mon, 8 Aug 2016 18:02:29 -0400 As such, would it be feasible to define these instruments as 64bit instead of 32bit? If so, a cursory look at the code seems to indicate that this would only require a change in the

Re: [PATCHv2 3/4] pci: Determine actual VPD size on first access

2016-08-09 Thread Alexander Duyck
On Tue, Aug 9, 2016 at 5:54 AM, Alexey Kardashevskiy wrote: > On 10/02/16 08:04, Bjorn Helgaas wrote: >> On Wed, Jan 13, 2016 at 12:25:34PM +0100, Hannes Reinecke wrote: >>> PCI-2.2 VPD entries have a maximum size of 32k, but might actually >>> be smaller than that. To figure out

Re: [PATCH] bonding: Allow tun-interfaces as slaves

2016-08-09 Thread Jay Vosburgh
Jörn Engel wrote: >Hello Tianhong! > >On Tue, Aug 09, 2016 at 10:18:41AM +0800, Ding Tianhong wrote: >> >> I don't understand your problem clearly, can you explain more about how the >> 00503b6f702e break tun-interfaces >> and we will try to fix it. > >Here is a trivial

Re: [PATCH v2] net: dsa: b53: constify b53_io_ops structures

2016-08-09 Thread Florian Fainelli
On 08/09/2016 10:09 AM, Julia Lawall wrote: > The b53_io_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Acked-by: Florian Fainelli -- Florian

Re: [PATCH] bonding: Allow tun-interfaces as slaves

2016-08-09 Thread Jörn Engel
On Tue, Aug 09, 2016 at 09:28:45PM +0800, Ding Tianhong wrote: > > This patch is a simple solution for this problem, but I don't think it is the > right solution, the bond is a virtual device base on L2, > if the slave has no mac address, it will break the design principle, so we > need to

Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

2016-08-09 Thread Timur Tabi
Lino Sanfilippo wrote: +/* Fill up transmit descriptors */ +static void emac_tx_fill_tpd(struct emac_adapter *adpt, +struct emac_tx_queue *tx_q, struct sk_buff *skb, +struct emac_tpd *tpd) +{ + u16 nr_frags =

[PATCH v2] net: dsa: b53: constify b53_io_ops structures

2016-08-09 Thread Julia Lawall
The b53_io_ops structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- v2: Refer to the right structure in the commit message drivers/net/dsa/b53/b53_common.c |3 ++- drivers/net/dsa/b53/b53_mdio.c

Re: [PATCH] net: dsa: b53: constify xfrm_replay structures

2016-08-09 Thread Julia Lawall
On Tue, 9 Aug 2016, Florian Fainelli wrote: > On 08/09/2016 09:58 AM, Julia Lawall wrote: > > The xfrm_replay structures are never modified, so declare them as const. > > You mean b53_io_ops here, right? Oops. I sent a v2. julia > Other than that LTGM, but this will > have to wait for

Re: [PATCH] dm9000: Fix irq trigger type setup on non-dt platforms

2016-08-09 Thread Robert Jarzmik
Sylwester Nawrocki writes: > Commit b5a099c67a1c36b "net: ethernet: davicom: fix devicetree irq > resource" causes an interrupt storm after the ethernet interface > is activated on S3C24XX platform (ARM non-dt), due to the interrupt > trigger type not being set properly.

Re: [Patch net 5/5] net_sched: convert tcf_exts from list to flex_array

2016-08-09 Thread Cong Wang
On Tue, Aug 9, 2016 at 1:03 AM, Amir Vadai wrote: > >> -#define tc_single_action(_exts) \ >> - (list_is_singular(&(_exts)->actions)) >> +#define tc_no_actions(_exts) (&(_exts)->nr_actions == 0) >> +#define tc_single_action(_exts) (&(_exts)->nr_actions == 1) > > Should

4.7.0: RCU stall in nf_conntrack

2016-08-09 Thread Johannes Stezenbach
Hi, I just experienced network hangup with 4.7.0, it happened shortly after resume from hibernate: [201988.443552] INFO: rcu_preempt detected stalls on CPUs/tasks: [201988.443556] Tasks blocked on level-0 rcu_node (CPUs 0-3): P14563 [201988.443557] (detected by 3, t=18002

[PATCH] xfrm: constify xfrm_replay structures

2016-08-09 Thread Julia Lawall
The xfrm_replay structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- include/net/xfrm.h |2 +- net/xfrm/xfrm_replay.c |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] net: dsa: b53: constify xfrm_replay structures

2016-08-09 Thread Florian Fainelli
On 08/09/2016 09:58 AM, Julia Lawall wrote: > The xfrm_replay structures are never modified, so declare them as const. You mean b53_io_ops here, right? Other than that LTGM, but this will have to wait for "net"next to re_open since this is more of a cleanup than bugfix. Thanks! -- Florian

[PATCH v3 10/13] net; ethernet: ti: cpsw: move irq stuff under cpsw_common

2016-08-09 Thread Ivan Khoronzhuk
The irq data are common for net devs in dual_emac mode. So no need to hold these data in every priv struct, move them under cpsw_common. Also delete irq_num var, as after optimization it's not needed. Correct number of irqs to 2, as anyway, driver is using only 2, at least for now. Signed-off-by:

[PATCH v3 07/13] net: ethernet: ti: cpsw: replace pdev on dev

2016-08-09 Thread Ivan Khoronzhuk
No need to hold pdev link when only dev is needed. This allows to simplify a bunch of cpsw->pdev->dev now and farther. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 65 ++ 1 file changed, 34 insertions(+),

[PATCH v3 12/13] net: ethernet: ti: cpsw: move napi struct to cpsw_common

2016-08-09 Thread Ivan Khoronzhuk
The napi structs are common for both net devices in dual_emac mode, In order to not hold duplicate links to them, move to cpsw_common. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 52 ++ 1 file changed,

[PATCH v3 13/13] net: ethernet: ti: cpsw: move ale, cpts and drivers params under cpsw_common

2016-08-09 Thread Ivan Khoronzhuk
The ale, cpts, version, rx_packet_max, bus_freq, interrupt pacing parameters are common per net device that uses the same h/w. So, move them to common driver structure. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 235

[net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

2016-08-09 Thread Sargun Dhillon
This adds a bpf helper that's similar to the skb_in_cgroup helper to check whether the probe is currently executing in the context of a specific subset of the cgroupsv2 hierarchy. It does this based on membership test for a cgroup arraymap. It is invalid to call this in an interrupt, and it'll

[net-next v2 v2 0/2] Add bpf current_task_in_cgroup helper & opensnoop example

2016-08-09 Thread Sargun Dhillon
This patchset includes a helper and an example to determine whether the probe is currently executing in the context of a specific cgroup based on a cgroup bpf map / array. The helper checks the cgroupsv2 hierarchy based on the handle in the map and if the current cgroup is equal to it, or a

Re: [net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

2016-08-09 Thread Alexei Starovoitov
On Tue, Aug 09, 2016 at 05:00:12PM -0700, Sargun Dhillon wrote: > This adds a bpf helper that's similar to the skb_in_cgroup helper to check > whether the probe is currently executing in the context of a specific > subset of the cgroupsv2 hierarchy. It does this based on membership test > for a

Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

2016-08-09 Thread Timur Tabi
Florian Fainelli wrote: nr_frags can't be bigger than MAX_SKB_FRAGS, hence these checks all other drivers do against 1 + MAX_SKB_FRAGS. Doh, I just realized something. emac_mac_tx_buf_send() just needs to make sure that there's enough room for ONE skb. For some reason I thought it had to

Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

2016-08-09 Thread Florian Fainelli
On 08/09/2016 06:09 PM, Timur Tabi wrote: > Florian Fainelli wrote: > >> nr_frags can't be bigger than MAX_SKB_FRAGS, hence these checks all >> other drivers do against 1 + MAX_SKB_FRAGS. > > Doh, I just realized something. emac_mac_tx_buf_send() just needs to > make sure that there's enough

Re: [PATCH 2/2] ravb: add sleep PM suspend/resume support

2016-08-09 Thread David Miller
From: Niklas Söderlund Date: Wed, 3 Aug 2016 15:56:47 +0200 > The interface would not function after the system had been woken up > after have been suspended (echo mem > /sys/power/state) cycle. The > reason for this is that all device registers have been

[PATCH v3 09/13] net: ethernet: ti: cpsw: move cpdma resources to cpsw_common

2016-08-09 Thread Ivan Khoronzhuk
Every net device private struct holds links to shared cpdma resources. No need to save and every time synchronize these resources per net dev. So, move it to common driver struct. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 97

[PATCH v3 02/13] net: ethernet: ti: cpsw: remove intr dbg msg from poll handlers

2016-08-09 Thread Ivan Khoronzhuk
At poll handler no possibility to figure out which network device is handling packets, as cpdma channels are common for both network devices in dual_emac mode. Currently, the messages are printed only for one device, in fact, there is two. This print msg is incorrect and seems is not very useful,

[PATCH v3 03/13] net: ethernet: ti: cpsw: remove priv from cpsw_get_slave_port() parameters list

2016-08-09 Thread Ivan Khoronzhuk
There is no need in priv here. Reviewed-by: Mugunthan V N Reviewed-by: Grygorii Strashko Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH v3 00/13] net: ethernet: ti: cpsw: split driver data and per ndev data

2016-08-09 Thread Ivan Khoronzhuk
In dual_emac mode the driver can handle 2 network devices. Each of them can use its own private data and common data/resources. This patchset splits common driver data/resources and private per net device data. It leads to: - reduce memory usage - increase code readability - allows add a bunch of

[PATCH v3 11/13] net: ethernet: ti: cpsw: move platform data and slaves info to cpsw_common

2016-08-09 Thread Ivan Khoronzhuk
These data are common for net devs in dual_emac mode. No need to hold it for every priv instance, so move them under cpsw_common. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 265 + 1 file changed, 137

[PATCH v3 05/13] net: ethernet: ti: cpsw: don't check slave num in runtime

2016-08-09 Thread Ivan Khoronzhuk
No need to check const slave num in runtime for every packet, and ndev for slaves w/o ndev is anyway NULL. So remove redundant check and macro. Reviewed-by: Mugunthan V N Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 11

[PATCH v3 04/13] net: ethernet: ti: cpsw: remove clk var from priv

2016-08-09 Thread Ivan Khoronzhuk
There is no need to hold link to clk, it's used only once while probe. Reviewed-by: Mugunthan V N Reviewed-by: Grygorii Strashko Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 10 -- 1 file

[PATCH v3 06/13] net: ethernet: ti: cpsw: create common struct to hold shared driver data

2016-08-09 Thread Ivan Khoronzhuk
This patch simply create holder for common data and as a start moves pdev var to it. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 62 ++ 1 file changed, 39 insertions(+), 23 deletions(-) diff --git

[PATCH v3 08/13] net: ethernet: ti: cpsw: move links on h/w registers to cpsw_common

2016-08-09 Thread Ivan Khoronzhuk
The pointers on h/w registers are common for every cpsw_private instance, so no need to hold them for every ndev. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 97 +++--- 1 file changed, 53 insertions(+), 44

[PATCH v3 01/13] net: ethernet: ti: cpsw: simplify submit routine

2016-08-09 Thread Ivan Khoronzhuk
As second net dev is created only in case of dual_emac mode, port number can be figured out in simpler way. Also no need to pass redundant ndev struct. Reviewed-by: Mugunthan V N Reviewed-by: Grygorii Strashko Signed-off-by: Ivan Khoronzhuk

Re: [PATCH] bonding: Allow tun-interfaces as slaves

2016-08-09 Thread Jay Vosburgh
Jörn Engel wrote: >On Tue, Aug 09, 2016 at 12:06:36PM -0700, David Miller wrote: >> > On Tue, Aug 09, 2016 at 09:28:45PM +0800, Ding Tianhong wrote: >> > >> > Simply not checking errors when setting the mac address solves the >> > problem for me. No new features needed.

Re: [net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

2016-08-09 Thread Sargun Dhillon
On Tue, Aug 09, 2016 at 05:23:50PM -0700, Alexei Starovoitov wrote: > On Tue, Aug 09, 2016 at 05:00:12PM -0700, Sargun Dhillon wrote: > > This adds a bpf helper that's similar to the skb_in_cgroup helper to check > > whether the probe is currently executing in the context of a specific > > subset

Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.

2016-08-09 Thread YOSHIFUJI Hideaki
David Ahern wrote: > On 8/9/16 1:01 AM, Erik Kline wrote: >> On 9 August 2016 at 14:20, David Miller wrote: >>> From: Lorenzo Colitti >>> Date: Tue, 9 Aug 2016 10:00:25 +0900 >>> Note that pretty much every sendmsg codepath allows other data to

Re: [PATCHv2 3/4] pci: Determine actual VPD size on first access

2016-08-09 Thread Benjamin Herrenschmidt
On Tue, 2016-08-09 at 11:12 -0700, Alexander Duyck wrote: > > The PCI spec is what essentially assumes that there is only one block. > If I am not mistaken in the case of this device the second block here > actually contains device configuration data, not actual VPD data.  The > issue here is

Re: [PATCH net-next v2 0/2] HFSC patches

2016-08-09 Thread David Miller
From: Michal Soltys Date: Wed, 3 Aug 2016 00:44:53 +0200 > Changes since v1: > > - in the first patch's commit message, reference old patch using kernel.org's > historical tree (instead of using gmane) > - in the second patch we just remove variable > > Notes regarding

Re: [net-next v2 v2 2/2] samples/bpf: Add opensnoop example that uses current_task_in_cgroup helper

2016-08-09 Thread Alexei Starovoitov
On Tue, Aug 09, 2016 at 05:00:58PM -0700, Sargun Dhillon wrote: > This example adds the trace_opensnoop BPF sample. This example program > prints all activities of files being opened for all programs in the > provided cgroupsv2 cgroup and it's descendants in the cgroupv2 hierarchy. > > It

Re: [net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

2016-08-09 Thread Alexei Starovoitov
On Tue, Aug 09, 2016 at 05:55:26PM -0700, Sargun Dhillon wrote: > On Tue, Aug 09, 2016 at 05:23:50PM -0700, Alexei Starovoitov wrote: > > On Tue, Aug 09, 2016 at 05:00:12PM -0700, Sargun Dhillon wrote: > > > This adds a bpf helper that's similar to the skb_in_cgroup helper to check > > > whether

Re: [PATCH net-next v3 1/3] strparser: Stream parser for messages

2016-08-09 Thread David Miller
From: Tom Herbert Date: Mon, 1 Aug 2016 14:28:47 -0700 > +/* Lower lock held */ > +void strp_parser_err(struct strparser *strp, int err, read_descriptor_t > *desc) > +{ > + desc->error = err; > + kfree_skb(strp->rx_skb_head); > + strp->rx_skb_head = NULL; > +

Re: [PATCH v2] net: phy: micrel: Add specific suspend

2016-08-09 Thread David Miller
From: Wenyou Yang Date: Fri, 5 Aug 2016 14:35:41 +0800 > Disable all interrupts when suspend, they will be enabled > when resume. Otherwise, the suspend/resume process will be > blocked occasionally. > > Signed-off-by: Wenyou Yang > Acked-by:

[net-next v2 v2 2/2] samples/bpf: Add opensnoop example that uses current_task_in_cgroup helper

2016-08-09 Thread Sargun Dhillon
This example adds the trace_opensnoop BPF sample. This example program prints all activities of files being opened for all programs in the provided cgroupsv2 cgroup and it's descendants in the cgroupv2 hierarchy. It populate a cgroups arraymap prior to execution in userspace. This means that the

Re: [PATCH v6 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-09 Thread Philp Prindeville
On 08/08/2016 10:38 PM, f...@48lvckh6395k16k5.yundunddos.com wrote: From: Gao Feng The PPTP is encapsulated by GRE header with that GRE_VERSION bits must contain one. But current GRE RPS needs the GRE_VERSION must be zero. So RPS does not work for PPTP traffic. In my test

Re: [PATCH] bonding: Allow tun-interfaces as slaves

2016-08-09 Thread Ding Tianhong
On 2016/8/10 7:51, Jay Vosburgh wrote: > Jörn Engel wrote: > >> On Tue, Aug 09, 2016 at 12:06:36PM -0700, David Miller wrote: On Tue, Aug 09, 2016 at 09:28:45PM +0800, Ding Tianhong wrote: Simply not checking errors when setting the mac address solves the

Re: [net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

2016-08-09 Thread Sargun Dhillon
On Tue, Aug 09, 2016 at 06:02:34PM -0700, Alexei Starovoitov wrote: > On Tue, Aug 09, 2016 at 05:55:26PM -0700, Sargun Dhillon wrote: > > On Tue, Aug 09, 2016 at 05:23:50PM -0700, Alexei Starovoitov wrote: > > > On Tue, Aug 09, 2016 at 05:00:12PM -0700, Sargun Dhillon wrote: > > > > This adds a

Re: [net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

2016-08-09 Thread Sargun Dhillon
On Tue, Aug 09, 2016 at 08:27:32PM -0700, Alexei Starovoitov wrote: > On Tue, Aug 09, 2016 at 06:26:37PM -0700, Sargun Dhillon wrote: > > On Tue, Aug 09, 2016 at 06:02:34PM -0700, Alexei Starovoitov wrote: > > > On Tue, Aug 09, 2016 at 05:55:26PM -0700, Sargun Dhillon wrote: > > > > On Tue, Aug

Re: [net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

2016-08-09 Thread Sargun Dhillon
On Tue, Aug 09, 2016 at 08:52:01PM -0700, Alexei Starovoitov wrote: > On Tue, Aug 09, 2016 at 08:40:05PM -0700, Sargun Dhillon wrote: > > On Tue, Aug 09, 2016 at 08:27:32PM -0700, Alexei Starovoitov wrote: > > > On Tue, Aug 09, 2016 at 06:26:37PM -0700, Sargun Dhillon wrote: > > > > On Tue, Aug

Re: problem with MPLS and TSO/GSO

2016-08-09 Thread David Ahern
On 7/25/16 10:39 AM, Lennert Buytenhek wrote: > Hi! > > I am seeing pretty horrible TCP transmit performance (anywhere between > 1 and 10 Mb/s, on a 10 Gb/s interface) when traffic is sent out over a > route that involves MPLS labeling, and this seems to be due to an > interaction between MPLS

Re: [net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

2016-08-09 Thread Alexei Starovoitov
On Tue, Aug 09, 2016 at 08:40:05PM -0700, Sargun Dhillon wrote: > On Tue, Aug 09, 2016 at 08:27:32PM -0700, Alexei Starovoitov wrote: > > On Tue, Aug 09, 2016 at 06:26:37PM -0700, Sargun Dhillon wrote: > > > On Tue, Aug 09, 2016 at 06:02:34PM -0700, Alexei Starovoitov wrote: > > > > On Tue, Aug

Re: [RFC PATCH 2/3] net: macb: Add support for 1588 for Zynq Ultrascale+ MPSoC

2016-08-09 Thread Harini Katakam
Hi Nicolas, Thanks for your reply On Tue, Aug 9, 2016 at 10:26 PM, Punnaiah Choudary Kalluri wrote: > Hi Nicolas, > > 1588 implementation in cadence GEM IP we have in Zynq Ultascale+ MPSoC is > Different to the one in Zynq SOC. > > In earlier version, all

Re: [net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

2016-08-09 Thread Alexei Starovoitov
On Tue, Aug 09, 2016 at 06:26:37PM -0700, Sargun Dhillon wrote: > On Tue, Aug 09, 2016 at 06:02:34PM -0700, Alexei Starovoitov wrote: > > On Tue, Aug 09, 2016 at 05:55:26PM -0700, Sargun Dhillon wrote: > > > On Tue, Aug 09, 2016 at 05:23:50PM -0700, Alexei Starovoitov wrote: > > > > On Tue, Aug

Re: [PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device

2016-08-09 Thread David Miller
From: Toshiaki Makita Date: Thu, 4 Aug 2016 11:11:19 +0900 > Adding fdb entries pointing to the bridge device uses fdb_insert(), > which lacks various checks and does not respect added_by_user flag. > > As a result, some inconsistent behavior can happen: > *

e1000: __pskb_pull_tail failed

2016-08-09 Thread Dave Jones
MY NFS server running 4.8-rc1 is getting flooded with this message: e1000e :00:19.0 eth0: __pskb_pull_tail failed. Never saw it happen with 4.7 or earlier. That device is this onboard NIC: 00:19.0 Ethernet controller: Intel Corporation Ethernet Connection (2) I218-V Dave

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-09 Thread Andreas Werner
On Mon, Aug 08, 2016 at 04:35:34PM +0200, Wolfgang Grandegger wrote: > Am 08.08.2016 um 16:05 schrieb Andreas Werner: > >On Mon, Aug 08, 2016 at 02:28:39PM +0200, Wolfgang Grandegger wrote: > >>Hello, > >> > >>Am 08.08.2016 um 13:39 schrieb Andreas Werner: > >>>On Mon, Aug 08, 2016 at 11:27:25AM

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-09 Thread Andreas Werner
On Mon, Aug 08, 2016 at 08:23:55PM -0700, Benjamin Poirier wrote: > On 2016/08/08 09:26, Andreas Werner wrote: > [...] > > > > + > > > > + if (cf->can_dlc > 0) > > > > + data[0] = be32_to_cpup((__be32 *)(cf->data)); > > > > + if (cf->can_dlc > 3) > > > > +

[RFC PATCH v5 2/3] Documentation: DT: net: Add Xilinx gmiitorgmii converter device tree binding documentation

2016-08-09 Thread Kedareswara rao Appana
Device-tree binding documentation for xilinx gmiitorgmii converter. Signed-off-by: Kedareswara rao Appana --- Changes for v5: ---> Fixed Indentation in the example as suggested by Michal. Changes for v4: --> Modified compatible as suggested by Rob. --> Removed underscores

Re: [PATCH v2 05/14] net: ethernet: ti: cpsw: don't check slave num in runtime

2016-08-09 Thread Grygorii Strashko
On 08/06/2016 01:48 PM, Ivan Khoronzhuk wrote: > No need to check const slave num in runtime for every packet, > and ndev for slaves w/o ndev is anyway NULL. So remove redundant > check. > > Signed-off-by: Ivan Khoronzhuk > --- > drivers/net/ethernet/ti/cpsw.c | 3

Re: [RFC PATCH 1/3] net: Remove unnecessary memset in __snmp6_fill_stats64

2016-08-09 Thread Eric Dumazet
On Mon, 2016-08-08 at 18:22 +0800, Jia He wrote: > buff[] will be assigned later, so memset is not necessary. > > Signed-off-by: Jia He > Cc: "David S. Miller" > Cc: Alexey Kuznetsov > Cc: James Morris > Cc:

[PATCH RESEND net-next 01/15] net: introduce keepalive function in struct proto

2016-08-09 Thread Ursula Braun
Direct call of tcp_set_keepalive() function from protocol-agnostic sock_setsockopt() function in net/core/sock.c violates network layering. And newly introduced protocol (SMC-R) will need its own keepalive function. Therefore, add "keepalive" function pointer to "struct proto", and call it from

[PATCH net-next 5/6] xfrm: state: use rcu_deref and assign_pointer helpers

2016-08-09 Thread Florian Westphal
Before xfrm_state_find() can use rcu_read_lock instead of xfrm_state_lock we need to switch users of the hash table to assign/obtain the pointers with the appropriate rcu helpers. Signed-off-by: Florian Westphal --- net/xfrm/xfrm_state.c | 18 ++ 1 file changed,

[PATCH net-next 3/6] xfrm: state: delay freeing until rcu grace period has elapsed

2016-08-09 Thread Florian Westphal
The hash table backend memory and the state structs are free'd via kfree/vfree. Once we only rely on rcu during lookups we have to make sure no other cpu is currently accessing this before doing the free. Free operations already happen from worker so we can use synchronize_rcu to wait until

[PATCH net-next 2/6] xfrm: state: use atomic_inc_not_zero to increment refcount

2016-08-09 Thread Florian Westphal
Once xfrm_state_lookup_byaddr no longer acquires the state lock another cpu might be freeing the state entry at the same time. To detect this we use atomic_inc_not_zero, we then signal -EAGAIN to caller in case our result was stale. Signed-off-by: Florian Westphal ---

[PATCH net-next 1/6] xfrm: state: use hlist_for_each_entry_rcu helper

2016-08-09 Thread Florian Westphal
This is required once we allow lockless access of bydst/bysrc hash tables. Signed-off-by: Florian Westphal --- net/xfrm/xfrm_state.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/net/xfrm/xfrm_state.c

[PATCH net-next 0/6] xfrm: convert xfrm_state_find to rcu

2016-08-09 Thread Florian Westphal
This series converts state_by{dst,src,spi} to allow lookups without holding xfrm_state_lock. Only xfrm_state_find() is converted here for the (more common) case where we do not query key manager. Once more flows are created/destroyed (or the flow cache is overloaded and often cleans out other

[PATCH net-next 4/6] xfrm: state: add sequence count to detect hash resizes

2016-08-09 Thread Florian Westphal
Once xfrm_state_find is lockless we have to cope with a concurrent resize opertion. We use a sequence counter to block in case a resize is in progress and to detect if we might have missed a state that got moved to a new hash table. Signed-off-by: Florian Westphal ---

[PATCH net-next 6/6] xfrm: state: don't use lock anymore unless acquire operation is needed

2016-08-09 Thread Florian Westphal
push the lock down, after earlier patches we can rely on rcu to make sure state struct won't go away. Signed-off-by: Florian Westphal --- include/net/netns/xfrm.h | 6 +++--- net/xfrm/xfrm_state.c| 6 -- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git

Re: [PATCH v2 02/14] net: ethernet: ti: cpsw: remove redundant check in napi poll

2016-08-09 Thread Grygorii Strashko
On 08/06/2016 01:48 PM, Ivan Khoronzhuk wrote: > No need to check number of handled packets, when in most cases (> 99%) > it's not 0. It can be 0 only in rare cases, even in this case > it's not bad to print just 0. > > Signed-off-by: Ivan Khoronzhuk > --- >

Re: [PATCH v2 01/14] net: ethernet: ti: cpsw: simplify submit routine

2016-08-09 Thread Grygorii Strashko
On 08/06/2016 01:48 PM, Ivan Khoronzhuk wrote: As second net dev is created only in case of dual_emac mode, port number can be figured out in simpler way. Also no need to pass redundant ndev struct. Signed-off-by: Ivan Khoronzhuk --- Reviewed-by: Grygorii Strashko

Re: [PATCH v2 04/14] net: ethernet: ti: cpsw: remove clk var from priv

2016-08-09 Thread Grygorii Strashko
On 08/06/2016 01:48 PM, Ivan Khoronzhuk wrote: There is no need to hold link to clk, it's used only once while probe. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

Re: [PATCH v2 03/14] net: ethernet: ti: cpsw: remove priv from cpsw_get_slave_port() parameters list

2016-08-09 Thread Grygorii Strashko
On 08/06/2016 01:48 PM, Ivan Khoronzhuk wrote: There is no need in priv here. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Grygorii Strashko

Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.

2016-08-09 Thread Lorenzo Colitti
On Tue, Aug 9, 2016 at 6:36 PM, Hannes Frederic Sowa wrote: >> The use of sin6_scope_id and SO_BINDTODEVICE with different interfaces >> is incorrect and should be rejected. > > I agree, I would actually change the behavior at this point, as it also > could have

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-09 Thread Wolfgang Grandegger
Am 09.08.2016 um 08:10 schrieb Andreas Werner: On Mon, Aug 08, 2016 at 04:35:34PM +0200, Wolfgang Grandegger wrote: Am 08.08.2016 um 16:05 schrieb Andreas Werner: On Mon, Aug 08, 2016 at 02:28:39PM +0200, Wolfgang Grandegger wrote: ---snip--- + + ndev = alloc_candev(sizeof(struct

[RFC PATCH v5 0/3] net: phy: Add xilinx gmiitorgmii converter support

2016-08-09 Thread Kedareswara rao Appana
The Gigabit Media Independent Interface (GMII) to Reduced Gigabit Media Independent Interface (RGMII) core provides the RGMII between RGMII-compliant Ethernet physical media devices (PHY) and the Gigabit Ethernet controller. This core can be used in all three modes of operation(10/100/1000 Mb/s).

RE: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-08-09 Thread Ramesh Shanmugasundaram
Hi Andreas, > Subject: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller > driver > > This CAN Controller is found on MEN Chameleon FPGAs. > > The driver/device supports the CAN2.0 specification. > There are 255 RX and 255 Tx buffer within the IP. The pointer for the > buffer are

[RFC PATCH v5 1/3] net: Add mask for Control register 10Mbps speed

2016-08-09 Thread Kedareswara rao Appana
This patch adds mask for the Control register 10Mbps speed. Signed-off-by: Kedareswara rao Appana --- Changes for v5: ---> New patch as suggested by Punnaiah. include/uapi/linux/mii.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/mii.h

RE: [RFC PATCH v4 2/2] net: phy: Add gmiitorgmii converter support

2016-08-09 Thread Appana Durga Kedareswara Rao
Hi Punnaiah, Thanks for the review... > > + > > +#define XILINX_GMII2RGMII_REG 0x10 > > +#define BMCR_SPEED10 0x00 > > Move this macro to mii.h Sure will fix in the next version... > > > + > > +struct gmii2rgmii { > > + struct phy_device *phy_dev; > > + struct

Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.

2016-08-09 Thread Hannes Frederic Sowa
On 09.08.2016 10:37, YOSHIFUJI Hideaki wrote: > > > Erik Kline wrote: >> On 9 August 2016 at 14:20, David Miller wrote: >>> From: Lorenzo Colitti >>> Date: Tue, 9 Aug 2016 10:00:25 +0900 >>> Note that pretty much every sendmsg codepath allows other

[RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

2016-08-09 Thread Kedareswara rao Appana
This patch adds support for gmiitorgmii converter. The GMII to RGMII IP core provides the Reduced Gigabit Media Independent Interface (RGMII) between Ethernet physical media Devices and the Gigabit Ethernet controller. This core can Switch dynamically between the three different speed modes of

Re: [RFC PATCH 2/3] net: Replace for_each_possible_cpu with for_each_online_cpu

2016-08-09 Thread Eric Dumazet
On Mon, 2016-08-08 at 18:22 +0800, Jia He wrote: > In PowerPC server with large number cpus, the loop index in smt=1 could be > reduced to 1/8 compared with smt=8. > Thus cache misses can be reduced. > > Signed-off-by: Jia He > Cc: "David S. Miller" >

Re: Regression introduced by "net: ipconfig: Support using "delayed" DHCP replies"

2016-08-09 Thread Uwe Kleine-König
Hello Geert, On Tue, Aug 09, 2016 at 12:02:44PM +0200, Geert Uytterhoeven wrote: > Hi Uwe, David, > > On current net-next, I see the following corruption during DHCP on > r8a7791/koelsch, which uses the sh_eth driver: > > Sending DHCP requests ., OK > IP-Config: Got DHCP answer from

RE: [patch iproute2 1/2] devlink: write usage help messages to stderr

2016-08-09 Thread David Laight
From: Stephen Hemminger > Sent: 08 August 2016 16:57 > To: Jiri Pirko ... > > >> In order to not confuse reader, write help messages into stderr. > > >> > > >> Signed-off-by: Jiri Pirko > > > > > >This does make devlink consistent with other parts of iproute2. > > >But the most

Regression introduced by "net: ipconfig: Support using "delayed" DHCP replies"

2016-08-09 Thread Geert Uytterhoeven
Hi Uwe, David, On current net-next, I see the following corruption during DHCP on r8a7791/koelsch, which uses the sh_eth driver: Sending DHCP requests ., OK IP-Config: Got DHCP answer from 192.168.97.254, my address is 192.168.97.28 IP-Config: Complete: - device=eth0,

[PATCH RESEND net-next 08/15] smc: work request (WR) base for use by LLC and CDC

2016-08-09 Thread Ursula Braun
The base containers for RDMA transport are work requests and completion queue entries processed through Infiniband verbs: * allocate and initialize these areas * map these areas to DMA * implement the basic communication consisting of work request posting and receival of completion queue events

[PATCH RESEND net-next 12/15] smc: send data (through RDMA)

2016-08-09 Thread Ursula Braun
copy data to kernel send buffer, and trigger RDMA write Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 13 +- net/smc/smc.h | 1 + net/smc/smc_cdc.c | 7 +- net/smc/smc_tx.c | 421

[PATCH RESEND net-next 00/15] net/smc: Shared Memory Communications - RDMA

2016-08-09 Thread Ursula Braun
From: Ursula Braun Dave, since our SMC-R patches still show up in state "Change Requested" on patchwork: https://patchwork.ozlabs.org/project/netdev/list/?submitter=2266=*=1 even though we came up with your requested change in the cover letter, we assume we should

[PATCH RESEND net-next 05/15] smc: CLC handshake (incl. preparation steps)

2016-08-09 Thread Ursula Braun
* CLC (Connection Layer Control) handshake Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 467 ++ net/smc/smc.h | 24 ++- net/smc/smc_clc.c | 251 +

[PATCH RESEND net-next 09/15] smc: initialize IB transport incl. PD, MR, QP, CQ, event, WR

2016-08-09 Thread Ursula Braun
Prepare the link for RDMA transport: Create a queue pair (QP) and move it into the state Ready-To-Receive (RTR). Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 34 ++-- net/smc/smc.h | 1 + net/smc/smc_clc.c | 10 ++- net/smc/smc_core.c | 80

[PATCH RESEND net-next 04/15] smc: introduce SMC as an IB-client

2016-08-09 Thread Ursula Braun
* create a list of SMC IB-devices (IB-devices mentioned in PNET table) * determine RoCE device and port belonging to used internal TCP interface according to the PNET table definitions Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c |

[PATCH RESEND net-next 06/15] smc: connection and link group creation

2016-08-09 Thread Ursula Braun
* create smc_connection for SMC-sockets * determine suitable link group for a connection * create a new link group if necessary Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 103 +-- net/smc/smc.h | 35 ++

[PATCH RESEND net-next 10/15] smc: link layer control (LLC)

2016-08-09 Thread Ursula Braun
send and receive LLC messages CONFIRM_LINK (via IB message send and CQE) Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 94 ++- net/smc/smc_clc.h | 2 + net/smc/smc_core.c | 8 +++ net/smc/smc_core.h

[PATCH RESEND net-next 03/15] smc: establish pnet table management

2016-08-09 Thread Ursula Braun
From: Thomas Richter Connection creation with SMC-R starts through an internal TCP-connection. The Ethernet interface for this TCP-connection is not restricted to the Ethernet interface of a RoCE device. Any existing Ethernet interface belonging to the same physical

4.8.0-rc1: page allocation failure: order:3, mode:0x2084020(GFP_ATOMIC|__GFP_COMP)

2016-08-09 Thread linux
L.S., Just tested 4.8.0-rc1, but i get the stack trace below, everything seems to continue fine afterwards though (haven't tried to bisect it yet, hopefully someone has an insight without having to go through that :) ) My network config consists of a bridge and NAT. -- Sander [10469.336815]

[PATCH RESEND net-next 14/15] smc: socket closing and linkgroup cleanup

2016-08-09 Thread Ursula Braun
smc_shutdown() and smc_release() handling delayed linkgroup cleanup for linkgroups without connections Signed-off-by: Ursula Braun --- net/smc/Makefile| 2 +- net/smc/af_smc.c| 102 ++-- net/smc/smc.h | 20 ++- net/smc/smc_cdc.c | 33 ++--

[PATCH RESEND net-next 11/15] smc: connection data control (CDC)

2016-08-09 Thread Ursula Braun
send and receive CDC messages (via IB message send and CQE) Signed-off-by: Ursula Braun --- net/smc/Makefile | 1 + net/smc/af_smc.c | 8 ++ net/smc/smc.h | 89 + net/smc/smc_cdc.c | 281

[PATCH RESEND net-next 15/15] smc: proc-fs interface for smc connections

2016-08-09 Thread Ursula Braun
Maintain a list of SMC sockets and display important SMC socket information in /proc/net/smc. Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 14 +++ net/smc/smc.h | 1 + net/smc/smc_proc.c | 251

[PATCH RESEND net-next 07/15] smc: remote memory buffers (RMBs)

2016-08-09 Thread Ursula Braun
* allocate data RMB memory for sending and receiving * size depends on the maximum socket send and receive buffers * allocated RMBs are kept during life time of the owning link group * map the allocated RMBs to DMA Signed-off-by: Ursula Braun --- net/smc/af_smc.c |

  1   2   >