[PATCH net-next 5/5] rxrpc: Use a tracepoint for skb accounting debugging

Use a tracepoint to log various skb accounting points to help in debugging refcounting errors. Signed-off-by: David Howells --- include/trace/events/rxrpc.h | 56 ++ net/rxrpc/af_rxrpc.c |1 + net/rxrpc/ar-internal.h |

[PATCH v1 1/1] net: phy: Add Edge-rate driver for Microsemi PHYs.

Hello, The Microsemi PHY (VSC 85xx) device includes programmable control of the rise/fall times for the MAC interface signals. The default setting will select the fastest rise/fall times. With the edge_rate_cntl_set( ) function control the rise/fall time. Edge rate control status will get by

Re: [patch net-next v6_repost 2/3] net: core: add SW stats to if_stats_msg

Tue, Aug 23, 2016 at 04:46:37PM CEST, ro...@cumulusnetworks.com wrote: >On 8/23/16, 12:26 AM, Jiri Pirko wrote: >> Tue, Aug 23, 2016 at 09:04:15AM CEST, da...@davemloft.net wrote: >>> From: Jiri Pirko >>> Date: Tue, 23 Aug 2016 08:53:18 +0200 >>> Anyway I think that next

[PATCH -next] ixgbe: Fix non static symbol warnings

From: Wei Yongjun Fixes the following sparse warnings: drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning: symbol 'ixgbe_led_on_t_x550em' was not declared. Should it be static? drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5: warning: symbol

[PATCH net-next 3/5] rxrpc: When clearing a socket, clear the call sets in the right order

When clearing a socket, we should clear the securing-in-progress list first, then the accept queue and last the main call tree because that's the order in which a call progresses. Not that a call should move from the accept queue to the main tree whilst we're shutting down a socket, but it a call

[PATCH net-next 2/5] rxrpc: Tidy up the rxrpc_call struct a bit

Do a little tidying of the rxrpc_call struct: (1) in_clientflag is no longer compared against the value that's in the packet, so keeping it in this form isn't necessary. Use a flag in flags instead and provide a pair of wrapper functions. (2) We don't read the epoch value, so that

[PATCH net-next 4/5] rxrpc: Drop channel number field from rxrpc_call struct

Drop the channel number (channel) field from the rxrpc_call struct to reduce the size of the call struct. The field is redundant: if the call is attached to a connection, the channel can be obtained from there by AND'ing with RXRPC_CHANNELMASK. Signed-off-by: David Howells

Re: [PATCH -next] net: dsa: bcm_sf2: Remove redundant dev_err call in bcm_sf2_sw_probe()

Hi Wei, [auto build test WARNING on next-20160823] url: https://github.com/0day-ci/linux/commits/Wei-Yongjun/net-dsa-bcm_sf2-Remove-redundant-dev_err-call-in-bcm_sf2_sw_probe/20160823-233314 config: sparc64-allyesconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 5.4.0-6

Re: [PATCH net-next 3/3] net/sched: Introduce act_iptunnel

On Tue, 23 Aug 2016 19:05:37 +0300, Amir Vadai wrote: > It is already there - user can use act_mirred and redirect skb's with > metadata since shared tunnel devices introduced. You're right, I haven't thought of that. > The only thing that was added here, is to enable the user to drop the >

[PATCH] ath10k: replace config_enabled() with IS_REACHABLE()

Commit 97f2645f358b ("tree-wide: replace config_enabled() with IS_ENABLED()") mostly did away with config_enabled(). This is one of the postponed TODO items as config_enabled() is used for a tristate option here. Theoretically, config_enabled() is equivalent to IS_BUILTIN(), but I guess

Re: [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

HI, Thanks for the patch.. On Tue, Aug 23, 2016 at 8:36 PM, Wei Yongjun wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning: > symbol 'xgmiitorgmii_probe' was not declared.

[PATCH v3] net: lpc_eth: Check clk_prepare_enable() error

clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of failure While at it, replace __lpc_eth_clock_enable() with a plain clk_prepare_enable/clk_disable_unprepare() call in order to simplify the code. Signed-off-by: Fabio Estevam

[PATCH net-next 1/1] qede: Add support for Tx/Rx-only queues.

Add provision for configuring the fastpath queues with Tx (or Rx) only functionality. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz --- Please consider applying this to 'net-next' branch. ---

[PATCH net-next 1/3] rxrpc: Set connection expiry on idle, not put

Set the connection expiry time when a connection becomes idle rather than doing this in rxrpc_put_connection(). This makes the put path more efficient (it is likely to be called occasionally whilst a connection has outstanding calls because active workqueue items needs to be given a ref). The

Re: net: Zeroing the structure ethtool_wolinfo in ethtool_get_wol()

On Tue, 2016-08-23 at 19:27 +0400, Loganaden Velvindron wrote: > Better be safe than sorry. Better still would be to create a tool via something like coccinelle that could be run on the entire kernel than submit a single patch for a construct that likely occurs dozens of times in the kernel

Re: net: Zeroing the structure ethtool_wolinfo in ethtool_get_wol()

On Tue, 2016-08-23 at 08:05 -0700, Joe Perches wrote: > A compiler does not have a standards based requirement to > initialize arbitrary padding bytes. > > I believe gcc always does zero all padding anyway. I would not worry for kernel code, because the amount of scrutiny there will be enough

[PATCH net-next 3/3] rxrpc: Perform terminal call ACK/ABORT retransmission from conn processor

Perform terminal call ACK/ABORT retransmission in the connection processor rather than in the call processor. With this change, once last_call is set, no more incoming packets will be routed to the corresponding call or any earlier calls on that channel (call IDs must only increase on a channel

Re: [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

Hi Andrew, On 08/23/2016 11:16 PM, Andrew Lunn wrote: > On Tue, Aug 23, 2016 at 03:06:05PM +, Wei Yongjun wrote: >> From: Wei Yongjun > Hi Wei > > No need for the additional From: > > git am will use the one in the mail header as the author of the patch, > and it is

[PATCH net] sctp: fix overrun in sctp_diag_dump_one()

The function sctp_diag_dump_one() currently performs a memcpy() of 64 bytes from a 16 byte field into another 16 byte field. Fix by using correct size, use sizeof to obtain correct size instead of using a hard-coded constant. Fixes: 8f840e47f190 ("sctp: add the sctp_diag.c file") Signed-off-by:

[PATCH net-next 0/3] rxrpc: Miscellaneous improvements

: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rewrite-20160823-2 David --- David Howells (3): rxrpc: Set connection expiry on idle, not put

[PATCH net-next 2/3] rxrpc: Calculate serial skew on packet reception

Calculate the serial number skew in the data_ready handler when a packet has been received and a connection looked up. The skew is cached in the sk_buff's priority field. The connection highest received serial number is updated at this time also. This can be done without locks or atomic

Re: [PATCH v3 net-next] net: diag: support SOCK_DESTROY for UDP sockets

On Tue, 2016-08-23 at 08:02 -0700, David Ahern wrote: > This implements SOCK_DESTROY for UDP sockets similar to what was done > for TCP with commit c1e64e298b8ca ("net: diag: Support destroying TCP > sockets.") A process with a UDP socket targeted for destroy is awakened > and recvmsg fails with

Re: [for-next V3 00/15][PULL request] Mellanox mlx5 core driver updates 2016-08-20

On Tue, Aug 23, 2016 at 6:57 PM, Doug Ledford wrote: > On 8/23/2016 4:49 AM, Saeed Mahameed wrote: >> Hi Dave and Doug, >> >> This series contains several low level and API updates for mlx5 core >> commands interface and mlx5_ifc.h to be shared as base code for net-next and

Re: [PATCH v3 net-next] net: diag: support SOCK_DESTROY for UDP sockets

On 8/23/16 10:37 AM, Lorenzo Colitti wrote: > On Wed, Aug 24, 2016 at 12:02 AM, David Ahern > wrote: >> +int udp_abort(struct sock *sk, int err) >> +{ >> + lock_sock(sk); >> + >> + sk->sk_err = err; >> + sk->sk_error_report(sk); >> +

[PATCH -next] net: hns: remove redundant dev_err call in hns_dsaf_get_cfg()

From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 16

Re: [PATCH net] sctp: fix overrun in sctp_diag_dump_one()

On Tue, Aug 23, 2016 at 11:40 PM, Lance Richardson wrote: > The function sctp_diag_dump_one() currently performs a memcpy() > of 64 bytes from a 16 byte field into another 16 byte field. Fix > by using correct size, use sizeof to obtain correct size instead > of using a

[PATCH net] udp: get rid of SLAB_DESTROY_BY_RCU allocations

From: Eric Dumazet After commit ca065d0cf80f ("udp: no longer use SLAB_DESTROY_BY_RCU") we do not need this special allocation mode anymore, even if it is harmless. Signed-off-by: Eric Dumazet --- Note that sk_prot_clear_portaddr_nulls() is no longer

[PATCH] net: ena: change the return type of ena_set_push_mode() to be void.

This patch changes the return type of ena_set_push_mode() to be void, as it always returns 0. Signed-off-by: Rami Rosen --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git

[PATCH -next] cxgb4: Remove unused including

From: Wei Yongjun Remove including that don't need it. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c

[PATCH -next] net: dsa: bcm_sf2: Remove redundant dev_err call in bcm_sf2_sw_probe()

From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/net/dsa/bcm_sf2.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH net-next] net: dsa: rename switch operations structure

Now that the dsa_switch_driver structure contains only function pointers as it is supposed to, rename it to the more appropriate dsa_switch_ops, uniformly to any other operations structure in the kernel. No functional changes here, basically just the result of something like: s/dsa_switch_driver

Re: [PATCH net-next 3/3] net/sched: Introduce act_iptunnel

On Tue, Aug 23, 2016 at 08:37:07AM -0400, Jamal Hadi Salim wrote: > On 16-08-22 10:38 AM, Amir Vadai wrote: > > This action could be used before redirecting packets to a shared tunnel > > device, or when redirecting packets arriving from a such a device > > > > The action will release the

Re: CVE-2014-9900 fix is not upstream

From: Luis Henriques Date: Tue, 23 Aug 2016 14:41:07 +0100 > Digging through some old CVEs I came across this one that doesn't seem be > in mainline. Was there a good reason for not being sent upstream? Maybe it > was > rejected for some reason and I failed to

[PATCH -next] igb: fix non static symbol warning

From: Wei Yongjun Fixes the following sparse warning: drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: symbol 'igb_rxnfc_write_vlan_prio_filter' was not declared. Should it be static? Signed-off-by: Wei Yongjun ---

Re: [PATCH net-next 3/3] net/sched: Introduce act_iptunnel

On Mon, Aug 22, 2016 at 08:51:37PM +0200, Jiri Benc wrote: > On Mon, 22 Aug 2016 21:15:41 +0300, Or Gerlitz wrote: > > Jiri B > I understand the motivation for the decap action. However, what > > would > > Jiri B > happen if someone does not include it? > > > > The MD set by the (say) vxlan

Re: [PATCH net-next 3/3] net/sched: Introduce act_iptunnel

On Tue, Aug 23, 2016 at 05:33:49PM +0200, Jiri Benc wrote: > On Tue, 23 Aug 2016 18:28:05 +0300, Amir Vadai wrote: > > On Mon, Aug 22, 2016 at 08:51:37PM +0200, Jiri Benc wrote: > > > 2. We may run into problems like tx path seeing the metadata_dst that > > >it should not see. This means

Re: net: Zeroing the structure ethtool_wolinfo in ethtool_get_wol()

2016-08-23 18:36 GMT+03:00 Eric Dumazet : > On Tue, 2016-08-23 at 08:05 -0700, Joe Perches wrote: > >> A compiler does not have a standards based requirement to >> initialize arbitrary padding bytes. >> >> I believe gcc always does zero all padding anyway. > > I would not

Re: [PATCH v3 net-next] net: diag: support SOCK_DESTROY for UDP sockets

On Wed, Aug 24, 2016 at 12:02 AM, David Ahern wrote: > +int udp_abort(struct sock *sk, int err) > +{ > + lock_sock(sk); > + > + sk->sk_err = err; > + sk->sk_error_report(sk); > + udp_disconnect(sk, 0); I notice that udp_disconnect does

Re: [PATCH v3 net-next] net: diag: support SOCK_DESTROY for UDP sockets

On Wed, Aug 24, 2016 at 2:02 AM, David Ahern wrote: >> Looking at the code again, it seems that there's a bug in >> sock_diag_destroy. If the destroy operation does not occur (e.g., if >> sock_diag_destroy returns EPERM, or the protocol doesn't support >> destroy), then

[PATCH net-next 1/5] rxrpc: Remove RXRPC_CALL_PROC_BUSY

Remove RXRPC_CALL_PROC_BUSY as work queue items are now 100% non-reentrant. Signed-off-by: David Howells --- net/rxrpc/ar-internal.h |1 - net/rxrpc/call_event.c |6 -- 2 files changed, 7 deletions(-) diff --git a/net/rxrpc/ar-internal.h

Re: [PATCH net-next 3/3] net/sched: Introduce act_iptunnel

On Tue, 23 Aug 2016 18:28:05 +0300, Amir Vadai wrote: > On Mon, Aug 22, 2016 at 08:51:37PM +0200, Jiri Benc wrote: > > 2. We may run into problems like tx path seeing the metadata_dst that > >it should not see. This means either this situation or such > >configuration must be prevented

[PATCH net-next 0/5] rxrpc: Cleanups

: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rewrite-20160823-1 David --- David Howells (5): rxrpc: Remove RXRPC_CALL_PROC_BUSY rxrpc: Tidy up the rxrpc_call struct a bit rxrpc: When clearing a socket, clear the call sets in the right order

Re: [for-next V3 00/15][PULL request] Mellanox mlx5 core driver updates 2016-08-20

On 8/23/2016 4:49 AM, Saeed Mahameed wrote: > Hi Dave and Doug, > > This series contains several low level and API updates for mlx5 core > commands interface and mlx5_ifc.h to be shared as base code for net-next and > rdma mlx5 4.9 submissions. > > From Saeed, ten patches that refactors old

Re: net: Zeroing the structure ethtool_wolinfo in ethtool_get_wol()

On 23 August 2016 at 17:05, Joe Perches wrote: > On Tue, 2016-08-23 at 07:21 -0700, Eric Dumazet wrote: >> On Tue, 2016-08-23 at 14:41 +0100, Luis Henriques wrote: >> > From: Avijit Kanti Das >> > >> > memset() the structure ethtool_wolinfo that has

RE: [Intel-wired-lan] [PATCH -next] ixgbe: Fix non static symbol warnings

>-Original Message- >From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On >Behalf Of Wei Yongjun >Sent: Tuesday, August 23, 2016 8:07 AM >To: Kirsher, Jeffrey T >Cc: intel-wired-...@lists.osuosl.org; Wei Yongjun ;

[PATCH v3 net-next] net: diag: support SOCK_DESTROY for UDP sockets

This implements SOCK_DESTROY for UDP sockets similar to what was done for TCP with commit c1e64e298b8ca ("net: diag: Support destroying TCP sockets.") A process with a UDP socket targeted for destroy is awakened and recvmsg fails with ECONNABORTED. Signed-off-by: David Ahern

Re: [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

On Tue, Aug 23, 2016 at 11:41:25PM +0800, Wei Yongjun wrote: > Hi Andrew, > > On 08/23/2016 11:16 PM, Andrew Lunn wrote: > > On Tue, Aug 23, 2016 at 03:06:05PM +, Wei Yongjun wrote: > >> From: Wei Yongjun > > Hi Wei > > > > No need for the additional From: > > > > git

Re: [PATCH 3/4] dsa: mv88e6xxx: Delete ppu timer when removing module

> >+static void mv88e6xxx_phy_destroy(struct mv88e6xxx_chip *chip) > >+{ > >+if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_PPU)) { > >+mv88e6xxx_ppu_state_destroy(chip); > >+} > >{} not needed here. See Documentation/CodingStyle, chapter 3. Agreed, I will send a follow up patch,

Re: [PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

On Tue, Aug 23, 2016 at 03:06:05PM +, Wei Yongjun wrote: > From: Wei Yongjun Hi Wei No need for the additional From: git am will use the one in the mail header as the author of the patch, and it is in the signed-off-by as well. Thanks Andrew > Fixes the

Re: [PATCH v3 net-next] net: diag: support SOCK_DESTROY for UDP sockets

On 8/23/16 11:13 AM, Lorenzo Colitti wrote: > On Wed, Aug 24, 2016 at 2:02 AM, David Ahern wrote: >>> Looking at the code again, it seems that there's a bug in >>> sock_diag_destroy. If the destroy operation does not occur (e.g., if >>> sock_diag_destroy returns EPERM,

Re: [PATCH v3 net-next] net: diag: support SOCK_DESTROY for UDP sockets

On Wed, Aug 24, 2016 at 2:16 AM, David Ahern wrote: >> So you'd remove the sock_put and sock_gen_put calls from tcp_abort and >> just add one sock_gen_put in tcp_diag_destroy? That does seem simpler. > > untested and mangled on a copy and paste but the intent is: ... >

Re: net: Zeroing the structure ethtool_wolinfo in ethtool_get_wol()

On Tue, 2016-08-23 at 07:21 -0700, Eric Dumazet wrote: > On Tue, 2016-08-23 at 14:41 +0100, Luis Henriques wrote: > > From: Avijit Kanti Das > > > > memset() the structure ethtool_wolinfo that has padded bytes > > but the padded bytes have not been zeroed out. [] > >

[PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

From: Wei Yongjun Fixes the following sparse warning: drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning: symbol 'xgmiitorgmii_probe' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/phy/xilinx_gmii2rgmii.c | 2

[PATCH -next] vmxnet3: fix non static symbol warning

From: Wei Yongjun Fixes the following sparse warning: drivers/net/vmxnet3/vmxnet3_drv.c:1645:1: warning: symbol 'vmxnet3_rq_destroy_all_rxdataring' was not declared. Should it be static? Signed-off-by: Wei Yongjun ---

Re: [PATCH v3 net-next] net: diag: support SOCK_DESTROY for UDP sockets

CC Lorenzo Colitti On Tue, 2016-08-23 at 08:02 -0700, David Ahern wrote: > This implements SOCK_DESTROY for UDP sockets similar to what was done > for TCP with commit c1e64e298b8ca ("net: diag: Support destroying TCP > sockets.") A process with a UDP socket targeted for

Re: [PATCH RESEND 8/8] af_unix: charge buffers to kmemcg

On 23/08/16 17:44, Vladimir Davydov wrote: Hello, On Tue, Aug 23, 2016 at 02:48:11PM +0100, Sudeep K N wrote: On Tue, May 24, 2016 at 5:36 PM, Vladimir Davydov wrote: On Tue, May 24, 2016 at 06:02:06AM -0700, Eric Dumazet wrote: On Tue, 2016-05-24 at 11:49 +0300,

Re: net: Zeroing the structure ethtool_wolinfo in ethtool_get_wol()

On 23/08/16 16:36, Eric Dumazet wrote: > On Tue, 2016-08-23 at 08:05 -0700, Joe Perches wrote: > >> A compiler does not have a standards based requirement to >> initialize arbitrary padding bytes. >> >> I believe gcc always does zero all padding anyway. > Even if the current standards are lazy

Re: [for-next V3 00/15][PULL request] Mellanox mlx5 core driver updates 2016-08-20

From: Saeed Mahameed Date: Tue, 23 Aug 2016 11:49:02 +0300 > This series contains several low level and API updates for mlx5 core > commands interface and mlx5_ifc.h to be shared as base code for net-next and > rdma mlx5 4.9 submissions. Pulled, thanks.

Re: [ethtool PATCH v4 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G

On Tue, Aug 23, 2016 at 6:30 AM, Vidya Sagar Ravipati wrote: > From: Vidya Sagar Ravipati > > Enhancing link mode bits to support 25G/50G/100G > for supported and advertised speed mode bits > > Signed-off-by: Vidya Sagar Ravipati

Re: CVE-2014-9900 fix is not upstream

From: Ben Hutchings Date: Tue, 23 Aug 2016 18:35:27 +0100 > On Tue, 2016-08-23 at 09:40 -0700, David Miller wrote: >> From: Luis Henriques >> Date: Tue, 23 Aug 2016 14:41:07 +0100 >> >> > Digging through some old CVEs I came across this one

Re: net: Zeroing the structure ethtool_wolinfo in ethtool_get_wol()

On Tue, 2016-08-23 at 14:41 +0100, Luis Henriques wrote: > From: Avijit Kanti Das > > memset() the structure ethtool_wolinfo that has padded bytes > but the padded bytes have not been zeroed out. > > Change-Id: If3fd2d872a1b1ab9521d937b86a29fc468a8bbfe >

[PATCH net-next 1/4] ipv6: udp: remove udp_v6_clear_sk()

Now RCU lookups of ipv6 udp sockets no longer dereference pinet6 field, we can get rid of udp_v6_clear_sk() helper. Signed-off-by: Eric Dumazet --- net/ipv6/udp.c | 13 + net/ipv6/udp_impl.h | 2 -- net/ipv6/udplite.c | 2 +- 3 files changed, 2

Re: [for-next V3 00/15][PULL request] Mellanox mlx5 core driver updates 2016-08-20

On Tue, Aug 23, 2016 at 07:10:53PM +0300, Saeed Mahameed wrote: > On Tue, Aug 23, 2016 at 6:57 PM, Doug Ledford wrote: > > On 8/23/2016 4:49 AM, Saeed Mahameed wrote: > >> Hi Dave and Doug, > >> > >> This series contains several low level and API updates for mlx5 core > >>

[PATCH net-next 0/4] net: remove clear_sk() method

Since IPv6 socket lookups no longer dereference pinet6 pointer and UDP lost SLAB_DESTROY_BY_RCU special rules, we no longer need special clear_sk() methods. Eric Dumazet (4): ipv6: udp: remove udp_v6_clear_sk() udp: get rid of sk_prot_clear_portaddr_nulls() ipv6: tcp: get rid of

[PATCH net-next 4/4] net: remove clear_sk() method

We no longer use this handler, we can delete it. Signed-off-by: Eric Dumazet --- include/net/sock.h | 1 - net/core/sock.c| 8 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index

[PATCH net-next 3/4] ipv6: tcp: get rid of tcp_v6_clear_sk()

Now RCU lookups of IPv6 TCP sockets no longer dereference pinet6, we do not need tcp_v6_clear_sk() anymore. Signed-off-by: Eric Dumazet --- net/ipv6/tcp_ipv6.c | 12 1 file changed, 12 deletions(-) diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index

[PATCH net-next 2/4] udp: get rid of sk_prot_clear_portaddr_nulls()

Since we no longer use SLAB_DESTROY_BY_RCU for UDP, we do not need sk_prot_clear_portaddr_nulls() helper. Signed-off-by: Eric Dumazet --- include/net/sock.h | 2 -- net/core/sock.c| 18 -- net/ipv4/udp.c | 1 - net/ipv4/udplite.c | 1 -

Re: [PATCH net-next 1/2] net: diag: slightly refactor the inet_diag_bc_audit error checks.

Hi Lorenzo, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Lorenzo-Colitti/net-diag-slightly-refactor-the-inet_diag_bc_audit-error-checks/20160824-020848 config: x86_64-randconfig-x015-201634 (attached as .config) compiler: gcc-6 (Debian 6.1.1-9)

Re: [Xen-devel] [PATCH net-next] xen-netfront: avoid packet loss when ethernet header crosses page boundary

David Vrabel writes: > On 22/08/16 16:42, Vitaly Kuznetsov wrote: >> >> I see two ways to fix the issue: >> - Change the 'wire' protocol between netfront and netback to start keeping >> the original SKB structure. We'll have to add a flag indicating the fact >> that

Re: [PATCH net-next 2/2] net: diag: allow socket bytecode filters to match socket marks

On 8/23/16 12:06 PM, Lorenzo Colitti wrote: > @@ -713,10 +728,11 @@ static bool valid_markcond(const struct inet_diag_bc_op > *op, int len, > return len >= *min_len; > } > > -static int inet_diag_bc_audit(struct nlattr *attr) > +static int inet_diag_bc_audit(struct nlattr *attr, const

Re: [for-next V3 00/15][PULL request] Mellanox mlx5 core driver updates 2016-08-20

On 8/23/2016 2:39 PM, Leon Romanovsky wrote: > On Tue, Aug 23, 2016 at 07:10:53PM +0300, Saeed Mahameed wrote: >> On Tue, Aug 23, 2016 at 6:57 PM, Doug Ledford wrote: >>> On 8/23/2016 4:49 AM, Saeed Mahameed wrote: From Hadar and Ilya, added the needed hardware bits and

[PATCH net-next 2/2] kcm: Fix locking issue

Lock the lower socket in kcm_unattach. Release during call to strp_done since that function cancels the RX timers and work queue with sync. Also added some status information in psock reporting. Signed-off-by: Tom Herbert --- net/kcm/kcmproc.c | 20 +++-

Re: [PATCH net-next 1/2] net: diag: slightly refactor the inet_diag_bc_audit error checks.

On Wed, 2016-08-24 at 03:06 +0900, Lorenzo Colitti wrote: > This simplifies the code a bit and also allows inet_diag_bc_audit > to send to userspace an error that isn't EINVAL. > > Signed-off-by: Lorenzo Colitti > --- > net/ipv4/inet_diag.c | 35

[PATCH net-next 0/2] strp: Minor fixes to strparser and kcm

Fix locking issue in kcm and losing events when paused. Tom Herbert (2): strparser: Queue work when being unpaused kcm: Fix locking issue include/net/strparser.h | 5 + net/kcm/kcmproc.c | 20 +++- net/kcm/kcmsock.c | 13 -

[PATCH net-next 1/2] strparser: Queue work when being unpaused

When the upper layer unpauses a stream parser connection we need to queue rx_work to make sure no events are missed. Signed-off-by: Tom Herbert --- include/net/strparser.h | 5 + net/strparser/strparser.c | 11 +++ 2 files changed, 12 insertions(+), 4

Re: CVE-2014-9900 fix is not upstream

On Tue, 2016-08-23 at 09:40 -0700, David Miller wrote: > From: Luis Henriques > Date: Tue, 23 Aug 2016 14:41:07 +0100 > > > Digging through some old CVEs I came across this one that doesn't > seem be > > in mainline.  Was there a good reason for not being sent

Re: [PATCH net] sctp: fix overrun in sctp_diag_dump_one()

On Tue, Aug 23, 2016 at 11:40:52AM -0400, Lance Richardson wrote: > The function sctp_diag_dump_one() currently performs a memcpy() > of 64 bytes from a 16 byte field into another 16 byte field. Fix > by using correct size, use sizeof to obtain correct size instead > of using a hard-coded

[PATCH 07/14] hv_netvsc: make device_remove void

From: Stephen Hemminger Always returns 0 and no callers check. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h |2 +- drivers/net/hyperv/netvsc.c |3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff

[PATCH 02/14] hv_netvsc: make RSS hash key static

From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h |2 -- drivers/net/hyperv/rndis_filter.c |3 ++- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/hyperv/hyperv_net.h

Re: [PATCH v3 net-next] net: diag: support SOCK_DESTROY for UDP sockets

On Wed, 2016-08-24 at 02:24 +0900, Lorenzo Colitti wrote: > On Wed, Aug 24, 2016 at 2:16 AM, David Ahern wrote: > >> So you'd remove the sock_put and sock_gen_put calls from tcp_abort and > >> just add one sock_gen_put in tcp_diag_destroy? That does seem simpler. > > > >

[PATCH 04/14] hv_netvsc: style cleanups

From: Stephen Hemminger Fix most of the complaints about the style of the code. Things like extra blank lines and return statements. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 18 ++

[PATCH 01/14] hv_netvsc: fix rtnl locking in callback

From: Stephen Hemminger The function get_netvsc_net_device had conditional locking. This was unnecessary, incorrect, but harmless. It was unnecessary since the code is only called from netlink netdev event callback where RTNL is always acquired before the callbacks are

[PATCH 10/14] hv_netvsc: refactor completion function

From: Stephen Hemminger Break the different cases, code is cleaner if broken up Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 103 1 file changed, 56 insertions(+), 47

[PATCH 07/14] hv_netvsc: make device_remove void

From: Stephen Hemminger Always returns 0 and no callers check. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH net-next 2/2] net: diag: allow socket bytecode filters to match socket marks

This allows a privileged process to filter by socket mark when dumping sockets via INET_DIAG_BY_FAMILY. This is useful on systems that use mark-based routing such as Android. The ability to filter socket marks requires CAP_NET_ADMIN, which is consistent with other privileged operations allowed by

[PATCH 14/14] hv_netvsc: add ethtool statistics for tx packet issues

From: Stephen Hemminger Printing console messages is not helpful when system is out of memory; and can be disastrous with netconsole. Instead keep statistics of these anomalous conditions. Signed-off-by: Stephen Hemminger ---

[PATCH 06/14] hv_netvsc: use ARRAY_SIZE() for NDIS versions

From: Stephen Hemminger Don't hard code size of array of NDIS versions. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/hyperv/netvsc.c

[PATCH 02/14] hv_netvsc: make RSS hash key static

From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 2 -- drivers/net/hyperv/rndis_filter.c | 3 ++- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/hyperv/hyperv_net.h

[PATCH 13/14] hv_netvsc: report vmbus name in ethtool

From: Stephen Hemminger Make netvsc on vmbus behave more like PCI. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 4 include/linux/hyperv.h | 7 +++ 2 files changed, 11 insertions(+) diff --git

[PATCH 11/14] hv_netvsc: make netvsc_destroy_buf void

From: Stephen Hemminger No caller checks the return value. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/hyperv/netvsc.c

[PATCH 05/14] hv_netvsc: make inline functions static

From: Stephen Hemminger Several new functions were introduced into hyperv.h but only used in one file. Move them and let compiler decide on inline. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 85

[PATCH 08/14] hv_netvsc: init completion during alloc

From: Stephen Hemminger Move initialization to allocate where other fields are initialized. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 09/14] hv_netvsc: rearrange start_xmit

From: Stephen Hemminger Rearrange the transmit routine to eliminate goto's and unnecessary boolean variables. Use standard functions to test for vlan tag. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 106

[PATCH net-next 1/2] net: diag: slightly refactor the inet_diag_bc_audit error checks.

This simplifies the code a bit and also allows inet_diag_bc_audit to send to userspace an error that isn't EINVAL. Signed-off-by: Lorenzo Colitti --- net/ipv4/inet_diag.c | 35 --- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git

[PATCH 12/14] hv_netvsc: make variable local

From: Stephen Hemminger The variable m_ret is only used in one basic block. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/hyperv/netvsc.c

[PATCH 03/14] hv_netvsc: use kcalloc

From: Stephen Hemminger Better to use kcalloc rather than kzalloc and multiply for an array. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] cxgb4: fix invalid checks in alloc_uld_rxqs

Local variable msi_idx defined as unsigned int is always >= 0, thus both 'if' checks are always true. On the other side presence of USING_MSIX flag suggests the checks should not be trivially true. The simplest solution is to replace incorrect checks with direct testing of adap->flags and remove

Re: [PATCH net-next 1/3] net/ip_tunnels: Introduce tunnel_id_to_key32() and key32_to_tunnel_id()

On Mon, Aug 22, 2016 at 07:00:27PM +0200, Jiri Benc wrote: > While cleaning this up, you may as well take the best of both > implementations. > > On Mon, 22 Aug 2016 17:38:32 +0300, Amir Vadai wrote: > > +static inline __be64 key32_to_tunnel_id(__be32 key) > > +{ > > +#ifdef __BIG_ENDIAN > > +

[PATCH net-next] cxgb4: Fix issue while re-registering VF mgmt netdev

When we disable SRIOV, we used to unregister the netdev but wasn't freed. But next time when the same netdev is registered, since the state was in 'NETREG_UNREGISTERED', we used to hit BUG_ON in register_netdevice, where it expects the state to be 'NETREG_UNINITIALIZED'. Alloc netdev and register

[net-next PATCH 13/15] net: sched: add support for TCQ_F_NOLOCK subqueues to sch_mq

The sch_mq qdisc creates a sub-qdisc per tx queue which are then called independently for enqueue and dequeue operations. However statistics are aggregated and pushed up to the "master" qdisc. This patch adds support for any of the sub-qdiscs to be per cpu statistic qdiscs. To handle this case

  1   2   3   >