RE: [PATCH net-next 2/2] bnx2x: allocate mac filtering pending list in PAGE_SIZE increments

2016-09-20 Thread Mintz, Yuval
> >> Currently, we can have high order page allocations that specify > >> GFP_ATOMIC when configuring multicast MAC address filters. > >> > >> For example, we have seen order 2 page allocation failures with > >> ~500 multicast addresses configured. > >> > >> Convert the allocation for the pending

[PATCH net-next] bnxt_en: Fix build error for kernesl without RTC-LIB

2016-09-20 Thread Michael Chan
From: Rob Swindell bnxt_hwrm_fw_set_time() now returns -EOPNOTSUPP when built for kernel without RTC_LIB. Setting the firmware time is not critical to the successful completion of the firmware update process. Signed-off-by: Rob Swindell

Re: [v3] net: ipv6: fallback to full lookup if table lookup is unsuitable

2016-09-20 Thread David Miller
From: Vincent Bernat Date: Sun, 18 Sep 2016 17:46:07 +0200 > Commit 8c14586fc320 ("net: ipv6: Use passed in table for nexthop > lookups") introduced a regression: insertion of an IPv6 route in a table > not containing the appropriate connected route for the gateway but which >

Re: [PATCH net-next v2 00/10] bnxt: update for net-next.

2016-09-20 Thread David Miller
From: Michael Chan Date: Tue, 20 Sep 2016 02:50:18 -0400 > Misc. changes and minor bug fixes for net-next. Please review. > > v2: Updated "bnxt_en: Added support for Secure Firmware Update" patch. Michael, I applied v1 already.

Re: [PATCH net-next 00/10] bnxt: update for net-next.

2016-09-20 Thread Michael Chan
On Mon, Sep 19, 2016 at 6:32 PM, David Miller wrote: > From: Michael Chan > Date: Mon, 19 Sep 2016 03:57:59 -0400 > >> Misc. changes and minor bug fixes for net-next. Please review. > > Series applied, thanks Michael. Sorry, I missed this and

[PATCH net-next v2 06/10] bnxt_en: Re-arrange bnxt_hwrm_func_qcaps().

2016-09-20 Thread Michael Chan
Re-arrange the code so that the generation of the random MAC address for the VF is at the end of the function. The next patch will add one more step to call bnxt_approve_mac() to get the firmware to approve the random MAC address. Signed-off-by: Michael Chan ---

[PATCH net-next v2 07/10] bnxt_en: Call firmware to approve the random VF MAC address.

2016-09-20 Thread Michael Chan
After generating the random MAC address for VF, call the firmware to approve it. This step serves 2 purposes. Some hypervisor (e.g. ESX) wants to approve the MAC address. 2nd, the call will setup the proper forwarding database in the internal switch. We need to unlock the hwrm_cmd_lock mutex

[PATCH net-next v2 05/10] bnxt_en: Fix ethtool -l|-L inconsistent channel counts.

2016-09-20 Thread Michael Chan
The existing code is inconsistent in reporting and accepting the combined channel count. bnxt_get_channels() reports maximum combined as the maximum rx count. bnxt_set_channels() accepts combined count that cannot be bigger than max rx or max tx. For example, if max rx = 2 and max tx = 1, we

[PATCH net-next v2 09/10] bnxt_en: Support for "ethtool -r" command

2016-09-20 Thread Michael Chan
From: Deepak Khungar Restart autoneg if autoneg is enabled. Signed-off-by: Deepak Khungar Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 20 1 file

[PATCH net-next v2 10/10] bnxt_en: Fixed the VF link status after a link state change

2016-09-20 Thread Michael Chan
From: Eddie Wai The VF link state can be changed via the 'ip link set' cmd. Currently, the new link state does not take effect immediately. The fix is for the PF to send a link change async event to the designated VF after a VF link state change. This async event will

[PATCH net-next v2 04/10] bnxt_en: Added support for Secure Firmware Update

2016-09-20 Thread Michael Chan
From: Rob Swindell Using Ethtool flashdev command, entire NVM package (*.pkg) files may now be staged into the "update" area of the NVM and subsequently verified and installed by the firmware using the newly introduced command: NVM_INSTALL_UPDATE. We also introduce

[PATCH net-next v2 03/10] bnxt_en: Update to firmware interface spec 1.5.1.

2016-09-20 Thread Michael Chan
Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c |3 + drivers/net/ethernet/broadcom/bnxt/bnxt.h | 14 +- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 1251 +++-- 3 files changed, 760 insertions(+), 508

[PATCH net-next v2 08/10] bnxt_en: Pad TX packets below 52 bytes.

2016-09-20 Thread Michael Chan
The hardware has a limitation that it won't pass host to BMC loopback packets below 52-bytes. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next v2 00/10] bnxt: update for net-next.

2016-09-20 Thread Michael Chan
Misc. changes and minor bug fixes for net-next. Please review. v2: Updated "bnxt_en: Added support for Secure Firmware Update" patch. Deepak Khungar (1): bnxt_en: Support for "ethtool -r" command Eddie Wai (1): bnxt_en: Fixed the VF link status after a link state change Michael Chan (7):

[PATCH net-next v2 01/10] bnxt_en: Use RSS flags defined in the bnxt_hsi.h file.

2016-09-20 Thread Michael Chan
And remove redundant definitions of the same flags. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 drivers/net/ethernet/broadcom/bnxt/bnxt.h | 5 - 2 files changed, 4 insertions(+), 9 deletions(-) diff --git

[PATCH net-next v2 02/10] bnxt_en: Simplify PCI device names and add additinal PCI IDs.

2016-09-20 Thread Michael Chan
Remove "Single-port/Dual-port" from the device names. Dual-port devices will appear as 2 separate devices, so no need to call each a dual-port device. Use a more generic name for VF devices belonging to the same chip fanmily. Add some remaining NPAR device IDs. Signed-off-by: David Christensen

Re: [net-next PATCH] net: netlink messages for HW addr programming

2016-09-20 Thread Roopa Prabhu
On 9/19/16, 10:49 PM, Jiri Pirko wrote: > Tue, Sep 20, 2016 at 07:31:27AM CEST, ro...@cumulusnetworks.com wrote: >> On 9/19/16, 7:46 AM, Patrick Ruddy wrote: >>> On Sun, 2016-09-18 at 07:51 -0700, Roopa Prabhu wrote: On 9/15/16, 9:48 AM, Patrick Ruddy wrote: > Add RTM_NEWADDR and

[PATCH net-next 1/7] net/faraday: Separate rx page storage from rxdesc

2016-09-20 Thread Joel Stanley
From: Andrew Jeffery The ftgmac100 hardware revision in e.g. the Aspeed AST2500 no longer reserves all bits in RXDES#2 but instead uses the bottom 16 bits to store MAC frame metadata. Avoid corruption by shifting struct page pointers out to their own member in struct ftgmac100.

[PATCH net-next 2/7] net/faraday: Make EDO{R,T}R bits configurable

2016-09-20 Thread Joel Stanley
From: Andrew Jeffery These bits are #defined at a fixed location. In order to support future hardware that has chosen to move these bits around move the bits into a member of the struct ftgmac100. Signed-off-by: Andrew Jeffery Signed-off-by: Joel Stanley

[PATCH net-next 0/7] ftgmac100 support for ast2500

2016-09-20 Thread Joel Stanley
Hello Dave, This series adds support to the ftgmac100 driver for the Aspeed ast2400 and ast2500 SoCs. In particular, they ensure the driver works correctly on the ast2500 where the MAC block has seen some changes in register layout. They have been tested on ast2400 and ast2500 systems with the

[PATCH net-next 3/7] net/faraday: Adapt for Aspeed SoCs

2016-09-20 Thread Joel Stanley
The RXDES and TXDES registers bits in the ftgmac100 indicates EDO{R,T}R at bit position 15 for the Faraday Tech IP. However, the version of this IP present in the Aspeed SoCs has these bits at position 30 in the registers. It appers that ast2400 SoCs support both positions, with the 15th bit

[PATCH net-next 5/7] net/faraday: Clear stale interrupts

2016-09-20 Thread Joel Stanley
From: Gavin Shan There is stale interrupt (PHYSTS_CHG in ISR, bit#6 in 0x0) from the bootloader (uboot) when enabling the MAC. The stale interrupts aren't part of kernel and should be cleared. This clears the stale interrupts in ISR (0x0) when enabling the MAC.

[PATCH net-next 4/7] net/faraday: Avoid PHYSTS_CHG interrupt

2016-09-20 Thread Joel Stanley
From: Gavin Shan Bit#11 in MACCR (0x50) designates the signal level for PHY link status change. It's cleared, meaning high level enabled, by default. However, we can see continuous interrupt (bit#6) in ISR (0x0) for it and it's obviously a false alarm. The side effect

[PATCH net-next 7/7] net/faraday: Configure old MDIO interface on Aspeed SoCs

2016-09-20 Thread Joel Stanley
The Aspeed SoCs have a new MDIO interface as an option in the G4 and G5 SoCs. The old one is still available, so select it in order to remain compatible with the ftgmac100 driver. Signed-off-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgmac100.c | 9 +

[PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs

2016-09-20 Thread Joel Stanley
On Aspeed SoC with a direct PHY connection (non-NSCI), we receive continual PHYSTS interrupts: [ 20.28] ftgmac100 1e66.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG [ 20.28] ftgmac100 1e66.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG [ 20.28] ftgmac100 1e66.ethernet eth0:

[PATCHv2 net] cxgb4/cxgb4vf: Allocate more queues for 25G and 100G adapter

2016-09-20 Thread Hariprasad Shenai
We were missing check for 25G and 100G while checking port speed, which lead to less number of queues getting allocated for 25G & 100G adapters and leading to low throughput. Adding the missing check for both NIC and vNIC driver. Also fixes port advertisement for 25G and 100G in ethtool output.

Re: [PATCH net] cxgb4/cxgb4vf: Allocate more queues for 100G adapter

2016-09-20 Thread Hariprasad Shenai
On Mon, Sep 19, 2016 at 01:32:46PM +0530, Hariprasad Shenai wrote: > We were missing check for 100G while checking port speed, which lead to > less number of queues getting allocated for 100G and leading to low > throughput. Adding the missing check for both NIC and vNIC driver. > >

Re: [patch net-next RFC 0/2] fib4 offload: notifier to let hw to be aware of all prefixes

2016-09-20 Thread Roopa Prabhu
On Mon, Sep 19, 2016 at 11:02 PM, Jiri Pirko wrote: > Tue, Sep 20, 2016 at 07:49:47AM CEST, ro...@cumulusnetworks.com wrote: [snip] >> >>Do you see any scale problems with using notifiers ?. as you know these ascis >>can scale to >>32k-128k routes. > > I don't see any problem

Re: [patch net-next RFC 0/2] fib4 offload: notifier to let hw to be aware of all prefixes

2016-09-20 Thread Jiri Pirko
Tue, Sep 20, 2016 at 07:49:47AM CEST, ro...@cumulusnetworks.com wrote: >On 9/19/16, 8:15 AM, Jiri Pirko wrote: >> Mon, Sep 19, 2016 at 04:59:22PM CEST, ro...@cumulusnetworks.com wrote: >>> On 9/18/16, 11:14 PM, Jiri Pirko wrote: Mon, Sep 19, 2016 at 01:16:17AM CEST, ro...@cumulusnetworks.com

[PATCH v3] iproute2: build nsid-name cache only for commands that need it

2016-09-20 Thread Anton Aksola
The calling of netns_map_init() before command parsing introduced a performance issue with large number of namespaces. As commands such as add, del and exec do not need to iterate through /var/run/netns it would be good not no build the cache before executing these commands. Example: unpatched:

<    1   2   3   4