Re: [PATCH net-next v2] net: inet: Support UID-based routing

2016-11-04 Thread David Miller
From: Lorenzo Colitti Date: Fri, 4 Nov 2016 02:23:40 +0900 > This patchset adds support for per-UID routing. Looks great, thanks for all of the hard work. Series applied. Please submit the necessary iproute2 patches, as needed. Thanks again.

Re: [PATCH net-next v1 00/10] amd-xgbe: AMD XGBE driver updates 2016-11-03

2016-11-04 Thread David Miller
From: Tom Lendacky Date: Thu, 3 Nov 2016 13:17:28 -0500 > This patch series is targeted at preparing the driver for a new PCI version > of the hardware. After this series is applied, a follow-on series will > introduce the support for the PCI version of the hardware. >

[PATCH net] sock: fix sendmmsg for partial sendmsg

2016-11-04 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh Do not send the next message in sendmmsg for partial sendmsg invocations. sendmmsg assumes that it can continue sending the next message when the return value of the individual sendmsg invocations is positive. It results in corrupting the data for

Re: [PATCH net-next resend 00/13] ring reconfiguration and XDP support

2016-11-04 Thread David Miller
From: Jakub Kicinski Date: Thu, 3 Nov 2016 17:11:56 + > This set adds support for ethtool channel API and XDP. Series applied, thank you!

Re: [PATCH net] fib_trie: correct /proc/net/route for large read buffer

2016-11-04 Thread Alexander Duyck
On Fri, Nov 4, 2016 at 12:07 PM, Jason Baron wrote: > > > On 11/04/2016 02:43 PM, Alexander Duyck wrote: >> >> On Fri, Nov 4, 2016 at 7:45 AM, Jason Baron wrote: >>> >>> From: Jason Baron >>> >>> When read() is called on /proc/net/route

Re: [PATCH net-next] sock: do not set sk_err in sock_dequeue_err_skb

2016-11-04 Thread Willem de Bruijn
On Thu, Nov 3, 2016 at 7:10 PM, Hannes Frederic Sowa wrote: > [also cc'ed Andy, albeit this doesn't seem to solve his initial problem, > right? ] Indeed, this does not help disambiguate the source of an error

Re: Coding Style: Reverse XMAS tree declarations ?

2016-11-04 Thread Lino Sanfilippo
On 04.11.2016 18:44, Joe Perches wrote: > On Fri, 2016-11-04 at 11:07 -0400, David Miller wrote: >> From: Lino Sanfilippo >> > On 04.11.2016 07:53, Joe Perches wrote: >> >> CHECK:REVERSE_XMAS_TREE: Prefer ordering declarations longest to >> >> shortest >> >> #446: FILE:

Re: [PATCH net] r8152: Fix broken RX checksums.

2016-11-04 Thread Mark Lord
On 16-11-04 09:50 AM, Mark Lord wrote: > Yeah, the device or driver is definitely getting confused with rx_desc > structures. > I added code to check for unlikely rx_desc values, and it found this for > starters: > > rx_desc: 00480801 00480401 00480001 0048fc00 0048f800 0048f400 pkt_len=2045 >

Re: [PATCH net] ipv4: update comment to document GSO fragmentation cases.

2016-11-04 Thread Shmulik Ladkani
Hi, On Fri, 4 Nov 2016 12:22:38 -0400 Lance Richardson wrote: > This is a follow-up to commit eb96202f1e34 ("ipv4: allow local > fragmentation in ip_finish_output_gso()"), updating the comment > documenting cases in which fragmentation is needed for egress > GSO packets. >

[PATCH net-next 2/2] tcp: no longer hold ehash lock while calling tcp_get_info()

2016-11-04 Thread Eric Dumazet
We had various problems in the past in tcp_get_info() and used specific synchronization to avoid deadlocks. We would like to add more instrumentation points for TCP, and avoiding grabing socket lock in tcp_getinfo() was too costly. Being able to lock the socket allows to provide consistent set

[PATCH net-next 0/2] tcp: tcp_get_info() locking changes

2016-11-04 Thread Eric Dumazet
This short series prepares tcp_get_info() for more detailed infos. In order to not slow down fast path, our goal is to use the normal socket spinlock instead of custom synchronization. All we need to ensure is that tcp_get_info() is not called with ehash lock, which might dead lock, since packet

[PATCH net-next 1/2] tcp: shortcut listeners in tcp_get_info()

2016-11-04 Thread Eric Dumazet
Being lockless in tcp_get_info() is hard, because we need to add specific synchronization in TCP fast path, like seqcount. Following patch will change inet_diag_dump_icsk() to no longer hold any lock for non listeners, so that we can properly acquire socket lock in get_tcp_info() and let it

Re: [PATCH net 0/6] Mellanox 100G mlx5 fixes 2016-11-04

2016-11-04 Thread David Miller
From: Saeed Mahameed Date: Fri, 4 Nov 2016 01:48:41 +0200 > This series contains six hot fixes of the mlx5 core and mlx5e driver. > > Huy fixed an invalid pointer dereference on initialization flow for when > the selected mlx5 load profile is out of range. > > Or provided

Re: [PATCH net] fib_trie: correct /proc/net/route for large read buffer

2016-11-04 Thread Jason Baron
On 11/04/2016 02:43 PM, Alexander Duyck wrote: On Fri, Nov 4, 2016 at 7:45 AM, Jason Baron wrote: From: Jason Baron When read() is called on /proc/net/route requesting a size that is one entry size (128 bytes) less than m->size or greater, the

Re: [PATCH net-next v2 00/11] net: dsa: mv88e6xxx: refine port operations

2016-11-04 Thread David Miller
From: Vivien Didelot Date: Fri, 4 Nov 2016 03:23:25 +0100 > The Marvell chips have one internal SMI device per port, containing a > set of registers used to configure a port's link, STP state, default > VLAN or addresses database, etc. > > This patchset

Re: [PATCH net] fib_trie: correct /proc/net/route for large read buffer

2016-11-04 Thread Alexander Duyck
On Fri, Nov 4, 2016 at 7:45 AM, Jason Baron wrote: > From: Jason Baron > > When read() is called on /proc/net/route requesting a size that is one > entry size (128 bytes) less than m->size or greater, the resulting output > has missing and/or duplicate

Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet)

2016-11-04 Thread David VomLehn
On Fri, Nov 04, 2016 at 10:05:15AM -0700, Randy Dunlap wrote: > On 11/03/16 23:53, Joe Perches wrote: > > On Thu, 2016-11-03 at 15:58 -0400, David Miller wrote: > >> From: Madalin Bucur > >> Date: Wed, 2 Nov 2016 22:17:26 +0200 > >> > >>> This introduces the Freescale Data

[PATCH net-next 7/7] vxlan: remove unsed vxlan_dev_dst_port()

2016-11-04 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar --- include/net/vxlan.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/include/net/vxlan.h b/include/net/vxlan.h index 308adc4..49a5920 100644 --- a/include/net/vxlan.h +++ b/include/net/vxlan.h @@ -281,16 +281,6 @@ struct vxlan_dev

[PATCH net-next 6/7] vxlan: simplify vxlan xmit

2016-11-04 Thread Pravin B Shelar
Existing vxlan xmit function handles two distinct cases. 1. vxlan net device 2. vxlan lwt device. By seperating initilization these two cases the egress path looks better. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 79

[PATCH net-next 4/7] vxlan: improve vxlan route lookup checks.

2016-11-04 Thread Pravin B Shelar
Move route sanity check to respective vxlan[4/6]_get_route functions. This allows us to perform all sanity checks before caching the dst so that we can avoid these checks on subsequent packets. This give move accurate metadata information for packet from fill_metadata_dst(). Signed-off-by: Pravin

[PATCH net-next 2/7] vxlan: simplify exception handling

2016-11-04 Thread Pravin B Shelar
vxlan egress path error handling has became complicated, it need to handle IPv4 and IPv6 tunnel cases. Earlier patch removes vlan handling from vxlan_build_skb(), so vxlan_build_skb does not need to free skb and we can simplify the xmit path by having single error handling for both type of

[PATCH net-next 5/7] vxlan: simplify RTF_LOCAL handling.

2016-11-04 Thread Pravin B Shelar
Avoid code duplicate code for handling RTF_LOCAL routes. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 78 + 1 file changed, 43 insertions(+), 35 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c

[PATCH net-next 0/7] vxlan: General improvements.

2016-11-04 Thread Pravin B Shelar
Following patch series improves vxlan fast path, removes duplicate code and simplifies vxlan xmit code path. Pravin B Shelar (7): vxlan: avoid vlan processing in vxlan device. vxlan: simplify exception handling vxlan: avoid checking socket multiple times. vxlan: improve vxlan route lookup

[PATCH net-next 3/7] vxlan: avoid checking socket multiple times.

2016-11-04 Thread Pravin B Shelar
Check the vxlan socket in vxlan6_getroute(). Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index a1e707f..6435d6a 100644 --- a/drivers/net/vxlan.c +++

[PATCH net-next 1/7] vxlan: avoid vlan processing in vxlan device.

2016-11-04 Thread Pravin B Shelar
VxLan device does not have special handling for vlan taging on egress. Therefore it does not make sense to expose vlan offloading feature. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 9 + include/linux/if_vlan.h | 16 2 files changed,

[PATCH net-next 3/5] net: l2tp: netlink: l2tp_nl_tunnel_send: set UDP6 checksum flags

2016-11-04 Thread Asbjoern Sloth Toennesen
This patch causes the proper attribute flags to be set, in the case that IPv6 UDP checksums are disabled, so that userspace ie. `ip l2tp show tunnel` knows about it. Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_netlink.c | 10 ++ 1 file changed, 10

[PATCH net-next 2/5] net: l2tp: fix L2TP_ATTR_UDP_ZERO_CSUM6_{RX,TX} attribute types

2016-11-04 Thread Asbjoern Sloth Toennesen
The attributes L2TP_ATTR_UDP_ZERO_CSUM6_RX and L2TP_ATTR_UDP_ZERO_CSUM6_TX are used as flags, but is defined as a u8 in a comment. This patch redocuments them as flags, and adds them to the nla_policy, so they gets validated. The only publicly user, iproute2, already treat these attributes as

[PATCH iproute2 1/7] man: ip-l2tp.8: fix l2spec_type documentation

2016-11-04 Thread Asbjørn Sloth Tønnesen
Signed-off-by: Asbjørn Sloth Tønnesen --- man/man8/ip-l2tp.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/ip-l2tp.8 b/man/man8/ip-l2tp.8 index 5b7041f..4a3bb20 100644 --- a/man/man8/ip-l2tp.8 +++ b/man/man8/ip-l2tp.8 @@ -239,7 +239,7 @@ find in

[PATCH iproute2 5/7] l2tp: support sequence numbering

2016-11-04 Thread Asbjørn Sloth Tønnesen
Signed-off-by: Asbjørn Sloth Tønnesen --- ip/ipl2tp.c| 23 +++ man/man8/ip-l2tp.8 | 15 +++ 2 files changed, 38 insertions(+) diff --git a/ip/ipl2tp.c b/ip/ipl2tp.c index af89e2f..6d00d09 100644 --- a/ip/ipl2tp.c +++ b/ip/ipl2tp.c @@

[PATCH iproute2 6/7] l2tp: read IPv6 UDP checksum attributes from kernel

2016-11-04 Thread Asbjørn Sloth Tønnesen
In case of an older kernel that doesn't set L2TP_ATTR_UDP_ZERO_CSUM6_{R,T}X the old hard-coded value is being preserved, since the attribute flag will be missing. Signed-off-by: Asbjørn Sloth Tønnesen --- ip/ipl2tp.c | 9 +++-- 1 file changed, 3 insertions(+), 6

[PATCH iproute2 3/7] l2tp: fix integers with too few significant bits

2016-11-04 Thread Asbjørn Sloth Tønnesen
udp6_csum{,_tx,_rx}, tunnel and session are the only ones currently used. recv_seq, send_seq, lns_mode and data_seq are partially implemented in a useless way. Signed-off-by: Asbjørn Sloth Tønnesen --- ip/ipl2tp.c | 18 +- 1 file changed, 9 insertions(+), 9

[PATCH iproute2 4/7] l2tp: fix L2TP_ATTR_{RECV,SEND}_SEQ handling

2016-11-04 Thread Asbjørn Sloth Tønnesen
L2TP_ATTR_RECV_SEQ and L2TP_ATTR_SEND_SEQ are declared as NLA_U8 attributes in the kernel, so let's threat them accordingly. Signed-off-by: Asbjørn Sloth Tønnesen --- ip/ipl2tp.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ip/ipl2tp.c

[PATCH] net-ipv6: on device mtu change do not add mtu to mtu-less routes

2016-11-04 Thread Maciej Żenczykowski
From: Maciej Żenczykowski Routes can specify an mtu explicitly or inherit the mtu from the underlying device - this inheritance is implemented in dst->ops->mtu handlers ip6_mtu() and ip6_blackhole_mtu(). Currently changing the mtu of a device adds mtu explicitly to routes using

[PATCH net-next 4/5] net: l2tp: cleanup: remove redundant condition

2016-11-04 Thread Asbjoern Sloth Toennesen
These assignments follow this pattern: unsigned int foo:1; struct nlattr *nla = info->attrs[bar]; if (nla) foo = nla_get_flag(nla); /* expands to: foo = !!nla */ This could be simplified to: if (nla) foo = 1; but lets just remove the condition and use the

[PATCH net-next 5/5] net: l2tp: fix negative assignment to unsigned int

2016-11-04 Thread Asbjoern Sloth Toennesen
recv_seq, send_seq and lns_mode mode are all defined as unsigned int foo:1; Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_core.c | 2 +- net/l2tp/l2tp_ppp.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/l2tp/l2tp_core.c

[PATCH net-next 1/5] net: l2tp: fix L2TP_ATTR_UDP_CSUM attribute type

2016-11-04 Thread Asbjoern Sloth Toennesen
L2TP_ATTR_UDP_CSUM is a flag, and gets read with nla_get_flag, but it is defined as NLA_U8 in the nla_policy. It appears that this is only publicly used in iproute2, where it's broken, because it's used as a NLA_FLAG, and fails validation as a NLA_U8. The only place it's used as a NLA_U8 is in

Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-11-04 Thread John Fastabend
On 16-11-03 05:34 PM, Michael S. Tsirkin wrote: > On Thu, Nov 03, 2016 at 04:29:22PM -0700, John Fastabend wrote: >> [...] >> > - when XDP is attached disable all LRO using > VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET > (not used by driver so far, designed to allow dynamic LRO control with

[PATCH iproute2 2/7] man: ip-l2tp.8: remove non-existent tunnel parameter name

2016-11-04 Thread Asbjørn Sloth Tønnesen
The name parameter is only valid for sessions, not tunnels. Signed-off-by: Asbjørn Sloth Tønnesen --- man/man8/ip-l2tp.8 | 3 --- 1 file changed, 3 deletions(-) diff --git a/man/man8/ip-l2tp.8 b/man/man8/ip-l2tp.8 index 4a3bb20..991d097 100644 --- a/man/man8/ip-l2tp.8 +++

[PATCH iproute2 7/7] l2tp: show tunnel: expose UDP checksum state

2016-11-04 Thread Asbjørn Sloth Tønnesen
Signed-off-by: Asbjørn Sloth Tønnesen --- ip/ipl2tp.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/ip/ipl2tp.c b/ip/ipl2tp.c index 8f3268d..27dc184 100644 --- a/ip/ipl2tp.c +++ b/ip/ipl2tp.c @@ -218,9 +218,24 @@ static void

Re: [PATCH net-next 5/7] vxlan: simplify RTF_LOCAL handling.

2016-11-04 Thread kbuild test robot
Hi Pravin, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Pravin-B-Shelar/vxlan-General-improvements/20161105-060958 config: i386-randconfig-x077-201644 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save

[net PATCH] fib_trie: Correct /proc/net/route off by one error

2016-11-04 Thread Alexander Duyck
The display of /proc/net/route has had a couple issues due to the fact that when I originally rewrote most of fib_trie I made it so that the iterator was tracking the next value to use instead of the current. In addition it had an off by 1 error where I was tracking the first piece of data as

Re: [PATCH net] sock: fix sendmmsg for partial sendmsg

2016-11-04 Thread Maciej Żenczykowski
Acked-by: Maciej Żenczykowski

Re: [PATCH v6 5/7] net: ethernet: bgmac: device tree phy enablement

2016-11-04 Thread Rafał Miłecki
On 2016-11-04 06:11, Jon Mason wrote: Change the bgmac driver to allow for phy's defined by the device tree Signed-off-by: Jon Mason [Resending from Roundcube due to "Wrong MIME labeling on 8-bit character texts." vger.kernel.org reject when using Thunderbird]

Re: [PATCH net-next v2 07/11] net: dsa: mv88e6xxx: add port link setter

2016-11-04 Thread Andrew Lunn
On Fri, Nov 04, 2016 at 03:23:32AM +0100, Vivien Didelot wrote: > Most of the chips will have a port register control bits to force the > port's link up, down, or let normal link detection occurs. > > Implement such operation to use it later when setting duplex, etc. > > Signed-off-by: Vivien

Re: [PATCH net v3] ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-04 Thread Shmulik Ladkani
On Thu, 3 Nov 2016 22:34:34 +0100 Hannes Frederic Sowa wrote: > Correct, but we should maybe redefine the code a bit. From my > understanding we can now create an ICMP storm in case every fragment gets. Yes, you are right. Each segment gets into ip_fragment, and due

Re: [net-next PATCH 3/3] qdisc: catch misconfig of attaching qdisc to tx_queue_len zero device

2016-11-04 Thread Jesper Dangaard Brouer
On Fri, 4 Nov 2016 10:35:26 +0100 Phil Sutter wrote: > Hi, > > On Thu, Nov 03, 2016 at 02:56:11PM +0100, Jesper Dangaard Brouer wrote: > [...] > > diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c > > index 206dc24add3a..f337f1bdd1d4 100644 > > --- a/net/sched/sch_api.c > >

Re: [PATCH net v3] ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-04 Thread Shmulik Ladkani
Hi, On Thu, 3 Nov 2016 09:06:27 -0400 (EDT) Lance Richardson wrote: > I'm not sure what could be added that would help, was there something > specific you had in mind? How about something like this (preliminary, feel free to massage): @@ -248,10 +248,16 @@ static int

[PATCH net-next v4 1/9] ipv6: implement dataplane support for rthdr type 4 (Segment Routing Header)

2016-11-04 Thread David Lebrun
Implement minimal support for processing of SR-enabled packets as described in https://tools.ietf.org/html/draft-ietf-6man-segment-routing-header-02. This patch implements the following operations: - Intermediate segment endpoint: incrementation of active segment and rerouting. - Egress for

[PATCH net-next v4 0/9] net: add support for IPv6 Segment Routing

2016-11-04 Thread David Lebrun
v4: - Change @cleanup in ipv6_srh_rcv() from int to bool - Move checksum helper functions into header file - Add common definition for SR TLVs - Add comments for HMAC computation algorithm - Use rhashtable to store HMAC infos instead of linked list - Remove packed attribute for struct

[PATCH net-next v4 2/9] ipv6: sr: add code base for control plane support of SR-IPv6

2016-11-04 Thread David Lebrun
This patch adds the necessary hooks and structures to provide support for SR-IPv6 control plane, essentially the Generic Netlink commands that will be used for userspace control over the Segment Routing kernel structures. The genetlink commands provide control over two different structures:

[PATCH net-next v4 3/9] ipv6: sr: add support for SRH encapsulation and injection with lwtunnels

2016-11-04 Thread David Lebrun
This patch creates a new type of interfaceless lightweight tunnel (SEG6), enabling the encapsulation and injection of SRH within locally emitted packets and forwarded packets. >From a configuration viewpoint, a seg6 tunnel would be configured as follows: ip -6 ro ad fc00::1/128 encap seg6 mode

[PATCH net-next v2 1/2] net/sock: add an explicit sk argument for ip_cmsg_recv_offset()

2016-11-04 Thread Paolo Abeni
So that we can use it even after orphaining the skbuff. Suggested-by: Eric Dumazet Signed-off-by: Paolo Abeni --- @Eric, please add your signed off by when you feel comfortable with the patch as you basically authored it include/net/ip.h | 5

[PATCH net-next 0/2] udp: do fwd memory scheduling on dequeue

2016-11-04 Thread Paolo Abeni
After commit 850cbaddb52d ("udp: use it's own memory accounting schema"), the udp code needs to acquire twice the receive queue spinlock on dequeue. This patch series remove the need for the second lock at skb free time, moving the udp memory scheduling inside the dequeue operation; the skb

Re: [PATCH v6 6/7] net: ethernet: bgmac: add NS2 support

2016-11-04 Thread Rafał Miłecki
On 2016-11-04 06:11, Jon Mason wrote: Add support for the variant of amac hardware present in the Broadcom Northstar2 based SoCs. Northstar2 requires an additional register to be configured with the port speed/duplexity (NICPM). This can be added to the link callback to hide it from the

Re: [PATCH net-next v2 00/11] net: dsa: mv88e6xxx: refine port operations

2016-11-04 Thread Andrew Lunn
On Fri, Nov 04, 2016 at 03:23:25AM +0100, Vivien Didelot wrote: > The Marvell chips have one internal SMI device per port, containing a > set of registers used to configure a port's link, STP state, default > VLAN or addresses database, etc. Reviewed-by: Andrew Lunn Andrew

[PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-04 Thread Kai-Heng Feng
Sometimes cdc_mbim failed to probe if runtime pm is enabled: [9.305626] cdc_mbim: probe of 2-2:1.12 failed with error -22 This can be solved by increase its pm usage counter. Signed-off-by: Kai-Heng Feng --- drivers/net/usb/usbnet.c | 7 ++- 1 file changed,

[PATCH ethtool 1/2] ethtool-copy.h:sync with net

2016-11-04 Thread Allan W. Nielsen
This covers kernel changes upto: commit 67168af82f30bacbd734a4472670cba6b3d6fd36 Author: Raju Lakkaraju Date: Wed Nov 2 11:35:12 2016 +0530 ethtool: (uapi) Add ETHTOOL_PHY_DOWNSHIFT to PHY tunables For operation in cabling environments that are

[PATCH ethtool 0/2] Adding downshift support to ethtool

2016-11-04 Thread Allan W. Nielsen
Hi All, This patch implements for set/get downshifting. Downshifting can either be turned on/off, or it can be configured to a specifc count. If no "count" are provided, then it is up to the individual PHY driver to configure a default count. Best regards Allan and Raju Allan W. Nielsen (1):

[PATCH ethtool 2/2] Ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift

2016-11-04 Thread Allan W. Nielsen
From: Raju Lakkaraju Add ethtool get and set tunable to access PHY drivers. Ethtool Help: ethtool -h for PHY tunables ethtool --set-phy-tunable DEVNAME Set PHY tunable [ downshift on|off|%d ] ethtool --get-phy-tunable DEVNAME Get

Re: [PATCH net] sctp: assign assoc_id earlier in __sctp_connect

2016-11-04 Thread Xin Long
On Fri, Nov 4, 2016 at 3:03 AM, Marcelo Ricardo Leitner wrote: > sctp_wait_for_connect() currently already holds the asoc to keep it > alive during the sleep, in case another thread release it. But Andrey > Konovalov and Dmitry Vyukov reported an use-after-free in such

Re: [PATCH net v3] ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-04 Thread Shmulik Ladkani
Hi, On Thu, 3 Nov 2016 17:05:54 -0400 (EDT) Lance Richardson wrote: > > I'm still digesting the patchwork history, but it seems to me: > >1) If we call skb_gso_validate_mtu() and it returns true, > ip_finish_output2() will > be called, just as before, so

Re: [net-next PATCH 3/3] qdisc: catch misconfig of attaching qdisc to tx_queue_len zero device

2016-11-04 Thread Phil Sutter
Hi, On Thu, Nov 03, 2016 at 02:56:11PM +0100, Jesper Dangaard Brouer wrote: [...] > diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c > index 206dc24add3a..f337f1bdd1d4 100644 > --- a/net/sched/sch_api.c > +++ b/net/sched/sch_api.c > @@ -960,6 +960,17 @@ static struct Qdisc

[PATCH net-next v2 2/2] udp: do fwd memory scheduling on dequeue

2016-11-04 Thread Paolo Abeni
A new argument is added to __skb_recv_datagram to provide an explicit skb destructor, invoked under the receive queue lock. The UDP protocol uses such argument to perform memory reclaiming on dequeue, so that the UDP protocol does not set anymore skb->desctructor. Instead explicit memory

[PATCH net-next v4 8/9] ipv6: sr: add support for SRH injection through setsockopt

2016-11-04 Thread David Lebrun
This patch adds support for per-socket SRH injection with the setsockopt system call through the IPPROTO_IPV6, IPV6_RTHDR options. The SRH is pushed through the ipv6_push_nfrag_opts function. Signed-off-by: David Lebrun --- net/ipv6/exthdrs.c | 79

[PATCH net-next v4 6/9] ipv6: sr: add calls to verify and insert HMAC signatures

2016-11-04 Thread David Lebrun
This patch enables the verification of the HMAC signature for transiting SR-enabled packets, and its insertion on encapsulated/injected SRH. Signed-off-by: David Lebrun --- net/ipv6/exthdrs.c | 10 ++ net/ipv6/seg6_iptunnel.c | 21 +

[PATCH net-next v4 5/9] ipv6: sr: implement API to control SR HMAC structure

2016-11-04 Thread David Lebrun
This patch provides an implementation of the genetlink commands to associate a given HMAC key identifier with an hashing algorithm and a secret. Signed-off-by: David Lebrun --- net/ipv6/seg6.c | 229 1 file

[PATCH net-next v4 9/9] ipv6: sr: add documentation file for per-interface sysctls

2016-11-04 Thread David Lebrun
This patch adds documentation for some SR-related per-interface sysctls. Signed-off-by: David Lebrun --- Documentation/networking/seg6-sysctl.txt | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/networking/seg6-sysctl.txt

[PATCH net-next v4 7/9] ipv6: add source address argument for ipv6_push_nfrag_opts

2016-11-04 Thread David Lebrun
This patch prepares for insertion of SRH through setsockopt(). The new source address argument is used when an HMAC field is present in the SRH, which must be filled. The HMAC signature process requires the source address as input text. Signed-off-by: David Lebrun ---

[PATCH net-next 0/5] Adding PHY-Tunables and downshift support

2016-11-04 Thread Allan W. Nielsen
Hi All, This series add support for PHY tunables, and uses this facility to configure downshifting. The downshifting mechanism is implemented for MSCC phys. This series tries to address the comments provided back in mid October when this feature was posted along with fast-link-failure.

[PATCH net-next 2/5] ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE

2016-11-04 Thread Allan W. Nielsen
From: Raju Lakkaraju Adding get_tunable/set_tunable function pointer to the phy_driver structure, and uses these function pointers to implement the ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE ioctls. Signed-off-by: Raju Lakkaraju

[PATCH net-next 3/5] ethtool: (uapi) Add ETHTOOL_PHY_DOWNSHIFT to PHY tunables

2016-11-04 Thread Allan W. Nielsen
From: Raju Lakkaraju For operation in cabling environments that are incompatible with 1000BAST-T, PHY device may provide an automatic link speed downshift operation. When enabled, the device automatically changes its 1000BAST-T auto-negotiation to the next slower

[PATCH net-next 1/5] ethtool: (uapi) Add ETHTOOL_PHY_GTUNABLE and ETHTOOL_PHY_STUNABLE

2016-11-04 Thread Allan W. Nielsen
From: Raju Lakkaraju Defines a generic API to get/set phy tunables. The API is using the existing ethtool_tunable/tunable_type_id types which is already being used for mac level tunables. Signed-off-by: Raju Lakkaraju Signed-off-by:

[PATCH] virtio-net: drop legacy features in virtio 1 mode

2016-11-04 Thread Michael S. Tsirkin
Virtio 1.0 spec says VIRTIO_F_ANY_LAYOUT and VIRTIO_NET_F_GSO are legacy-only feature bits. Do not negotiate them in virtio 1 mode. Note this is a spec violation so we need to backport it to stable/downstream kernels. Cc: sta...@vger.kernel.org Signed-off-by: Michael S. Tsirkin

Re: [RFC PATCH v2 0/5] ARM64: Add Internal PHY support for Meson GXL

2016-11-04 Thread Neil Armstrong
On 10/31/2016 05:56 PM, Neil Armstrong wrote: > The Amlogic Meson GXL SoCs have an internal RMII PHY that is muxed with the > external RGMII pins. > > In order to support switching between the two PHYs links, extended registers > size for mdio-mux-mmioreg must be added. > > Finally, the internal

Re: [PATCH net] tipc: Guard against tiny MTU in tipc_msg_build()

2016-11-04 Thread 张谦
Hi, I think both tipc_l2_device_event() and tipc_enable_l2_media() need to refuse a tiny MTU for TIPC bearers. tipc_l2_device_event() used to update the TIPC MTU value when executing a command like 'ifconfig eth0 MTU 1 up'. tipc_enable_l2_media() will be invoked when the TIPC network created.

Need you attention to solve this soft lockup issue in intel network interface card (IGB)

2016-11-04 Thread Sumit Gemini1
Hi All,, msx:~ # ethtool -i eth0 driver: igb version: 3.2.10-k firmware-version: 3.2-9 bus-info: :0b:00.1 supports-statistics: yes supports-test: yes supports-eeprom-access: yes supports-register-dump: yes I have one issue, at customer machine the user space process is hogging up the

Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet)

2016-11-04 Thread Joe Perches
On Thu, 2016-11-03 at 15:58 -0400, David Miller wrote: > From: Madalin Bucur > Date: Wed, 2 Nov 2016 22:17:26 +0200 > > > This introduces the Freescale Data Path Acceleration Architecture > > +static inline size_t bpool_buffer_raw_size(u8 index, u8 cnt) > > +{ > > + u8

Re: [net-next PATCH 2/3] net/qdisc: IFF_NO_QUEUE drivers should use consistent TX queue len

2016-11-04 Thread Jesper Dangaard Brouer
On Thu, 3 Nov 2016 13:54:40 -0700 Krister Johansen wrote: > On Thu, Nov 03, 2016 at 02:56:06PM +0100, Jesper Dangaard Brouer wrote: > > The flag IFF_NO_QUEUE marks virtual device drivers that doesn't need a > > default qdisc attached, given they will be backed by

Re: [net-next PATCH 3/3] qdisc: catch misconfig of attaching qdisc to tx_queue_len zero device

2016-11-04 Thread Phil Sutter
On Fri, Nov 04, 2016 at 11:10:42AM +0100, Jesper Dangaard Brouer wrote: > > On Fri, 4 Nov 2016 10:35:26 +0100 Phil Sutter wrote: > > > Hi, > > > > On Thu, Nov 03, 2016 at 02:56:11PM +0100, Jesper Dangaard Brouer wrote: > > [...] > > > diff --git a/net/sched/sch_api.c

Re: [Patch net] ipvs: use IPVS_CMD_ATTR_MAX for family.maxattr

2016-11-04 Thread Simon Horman
On Thu, Nov 03, 2016 at 05:14:03PM -0700, Cong Wang wrote: > family.maxattr is the max index for policy[], the size of > ops[] is determined with ARRAY_SIZE(). > > Reported-by: Andrey Konovalov > Tested-by: Andrey Konovalov > Cc: Pablo Neira Ayuso

Re: [PATCH net] sctp: assign assoc_id earlier in __sctp_connect

2016-11-04 Thread Marcelo Ricardo Leitner
Em 04-11-2016 08:55, David Laight escreveu: From: Of Marcelo Ricardo Leitner Sent: 03 November 2016 19:04 sctp_wait_for_connect() currently already holds the asoc to keep it alive during the sleep, in case another thread release it. But Andrey Konovalov and Dmitry Vyukov reported an

Re: [PATCH ethtool 2/2] Ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift

2016-11-04 Thread Andrew Lunn
Hi Allen > +++ b/ethtool.8.in > @@ -340,6 +340,14 @@ ethtool \- query or control network driver and hardware > settings > .B2 tx-lpi on off > .BN tx-timer > .BN advertise > +.HP > +.B ethtool \-\-set\-phy\-tunable > +.I devname > +.B3 downshift on off N > +.HP I don't think there is any

Re: [PATCH net] sctp: assign assoc_id earlier in __sctp_connect

2016-11-04 Thread Neil Horman
On Thu, Nov 03, 2016 at 05:03:41PM -0200, Marcelo Ricardo Leitner wrote: > sctp_wait_for_connect() currently already holds the asoc to keep it > alive during the sleep, in case another thread release it. But Andrey > Konovalov and Dmitry Vyukov reported an use-after-free in such > situation. > >

Re: [PATCH ethtool 2/2] Ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift

2016-11-04 Thread Allan W. Nielsen
On 04/11/16 12:59, Andrew Lunn wrote: > > +++ b/ethtool.8.in > > @@ -340,6 +340,14 @@ ethtool \- query or control network driver and > > hardware settings > > .B2 tx-lpi on off > > .BN tx-timer > > .BN advertise > > +.HP > > +.B ethtool \-\-set\-phy\-tunable > > +.I devname > > +.B3 downshift

Re: [PATCH (net.git) 0/3] stmmac: fix PTP support

2016-11-04 Thread Giuseppe CAVALLARO
Hi David, the series have some Acked-by, do you prefer a new series (I can rebase them if you ask me) or you can keep this one? Or you have some advice or issue to warn? Regards, peppe On 10/26/2016 8:56 AM, Giuseppe Cavallaro wrote: This subset of patches aim to fix the PTP support for the

Re: [PATCH net v3] ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-04 Thread Lance Richardson
> From: "Shmulik Ladkani" > To: "Lance Richardson" > Cc: netdev@vger.kernel.org, f...@strlen.de, jtl...@redhat.com, > han...@stressinduktion.org > Sent: Friday, November 4, 2016 5:24:09 AM > Subject: Re: [PATCH net v3] ipv4: allow local

Re: Ethernet not working on a different SoC with same eth HW

2016-11-04 Thread Måns Rullgård
Andrew Lunn writes: >> Considering the ethernet DT bindings: >> >> https://www.kernel.org/doc/Documentation/devicetree/bindings/net/ethernet.txt >> >> Specifically, phy-mode values "rgmii", "rgmii-id", "rgmii-rxid", >> "rgmii-txid". >> >> Assuming that "rxid" (rx internal

Re: Ethernet not working on a different SoC with same eth HW

2016-11-04 Thread Sebastian Frias
On 11/04/2016 02:57 PM, Andrew Lunn wrote: >> Considering the ethernet DT bindings: >> >> https://www.kernel.org/doc/Documentation/devicetree/bindings/net/ethernet.txt >> >> Specifically, phy-mode values "rgmii", "rgmii-id", "rgmii-rxid", >> "rgmii-txid". >> >> Assuming that "rxid" (rx internal

Re: [PATCH net-next 5/5] net: phy: Add downshift get/set support in Microsemi PHYs driver

2016-11-04 Thread Allan W. Nielsen
On 04/11/16 13:27, Andrew Lunn wrote: > > + } else if (count) { > > + /* Downshift count is either 2,3,4 or 5 */ > > + count = (((count - 2) << DOWNSHIFT_CNTL_POS) | DOWNSHIFT_EN); > > Ah, now i see why + 2. But this means it never does what you ask it to > do. It

Re: [PATCH net v3] ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-04 Thread Lance Richardson
> From: "Shmulik Ladkani" > To: "Hannes Frederic Sowa" > Cc: "Lance Richardson" , f...@strlen.de, > netdev@vger.kernel.org, jtl...@redhat.com > Sent: Friday, November 4, 2016 5:40:14 AM > Subject: Re: [PATCH net v3]

Re: [PATCH net-next 5/5] net: phy: Add downshift get/set support in Microsemi PHYs driver

2016-11-04 Thread Andrew Lunn
On Fri, Nov 04, 2016 at 02:42:34PM +0100, Allan W. Nielsen wrote: > On 04/11/16 13:27, Andrew Lunn wrote: > > > + } else if (count) { > > > + /* Downshift count is either 2,3,4 or 5 */ > > > + count = (((count - 2) << DOWNSHIFT_CNTL_POS) | > > > DOWNSHIFT_EN); > > > >

Re: [net-next PATCH 0/7] stmmac: dwmac-sti refactor+cleanup

2016-11-04 Thread Giuseppe CAVALLARO
Hello Joachim. I have tested the patches on STiH390 with GMAC4 and the driver is ok. So you can add my Acked-by/Tested-by in the V2. I just ask you, when rename the sti_dwmac_init in sti_dwmac_set_phy_mode to use another name: sti_dwmac_set_mode could be good, IMO. In fact, this function is

Re: [PATCH net] r8152: Fix broken RX checksums.

2016-11-04 Thread Mark Lord
Yeah, the device or driver is definitely getting confused with rx_desc structures. I added code to check for unlikely rx_desc values, and it found this for starters: rx_desc: 00480801 00480401 00480001 0048fc00 0048f800 0048f400 pkt_len=2045 rx_data: 00 f0 48 00 00 ec 48 00 00 e8 48 00 00 e4

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-11-04 Thread Jes Sorensen
Joe Perches writes: > On Sun, 2016-10-30 at 19:02 -0400, Jes Sorensen wrote: >> Code is 80 characters wide, and comments are /* */ never the ugly C++ >> crap. > > You might look at the recent Linus Torvalds authored commit > 5e467652ffef (?printk: re-organize log_output() to be

[PATCH net] fib_trie: correct /proc/net/route for large read buffer

2016-11-04 Thread Jason Baron
From: Jason Baron When read() is called on /proc/net/route requesting a size that is one entry size (128 bytes) less than m->size or greater, the resulting output has missing and/or duplicate entries. Since m->size is typically PAGE_SIZE, for a PAGE_SIZE of 4,096 this means

Re: Ethernet not working on a different SoC with same eth HW

2016-11-04 Thread Andrew Lunn
> Considering the ethernet DT bindings: > > https://www.kernel.org/doc/Documentation/devicetree/bindings/net/ethernet.txt > > Specifically, phy-mode values "rgmii", "rgmii-id", "rgmii-rxid", "rgmii-txid". > > Assuming that "rxid" (rx internal delay) and "rx clock delay" are > in fact the same

Re: Ethernet not working on a different SoC with same eth HW

2016-11-04 Thread Mason
On 04/11/2016 15:04, Måns Rullgård wrote: > Andrew Lunn writes: > >>> Considering the ethernet DT bindings: >>> >>> https://www.kernel.org/doc/Documentation/devicetree/bindings/net/ethernet.txt >>> >>> Specifically, phy-mode values "rgmii", "rgmii-id", "rgmii-rxid", >>>

Re: Ethernet not working on a different SoC with same eth HW

2016-11-04 Thread Mason
On 04/11/2016 14:40, Måns Rullgård wrote: > Mason writes: > >> On 31/10/2016 17:28, Mason wrote: >> >>> On 31/10/2016 16:53, Andrew Lunn wrote: >>> > I'll add a log for the request_irq call. And take a look at /proc/interrupts >>> >>> You're right, there does

Re: Ethernet not working on a different SoC with same eth HW

2016-11-04 Thread Andrew Lunn
> > I agree with you. But fixing it is likely to break boards which > > currently have "rgmii", but actually need the delay in order to work. > > Does the internal delay here refer to the PHY or the MAC? It's a > property of the MAC node after all. It is the PHY which applies the delay. The

Re: [PATCH net-next v4 3/9] ipv6: sr: add support for SRH encapsulation and injection with lwtunnels

2016-11-04 Thread Thomas Graf
On 11/04/16 at 11:29am, David Lebrun wrote: > +/* insert an SRH within an IPv6 packet, just after the IPv6 header */ > +static int seg6_do_srh_inline(struct sk_buff *skb, struct ipv6_sr_hdr *osrh) > +{ > + struct ipv6hdr *hdr, *oldhdr; > + struct ipv6_sr_hdr *isrh; > + int hdrlen, err;

  1   2   >