Re: stmmac/RTL8211F/Meson GXBB: TX throughput problems

2016-11-13 Thread André Roth
Hi all, > To everybody having similar issue with their OdroidC2, could you try > the attached patch and let us know if it changes anything for you ? I can confirm that this patch removes the problem, I have now constant ~300Mb/s in both directions without any issue ! :) I used the v4.10/integ

Re: stmmac/RTL8211F/Meson GXBB: TX throughput problems

2016-11-13 Thread André Roth
> Andre, the 3.14 kernel you are talking, is it this one ? :  > https://github.com/hardkernel/linux/tree/odroidc2-3.14.y yes > Because in drivers/net/phy/realtek.c, they disable EEE, but > also 1000Base-T Full Duplex advertisement ? > > + /* disable 1000m adv*/ > + val =

[PATCH v2] ip6_output: ensure flow saddr actually belongs to device

2016-11-13 Thread Jason A. Donenfeld
This puts the IPv6 routing functions in parity with the IPv4 routing functions. Namely, we now check in v6 that if a flowi6 requests an saddr, the returned dst actually corresponds to a net device that has that saddr. This mirrors the v4 logic with __ip_dev_find in __ip_route_output_key_hash. In

Re: [PATCH v2 2/2] bnx2: Wait for in-flight DMA to complete at probe stage

2016-11-13 Thread Michael Chan
On Sat, Nov 12, 2016 at 9:01 PM, Baoquan He wrote: > In-flight DMA from 1st kernel could continue going in kdump kernel. > New io-page table has been created before bnx2 does reset at open stage. > We have to wait for the in-flight DMA to complete to avoid it look up > into the

Re: [PATCH net 1/2] ibmvnic: Unmap ibmvnic_statistics structure

2016-11-13 Thread David Miller
From: Thomas Falcon Date: Fri, 11 Nov 2016 11:00:45 -0600 > This structure was mapped but never subsequently unmapped. > > Signed-off-by: Thomas Falcon Applied.

Re: [PATCH net 2/2] ibmvnic: Fix size of debugfs name buffer

2016-11-13 Thread David Miller
From: Thomas Falcon Date: Fri, 11 Nov 2016 11:00:46 -0600 > This mistake was causing debugfs directory creation > failures when multiple ibmvnic devices were probed. > > Signed-off-by: Thomas Falcon Applied.

Re: [PATCH] net: ethernet: ixp4xx_eth: fix spelling mistake in debug message

2016-11-13 Thread David Miller
From: Colin King Date: Sat, 12 Nov 2016 17:44:06 + > From: Colin Ian King > > Trivial fix to spelling mistake "successed" to "succeeded" > in debug message. Also unwrap multi-line literal string. > > Signed-off-by: Colin Ian King

Re: [PATCH] net: atheros: atl1e: use new api ethtool_{get|set}_link_ksettings

2016-11-13 Thread David Miller
From: Philippe Reynes Date: Sat, 12 Nov 2016 23:16:51 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > The previous implementation of set_settings was modifying > the value of advertising, but with the

[PATCH net-next v1] bpf: Use u64_to_user_ptr()

2016-11-13 Thread Mickaël Salaün
Replace the custom u64_to_ptr() function with the u64_to_user_ptr() macro. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnd Bergmann Cc: Daniel Borkmann --- kernel/bpf/syscall.c | 29

Re: [PATCH net-next] sfc: clear napi_hash state when copying channels

2016-11-13 Thread David Miller
From: Bert Kenward Date: Fri, 11 Nov 2016 15:56:51 + > efx_copy_channel() doesn't correctly clear the napi_hash related state. > This means that when napi_hash_add is called for that channel nothing is > done, and we are left with a copy of the napi_hash_node from

Re: [PATCH v2] net: ethernet: ti: davinci_cpdma: fix fixed prio cpdma ctlr configuration

2016-11-13 Thread David Miller
From: Ivan Khoronzhuk Date: Fri, 11 Nov 2016 15:45:24 +0200 > The dma ctlr is reseted to 0 while cpdma soft reset, thus cpdma ctlr > cannot be configured after cpdma is stopped. So restoring content > of cpdma ctlr while off/on procedure is needed. The cpdma ctlr

Re: [PATCH] net: ethernet: ti: davinci_cpdma: don't stop ctlr if it was stopped

2016-11-13 Thread David Miller
From: Ivan Khoronzhuk Date: Fri, 11 Nov 2016 16:10:47 +0200 > No need to stop ctlr if it was already stopped. It can cause timeout > warns. Steps: > - ifconfig eth0 down > - ethtool -l eth0 rx 8 tx 8 > - ethtool -l eth0 rx 1 tx 1 > > Signed-off-by: Ivan Khoronzhuk

Re: [PATCH] net: ioctl SIOCSIFADDR minor cleanup

2016-11-13 Thread David Miller
Your patch was mangled by your email client, chopping up long lines and turning TAB characters into spaces. Please fix this, email a test patch to yourself, and do not resubmit your change until you can successfully apply the patch you receive in a test email. Also, do not try using attachments

[net-next:master 664/670] drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c:1421:7-9: WARNING: possible condition with no effect (if == else)

2016-11-13 Thread Julia Lawall
It looks like the code on lines 1422 and 1424 is the same, so either the test may be unnecessary, or one of the branches is wrong. Coccinelle is also comparing about a comparison on an unsigned value in line 1900, but the code for that is not listed in the report below. julia tree:

[PATCH] net: atheros: atl2: use new api ethtool_{get|set}_link_ksettings

2016-11-13 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. The previous implementation of set_settings was modifying the value of advertising, but with the new API, it's not possible. The structure ethtool_link_ksettings is defined as const.

Re: [patch net-next] mlxsw: reg: Fix pwm_frequency field size in MFCR register

2016-11-13 Thread David Miller
From: Jiri Pirko Date: Fri, 11 Nov 2016 11:22:53 +0100 > From: Jiri Pirko > > The field is 7bit long. Fix it. > > Signed-off-by: Jiri Pirko Applied.

Re: [patch net v2 0/2] mlxsw: Couple of fixes

2016-11-13 Thread David Miller
From: Jiri Pirko Date: Fri, 11 Nov 2016 16:34:24 +0100 > From: Jiri Pirko > > Please, queue-up both for stable. Thanks! Just to be clear I did make sure to take v2 rather than v1.

Re: [patch net 0/2] mlxsw: Couple of fixes

2016-11-13 Thread David Miller
From: Jiri Pirko Date: Fri, 11 Nov 2016 11:20:40 +0100 > Please, queue-up both for stable. Thanks! Series applied and queued up for -stable, thanks.

Re: [PATCH net-next v7 03/10] dpaa_eth: add option to use one buffer pool set

2016-11-13 Thread David Miller
From: Madalin Bucur Date: Fri, 11 Nov 2016 10:20:00 +0200 > @@ -8,3 +8,12 @@ menuconfig FSL_DPAA_ETH > supporting the Freescale QorIQ chips. > Depends on Freescale Buffer Manager and Queue Manager > driver and Frame Manager Driver. > + > +if

Re: [PATCH] Revert "include/uapi/linux/atm_zatm.h: include linux/time.h"

2016-11-13 Thread David Miller
From: Mike Frysinger Date: Thu, 10 Nov 2016 19:08:39 -0500 > This reverts commit cf00713a655d ("include/uapi/linux/atm_zatm.h: include > linux/time.h"). > > This attempted to fix userspace breakage that no longer existed when > the patch was merged. Almost one year earlier,

Re: [PATCH net 2/2] r8152: rx descriptor check

2016-11-13 Thread David Miller
From: Hayes Wang Date: Fri, 11 Nov 2016 15:15:41 +0800 > For some platforms, the data in memory is not the same with the one > from the device. That is, the data of memory is unbelievable. The > check is used to find out this situation. > > Signed-off-by: Hayes Wang

Re: [RFC v4 00/18] Landlock LSM: Unprivileged sandboxing

2016-11-13 Thread Alexei Starovoitov
On Sun, Nov 13, 2016 at 6:23 AM, Mickaël Salaün wrote: > Hi, > > After the BoF at LPC last week, we came to a multi-step roadmap to > upstream Landlock. > > A first patch series containing the basic properties needed for a > "minimum viable product", which means being able to

Re: [PATCH net 0/2] bnxt_en: 2 bug fixes.

2016-11-13 Thread David Miller
From: Michael Chan Date: Fri, 11 Nov 2016 00:11:41 -0500 > Bug fixes in bnxt_setup_tc() and VF vitual link state. Series applied, thanks Michael.

[PATCH] net: atheros: atl1: use new api ethtool_{get|set}_link_ksettings

2016-11-13 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. The previous implementation of set_settings was modifying the value of advertising, but with the new API, it's not possible. The structure ethtool_link_ksettings is defined as const.

Re: [PATCH v2 net] tcp: take care of truncations done by sk_filter()

2016-11-13 Thread David Miller
From: Eric Dumazet Date: Thu, 10 Nov 2016 13:12:35 -0800 > From: Eric Dumazet > > With syzkaller help, Marco Grassi found a bug in TCP stack, > crashing in tcp_collapse() > > Root cause is that sk_filter() can truncate the incoming skb, > but TCP

Re: [mm PATCH v3 17/23] arch/sparc: Add option to skip DMA sync as a part of map and unmap

2016-11-13 Thread David Miller
From: Alexander Duyck Date: Thu, 10 Nov 2016 06:35:45 -0500 > This change allows us to pass DMA_ATTR_SKIP_CPU_SYNC which allows us to > avoid invoking cache line invalidation if the driver will just handle it > via a sync_for_cpu or sync_for_device call. > >

Re: [PATCH net,v2] ipv4: use new_gw for redirect neigh lookup

2016-11-13 Thread David Miller
From: Stephen Suryaputra Lin Date: Thu, 10 Nov 2016 11:16:15 -0500 > In v2.6, ip_rt_redirect() calls arp_bind_neighbour() which returns 0 > and then the state of the neigh for the new_gw is checked. If the state > isn't valid then the redirected route is

Re: [PATCH] Fixup packets with incorrect ethertype sent by ZTE MF821D

2016-11-13 Thread Jussi Peltola
On Sun, Nov 13, 2016 at 05:12:57PM +0100, Bjørn Mork wrote: > In any case, if we're going to add a fix like this, then I want it way > more generic. The only valid ethertypes expected from the modem is IP, > IPV6 or ARP. Testing against those three, resetting anything else to IP, > will at least

Re: [PATCH] genetlink: fix unsigned int comparison with less than zero

2016-11-13 Thread David Miller
From: Colin King Date: Thu, 10 Nov 2016 15:57:58 + > From: Colin Ian King > > family->id is unsigned, so the less than zero check for > failure return from idr_alloc is never true and so the error exit > is never handled. Instead, assign

Re: [PATCH] net: phy: marvell: optimize logic for page changing during init

2016-11-13 Thread David Miller
From: Uwe Kleine-König Date: Thu, 10 Nov 2016 15:03:01 +0100 > Instead of remembering if the page was changed, just compare the current > page to the saved one. This is easier and has the advantage to save a > register write if the page was already restored. > >

Re: [PATCH] r8152: Fix error path in open function

2016-11-13 Thread David Miller
From: Guenter Roeck Date: Wed, 9 Nov 2016 19:51:25 -0800 > If usb_submit_urb() called from the open function fails, the following > crash may be observed. ... > Clean up error handling to avoid registering the notifier if the open > function is going to fail. > >

Re: [PATCH] Fixup packets with incorrect ethertype sent by ZTE MF821D

2016-11-13 Thread David Miller
From: Bjørn Mork Date: Sun, 13 Nov 2016 17:12:57 +0100 > In any case, if we're going to add a fix like this, then I want it way > more generic. The only valid ethertypes expected from the modem is IP, > IPV6 or ARP. Testing against those three, resetting anything else to IP, >

Re: [PATCH] ip6_output: ensure flow saddr actually belongs to device

2016-11-13 Thread David Ahern
On 11/13/16 6:23 AM, Jason A. Donenfeld wrote: > This puts the IPv6 routing functions in parity with the IPv4 routing > functions. Namely, we now check in v6 that if a flowi6 requests an > saddr, the returned dst actually corresponds to a net device that has > that saddr. This mirrors the v4 logic

Re: [PATCH] Fixup packets with incorrect ethertype sent by ZTE MF821D

2016-11-13 Thread Bjørn Mork
Jussi Peltola writes: > This brokenness appears reliably after running "rdisc6 wwan0" but I have > not debugged if this is related to timing or the format of the router > solicitation. Before receiving a router solicitation, v4 is received > correctly and v6 does not work. After

Re: Kernel 4.8.7 crashing down cleanup_net()

2016-11-13 Thread Borislav Petkov
Hmm, there's cleanup_net() namespaces fun in there, adding netdev@. On Sat, Nov 12, 2016 at 02:17:03PM -0800, Ashton Holmes wrote: > I upgraded to 4.8.7 and the system boots and my root partition gets > decrypted but right after that both of my monitors turn off and > looking at syslog from 4.8.6

Re: [RFC v4 00/18] Landlock LSM: Unprivileged sandboxing

2016-11-13 Thread Mickaël Salaün
Hi, After the BoF at LPC last week, we came to a multi-step roadmap to upstream Landlock. A first patch series containing the basic properties needed for a "minimum viable product", which means being able to test it, without full features. The idea is to set in place the main components which

[PATCH net] sctp: change sk state only when it has assocs in sctp_shutdown

2016-11-13 Thread Xin Long
Now when users shutdown a sock with SEND_SHUTDOWN in sctp, even if this sock has no connection (assoc), sk state would be changed to SCTP_SS_CLOSING, which is not as we expect. Besides, after that if users try to listen on this sock, kernel could even panic when it dereference

[PATCH] Fixup packets with incorrect ethertype sent by ZTE MF821D

2016-11-13 Thread Jussi Peltola
This brokenness appears reliably after running "rdisc6 wwan0" but I have not debugged if this is related to timing or the format of the router solicitation. Before receiving a router solicitation, v4 is received correctly and v6 does not work. After sending the MF821D a router solicitation with

[PATCH] ip6_output: ensure flow saddr actually belongs to device

2016-11-13 Thread Jason A. Donenfeld
This puts the IPv6 routing functions in parity with the IPv4 routing functions. Namely, we now check in v6 that if a flowi6 requests an saddr, the returned dst actually corresponds to a net device that has that saddr. This mirrors the v4 logic with __ip_dev_find in __ip_route_output_key_hash. In

Re: linux-next: manual merge of the net-next tree with the net tree

2016-11-13 Thread Or Gerlitz
On Thu, Nov 10, 2016 at 1:50 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c > > between commit: > ee39fbc4447d ("net/mlx5: E-Switch, Set the

[PATCH 4.8 24/35] net: sctp, forbid negative length

2016-11-13 Thread Greg Kroah-Hartman
4.8-stable review patch. If anyone has any objections, please let me know. -- From: Jiri Slaby [ Upstream commit a4b8e71b05c27bae6bad3bdecddbc6b68a3ad8cf ] Most of getsockopt handlers in net/sctp/socket.c check len against sizeof some structure like:

[PATCH 4.4 23/34] net: sctp, forbid negative length

2016-11-13 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Jiri Slaby [ Upstream commit a4b8e71b05c27bae6bad3bdecddbc6b68a3ad8cf ] Most of getsockopt handlers in net/sctp/socket.c check len against sizeof some structure like:

Re: [Intel-wired-lan] [PATCH v2] e1000e: free IRQ regardless of __E1000_DOWN

2016-11-13 Thread Neftin, Sasha
On 11/13/2016 10:34 AM, Neftin, Sasha wrote: > On 11/11/2016 12:35 AM, Baicar, Tyler wrote: >> Hello Sasha, >> >> On 11/9/2016 11:19 PM, Neftin, Sasha wrote: >>> On 11/9/2016 11:41 PM, Tyler Baicar wrote: Move IRQ free code so that it will happen regardless of the __E1000_DOWN bit.

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-13 Thread kbuild test robot
Hi Lino, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Lino-Sanfilippo/net-ethernet-slicoss-add-slicoss-gigabit-ethernet-driver/20161113-125131 config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9

Re: [Intel-wired-lan] [PATCH v2] e1000e: free IRQ regardless of __E1000_DOWN

2016-11-13 Thread Neftin, Sasha
On 11/11/2016 12:35 AM, Baicar, Tyler wrote: > Hello Sasha, > > On 11/9/2016 11:19 PM, Neftin, Sasha wrote: >> On 11/9/2016 11:41 PM, Tyler Baicar wrote: >>> Move IRQ free code so that it will happen regardless of the >>> __E1000_DOWN bit. Currently the e1000e driver only releases its IRQ >>> if

<    1   2