Re: [PATCH net-next v2 6/6] tcp: SOF_TIMESTAMPING_OPT_STATS option for SO_TIMESTAMPING

On Mon, Nov 28, 2016 at 2:07 AM, Yuchung Cheng wrote: > From: Francis Yan > > This patch exports the sender chronograph stats via the socket > SO_TIMESTAMPING channel. Currently we can instrument how long a > particular application unit of data was

Re: [[PATCH iproute2/net-next v2] 2/4] tc: flower: document SCTP ip_proto

On Fri, 2 Dec 2016 09:45:19 +0100 Simon Horman wrote: > Add SCTP ip_proto to help text and man page. > > Signed-off-by: Simon Horman This doesn't apply cleanly to current net-next git. Probably some of the other man page changes caused

Re: [PATCH/RFC iproute2/net-next 1/3] tc: flower: update headers for TCA_FLOWER_KEY_ICMP*

On Fri, 2 Dec 2016 10:59:43 +0100 Simon Horman wrote: > These are proposed changes for net-next. > > Signed-off-by: Simon Horman > --- > include/linux/pkt_cls.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

[PATCH net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

When XDP prog is attached, it is currently limiting MTU to be FRAG_SZ0 - ETH_HLEN - (2 * VLAN_HLEN) which is 1514 in x86. AFAICT, since mlx4 is doing one page per packet for XDP, we can at least raise the MTU limitation up to PAGE_SIZE - ETH_HLEN - (2 * VLAN_HLEN) which this patch is doing. It

Re: [PATCH net-next 1/4] bpf: xdp: Allow head adjustment in XDP prog

On 12/03/2016 12:23 AM, Martin KaFai Lau wrote: This patch allows XDP prog to extend/remove the packet data at the head (like adding or removing header). It is done by adding a new XDP helper bpf_xdp_adjust_head(). It also renames bpf_helper_changes_skb_data() to bpf_helper_changes_pkt_data()

Re: [PATCH net] geneve: avoid use-after-free of skb->data

2016-12-02, 14:09:25 -0500, David Miller wrote: > From: Sabrina Dubroca > Date: Fri, 2 Dec 2016 16:49:29 +0100 > > > geneve{,6}_build_skb can end up doing a pskb_expand_head(), which > > makes the ip_hdr(skb) reference we stashed earlier stale. Since it's > > only needed

[PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read

There is desc_read() macros to read desc fields, so no need to use __raw_readl(); Signed-off-by: Ivan Khoronzhuk --- Based on net-next/master drivers/net/ethernet/ti/davinci_cpdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

On Fri, Dec 02, 2016 at 06:15:26PM -0800, Eric Dumazet wrote: > On Fri, 2016-12-02 at 16:53 -0800, Alexei Starovoitov wrote: > > On 12/2/16 4:38 PM, Eric Dumazet wrote: > > > On Fri, 2016-12-02 at 15:23 -0800, Martin KaFai Lau wrote: > > >> When XDP prog is attached, it is currently limiting > >

Re: [PATCH net-next 1/4] bpf: xdp: Allow head adjustment in XDP prog

On Sat, Dec 03, 2016 at 01:22:05AM +0100, Daniel Borkmann wrote: > On 12/03/2016 12:23 AM, Martin KaFai Lau wrote: > >This patch allows XDP prog to extend/remove the packet > >data at the head (like adding or removing header). It is > >done by adding a new XDP helper bpf_xdp_adjust_head(). > > >

Re: [PATCH] iproute2: ss: escape all null bytes in abstract unix domain socket

On Fri, 2016-12-02 at 15:18 -0800, Stephen Hemminger wrote: > name[i] = '@'; > > > > ss.c: In function 'unix_show_sock': > > ss.c:3128:4: error: 'for' loop initial declarations are only allowed in C99 > > mode > > ss.c:3128:4: note: use option -std=c99 or

[PATCH v3 net-next 1/4] net: dsa: mv88e6xxx: Implement mv88e6390 tag remap

The mv88e6390 does not have the two registers to set the frame priority map. Instead it has an indirection registers for setting a number of different priority maps. Refactor the old code into an function, implement the mv88e6390 version, and use an op to call the right one. Signed-off-by: Andrew

[PATCH v3 net-next 2/4] net: dsa: mv88e6xxx: Monitor and Management tables

The mv88e6390 changes the monitor control register into the Monitor and Management control, which is an indirection register to various registers. Add ops to set the CPU port and the ingress/egress port for both register layouts, to global1 Signed-off-by: Andrew Lunn ---

[PATCH v3 net-next 4/4] net: dsa: mv88e6xxx: Refactor CPU and DSA port setup

Older chips only support DSA tagging. Newer chips have both DSA and EDSA tagging. Refactor the code by adding port functions for setting the frame mode, egress mode, and if to forward unknown frames. This results in the helper mv88e6xxx_6065_family() becoming unused, so remove it. Signed-off-by:

Re: [PATCH net v2] tcp: warn on bogus MSS and try to amend it

On Fri, Dec 02, 2016 at 06:45:24AM -0800, Eric Dumazet wrote: > On Fri, 2016-12-02 at 08:55 -0200, Marcelo Ricardo Leitner wrote: > > There have been some reports lately about TCP connection stalls caused > > by NIC drivers that aren't setting gso_size on aggregated packets on rx > > path. This

[PATCH net v3] tcp: warn on bogus MSS and try to amend it

There have been some reports lately about TCP connection stalls caused by NIC drivers that aren't setting gso_size on aggregated packets on rx path. This causes TCP to assume that the MSS is actually the size of the aggregated packet, which is invalid. Although the proper fix is to be done at

[PATCH v3 net-next 3/4] net: dsa: mv88e6xxx: Move the tagging protocol into info

Older chips support a single tagging protocol, DSA. New chips support both DSA and EDSA, an enhanced version. Having both as an option changes the register layouts. Up until now, it has been assumed that if EDSA is supported, it will be used. Hence the register layout has been determined by which

[PATCH 0/3] UAPI export missing headers

Files not being exported by make install headers Stephen Hemminger (3): tc: export tunnel key file uapi: export tc_skbmod.h uapi: export nf_log.h include/uapi/linux/netfilter/Kbuild | 1 + include/uapi/linux/tc_act/Kbuild| 2 ++ 2 files changed, 3 insertions(+) -- 2.10.2

[PATCH 1/2] net: ethernet: sxgbe: do not use xmit_lock in tx completion handler

The driver already uses its private lock for synchronization between the xmit function and the xmit completion handler, making the additional use of the xmit_lock unnecessary. Furthermore the driver does not set NETIF_F_LLTX resulting in xmit to be called with the xmit_lock held and then taking

[PATCH 2/2] net: ethernet: stmmac: do not use xmit_lock in tx completion handler

The driver already uses its private lock for synchronization between the xmit function and the xmit completion handler, making the additional use of the xmit_lock unnecessary. Furthermore the driver does not set NETIF_F_LLTX resulting in xmit to be called with the xmit_lock held and then taking

Avoid deadlock situation due to use of xmit_lock

Hi, after stumbling over a potential deadlock situation in the altera driver (see http://marc.info/?l=linux-netdev=148054615230447=2), I checked all other ethernet drivers for the same issue and actually found it in 2 more, namely stmmac, and sxgbe. Please see the commit messages for a

Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'

On Sat, 3 Dec 2016, Arnd Bergmann wrote: > ptp now depends on the optional POSIX_TIMERS setting and fails to build > if we select it without that: > > warning: (LIQUIDIO_VF && TI_CPTS) selects PTP_1588_CLOCK which has unmet > direct dependencies (NET && POSIX_TIMERS) > warning: (LIQUIDIO_VF &&

Re: [PATCH 2/7] net: ethernet: ti: cpdma: fix desc re-queuing

On Fri, Dec 02, 2016 at 10:45:07AM -0600, Grygorii Strashko wrote: > > > On 12/02/2016 05:03 AM, Ivan Khoronzhuk wrote: > > On Thu, Dec 01, 2016 at 05:34:27PM -0600, Grygorii Strashko wrote: > >> The currently processing cpdma descriptor with EOQ flag set may > >> contain two values in Next

Re: [PATCH net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

On 12/02/2016 03:23 PM, Martin KaFai Lau wrote: When XDP prog is attached, it is currently limiting MTU to be FRAG_SZ0 - ETH_HLEN - (2 * VLAN_HLEN) which is 1514 in x86. AFAICT, since mlx4 is doing one page per packet for XDP, we can at least raise the MTU limitation up to PAGE_SIZE - ETH_HLEN

[PATCH] net: ping: check minimum size on ICMP header length

Prior to commit c0371da6047a ("put iov_iter into msghdr") in v3.19, there was no check that the iovec contained enough bytes for a icmp header, and the read loop would walk across neighboring stack contents. Since the iov_iter conversion, bad arguments are noticed, but the returned error is

[PATCH 1/3] uapi: export tc tunnel key file

Fixes commit 21609ae32aaf6c6fab0e ("net/sched: Introduce act_tunnel_key") The file is necessary for iproute2 headers but was not being copied by make install_headers Signed-off-by: Stephen Hemminger --- include/uapi/linux/tc_act/Kbuild | 1 + 1 file changed, 1

[PATCH 2/3] uapi: export tc_skbmod.h

Fixes commit 735cffe5d800 ("net_sched: Introduce skbmod action") Not used by iproute2 but maybe in future. Signed-off-by: Stephen Hemminger --- include/uapi/linux/tc_act/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/tc_act/Kbuild

[PATCH 3/3] uapi: export nf_log.h

File is in uapi directory but not being copied on make install_headers Fixes commit 4ec9c8fbbc22 ("netfilter: nft_log: complete NFTA_LOG_FLAGS attr support"). Signed-off-by: Stephen Hemminger --- include/uapi/linux/netfilter/Kbuild | 1 + 1 file changed, 1 insertion(+)

[PATCH v2 0/3] uapi: add kbuild for some files

Some files which are in uapi but not being copied by make headers_install Stephen Hemminger (3): tc: export tunnel key file uapi: export tc_skbmod.h uapi: export nf_log.h include/uapi/linux/netfilter/Kbuild | 1 + include/uapi/linux/tc_act/Kbuild| 2 ++ 2 files changed, 3

[PATCH net-next] liquidio: 'imply' ptp instead of 'select'

ptp now depends on the optional POSIX_TIMERS setting and fails to build if we select it without that: warning: (LIQUIDIO_VF && TI_CPTS) selects PTP_1588_CLOCK which has unmet direct dependencies (NET && POSIX_TIMERS) warning: (LIQUIDIO_VF && TI_CPTS) selects PTP_1588_CLOCK which has unmet direct

Re: [[PATCH iproute2/net-next v2] 1/4] tc: flower: remove references to eth_type in manpage

On Fri, 2 Dec 2016 09:45:18 +0100 Simon Horman wrote: > Remove references to eth_type and ether_type (spelling error) in > the tc flower manpage. > > Also correct formatting of boldface text with whitespace. > > Cc: Paul Blakey > Signed-off-by:

Re: iproute2 public git outdated?

On Thu, 1 Dec 2016 13:18:06 +0100 Phil Sutter wrote: > Hi, > > I am using iproute2's public git repo at this URL: > > git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git > > To my surprise, neither master nor net-next branches have received new > commits since

Re: [PATCH net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

On 12/2/16 4:38 PM, Eric Dumazet wrote: On Fri, 2016-12-02 at 15:23 -0800, Martin KaFai Lau wrote: When XDP prog is attached, it is currently limiting MTU to be FRAG_SZ0 - ETH_HLEN - (2 * VLAN_HLEN) which is 1514 in x86. AFAICT, since mlx4 is doing one page per packet for XDP, we can at least

[PATCHv2 net-next 0/4] MV88E6390 batch two

This is the second batch of patches adding support for the MV88e6390. They are not sufficient to make it work properly. The mv88e6390 has a much expanded set of priority maps. Refactor the existing code, and implement basic support for the new device. Similarly, the monitor control register has

Re: [PATCH net-next v2 6/6] tcp: SOF_TIMESTAMPING_OPT_STATS option for SO_TIMESTAMPING

On Fri, Dec 2, 2016 at 2:30 PM, Paul Gortmaker wrote: > On Mon, Nov 28, 2016 at 2:07 AM, Yuchung Cheng wrote: >> From: Francis Yan >> >> This patch exports the sender chronograph stats via the socket >> SO_TIMESTAMPING

[PATCH net-next] phy: add phy fixup unregister functions

From: Woojung Huh Add functions to unregister phy fixup for modules. phy_unregister_fixup(const char *bus_id, u32 phy_uid, u32 phy_uid_mask) Unregister phy fixup matches bus_id, phy_uid and phy_uid_mask from phy_fixup_list. Return 0 when find matched one and remove

[PATCH net-next 1/4] bpf: xdp: Allow head adjustment in XDP prog

This patch allows XDP prog to extend/remove the packet data at the head (like adding or removing header). It is done by adding a new XDP helper bpf_xdp_adjust_head(). It also renames bpf_helper_changes_skb_data() to bpf_helper_changes_pkt_data() to better reflect that XDP prog does not work on

Re: [net-next PATCH v4 5/6] virtio_net: add XDP_TX support

On 16-12-02 12:51 PM, John Fastabend wrote: > This adds support for the XDP_TX action to virtio_net. When an XDP > program is run and returns the XDP_TX action the virtio_net XDP > implementation will transmit the packet on a TX queue that aligns > with the current CPU that the XDP packet was

[PATCH v1 net-next 1/5] net: dsa: mv88e6xxx: Reserved Management frames to CPU

Older devices have a couple of registers in global2. The mv88e6390 family has a single register in global1 behind which hides similar configuration. Implement and op for this. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 35

[PATCH v1 net-next 0/5] mv88e6390 batch 3

More patches to support the MV88e6390. This is mostly refactoring existing code and adding implementations for the mv88e6390. This patchset set which reserved frames are sent to the cpu, the size of jumbo frames that will be accepted, turn off egress rate limiting, and configuration of pause

[PATCH 2/3] uapi: export tc_skbmod.h

Fixes commit 735cffe5d800 ("net_sched: Introduce skbmod action") Not used by iproute2 but maybe in future. Signed-off-by: Stephen Hemminger --- include/uapi/linux/tc_act/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/tc_act/Kbuild

[PATCH 1/3] uapi: export tc tunnel key file

Fixes commit 21609ae32aaf6c6fab0e ("net/sched: Introduce act_tunnel_key") The file is necessary for iproute2 headers but was not being copied by make install_headers Signed-off-by: Stephen Hemminger --- include/uapi/linux/tc_act/Kbuild | 1 + 1 file changed, 1

[PATCH 3/3] uapi: export nf_log.h

File is in uapi directory but not being copied on make install_headers Fixes commit 4ec9c8fbbc22 ("netfilter: nft_log: complete NFTA_LOG_FLAGS attr support"). Signed-off-by: Stephen Hemminger --- include/uapi/linux/netfilter/Kbuild | 1 + 1 file changed, 1 insertion(+)

[PATCH net-next v3 1/2] net: dt-bindings: add RGMII TX delay configuration to meson8b-dwmac

This allows configuring the RGMII TX clock delay. The RGMII clock is generated by underlying hardware of the the Meson 8b / GXBB DWMAC glue. The configuration depends on the actual hardware (no delay may be needed due to the design of the actual circuit, the PHY might add this delay, etc.).

[PATCH net-next v3 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4 cycle (= 2ns) TX clock delay. This seems to work fine for many boards (for example Odroid-C2 or Amlogic's reference boards) but there are some others where TX traffic is simply broken. There are probably multiple reasons why it's

[PATCH net-next v3 2/2] net: stmmac: dwmac-meson8b: make the RGMII TX delay configurable

Prior to this patch we were using a hardcoded RGMII TX clock delay of 2ns (= 1/4 cycle of the 125MHz RGMII TX clock). This value works for many boards, but unfortunately not for all (due to the way the actual circuit is designed, sometimes because the TX delay is enabled in the PHY, etc.). Making

Re: [PATCH 5/7] Documentation: DT: net: cpsw: allow to specify descriptors pool size

On Fri, Dec 02, 2016 at 11:22:28AM -0600, Grygorii Strashko wrote: > > > On 12/02/2016 05:28 AM, Ivan Khoronzhuk wrote: > > On Thu, Dec 01, 2016 at 05:34:30PM -0600, Grygorii Strashko wrote: > >> Add optional property "descs_pool_size" to specify buffer descriptor's > >> pool size. The

Re: [PATCH net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

On Fri, 2016-12-02 at 16:53 -0800, Alexei Starovoitov wrote: > On 12/2/16 4:38 PM, Eric Dumazet wrote: > > On Fri, 2016-12-02 at 15:23 -0800, Martin KaFai Lau wrote: > >> When XDP prog is attached, it is currently limiting > >> MTU to be FRAG_SZ0 - ETH_HLEN - (2 * VLAN_HLEN) which is 1514 > >> in

Re: [PATCH] iproute2: ss: escape all null bytes in abstract unix domain socket

On Fri, 02 Dec 2016 10:59:56 -0800 Eric Dumazet wrote: > On Sat, 2016-11-12 at 10:17 +0300, Stephen Hemminger wrote: > > On Sat, 29 Oct 2016 22:20:19 +0300 > > Isaac Boukris wrote: > > > > > Abstract unix domain socket may embed null characters, >

Re: bpf bounded loops. Was: [flamebait] xdp

On Fri, Dec 02, 2016 at 08:42:41PM +0100, Hannes Frederic Sowa wrote: > On Fri, Dec 2, 2016, at 20:25, Hannes Frederic Sowa wrote: > > On 02.12.2016 19:39, Alexei Starovoitov wrote: > > > On Thu, Dec 01, 2016 at 10:27:12PM +0100, Hannes Frederic Sowa wrote: > > >> like") and the problematic of

[PATCH net-next 0/4]: Allow head adjustment in XDP prog

This series adds a helper to allow head adjustment in XDP prog. mlx4 driver has been modified to support this feature. An example is written to encapsulate a packet with an IPv4/v6 header and then XDP_TX it out. Thanks, --Martin

Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'

On 12/02/2016 03:04 PM, Arnd Bergmann wrote: ptp now depends on the optional POSIX_TIMERS setting and fails to build if we select it without that: warning: (LIQUIDIO_VF && TI_CPTS) selects PTP_1588_CLOCK which has unmet direct dependencies (NET && POSIX_TIMERS) warning: (LIQUIDIO_VF &&

Re: [PATCH v2 0/7] stmmac: dwmac-meson8b: configurable RGMII TX delay

On Mon, Nov 28, 2016 at 2:33 AM, David Miller wrote: > From: Martin Blumenstingl > Date: Fri, 25 Nov 2016 14:01:49 +0100 > >> Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4 >> cycle TX clock delay. This seems to work

[PATCH net-next 3/4] mlx4: xdp: Reserve headroom for receiving packet when XDP prog is active

Reserve XDP_PACKET_HEADROOM when XDP prog is active. Signed-off-by: Martin KaFai Lau --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 17 +++-- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 23 +-- drivers/net/ethernet/mellanox/mlx4/en_tx.c

Re: [PATCH net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

On Fri, 2016-12-02 at 15:23 -0800, Martin KaFai Lau wrote: > When XDP prog is attached, it is currently limiting > MTU to be FRAG_SZ0 - ETH_HLEN - (2 * VLAN_HLEN) which is 1514 > in x86. > > AFAICT, since mlx4 is doing one page per packet for XDP, > we can at least raise the MTU limitation up to

[PATCH net-next v2 1/4] bnxt_en: Re-factor bnxt_setup_tc().

Add a new function bnxt_setup_mq_tc() to handle MQPRIO. This new function will be called during ETS setup when we add DCBNL in the next patch. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 18 ++

[PATCH net-next v2 2/4] bnxt_en: Update firmware header file to latest 1.6.0.

Latest interface has the latest DCB command structs. Get and store the max number of lossless TCs the hardware can support. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 +- drivers/net/ethernet/broadcom/bnxt/bnxt.h |

[PATCH net-next v2 4/4] bnxt_en: Add PFC statistics.

Report PFC statistics to ethtool -S and DCBNL. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 7 +++ drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 14 +- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 23

[PATCH net-next v2 3/4] bnxt_en: Implement DCBNL to support host-based DCBX.

Support only IEEE DCBX initially. Add IEEE DCBNL ops and functions to get and set the hardware DCBX parameters. The DCB code is conditional on Kconfig CONFIG_BNXT_DCB. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/Kconfig | 10 +

[PATCH net-next v2 0/4] bnxt_en: Add DCBNL support.

This series adds DCBNL operations to support host-based IEEE DCBX. v2: Updated to the latest firmware interface spec. David, please consider this series for net-next. Michael Chan (4): bnxt_en: Re-factor bnxt_setup_tc(). bnxt_en: Update firmware header file to latest 1.6.0. bnxt_en:

[PATCH v1 net-next 5/5] net: dsa: mv88e6xxx: Implement mv88e6390 pause control

The mv88e6390 has a number flow control registers accessed via the Flow Control register. Use these to set the pause control. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 7 +++ drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 2 ++

[PATCH v1 net-next 3/5] net: dsa: mv88e6xxx: Refactor egress rate limiting

There are two different rate limiting configurations, depending on the switch generation. Refactor this into ops. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 31 +++ drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 2 ++

[PATCH v1 net-next 2/5] net: dsa: mv88e6xxx: Refactor setting of jumbo frames

Some switches support jumbo frames. Refactor this code into operations in the ops structure. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 26 ++ drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 1 + drivers/net/dsa/mv88e6xxx/port.c

[PATCH v1 net-next 4/5] net: dsa: mv88e6xxx: Refactor pause configuration

The mv88e6390 has a different mechanism for configuring pause. Refactor the code into an ops function, and for the moment, don't add any mv88e6390 code yet. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 28

Re: [PATCH net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

On Fri, 2016-12-02 at 19:42 -0800, Martin KaFai Lau wrote: > On Fri, Dec 02, 2016 at 06:15:26PM -0800, Eric Dumazet wrote: > > My question was more like : > > > > Can we double check all these patches wont break mlx4 driver (non XDP > > path) on arches with PAGE_SIZE=64KB. > The page/pkt

Re: DSA vs. SWTICHDEV ?

On Thu, Dec 01, 2016 at 04:38:47PM -0500, Murali Karicheri wrote: > Hi Andrew, > On 12/01/2016 12:31 PM, Andrew Lunn wrote: > > Hi Murali > > > >> 2. Switch mode where it implements a simple Ethernet switch. Currently > >>it doesn't have address learning capability, but in future it > >>

Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v3

On Fri, 2016-12-02 at 16:37 +0100, Jesper Dangaard Brouer wrote: > On Thu, 01 Dec 2016 23:17:48 +0100 > Paolo Abeni wrote: > > > On Thu, 2016-12-01 at 18:34 +0100, Jesper Dangaard Brouer wrote: > > > (Cc. netdev, we might have an issue with Paolo's UDP accounting and > > >

Re: [PATCH net-next 3/6] net: dsa: mv88e6xxx: add a software reset op

On Thu, Dec 01, 2016 at 03:41:20PM -0500, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > >> diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > >> b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > >> index ab52c37..9e51405 100644 > >> ---

Re: [PATCH net 0/7] net: stmmac: fix probe error handling and phydev leaks

From: Johan Hovold Date: Wed, 30 Nov 2016 15:29:48 +0100 > This series fixes a number of issues with the stmmac-driver probe error > handling, which for example left clocks enabled after probe failures. > > The final patch fixes a failure to deregister and free any fixed-link

Re: [PATCH net-next V2 0/7] Mellanox 100G mlx5 updates 2016-11-29

From: Saeed Mahameed Date: Wed, 30 Nov 2016 17:59:36 +0200 > The following series from Tariq and Roi, provides some critical fixes > and updates for the mlx5e driver. > > From Tariq: > - Fix driver coherent memory huge allocation issues by fragmenting >completion

[PATCH net-next] udp: be less conservative with sock rmem accounting

Before commit 850cbaddb52d ("udp: use it's own memory accounting schema"), the udp protocol allowed sk_rmem_alloc to grow beyond the rcvbuf by the whole current packet's truesize. After said commit we allow sk_rmem_alloc to exceed the rcvbuf only if the receive queue is empty. As reported by

Re: [PATCH 2/7] net: ethernet: ti: cpdma: fix desc re-queuing

On 12/02/2016 05:03 AM, Ivan Khoronzhuk wrote: > On Thu, Dec 01, 2016 at 05:34:27PM -0600, Grygorii Strashko wrote: >> The currently processing cpdma descriptor with EOQ flag set may >> contain two values in Next Descriptor Pointer field: >> - valid pointer: means CPDMA missed addition of new

Re: [Intel-wired-lan] [PATCH v2] e1000e: free IRQ regardless of __E1000_DOWN

Hello Sasha, Were you able to reproduce this issue? Do you have a patch fixing the close function inconsistencies that you mentioned which I could try out? Thanks, Tyler On 11/21/2016 1:40 PM, Baicar, Tyler wrote: On 11/17/2016 6:31 AM, Neftin, Sasha wrote: On 11/13/2016 10:34 AM, Neftin,

Re: [PATCH] net: atarilance: use %8ph for printing hex string

From: Rasmus Villemoes Date: Wed, 30 Nov 2016 23:02:54 +0100 > This is already using the %pM printf extension; might as well also use > %ph to make the code smaller. > > Signed-off-by: Rasmus Villemoes Applied, thank you.

Re: net/can: warning in raw_setsockopt/__alloc_pages_slowpath

On 12/02/2016 04:42 PM, Marc Kleine-Budde wrote: On 12/02/2016 04:11 PM, Oliver Hartkopp wrote: On 12/02/2016 02:24 PM, Marc Kleine-Budde wrote: On 12/02/2016 01:43 PM, Andrey Konovalov wrote: [] raw_setsockopt+0x1be/0x9f0 net/can/raw.c:506 We should add a check for a sensible

Re: [PATCH/RFC net-next 0/2] net/sched: cls_flower: Support matching on ICMP

Fri, Dec 02, 2016 at 10:52:30AM CET, simon.hor...@netronome.com wrote: >Hi, > >this series add supports for matching on ICMP type and code to cls_flower. >This is modeled on existing support for matching on L4 ports. The updates >to the dissector are intended to allow for code and storage re-use.

[PATCH] pull request for net: batman-adv 2016-12-02

during tp_send as error (2016-11-04 12:27:39 +0100) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-net-for-davem-20161202 for you to fetch changes up to c2d0f48a13e53b4747704c9e692f5e765e52041a: batman-adv: Check for alloc errors when preparing TT

[PATCH net-next] net_sched: gen_estimator: account for timer drifts

From: Eric Dumazet Under heavy stress, timer used in estimators tend to slowly be delayed by a few jiffies, leading to inaccuracies. Lets remember what was the last scheduled jiffies so that we get more precise estimations, without having to add a multiply/divide in the

[PATCH] batman-adv: Check for alloc errors when preparing TT local data

From: Sven Eckelmann batadv_tt_prepare_tvlv_local_data can fail to allocate the memory for the new TVLV block. The caller is informed about this problem with the returned length of 0. Not checking this value results in an invalid memory access when either tt_data or tt_change

Re: [PATCH 1/1] ax25: Fix segfault when receiving an iframe with net2kiss loaded

From: Basil Gunn Date: Wed, 30 Nov 2016 11:15:25 -0800 > AX.25 uses sock_queue_rcv_skb() to queue an iframe received packet. > This routine writes NULL to the socket buffer device structure > pointer. The socket buffer is subsequently serviced by > __netif_receiv_skb_core()

Re: arp_filter and IPv6 ND

Hello, On 02.12.2016 16:42, Saku Ytti wrote: > On 2 December 2016 at 16:08, Hannes Frederic Sowa > wrote: > > Hey, > >> May I ask why you want to turn it off? > > Certainly. I don't want device to answer with link address for L3 > address it does not have on the

Re: [PATCH net-next v4 0/4] bpf: BPF for lightweight tunnel encapsulation

From: Thomas Graf Date: Wed, 30 Nov 2016 17:10:07 +0100 > This series implements BPF program invocation from dst entries via the > lightweight tunnels infrastructure. Nice work, applied, thanks Thomas.

Re: [PATCH net-next] net/mlx5e: skip loopback selftest with !CONFIG_INET

From: Arnd Bergmann Date: Wed, 30 Nov 2016 22:05:39 +0100 > When CONFIG_INET is disabled, the new selftest results in a link > error: > > drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.o: In function > `mlx5e_test_loopback': > en_selftest.c:(.text.mlx5e_test_loopback+0x2ec):

Re: [PATCH/RFC iproute2/net-next 0/3] tc: flower: Support matching on ICMP

Fri, Dec 02, 2016 at 10:59:42AM CET, simon.hor...@netronome.com wrote: >Add support for matching on ICMP type and code to flower. This is modeled >on existing support for matching on L4 ports. > >The second patch provided a minor cleanup which is in keeping with >they style used in the last patch.

Re: [PATCH net-next] bpf, xdp: drop rcu_read_lock from bpf_prog_run_xdp and move to caller

From: Daniel Borkmann Date: Wed, 30 Nov 2016 22:16:06 +0100 > After 326fe02d1ed6 ("net/mlx4_en: protect ring->xdp_prog with rcu_read_lock"), > the rcu_read_lock() in bpf_prog_run_xdp() is superfluous, since callers > need to hold rcu_read_lock() already to make sure BPF

Re: [PATCH net v2] igb: re-assign hw address pointer on reset after PCI error

On Fri, 2016-12-02 at 10:55 -0200, Guilherme G. Piccoli wrote: > On 11/10/2016 04:46 PM, Guilherme G. Piccoli wrote: > > Whenever the igb driver detects the result of a read operation > > returns > > a value composed only by F's (like 0x), it will detach the > > net_device, clear the

Re: [flamebait] xdp, well meaning but pointless

On Fri, Dec 2, 2016 at 3:54 AM, Hannes Frederic Sowa wrote: > On 02.12.2016 11:24, Jesper Dangaard Brouer wrote: >> On Thu, 1 Dec 2016 13:51:32 -0800 >> Tom Herbert wrote: >> > The technical plenary at last IETF on Seoul a couple of weeks ago

Re: [PATCH/RFC iproute2/net-next 2/3] tc: flower: introduce enum flower_endpoint

Fri, Dec 02, 2016 at 10:59:44AM CET, simon.hor...@netronome.com wrote: >Introduce enum flower_endpoint and use it instead of a bool >as the type for paramatising source and destination. > >This is intended to improve read-ability and provide some type >checking of endpoint parameters. >

Re: [PATCH/RFC iproute2/net-next 3/3] tc: flower: support matching on ICMP type and code

Fri, Dec 02, 2016 at 10:59:45AM CET, simon.hor...@netronome.com wrote: >Support matching on ICMP type and code. > >Example usage: > >tc qdisc add dev eth0 ingress > >tc filter add dev eth0 protocol ip parent : flower \ > indev eth0 ip_proto icmp type 8 code 0 action drop > >tc filter add

Re: Initial thoughts on TXDP

On 01/12/16 23:46, Tom Herbert wrote: > The only time we > _really_ to allocate an skbuf is when we need to put the packet onto a > queue. All the other use cases are really just to pass a structure > containing a packet from function to function. For that purpose we > should be able to just pass

Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v3

On Thu, 01 Dec 2016 23:17:48 +0100 Paolo Abeni wrote: > On Thu, 2016-12-01 at 18:34 +0100, Jesper Dangaard Brouer wrote: > > (Cc. netdev, we might have an issue with Paolo's UDP accounting and > > small socket queues) > > > > On Wed, 30 Nov 2016 16:35:20 + > > Mel Gorman

Re: net/can: warning in raw_setsockopt/__alloc_pages_slowpath

On 12/02/2016 04:11 PM, Oliver Hartkopp wrote: > > > On 12/02/2016 02:24 PM, Marc Kleine-Budde wrote: >> On 12/02/2016 01:43 PM, Andrey Konovalov wrote: > > >>> [] raw_setsockopt+0x1be/0x9f0 net/can/raw.c:506 >> >> We should add a check for a sensible optlen >> >>> static int

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

Hi Alex On 12/2/2016 3:26 PM, Alexandre Torgue wrote: 4.4 has no GMAC4 support. Alex, do you remember any patches to fix that? No sorry Peppe. Pavel, Sorry but I'm a little bit confused. I'm dropped in some mails without historic. I see cleanup, coalescence issue and TSO question. What is

[PATCH] net: phy: dp83848: Support ethernet pause frames

According to the documentation, the PHYs supported by this driver can also support pause frames. Announce this to be so. Tested with a TI83822I. Signed-off-by: Jesper Nilsson --- drivers/net/phy/dp83848.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH] net: phy: dp83848: Support ethernet pause frames

On Fri, Dec 02, 2016 at 08:35:23AM -0600, Andrew F. Davis wrote: > On 12/02/2016 08:22 AM, Jesper Nilsson wrote: > > According to the documentation, the PHYs supported by this driver > > can also support pause frames. Announce this to be so. > > Tested with a TI83822I. > > > > Looks like all

Re: [PATCH] net/rtnetlink: fix attribute name in nlmsg_size() comments

From: Tobias Klauser Date: Wed, 30 Nov 2016 14:30:37 +0100 > Use the correct attribute constant names IFLA_GSO_MAX_{SEGS,SIZE} > instead of IFLA_MAX_GSO_{SEGS,SIZE} for the comments int nlmsg_size(). > > Cc: Eric Dumazet > Signed-off-by: Tobias Klauser

Re: [PATCH net-next] sock: reset sk_err for ICMP packets read from error queue

From: Soheil Hassas Yeganeh Date: Wed, 30 Nov 2016 14:01:08 -0500 > From: Soheil Hassas Yeganeh > > Only when ICMP packets are enqueued onto the error queue, > sk_err is also set. Before f5f99309fa74 (sock: do not set sk_err > in sock_dequeue_err_skb),

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

Hi Pavel and Peppe, On 12/02/2016 02:51 PM, Giuseppe CAVALLARO wrote: On 12/2/2016 1:32 PM, Pavel Machek wrote: Hi! Well, if you have a workload that sends and receive packets, it tends to work ok, as you do tx_clean() in stmmac_poll(). My workload is not like that -- it is "sending packets

Re: [PATCH] net: phy: dp83848: Support ethernet pause frames

On 12/02/2016 08:22 AM, Jesper Nilsson wrote: > According to the documentation, the PHYs supported by this driver > can also support pause frames. Announce this to be so. > Tested with a TI83822I. > Looks like all PHYs supported by this driver do, so: Acked-by: Andrew F. Davis >

Re: [PATCH net v2] tcp: warn on bogus MSS and try to amend it

On Fri, 2016-12-02 at 08:55 -0200, Marcelo Ricardo Leitner wrote: > There have been some reports lately about TCP connection stalls caused > by NIC drivers that aren't setting gso_size on aggregated packets on rx > path. This causes TCP to assume that the MSS is actually the size of the >

Re: [PATCH 0/2] net: Add support for SGMII PCS on Altera TSE MAC

From: Neill Whillans Date: Wed, 30 Nov 2016 13:41:03 + > These patches were created as part of work to add support for SGMII > PCS functionality to the Altera TSE MAC. Patches are based on 4.9-rc6 > git tree. > > The first patch in the series adds support for

<    1   2   3   4   >