[PATCH V2 net 01/20] net/ena: remove ntuple filter support from device feature list

Remove NETIF_F_NTUPLE from netdev->features. The ENA device driver does not support ntuple filtering. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: Regression: [PATCH] mlx4: give precise rx/tx bytes/packets counters

On Thu, Dec 1, 2016 at 7:08 PM, Eric Dumazet wrote: > On Thu, 2016-12-01 at 18:33 +0200, Saeed Mahameed wrote: > >> Thanks for the detailed answer !! > > You're welcome. > >> >> BTW you went 5 steps ahead of my original question :)), so far you >> already have a patch

[PATCH V2 net 07/20] net/ena: refactor ena_get_stats64 to be atomic context safe

ndo_get_stat64 can be called from atomic context. However the current implementation sends an admin command to retrieve the statistics from the device. This admin commands uses sleep. Refactor the implementation of ena_get_stats64 to take the {rx,tx}bytes/cnt from the driver's inner counters and

[PATCH V2 net 14/20] net/ena: change condition for host attribute configuration

Move the host info config to be the first admin command that is executed. This change require the driver to remove the 'feature check' from host info configuration flow. The check is removed since the supported features bitmask field is retrieved only after calling ENA_ADMIN_DEVICE_ATTRIBUTES

[PATCH V2 net 10/20] net/ena: remove redundant logic in napi callback for busy poll mode

sk_busy_loop can call the napi callback few million times a sec. For each call there is unmask interrupt. We want to reduce the number of unmasks. Add an atomic variable that will tell the napi handler if it was called from irq context or not. Unmask the interrupt only from irq context. A

[PATCH V2 net 13/20] net/ena: change driver's default timeouts

Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c| 4 ++-- drivers/net/ethernet/amazon/ena/ena_netdev.h | 7 --- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c

[PATCH V2 net 12/20] net/ena: reduce the severity of ena printouts

Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c| 27 +-- drivers/net/ethernet/amazon/ena/ena_netdev.c | 14 +++--- 2 files changed, 28 insertions(+), 13 deletions(-) diff --git

[PATCH V2 net 16/20] net/ena: use napi_schedule_irqoff when possible

Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c index 8c1e14b..6c49529

Re: Regression: [PATCH] mlx4: give precise rx/tx bytes/packets counters

On Thu, Dec 1, 2016 at 7:36 PM, Eric Dumazet wrote: > On Thu, 2016-12-01 at 08:08 -0800, Eric Dumazet wrote: >> On Thu, 2016-12-01 at 07:55 -0800, Eric Dumazet wrote: >> >> > So removing the spinlock is doable, but needs to add a new parameter >> > to

[PATCH V2 net 06/20] net/ena: fix NULL dereference when removing the driver after device reset faild

If for some reason the device stop responding and the device reset failed to recover the device, the mmio register read datastructure will not be reinitialized. On driver removal, the driver will also tries to reset the device but this time the mmio data structure will be NULL. To solve this

[PATCH V2 net 17/20] net/ena: add IPv6 extended protocols to ena_admin_flow_hash_proto

We intend to use those fields in the future. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_admin_defs.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/amazon/ena/ena_admin_defs.h

[PATCH V2 net 11/20] net/ena: use READ_ONCE to access completion descriptors

Completion descriptors are accessed from the driver and from the device. To avoid reading the old value, use READ_ONCE macro. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.h | 1 + drivers/net/ethernet/amazon/ena/ena_eth_com.c | 8

[PATCH V2 net 09/20] net/ena: fix potential access to freed memory during device reset

If the ena driver detects that the device is not behave as expected, it tries to reset the device. The reset flow calls ena_down, which will frees all the resources the driver allocates and then it will reset the device. This flow can cause memory corruption if the device is still writes to the

[PATCH V2 net 15/20] net/ena: change sizeof() argument to be the type pointer

Instead of using: memset(ptr, 0x0, sizeof(struct ...)) use: memset(ptr, 0x0, sizeor(*ptr)) Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH V2 net 08/20] net/ena: add hardware hints capability to the driver

The ENA device can update the ena driver about the desire timeouts. The hardware hints are transmitted as Asynchronous event to the driver. In case the device does not support this capability, the driver will use its own defines. Signed-off-by: Netanel Belgazal ---

[PATCH V2 net 05/20] net/ena: fix RSS default hash configuration

ENA default hash configure IPv4_frag hash twice instead of configure non ip packets. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH V2 net 19/20] net/ena: restructure skb allocation

To increase readability, refactor skb allocation to dedicated function This change does not impact the performance since the compiler optimize the code and elimitate the if condition. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c |

[PATCH V2 net 20/20] net/ena: increase driver version to 1.1.2

Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h b/drivers/net/ethernet/amazon/ena/ena_netdev.h index ed42e07..de1e5ac

[PATCH V2 net 18/20] net/ena: remove affinity hint from the driver

To allow irqbalance to better distribute the napi handler, remove the smp affinity hint from the driver. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration

ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type treat the ena_flow_hash_to_flow_type enum as power of two values. Change the values of ena_admin_flow_hash_fields to be power of two values. Signed-off-by: Netanel Belgazal ---

Re: [PATCN net-next] net_sched: gen_estimator: complete rewrite of rate estimators

Hi Eric, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/net_sched-gen_estimator-complete-rewrite-of-rate-estimators/20161204-185201 reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/sock.h:467: w

Trigger EHOSTUNREACH

Hallo everyone, hope you are having a good day we are building a networking testing tool to simulate network error condition, and we are having difficulties triggering the EHOSTUNREACH socket error. We are trying to trigger this error by sending an ICMP packet type=3 code=3 on an open STREAM

RE: [PATCH 1/1] net: ethernet: broadcom: fix improper return value

> From: Pan Bian > > Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate > memory, and jumps to label "lbl" if the allocation fails. Label "lbl" > first cleans memory and then returns variable rc. Before calling the macro, > the > value of variable rc is

Auditor General Office

Mr.Malaki Ahmed Auditor General Office Attn, I feel quite safe dealing with you in this important business. Though this medium (Internet) has been greatly abused, I choose to reach you through it because it still remains the fastest medium of communication. However, this correspondence is

Re: [PATCN v2 net-next] net_sched: gen_estimator: complete rewrite of rate estimators

Hi Eric, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/net_sched-gen_estimator-complete-rewrite-of-rate-estimators/20161204-182009 reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/sock.h:467: w

[PATCH 1/1] net: qed: set error code on failure

From: Pan Bian When calling dma_mapping_error(), the value of return variable rc is 0. And when the call returns an unexpected value, rc is not set to a negative errno. Thus, it will return 0 on the error path, and its callers cannot detect the bug. This patch fixes the bug,

[PATCH net 5/6] net/mlx5e: Don't flush SQ on error

We are doing SQ descriptors cleanup in driver. Fixes: 6e8dd6d6f4bd ("net/mlx5e: Don't wait for SQ completions on close") Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH net 0/6] Mellanox 100G mlx5 fixes 2016-12-04

Hi Dave, Some bug fixes for mlx5 core and mlx5e driver. Thanks, Saeed. Kamal Heib (3): net/mlx5: Verify module parameters net/mlx5: Remove duplicate pci dev name print net/mlx5: Fix query ISSI flow Mohamad Haj Yahia (1): net/mlx5e: Change the SQ/RQ operational state to positive logic

[PATCH net 1/6] net/mlx5: Verify module parameters

From: Kamal Heib Verify the mlx5_core module parameters by making sure that they are in the expected range and if they aren't restore them to their default values. Fixes: 9603b61de1ee ('mlx5: Move pci device handling from mlx5_ib to mlx5_core') Signed-off-by: Kamal Heib

[PATCH net 2/6] net/mlx5: Remove duplicate pci dev name print

From: Kamal Heib Remove duplicate pci dev name printing from mlx5_core_warn/dbg. Fixes: 5a7883989b1c ('net/mlx5_core: Improve mlx5 messages') Signed-off-by: Kamal Heib Signed-off-by: Saeed Mahameed ---

[PATCH net 6/6] net/mlx5e: Change the SQ/RQ operational state to positive logic

From: Mohamad Haj Yahia When using the negative logic (i.e. FLUSH state), after the RQ/SQ reopen we will have a time interval that the RQ/SQ is not really ready and the state indicates that its not in FLUSH state because the initial SQ/RQ struct memory starts as zeros. Now

[PATCH net 4/6] net/mlx5e: Don't notify HW when filling the edge of ICO SQ

We are going to do this a couple of steps ahead anyway. Fixes: d3c9bc2743dc ("net/mlx5e: Added ICO SQs") Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net 3/6] net/mlx5: Fix query ISSI flow

From: Kamal Heib In old FWs query ISSI command is not supported and for some of those FWs it might fail with status other than "MLX5_CMD_STAT_BAD_OP_ERR". In such case instead of failing the driver load, we will treat any FW status other than 0 for Query ISSI FW command as

[PATCH 1/1 v2] net: bnx2x: fix improper return value

From: Pan Bian Macro BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate memory, and jumps to label "lbl" if the allocation fails. Label "lbl" first cleans memory and then returns variable rc. Before calling the macro, the value of variable rc is 0. Because 0

[PATCH 1/1 v2] isdn: hisax: set error code on failure

From: Pan Bian In function hfc4s8s_probe(), the value of return variable err should be negative on failures. However, when the call to request_region() returns NULL, the value of err is 0. This patch fixes the bug, assigning "-EBUSY" to err on the path that request_region()

[PATCH 1/1] net: bnx2x: fix improper return value

From: Pan Bian Macro BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate memory, and jumps to label "lbl" if the allocation fails. Label "lbl" first cleans memory and then returns variable rc. Before calling the macro, the value of variable rc is 0. Because 0

Re: [PATCH 1/1] isdn: hisax: set error code on failure

On 12/4/2016 1:33 PM, Pan Bian wrote: You now need to indicate the patch version in hte subject, like this: [PATCH 1/1 v2] isdn:... From: Pan Bian In function hfc4s8s_probe(), the value of return variable err should be negative on failures. However, when the call to

[PATCH 1/1] isdn: hisax: set error code on failure

From: Pan Bian In function hfc4s8s_probe(), the value of return variable err should be negative on failures. However, when the call to request_region() returns NULL, the value of err is 0. This patch fixes the bug, assiging "-EBUSY" to err on the path that request_region()

Re: [PATCH 1/1] net: bnx2x: fix improper return value

On 12/4/2016 11:39 AM, Pan Bian wrote: From: Pan Bian Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate Macro. memory, and jumps to label "lbl" if the allocation fails. Label "lbl" first cleans memory and then returns variable rc. Before calling

Re: [PATCH 1/1] isdn: hisax: set error code on failure

Hello. On 12/4/2016 8:15 AM, Pan Bian wrote: From: Pan Bian In function hfc4s8s_probe(), the value of return variable err should be negative on failures. However, when the call to request_region() returns NULL, the value of err is 0. This patch fixes the bug, assiging

[PATCH 1/1] net: bnx2x: fix improper return value

From: Pan Bian Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate memory, and jumps to label "lbl" if the allocation fails. Label "lbl" first cleans memory and then returns variable rc. Before calling the macro, the value of variable rc is 0. Because 0

<    1   2