[PATCH v4 05/13] net: ethernet: ti: cpts: fix registration order

2016-12-05 Thread Grygorii Strashko
The ptp clock registered before spinlock, which is protecting it, and before timecounter and cyclecounter initialization in cpts_register(). So, ensure that ptp clock is registered the last, after everything else is done. Signed-off-by: Grygorii Strashko Acked-by:

Re: [PATCH V3 net-next] net: hns: Fix to conditionally convey RX checksum flag to stack

2016-12-05 Thread kbuild test robot
Hi Salil, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Salil-Mehta/net-hns-Fix-to-conditionally-convey-RX-checksum-flag-to-stack/20161206-022948 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901

Re: [PATCH net 0/2] bnx2x: fixes series

2016-12-05 Thread David Miller
From: Yuval Mintz Date: Sun, 4 Dec 2016 15:30:16 +0200 > Two unrelated fixes for bnx2x - the first one is nice-to-have, > while the other fixes fatal behaviour in older adapters. > > Please consider applying them to `net'. Series applied, thanks.

Re: [PATCH 0/5] cpsw: add per channel shaper configuration

2016-12-05 Thread Grygorii Strashko
Hi Ivan, On 11/29/2016 09:00 AM, Ivan Khoronzhuk wrote: > This series is intended to allow user to set rate for per channel > shapers at cpdma level. This patchset doesn't have impact on performance. > The rate can be set with: > > echo 100 > /sys/class/net/ethX/queues/tx-0/tx_maxrate > >

Re: [PATCH net] net: ep93xx_eth: Do not crash unloading module

2016-12-05 Thread David Miller
From: Florian Fainelli Date: Sun, 4 Dec 2016 19:22:05 -0800 > When we unload the ep93xx_eth, whether we have opened the network > interface or not, we will either hit a kernel paging request error, or a > simple NULL pointer de-reference because: > > - if ep93xx_open has

Re: [PATCH 1/1] net: caif: remove ineffective check

2016-12-05 Thread David Miller
From: Pan Bian Date: Sun, 4 Dec 2016 12:15:44 +0800 > The check of the return value of sock_register() is ineffective. > "if(!err)" seems to be a typo. It is better to propagate the error code > to the callers of caif_sktinit_module(). This patch removes the check >

Re: [PATCH 1/1] net: ethernet: qlogic: set error code on failure

2016-12-05 Thread David Miller
From: "Mintz, Yuval" Date: Sun, 4 Dec 2016 07:29:58 + >> From: Pan Bian >> >> When calling dma_mapping_error(), the value of return variable rc is 0. >> And when the call returns an unexpected value, rc is not set to a negative >> errno. Thus,

[PATCH v4 02/13] net: ethernet: ti: allow cpts to be built separately

2016-12-05 Thread Grygorii Strashko
TI CPTS IP is used as part of TI OMAP CPSW driver, but it's also present as part of NETCP on TI Keystone 2 SoCs. So, It's required to enable build of CPTS for both this drivers and this can be achieved by allowing CPTS to be built separately. Hence, allow cpts to be built separately and convert

Re: [PATCH net 1/6] net/mlx5: Verify module parameters

2016-12-05 Thread David Miller
From: Saeed Mahameed Date: Sun, 4 Dec 2016 12:56:11 +0200 > +static uint prof_sel = MLX5_DEFAULT_PROF; Please do not use type shorthands such as "uint", always expand fully "unsigned int". Thanks.

Re: [mm PATCH 0/3] Page fragment updates

2016-12-05 Thread Andrew Morton
On Mon, 5 Dec 2016 09:01:12 -0800 Alexander Duyck wrote: > On Tue, Nov 29, 2016 at 10:23 AM, Alexander Duyck > wrote: > > This patch series takes care of a few cleanups for the page fragments API. > > > > ... > > It's been about a week

[PATCH v4 12/13] net: ethernet: ti: cpts: calc mult and shift from refclk freq

2016-12-05 Thread Grygorii Strashko
The cyclecounter mult and shift values can be calculated based on the CPTS rfclk frequency and timekeepnig framework provides required algos and API's. Hence, calc mult and shift basing on CPTS rfclk frequency if both cpts_clock_shift and cpts_clock_mult properties are not provided in DT (the

[PATCH v4 10/13] net: ethernet: ti: cpts: move dt props parsing to cpts driver

2016-12-05 Thread Grygorii Strashko
Move DT properties parsing into CPTS driver to simplify CPSW code and CPTS driver porting on other SoC in the future (like Keystone 2) - with this change it will not be required to add the same DT parsing code in Keystone 2 NETCP driver. Signed-off-by: Grygorii Strashko

[PATCH v4 13/13] net: ethernet: ti: cpts: fix overflow check period

2016-12-05 Thread Grygorii Strashko
The CPTS drivers uses 8sec period for overflow checking with assumption that CPTS retclk will not exceed 500MHz. But that's not true on some TI platforms (Kesytone 2). As result, it is possible that CPTS counter will overflow more than once between two readings. Hence, fix it by selecting

[PATCH v4 06/13] net: ethernet: ti: cpts: disable cpts when unregistered

2016-12-05 Thread Grygorii Strashko
The cpts now is left enabled after unregistration. Hence, disable it in cpts_unregister(). Signed-off-by: Grygorii Strashko Acked-by: Richard Cochran --- drivers/net/ethernet/ti/cpts.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v4 07/13] net: ethernet: ti: cpts: clean up event list if event pool is empty

2016-12-05 Thread Grygorii Strashko
From: WingMan Kwok When a CPTS user does not exit gracefully by disabling cpts timestamping and leaving a joined multicast group, the system continues to receive and timestamps the ptp packets which eventually occupy all the event list entries. When this happns, the added code

[PATCH v4 01/13] net: ethernet: ti: cpts: switch to readl/writel_relaxed()

2016-12-05 Thread Grygorii Strashko
Switch to readl/writel_relaxed() APIs, because this is recommended API and the CPTS IP is reused on Keystone 2 SoCs where LE/BE modes are supported. Signed-off-by: Grygorii Strashko Acked-by: Richard Cochran --- drivers/net/ethernet/ti/cpts.c

[PATCH v4 03/13] net: ethernet: ti: cpsw: minimize direct access to struct cpts

2016-12-05 Thread Grygorii Strashko
This will provide more flexibility in changing CPTS internals and also required for further changes. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 28 +++- drivers/net/ethernet/ti/cpts.h | 39

[PATCH v4 11/13] clocksource: export the clocks_calc_mult_shift to use by timestamp code

2016-12-05 Thread Grygorii Strashko
From: Murali Karicheri The CPSW CPTS driver is capable of doing timestamping on tx/rx packets and requires to know mult and shift factors for timestamp conversion from raw value to nanoseconds (ptp clock). Now these mult and shift factors are calculated manually and provided

[PATCH v4 00/13] net: ethernet: ti: cpts: update and fixes

2016-12-05 Thread Grygorii Strashko
It is preparation series intended to clean up and optimize TI CPTS driver to facilitate further integration with other TI's SoCs like Keystone 2. Changes in v4: - fixed build error in patch "net: ethernet: ti: cpts: clean up event list if event pool is empty" - rebased on top of net-next

Re: [PATCH net-next 0/3] Minor BPF cleanups and digest

2016-12-05 Thread David Miller
From: Daniel Borkmann Date: Sun, 4 Dec 2016 23:19:38 +0100 > First two patches are minor cleanups, and the third one adds > a prog digest. For details, please see individual patches. > After this one, I have a set with tracepoint support that makes > use of this facility

Re: [PATCH 0/5] cpsw: add per channel shaper configuration

2016-12-05 Thread Ivan Khoronzhuk
On Mon, Dec 05, 2016 at 02:33:40PM -0600, Grygorii Strashko wrote: > Hi Ivan, > > On 11/29/2016 09:00 AM, Ivan Khoronzhuk wrote: > > This series is intended to allow user to set rate for per channel > > shapers at cpdma level. This patchset doesn't have impact on performance. > > The rate can be

Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read

2016-12-05 Thread David Miller
From: Grygorii Strashko Date: Mon, 5 Dec 2016 12:47:16 -0600 > > > On 12/02/2016 08:05 PM, Ivan Khoronzhuk wrote: >> There is desc_read() macros to read desc fields, so no need to >> use __raw_readl(); >> >> Signed-off-by: Ivan Khoronzhuk

Re: [PATCH 1/1] net: irda: set error code on failures

2016-12-05 Thread David Miller
From: Pan Bian Date: Sun, 4 Dec 2016 13:27:40 +0800 > From: Pan Bian > > When the calls to kzalloc() fail, the value of return variable ret may > be 0. 0 means success in this context. This patch fixes the bug, > assigning "-ENOMEM" to ret before

Re: [PATCH 1/1 v2] isdn: hisax: set error code on failure

2016-12-05 Thread David Miller
From: Pan Bian Date: Sun, 4 Dec 2016 18:43:31 +0800 > From: Pan Bian > > In function hfc4s8s_probe(), the value of return variable err should be > negative on failures. However, when the call to request_region() returns > NULL, the value of err is

[PATCH net v4] tcp: warn on bogus MSS and try to amend it

2016-12-05 Thread Marcelo Ricardo Leitner
There have been some reports lately about TCP connection stalls caused by NIC drivers that aren't setting gso_size on aggregated packets on rx path. This causes TCP to assume that the MSS is actually the size of the aggregated packet, which is invalid. Although the proper fix is to be done at

Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Florian Westphal
Eric Dumazet wrote: > On Mon, 2016-12-05 at 15:28 -0500, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Add support for attaching an eBPF object by file descriptor. > > > > The iptables binary can be called with a path to an elf object or

Re: [PATCH 1/1] net: ethernet: broadcom: fix improper return value

2016-12-05 Thread David Miller
From: Pan Bian Date: Sun, 4 Dec 2016 14:29:29 +0800 > From: Pan Bian > > Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate > memory, and jumps to label "lbl" if the allocation fails. Label "lbl" > first cleans memory and then

Re: [PATCH v3 net-next] net_sched: gen_estimator: complete rewrite of rate estimators

2016-12-05 Thread David Miller
From: Eric Dumazet Date: Sun, 04 Dec 2016 09:48:16 -0800 > From: Eric Dumazet > > 1) Old code was hard to maintain, due to complex lock chains. >(We probably will be able to remove some kfree_rcu() in callers) > > 2) Using a single timer to

[PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Willem de Bruijn
From: Willem de Bruijn Add support for attaching an eBPF object by file descriptor. The iptables binary can be called with a path to an elf object or a pinned bpf object. Also pass the mode and path to the kernel to be able to return it later for iptables dump and save.

Re: [PATCH] net: calxeda: xgmac: use new api ethtool_{get|set}_link_ksettings

2016-12-05 Thread David Miller
From: Philippe Reynes Date: Sun, 4 Dec 2016 23:37:53 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH v2 net-next v2 3/4] net: dsa: mv88e6xxx: add a soft reset operation

2016-12-05 Thread Stefan Eichenberger
Hi Vivien On Mon, Dec 05, 2016 at 11:27:02AM -0500, Vivien Didelot wrote: > static const struct mv88e6xxx_ops mv88e6097_ops = { > @@ -3285,6 +3266,7 @@ static const struct mv88e6xxx_ops mv88e6097_ops = { > .g1_set_cpu_port = mv88e6095_g1_set_cpu_port, > .g1_set_egress_port =

Re: [PATCH v2 net-next 3/4] mlx4: xdp: Reserve headroom for receiving packet when XDP prog is active

2016-12-05 Thread Martin KaFai Lau
On Mon, Dec 05, 2016 at 02:54:06AM +0200, Saeed Mahameed wrote: > On Sun, Dec 4, 2016 at 5:17 AM, Martin KaFai Lau wrote: > > Reserve XDP_PACKET_HEADROOM and honor bpf_xdp_adjust_head() > > when XDP prog is active. This patch only affects the code > > path when XDP is active. > > >

[PATCH v4 09/13] net: ethernet: ti: cpts: rework initialization/deinitialization

2016-12-05 Thread Grygorii Strashko
The current implementation CPTS initialization and deinitialization (represented by cpts_register/unregister()) does too many static initialization from .ndo_open(), which is reasonable to do once at probe time instead, and also require caller to allocate memory for struct cpts, which is internal

[PATCH v4 04/13] net: ethernet: ti: cpts: fix unbalanced clk api usage in cpts_register/unregister

2016-12-05 Thread Grygorii Strashko
There are two issues with TI CPTS code which are reproducible when TI CPSW ethX device passes few up/down iterations: - cpts refclk prepare counter continuously incremented after each up/down iteration; - devm_clk_get(dev, "cpts") is called many times. Hence, fix these issues by using

[PATCH v4 08/13] net: ethernet: ti: cpts: drop excessive writes to CTRL and INT_EN regs

2016-12-05 Thread Grygorii Strashko
CPTS module and IRQs are always enabled when CPTS is registered, before starting overflow check work, and disabled during deregistration, when overflow check work has been canceled already. So, It doesn't require to (re)enable CPTS module and IRQs in cpts_overflow_check(). Signed-off-by: Grygorii

Re: [PATCH net-next] net/sched: cls_flower: Set the filter Hardware device for all use-cases

2016-12-05 Thread David Miller
From: Hadar Hen Zion Date: Sun, 4 Dec 2016 15:25:19 +0200 > Check if the returned device from tcf_exts_get_dev function supports tc > offload and in case the rule can't be offloaded, set the filter hw_dev > parameter to the original device given by the user. > > The filter

Re: [PATCH v2 net-next v2 4/4] net: dsa: mv88e6xxx: add PPU operations

2016-12-05 Thread Stefan Eichenberger
Hi Vivien, On Mon, Dec 05, 2016 at 11:27:03AM -0500, Vivien Didelot wrote: > @@ -3266,6 +3220,8 @@ static const struct mv88e6xxx_ops mv88e6097_ops = { > .g1_set_cpu_port = mv88e6095_g1_set_cpu_port, > .g1_set_egress_port = mv88e6095_g1_set_egress_port, > .mgmt_rsvd2cpu =

Re: [PATCH net v2] ipv6: Allow IPv4-mapped address as next-hop

2016-12-05 Thread David Miller
From: Erik Nordmark Date: Sat, 3 Dec 2016 20:57:09 -0800 > Made kernel accept IPv6 routes with IPv4-mapped address as next-hop. > > It is possible to configure IP interfaces with IPv4-mapped addresses, and > one can add IPv6 routes for IPv4-mapped destinations/prefixes,

Re: [PATCH 1/1] atm: fix improper return value

2016-12-05 Thread David Miller
From: Pan Bian Date: Sun, 4 Dec 2016 13:45:15 +0800 > From: Pan Bian > > It returns variable "error" when ioremap_nocache() returns a NULL > pointer. The value of "error" is 0 then, which will mislead the callers > to believe that there is no error.

Re: [net PATCH 2/2] ipv4: Drop suffix update from resize code

2016-12-05 Thread Robert Shearman
On 05/12/16 17:28, David Miller wrote: From: Robert Shearman Date: Mon, 5 Dec 2016 15:05:18 + On 01/12/16 12:27, Alexander Duyck wrote: It has been reported that update_suffix can be expensive when it is called on a large node in which most of the suffix lengths are

Re: [PATCH net-next 0/3] net: ethoc: Misc improvements

2016-12-05 Thread David Miller
From: Florian Fainelli Date: Sun, 4 Dec 2016 12:40:27 -0800 > This patch series fixes/improves a few things: > > - implement a proper PHYLIB adjust_link callback to set the duplex mode > accordingly > - do not open code the fetching of a MAC address in OF/DT

Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Eric Dumazet
On Mon, 2016-12-05 at 15:28 -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > Add support for attaching an eBPF object by file descriptor. > > The iptables binary can be called with a path to an elf object or a > pinned bpf object. Also pass the mode and path to

[PATCH] net: stmmac: clear reset value of snps,wr_osr_lmt/snps,rd_osr_lmt before writing

2016-12-05 Thread Niklas Cassel
From: Niklas Cassel WR_OSR_LMT and RD_OSR_LMT have a reset value of 1. Since the reset value wasn't cleared before writing, the value in the register would be incorrect if specifying an uneven value for snps,wr_osr_lmt/snps,rd_osr_lmt. Zero is a valid value for the

Re: [patch net v2] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread David Miller
From: Nikita Yushchenko Date: Mon, 5 Dec 2016 16:55:04 +0300 > Aieee I was typing too fast today, sorry... > > send separate "fix for the fix", or re-send patch without that silly typo? If the patch hasn't been applied yet, you resend a fixed version of the

Re: [PATCH v2 net-next 1/2] flow dissector: ICMP support

2016-12-05 Thread Tom Herbert
On Mon, Dec 5, 2016 at 6:23 AM, Simon Horman wrote: > On Sat, Dec 03, 2016 at 10:52:32AM -0800, Tom Herbert wrote: >> On Sat, Dec 3, 2016 at 2:49 AM, Jiri Pirko wrote: >> > Fri, Dec 02, 2016 at 09:31:41PM CET, simon.hor...@netronome.com wrote: >>

Re: [iproute PATCH v2 08/18] ss: Turn generic_proc_open() wrappers into macros

2016-12-05 Thread Phil Sutter
On Mon, Dec 05, 2016 at 05:02:20PM +, David Laight wrote: > From: Phil Sutter > > Sent: 02 December 2016 10:40 > > Signed-off-by: Phil Sutter > > --- > > misc/ss.c | 89 > > ++- > > 1 file changed, 19 insertions(+), 70

Re: [PATCH net-next v2 0/4] bnxt_en: Add DCBNL support.

2016-12-05 Thread David Miller
From: Michael Chan Date: Fri, 2 Dec 2016 21:17:14 -0500 > This series adds DCBNL operations to support host-based IEEE DCBX. > > v2: Updated to the latest firmware interface spec. > > David, please consider this series for net-next. Series applied, thanks.

Re: [PATCH V2 net 02/20] net/ena: fix error handling when probe fails

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:09 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:20PM +0200, Netanel Belgazal wrote: When driver fails in probe, it will release all resources, including adapter. In case of probe failure, ena_remove should not try to free the adapter resources. Please word wrap your

Re: [PATCH v2 net-next 0/4]: Allow head adjustment in XDP prog

2016-12-05 Thread Jesper Dangaard Brouer
On Mon, 5 Dec 2016 17:53:02 + Jakub Kicinski wrote: > On Sat, 3 Dec 2016 19:17:22 -0800, Martin KaFai Lau wrote: > > This series adds a helper to allow head adjusting in XDP prog. mlx4 > > driver has been modified to support this feature. An example is written > > to

Re: [PATCH V2 net 03/20] net/ena: fix queues number calculation

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:11 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:21PM +0200, Netanel Belgazal wrote: The ENA driver tries to open a queue per vCPU. To determine how many vCPUs the instance have it uses num_possible_cpus while it should have use num_online_cpus instead. use () when

Re: [ovs-dev] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit

2016-12-05 Thread Ben Pfaff
On Mon, Dec 05, 2016 at 06:24:36PM +0100, Michał Mirosław wrote: > On Sat, Dec 03, 2016 at 03:27:30PM -0800, Ben Pfaff wrote: > > On Sat, Dec 03, 2016 at 10:22:28AM +0100, Michał Mirosław wrote: > > > This All-in-one patch removes abuse of VLAN CFI bit, so it can be passed > > > intact through

Re: Trigger EHOSTUNREACH

2016-12-05 Thread Marco Zunino
Hi Neal, thank you! I can succesfully repoduce the following socket error now after setting the IP_RECVERR socket option: ICMP type=3, code=1 -> EHOSTUNREACH ICMP type=3, code=2 -> ENOPROTOOPT ICMP type=3, code=3 -> ECONNREFUSED ICMP type=3, code=4 -> No error ICMP type=3,

Re: [PATCH v2 net-next 0/8] tcp: tsq: performance series

2016-12-05 Thread David Miller
From: Eric Dumazet Date: Sat, 3 Dec 2016 11:14:49 -0800 > Under very high TX stress, CPU handling NIC TX completions can spend > considerable amount of cycles handling TSQ (TCP Small Queues) logic. > > This patch series avoids some atomic operations, but most notable >

Re: [net PATCH 0/2] IPv4 FIB suffix length fixes

2016-12-05 Thread David Miller
From: Alexander Duyck Date: Thu, 01 Dec 2016 07:27:47 -0500 > In reviewing the patch from Robert Shearman and looking over the code I > realized there were a few different bugs we were still carrying in the IPv4 > FIB lookup code. > > These two patches are based off

Re: [PATCH 0/8] irda: w83977af_ir: Neatening

2016-12-05 Thread Joe Perches
On Thu, 2016-11-24 at 11:10 -0800, Joe Perches wrote: > On top of Arnd's overly long udelay patch because I noticed a > misindented block. > > Even though I haven't turned on the netwinder in a box in in the > garage in who knows how long, if this device is still used somewhere, > might as well

Re: [PATCH v2] net: ping: check minimum size on ICMP header length

2016-12-05 Thread David Miller
From: Kees Cook Date: Mon, 5 Dec 2016 10:34:38 -0800 > Prior to commit c0371da6047a ("put iov_iter into msghdr") in v3.19, there > was no check that the iovec contained enough bytes for an ICMP header, > and the read loop would walk across neighboring stack contents. Since

[PATCH v2] net: ping: check minimum size on ICMP header length

2016-12-05 Thread Kees Cook
Prior to commit c0371da6047a ("put iov_iter into msghdr") in v3.19, there was no check that the iovec contained enough bytes for an ICMP header, and the read loop would walk across neighboring stack contents. Since the iov_iter conversion, bad arguments are noticed, but the returned error is

Re: [PATCH V2 net 10/20] net/ena: remove redundant logic in napi callback for busy poll mode

2016-12-05 Thread Eric Dumazet
On Mon, 2016-12-05 at 20:29 +0200, Netanel Belgazal wrote: > You are correct. > I didn't see the patches. > It is much better to use the napi_complete_done() return value. > I'll rework my patch. Excellent, please CC me on this particular work on the future. Thanks.

Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'

2016-12-05 Thread David Miller
From: Nicolas Pitre Date: Mon, 5 Dec 2016 10:44:32 -0500 (EST) > On Sat, 3 Dec 2016, David Miller wrote: > >> From: Arnd Bergmann >> Date: Sat, 3 Dec 2016 00:04:32 +0100 >> >> > ptp now depends on the optional POSIX_TIMERS setting and fails to build

Re: [net PATCH 2/2] ipv4: Drop suffix update from resize code

2016-12-05 Thread David Miller
From: Robert Shearman Date: Mon, 5 Dec 2016 15:05:18 + > On 01/12/16 12:27, Alexander Duyck wrote: >> It has been reported that update_suffix can be expensive when it is >> called >> on a large node in which most of the suffix lengths are the same. The >> time >>

Re: [patch net v2] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread David Miller
From: Nikita Yushchenko Date: Mon, 5 Dec 2016 20:26:52 +0300 >> From: Nikita Yushchenko >> Date: Mon, 5 Dec 2016 16:55:04 +0300 >> >>> Aieee I was typing too fast today, sorry... >>> >>> send separate "fix for the fix", or

Re: [net PATCH 2/2] ipv4: Drop suffix update from resize code

2016-12-05 Thread Duyck, Alexander H
On Mon, 2016-12-05 at 12:28 -0500, David Miller wrote: > From: Robert Shearman > Date: Mon, 5 Dec 2016 15:05:18 + > > > > > On 01/12/16 12:27, Alexander Duyck wrote: > > > > > > It has been reported that update_suffix can be expensive when it is > > > called > > > on

Re: commit : ppp: add rtnetlink device creation support - breaks netcf on my machine.

2016-12-05 Thread Guillaume Nault
On Mon, Dec 05, 2016 at 05:06:31PM +0800, Brad Campbell wrote: > Machine is an old Debian (7.11) box with a recent compile of netcf. Any > kernel later than 4.6.7 prevents ncftool from running if the ppp interface > is up. > > I'm using netcf-0.2.8, and this commit breaks it : > >

Re: [PATCH v2 net-next 0/4]: Allow head adjustment in XDP prog

2016-12-05 Thread Jakub Kicinski
On Sat, 3 Dec 2016 19:17:22 -0800, Martin KaFai Lau wrote: > This series adds a helper to allow head adjusting in XDP prog. mlx4 > driver has been modified to support this feature. An example is written > to encapsulate a packet with an IPv4/v6 header and then XDP_TX it > out. Can we just add a

Re: [patch net v3] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread Nikita Yushchenko
> +#define FEC_STATS_SIZE (ARRAY_SIZE(fec_stats) * sizeof(u64)) > > > Do I take it right this actually translates to (sizeof(fec_stats) / > sizeof(u64) * sizeof(u64))? No. fec_stats is an array of structs, each struct has car arrsy and integer, and size of that is definitely not

Re: [PATCH] net: ping: check minimum size on ICMP header length

2016-12-05 Thread David Miller
From: Kees Cook Date: Fri, 2 Dec 2016 16:58:53 -0800 > diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c > index 205e2000d395..8257be3f032c 100644 > --- a/net/ipv4/ping.c > +++ b/net/ipv4/ping.c > @@ -654,7 +654,7 @@ int ping_common_sendmsg(int family, struct msghdr *msg, >

Re: [PATCH 2/7] net: ethernet: ti: cpdma: fix desc re-queuing

2016-12-05 Thread Grygorii Strashko
On 12/02/2016 05:28 PM, Ivan Khoronzhuk wrote: > On Fri, Dec 02, 2016 at 10:45:07AM -0600, Grygorii Strashko wrote: >> >> >> On 12/02/2016 05:03 AM, Ivan Khoronzhuk wrote: >>> On Thu, Dec 01, 2016 at 05:34:27PM -0600, Grygorii Strashko wrote: The currently processing cpdma descriptor with

Re: [PATCH V2 net 08/20] net/ena: add hardware hints capability to the driver

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:31 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:26PM +0200, Netanel Belgazal wrote: The ENA device can update the ena driver about the desire timeouts. The hardware hints are transmitted as Asynchronous event to the driver. This is really a new feature, not a bugfix

Re: [PATCH v3 00/13] net: ethernet: ti: cpts: update and fixes

2016-12-05 Thread Grygorii Strashko
On 12/03/2016 03:22 AM, Richard Cochran wrote: On Fri, Dec 02, 2016 at 02:30:10PM -0600, Grygorii Strashko wrote: It is preparation series intended to clean up and optimize TI CPTS driver to facilitate further integration with other TI's SoCs like Keystone 2. Changes in v3: - patches

Re: [PATCH 0/8] irda: w83977af_ir: Neatening

2016-12-05 Thread David Miller
From: Joe Perches Date: Mon, 05 Dec 2016 10:16:41 -0800 > On Thu, 2016-11-24 at 11:10 -0800, Joe Perches wrote: >> On top of Arnd's overly long udelay patch because I noticed a >> misindented block. >> >> Even though I haven't turned on the netwinder in a box in in the >>

Re: [PATCH V2 net 05/20] net/ena: fix RSS default hash configuration

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:20 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:23PM +0200, Netanel Belgazal wrote: ENA default hash configure IPv4_frag hash twice instead of configure -> configures. You may want to include "erroneously". What is the consequence of this bug? I'll fix and I'll add

[patch net v3] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread Nikita Yushchenko
Commit 4dfb80d18d05 ("net: fec: cache statistics while device is down") introduced unconditional statistics-related actions. However, when driver is compiled with CONFIG_M5272, staticsics-related definitions do not exist, which results into build errors. Fix that by adding explicit handling of

Re: [PATCH net-next 2/4] mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs

2016-12-05 Thread Jakub Kicinski
On Sat, 3 Dec 2016 19:19:58 -0800, Martin KaFai Lau wrote: > AFAIK, only mlx4/5 supports XDP now. That is, unfortunately, not true. $ git checkout net-next/master $ git grep ndo_xdp drivers/ drivers/net/ethernet/mellanox/mlx4/en_netdev.c: .ndo_xdp= mlx4_xdp,

[PATCH resend 5/8] irda: w83977af_ir: Use the common brace style

2016-12-05 Thread Joe Perches
Add braces where appropriate and remove an unnecessary else. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c

[PATCH resend 2/8] irda: w83977af_ir: More whitespace neatening

2016-12-05 Thread Joe Perches
Add spaces around operators. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 232 - 1 file changed, 116 insertions(+), 116 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c

[PATCH resend 3/8] irda: w83977af_ir: Remove and add blank lines

2016-12-05 Thread Joe Perches
Use a more typical vertical spacing style. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 4ad91f4f867f..5aa61413aea8

[PATCH resend 8/8] irda: w83977af_ir: Fix misindented block

2016-12-05 Thread Joe Perches
One indent level too many is too many. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index

[PATCH resend 6/8] irda: w83977af_ir: Parenthesis alignment

2016-12-05 Thread Joe Perches
Neaten function declaration and definition arguments. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index

[PATCH resend 4/8] irda: w83977af_ir: Neaten pointer comparisons

2016-12-05 Thread Joe Perches
Convert pointer comparisons to NULL. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index

[PATCH resend 7/8] irda: w83977af_ir: Neaten logging

2016-12-05 Thread Joe Perches
Use more common logging style, standardize function output logging use. Miscellanea: o Add and use pr_fmt o Convert printks to pr_ Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 48 -- 1 file changed, 23 insertions(+),

[PATCH resend 1/8] irda: w83977af_ir: whitespace neatening

2016-12-05 Thread Joe Perches
Remove leading and trailing whitespace. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 392 - 1 file changed, 196 insertions(+), 196 deletions(-) diff --git

Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

2016-12-05 Thread Richard Cochran
On Mon, Dec 05, 2016 at 12:25:57PM -0600, Grygorii Strashko wrote: > >> --- a/Documentation/devicetree/bindings/net/keystone-netcp.txt > >> +++ b/Documentation/devicetree/bindings/net/keystone-netcp.txt > >> @@ -113,6 +113,15 @@ Optional properties: > >>will only

Re: [PATCH iproute2/net-next v3 0/3] tc: flower: SCTP and other port fixes

2016-12-05 Thread Stephen Hemminger
On Sat, 3 Dec 2016 09:52:37 +0100 Simon Horman wrote: > Hi Stephen, > > this short series: > > * Makes some improvements to the documentation of flower; > A follow-up to recent work by Paul Blakey and myself. > * Corrects some errors introduced when SCTP port

Re: [PATCH v2] net: phy: dp83848: Support ethernet pause frames

2016-12-05 Thread David Miller
From: Jesper Nilsson Date: Fri, 2 Dec 2016 15:57:49 +0100 > According to the documentation, the PHYs supported by this driver > can also support pause frames. Announce this to be so. > Tested with a TI83822I. > > Acked-by: Andrew F. Davis > Signed-off-by:

Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

2016-12-05 Thread Grygorii Strashko
On 12/05/2016 08:49 AM, Rob Herring wrote: > On Mon, Nov 28, 2016 at 05:04:23PM -0600, Grygorii Strashko wrote: >> From: WingMan Kwok >> >> This patch adds support of the cpts device found in the >> gbe and 10gbe ethernet switches on the keystone 2 SoCs >> (66AK2E/L/Hx,

Re: [PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:18 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:22PM +0200, Netanel Belgazal wrote: ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type treat the ena_flow_hash_to_flow_type enum as power of two values. Change the values of ena_admin_flow_hash_fields to be power

Re: [PATCH 1/1] netdev: broadcom: propagate error code

2016-12-05 Thread David Miller
From: Pan Bian Date: Sat, 3 Dec 2016 17:56:17 +0800 > Function bnxt_hwrm_stat_ctx_alloc() always returns 0, even if the call > to _hwrm_send_message() fails. It may be better to propagate the errors > to the caller of bnxt_hwrm_stat_ctx_alloc(). > > Bugzilla:

Re: pull request: bluetooth-next 2016-12-03

2016-12-05 Thread David Miller
From: Johan Hedberg Date: Sat, 3 Dec 2016 19:53:41 + > Here's a set of Bluetooth & 802.15.4 patches for net-next (i.e. 4.10 > kernel): > > - Fix for a potential NULL deref in the ieee802154 netlink code > - Fix for the ED values of the at86rf2xx driver > -

Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'

2016-12-05 Thread Nicolas Pitre
On Mon, 5 Dec 2016, David Miller wrote: > From: Nicolas Pitre > Date: Mon, 5 Dec 2016 10:44:32 -0500 (EST) > > > On Sat, 3 Dec 2016, David Miller wrote: > > > >> From: Arnd Bergmann > >> Date: Sat, 3 Dec 2016 00:04:32 +0100 > >> > >> > ptp now

Re: [PATCH net-next] bpf: Preserve const register type on const OR alu ops

2016-12-05 Thread David Miller
From: Alexei Starovoitov Date: Sat, 3 Dec 2016 12:31:33 -0800 > From: Gianluca Borello > > Occasionally, clang (e.g. version 3.8.1) translates a sum between two > constant operands using a BPF_OR instead of a BPF_ADD. The verifier is > currently not handling

Re: [patch net v2] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread Nikita Yushchenko
> From: Nikita Yushchenko > Date: Mon, 5 Dec 2016 16:55:04 +0300 > >> Aieee I was typing too fast today, sorry... >> >> send separate "fix for the fix", or re-send patch without that silly typo? > > If the patch hasn't been applied yet, you resend a fixed

Re: [ovs-dev] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit

2016-12-05 Thread Michał Mirosław
On Sat, Dec 03, 2016 at 03:27:30PM -0800, Ben Pfaff wrote: > On Sat, Dec 03, 2016 at 10:22:28AM +0100, Michał Mirosław wrote: > > This All-in-one patch removes abuse of VLAN CFI bit, so it can be passed > > intact through linux networking stack. > > > > Signed-off-by: Michał Mirosław

[PATCH] net/udp: do not touch skb->peeked unless really needed

2016-12-05 Thread Eric Dumazet
From: Eric Dumazet In UDP recvmsg() path we currently access 3 cache lines from an skb while holding receive queue lock, plus another one if packet is dequeued, since we need to change skb->next->prev 1st cache line (contains ->next/prev pointers, offsets 0x00 and 0x08) 2nd

Re: [PATCH 1/1] net: usb: set error code when usb_alloc_urb fails

2016-12-05 Thread David Miller
From: Pan Bian Date: Sat, 3 Dec 2016 19:24:48 +0800 > In function lan78xx_probe(), variable ret takes the errno code on > failures. However, when the call to usb_alloc_urb() fails, its value > will keeps 0. 0 indicates success in the context, which is inconsistent > with

Re: [PATCH 1/1] net: bridge: set error code on failure

2016-12-05 Thread David Miller
From: Pan Bian Date: Sat, 3 Dec 2016 19:33:23 +0800 > Function br_sysfs_addbr() does not set error code when the call > kobject_create_and_add() returns a NULL pointer. It may be better to > return "-ENOMEM" when kobject_create_and_add() fails. > > Bugzilla:

Re: [PATCH V2 net 13/20] net/ena: change driver's default timeouts

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:35 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:31PM +0200, Netanel Belgazal wrote: ... because? (they turned out to be too aggressive, I believe.) Yes, The timeout were too aggressive on some specific machines. Signed-off-by: Netanel Belgazal

Re: [PATCH 1/1] atm: lanai: set error code when ioremap fails

2016-12-05 Thread David Miller
From: Pan Bian Date: Sat, 3 Dec 2016 20:25:45 +0800 > In function lanai_dev_open(), when the call to ioremap() fails, the > value of return variable result is 0. 0 means no error in this context. > This patch fixes the bug, assigning "-ENOMEM" to result when ioremap() >

Re: [PATCH V2 net 10/20] net/ena: remove redundant logic in napi callback for busy poll mode

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 07:45 AM, Eric Dumazet wrote: On Sun, 2016-12-04 at 15:19 +0200, Netanel Belgazal wrote: sk_busy_loop can call the napi callback few million times a sec. For each call there is unmask interrupt. We want to reduce the number of unmasks. Add an atomic variable that will tell the

Re: [PATCH V2 net 07/20] net/ena: refactor ena_get_stats64 to be atomic context safe

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:24 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:25PM +0200, Netanel Belgazal wrote: ndo_get_stat64 can be called from atomic context. However the current implementation sends an admin command to retrieve the statistics from the device. This admin commands uses sleep.

Re: [PATCH V2 net 06/20] net/ena: fix NULL dereference when removing the driver after device reset faild

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:29 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:24PM +0200, Netanel Belgazal wrote: If for some reason the device stop responding and the device reset failed to recover the device, the mmio register read datastructure will not be reinitialized. If for some reason the

  1   2   3   >