Re: pull-request: can 2016-12-07

2016-12-07 Thread David Miller
From: Marc Kleine-Budde Date: Wed, 7 Dec 2016 10:50:39 +0100 > Andrey Konovalov triggered a warning in the CAN RAW layer, which is > fixed by a patch by me. Pulled, thanks Marc.

Re: [PATCH] net/udp: do not touch skb->peeked unless really needed

2016-12-07 Thread Eric Dumazet
On Wed, 2016-12-07 at 18:37 +0100, Hannes Frederic Sowa wrote: > I had the same idea while discussing that with Paolo, merely using an > *atomic_t = kmalloc(sizeof(atomic_t)) out of band of the socket. > > My fear was that those could be aggregated by the slab cache into one > cache line,

Re: [PATCH v2] drivers: net: cpsw-phy-sel: Clear RGMII_IDMODE on "rgmii" links

2016-12-07 Thread David Miller
From: Alexandru Gagniuc Date: Tue, 6 Dec 2016 10:56:51 -0800 > Support for setting the RGMII_IDMODE bit was added in the commit > referenced below. However, that commit did not add the symmetrical > clearing of the bit by way of setting it in "mask". Add it here. > > Note

Re: [PATCH] [v3] net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause

2016-12-07 Thread Timur Tabi
On 12/07/2016 03:13 AM, Niklas Cassel wrote: You might want to include drivers/net/phy/dp83848.c in your patch. Support for pause frames in that phy was recently added to netdev-next. Thanks. I feel bad that I'm reverting your patch just a few days after it was applied. -- Qualcomm

Re: commit : ppp: add rtnetlink device creation support - breaks netcf on my machine.

2016-12-07 Thread Thomas Haller
On Tue, 2016-12-06 at 17:12 -0600, Dan Williams wrote: > > > libnl1 rejects the IFLA_INFO_DATA attribute because it expects it > > to > > contain a sub-attribute. Since the payload size is zero it doesn't > > match the policy and parsing fails. > > > > There's no problem with libnl3 because its

Re: [PATCH] net: return value of skb_linearize should be handled in Linux kernel

2016-12-07 Thread Cong Wang
On Tue, Dec 6, 2016 at 10:27 PM, Zhouyi Zhou wrote: > On Wed, Dec 7, 2016 at 1:02 PM, Cong Wang wrote: >> On Mon, Dec 5, 2016 at 11:10 PM, Zhouyi Zhou wrote: >>> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c >>>

stmmac driver...

2016-12-07 Thread David Miller
Giuseppe and Alexandre, There are a lot of patches and discussions happening around the stammc driver lately and both of you are listed as the maintainers. I really need prompt and conclusive reviews of these patch submissions from you, and participation in all discussions about the driver.

Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

2016-12-07 Thread David Miller
From: Santosh Shilimkar Date: Wed, 7 Dec 2016 08:44:04 -0800 > On 12/7/2016 7:55 AM, David Miller wrote: >> From: Santosh Shilimkar >> Date: Tue, 6 Dec 2016 20:01:56 -0800 >> >> What level of compatability exists here? If we run an

Re: [PATCH v2 iproute2/net-next 0/3] tc: flower: Support matching on ICMP

2016-12-07 Thread Stephen Hemminger
On Wed, 7 Dec 2016 14:54:00 +0100 Simon Horman wrote: > Add support for matching on ICMP type and code to flower. This is modeled > on existing support for matching on L4 ports. > > The second patch provided a minor cleanup which is in keeping with > they style used

Re: [PATCH net-next] of: add optional naming of interfaces

2016-12-07 Thread Florian Fainelli
On 12/07/2016 05:12 AM, Volodymyr Bendiuga wrote: > From: Jonas Johansson > > Signed-off-by: Mattias Walström > Signed-off-by: Jonas Johansson This does not belong to the Device Tree, there should be plenty of

[PATCH net-next] net: do not read sk_drops if application does not care

2016-12-07 Thread Eric Dumazet
From: Eric Dumazet sk_drops can be an often written field, do not read it unless application showed interest. Note that sk_drops can be read via inet_diag, so applications can avoid getting this info from every received packet. In the future, 'reading' sk_drops might

Re: [PATCH net-next 1/1] driver: macvlan: Remove the rcu member of macvlan_port

2016-12-07 Thread David Miller
From: f...@ikuai8.com Date: Wed, 7 Dec 2016 12:23:18 +0800 > From: Gao Feng > > When free macvlan_port in macvlan_port_destroy, it is safe to free > directly because netdev_rx_handler_unregister could enforce one > grace period. > So it is unnecessary to use kfree_rcu for

Re: [PATCH net-next v3 1/1] driver: ipvlan: Free ipvl_port directly with kfree instead of kfree_rcu

2016-12-07 Thread David Miller
From: f...@ikuai8.com Date: Wed, 7 Dec 2016 08:44:47 +0800 > From: Gao Feng > > There are two functions which would free the ipvl_port now. The first > is ipvlan_port_create. It frees the ipvl_port in the error handler, > so it could kfree it directly. The second is

Re: [PATCH net] phy: Don't increment MDIO bus refcount unless it's a different owner

2016-12-07 Thread David Miller
From: Florian Fainelli Date: Tue, 6 Dec 2016 20:54:43 -0800 > Commit 3e3aaf649416 ("phy: fix mdiobus module safety") fixed the way we > dealt with MDIO bus module reference count, but sort of introduced a > regression in that, if an Ethernet driver registers its own MDIO

Re: [net-next] nlmon: use core MTU range checking in nlmon driver

2016-12-07 Thread David Miller
From: Zhang Shengju Date: Wed, 7 Dec 2016 17:26:05 +0800 > Since commit 61e84623ace3 ("net: centralize net_device min/max MTU checking"), > mtu range is checked at dev_set_mtu(). > > This patch adds min_mtu for nlmon device and remove unnecessary >

Re: [net-next] dummy: expend mtu range for dummy device

2016-12-07 Thread David Miller
From: Zhang Shengju Date: Wed, 7 Dec 2016 17:41:33 +0800 > After commit 61e84623ace3 ("net: centralize net_device min/max MTU checking"), > the mtu range for dummy device becomes [68, 1500]. > > This patch expends it to [0, 65535]. > > Signed-off-by: Zhang

Re: ixgbe Port cannot load, "failed to register GSI"

2016-12-07 Thread Alexander Duyck
On Tue, Dec 6, 2016 at 3:22 PM, Ben Greear wrote: > We put 3 10-g dual-port ixgbe NICs and 4 4-port I350 NICs in a 2U rackmount, > and one of the ixgbe ports > fails to come up. This previously worked before reboot, so maybe it is a > race somehow. Kernel is 4.4.11+, >

[PATCH net-next V3 6/7] liquidio CN23XX: VF TX buffers

2016-12-07 Thread Raghu Vatsavayi
Adds support for freeing VF xmit buffers. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V3 3/7] liquidio CN23XX: VF mac address

2016-12-07 Thread Raghu Vatsavayi
Adds support for configuring mtu, multicast and mac address. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V3 1/7] liquidio CN23XX: VF offload features

2016-12-07 Thread Raghu Vatsavayi
Adds support for VF link initialization and offload features. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V3 4/7] liquidio CN23XX: VF scatter gather lists

2016-12-07 Thread Raghu Vatsavayi
Adds support for VF scatter gather lists. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V3 2/7] liquidio CN23XX: VF link status

2016-12-07 Thread Raghu Vatsavayi
Adds support for VF link status related changes. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V3 5/7] liquidio CN23XX: VF xmit

2016-12-07 Thread Raghu Vatsavayi
Adds support for transmit functionality in VF. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

Re: [PATCH v3 net-next 1/4] bpf: xdp: Allow head adjustment in XDP prog

2016-12-07 Thread Daniel Borkmann
On 12/07/2016 06:04 PM, David Miller wrote: From: Alexei Starovoitov Date: Wed, 7 Dec 2016 08:37:58 -0800 On Wed, Dec 07, 2016 at 11:41:12AM +, Jakub Kicinski wrote: I see nothing wrong if this is exposed/made visible in the usual way through ethtool -k as

[PATCH net-next] udp: under rx pressure, try to condense skbs

2016-12-07 Thread Eric Dumazet
From: Eric Dumazet Under UDP flood, many softirq producers try to add packets to UDP receive queue, and one user thread is burning one cpu trying to dequeue packets as fast as possible. Two parts of the per packet cost are : - copying payload from kernel space to user

Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

2016-12-07 Thread Santosh Shilimkar
On 12/7/2016 9:05 AM, David Miller wrote: From: Santosh Shilimkar Date: Wed, 7 Dec 2016 08:44:04 -0800 On 12/7/2016 7:55 AM, David Miller wrote: From: Santosh Shilimkar Date: Tue, 6 Dec 2016 20:01:56 -0800 What level of

Re: [PATCH] net/udp: do not touch skb->peeked unless really needed

2016-12-07 Thread Eric Dumazet
On Wed, 2016-12-07 at 18:37 +0100, Hannes Frederic Sowa wrote: > I had the same idea while discussing that with Paolo, merely using an > *atomic_t = kmalloc(sizeof(atomic_t)) out of band of the socket. > > My fear was that those could be aggregated by the slab cache into one > cache line,

[PATCH] net: pch_gbe: Fix TX RX descriptor accesses for big endian systems

2016-12-07 Thread Hassan Naveed
Fix pch_gbe driver for ethernet operations for a big endian CPU. Values written to and read from transmit and receive descriptors in the pch_gbe driver are byte swapped from the perspective of a big endian CPU, since the ethernet controller always operates in little endian mode. Rectify this by

Re: [PATCH net-next] bpf: fix loading of BPF_MAXINSNS sized programs

2016-12-07 Thread David Miller
From: Daniel Borkmann Date: Wed, 7 Dec 2016 01:15:44 +0100 > General assumption is that single program can hold up to BPF_MAXINSNS, > that is, 4096 number of instructions. It is the case with cBPF and > that limit was carried over to eBPF. When recently testing digest, I >

nfct_query hangs after multiple requests

2016-12-07 Thread Kirila Adamova
Hi I am using nfct_query (libnetfilter_conntrack library) to get a connection from the conntrack table and then to update its connmark. This was working ok in a development environment, but when testing it in production with a lot of traffic, after around a minute, the daemon

Re: [PATCH v3 net-next 1/4] bpf: xdp: Allow head adjustment in XDP prog

2016-12-07 Thread Martin KaFai Lau
On Wed, Dec 07, 2016 at 08:37:58AM -0800, Alexei Starovoitov wrote: > On Wed, Dec 07, 2016 at 11:41:12AM +, Jakub Kicinski wrote: > > > I see nothing wrong if this is exposed/made visible in the usual way > > > through > > > ethtool -k as well. I guess at least that would be the expected way

Re: [PATCH] net/udp: do not touch skb->peeked unless really needed

2016-12-07 Thread Eric Dumazet
On Wed, 2016-12-07 at 17:09 +, David Laight wrote: > From: Paolo Abeni > > Sent: 06 December 2016 17:08 > ... > > @@ -79,6 +82,9 @@ struct udp_sock { > > int (*gro_complete)(struct sock *sk, > > struct sk_buff *skb, > >

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-07 Thread Jason A. Donenfeld
On Wed, Dec 7, 2016 at 7:51 PM, David Miller wrote: > It's so much better to analyze properly where the misalignment comes from > and address it at the source, as we have for various cases that trip up > Sparc too. That's sort of my attitude too, hence starting this thread.

Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

2016-12-07 Thread David Miller
From: Santosh Shilimkar Date: Wed, 7 Dec 2016 09:20:17 -0800 > Newer/Updated tools which can parse this extra info in needs newer > or an updated kernel which supports and populates these fields. > > As mentioned, this particular option used only in verbose mode so

Re: [PATCH net] netvsc: reduce maximum GSO size

2016-12-07 Thread David Miller
From: Stephen Hemminger Date: Tue, 6 Dec 2016 13:43:54 -0800 > Hyper-V (and Azure) support using NVGRE which requires some extra space > for encapsulation headers. Because of this the largest allowed TSO > packet is reduced. > > For older releases, hard code a fixed

Re: [PATCH] sh_eth: add wake-on-lan support via magic packet

2016-12-07 Thread Geert Uytterhoeven
Hi Niklas, On Wed, Dec 7, 2016 at 5:28 PM, Niklas Söderlund wrote: > Signed-off-by: Niklas Söderlund Thanks, works fine on r8a7791/koelsch! Tested-by: Geert Uytterhoeven > ---

Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-07 Thread Jason A. Donenfeld
Hey MIPS Networking People, I receive encrypted packets with a 13 byte header. I decrypt the ciphertext in place, and then discard the header. I then pass the plaintext to the rest of the networking stack. The plaintext is an IP packet. Due to the 13 byte header that was discarded, the plaintext

Re: 4.9.0-rc8: tg3 dead after resume

2016-12-07 Thread Billy Shuman
On Wed, Dec 7, 2016 at 12:37 PM, Michael Chan wrote: > On Wed, Dec 7, 2016 at 7:20 AM, Billy Shuman wrote: >> After resume on 4.9.0-rc8 tg3 is dead. >> >> In logs I see: >> kernel: tg3 :44:00.0: phy probe failed, err -19 >> kernel: tg3

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-07 Thread David Miller
From: Dave Taht Date: Wed, 7 Dec 2016 10:47:16 -0800 > https://git.lede-project.org/?p=openwrt/source.git;a=blob;f=target/linux/ar71xx/patches-4.4/910-unaligned_access_hacks.patch;h=b4b749e4b9c02a74a9f712a2740d63e554de5c64;hb=ee53a240ac902dc83209008a2671e7fdcf55957a It's so

Re: [PATCH net-next v2] dsa:mv88e6xxx: dispose irq mapping for chip->irq

2016-12-07 Thread Volodymyr Bendiuga
Yes, most of the users of of_irq_get() do not use irq_dispose_mapping(). But some of them do (some irq chips), and I believe the correct way of doing this is to dispose irq mapping, as the description for this function says that it unmaps the irq, which is mapped by of_irq_parse_and_map().

Re: [PATCH v3 net-next 1/4] bpf: xdp: Allow head adjustment in XDP prog

2016-12-07 Thread David Miller
From: Alexei Starovoitov Date: Wed, 7 Dec 2016 08:37:58 -0800 > On Wed, Dec 07, 2016 at 11:41:12AM +, Jakub Kicinski wrote: >> > I see nothing wrong if this is exposed/made visible in the usual way >> > through >> > ethtool -k as well. I guess at least that

Re: 4.9.0-rc8: tg3 dead after resume

2016-12-07 Thread Michael Chan
On Wed, Dec 7, 2016 at 7:20 AM, Billy Shuman wrote: > After resume on 4.9.0-rc8 tg3 is dead. > > In logs I see: > kernel: tg3 :44:00.0: phy probe failed, err -19 > kernel: tg3 :44:00.0: Problem fetching invariants of chip, aborting -19 is -ENODEV which means tg3

Re: [PATCH] net/udp: do not touch skb->peeked unless really needed

2016-12-07 Thread Hannes Frederic Sowa
On Wed, Dec 7, 2016, at 18:32, Eric Dumazet wrote: > On Wed, 2016-12-07 at 17:09 +, David Laight wrote: > > From: Paolo Abeni > > > Sent: 06 December 2016 17:08 > > ... > > > @@ -79,6 +82,9 @@ struct udp_sock { > > > int (*gro_complete)(struct sock *sk, > > >

Re: [PATCH] net: stmmac: do not call phy_ethtool_ksettings_set from atomic context

2016-12-07 Thread David Miller
From: Niklas Cassel Date: Tue, 6 Dec 2016 14:47:15 +0100 > From: Niklas Cassel > > From what I can tell, spin_lock(>lock) is not needed, since the > phy_ethtool_ksettings_set call is not given the priv struct. > > phy_start_aneg takes the

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-07 Thread Dave Taht
The openwrt tree has long contained a set of patches that correct for unaligned issues throughout the linux network stack.

[PATCH net-next V3 7/7] liquidio VF rx data and ctl path

2016-12-07 Thread Raghu Vatsavayi
Adds support for VF receive data control path. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V3 0/7] liquidio VF data path

2016-12-07 Thread Raghu Vatsavayi
Dave, Following is V3 patch series that adds support for VF data path related features. It also has following changes related to previous comments: 1) Remove unnecessary "void *" casting. 2) Remove inline for functions and let gcc decide. Please apply patches in following order as some of them

RE: [PATCH] net/udp: do not touch skb->peeked unless really needed

2016-12-07 Thread David Laight
From: Paolo Abeni > Sent: 06 December 2016 17:08 ... > @@ -79,6 +82,9 @@ struct udp_sock { > int (*gro_complete)(struct sock *sk, > struct sk_buff *skb, > int nhoff); > + > +

Re: [PATCH 1/1] ixgbe: fcoe: return value of skb_linearize should be handled

2016-12-07 Thread Jeff Kirsher
On Wed, 2016-12-07 at 15:43 +0800, Zhouyi Zhou wrote: > Signed-off-by: Zhouyi Zhou > Reviewed-by: Cong Wang > Reviewed-by: Yuval Shaia   > Reviewed-by: Eric Dumazet > --- >  

Re: 4.9.0-rc8: tg3 dead after resume

2016-12-07 Thread Billy Shuman
On Wed, Dec 7, 2016 at 12:37 PM, Michael Chan wrote: > On Wed, Dec 7, 2016 at 7:20 AM, Billy Shuman wrote: >> After resume on 4.9.0-rc8 tg3 is dead. >> >> In logs I see: >> kernel: tg3 :44:00.0: phy probe failed, err -19 >> kernel: tg3

[PATCH net-next] bpf: fix state equivalence

2016-12-07 Thread Alexei Starovoitov
Commmits 57a09bf0a416 ("bpf: Detect identical PTR_TO_MAP_VALUE_OR_NULL registers") and 484611357c19 ("bpf: allow access into map value arrays") by themselves are correct, but in combination they make state equivalence ignore 'id' field of the register state which can lead to accepting invalid

PROBLEM:

2016-12-07 Thread Tony
Hello, NB. This is a re-send. I've been advised to send again as I gather I'm supposed to receive a URL back. I am reporting this as requested below: Anthony Buckley, the issue you are reporting is an upstream one. Could you please report this problem following the instructions verbatim at

pull request: bluetooth-next 2016-12-08

2016-12-07 Thread Johan Hedberg
Hi Dave, I didn't miss your "net-next is closed" email, but it did come as a bit of a surprise, and due to time-zone differences I didn't have a chance to react to it until now. We would have had a couple of patches in bluetooth-next that we'd still have wanted to get to 4.10. Out of these the

[PATCH v2 2/2] net: rfkill: Add rfkill-any LED trigger

2016-12-07 Thread Michał Kępień
Add a new "global" (i.e. not per-rfkill device) LED trigger, rfkill-any, which may be useful on laptops with a single "radio LED" and multiple radio transmitters. The trigger is meant to turn a LED on whenever there is at least one radio transmitter active and turn it off otherwise.

pull request: bluetooth-next 2016-12-08

2016-12-07 Thread Johan Hedberg
(resending since I forgot to sign the first one) Hi Dave, I didn't miss your "net-next is closed" email, but it did come as a bit of a surprise, and due to time-zone differences I didn't have a chance to react to it until now. We would have had a couple of patches in bluetooth-next that we'd

[PATCH] net: add one ethtool option to set relax ordering mode

2016-12-07 Thread Mao Wenan
This patch provides one way to set/unset IXGBE NIC TX and RX relax ordering mode, which can be set by ethtool. Relax ordering is one mode of 82599 NIC, to enable this mode can enhance the performance for some cpu architecure. example: ethtool -s enp1s0f0 relaxorder off ethtool -s enp1s0f0

Re: [PATCH] sh_eth: add wake-on-lan support via magic packet

2016-12-07 Thread Niklas Söderlund
Hi Geert, Thanks for testing and your feedback. On 2016-12-07 19:14:40 +0100, Geert Uytterhoeven wrote: > Hi Niklas, > > On Wed, Dec 7, 2016 at 5:28 PM, Niklas Söderlund > wrote: > > Signed-off-by: Niklas Söderlund

[PATCH v2 1/2] net: rfkill: Cleanup error handling in rfkill_init()

2016-12-07 Thread Michał Kępień
Use a separate label per error condition in rfkill_init() to make it a bit cleaner and easier to extend. Signed-off-by: Michał Kępień --- No changes from v1. net/rfkill/core.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git

[PATCH] cxgb4/cxgb4vf: Remove deprecated module parameters

2016-12-07 Thread Ganesh Goudar
Remove deprecated module parameters num_vf, dflt_msg_enable and force_init. Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c| 41 +- .../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c| 9 + 2 files changed, 2

[PATCH] ethtool: add one ethtool option to set relax ordering mode

2016-12-07 Thread Mao Wenan
This patch provides one way to set/unset IXGBE NIC TX and RX relax ordering mode, which can be set by ethtool. Relax ordering is one mode of 82599 NIC, to enable this mode can enhance the performance for some cpu architecure. example: ethtool -s enp1s0f0 relaxorder off ethtool -s enp1s0f0

Re: [PATCH 5/7] Documentation: DT: net: cpsw: allow to specify descriptors pool size

2016-12-07 Thread Grygorii Strashko
On 12/02/2016 11:21 AM, Grygorii Strashko wrote: > > > On 12/02/2016 05:28 AM, Ivan Khoronzhuk wrote: >> On Thu, Dec 01, 2016 at 05:34:30PM -0600, Grygorii Strashko wrote: >>> Add optional property "descs_pool_size" to specify buffer descriptor's >>> pool size. The "descs_pool_size" should

[net-next PATCH v5 2/6] net: xdp: add invalid buffer warning

2016-12-07 Thread John Fastabend
This adds a warning for drivers to use when encountering an invalid buffer for XDP. For normal cases this should not happen but to catch this in virtual/qemu setups that I may not have expected from the emulation layer having a standard warning is useful. Signed-off-by: John Fastabend

Re: Synopsys Ethernet QoS Driver

2016-12-07 Thread Andy Shevchenko
On Mon, Nov 21, 2016 at 2:52 PM, Giuseppe CAVALLARO wrote: First of all, +1 to (re-)use stmmac. > The stmmac drivers run since many years on several platforms > (sh4, stm32, arm, x86, mips ...) and it supports an huge of amount of > configurations starting from 3.1x to

Re: [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool()

2016-12-07 Thread Iyappan Subramanian
On Wed, Dec 7, 2016 at 3:14 AM, Dan Carpenter wrote: > We never set "slots" in this function. > > Fixes: a9380b0f7be8 ("drivers: net: xgene: Add support for Jumbo frame") > Signed-off-by: Dan Carpenter > --- > I copied how slots gets set in

Re: [PATCH] net: pch_gbe: Fix TX RX descriptor accesses for big endian systems

2016-12-07 Thread Francois Romieu
Hassan Naveed : > Fix pch_gbe driver for ethernet operations for a big endian CPU. > Values written to and read from transmit and receive descriptors > in the pch_gbe driver are byte swapped from the perspective of a > big endian CPU, since the ethernet controller always

[net-next v2 09/19] i40e: Add support for 25G devices

2016-12-07 Thread Jeff Kirsher
From: Carolyn Wyborny Add support for 25G devices - defines and data structures. One tricky part here is that the firmware support for these Devices introduces a mismatch between the PHY type enum and the bitfields for the phy types. This change creates a macro and

[net-next v2 05/19] i40e: remove code to handle dev_addr specially

2016-12-07 Thread Jeff Kirsher
From: Jacob Keller The netdev->dev_addr MAC filter already exists in the MAC/VLAN hash table, as it is added when we configure the netdev in i40e_configure_netdev. Because we already know that this address will be updated in the hash_for_each loops, we do not need to

[net-next v2 01/19] i40e: Driver prints log message on link speed change

2016-12-07 Thread Jeff Kirsher
From: Filip Sadowski This patch makes the driver log link speed change. Before applying the patch link messages were printed only on state change. Now message is printed when link is brought up or down and when speed changes. Change-ID:

[net-next v2 07/19] Changed version from 1.6.21 to 1.6.25

2016-12-07 Thread Jeff Kirsher
From: Bimmy Pujari Signed-off-by: Bimmy Pujari Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-

[PATCH 36/50] netfilter: nft_quota: dump consumed quota

2016-12-07 Thread Pablo Neira Ayuso
Add a new attribute NFTA_QUOTA_CONSUMED that displays the amount of quota that has been already consumed. This allows us to restore the internal state of the quota object between reboots as well as to monitor how wasted it is. This patch changes the logic to account for the consumed bytes,

[PATCH 17/50] netfilter: conntrack: register hooks in netns when needed by ruleset

2016-12-07 Thread Pablo Neira Ayuso
From: Florian Westphal This makes use of nf_ct_netns_get/put added in previous patch. We add get/put functions to nf_conntrack_l3proto structure, ipv4 and ipv6 then implement use-count to track how many users (nft or xtables modules) have a dependency on ipv4 and/or ipv6

[PATCH 20/50] netfilter: introduce accessor functions for hook entries

2016-12-07 Thread Pablo Neira Ayuso
From: Aaron Conole This allows easier future refactoring. Signed-off-by: Aaron Conole Signed-off-by: Pablo Neira Ayuso --- include/linux/netfilter.h | 27 +++ net/bridge/br_netfilter_hooks.c | 2 +-

[PATCH 33/50] netfilter: nft_counter: add stateful object type

2016-12-07 Thread Pablo Neira Ayuso
Register a new percpu counter stateful object type into the stateful object infrastructure. Signed-off-by: Pablo Neira Ayuso --- include/uapi/linux/netfilter/nf_tables.h | 1 + net/netfilter/nft_counter.c | 140 +-- 2 files

[PATCH 38/50] netfilter: nf_tables: notify internal updates of stateful objects

2016-12-07 Thread Pablo Neira Ayuso
Introduce nf_tables_obj_notify() to notify internal state changes in stateful objects. This is used by the quota object to report depletion in a follow up patch. Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h | 4 net/netfilter/nf_tables_api.c

[PATCH 19/50] netfilter: defrag: only register defrag functionality if needed

2016-12-07 Thread Pablo Neira Ayuso
From: Florian Westphal nf_defrag modules for ipv4 and ipv6 export an empty stub function. Any module that needs the defragmentation hooks registered simply 'calls' this empty function to create a phony module dependency -- modprobe will then load the defrag module too. This

[PATCH 11/50] netfilter: conntrack: built-in support for SCTP

2016-12-07 Thread Pablo Neira Ayuso
From: Davide Caratti CONFIG_NF_CT_PROTO_SCTP is no more a tristate. When set to y, connection tracking support for SCTP protocol is built-in into nf_conntrack.ko. footprint test: $ ls -l net/netfilter/nf_conntrack{_proto_sctp,}.ko \

[PATCH 48/50] netfilter: x_tables: avoid warn and OOM killer on vmalloc call

2016-12-07 Thread Pablo Neira Ayuso
From: Marcelo Ricardo Leitner Andrey Konovalov reported that this vmalloc call is based on an userspace request and that it's spewing traces, which may flood the logs and cause DoS if abused. Florian Westphal also mentioned that this call should not trigger OOM

[PATCH 50/50] netfilter: nft_quota: allow to restore consumed quota

2016-12-07 Thread Pablo Neira Ayuso
Allow to restore consumed quota, this is useful to restore the quota state across reboots. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_quota.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nft_quota.c

[PATCH 18/50] netfilter: conntrack: add nf_conntrack_default_on sysctl

2016-12-07 Thread Pablo Neira Ayuso
From: Florian Westphal This switch (default on) can be used to disable automatic registration of connection tracking functionality in newly created network namespaces. This means that when net namespace goes down (or the tracker protocol module is unloaded) we *might* have to

[PATCH 49/50] netfilter: xt_bpf: support ebpf

2016-12-07 Thread Pablo Neira Ayuso
From: Willem de Bruijn Add support for attaching an eBPF object by file descriptor. The iptables binary can be called with a path to an elf object or a pinned bpf object. Also pass the mode and path to the kernel to be able to return it later for iptables dump and save.

[PATCH 37/50] netfilter: nf_tables: atomic dump and reset for stateful objects

2016-12-07 Thread Pablo Neira Ayuso
This patch adds a new NFT_MSG_GETOBJ_RESET command perform an atomic dump-and-reset of the stateful object. This also comes with add support for atomic dump and reset for counter and quota objects. Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h

[PATCH 46/50] netfilter: nft_set: introduce nft_{hash, rbtree}_deactivate_one()

2016-12-07 Thread Pablo Neira Ayuso
This new function allows us to deactivate one single element, this is required by the set flush command that comes in a follow up patch. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_set_hash.c | 24 +--- net/netfilter/nft_set_rbtree.c | 11

[PATCH 28/50] netfilter: nft_payload: layer 4 checksum adjustment for pseudoheader fields

2016-12-07 Thread Pablo Neira Ayuso
This patch adds a new flag that signals the kernel to update layer 4 checksum if the packet field belongs to the layer 4 pseudoheader. This implicitly provides stateless NAT 1:1 that is useful under very specific usecases. Since rules mangling layer 3 fields that are part of the pseudoheader may

[PATCH 21/50] netfilter: decouple nf_hook_entry and nf_hook_ops

2016-12-07 Thread Pablo Neira Ayuso
From: Aaron Conole During nfhook traversal we only need a very small subset of nf_hook_ops members. We need: - next element - hook function to call - hook function priv argument Bridge netfilter also needs 'thresh'; can be obtained via ->orig_ops. nf_hook_entry struct is

[PATCH 02/50] ipvs: Decrement ttl

2016-12-07 Thread Pablo Neira Ayuso
From: Dwip Banerjee We decrement the IP ttl in all the modes in order to prevent infinite route loops. The changes were done based on Julian Anastasov's suggestions in a prior thread. The ttl based check/discard and the actual decrement are done in __ip_vs_get_out_rt()

[PATCH 45/50] netfilter: nf_tables: constify struct nft_ctx * parameter in nft_trans_alloc()

2016-12-07 Thread Pablo Neira Ayuso
Context is not modified by nft_trans_alloc(), so constify it. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index

[PATCH 47/50] netfilter: nf_tables: support for set flushing

2016-12-07 Thread Pablo Neira Ayuso
This patch adds support for set flushing, that consists of walking over the set elements if the NFTA_SET_ELEM_LIST_ELEMENTS attribute is set. This patch requires the following changes: 1) Add set->ops->deactivate_one() operation: This allows us to deactivate an element from the set element

Re: [patch] ser_gigaset: return -ENOMEM on error instead of success

2016-12-07 Thread Tilman Schmidt
Hi Paul, Am 07.12.2016 um 22:08 schrieb Paul Bolle: > On Wed, 2016-12-07 at 21:57 +0100, Tilman Schmidt wrote: >> Not much of a mess, I reckon. Everything that has been allocated and >> registered up to that point is properly deallocated and unregistered. >> The code just fails to tell the kernel

[net-next v2 04/19] i40e/i40evf: napi_poll must return the work done

2016-12-07 Thread Jeff Kirsher
From: Alexander Duyck Currently the function i40e_napi-poll() returns 0 when it clean completely the Rx rings, but this foul budget accounting in core code. Fix this by returning the actual work done, capped to budget - 1, since the core doesn't allow to return the

[net-next v2 10/19] i40e: Add FEC for 25g

2016-12-07 Thread Jeff Kirsher
From: Carolyn Wyborny This patch adds adminq support for Forward Error Correction ("FEC")for 25g products. Change-ID: Iaff4910737c239d2c730e5c22a313ce9c37d3964 Signed-off-by: Carolyn Wyborny Signed-off-by: Mitch Williams

[net-next v2 06/19] i40e: Blink LED on 1G BaseT boards

2016-12-07 Thread Jeff Kirsher
From: Henry Tieman Before this patch "ethtool -p" was not blinking the LEDs on boards with 1G BaseT PHYs. This commit identifies 1G BaseT boards as having the LEDs connected to the MAC. Also, renamed the flag to be more descriptive of usage. The flag is now

[net-next v2 03/19] i40e: restore workaround for removing default MAC filter

2016-12-07 Thread Jeff Kirsher
From: Jacob Keller A previous commit 53cb6e9e8949 ("i40e: Removal of workaround for simple MAC address filter deletion") removed a workaround for some firmware versions which was reported to not be necessary in production NICs. Unfortunately this workaround is necessary

Re: [PATCH 2/2] net: ethernet: stmmac: remove private tx queue lock

2016-12-07 Thread Lino Sanfilippo
On 07.12.2016 22:43, Lino Sanfilippo wrote: > Hi Pavel, > > On 07.12.2016 22:37, Pavel Machek wrote: >> On Wed 2016-12-07 21:05:38, Lino Sanfilippo wrote: >>> The driver uses a private lock for synchronization between the xmit >>> function and the xmit completion handler, but since the

Re: [PATCH 2/2] net: ethernet: stmmac: remove private tx queue lock

2016-12-07 Thread Pavel Machek
On Wed 2016-12-07 21:05:38, Lino Sanfilippo wrote: > The driver uses a private lock for synchronization between the xmit > function and the xmit completion handler, but since the NETIF_F_LLTX flag > is not set, the xmit function is also called with the xmit_lock held. > > On the other hand the

RE: [net-next 20/20] i40e: don't allow i40e_vsi_(add|kill)_vlan to operate when VID<1

2016-12-07 Thread Keller, Jacob E
> -Original Message- > From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] > Sent: Wednesday, December 07, 2016 2:11 AM > To: Kirsher, Jeffrey T ; da...@davemloft.net > Cc: Keller, Jacob E ; netdev@vger.kernel.org; >

[PATCH 32/50] netfilter: nf_tables: add stateful objects

2016-12-07 Thread Pablo Neira Ayuso
This patch augments nf_tables to support stateful objects. This new infrastructure allows you to create, dump and delete stateful objects, that are identified by a user-defined name. This patch adds the generic infrastructure, follow up patches add support for two stateful objects: counters and

[PATCH 00/50] Netfilter/IPVS updates for net-next

2016-12-07 Thread Pablo Neira Ayuso
Hi David, The following patchset contains a large Netfilter update for net-next, to summarise: 1) Add support for stateful objects. This series provides a nf_tables native alternative to the extended accounting infrastructure for nf_tables. Two initial stateful objects are supported:

[PATCH 26/50] netfilter: nft_fib: convert htonl to ntohl properly

2016-12-07 Thread Pablo Neira Ayuso
From: Liping Zhang Acctually ntohl and htonl are identical, so this doesn't affect anything, but it is conceptually wrong. Signed-off-by: Liping Zhang Acked-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso

[PATCH 31/50] netfilter: add and use nf_fwd_netdev_egress

2016-12-07 Thread Pablo Neira Ayuso
From: Florian Westphal ... so we can use current skb instead of working with a clone. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_dup_netdev.h | 1 + net/netfilter/nf_dup_netdev.c

[PATCH 23/50] netfilter: x_tables: pass xt_counters struct instead of packet counter

2016-12-07 Thread Pablo Neira Ayuso
From: Florian Westphal On SMP we overload the packet counter (unsigned long) to contain percpu offset. Hide this from callers and pass xt_counters address instead. Preparation patch to allocate the percpu counters in page-sized batch chunks. Signed-off-by: Florian Westphal

  1   2   3   4   >