Re: Soft lockup in inet_put_port on 4.6

2016-12-12 Thread Josef Bacik
On Mon, Dec 12, 2016 at 1:44 PM, Hannes Frederic Sowa wrote: On 12.12.2016 19:05, Josef Bacik wrote: On Fri, Dec 9, 2016 at 11:14 PM, Eric Dumazet wrote: On Fri, 2016-12-09 at 19:47 -0800, Eric Dumazet wrote: Hmm... Is your

Soft lockup in tc_classify

2016-12-12 Thread Shahar Klein
Hi All, sorry for the spam, the first time was sent with html part and was rejected. We observed an issue where a classifier instance next member is pointing back to itself, causing a CPU soft lockup. We found it by running traffic on many udp connections and then adding a new flower rule

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-12 Thread Doug Ledford
On 12/9/2016 1:47 AM, Selvin Xavier wrote: > This series introduces the RoCE driver for the Broadcom > NetXtreme-E 10/25/40/50 gigabit RoCE HCAs. > This driver is dependent on the bnxt_en NIC driver and is > based on the bnxt_re branch in Doug's repository. bnxt_en changes > required for this

RE: [PATCH net-next 09/27] cxgb4: use __vlan_hwaccel helpers

2016-12-12 Thread Steve Wise
> This also initializes vlan_proto field. > > Signed-off-by: Michał Mirosław Acked-by: Steve Wise

Re: [PATCH 0/6] USB support for Broadcom NSP SoC

2016-12-12 Thread Florian Fainelli
On 11/09/2016 01:33 AM, Yendapally Reddy Dhananjaya Reddy wrote: > This patch set contains the usb support for Broadcom NSP SoC. > The usb phy is connected through mdio interface. The mdio interface > can be used to access either internal phys or external phys using a > multiplexer. > > The first

Re: [PATCH V3 for-next 00/11] Code improvements & fixes for HNS RoCE driver

2016-12-12 Thread Doug Ledford
On 11/23/2016 2:40 PM, Salil Mehta wrote: > This patchset introduces some code improvements and fixes > for the identified problems in the HNS RoCE driver. > > Lijun Ou (4): > IB/hns: Add the interface for querying QP1 > IB/hns: add self loopback for CM > IB/hns: Modify the condition of

[PATCH] net: cirrus: ep93xx: use new api ethtool_{get|set}_link_ksettings

2016-12-12 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/cirrus/ep93xx_eth.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git

"virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

2016-12-12 Thread Theodore Ts'o
Hi, I was doing a last minute regression test of the ext4 tree before sending a pull request to Linus, which I do using gce-xfstests[1], and I found that using networking was broken on GCE on linux-next. I was using next-20161209, and after bisecting things, I narrowed down the commit which

Re: [PATCH v2 1/4] net: hix5hd2_gmac: add generic compatible string

2016-12-12 Thread Dongpo Li
On 2016/12/12 22:21, Rob Herring wrote: > On Mon, Dec 12, 2016 at 5:16 AM, Dongpo Li wrote: >> Hi Rob, >> >> On 2016/12/10 6:35, Rob Herring wrote: >>> On Mon, Dec 05, 2016 at 09:27:58PM +0800, Dongpo Li wrote: The "hix5hd2" is SoC name, add the generic ethernet

[PATCH net-next 06/27] cnic: remove use of VLAN_TAG_PRESENT

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/net/ethernet/broadcom/cnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/cnic.c b/drivers/net/ethernet/broadcom/cnic.c index b1d2ac8..6e3c610 100644 ---

[PATCH net-next 08/27] net/hyperv: remove use of VLAN_TAG_PRESENT

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc_drv.c | 13 ++--- drivers/net/hyperv/rndis_filter.c | 4 ++-- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git

[PATCH net-next 03/27] ibmvnic: fix accelerated VLAN handling

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/net/ethernet/ibm/ibmvnic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index c125966..c7664db 100644 ---

[PATCH net-next 25/27] net: remove VLAN_TAG_PRESENT

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- arch/mips/net/bpf_jit.c | 3 --- arch/powerpc/net/bpf_jit_comp.c | 3 --- arch/sparc/net/bpf_jit_comp.c | 4 include/linux/if_vlan.h | 11 ++- include/linux/skbuff.h | 16 +---

[PATCH net-next 20/27] net/bpf_jit: MIPS: split VLAN_PRESENT bit handling from VLAN_TCI

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- arch/mips/net/bpf_jit.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/mips/net/bpf_jit.c b/arch/mips/net/bpf_jit.c index 49a2e22..4b12b5d 100644 --- a/arch/mips/net/bpf_jit.c +++

[PATCH net-next 18/27] net/skbuff: add macros for VLAN_PRESENT bit

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- include/linux/skbuff.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 332e767..4a85a1f 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -768,6 +768,12

Re: "virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

2016-12-12 Thread Michael S. Tsirkin
On Mon, Dec 12, 2016 at 06:33:43PM -0500, Theodore Ts'o wrote: > Hi, > > I was doing a last minute regression test of the ext4 tree before > sending a pull request to Linus, which I do using gce-xfstests[1], and > I found that using networking was broken on GCE on linux-next. I was > using

Re: [iproute2 v2 net-next 0/8] Add support for vrf helper

2016-12-12 Thread Stephen Hemminger
On Sat, 10 Dec 2016 12:32:06 -0800 David Ahern wrote: > This series adds support to iproute2 to run a command against a specific > VRF. The user semnatics are similar to 'ip netns'. > > The 'ip vrf' subcommand supports 3 usages: > > 1. Run a command against a given

Re: netlink: GPF in sock_sndtimeo

2016-12-12 Thread Cong Wang
On Mon, Dec 12, 2016 at 2:02 AM, Richard Guy Briggs wrote: > On 2016-12-09 20:13, Cong Wang wrote: >> Netlink notifier can safely be converted to blocking one, I will send >> a patch. > > I had a quick look at how that might happen. The netlink notifier chain > is atomic. Would

[ANNOUNCE] iproute2 4.9

2016-12-12 Thread Stephen Hemminger
Release of iproute2 for Linux 4.9, just in time for your holiday giving. Update to iproute2 utility to support new features in Linux 4.9. Mostly this is refinements to add new flags to tipc, l2tp, ss and macsec support. There are also a couple of performance enhancments for handling lots of

Re: [PATCH v2] audit: use proper refcount locking on audit_sock

2016-12-12 Thread Cong Wang
On Mon, Dec 12, 2016 at 2:03 AM, Richard Guy Briggs wrote: > Resetting audit_sock appears to be racy. > > audit_sock was being copied and dereferenced without using a refcount on > the source sock. > > Bump the refcount on the underlying sock when we store a refrence in >

Re: [PATCH net-next 2/5] liquidio VF vxlan

2016-12-12 Thread Felix Manlunas
Or Gerlitz wrote on Sat [2016-Dec-10 05:46:13 -0800]: > On Fri, Dec 9, 2016 at 12:42 AM, Vatsavayi, Raghu > wrote: > >> From: Or Gerlitz [mailto:gerlitz...@gmail.com] > >> On Thu, Dec 8, 2016 at 11:00 PM, Raghu Vatsavayi > >>

[PATCH net-next 02/27] net/vlan: introduce __vlan_hwaccel_copy_tag() helper

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 38be904..75e839b 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @@

[PATCH net-next 26/27] net/hyperv: enable passing of VLAN.CFI bit

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/net/hyperv/netvsc_drv.c | 1 + drivers/net/hyperv/rndis_filter.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 6597d79..4e20f4c 100644 ---

[PATCH net-next 19/27] net/bpf_jit: ARM: split VLAN_PRESENT bit handling from VLAN_TCI

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- arch/arm/net/bpf_jit_32.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c index 93d0b6d..6dbc602 100644 --- a/arch/arm/net/bpf_jit_32.c +++

[PATCH net-next 27/27] net/vlan: remove unused #define HAVE_VLAN_GET_TAG

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 8ff2f0e..f0b9356 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @@ -477,8 +477,6 @@

[PATCH net-next 09/27] cxgb4: use __vlan_hwaccel helpers

2016-12-12 Thread Michał Mirosław
This also initializes vlan_proto field. Signed-off-by: Michał Mirosław --- drivers/infiniband/hw/cxgb4/cm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index f1510cc..66a3d39

[PATCH net-next 11/27] sky2: use __vlan_hwaccel helpers

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/net/ethernet/marvell/sky2.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c index b60ad0e..bcd20e0 100644 ---

[PATCH net-next 21/27] net/bpf_jit: PPC: split VLAN_PRESENT bit handling from VLAN_TCI

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- arch/powerpc/net/bpf_jit_comp.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/net/bpf_jit_comp.c b/arch/powerpc/net/bpf_jit_comp.c index 7e706f3..22ae63f 100644 ---

[PATCH net-next 24/27] bpf_test: prepare for VLAN_TAG_PRESENT removal

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- lib/test_bpf.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/lib/test_bpf.c b/lib/test_bpf.c index 0362da0..00d3450 100644 --- a/lib/test_bpf.c +++ b/lib/test_bpf.c @@ -691,8 +691,13 @@ static struct bpf_test

[PATCH net-next 05/27] i40iw: remove use of VLAN_TAG_PRESENT

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/infiniband/hw/i40iw/i40iw_cm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c index 8563769..25cf689 100644 ---

[PATCH net-next 23/27] net/bpf: split VLAN_PRESENT bit handling from VLAN_TCI

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- net/core/filter.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c index b146170..c3321f1 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -188,22

[PATCH net-next 17/27] OVS: remove assumptions about VLAN_TAG_PRESENT bit

2016-12-12 Thread Michał Mirosław
This leaves CFI bit toggled in API, because userspace might depend this is set for normal ethernet traffic with tag present. Signed-off-by: Michał Mirosław --- Documentation/networking/openvswitch.txt | 14 net/openvswitch/actions.c| 13 +++

[PATCH net-next 07/27] gianfar: remove use of VLAN_TAG_PRESENT

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index

[PATCH net-next 01/27] net/vlan: introduce __vlan_hwaccel_clear_tag() helper

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 8d5fcd6..38be904 100644 --- a/include/linux/if_vlan.h +++

[PATCH net-next 04/27] qlcnic: remove assumption that vlan_tci != 0

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c index

[PATCH net-next 15/27] ipv4/tunnel: use __vlan_hwaccel helpers

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- net/ipv4/ip_tunnel_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c index fed3d29..0004a54 100644 --- a/net/ipv4/ip_tunnel_core.c +++

[PATCH net-next 00/27] Remove VLAN CFI bit abuse

2016-12-12 Thread Michał Mirosław
Dear NetDevs This series removes an abuse of VLAN CFI bit in Linux networking stack. Currently Linux always clears the bit on outgoing traffic and presents it cleared to userspace (even via AF_PACKET/tcpdump when hw-accelerated). This uses a new vlan_present bit in struct skbuff, and removes an

[PATCH net-next 16/27] nfnetlink/queue: use __vlan_hwaccel helpers

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- net/netfilter/nfnetlink_queue.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c index be7627b..f268bb9 100644 ---

[PATCH net-next 14/27] 8021q: use __vlan_hwaccel helpers

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- net/8021q/vlan_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/8021q/vlan_core.c b/net/8021q/vlan_core.c index e2ed698..604a67a 100644 --- a/net/8021q/vlan_core.c +++ b/net/8021q/vlan_core.c @@ -50,7 +50,7

[PATCH net-next 22/27] net/bpf_jit: SPARC: split VLAN_PRESENT bit handling from VLAN_TCI

2016-12-12 Thread Michał Mirosław
Signed-off-by: Michał Mirosław --- arch/sparc/net/bpf_jit_comp.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/arch/sparc/net/bpf_jit_comp.c b/arch/sparc/net/bpf_jit_comp.c index a6d9204..61cc15d 100644 ---

[PATCH net-next 13/27] bridge: use __vlan_hwaccel helpers

2016-12-12 Thread Michał Mirosław
This removes assumption than vlan_tci != 0 when tag is present. Signed-off-by: Michał Mirosław --- net/bridge/br_netfilter_hooks.c | 14 -- net/bridge/br_private.h | 2 +- net/bridge/br_vlan.c| 6 +++--- 3 files changed, 12

Re: Soft lockup in tc_classify

2016-12-12 Thread Cong Wang
On Mon, Dec 12, 2016 at 1:18 PM, Or Gerlitz wrote: > On Mon, Dec 12, 2016 at 3:28 PM, Daniel Borkmann wrote: > >> Note that there's still the RCU fix missing for the deletion race that >> Cong will still send out, but you say that the only thing you do

Re: [PATCH for-next 0/6] IB/hns: Bug Fixes for HNS RoCE Driver

2016-12-12 Thread Doug Ledford
On 11/29/2016 6:10 PM, Salil Mehta wrote: > This patch-set contains bug fixes for the HNS RoCE driver. > > Lijun Ou (1): > IB/hns: Fix the IB device name > > Shaobo Xu (2): > IB/hns: Fix the bug when free mr > IB/hns: Fix the bug when free cq > > Wei Hu (Xavier) (3): > IB/hns: Fix the

Re: [PATCH net-next 20/27] net/bpf_jit: MIPS: split VLAN_PRESENT bit handling from VLAN_TCI

2016-12-12 Thread Ralf Baechle
I assume you want to merge this together with the rest of you series, so Acked-by: Ralf Baechle Cheers, Ralf On Tue, Dec 13, 2016 at 01:12:39AM +0100, Michał Mirosław wrote: > Date: Tue, 13 Dec 2016 01:12:39 +0100 (CET) > From: Michał Mirosław

Re: [iproute2 net-next 3/8] bpf: Add BPF_ macros

2016-12-12 Thread Daniel Borkmann
On 12/12/2016 01:53 AM, David Ahern wrote: Based on version in kernel repo, samples/bpf/libbpf.h Signed-off-by: David Ahern Acked-by: Daniel Borkmann

Re: [iproute2 net-next 2/8] bpf: export bpf_prog_load

2016-12-12 Thread Daniel Borkmann
On 12/12/2016 01:53 AM, David Ahern wrote: Code move only; no functional change intended. Signed-off-by: David Ahern Acked-by: Daniel Borkmann

Re: [PATCH net-next 2/2] net: ethernet: Initial driver for Synopsys DWC XLGMAC

2016-12-12 Thread kbuild test robot
Hi Jie, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jie-Deng/net-phy-add-extension-of-phy-mode-for-XLGMII/20161207-121843 config: i386-randconfig-h0-12121424 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:

Re: [PATCH] net:phy fix driver reference count error when attach and detach phy device

2016-12-12 Thread maowenan
On 2016/12/5 16:47, maowenan wrote: > > > On 2016/12/2 17:45, David Laight wrote: >> From: Mao Wenan >>> Sent: 30 November 2016 10:23 >>> The nic in my board use the phy dev from marvell, and the system will >>> load the marvell phy driver automatically, but when I remove the phy >>> drivers,

Re: [PATCH v3 0/4] vsock: cancel connect packets when failing to connect

2016-12-12 Thread Peng Tao
On Fri, Dec 9, 2016 at 6:18 PM, Stefan Hajnoczi wrote: > On Fri, Dec 09, 2016 at 01:12:32AM +0800, Peng Tao wrote: >> Currently, if a connect call fails on a signal or timeout (e.g., guest is >> still >> in the process of starting up), we'll just return to caller and leave

Re: Designing a safe RX-zero-copy Memory Model for Networking

2016-12-12 Thread Mike Rapoport
Hello Jesper, On Mon, Dec 05, 2016 at 03:31:32PM +0100, Jesper Dangaard Brouer wrote: > Hi all, > > This is my design for how to safely handle RX zero-copy in the network > stack, by using page_pool[1] and modifying NIC drivers. Safely means > not leaking kernel info in pages mapped to

Re: [iproute2 net-next 1/8] lib bpf: Add support for BPF_PROG_ATTACH and BPF_PROG_DETACH

2016-12-12 Thread Daniel Borkmann
On 12/12/2016 01:53 AM, David Ahern wrote: Signed-off-by: David Ahern Acked-by: Daniel Borkmann

RE: [PATCH] net: add one ethtool option to set relax ordering mode

2016-12-12 Thread maowenan
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Andrew Lunn > Sent: Thursday, December 08, 2016 10:12 PM > To: maowenan > Cc: netdev@vger.kernel.org; jeffrey.t.kirs...@intel.com > Subject: Re: [PATCH] net: add one ethtool

Re: "virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

2016-12-12 Thread Jason Wang
On 2016年12月13日 11:12, Theodore Ts'o wrote: On Tue, Dec 13, 2016 at 04:28:17AM +0200, Michael S. Tsirkin wrote: That's unfortunate, of course. It could be a hypervisor or a guest kernel bug. ideas: - does host have mq capability? how many queues? - how about # of msix vectors? - after you send

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-12 Thread Michael Chan
On Mon, Dec 12, 2016 at 8:52 PM, Selvin Xavier wrote: >> CHECK drivers/infiniband/hw/bnxtre/bnxt_qplib_rcfw.c >> CHECK drivers/infiniband/hw/bnxtre/bnxt_qplib_sp.c >> CHECK drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c >>

Re: "virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

2016-12-12 Thread Theodore Ts'o
On Tue, Dec 13, 2016 at 04:28:17AM +0200, Michael S. Tsirkin wrote: > > That's unfortunate, of course. It could be a hypervisor or > a guest kernel bug. ideas: > - does host have mq capability? how many queues? > - how about # of msix vectors? > - after you send something on tx queues, > are

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-12 Thread Selvin Xavier
On Tue, Dec 13, 2016 at 5:22 AM, Doug Ledford wrote: > > There are outstanding review comments to be addressed still yet, and the > v2 patchset doesn't compile for me in 0day testing. I'm going to bounce > this one to 4.11. I will address all review comments and fix the

Re: [PATCH V2 13/22] bnxt_re: Support QP verbs

2016-12-12 Thread Selvin Xavier
On Mon, Dec 12, 2016 at 11:57 PM, Leon Romanovsky wrote: > It can help to review if you break this function into smaller pieces and > get rid of switch->switch->if construction. Thanks Leon. I will address this and your previous comments in v3 patch set.

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-12 Thread Or Gerlitz
On Tue, Dec 13, 2016 at 1:52 AM, Doug Ledford wrote: > On 12/9/2016 1:47 AM, Selvin Xavier wrote: >> This series introduces the RoCE driver for the Broadcom >> NetXtreme-E 10/25/40/50 gigabit RoCE HCAs. >> This driver is dependent on the bnxt_en NIC driver and is >> based on

Re: stmmac DT property snps,axi_all

2016-12-12 Thread Giuseppe CAVALLARO
Hello Niklas, Alex, my fault and a step behind... Current code is OK when manage the AAL that, although it is passed from the axi structure, it is always used to program, for all the chip versions, the writable bit inside the DMA_BUS_MODE register. So I guess no extra patch is needed. Regards

Re: netlink: GPF in sock_sndtimeo

2016-12-12 Thread Richard Guy Briggs
On 2016-12-09 23:40, Cong Wang wrote: > On Fri, Dec 9, 2016 at 8:13 PM, Cong Wang wrote: > > On Fri, Dec 9, 2016 at 3:01 AM, Richard Guy Briggs wrote: > >> On 2016-12-08 22:57, Cong Wang wrote: > >>> On Thu, Dec 8, 2016 at 10:02 PM, Richard Guy Briggs

Re: [PATCH v2] audit: use proper refcount locking on audit_sock

2016-12-12 Thread Richard Guy Briggs
On 2016-12-12 12:10, Paul Moore wrote: > On Mon, Dec 12, 2016 at 5:03 AM, Richard Guy Briggs wrote: > > Resetting audit_sock appears to be racy. > > > > audit_sock was being copied and dereferenced without using a refcount on > > the source sock. > > > > Bump the refcount on the

Re: "virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

2016-12-12 Thread Theodore Ts'o
On Tue, Dec 13, 2016 at 11:43:00AM +0800, Jason Wang wrote: > Thanks for reporting this issue. Looks like I blindly set the affinity > instead of queues during probe. Could you please try the following patch to > see if it works? This fixed things, thanks!!

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-12 Thread Selvin Xavier
On Mon, Dec 12, 2016 at 10:24 PM, Jonathan Toppins wrote: > CHECK drivers/infiniband/hw/bnxtre/bnxt_re_debugfs.c > CHECK drivers/infiniband/hw/bnxtre/bnxt_qplib_res.c > drivers/infiniband/hw/bnxtre/bnxt_qplib_res.c:729:6: warning: symbol > 'bnxt_qplib_cleanup_pkey_tbl'

Re: Synopsys Ethernet QoS

2016-12-12 Thread Giuseppe CAVALLARO
On 12/12/2016 5:25 PM, Niklas Cassel wrote: On 12/12/2016 11:19 AM, Joao Pinto wrote: Hi, Às 1:44 AM de 12/10/2016, Florian Fainelli escreveu: Le 12/09/16 à 16:16, Andy Shevchenko a écrit : On Sat, Dec 10, 2016 at 12:52 AM, Florian Fainelli wrote: It's kind of sad

Re: "virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

2016-12-12 Thread Michael S. Tsirkin
On Mon, Dec 12, 2016 at 10:12:43PM -0500, Theodore Ts'o wrote: > On Tue, Dec 13, 2016 at 04:28:17AM +0200, Michael S. Tsirkin wrote: > > > > That's unfortunate, of course. It could be a hypervisor or > > a guest kernel bug. ideas: > > - does host have mq capability? how many queues? > > - how

[PATCH iproute2 1/2] tc: flower: Fix typo in the flower man page

2016-12-12 Thread Roi Dayan
Replace vlan_eth_type with vlan_ethtype. Fixes: 745d91726006 ("tc: flower: Introduce vlan support") Signed-off-by: Roi Dayan Reviewed-by: Hadar Hen Zion --- man/man8/tc-flower.8 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH iproute2 2/2] tc: tunnel_key: Add tc-tunnel_key man page to Makefile

2016-12-12 Thread Roi Dayan
To be installed with the other man pages. Fixes: d57639a475a9 ("tc/act_tunnel: Introduce ip tunnel action") Signed-off-by: Roi Dayan Reviewed-by: Amir Vadai --- man/man8/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/man/man8/Makefile

[PATCH iproute2 0/2] Man page fixes

2016-12-12 Thread Roi Dayan
Hi, The 2 patches are man page related only. First fixes a typo and second adding missing man page to the Makefile. Thanks Roi Dayan (2): tc: flower: Fix typo in the flower man page tc: tunnel_key: Add tc-tunnel_key man page to Makefile man/man8/Makefile| 1 + man/man8/tc-flower.8 | 4

Re: [PATCH V2 18/22] bnxt_re: Support for DCB

2016-12-12 Thread Selvin Xavier
On Sat, Dec 10, 2016 at 7:20 PM, Or Gerlitz wrote: > On Fri, Dec 9, 2016 at 8:48 AM, Selvin Xavier > wrote: >> This patch queries the configured RoCE APP Priority on the host >> using the dcbnl API and programs the RoCE FW with the corresponding

Re: [PATCH V2 for-next 00/11] Code improvements & fixes for HNS RoCE driver

2016-12-12 Thread Doug Ledford
On 11/15/2016 1:10 PM, Salil Mehta wrote: > This patchset introduces some code improvements and fixes > for the identified problems in the HNS RoCE driver. > > Lijun Ou (4): > IB/hns: Add the interface for querying QP1 > IB/hns: add self loopback for CM > IB/hns: Modify the condition of

Re: [PATCH net-next 00/27] Remove VLAN CFI bit abuse

2016-12-12 Thread Michał Mirosław
On Tue, Dec 13, 2016 at 01:12:32AM +0100, Michał Mirosław wrote: > Dear NetDevs > > This series removes an abuse of VLAN CFI bit in Linux networking stack. > Currently Linux always clears the bit on outgoing traffic and presents > it cleared to userspace (even via AF_PACKET/tcpdump when

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

2016-12-12 Thread Selvin Xavier
On Mon, Dec 12, 2016 at 10:37 PM, Jason Gunthorpe wrote: > On Sat, Dec 10, 2016 at 11:06:58AM +0530, Selvin Xavier wrote: >> On Fri, Dec 9, 2016 at 12:17 PM, Selvin Xavier >> wrote: >> > I am preparing a git repository with these

Re: [PATCH v2] audit: use proper refcount locking on audit_sock

2016-12-12 Thread Richard Guy Briggs
On 2016-12-12 15:18, Paul Moore wrote: > On Mon, Dec 12, 2016 at 5:03 AM, Richard Guy Briggs wrote: > > Resetting audit_sock appears to be racy. > > > > audit_sock was being copied and dereferenced without using a refcount on > > the source sock. > > > > Bump the refcount on the

[PATCH net] virtio-net: correctly enable multiqueue

2016-12-12 Thread Jason Wang
Commit 4490001029012539937ff02778fe6180613fa949 ("virtio-net: enable multiqueue by default") blindly set the affinity instead of queues during probe which can cause a mismatch of #queues between guest and host. This patch fixes it by setting queues. Reported-by: Theodore Ts'o

[PATCH v2] audit: use proper refcount locking on audit_sock

2016-12-12 Thread Richard Guy Briggs
Resetting audit_sock appears to be racy. audit_sock was being copied and dereferenced without using a refcount on the source sock. Bump the refcount on the underlying sock when we store a refrence in audit_sock and release it when we reset audit_sock. audit_sock modification needs the

Re: [PATCH v3 2/4] vhost-vsock: add pkt cancel capability

2016-12-12 Thread Jorgen S. Hansen
> On Dec 8, 2016, at 6:12 PM, Peng Tao wrote: > > --- a/include/net/af_vsock.h > +++ b/include/net/af_vsock.h > @@ -100,6 +100,9 @@ struct vsock_transport { > void (*destruct)(struct vsock_sock *); > void (*release)(struct vsock_sock *); > > + /* Cancel

Re: [iproute2 net-next 3/8] bpf: Add BPF_ macros

2016-12-12 Thread Hannes Frederic Sowa
On 12.12.2016 01:53, David Ahern wrote: > Based on version in kernel repo, samples/bpf/libbpf.h > > Signed-off-by: David Ahern > --- > include/bpf_util.h | 179 > + > 1 file changed, 179 insertions(+) > > diff --git

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

2016-12-12 Thread Leon Romanovsky
On Mon, Dec 12, 2016 at 12:58:59PM +0200, Ozgur Karatas wrote: > Hello all, > I think should be use to "WARN_ON" and checkpatch script give to error, I > fixed and I think should don't use "BUG_ON". > Regards, > > Signed-off-by: Ozgur Karatas NAK, Leon Romanovsky

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON

2016-12-12 Thread Ozgur Karatas
Dear Stefan; I'm reading to Documentation/SubmittingPatches and I still apologized for misrepresentations my patches. I will add a next time good commit message and commit subjects. Sorry, Regards Ozgur Karatas 12.12.2016, 13:20, "Stefan Schmidt" : > Hello. > > On

Re: [PATCH net] net: dsa: mv88e6xxx: Fix opps when adding vlan bridge

2016-12-12 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > A port is not necessarily assigned to a netdev. And a port does not > need to be a member of a bridge. So when iterating over all ports, > check before using the netdev and bridge_dev for a port. Otherwise we > dereference a NULL pointer. > >

Re: stmmac DT property snps,axi_all

2016-12-12 Thread Giuseppe CAVALLARO
Hello On 12/9/2016 5:06 PM, Alexandre Torgue wrote: Hi Niklas On 12/09/2016 10:53 AM, Niklas Cassel wrote: On 12/09/2016 10:20 AM, Niklas Cassel wrote: On 12/08/2016 02:36 PM, Alexandre Torgue wrote: Hi Niklas, On 12/05/2016 05:18 PM, Niklas Cassel wrote: Hello Giuseppe I'm trying to

Re: Designing a safe RX-zero-copy Memory Model for Networking

2016-12-12 Thread Jesper Dangaard Brouer
On Mon, 12 Dec 2016 10:38:13 +0200 Mike Rapoport wrote: > Hello Jesper, > > On Mon, Dec 05, 2016 at 03:31:32PM +0100, Jesper Dangaard Brouer wrote: > > Hi all, > > > > This is my design for how to safely handle RX zero-copy in the network > > stack, by using

Re: netlink: GPF in sock_sndtimeo

2016-12-12 Thread Richard Guy Briggs
On 2016-12-09 20:13, Cong Wang wrote: > On Fri, Dec 9, 2016 at 3:01 AM, Richard Guy Briggs wrote: > > On 2016-12-08 22:57, Cong Wang wrote: > >> On Thu, Dec 8, 2016 at 10:02 PM, Richard Guy Briggs > >> wrote: > >> > I also tried to extend Cong Wang's idea to

Re: [PATCH v2 1/4] net: hix5hd2_gmac: add generic compatible string

2016-12-12 Thread Dongpo Li
Hi Rob, On 2016/12/10 6:35, Rob Herring wrote: > On Mon, Dec 05, 2016 at 09:27:58PM +0800, Dongpo Li wrote: >> The "hix5hd2" is SoC name, add the generic ethernet driver name. >> The "hisi-gemac-v1" is the basic version and "hisi-gemac-v2" adds >> the SG/TXCSUM/TSO/UFO features. >> >>

[patch net-next] irda: w83977af_ir: cleanup an indent issue

2016-12-12 Thread Dan Carpenter
In commit 99d8d2159d7c ("irda: w83977af_ir: Neaten logging"), we accidentally added an extra tab to these lines. Signed-off-by: Dan Carpenter diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index f293d33fb28f..8d5b903d1d9d 100644 ---

Re: [PATCH v3 2/4] vhost-vsock: add pkt cancel capability

2016-12-12 Thread Peng Tao
On Mon, Dec 12, 2016 at 6:37 PM, Jorgen S. Hansen wrote: > >> On Dec 8, 2016, at 6:12 PM, Peng Tao wrote: >> >> --- a/include/net/af_vsock.h >> +++ b/include/net/af_vsock.h >> @@ -100,6 +100,9 @@ struct vsock_transport { >> void (*destruct)(struct

RE: [RFC PATCH net-next v3 1/2] macb: Add 1588 support in Cadence GEM.

2016-12-12 Thread Andrei.Pistirica
> -Original Message- > From: Rafal Ozieblo [mailto:raf...@cadence.com] > Sent: Friday, December 09, 2016 11:20 AM > To: Andrei Pistirica - M16132; richardcoch...@gmail.com > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org;

[PATCH v2] net: macb: Added PCI wrapper for Platform Driver.

2016-12-12 Thread Bartosz Folta
There are hardware PCI implementations of Cadence GEM network controller. This patch will allow to use such hardware with reuse of existing Platform Driver. Signed-off-by: Bartosz Folta --- Changed in v2: Respin to net-next. Changed patch formatting. ---

[PATCH 1/1] Fixed to BUG_ON to WARN_ON def

2016-12-12 Thread Ozgur Karatas
Hello all, I think should be use to "WARN_ON" and checkpatch script give to error, I fixed and I think should don't use "BUG_ON". Regards, Signed-off-by: Ozgur Karatas --- drivers/net/ethernet/mellanox/mlx4/icm.c | 4 ++-- diff --git

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

2016-12-12 Thread Stefan Schmidt
Hello. On 12/12/16 11:58, Ozgur Karatas wrote: Hello all, I think should be use to "WARN_ON" and checkpatch script give to error, I fixed and I think should don't use "BUG_ON". Regards, Signed-off-by: Ozgur Karatas I pointed you already before to the Documentation

Re: [iproute2 net-next 3/8] bpf: Add BPF_ macros

2016-12-12 Thread Daniel Borkmann
On 12/12/2016 12:28 PM, Hannes Frederic Sowa wrote: On 12.12.2016 01:53, David Ahern wrote: Based on version in kernel repo, samples/bpf/libbpf.h Signed-off-by: David Ahern --- include/bpf_util.h | 179 + 1 file

[no subject]

2016-12-12 Thread Brianna Falzone
My name is Brianna Falzone , I am a United State Army officer, i saw your mail on google search please reply to me So that we know better. I hope to read Thanks and hope to hear from you soon. Regards Brianna

Re: 4.9.0-rc8: tg3 dead after resume

2016-12-12 Thread Siva Reddy Kallam
On Fri, Dec 9, 2016 at 7:59 PM, Billy Shuman wrote: > On Thu, Dec 8, 2016 at 4:03 AM, Siva Reddy Kallam > wrote: >> On Thu, Dec 8, 2016 at 12:14 AM, Billy Shuman wrote: >>> On Wed, Dec 7, 2016 at 12:37 PM, Michael Chan

[PATCH v4 2/4] vhost-vsock: add pkt cancel capability

2016-12-12 Thread Peng Tao
To allow canceling all packets of a connection. Reviewed-by: Stefan Hajnoczi Signed-off-by: Peng Tao --- drivers/vhost/vsock.c | 41 + include/net/af_vsock.h | 3 +++ 2 files changed, 44 insertions(+) diff

[PATCH v4 1/4] vsock: track pkt owner vsock

2016-12-12 Thread Peng Tao
So that we can cancel a queued pkt later if necessary. Signed-off-by: Peng Tao --- include/linux/virtio_vsock.h| 2 ++ net/vmw_vsock/virtio_transport_common.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/include/linux/virtio_vsock.h

[PATCH v4 4/4] vsock: cancel packets when failing to connect

2016-12-12 Thread Peng Tao
Otherwise we'll leave the packets queued until releasing vsock device. E.g., if guest is slow to start up, resulting ETIMEDOUT on connect, guest will get the connect requests from failed host sockets. Reviewed-by: Stefan Hajnoczi Reviewed-by: Jorgen Hansen

[PATCH v4 3/4] vsock: add pkt cancel capability

2016-12-12 Thread Peng Tao
Reviewed-by: Stefan Hajnoczi Signed-off-by: Peng Tao --- net/vmw_vsock/virtio_transport.c | 42 1 file changed, 42 insertions(+) diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c

[PATCH v4 0/4] vsock: cancel connect packets when failing to connect

2016-12-12 Thread Peng Tao
Currently, if a connect call fails on a signal or timeout (e.g., guest is still in the process of starting up), we'll just return to caller and leave the connect packet queued and they are sent even though the connection is considered a failure, which can confuse applications with unwanted false

Re: [PATCH net] net: dsa: mv88e6xxx: Fix opps when adding vlan bridge

2016-12-12 Thread Andrew Lunn
On Sun, Dec 11, 2016 at 04:02:37PM -0500, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > @@ -1804,6 +1807,9 @@ static int mv88e6xxx_port_check_hw_vlan(struct > > dsa_switch *ds, int port, > > chip->ports[port].bridge_dev) > >

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

2016-12-12 Thread Ozgur Karatas
Dear Romanovsky; I'm trying to learn english and I apologize for my mistake words and phrases. So, I think the code when call to "sg_set_buf" and next time set memory and buffer. For example, isn't to call "WARN_ON" function, get a error to implicit declaration, right? Because, you will use

  1   2   >