Re: stmmac driver...

Hello Jie On 12/14/2016 5:05 AM, Jie Deng wrote: Hi Peppe, On 2016/12/12 22:17, Giuseppe CAVALLARO wrote: Hi David On 12/7/2016 7:06 PM, David Miller wrote: Giuseppe and Alexandre, There are a lot of patches and discussions happening around the stammc driver lately and both of you are

Re: [PATCH] vhost: introduce O(1) vq metadata cache

On 2016年12月14日 16:14, kbuild test robot wrote: Hi Jason, [auto build test WARNING on vhost/linux-next] [also build test WARNING on v4.9 next-20161214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH] vhost: introduce O(1) vq metadata cache

Hi Jason, [auto build test WARNING on vhost/linux-next] [also build test WARNING on v4.9 next-20161214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jason-Wang/vhost-introduce-O-1-vq-metadata

Re: [PATCH v2 net-next 1/2] phy: add phy fixup unregister functions

Hi all, On 2016/12/8 4:26, woojung@microchip.com wrote: >>From : Woojung Huh > > Add functions to unregister phy fixup for modules. > > int phy_unregister_fixup(const char *bus_id, u32 phy_uid, u32 phy_uid_mask) > Unregister phy fixup from phy_fixup_list

[PATCH] net: davicom: dm9000: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/davicom/dm9000.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git

Re: [Query] Delayed vxlan socket creation?

On Wed, 14 Dec 2016 07:49:24 +, Du, Fan wrote: > I'm interested to one Docker issue[1] which looks like related to kernel > vxlan socket creation > as described in the thread. From my limited knowledge here, socket creation > is synchronous , > and after the *socket* syscall, the sock handle

Re: stmmac driver...

Hi David, Giuseppe and Alexandre, There are a lot of patches and discussions happening around the stammc driver lately and both of you are listed as the maintainers. I really need prompt and conclusive reviews of these patch submissions from you, and

Re: Designing a safe RX-zero-copy Memory Model for Networking

On Tue, 13 Dec 2016 12:08:21 -0800 John Fastabend wrote: > On 16-12-13 11:53 AM, David Miller wrote: > > From: John Fastabend > > Date: Tue, 13 Dec 2016 09:43:59 -0800 > > > >> What does "zero-copy send packet-pages to the

Hi

I am Mrs Nicole Marois, i have a pending project of fulfillment to put in your hand, i will need your support to make this dream come through, could you let me know your interest to enable me give you further information, and I hereby advice that you send the below mentioned information I decided

[no subject]

Good Day, This is the second time i am sending you this mail. I, Friedrich Mayrhofer Donate $ 1,000,000.00 to You, Email Me personally for more details. Regards. Friedrich Mayrhofer

RE: [PATCH 1/3] siphash: add cryptographically secure hashtable function

From: Jason A. Donenfeld > Sent: 14 December 2016 00:17 > SipHash is a 64-bit keyed hash function that is actually a > cryptographically secure PRF, like HMAC. Except SipHash is super fast, > and is meant to be used as a hashtable keyed lookup function. > > SipHash isn't just some new trendy hash

Re: sctp: suspicious rcu_dereference_check() usage in sctp_epaddr_lookup_transport

On Wed, Dec 14, 2016 at 5:37 AM, Marcelo Ricardo Leitner wrote: > On Tue, Dec 13, 2016 at 07:07:01PM +0100, Dmitry Vyukov wrote: >> Hello, >> >> I am getting the following reports while running syzkaller fuzzer: >> >> [ INFO: suspicious RCU usage. ] >> 4.9.0+ #85 Not

[RFC PATCH net-next v4 2/2] macb: Enable 1588 support in SAMA5Dx platforms.

This patch does the following: - Enable HW time stamp for the following platforms: SAMA5D2, SAMA5D3 and SAMA5D4. - HW time stamp capabilities are advertised via ethtool and macb ioctl is updated accordingly. - HW time stamp on the PTP Ethernet packets are received using the SO_TIMESTAMPING

Re: [PATCH net-next 1/3] net:dsa:mv88e6xxx: use hashtable to store multicast entries

On Wed, Dec 14, 2016 at 11:03:14AM +0100, Volodymyr Bendiuga wrote: > Hi, > > I understand what you wrote, but we do not refresh anything > at intervals. FDB dump works only on user request, i.e. user > run bridge fdb dump command. What we did is just a smarter > way of feeding the dump request

Re: net/arp: ARP cache aging failed.

On 2016/11/26 4:40, Julian Anastasov wrote: > > Hello, > > On Fri, 25 Nov 2016, Hannes Frederic Sowa wrote: > >> On 25.11.2016 09:18, Julian Anastasov wrote: >>> >>> Another option would be to add similar bit to >>> struct sock (sk_dst_pending_confirm), may be ip_finish_output2 >>>

dsa: handling more than 1 cpu port

Hi Andrew, switches supported by qca8k have 2 gmacs that we can wire an external mii interface to. Usually this is used to wire 2 of the SoCs MACs to the switch. Thw switch itself is aware of one of the MACs being the cpu port and expects this to be port/mac0. Using the other will break the

Re: [PATCH 2/3] selftests: do not require bash to run bpf tests

On 12/14/2016 11:58 AM, Rolf Eike Beer wrote: From b9d6c1b7427d708ef2d4d57aac17b700b3694d71 Mon Sep 17 00:00:00 2001 From: Rolf Eike Beer Date: Wed, 14 Dec 2016 09:58:12 +0100 Subject: [PATCH 2/3] selftests: do not require bash to run bpf tests Nothing in this minimal

Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function

Hello, On 14.12.2016 04:59, Jason A. Donenfeld wrote: > SipHash is a 64-bit keyed hash function that is actually a > cryptographically secure PRF, like HMAC. Except SipHash is super fast, > and is meant to be used as a hashtable keyed lookup function. Can you show or cite benchmarks in

Re: dsa: handling more than 1 cpu port

On Wed, Dec 14, 2016 at 11:35:30AM +0100, John Crispin wrote: > > > On 14/12/2016 11:31, Andrew Lunn wrote: > > On Wed, Dec 14, 2016 at 11:01:54AM +0100, John Crispin wrote: > >> Hi Andrew, > >> > >> switches supported by qca8k have 2 gmacs that we can wire an external > >> mii interface to.

[PATCH 2/3] selftests: do not require bash to run bpf tests

>From b9d6c1b7427d708ef2d4d57aac17b700b3694d71 Mon Sep 17 00:00:00 2001 From: Rolf Eike Beer Date: Wed, 14 Dec 2016 09:58:12 +0100 Subject: [PATCH 2/3] selftests: do not require bash to run bpf tests Nothing in this minimal script seems to require bash. We often run these

RE: [PATCH 3/3] secure_seq: use fast siphash instead of slow md5

From: Jason A. Donenfeld > Sent: 14 December 2016 00:17 > This gives a clear speed and security improvement. Rather than manually > filling MD5 buffers, we simply create a layout by a simple anonymous > struct, for which gcc generates rather efficient code. ... > + const struct { > +

[RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence GEM.

Cadence GEM provides a 102 bit time counter with 48 bits for seconds, 30 bits for nsecs and 24 bits for sub-nsecs to control 1588 timestamping. This patch does the following: - Registers to ptp clock framework - Timer initialization is done by writing time of day to the timer counter. - ns

Re: dsa: handling more than 1 cpu port

On Wed, Dec 14, 2016 at 11:01:54AM +0100, John Crispin wrote: > Hi Andrew, > > switches supported by qca8k have 2 gmacs that we can wire an external > mii interface to. Usually this is used to wire 2 of the SoCs MACs to the > switch. Thw switch itself is aware of one of the MACs being the cpu

Re: dsa: handling more than 1 cpu port

On 14/12/2016 12:00, Andrew Lunn wrote: > On Wed, Dec 14, 2016 at 11:35:30AM +0100, John Crispin wrote: >> >> >> On 14/12/2016 11:31, Andrew Lunn wrote: >>> On Wed, Dec 14, 2016 at 11:01:54AM +0100, John Crispin wrote: Hi Andrew, switches supported by qca8k have 2 gmacs that we

[PATCH V2] vhost: introduce O(1) vq metadata cache

When device IOTLB is enabled, all address translations were stored in interval tree. O(lgN) searching time could be slow for virtqueue metadata (avail, used and descriptors) since they were accessed much often than other addresses. So this patch introduces an O(1) array which points to the

Re: dsa: handling more than 1 cpu port

On 14/12/2016 11:31, Andrew Lunn wrote: > On Wed, Dec 14, 2016 at 11:01:54AM +0100, John Crispin wrote: >> Hi Andrew, >> >> switches supported by qca8k have 2 gmacs that we can wire an external >> mii interface to. Usually this is used to wire 2 of the SoCs MACs to the >> switch. Thw switch

Re: Re: Synopsys Ethernet QoS

Hi! > There are some performance problems with the stmmac driver though: > > When running iperf3 with 3 streams: > iperf3 -c 192.168.0.90 -P 3 -t 30 > iperf3 -c 192.168.0.90 -P 3 -t 30 -R > > I get really bad fairness between the streams. > > This appears to be an issue with how TX IRQ

Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function

Hi David, On Wed, Dec 14, 2016 at 10:56 AM, David Laight wrote: > ... >> +u64 siphash24(const u8 *data, size_t len, const u8 key[SIPHASH24_KEY_LEN]) > ... >> + u64 k0 = get_unaligned_le64(key); >> + u64 k1 = get_unaligned_le64(key + sizeof(u64)); > ... >> +

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

Thanks Ozgur for your report. On 12/12/2016 8:18 PM, Leon Romanovsky wrote: On Mon, Dec 12, 2016 at 03:04:28PM +0200, Ozgur Karatas wrote: Dear Romanovsky; Please avoid top-posting in your replies. Thanks I'm trying to learn english and I apologize for my mistake words and phrases. So, I

Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function

Hi Hannes, On Wed, Dec 14, 2016 at 12:21 PM, Hannes Frederic Sowa wrote: > Can you show or cite benchmarks in comparison with jhash? Last time I > looked, especially for short inputs, siphash didn't beat jhash (also on > all the 32 bit devices etc.). I assume that

Re: Synopsys Ethernet QoS

Hi, Às 12:57 PM de 12/14/2016, Pavel Machek escreveu: > Hi! > >> So if there is a long time before handling interrupts, >> I guess that it makes sense that one stream could >> get an advantage in the net scheduler. >> >> If I find the time, and if no one beats me to it, I will try to replace >>

Re: [PATCH v2 3/4] secure_seq: use siphash24 instead of md5_transform

Hi David, On Wed, Dec 14, 2016 at 10:51 AM, David Laight wrote: > From: Jason A. Donenfeld >> Sent: 14 December 2016 00:17 >> This gives a clear speed and security improvement. Rather than manually >> filling MD5 buffers, we simply create a layout by a simple anonymous

Re: [net-next PATCH v5 1/6] net: virtio dynamically disable/enable LRO

On Thu, Dec 08, 2016 at 04:04:58PM -0800, John Fastabend wrote: > On 16-12-08 01:36 PM, Michael S. Tsirkin wrote: > > On Wed, Dec 07, 2016 at 12:11:11PM -0800, John Fastabend wrote: > >> This adds support for dynamically setting the LRO feature flag. The > >> message to control guest features in

Re: [PATCHv3 perf/core 0/7] Reuse libbpf from samples/bpf

Em Fri, Dec 09, 2016 at 04:30:54PM +0100, Daniel Borkmann escreveu: > Hi Arnaldo, > > On 12/09/2016 04:09 PM, Arnaldo Carvalho de Melo wrote: > > Em Thu, Dec 08, 2016 at 06:46:13PM -0800, Joe Stringer escreveu: > > > (Was "libbpf: Synchronize implementations") > > > > > > Update tools/lib/bpf to

Re: [PATCH] arp: do neigh confirm based on sk arg

Hi YueHaibing, [auto build test WARNING on v4.9-rc8] [cannot apply to net/master net-next/master sparc-next/master next-20161214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/YueHaibing/arp

Re: [PATCHv2 2/5] sh_eth: enable wake-on-lan for Gen2 devices

Hello! You forgot "R-Car" before "Gen2" in the subject. On 12/12/2016 07:09 PM, Niklas Söderlund wrote: Tested on Gen2 r8a7791/Koelsch. Signed-off-by: Niklas Söderlund --- drivers/net/ethernet/renesas/sh_eth.c | 6 -- 1 file changed, 4

Re: [PATCH v2 3/4] secure_seq: use siphash24 instead of md5_transform

Hi Hannes, Thanks for the feedback. > __packed not only removes all padding of the struct but also changes the > alignment assumptions for the whole struct itself. The rule, the struct > is aligned by its maximum alignment of a member is no longer true. That > said, the code accessing this

Re: [PATCH] arp: do neigh confirm based on sk arg

Hi YueHaibing, [auto build test WARNING on v4.9-rc8] [cannot apply to net/master net-next/master sparc-next/master next-20161214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/YueHaibing/arp

Re: Synopsys Ethernet QoS

Hi! > So if there is a long time before handling interrupts, > I guess that it makes sense that one stream could > get an advantage in the net scheduler. > > If I find the time, and if no one beats me to it, I will try to replace > the normal timers with HR timers + a smaller default timeout. >

Re: [PATCH] vsock: lookup and setup guest_cid inside vhost_vsock_lock

On Wed, Dec 14, 2016 at 07:24:36PM +0800, Gao feng wrote: > Multi vsocks may setup the same cid at the same time. > > Signed-off-by: Gao feng > --- > drivers/vhost/vsock.c | 25 + > 1 file changed, 17 insertions(+), 8 deletions(-) Good catch, a

Re: [PATCH v2 3/4] secure_seq: use siphash24 instead of md5_transform

On 14.12.2016 13:53, Jason A. Donenfeld wrote: > Hi David, > > On Wed, Dec 14, 2016 at 10:51 AM, David Laight > wrote: >> From: Jason A. Donenfeld >>> Sent: 14 December 2016 00:17 >>> This gives a clear speed and security improvement. Rather than manually >>> filling

Re: [PATCH 3/3] netns: fix net_generic() "id - 1" bloat

On Tue, Dec 13, 2016 at 5:42 PM, David Laight wrote: > From: Alexey Dobriyan >> Sent: 13 December 2016 14:23 > ... >> Well, the point of the patch is to save .text, so might as well save >> as much as possible. Any form other than "ptr[id]" is going >> to be either bigger

Re: [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit

On Tue, Dec 13, 2016 at 05:21:18PM -0800, Stephen Hemminger wrote: > On Sat, 3 Dec 2016 10:22:28 +0100 (CET) > Michał Mirosław wrote: > > > This All-in-one patch removes abuse of VLAN CFI bit, so it can be passed > > intact through linux networking stack. > > > >

Re: [v1] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL error from devm_ioremap

Hi Arvind, [auto build test ERROR on net-next/master] [also build test ERROR on v4.9 next-20161214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arvind-Yadav/net-ethernet-cavium-octeon

RE: [PATCH 3/3] netns: fix net_generic() "id - 1" bloat

From: Alexey Dobriyan > Sent: 14 December 2016 13:20 ... > > If you have foo->bar[id - const] then the compiler has to add the > > offset of 'bar' and subtract for 'const'. > > If the numbers match no add or subtract is needed. > > > > It is much cleaner to do this by explicitly removing the

[PATCH] vsock: lookup and setup guest_cid inside vhost_vsock_lock

Multi vsocks may setup the same cid at the same time. Signed-off-by: Gao feng --- drivers/vhost/vsock.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index e3b30ea..a08332b

Re: [PATCH 2/3] selftests: do not require bash to run bpf tests

On 12/14/2016 04:03 AM, Daniel Borkmann wrote: > On 12/14/2016 11:58 AM, Rolf Eike Beer wrote: >> From b9d6c1b7427d708ef2d4d57aac17b700b3694d71 Mon Sep 17 00:00:00 2001 >> From: Rolf Eike Beer >> Date: Wed, 14 Dec 2016 09:58:12 +0100 >> Subject: [PATCH 2/3] selftests: do

RE: [PATCH v2 3/4] secure_seq: use siphash24 instead of md5_transform

From: Jason A. Donenfeld > Sent: 14 December 2016 13:44 > To: Hannes Frederic Sowa > > __packed not only removes all padding of the struct but also changes the > > alignment assumptions for the whole struct itself. The rule, the struct > > is aligned by its maximum alignment of a member is no

Re: Designing a safe RX-zero-copy Memory Model for Networking

On Wed, Dec 14, 2016 at 8:32 AM, John Fastabend wrote: > On 16-12-14 01:39 AM, Jesper Dangaard Brouer wrote: >> On Tue, 13 Dec 2016 12:08:21 -0800 >> John Fastabend wrote: >> >>> On 16-12-13 11:53 AM, David Miller wrote: From: John

Re: Designing a safe RX-zero-copy Memory Model for Networking

On Tue, 13 Dec 2016, Hannes Frederic Sowa wrote: > > Interesting. So you even imagine sockets registering memory regions > > with the NIC. If we had a proper NIC HW filter API across the drivers, > > to register the steering rule (like ibv_create_flow), this would be > > doable, but we don't

[PATCH net 0/2] net/sched: cls_flower: Fix mask handling

Hi, The series fix how the mask is being handled. Thanks. Paul Blakey (2): net/sched: cls_flower: Use mask for addr_type net/sched: cls_flower: Use masked key when calling HW offloads net/sched/cls_flower.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) -- 1.8.3.1

[PATCH net 1/2] net/sched: cls_flower: Use mask for addr_type

When addr_type is set, mask should also be set. Fixes: 66530bdf85eb ('sched,cls_flower: set key address type when present') Fixes: bc3103f1ed40 ('net/sched: cls_flower: Classify packet in ip tunnels') Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan

[PATCH net 2/2] net/sched: cls_flower: Use masked key when calling HW offloads

Zero bits on the mask signify a "don't care" on the corresponding bits in key. Some HWs require those bits on the key to be zero. Since these bits are masked anyway, it's okay to provide the masked key to all drivers. Fixes: 5b33f48842fa ('net/flower: Introduce hardware offload support')

[PATCH RFC 2/2] bpf: Add tests for the lpm trie map

From: David Herrmann The first part of this program runs randomized tests against the lpm-bpf-map. It implements a "Trivial Longest Prefix Match" (tlpm) based on simple, linear, single linked lists. The implementation should be pretty straightforward. Based on tlpm, this

[PATCH RFC 1/2] bpf: add a longest prefix match trie map implementation

This trie implements a longest prefix match algorithm that can be used to match IP addresses to a stored set of ranges. Internally, data is stored in an unbalanced trie of nodes that has a maximum height of n, where n is the prefixlen the trie was created with. Tries may be created with prefix

[PATCH RFC 0/2] bpf: add longest prefix match map

This patch set adds longest prefix match algorithm that can be used to match IP addresses to a stored set of ranges. It is exposed as a bpf map type. Internally, data is stored in an unbalanced tree of nodes that has a maximum height of n, where n is the prefixlen the trie was created with.

Re: dsa: handling more than 1 cpu port

On 14/12/2016 12:00, Andrew Lunn wrote: > On Wed, Dec 14, 2016 at 11:35:30AM +0100, John Crispin wrote: >> >> >> On 14/12/2016 11:31, Andrew Lunn wrote: >>> On Wed, Dec 14, 2016 at 11:01:54AM +0100, John Crispin wrote: Hi Andrew, switches supported by qca8k have 2 gmacs that we

ipv6: handle -EFAULT from skb_copy_bits

It seems to be possible to craft a packet for sendmsg that triggers the -EFAULT path in skb_copy_bits resulting in a BUG_ON that looks like: RIP: 0010:[] [] rawv6_sendmsg+0xc30/0xc40 RSP: 0018:881f6c4a7c18 EFLAGS: 00010282 RAX: fff2 RBX: 881f6c681680 RCX: 0002

ravb/sh_eth/b44: BUG: sleeping function called from invalid context

Hi, When CONFIG_DEBUG_ATOMIC_SLEEP=y, running "ethtool -s eth0 speed 100" on Salvator-X gives: BUG: sleeping function called from invalid context at kernel/locking/mutex.c:97 in_atomic(): 1, irqs_disabled(): 128, pid: 1683, name: ethtool CPU: 0 PID: 1683 Comm: ethtool Tainted: GW

Re: [PATCH net] ibmveth: calculate gso_segs for large packets

On Tue, Dec 13, 2016 at 06:15:09PM -0600, Thomas Falcon wrote: > Include calculations to compute the number of segments > that comprise an aggregated large packet. > > Signed-off-by: Thomas Falcon Reviewed-by: Marcelo Ricardo Leitner >

Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function

Hey Tom, Just following up on what I mentioned in my last email... On Wed, Dec 14, 2016 at 8:35 PM, Jason A. Donenfeld wrote: > I think your suggestion for (2) will contribute to further > optimizations for (1). In v2, I had another patch in there adding > siphash_1word,

Re: [PATCH v3 2/3] secure_seq: use siphash24 instead of md5_transform

Hi Jason, [auto build test ERROR on linus/master] [also build test ERROR on next-20161214] [cannot apply to v4.9] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jason-A-Donenfeld/siphash-add

Re: [PATCH] infiniband: nes: nes_nic: use new api ethtool_{get|set}_link_ksettings

On 10/25/2016 11:29 AM, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Thanks, applied. -- Doug Ledford GPG Key ID: 0E572FDD

[PATCH net] net: vrf: Fix NAT within a VRF

Connection tracking with VRF is broken because the pass through the VRF device drops the connection tracking info. Removing the call to nf_reset allows DNAT and MASQUERADE to work across interfaces within a VRF. Fixes: 73e20b761acf ("net: vrf: Add support for PREROUTING rules on vrf device")

[PATCH net] vxlan: fix unused variable warning

Fixes commit 4528520d315ac1 ("vxlan: add ipv6 proxy support") which added code that caused this warning: drivers/net/vxlan.c: In function ‘neigh_reduce’: drivers/net/vxlan.c:1556:25: warning: variable ‘saddr’ set but not used Signed-off-by: Stephen Hemminger ---

Re: [v3] net: ethernet: cavium: octeon: octeon_mgmt: Handle return NULL error from devm_ioremap

On 12/14/2016 11:03 AM, Arvind Yadav wrote: Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. This error check will avoid NULL pointer dereference. I have asked you twice already this question, but could not determine from your response what

Re: Designing a safe RX-zero-copy Memory Model for Networking

On 14.12.2016 20:43, Christoph Lameter wrote: > On Wed, 14 Dec 2016, David Laight wrote: > >> If the kernel is doing ANY validation on the frames it must copy the >> data to memory the application cannot modify before doing the validation. >> Otherwise the application could change the data

Re: [PATCH v2 3/4] secure_seq: use siphash24 instead of md5_transform

On Wed, Dec 14, 2016 at 9:12 PM, Tom Herbert wrote: > If you pad the data structure to 64 bits then we can call the version > of siphash that only deals in 64 bit words. Writing a zero in the > padding will be cheaper than dealing with odd lengths in siphash24. On Wed, Dec

Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function

Interesting. Evidently gcc 4.8 doesn't like my use of: enum siphash_lengths { SIPHASH24_KEY_LEN = 16, SIPHASH24_ALIGNMENT = 8 }; I'll convert this to the more boring: #define SIPHASH24_KEY_LEN 16 #define SIPHASH24_ALIGNMENT 8

Re: Designing a safe RX-zero-copy Memory Model for Networking

On Wed, 14 Dec 2016, Hannes Frederic Sowa wrote: > Wouldn't changing of the pages cause expensive TLB flushes? Yes so you would only want that feature if its realized at the page table level for debugging issues. Once you have memory registered with the hardware device then also the device

Re: [PATCH v3 3/3] random: use siphash24 instead of md5 for get_random_int/long

Hi Jason, [auto build test ERROR on linus/master] [also build test ERROR on next-20161214] [cannot apply to v4.9] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jason-A-Donenfeld/siphash-add

Re: [PATCH v2 3/4] secure_seq: use siphash24 instead of md5_transform

Hey Jason, On 14.12.2016 20:38, Jason A. Donenfeld wrote: > On Wed, Dec 14, 2016 at 8:22 PM, Hannes Frederic Sowa > wrote: >> I don't think this helps. Did you test it? I don't see reason why >> padding could be left out between `d' and `end' because of the flexible

Re: Designing a safe RX-zero-copy Memory Model for Networking

On Wed, 14 Dec 2016 08:32:10 -0800 John Fastabend wrote: > On 16-12-14 01:39 AM, Jesper Dangaard Brouer wrote: > > On Tue, 13 Dec 2016 12:08:21 -0800 > > John Fastabend wrote: > > > >> On 16-12-13 11:53 AM, David Miller wrote: > >>> From:

Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function

Hi Jason, [auto build test ERROR on linus/master] [also build test ERROR on v4.9 next-20161214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jason-A-Donenfeld/siphash-add-cryptographically

Re: Designing a safe RX-zero-copy Memory Model for Networking

On Wed, 14 Dec 2016 08:45:08 -0800 Alexander Duyck wrote: > I agree. This is a no-go from the performance perspective as well. > At a minimum you would have to be zeroing out the page between uses to > avoid leaking data, and that assumes that the program we are

Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function

On 14.12.2016 13:46, Jason A. Donenfeld wrote: > Hi David, > > On Wed, Dec 14, 2016 at 10:56 AM, David Laight > wrote: >> ... >>> +u64 siphash24(const u8 *data, size_t len, const u8 key[SIPHASH24_KEY_LEN]) >> ... >>> + u64 k0 = get_unaligned_le64(key); >>> + u64

Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function

On Wed, Dec 14, 2016 at 12:55 PM, Jason A. Donenfeld wrote: > Hey Tom, > > Just following up on what I mentioned in my last email... > > On Wed, Dec 14, 2016 at 8:35 PM, Jason A. Donenfeld wrote: >> I think your suggestion for (2) will contribute to further >>

Re: [PATCH v3 3/3] random: use siphash24 instead of md5 for get_random_int/long

Hi Jason, [auto build test ERROR on linus/master] [also build test ERROR on next-20161214] [cannot apply to v4.9] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jason-A-Donenfeld/siphash-add

[PATCH v3 3/3] random: use siphash24 instead of md5 for get_random_int/long

This duplicates the current algorithm for get_random_int/long, but uses siphash24 instead. This comes with several benefits. It's certainly faster and more cryptographically secure than MD5. This patch also hashes the pid, entropy, and timestamp as fixed width fields, in order to increase

[PATCH v3 2/3] secure_seq: use siphash24 instead of md5_transform

This gives a clear speed and security improvement. Siphash is both faster and is more solid crypto than the aging MD5. Rather than manually filling MD5 buffers, we simply create a layout by a simple anonymous struct, for which gcc generates rather efficient code. Signed-off-by: Jason A.

[PATCH v3 1/3] siphash: add cryptographically secure hashtable function

SipHash is a 64-bit keyed hash function that is actually a cryptographically secure PRF, like HMAC. Except SipHash is super fast, and is meant to be used as a hashtable keyed lookup function. SipHash isn't just some new trendy hash function. It's been around for a while, and there really isn't

Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function

Hi Hannes, On Wed, Dec 14, 2016 at 4:09 PM, Hannes Frederic Sowa wrote: > Yes, numbers would be very usable here. I am mostly concerned about > small plastic router cases. E.g. assume you double packet processing > time with a change of the hashing function at what

Re: [kernel-hardening] Re: [PATCH 4/3] random: use siphash24 instead of md5 for get_random_int/long

Hey Ted, On Wed, Dec 14, 2016 at 5:37 PM, Theodore Ts'o wrote: > One somewhat undesirable aspect of the current algorithm is that we > never change random_int_secret. Why exactly would this be a problem? So long as the secret is kept secret, the PRF is secure. If an attacker can

Re: [PATCH v2 3/4] secure_seq: use siphash24 instead of md5_transform

Hi Hannes, On Wed, Dec 14, 2016 at 8:22 PM, Hannes Frederic Sowa wrote: > I don't think this helps. Did you test it? I don't see reason why > padding could be left out between `d' and `end' because of the flexible > array member? Because the type u8 doesn't require

RE: Designing a safe RX-zero-copy Memory Model for Networking

On Wed, 14 Dec 2016, David Laight wrote: > If the kernel is doing ANY validation on the frames it must copy the > data to memory the application cannot modify before doing the validation. > Otherwise the application could change the data afterwards. The application is not allowed to change the

Re: [PATCH scsi 0/3] cxgb4i: add support for Chelsio T6 adapters

> "Varun" == Varun Prakash writes: Varun> This patch series adds support for Chelsio T6 adapters in iSCSI Varun> initiator offload driver(cxgb4i). Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 3/4] secure_seq: use siphash24 instead of md5_transform

On Wed, Dec 14, 2016 at 4:53 AM, Jason A. Donenfeld wrote: > Hi David, > > On Wed, Dec 14, 2016 at 10:51 AM, David Laight > wrote: >> From: Jason A. Donenfeld >>> Sent: 14 December 2016 00:17 >>> This gives a clear speed and security improvement. Rather

Re: [PATCH v2 3/4] secure_seq: use siphash24 instead of md5_transform

On Wed, Dec 14, 2016 at 3:47 PM, David Laight wrote: > Just remove the __packed and ensure that the structure is 'nice'. > This includes ensuring there is no 'tail padding'. > In some cases you'll need to put the port number into a 32bit field. I'd rather not. There's no

Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL error from devm_ioremap

Yes, I have seen this error. We have a device with very less memory. Basically it's OMAP2 board. We have to port Android L on this. It's has 3.10 kernel version. In this device, we were getting Page allocation failure. Vmalloc size was not enough to run all application. So we have decide to

Re: [PATCH v2 3/4] secure_seq: use siphash24 instead of md5_transform

Hi David, On Wed, Dec 14, 2016 at 6:56 PM, David Miller wrote: > Just marking the structure __packed, whether necessary or not, makes > the compiler assume that the members are not aligned and causes > byte-by-byte accesses to be performed for words. > Never, _ever_, use

Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL error from devm_ioremap

On 12/14/2016 10:06 AM, arvind Yadav wrote: Yes, I have seen this error. We have a device with very less memory. Basically it's OMAP2 board. We have to port Android L on this. It's has 3.10 kernel version. In this device, we were getting Page allocation failure. This makes absolutely no sense

Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL error from devm_ioremap

Hi David, I have gave my comment. Thanks Arvind On Wednesday 14 December 2016 11:44 PM, David Daney wrote: On 12/14/2016 10:06 AM, arvind Yadav wrote: Yes, I have seen this error. We have a device with very less memory. Basically it's OMAP2 board. We have to port Android L on this. It's has

stmmac: lockups (was Re: Synopsys Ethernet QoS)

Hi! > I know that this is completely of topic, but I am facing a dificulty with > stmmac. I have interrupts, mac well configured rx packets being received > successfully, but TX is not working, resulting in Tx errors = Total TX > packets. > I have made a lot of debug and my conclusions is that

Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function

On Wed, Dec 14, 2016 at 10:46 AM, Jason A. Donenfeld wrote: > SipHash is a 64-bit keyed hash function that is actually a > cryptographically secure PRF, like HMAC. Except SipHash is super fast, > and is meant to be used as a hashtable keyed lookup function. > "super fast" is

Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function

Hi Tom, On Wed, Dec 14, 2016 at 8:18 PM, Tom Herbert wrote: > "super fast" is relative. My quick test shows that this faster than > Toeplitz (good, but not exactly hard to achieve), but is about 4x > slower than jhash. Fast relative to other cryptographically secure PRFs.

[PATCH 3/3] Bluetooth: btusb: Configure Marvel to use one of the pins for oob wakeup

The Marvell devices may have many gpio pins, and hence for wakeup on these out-of-band pins, the chip needs to be told which pin is to be used for wakeup, using an hci command. Thus, we read the pin number etc from the device tree node and send a command to the chip. Signed-off-by: Rajat Jain

[PATCH 2/3] Bluetooth: btusb: Add out-of-band wakeup support

Some BT chips (e.g. Marvell 8997) contain a wakeup pin that can be connected to a gpio on the CPU side, and can be used to wakeup the host out-of-band. This can be useful in situations where the in-band wakeup is not possible or not preferable (e.g. the in-band wakeup may require the USB host

[PATCH 1/3] Bluetooth: btusb: Use an error label for error paths

Use a label to remove the repetetive cleanup, for error cases. (This label will also be used in subsequent patches). Signed-off-by: Rajat Jain --- drivers/bluetooth/btusb.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git

Re: [kernel-hardening] Re: [PATCH 4/3] random: use siphash24 instead of md5 for get_random_int/long

Hi again, On Wed, Dec 14, 2016 at 5:37 PM, Theodore Ts'o wrote: > [3.606139] random benchmark!! > [3.606276] get_random_int # cycles: 326578 > [3.606317] get_random_int_new # cycles: 95438 > [3.607423] get_random_bytes # cycles: 2653388 Looks to me like my siphash

Re: net/arp: ARP cache aging failed.

Hello, On Wed, 14 Dec 2016, YueHaibing wrote: > On 2016/11/26 4:40, Julian Anastasov wrote: > > > > So, the idea is to move TCP and other similar > > users to the new dst_confirm_sk() method. If other > > dst_confirm() users are left, they should be checked > > if dsts with

  1   2   >