Re: [PATCH v3 net-next 3/3] arm64: dts: marvell: Add ethernet switch definition for the ESPRESSObin

2016-12-21 Thread Gregory CLEMENT
Hi Romain, On mer., déc. 21 2016, Romain Perier wrote: > This defines and enables the Marvell ethernet switch MVE886341 on the > Marvell ESPRESSObin board. This patch looks OK now. Applied on mvebu/dt64-4.11 So you can remove it from you next version

[PATCHv2] net: mvpp2: fix dma unmapping of TX buffers for fragments

2016-12-21 Thread Thomas Petazzoni
Since commit 71ce391dfb784 ("net: mvpp2: enable proper per-CPU TX buffers unmapping"), we are not correctly DMA unmapping TX buffers for fragments. Indeed, the mvpp2_txq_inc_put() function only stores in the txq_cpu->tx_buffs[] array the physical address of the buffer to be DMA-unmapped when skb

[PATCH net-next 14/27] net: mvpp2: add ip_version field in "struct mvpp2"

2016-12-21 Thread Thomas Petazzoni
In preparation to the introduction for the support of PPv2.2 in the mvpp2 driver, this commit adds an ip_version field to the struct mvpp2, and uses the .data field of the DT match table to fill it in. Having the MVPP21 and MVPP22 definitions available will allow to start adding the necessary

[PATCH net-next 08/27] net: mvpp2: remove unused register definitions

2016-12-21 Thread Thomas Petazzoni
Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/mvpp2.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index 98edcb6..e11eb6f 100644 ---

[PATCH net-next 11/27] net: mvpp2: switch to build_skb() in the RX path

2016-12-21 Thread Thomas Petazzoni
This commit adapts the mvpp2 RX path to use the build_skb() method. Not only build_skb() is now the recommended mechanism, but it also simplifies the addition of support for the PPv2.2 variant. Indeed, without build_skb(), we have to keep track for each RX descriptor of the physical address of

[PATCH net-next 04/27] net: mvpp2: release reference to txq_cpu[] entry after unmapping

2016-12-21 Thread Thomas Petazzoni
The mvpp2_txq_bufs_free() function is called upon TX completion to DMA unmap TX buffers, and free the corresponding SKBs. It gets the references to the SKB to free and the DMA buffer to unmap from a per-CPU txq_pcpu data structure. However, the code currently increments the pointer to the next

[PATCH net-next 03/27] net: mvpp2: handle too large value in mvpp2_rx_time_coal_set()

2016-12-21 Thread Thomas Petazzoni
When configuring the MVPP2_ISR_RX_THRESHOLD_REG with the RX coalescing time threshold, we do not check for the maximum allowed value supported by the driver, which means we might overflow and use a bogus value. This commit adds a check for this situation, and if a value higher than what is

[PATCH net-next 02/27] net: mvpp2: handle too large value handling in mvpp2_rx_pkts_coal_set()

2016-12-21 Thread Thomas Petazzoni
Currently, mvpp2_rx_pkts_coal_set() does the following to avoid setting a too large value for the RX coalescing by packet number: val = (pkts & MVPP2_OCCUPIED_THRESH_MASK); This means that if you set a value that is slightly higher the the maximum number of packets, you in fact get a very low

[PATCH net-next 05/27] net: mvpp2: remove unused 'tx_skb' field of 'struct mvpp2_tx_queue'

2016-12-21 Thread Thomas Petazzoni
This commit remove a field of 'struct mvpp2_tx_queue' that is not used anywhere. Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/mvpp2.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c

Re: Soft lockup in tc_classify

2016-12-21 Thread Daniel Borkmann
On 12/21/2016 08:03 AM, Cong Wang wrote: On Tue, Dec 20, 2016 at 10:44 PM, Shahar Klein wrote: [...] Looks like you added a debug printk inside tcf_destroy() too, which seems racy with filter creation, it should not happen since in both cases we take RTNL lock. Don't

[PATCH] net: macb: Applied changes according to review made by Andy Shevchenko.

2016-12-21 Thread Bartosz Folta
This patch is sent in regard to recently applied patch Commit 83a77e9ec4150ee4acc635638f7dedd9da523a26 net: macb: Added PCI wrapper for Platform Driver. Andy's review does not appear on mailing lists. I can't reference it. Signed-off-by: Bartosz Folta ---

[PATCH net-next 10/27] net: mvpp2: simplify MVPP2_PRS_RI_* definitions

2016-12-21 Thread Thomas Petazzoni
Some of the MVPP2_PRS_RI_* definitions use the ~(value) syntax, which doesn't compile nicely on 64-bit. Moreover, those definitions are in fact unneeded, since they are always used in combination with a bit mask that ensures only the appropriate bits are modified. Therefore, such definitions

[PATCH net-next 07/27] net: mvpp2: simplify mvpp2_bm_bufs_add()

2016-12-21 Thread Thomas Petazzoni
The mvpp2_bm_bufs_add() currently creates a fake cookie by calling mvpp2_bm_cookie_pool_set(), just to be able to call mvpp2_pool_refill(). But all what mvpp2_pool_refill() does is extract the pool ID from the cookie, and call mvpp2_bm_pool_put() with this ID. Instead of doing this convoluted

[PATCH net-next 00/27] net: mvpp2: add basic support for PPv2.2

2016-12-21 Thread Thomas Petazzoni
Hello, The goal of this patch series is to add basic support for PPv2.2 in the existing mvpp2 driver. mvpp2 currently supported the PPv2.1 version of the IP, used in the 32 bits Marvell Armada 375 SoC. PPv2.2 is an evolution of this IP block, used in the 64 bits Marvell Armada 7K/8K SoCs. In

[PATCH net-next 06/27] net: mvpp2: drop useless fields in mvpp2_bm_pool and related code

2016-12-21 Thread Thomas Petazzoni
This commit drops dead code from the mvpp2 driver. The 'in_use' and 'in_use_thresh' fields of 'struct mvpp2_bm_pool' are incremented/decremented/initialized in various places. But they are only used in one place: if (is_recycle && (atomic_read(_pool->in_use) <

[PATCH net-next 01/27] dt-bindings: net: update Marvell PPv2 binding for PPv2.2 support

2016-12-21 Thread Thomas Petazzoni
The Marvell PPv2 Device Tree binding was so far only used to describe the PPv2.1 network controller, used in the Marvell Armada 375. A new version of this IP block, PPv2.2 is used in the Marvell Armada 7K/8K processor. This commit extends the existing binding so that it can also be used to

[PATCH net-next 09/27] net: mvpp2: fix indentation of MVPP2_EXT_GLOBAL_CTRL_DEFAULT

2016-12-21 Thread Thomas Petazzoni
Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/mvpp2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index e11eb6f..6ec1135 100644 ---

[PATCH for bnxt_re V4 00/21] Broadcom RoCE Driver (bnxt_re)

2016-12-21 Thread Selvin Xavier
This series introduces the RoCE driver for the Broadcom NetXtreme-E 10/25/40/50G RoCE HCAs. This driver is dependent on the bnxt_en NIC driver and is based on the bnxt_re branch in linux-rdma repository. bnxt_en changes required for this patch series are already available afore mentioned branch.

[PATCH for bnxt_re V4 01/21] RDMA/bnxt_re: Add bnxt_re RoCE driver files

2016-12-21 Thread Selvin Xavier
This patch adds the required skeletal files for Broadcom NetXtreme-E RoCE driver. Also, added the load/unload routines for bnxt_re driver. v2: Modified the license text to include Dual License v4: Modifies the directory and file names as per the review comment Signed-off-by: Eddie Wai

[PATCH net-next 22/27] net: mvpp2: handle misc PPv2.1/PPv2.2 differences

2016-12-21 Thread Thomas Petazzoni
This commit handles a few miscellaneous differences between PPv2.1 and PPv2.2 in different areas, where code done for PPv2.1 doesn't apply for PPv2.2 or needs to be adjusted (getting the MAC address, disabling PHY polling, etc.). Signed-off-by: Thomas Petazzoni

[PATCH net-next 19/27] net: mvpp2: adapt mvpp2_defaults_set() to PPv2.2

2016-12-21 Thread Thomas Petazzoni
This commit modifies the mvpp2_defaults_set() function to not do the loopback and FIFO threshold initialization, which are not needed for PPv2.2. Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/mvpp2.c | 22 -- 1 file

[PATCH net-next 16/27] net: mvpp2: introduce PPv2.2 HW descriptors and adapt accessors

2016-12-21 Thread Thomas Petazzoni
This commit adds the definition of the PPv2.2 HW descriptors, adjusts the mvpp2_tx_desc and mvpp2_rx_desc structures accordingly, and adapts the accessors to work on both PPv2.1 and PPv2.2. Signed-off-by: Thomas Petazzoni ---

[PATCH net-next 26/27] net: mvpp2: add support for an additional clock needed for PPv2.2

2016-12-21 Thread Thomas Petazzoni
The PPv2.2 variant of the network controller needs an additional clock, the "MG clock" in order for the IP block to operate properly. This commit adds support for this additional clock to the driver, reworking as needed the error handling path. Signed-off-by: Thomas Petazzoni

[PATCH net-next 13/27] net: mvpp2: add and use accessors for TX/RX descriptors

2016-12-21 Thread Thomas Petazzoni
The PPv2.2 IP has a different TX and RX descriptor layout compared to PPv2.1. In order to prepare for the introduction of PPv2.2 support in mvpp2, this commit adds accessors for the different fields of the TX and RX descriptors, and changes the code to use them. For now, the mvpp2_port argument

[PATCH net-next 12/27] net: mvpp2: enable building on 64-bit platforms

2016-12-21 Thread Thomas Petazzoni
The mvpp2 is going to be extended to support the Marvell Armada 7K/8K platform, which is ARM64. As a preparation to this work, this commit enables building the mvpp2 driver on ARM64, by: - Adjusting the Kconfig dependency - Fixing the types used in the driver so that they are 32/64-bits

[PATCH net-next 17/27] net: mvpp2: adjust the allocation/free of BM pools for PPv2.2

2016-12-21 Thread Thomas Petazzoni
This commit adjusts the allocation and freeing of BM pools to support PPv2.2. This involves: - Checking that the number of buffer pointers is a multiple of 16, as required by the hardware. - Adjusting the size of the DMA coherent area allocated for buffer pointers. Indeed, PPv2.2 needs

[PATCH net-next 20/27] net: mvpp2: adjust mvpp2_{rxq,txq}_init for PPv2.2

2016-12-21 Thread Thomas Petazzoni
In PPv2.2, the MVPP2_RXQ_DESC_ADDR_REG and MVPP2_TXQ_DESC_ADDR_REG registers have a slightly different layout, because they need to contain a 64-bit address for the RX and TX descriptor arrays. This commit adjusts those functions accordingly. Signed-off-by: Thomas Petazzoni

[PATCH net-next 15/27] net: mvpp2: introduce an intermediate union for the TX/RX descriptors

2016-12-21 Thread Thomas Petazzoni
Since the format of the HW descriptors is different between PPv2.1 and PPv2.2, this commit introduces an intermediate union, with for now only the PPv2.1 descriptors. The bulk of the driver code only manipulates opaque mvpp2_tx_desc and mvpp2_rx_desc pointers, and the descriptors can only be

[PATCH net-next 23/27] net: mvpp2: add AXI bridge initialization for PPv2.2

2016-12-21 Thread Thomas Petazzoni
The PPv2.2 unit is connected to an AXI bus on Armada 7K/8K, so this commit adds the necessary initialization of the AXI bridge. Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/mvpp2.c | 85 1 file

[PATCH net-next 24/27] net: mvpp2: rework RXQ interrupt group initialization for PPv2.2

2016-12-21 Thread Thomas Petazzoni
This commit adjusts how the MVPP2_ISR_RXQ_GROUP_REG register is configured, since it changed between PPv2.1 and PPv2.2. Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/mvpp2.c | 45 1 file changed, 41

[PATCH net-next 27/27] net: mvpp2: finally add the PPv2.2 compatible string

2016-12-21 Thread Thomas Petazzoni
Now that the mvpp2 driver has been modified to accommodate the support for PPv2.2, we can finally advertise this support by adding the appropriate compatible string. Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/mvpp2.c | 4 1 file

[PATCH net-next 18/27] net: mvpp2: adapt the mvpp2_rxq_*_pool_set functions to PPv2.2

2016-12-21 Thread Thomas Petazzoni
The MVPP2_RXQ_CONFIG_REG register has a slightly different layout between PPv2.1 and PPv2.2, so this commit adapts the functions modifying this register to accommodate for both the PPv2.1 and PPv2.2 cases. Signed-off-by: Thomas Petazzoni ---

[PATCH net-next 21/27] net: mvpp2: handle register mapping and access for PPv2.2

2016-12-21 Thread Thomas Petazzoni
This commit adjusts the mvpp2 driver register mapping and access logic to support PPv2.2, to handle a number of differences. Due to how the registers are laid out in memory, the Device Tree binding for the "reg" property is different: - On PPv2.1, we had a first area for the common registers,

[PATCH net-next 25/27] net: mvpp2: adapt rxq distribution to PPv2.2

2016-12-21 Thread Thomas Petazzoni
In PPv2.1, we have a maximum of 8 RXQs per port, with a default of 4 RXQs per port, and we were assigning RXQs 0->3 to the first port, 4->7 to the second port, 8->11 to the third port, etc. In PPv2.2, we have a maximum of 32 RXQs per port, and we must allocate RXQs from the range of 32 RXQs

Re: Soft lockup in tc_classify

2016-12-21 Thread Shahar Klein
On 12/21/2016 9:03 AM, Cong Wang wrote: On Tue, Dec 20, 2016 at 10:44 PM, Shahar Klein wrote: Tried it with same results This piece is pretty interesting: [ 408.554689] DEBUGG:SK thread-2853[cpu-1] setting tp_created to 1 tp=94b5b02805a0 back=94b9ea932060 [

[PATCH for bnxt_re V4 17/21] RDMA/bnxt_re: Handling dispatching of events to IB stack

2016-12-21 Thread Selvin Xavier
This patch implements events dispatching to the IB stack based on NETDEV events received. v2: Removed cleanup of the resources during driver unload since we are calling unregister_netdevice_notifier first in the exit. v3: Fixes cocci warnings and some sparse warnings Signed-off-by: Eddie

[PATCH for bnxt_re V4 18/21] RDMA/bnxt_re: Support for DCB

2016-12-21 Thread Selvin Xavier
This patch queries the configured RoCE APP Priority on the host using the dcbnl API and programs the RoCE FW with the corresponding Traffic Class(es) for the priority. v2: Fixed some sparse warning and cleanup of function bnxt_re_query_hwrm_pri2cos v3: Adds bnxt_qplib_map_tc2cos as a part of

[PATCH for bnxt_re V4 15/21] RDMA/bnxt_re: Support post_recv

2016-12-21 Thread Selvin Xavier
Enables the fastpath verb ib_post_recv. v3: Fixes sparse warnings Signed-off-by: Eddie Wai Signed-off-by: Devesh Sharma Signed-off-by: Somnath Kotur Signed-off-by: Sriharsha Basavapatna

[PATCH for bnxt_re V4 02/21] RDMA/bnxt_re: Introducing autogenerated Host Software Interface(hsi) file

2016-12-21 Thread Selvin Xavier
This patch introduces all the structures used by the driver for communicating with the Hardware. This file is the equivalent of the bnxt_hsi.h used by bnxt_en driver. v2: Remove duplicate structure definitions from bnxt_en HSI file and include bnxt_hsi.h from bnxt_en driver v3: Remove the

[PATCH for bnxt_re V4 10/21] RDMA/bnxt_re: Support for CQ verbs

2016-12-21 Thread Selvin Xavier
Implements support for create_cq, destroy_cq and req_notify_cq verbs. v3: Code cleanup based on errors reported by sparse on endianness check. Removes unwanted macros. Signed-off-by: Eddie Wai Signed-off-by: Devesh Sharma Signed-off-by:

[PATCH for bnxt_re V4 16/21] RDMA/bnxt_re: Support poll_cq verb

2016-12-21 Thread Selvin Xavier
Enables the fastpath ib_poll_cq verb. v2: Fixed sparse warnings v3: Fixes endianness related warnings reported by sparse. Also, fixes smatch and checkpatch warnings Signed-off-by: Eddie Wai Signed-off-by: Devesh Sharma Signed-off-by:

[PATCH for bnxt_re V4 11/21] RDMA/bnxt_re: Support for AH verbs

2016-12-21 Thread Selvin Xavier
This patch implements support for create_ah, destroy_ah, query_ah and modify_ah verbs. v3: Removes unwanted macros and does cleanup listed by checkpatch Signed-off-by: Eddie Wai Signed-off-by: Devesh Sharma Signed-off-by: Somnath Kotur

[PATCH for bnxt_re V4 14/21] RDMA/bnxt_re: Support post_send verb

2016-12-21 Thread Selvin Xavier
Enables the ib_post_send fastpath verb for posting Send work requests on QPs. v2: Fixed some sparse warnings v3: Fixes endianness related warnings reported by sparse. Changes some of the macros to inline functions. Signed-off-by: Eddie Wai Signed-off-by: Devesh

[PATCH for bnxt_re V4 08/21] RDMA/bnxt_re: Adding support for port related verbs

2016-12-21 Thread Selvin Xavier
Implements query_port, modify_port and port_immutable verbs Signed-off-by: Eddie Wai Signed-off-by: Devesh Sharma Signed-off-by: Somnath Kotur Signed-off-by: Sriharsha Basavapatna

[PATCH for bnxt_re V4 20/21] RDMA/bnxt_re: Add QP event handling

2016-12-21 Thread Selvin Xavier
Implements callback handler for processing Async events related to a QP. This patch also implements the control path command completion handling. v3: Removes unwanted braces Signed-off-by: Eddie Wai Signed-off-by: Devesh Sharma Signed-off-by:

[PATCH for bnxt_re V4 07/21] RDMA/bnxt_re: Support for query and modify device verbs

2016-12-21 Thread Selvin Xavier
Implements the query device and modify device verbs v3: Fix sparse warnings related to endianness checks Signed-off-by: Eddie Wai Signed-off-by: Devesh Sharma Signed-off-by: Somnath Kotur Signed-off-by: Sriharsha

[PATCH for bnxt_re V4 19/21] RDMA/bnxt_re: Set uverbs command mask

2016-12-21 Thread Selvin Xavier
This patch exports available uverbs command mask to the IB stack. Also, populates some of the missing parameters in the ibdev structure used for registration. v4: Changes the include file names Signed-off-by: Eddie Wai Signed-off-by: Devesh Sharma

[PATCH for bnxt_re V4 21/21] RDMA/bnxt_re: Add bnxt_re driver build support

2016-12-21 Thread Selvin Xavier
Makefile and Kconfig changes for enabling bnxt_re compilation v3: Adds list of MAINTAINERS of bnxt_re driver. Removes bnxt_re_debugfs.c from Makefile as this file is no longer present Signed-off-by: Devesh Sharma Signed-off-by: Somnath Kotur

[PATCH for bnxt_re V4 03/21] RDMA/bnxt_re: register with the NIC driver

2016-12-21 Thread Selvin Xavier
This patch handles the registration with the bnxt_en driver. The bnxt_re driver first registers with netdev notifier chain and upon receiving the NETDEV_REGISTER event, it registers with bnxt_en driver. 1. bnxt_en's ulp_probe function returns a structure that contains

[PATCH for bnxt_re V4 09/21] RDMA/bnxt_re: Support for GID related verbs

2016-12-21 Thread Selvin Xavier
Implements add GID, del GID, get_netdev and pkey related verbs. v3: Fixes some sparse warning related to endianness check. Removes macros which are just wrapper for standard defines. Signed-off-by: Eddie Wai Signed-off-by: Devesh Sharma

[PATCH for bnxt_re V4 04/21] RDMA/bnxt_re: Enabling RoCE control path

2016-12-21 Thread Selvin Xavier
This patch covers the basic initialization of the HW interface. Implements some of the slow path FW commands required for the HW intialization. It also handles registration with the IB stack. v2: Fix some of the sparse warnings v3: Removed some more smatch and sparse warnings related to

[PATCH for bnxt_re V4 06/21] RDMA/bnxt_re: Support for PD, ucontext and mmap verbs

2016-12-21 Thread Selvin Xavier
This patch includes the uverbs ABI header file to enable user verbs. Also, adds support for the Protection Domain, User Context and mmap verbs. v2: Moved the bnxt_re_uverbs_abi.h file to include/uapi/rdma folder. Also, Fixed one sparse warning. v3: Fixes some cross compile and sparse

[PATCH for bnxt_re V4 13/21] RDMA/bnxt_re: Support QP verbs

2016-12-21 Thread Selvin Xavier
This patch implements create_qp, destroy_qp, query_qp and modify_qp verbs. v2: Fixed sparse warnings v3: Splits __filter_modify_flags function to avoid nested switch cases. Removes unwanted macros. Also, fix the endianness related issues reported by sparse. Signed-off-by: Eddie Wai

[PATCH for bnxt_re V4 12/21] RDMA/bnxt_re: Support memory registration verbs

2016-12-21 Thread Selvin Xavier
This patch implements the kernel and user memory region registration supported by the bnxt_re driver. This includes the user MR, FRMR, FMR and DMA MR support. v3: Moves bnxt_qplib_map_tc2cos to DCB patch as the functionality is used by DCB patch. Also, removed some unwanted macros.

[PATCH for bnxt_re V4 05/21] RDMA/bnxt_re: Adding Notification Queue support

2016-12-21 Thread Selvin Xavier
Completion Notifcations are handled by Notification Queue (NQ). This patch configures the NQs. Also, configures the Door bell page mapping v3: Fixes some sparse warnings related to endianness checks v4: Change include file names Signed-off-by: Eddie Wai Signed-off-by:

[PATCH v3] rfkill: Add rfkill-any LED trigger

2016-12-21 Thread Michał Kępień
Add a new "global" (i.e. not per-rfkill device) LED trigger, rfkill-any, which may be useful on laptops with a single "radio LED" and multiple radio transmitters. The trigger is meant to turn a LED on whenever there is at least one radio transmitter active and turn it off otherwise. This

[PATCH v3 net-next 0/3] Add support for the ethernet switch on the ESPRESSObin

2016-12-21 Thread Romain Perier
This set of patches adds support for the Marvell ethernet switch 88E6341. It also add the devicetree definition of this switch to the DT board. Romain Perier (3): net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports net: dsa: mv88e6xxx: Add support for ethernet switch

[PATCH v3 net-next 3/3] arm64: dts: marvell: Add ethernet switch definition for the ESPRESSObin

2016-12-21 Thread Romain Perier
This defines and enables the Marvell ethernet switch MVE886341 on the Marvell ESPRESSObin board. Signed-off-by: Romain Perier --- Changes in v3: - Changed the node switch0 to be at 1 - Removed reg=<1> from the mdio node, finally that's not required Changes

[PATCH v3 net-next 2/3] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341/88E6141

2016-12-21 Thread Romain Perier
The Marvell 88E6341 device is single-chip, 6-port ethernet switch with four integrated 10/100/1000Mbps ethernet transceivers and one high speed SerDes interfaces. It is compatible with switches of family 88E6352. This commit adds basic support for this switch by describing its capabilities to the

[PATCH v3 net-next 1/3] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports

2016-12-21 Thread Romain Perier
Some Marvell ethernet switches have internal ethernet transceivers with hardcoded phy addresses. These addresses can be grearer than the number of ports or its value might be different than the associated port number. This is for example the case for MV88E6341 that has 6 ports and internal Port 1

Re: [PATCH v3 net-next 1/3] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports

2016-12-21 Thread Gregory CLEMENT
Hi Romain, it seems there is a remaining typo :) On mer., déc. 21 2016, Romain Perier wrote: > Some Marvell ethernet switches have internal ethernet transceivers with > hardcoded phy addresses. These addresses can be grearer than the number

[RFC PATCH 3/7] Enable pause frame support

2016-12-21 Thread Satha Koteswara Rao
--- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 25 +++ drivers/net/ethernet/cavium/thunder/thunder_bgx.h | 7 +++ 2 files changed, 32 insertions(+) diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c

[RFC PATCH 4/7] HW Filter Initialization code and register access APIs

2016-12-21 Thread Satha Koteswara Rao
--- drivers/net/ethernet/cavium/thunder/pf_reg.c | 660 +++ 1 file changed, 660 insertions(+) create mode 100644 drivers/net/ethernet/cavium/thunder/pf_reg.c diff --git a/drivers/net/ethernet/cavium/thunder/pf_reg.c b/drivers/net/ethernet/cavium/thunder/pf_reg.c new

Re: [PATCH net] be2net: Increase skb headroom size to 256 bytes

2016-12-21 Thread Sriharsha Basavapatna
On Wed, Dec 21, 2016 at 1:00 AM, David Miller wrote: > > From: Suresh Reddy > Date: Tue, 20 Dec 2016 10:14:30 -0500 > > > From: Kalesh A P > > > > The driver currently allocates 128 bytes of skb headroom. > >

Re: [PATCH v2 3/3] arm64: dts: marvell: Add ethernet switch definition for the ESPRESSObin

2016-12-21 Thread Romain Perier
Hi, Le 20/12/2016 à 17:17, Andrew Lunn a écrit : + mdio { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; what is this reg value for? Andrew It was required to avoid a warning thrown by the mdio

Re: Soft lockup in tc_classify

2016-12-21 Thread Shahar Klein
On 12/20/2016 1:47 PM, Daniel Borkmann wrote: Hi Shahar, On 12/20/2016 07:22 AM, Shahar Klein wrote: On 12/19/2016 7:58 PM, Cong Wang wrote: On Mon, Dec 19, 2016 at 8:39 AM, Shahar Klein wrote: On 12/13/2016 12:51 AM, Cong Wang wrote: On Mon, Dec 12, 2016 at 1:18

[RFC PATCH 7/7] Get notifications from PF driver and configure filter block based on request data

2016-12-21 Thread Satha Koteswara Rao
--- drivers/net/ethernet/cavium/thunder/pf_filter.c | 1678 +++ 1 file changed, 1678 insertions(+) create mode 100644 drivers/net/ethernet/cavium/thunder/pf_filter.c diff --git a/drivers/net/ethernet/cavium/thunder/pf_filter.c

[RFC PATCH 1/7] PF driver modified to enable HW filter support, changes works in backward compatibility mode Enable required things in Makefile Enable LZ4 dependecy inside config file

2016-12-21 Thread Satha Koteswara Rao
--- drivers/net/ethernet/cavium/Kconfig| 1 + drivers/net/ethernet/cavium/thunder/Makefile | 2 +- drivers/net/ethernet/cavium/thunder/nic.h | 203 --- drivers/net/ethernet/cavium/thunder/nic_main.c | 735 ++--- 4 files changed, 804 insertions(+),

[RFC PATCH 0/7] ThunderX Embedded switch support

2016-12-21 Thread Satha Koteswara Rao
Background == Proposed patch configures programmable ThunderX embedded network switch to emulate functions of e-switch found in most industry standard NICs. Embedded switch is pre-configured by loading firmware image which exposes several firmware defined tables allowing configuration of

[RFC PATCH 5/7] Multiple VF's grouped together under single physical port called PF group PF Group maintainance API's

2016-12-21 Thread Satha Koteswara Rao
--- drivers/net/ethernet/cavium/thunder/pf_globals.h | 78 + drivers/net/ethernet/cavium/thunder/pf_locals.h | 365 +++ drivers/net/ethernet/cavium/thunder/pf_vf.c | 207 + 3 files changed, 650 insertions(+) create mode 100644

[RFC PATCH 6/7] HW Filter Table access API's

2016-12-21 Thread Satha Koteswara Rao
--- drivers/net/ethernet/cavium/thunder/tbl_access.c | 262 +++ drivers/net/ethernet/cavium/thunder/tbl_access.h | 61 ++ 2 files changed, 323 insertions(+) create mode 100644 drivers/net/ethernet/cavium/thunder/tbl_access.c create mode 100644

[RFC PATCH 2/7] VF driver changes to enable hooks to get kernel notifications

2016-12-21 Thread Satha Koteswara Rao
--- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 579 ++- 1 file changed, 565 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_main.c b/drivers/net/ethernet/cavium/thunder/nicvf_main.c index 8a37012..8f00bc7 100644 ---

Re: [PATCH 1/5 net-next] inet: replace ->bind_conflict with ->rcv_saddr_equal

2016-12-21 Thread Hannes Frederic Sowa
On Tue, 2016-12-20 at 15:07 -0500, Josef Bacik wrote: > --- a/net/dccp/ipv6.c > +++ b/net/dccp/ipv6.c > @@ -926,7 +926,7 @@ static const struct inet_connection_sock_af_ops > dccp_ipv6_af_ops = { > .getsockopt= ipv6_getsockopt, > .addr2sockaddr = inet6_csk_addr2sockaddr, >

Re: [PATCH v3] net: macb: Added PCI wrapper for Platform Driver.

2016-12-21 Thread Andy Shevchenko
On Wed, Dec 21, 2016 at 1:53 PM, Bartosz Folta wrote: > Please find link to patch holding changes that you suggested: > https://lkml.kernel.org/r/sn1pr0701mb1951b994f86160a24c436f30cc...@sn1pr0701mb1951.namprd07.prod.outlook.com > > Here is alternative link to mentioned patch.

Re: ipv6: handle -EFAULT from skb_copy_bits

2016-12-21 Thread Hannes Frederic Sowa
On Tue, 2016-12-20 at 22:09 -0800, Cong Wang wrote: > On Tue, Dec 20, 2016 at 2:12 PM, Dave Jones wrote: > > fd = socket(AF_INET6, SOCK_RAW, 7); > > > > setsockopt(fd, SOL_IPV6, IPV6_CHECKSUM, , 4); > > setsockopt(fd, SOL_IPV6, IPV6_DSTOPTS, ,

Re: at86rf230: Allow slow GPIO pins for "rstn"

2016-12-21 Thread Nikita Yushchenko
> Driver code never touches "rstn" signal in atomic context, so there's > no need to implicitly put such restriction on it by using gpio_set_value > to manipulate it. Replace gpio_set_value to gpio_set_value_cansleep to > fix that. > > As a an example of where such restriction might be

Re: ipv6: handle -EFAULT from skb_copy_bits

2016-12-21 Thread Hannes Frederic Sowa
On Wed, 2016-12-21 at 13:27 +0100, Hannes Frederic Sowa wrote: > @@ -555,8 +566,8 @@ static int rawv6_push_pending_frames(struct sock *sk, > struct flowi6 *fl6, > goto out; > > offset = rp->offset; > - total_len = inet_sk(sk)->cork.base.length; > - if

Re: Soft lockup in tc_classify

2016-12-21 Thread Daniel Borkmann
On 12/21/2016 01:58 PM, Shahar Klein wrote: On 12/21/2016 12:15 PM, Daniel Borkmann wrote: On 12/21/2016 08:03 AM, Cong Wang wrote: On Tue, Dec 20, 2016 at 10:44 PM, Shahar Klein wrote: [...] Looks like you added a debug printk inside tcf_destroy() too, which seems

Re: Soft lockup in tc_classify

2016-12-21 Thread Shahar Klein
On 12/21/2016 12:15 PM, Daniel Borkmann wrote: On 12/21/2016 08:03 AM, Cong Wang wrote: On Tue, Dec 20, 2016 at 10:44 PM, Shahar Klein wrote: [...] Looks like you added a debug printk inside tcf_destroy() too, which seems racy with filter creation, it should not

[PATCH net] tcp: add a missing barrier in tcp_tasklet_func()

2016-12-21 Thread Eric Dumazet
From: Eric Dumazet Madalin reported crashes happening in tcp_tasklet_func() on powerpc64 Before TSQ_QUEUED bit is cleared, we must ensure the changes done by list_del(>tsq_node); are committed to memory, otherwise corruption might happen, as an other cpu could catch

RE: [PATCH v3] net: macb: Added PCI wrapper for Platform Driver.

2016-12-21 Thread Bartosz Folta
> And one more > > + plat_info.dma_mask = DMA_BIT_MASK(32); > > Perhaps > plat_info.dma_mask = pdev->dma_mask; > ? Thank you. I tested your suggestion. I have sent second version of patch. https://patchwork.ozlabs.org/patch/707800/ Regards, Bartosz Folta

Re: [PATCH][V2] qed: fix memory leak of a qed_spq_entry on error failure paths

2016-12-21 Thread Colin Ian King
On 21/12/16 13:29, Mintz, Yuval wrote: >> From: Colin Ian King >> >> A qed_spq_entry entry is allocated by qed_sp_init_request but is not kfree'd >> if an error occurs, causing a memory leak. Fix this by returning the >> previously >> allocated spq entry and also

Re: [PATCH 2/2] net: sfc: falcon: use new api ethtool_{get|set}_link_ksettings

2016-12-21 Thread Bert Kenward
On 20/12/16 22:24, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes > --- > drivers/net/ethernet/sfc/falcon/efx.c |2 +- >

Re: [PATCH RFC net-next 3/7] sctp: add dst_pending_confirm flag

2016-12-21 Thread Neil Horman
On Sun, Dec 18, 2016 at 10:56:32PM +0200, Julian Anastasov wrote: > Add new transport flag to allow sockets to confirm neighbour. > When same struct dst_entry can be used for many different > neighbours we can not use it for pending confirmations. > The flag is propagated from transport to every

Re: [PATCHv2 net 1/2] sctp: reduce indent level in sctp_copy_local_addr_list

2016-12-21 Thread Neil Horman
On Tue, Dec 20, 2016 at 01:49:49PM +0800, Xin Long wrote: > This patch is to reduce indent level by using continue when the addr > is not allowed, and also drop end_copy by using break. > > Signed-off-by: Xin Long > --- > net/sctp/protocol.c | 37

Re: HalfSipHash Acceptable Usage

2016-12-21 Thread Jason A. Donenfeld
Hi George, On Wed, Dec 21, 2016 at 7:34 AM, George Spelvin wrote: > In fact, I have an idea. Allow me to make the following concrete > suggestion for using HalfSipHash with 128 bits of key material: > > - 64 bits are used as the key. > - The other 64 bits are used as

Re: [RFC PATCH 0/7] ThunderX Embedded switch support

2016-12-21 Thread Sunil Kovvuri
It would be easier for anyone to review if you prepare patches based on features rather than based on modifications to files. Thanks, Sunil.

[PATCH v2] net: macb: Applied changes according to review made by Andy Shevchenko.

2016-12-21 Thread Bartosz Folta
This patch is sent in regard to recently applied patch Commit 83a77e9ec4150ee4acc635638f7dedd9da523a26 net: macb: Added PCI wrapper for Platform Driver. Signed-off-by: Bartosz Folta --- Changed in v2: Size of DMA mask is set based on value held by PCI device. ---

Re: [RFC PATCH 1/7] PF driver modified to enable HW filter support, changes works in backward compatibility mode Enable required things in Makefile Enable LZ4 dependecy inside config file

2016-12-21 Thread Sunil Kovvuri
> > #define NIC_MAX_RSS_HASH_BITS 8 > #define NIC_MAX_RSS_IDR_TBL_SIZE (1 << NIC_MAX_RSS_HASH_BITS) > +#define NIC_TNS_RSS_IDR_TBL_SIZE 5 So you want to use only 5 queues per VF when TNS is enabled, is it ?? There are 4096 RSS indices in total, for each VF you can use max

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-21 Thread Geoff Lansberry
Thanks Mark. Should I resubmit patches with the requested edits today, or wait a bit for more comments? What is the desired etiquette? > On Dec 20, 2016, at 9:23 PM, Mark Greer wrote: > >> On Tue, Dec 20, 2016 at 11:16:31AM -0500, Geoff Lansberry wrote: >> From:

Re: [PATCH v3] net: macb: Added PCI wrapper for Platform Driver.

2016-12-21 Thread Andy Shevchenko
On Wed, Dec 21, 2016 at 2:16 PM, Andy Shevchenko wrote: > On Wed, Dec 21, 2016 at 1:53 PM, Bartosz Folta wrote: >> I think that there is a delay on some mailing lists (marc.info and >> mail-archive.com). Latest messages I found there are from

Re: [RFC PATCH 4/7] HW Filter Initialization code and register access APIs

2016-12-21 Thread Sunil Kovvuri
On Wed, Dec 21, 2016 at 2:16 PM, Satha Koteswara Rao wrote: > --- > drivers/net/ethernet/cavium/thunder/pf_reg.c | 660 > +++ > 1 file changed, 660 insertions(+) > create mode 100644 drivers/net/ethernet/cavium/thunder/pf_reg.c > > diff

Re: [PATCH] at86rf230: Allow slow GPIO pins for "rstn"

2016-12-21 Thread Stefan Schmidt
Hello. On 19/12/16 00:25, Andrey Smirnov wrote: Driver code never touches "rstn" signal in atomic context, so there's no need to implicitly put such restriction on it by using gpio_set_value to manipulate it. Replace gpio_set_value to gpio_set_value_cansleep to fix that. We need to make sure

RE: [PATCH v3] net: macb: Added PCI wrapper for Platform Driver.

2016-12-21 Thread Bartosz Folta
Please find link to patch holding changes that you suggested: https://lkml.kernel.org/r/sn1pr0701mb1951b994f86160a24c436f30cc...@sn1pr0701mb1951.namprd07.prod.outlook.com Here is alternative link to mentioned patch. https://patchwork.ozlabs.org/patch/707720/ I think that there is a delay on some

Re: [RFC PATCH 5/7] Multiple VF's grouped together under single physical port called PF group PF Group maintainance API's

2016-12-21 Thread Sunil Kovvuri
On Wed, Dec 21, 2016 at 2:16 PM, Satha Koteswara Rao wrote: > +struct tns_global_st { > + u64 magic; > + char version[16]; > + u64 reg_cnt; > + struct table_static_s tbl_info[TNS_MAX_TABLE]; > +}; > + > +#define PF_COUNT 3 > +#define PF_1

[PATCH net-next v4 0/2] Add support for the ethernet switch on the ESPRESSObin

2016-12-21 Thread Romain Perier
This set of patches adds support for the Marvell ethernet switch 88E6341. It also add the devicetree definition of this switch to the DT board. Romain Perier (2): net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports net: dsa: mv88e6xxx: Add support for ethernet switch

[PATCH net-next v4 1/2] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports

2016-12-21 Thread Romain Perier
Some Marvell ethernet switches have internal ethernet transceivers with hardcoded phy addresses. These addresses can be greater than the number of ports or its value might be different than the associated port number. This is for example the case for MV88E6341 that has 6 ports and internal Port 1

[PATCH net-next v4 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341/88E6141

2016-12-21 Thread Romain Perier
The Marvell 88E6341 device is single-chip, 6-port ethernet switch with four integrated 10/100/1000Mbps ethernet transceivers and one high speed SerDes interfaces. It is compatible with switches of family 88E6352. This commit adds basic support for this switch by describing its capabilities to the

Re: [PATCH net] be2net: Increase skb headroom size to 256 bytes

2016-12-21 Thread David Miller
From: Suresh Reddy Date: Tue, 20 Dec 2016 10:14:30 -0500 > From: Kalesh A P > > The driver currently allocates 128 bytes of skb headroom. > This was found to be insufficient with some configurations > like Geneve tunnels, which

Re: [PATCH] net: qcom/emac: add ethtool support

2016-12-21 Thread David Miller
From: Timur Tabi Date: Tue, 20 Dec 2016 16:32:09 -0600 > Add support for some ethtool methods: get/set link settings, get/set > message level, get statistics, get link status, and restart > autonegotiation. > > Signed-off-by: Timur Tabi Please

  1   2   3   >