RE: [PATCH iproute2 v3 4/4] ifstat: Add "sw only" extended statistics to ifstat

2016-12-25 Thread Nogah Frankel
> -Original Message- > From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com] > Sent: Thursday, December 22, 2016 11:10 PM > To: Nogah Frankel > Cc: netdev@vger.kernel.org; step...@networkplumber.org; roszenr...@gmail.com; > Or > Gerlitz ;

RE: [PATCH v3 net-next] bnx2x: ethtool -x support for rss_key

2016-12-25 Thread Mintz, Yuval
+ if (key) { > + WARN_ON_ONCE(bnx2x_get_rxfh_key_size(dev) != > T_ETH_RSS_KEY * 4); > + bnx2x_get_rss_key(>rss_conf_obj, key); > + } This doesn’t work VFs [the PF has the RSS configuration object in their case; They don't have it], which is fine as 'key' should

RE: [PATCH iproute2 v3 2/4] ifstat: Add extended statistics to ifstat

2016-12-25 Thread Nogah Frankel
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, December 22, 2016 8:59 PM > To: Nogah Frankel > Cc: netdev@vger.kernel.org; ro...@cumulusnetworks.com; roszenr...@gmail.com; > Or > Gerlitz ;

Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value

2016-12-25 Thread Sergei Shtylyov
Hello! On 12/25/2016 3:30 AM, Thomas Preisner wrote: In some cases the return value of a failing function is not being used and the function typhoon_init_one() returns another negative error code instead. Signed-off-by: Thomas Preisner Signed-off-by: Milan

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2016-12-25 Thread Pali Rohár
On Sunday 25 December 2016 21:15:40 Arend Van Spriel wrote: > On 24-12-2016 17:52, Pali Rohár wrote: > > NVS calibration data for wl1251 are model specific. Every one > > device with wl1251 chip has different and calibrated in factory. > > > > Not all wl1251 chips have own EEPROM where are

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2016-12-25 Thread Arend Van Spriel
On 24-12-2016 17:52, Pali Rohár wrote: > NVS calibration data for wl1251 are model specific. Every one device with > wl1251 chip has different and calibrated in factory. > > Not all wl1251 chips have own EEPROM where are calibration data stored. And > in that case there is no "standard" place.

Re: [PATCH net 3/9] virtio-net: fix page miscount during XDP linearizing

2016-12-25 Thread Jason Wang
On 2016年12月23日 23:54, John Fastabend wrote: On 16-12-23 06:37 AM, Jason Wang wrote: We don't put page during linearizing, the would cause leaking when xmit through XDP_TX or the packet exceeds PAGE_SIZE. Fix them by put page accordingly. Also decrease the number of buffers during linearizing

Re: [PATCH net 4/9] virtio-net: correctly handle XDP_PASS for linearized packets

2016-12-25 Thread Jason Wang
On 2016年12月23日 23:57, John Fastabend wrote: On 16-12-23 06:37 AM, Jason Wang wrote: When XDP_PASS were determined for linearized packets, we try to get new buffers in the virtqueue and build skbs from them. This is wrong, we should create skbs based on existed buffers instead. Fixing them by

Re: 4.9.0-rc8: tg3 dead after resume

2016-12-25 Thread Siva Reddy Kallam
On Mon, Dec 12, 2016 at 3:53 PM, Siva Reddy Kallam wrote: > On Fri, Dec 9, 2016 at 7:59 PM, Billy Shuman wrote: >> On Thu, Dec 8, 2016 at 4:03 AM, Siva Reddy Kallam >> wrote: >>> On Thu, Dec 8, 2016 at 12:14 AM, Billy

Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be used without shash

2016-12-25 Thread Herbert Xu
On Sat, Dec 24, 2016 at 09:57:53AM -0800, Andy Lutomirski wrote: > > I actually do use incremental hashing later on. BPF currently > vmallocs() a big temporary buffer just so it can fill it and hash it. > I change it to hash as it goes. How much data is this supposed to hash on average? If

Re: [PATCH net 0/9] several fixups for virtio-net XDP

2016-12-25 Thread Jason Wang
On 2016年12月24日 01:10, John Fastabend wrote: On 16-12-23 06:37 AM, Jason Wang wrote: Merry Xmas and a Happy New year to all: This series tries to fixes several issues for virtio-net XDP which could be categorized into several parts: - fix several issues during XDP linearizing - allow csumed

Re: [PATCH net 7/9] virtio-net: forbid XDP when VIRTIO_NET_F_GUEST_UFO is support

2016-12-25 Thread Jason Wang
On 2016年12月24日 00:10, John Fastabend wrote: On 16-12-23 08:02 AM, John Fastabend wrote: On 16-12-23 06:37 AM, Jason Wang wrote: When VIRTIO_NET_F_GUEST_UFO is negotiated, host could still send UFO packet that exceeds a single page which could not be handled correctly by XDP. So this patch