Re: [PATCH v2] net: phy: micrel: add support for KSZ8795

2017-01-27 Thread Florian Fainelli
On 01/26/2017 11:46 PM, Sean Nyekjaer wrote: > This is adds support for the PHYs in the KSZ8795 5port managed switch. > > It will allow to detect the link between the switch and the soc > and uses the same read_status functions as the KSZ8873MLL switch. > > Signed-off-by: Sean Nyekjaer

Re: [PATCH v2 net] net: free ip_vs_dest structs when refcnt=0

2017-01-27 Thread Simon Horman
On Fri, Jan 27, 2017 at 01:21:11PM +0100, Pablo Neira Ayuso wrote: > On Fri, Jan 27, 2017 at 09:07:38AM +0100, Simon Horman wrote: > > On Thu, Jan 26, 2017 at 10:49:10PM +0200, Julian Anastasov wrote: > > > > > > Hello, > > > > > > On Mon, 23 Jan 2017, David Windsor wrote: > > > > > > >

Re: [PATCH v2 net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Sergei Shtylyov
On 01/27/2017 09:35 PM, Simon Horman wrote: From: Kazuya Mizuguchi This patch enables tx and rx clock internal delay modes (TDM and RDM). This is to address a failure in the case of 1Gbps communication using the by salvator-x board with the KSZ9031RNX phy.

Re: [PATCH RFC net-next] packet: always ensure that we pass hard_header_len bytes in skb_headlen() to the driver

2017-01-27 Thread Willem de Bruijn
> On (01/27/17 10:28), Willem de Bruijn wrote: >> > Would it make sense to only do the CAP_SYS_RAWIO branch if the >> > driver declares itself to have variable length L2 headers, via, e.g., >> > some priv flag? >> >> At the time, the comments were not specific to AX25. Again, we should >> probably

STRICTLY CONFIDENTIAL

2017-01-27 Thread Acct. Dept.
I have important transaction for you as next of kin to claim US$18.37m Mail me on my private email: chimwia...@gmail.com so I can send you more details Thanks Mr.Chim Wai Kim MOVE TO INBOX=== DISCLAIMER: This email and any files it contains are confidential

Re: [PATCH net-next 1/4] mlx5: Make building eswitch configurable

2017-01-27 Thread Saeed Mahameed
On Fri, Jan 27, 2017 at 1:32 AM, Tom Herbert wrote: > Add a configuration option (CONFIG_MLX5_CORE_ESWITCH) for controlling > whether the eswitch code is built. Change Kconfig and Makefile > accordingly. > > Signed-off-by: Tom Herbert > --- >

Re: [PATCH net-next 1/4] mlx5: Make building eswitch configurable

2017-01-27 Thread Tom Herbert
On Fri, Jan 27, 2017 at 10:28 AM, Saeed Mahameed wrote: > On Fri, Jan 27, 2017 at 8:16 PM, Tom Herbert wrote: >> On Fri, Jan 27, 2017 at 10:05 AM, Saeed Mahameed >> wrote: >>> On Fri, Jan 27, 2017 at 7:50 PM, Tom

Re: [PATCH net-next 1/4] mlx5: Make building eswitch configurable

2017-01-27 Thread Tom Herbert
On Fri, Jan 27, 2017 at 10:19 AM, Saeed Mahameed wrote: > On Fri, Jan 27, 2017 at 1:32 AM, Tom Herbert wrote: >> Add a configuration option (CONFIG_MLX5_CORE_ESWITCH) for controlling >> whether the eswitch code is built. Change Kconfig and

Re: [PATCH net-next 0/4] mlx5: Create build configuration options

2017-01-27 Thread Saeed Mahameed
On Fri, Jan 27, 2017 at 1:32 AM, Tom Herbert wrote: > This patchset creates configuration options for sriov, vxlan, eswitch, > and tc features in the mlx5 driver. The purpose of this is to allow not > building these features. These features are optional advanced features >

Re: [1/3] ath10k: remove multiple defines of DIAG_TRANSFER_LIMIT

2017-01-27 Thread Kalle Valo
Srinivas Kandagatla wrote: > DIAG_TRANSFER_LIMIT is redefined with same value and comments > just below this entry, remove this duplicate entry. > > Signed-off-by: Srinivas Kandagatla 3 patches applied to ath-next branch of

Re: [PATCH net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
On Fri, Jan 27, 2017 at 07:55:25PM +0300, Sergei Shtylyov wrote: > On 01/27/2017 07:49 PM, Simon Horman wrote: > > >>>From: Kazuya Mizuguchi > >>> > >>>This patch enables tx and rx clock internal delay modes (TDM and RDM). > >>> > >>>This is to address a failure

Re: [PATCH net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Sergei Shtylyov
On 01/27/2017 07:51 PM, Simon Horman wrote: From: Kazuya Mizuguchi This patch enables tx and rx clock internal delay modes (TDM and RDM). This is to address a failure in the case of 1Gbps communication using the by salvator-x board with the KSZ9031RNX phy.

Re: [PATCH net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Sergei Shtylyov
On 01/27/2017 09:07 PM, Simon Horman wrote: From: Kazuya Mizuguchi This patch enables tx and rx clock internal delay modes (TDM and RDM). This is to address a failure in the case of 1Gbps communication using the by salvator-x board with the KSZ9031RNX phy.

Re: [PATCH v2 net-next 0/4] sfc: encapsulated filters

2017-01-27 Thread Tom Herbert
On Fri, Jan 27, 2017 at 7:00 AM, Edward Cree wrote: > This series adds support for setting up filters for encapsulated traffic on > SFC 8000-series adapters, which recognise VXLAN, GENEVE and NVGRE packets by > parsing packet headers. (VXLAN and GENEVE will only be

Re: [PATCH net-next 1/4] mlx5: Make building eswitch configurable

2017-01-27 Thread Tom Herbert
On Fri, Jan 27, 2017 at 10:05 AM, Saeed Mahameed wrote: > On Fri, Jan 27, 2017 at 7:50 PM, Tom Herbert wrote: >> On Fri, Jan 27, 2017 at 9:38 AM, Saeed Mahameed >> wrote: >>> On Fri, Jan 27, 2017 at 7:34 AM, Or Gerlitz

Re: netvsc NAPI patch process

2017-01-27 Thread Greg KH
On Fri, Jan 27, 2017 at 09:39:53AM -0800, Stephen Hemminger wrote: > On Fri, 27 Jan 2017 08:54:06 +0100 > Greg KH wrote: > > > On Thu, Jan 26, 2017 at 01:06:46PM -0500, David Miller wrote: > > > From: Stephen Hemminger > > > Date: Thu, 26 Jan 2017

Re: [PATCH net-next] net: adjust skb->truesize in pskb_expand_head()

2017-01-27 Thread Eric Dumazet
On Fri, 2017-01-27 at 17:24 +, David Laight wrote: > From: Eric Dumazet > > Sent: 27 January 2017 14:44 > ... > > > I'm also guessing that extra headroom can be generated by stealing unused > > > tailroom. > > > > This is already done. > > > > Quoting > >

Re: [PATCH net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
On Fri, Jan 27, 2017 at 09:11:35PM +0300, Sergei Shtylyov wrote: > On 01/27/2017 09:07 PM, Simon Horman wrote: > > >From: Kazuya Mizuguchi > > > >This patch enables tx and rx clock internal delay modes (TDM and RDM). > > > >This is to address

Re: netvsc NAPI patch process

2017-01-27 Thread Stephen Hemminger
On Fri, 27 Jan 2017 08:54:06 +0100 Greg KH wrote: > On Thu, Jan 26, 2017 at 01:06:46PM -0500, David Miller wrote: > > From: Stephen Hemminger > > Date: Thu, 26 Jan 2017 10:04:05 -0800 > > > > > I have a working set of patches to enable NAPI in the

Re: [PATCH net-next 1/4] mlx5: Make building eswitch configurable

2017-01-27 Thread Saeed Mahameed
On Fri, Jan 27, 2017 at 7:50 PM, Tom Herbert wrote: > On Fri, Jan 27, 2017 at 9:38 AM, Saeed Mahameed > wrote: >> On Fri, Jan 27, 2017 at 7:34 AM, Or Gerlitz wrote: >>> On Fri, Jan 27, 2017 at 1:32 AM, Tom Herbert

Re: [PATCH net-next 0/4] mlx5: Create build configuration options

2017-01-27 Thread Tom Herbert
On Fri, Jan 27, 2017 at 9:58 AM, Saeed Mahameed wrote: > On Fri, Jan 27, 2017 at 1:32 AM, Tom Herbert wrote: >> This patchset creates configuration options for sriov, vxlan, eswitch, >> and tc features in the mlx5 driver. The purpose of this is to

[next-20170124] Kernel oops(rt6_fill_node) during reboot of LPAR

2017-01-27 Thread Sachin Sant
While rebooting PowerVM LPAR running 4.10.0-rc5-next-20170124 on a POWER8 box, following kernel oops is displayed. This problem was introduced with next-20170123. next-20170120 works. Initial analysis points to following patch included with next-20170123 commit

Re: [PATCH net-next 1/4] mlx5: Make building eswitch configurable

2017-01-27 Thread Saeed Mahameed
On Fri, Jan 27, 2017 at 8:16 PM, Tom Herbert wrote: > On Fri, Jan 27, 2017 at 10:05 AM, Saeed Mahameed > wrote: >> On Fri, Jan 27, 2017 at 7:50 PM, Tom Herbert wrote: >>> On Fri, Jan 27, 2017 at 9:38 AM, Saeed Mahameed >>>

[PATCH v2 net-next 0/2] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2017-01-27 Thread Simon Horman
Hi, this series adds support for gigabit communication to the Renesas EthernetAVB controller when used in conjunction with R-Car Gen3 H3 ES1.1+ and M3-W SoCs. Gigabit is already supported with R-Car Gen 2 SoCs. The patch from Geert was previously posted for inclusion in v4.10 and acked by Dave

[PATCH v2 net-next 2/2] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2017-01-27 Thread Simon Horman
From: Geert Uytterhoeven The limitation to 10/100Mbit speeds on R-Car Gen3 is valid for R-Car H3 ES1.0 only. Check for the exact SoC model to allow 1Gbps on newer revisions of R-Car H3, and on R-Car M3-W. Signed-off-by: Geert Uytterhoeven

[PATCH v2 net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
From: Kazuya Mizuguchi This patch enables tx and rx clock internal delay modes (TDM and RDM). This is to address a failure in the case of 1Gbps communication using the by salvator-x board with the KSZ9031RNX phy. This has been reported to occur with both the

[PATCH] cfg80211 debugfs: Cleanup some checkpatch issues

2017-01-27 Thread Pichugin Dmitry
This fixes the checkpatch.pl warnings: * Macros should not use a trailing semicolon. * Spaces required around that '='. * Symbolic permissions 'S_IRUGO' are not preferred. * Macro argument reuse 'buflen' - possible side-effects Signed-off-by: Pichugin Dmitry ---

Re: [PATCH v2 net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
On Fri, Jan 27, 2017 at 10:05:58PM +0300, Sergei Shtylyov wrote: > On 01/27/2017 09:35 PM, Simon Horman wrote: > > >From: Kazuya Mizuguchi > > > >This patch enables tx and rx clock internal delay modes (TDM and RDM). > > > >This is to address a failure in the

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-27 Thread Pavel Machek
On Fri 2017-01-27 17:23:07, Kalle Valo wrote: > Pali Rohár writes: > > > On Friday 27 January 2017 14:26:22 Kalle Valo wrote: > >> Pali Rohár writes: > >> > >> > 2) It was already tested that example NVS data can be used for N900 e.g. > >> > for SSH

[PATCH v3 net-next 2/2] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2017-01-27 Thread Simon Horman
From: Geert Uytterhoeven The limitation to 10/100Mbit speeds on R-Car Gen3 is valid for R-Car H3 ES1.0 only. Check for the exact SoC model to allow 1Gbps on newer revisions of R-Car H3, and on R-Car M3-W. Signed-off-by: Geert Uytterhoeven

Re: [PATCH v2] net: phy: micrel: add support for KSZ8795

2017-01-27 Thread Sean Nyekjær
On 2017-01-27 19:55, Florian Fainelli wrote: On 01/26/2017 11:46 PM, Sean Nyekjaer wrote: This is adds support for the PHYs in the KSZ8795 5port managed switch. It will allow to detect the link between the switch and the soc and uses the same read_status functions as the KSZ8873MLL switch.

Re: [PATCH 1/3] net: bgmac: allocate struct bgmac just once & don't copy it

2017-01-27 Thread Rafał Miłecki
On 27 January 2017 at 17:14, David Miller wrote: > From: Felix Fietkau > Date: Fri, 27 Jan 2017 17:02:33 +0100 > >> On 2017-01-27 10:20, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> To share as much code as possible in bgmac we call

Re: [PATCH v2] net: phy: micrel: add support for KSZ8795

2017-01-27 Thread Florian Fainelli
On 01/27/2017 11:52 AM, Sean Nyekjær wrote: > > > On 2017-01-27 19:55, Florian Fainelli wrote: >> On 01/26/2017 11:46 PM, Sean Nyekjaer wrote: >>> This is adds support for the PHYs in the KSZ8795 5port managed switch. >>> >>> It will allow to detect the link between the switch and the soc >>>

Re: [PATCH v3] can: Fix kernel panic at security_sock_rcv_skb

2017-01-27 Thread Oliver Hartkopp
On 01/27/2017 05:11 PM, Eric Dumazet wrote: From: Eric Dumazet Zhang Yanmin reported crashes [1] and provided a patch adding a synchronize_rcu() call in can_rx_unregister() The main problem seems that the sockets themselves are not RCU protected. If CAN uses RCU for

[PATCH v3 net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
From: Kazuya Mizuguchi This patch enables tx and rx clock internal delay modes (TDM and RDM). This is to address a failure in the case of 1Gbps communication using the by salvator-x board with the KSZ9031RNX phy. This has been reported to occur with both the

[PATCH v3 net-next 0/2] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2017-01-27 Thread Simon Horman
Hi, this series adds support for gigabit communication to the Renesas EthernetAVB controller when used in conjunction with R-Car Gen3 H3 ES1.1+ and M3-W SoCs. Gigabit is already supported with R-Car Gen 2 SoCs. The patch from Geert was previously posted for inclusion in v4.10 and acked by Dave

Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues

2017-01-27 Thread Joe Perches
On Fri, 2017-01-27 at 22:26 +0300, Pichugin Dmitry wrote: > This fixes the checkpatch.pl warnings: > * Macros should not use a trailing semicolon. > * Spaces required around that '='. > * Symbolic permissions 'S_IRUGO' are not preferred. OK > * Macro argument reuse 'buflen' - possible

Re: [PATCH RFC net-next] packet: always ensure that we pass hard_header_len bytes in skb_headlen() to the driver

2017-01-27 Thread Sowmini Varadhan
On (01/27/17 14:29), Willem de Bruijn wrote: > > As your patch state, the contract is that any packet delivered to a > driver has the entire L2 in its linear section. Drivers are not required > to be robust against shorter packets, so there is no reason to test > those. > > One option is to

Re: [PATCH 0/6 v3] kvmalloc

2017-01-27 Thread Daniel Borkmann
On 01/27/2017 11:05 AM, Michal Hocko wrote: On Thu 26-01-17 21:34:04, Daniel Borkmann wrote: On 01/26/2017 02:40 PM, Michal Hocko wrote: [...] But realistically, how big is this problem really? Is it really worth it? You said this is an admin only interface and admin can kill the machine by

[PATCH net-next 7/9] net: dsa: mv88e6xxx: use dsa_port's bridge pointer

2017-01-27 Thread Vivien Didelot
Now that DSA exposes the bridge device pointer to which a port belongs, use it when programming the port based VLANs and thus remove the cache. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 27 +++

[net-next v2] openvswitch: Simplify do_execute_actions().

2017-01-27 Thread Andy Zhou
do_execute_actions() implements a worthwhile optimization: in case an output action is the last action in an action list, skb_clone() can be avoided by outputing the current skb. However, the implementation is more complicated than necessary. This patch simplify this logic. Signed-off-by: Andy

Re: [PATCH net-next 1/4] mlx5: Make building eswitch configurable

2017-01-27 Thread Saeed Mahameed
On Fri, Jan 27, 2017 at 8:42 PM, Tom Herbert wrote: > On Fri, Jan 27, 2017 at 10:28 AM, Saeed Mahameed > wrote: >> On Fri, Jan 27, 2017 at 8:16 PM, Tom Herbert wrote: >>> On Fri, Jan 27, 2017 at 10:05 AM, Saeed Mahameed >>>

[PATCH net-next v3 3/4] net: ipv6: Add support to dump multipath routes via RTA_MULTIPATH attribute

2017-01-27 Thread David Ahern
IPv6 returns multipath routes as a series of individual routes making their display and handling by userspace different and more complicated than IPv4, putting the burden on the user to see that a route is part of a multipath route and internally creating a multipath route if desired (e.g., libnl

[PATCH net-next v3 4/4] net: ipv6: Use compressed IPv6 addresses showing route replace error

2017-01-27 Thread David Ahern
ip6_print_replace_route_err logs an error if a route replace fails with IPv6 addresses in the full format. e.g,: IPv6: IPV6: multipath route replace failed (check consistency of installed routes): 2001:0db8:0200::::: nexthop 2001:0db8:0001:::::0016 ifi 0

[PATCH net-next v3 2/4] net: ipv6: Allow shorthand delete of all nexthops in multipath route

2017-01-27 Thread David Ahern
IPv4 allows multipath routes to be deleted using just the prefix and length. For example: $ ip ro ls vrf red unreachable default metric 8192 1.1.1.0/24 nexthop via 10.100.1.254 dev eth1 weight 1 nexthop via 10.11.200.2 dev eth11.200 weight 1 10.11.200.0/24 dev

Re: net: suspicious RCU usage in nf_hook

2017-01-27 Thread Cong Wang
On Fri, Jan 27, 2017 at 1:15 PM, Dmitry Vyukov wrote: > stack backtrace: > CPU: 2 PID: 23111 Comm: syz-executor14 Not tainted 4.10.0-rc5+ #192 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 > Call Trace: > __dump_stack lib/dump_stack.c:15

[PATCH net-next 3/4] net: dsa: bcm_sf2: Add CFP registers definitions

2017-01-27 Thread Florian Fainelli
Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2_regs.h | 146 + 1 file changed, 146 insertions(+) diff --git a/drivers/net/dsa/bcm_sf2_regs.h b/drivers/net/dsa/bcm_sf2_regs.h index 6b63c00928ba..26052450091e 100644 ---

[net 6/8] net/mlx5e: Modify TIRs hash only when it's needed

2017-01-27 Thread Saeed Mahameed
From: Gal Pressman We don't need to modify our TIRs unless the user requested a change in the hash function/key, for example when changing indirection only. Fixes: bdfc028de1b3 ("net/mlx5e: Fix ethtool RX hash func configuration change") Signed-off-by: Gal Pressman

[net 1/8] net/mlx5: Change ENOTSUPP to EOPNOTSUPP

2017-01-27 Thread Saeed Mahameed
From: Or Gerlitz As ENOTSUPP is specific to NFS, change the return error value to EOPNOTSUPP in various places in the mlx5 driver. Signed-off-by: Or Gerlitz Suggested-by: Yotam Gigi Reviewed-by: Matan Barak

[PATCH net-next 4/4] net: dsa: bcm_sf2: Add support for ethtool::rxnfc

2017-01-27 Thread Florian Fainelli
Add support for configuring classification rules using the ethtool::rxnfc API. This is useful to program the switch's CFP/TCAM to redirect specific packets to specific ports/queues for instance. For now, we allow any kind of IPv4 5-tuple matching. Signed-off-by: Florian Fainelli

[net 5/8] net/mlx5e: Support TC encapsulation offloads with upper devices

2017-01-27 Thread Saeed Mahameed
From: Hadar Hen Zion When tunneling is used, some virtualizations systems set the (mlx5e) uplink device to be stacked under upper devices such as bridge or ovs internal port, where the VTEP IP address used for the encapsulation is set on that upper device. In order to

Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues

2017-01-27 Thread Joe Perches
On Fri, 2017-01-27 at 22:00 +0100, Johannes Berg wrote: > On Fri, 2017-01-27 at 22:26 +0300, Pichugin Dmitry wrote: > > This fixes the checkpatch.pl warnings: > > * Macros should not use a trailing semicolon. > > * Spaces required around that '='. > > * Symbolic permissions 'S_IRUGO' are not

[net 2/8] net/mlx5: Return EOPNOTSUPP when failing to get steering name-space

2017-01-27 Thread Saeed Mahameed
From: Or Gerlitz When we fail to retrieve a hardware steering name-space, the returned error code should say that this operation is not supported. Align the various places in the driver where this call is made to this convention. Also, make sure to warn when we fail to

[PATCH net-next 3/3] net: dsa: bcm_sf2: Add support for ethtool::rxnfc

2017-01-27 Thread Florian Fainelli
Add support for configuring classification rules using the ethtool::rxnfc API. This is useful to program the switch's CFP/TCAM to redirect specific packets to specific ports/queues for instance. For now, we allow any kind of IPv4 5-tuple matching. Signed-off-by: Florian Fainelli

[net 4/8] net/mlx5: E-Switch, Re-enable RoCE on mode change only after FDB destroy

2017-01-27 Thread Saeed Mahameed
From: Or Gerlitz We must re-enable RoCE on the e-switch management port (PF) only after destroying the FDB in its switchdev/offloaded mode. Otherwise, when encapsulation is supported, this re-enablement will fail. Also, it's more natural and symmetric to disable RoCE on

[PATCH net-next 0/4] net: dsa: bcm_sf2: CFP support

2017-01-27 Thread Florian Fainelli
Hi all, This patch series adds support for the Broadcom Compact Field Processor (CFP) which is a classification and matching engine built into most Broadcom switches. We support that using ethtool::rxnfc because it allows all known uses cases from the users I support to work, and more

[PATCH net-next 1/4] net: dsa: Hook {get,set}_rxnfc ethtool operations

2017-01-27 Thread Florian Fainelli
In preparation for adding support for CFP/TCAMP in the bcm_sf2 driver add the plumbing to call into driver specific {get,set}_rxnfc operations. Signed-off-by: Florian Fainelli --- include/net/dsa.h | 8 net/dsa/slave.c | 26 ++ 2 files

[net 7/8] net/mlx5e: Fix update of hash function/key via ethtool

2017-01-27 Thread Saeed Mahameed
From: Gal Pressman Modifying TIR hash should change selected fields bitmask in addition to the function and key. Formerly, we would not set this field resulting in zeroing of its value, which means no packet fields are used for RX RSS hash calculation thus causing all traffic

[PATCH net-next 2/4] net: dsa: bcm_sf2: Configure traffic classes to queue mapping

2017-01-27 Thread Florian Fainelli
By default, all traffic goes to queue 0, re-configure the traffic classes to quality of service mapping such that priority X maps to queue X, where X is from 0 through 7. Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 9 +

[pull request][net 0/8] Mellanox mlx5 fixes 2017-01-27

2017-01-27 Thread Saeed Mahameed
Hi Dave, This pull request includes some mlx5 fixes for net, please see details below. Please pull and let me know if there's any problem. For -stable: net/mlx5e: Modify TIRs hash only when it's needed net/mlx5e: Fix update of hash function/key via ethtool Thanks, Saeed. --- The

[PATCH 3/5] [net-next] net: qcom/emac: do not call emac_mac_start twice

2017-01-27 Thread Timur Tabi
emac_mac_start() uses information from the external PHY to program the MAC, so it makes no sense to call it before the link is up. Signed-off-by: Timur Tabi --- drivers/net/ethernet/qualcomm/emac/emac-mac.c | 2 +- drivers/net/ethernet/qualcomm/emac/emac-mac.h | 1 -

[PATCH 2/5] [net-next] net: qcom/emac: always use autonegotiation to configure the SGMII link

2017-01-27 Thread Timur Tabi
Regardless of how the external PHY is configured, the internal PHY (the "SGMII" block) is capable of configuring the SGMII link automatically. When the external PHY link comes up, regardless of how it is configured, the SGMII link is configured automatically. Signed-off-by: Timur Tabi

[PATCH 5/5] [net-next] net: qcom/emac: add an error interrupt handler for the sgmii

2017-01-27 Thread Timur Tabi
The SGMII (internal PHY) can report decode errors via an interrupt. It can also report autonegotiation status changes, but we don't need to track those. The SGMII can recover automatically from most decode errors, so we only reset the interface if we get multiple consecutive errors. It's

[PATCH 4/4] [net-next] net: qcom/emac: add an error interrupt handler for the sgmii

2017-01-27 Thread Timur Tabi
The SGMII (internal PHY) can report decode errors via an interrupt. It can also report autonegotiation status changes, but we don't need to track those. The SGMII can recover automatically from most decode errors, so we only reset the interface if we get multiple consecutive errors. It's

[PATCH 4/5] [net-next] net: qcom/emac: remove extraneous wake-on-lan code

2017-01-27 Thread Timur Tabi
The EMAC driver does not support wake-on-lan, but there is still code left-over that partially enables it. Remove that code and a few macros that support it. Signed-off-by: Timur Tabi --- drivers/net/ethernet/qualcomm/emac/emac-mac.c | 10 --

[PATCH 1/5] [net-next] net: qcom/emac: display the phy driver info after we connect

2017-01-27 Thread Timur Tabi
The PHY driver is attached only when the driver calls phy_connect_direct(). Calling phy_attached_print() to display information about the PHY driver prior to that point is meaningless. The interface can be brought down, a new PHY driver can be loaded, and the interface then brought back up. This

[PATCH 0/5] [net-next] net: qcom/emac:

2017-01-27 Thread Timur Tabi
Although not related, these patches affect the same files, so they should be applied in order. The first patch cleans up logging of when the the phy driver is attached. The second patch always configures the SGMII to use autonegotiation mode. The third patch removes a redundant call to

Re: [PATCH V3 net-next 02/14] net/ena: fix error handling when probe fails

2017-01-27 Thread Lino Sanfilippo
Hi, On 26.01.2017 23:18, Netanel Belgazal wrote: When driver fails in probe, it will release all resources, including adapter. In case of probe failure, ena_remove should not try to free the adapter resources. Signed-off-by: Netanel Belgazal ---

Re: [PATCH v4] net: ethernet: faraday: To support device tree usage.

2017-01-27 Thread Rob Herring
On Wed, Jan 25, 2017 at 10:09:20PM +0100, Arnd Bergmann wrote: > On Wed, Jan 25, 2017 at 6:34 PM, David Miller wrote: > > From: Greentime Hu > > Date: Tue, 24 Jan 2017 16:46:14 +0800 > >> We also use the same binding document to describe the same faraday

Re: [PATCH net-next 1/4] mlx5: Make building eswitch configurable

2017-01-27 Thread Alexei Starovoitov
On 1/27/17 1:15 PM, Saeed Mahameed wrote: It is only mandatory for configurations that needs eswitch, where the driver has no way to know about them, for a good old bare metal box, eswitch is not needed. we can do some work to strip the l2 table logic - needed for PFs to work on multi-host -

[RFC PATCH 1/2] af_packet: direct dma for packet ineterface

2017-01-27 Thread John Fastabend
This adds ndo ops for upper layer objects to request direct DMA from the network interface into memory "slots". The slots must be DMA'able memory given by a page/offset/size vector in a packet_ring_buffer structure. The PF_PACKET socket interface can use these ndo_ops to do zerocopy RX from the

[RFC PATCH 2/2] ixgbe: add af_packet direct copy support

2017-01-27 Thread John Fastabend
This implements the ndo ops for direct dma socket option. This is to start looking at the interface and driver work needed to enable it. Note error paths are not handled and I'm aware of a few bugs. For example interface must be up before attaching socket or else it will fail silently. TBD fix

Re: [PATCH net-next 0/4] net: dsa: bcm_sf2: CFP support

2017-01-27 Thread Chris Healy
Hi Florian, In saying the below, I may just be showing my naivety but here goes: If I understand this correctly, what you are using is similar to the TCAM hardware present in the newer Marvell switches. I think Pablo is doing some work with nftables and HW offload using TCAM HW. Is there

[RFC PATCH 0/2] rx zero copy interface for af_packet

2017-01-27 Thread John Fastabend
This is an experimental implementation of rx zero copy for af_packet. Its a bit rough and likely has errors but the plan is to clean it up over the next few months. And seeing I said I would post it in another thread a few days back here it is. Comments welcome and use at your own risk. Thanks,

Re: [PATCH RFC net-next] packet: always ensure that we pass hard_header_len bytes in skb_headlen() to the driver

2017-01-27 Thread Sowmini Varadhan
On (01/27/17 15:51), Willem de Bruijn wrote: : > - limit capable() check to drivers with with .validate callback (aka second option below) : > - let privileged applications shoot themselves in the foot (change nothing). > The second will break variable length header protocols unless >

[PATCH net-next v3 1/4] net: ipv6: add NLM_F_APPEND in notifications when applicable

2017-01-27 Thread David Ahern
IPv6 does not set the NLM_F_APPEND flag in notifications to signal that a NEWROUTE is an append versus a new route or a replaced one. Add the flag if the request has it. Signed-off-by: David Ahern --- net/ipv6/ip6_fib.c | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [PATCH 4/4] [net-next] net: qcom/emac: add an error interrupt handler for the sgmii

2017-01-27 Thread Timur Tabi
On 01/27/2017 04:43 PM, Timur Tabi wrote: The SGMII (internal PHY) can report decode errors via an interrupt. It can also report autonegotiation status changes, but we don't need to track those. The SGMII can recover automatically from most decode errors, so we only reset the interface if we

[PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-27 Thread David Ahern
This series closes a couple of gaps between IPv4 and IPv6 with respect to multipath routes: 1. IPv4 allows all nexthops of multipath routes to be deleted using just the prefix and length; IPv6 only deletes the first nexthop for the route if only the prefix and length are given. 2. IPv4

Re: net: suspicious RCU usage in nf_hook

2017-01-27 Thread Eric Dumazet
On Fri, 2017-01-27 at 22:15 +0100, Dmitry Vyukov wrote: > Hello, > > I've got the following report while running syzkaller fuzzer on > fd694aaa46c7ed811b72eb47d5eb11ce7ab3f7f1: > > [ INFO: suspicious RCU usage. ] > 4.10.0-rc5+ #192 Not tainted > --- >

Re: [PATCH RFC net-next] packet: always ensure that we pass hard_header_len bytes in skb_headlen() to the driver

2017-01-27 Thread Willem de Bruijn
On Fri, Jan 27, 2017 at 4:58 PM, Sowmini Varadhan wrote: > On (01/27/17 15:51), Willem de Bruijn wrote: > : >> - limit capable() check to drivers with with .validate callback > (aka second option below) > : >> - let privileged applications shoot themselves in

Re: net: suspicious RCU usage in nf_hook

2017-01-27 Thread Cong Wang
On Fri, Jan 27, 2017 at 3:35 PM, Eric Dumazet wrote: > Oh well, I forgot to submit the official patch I think, Jan 9th. > > https://groups.google.com/forum/#!topic/syzkaller/BhyN5OFd7sQ > Hmm, but why only fragments need skb_orphan()? It seems like any kfree_skb() inside

[PATCH net-next 2/2] tcp: include locally failed retries in retransmission stats

2017-01-27 Thread Yuchung Cheng
Currently the retransmission stats are not incremented if the retransmit fails locally. But we always increment the other packet counters that track total packet/bytes sent. Awkwardly while we don't count these failed retransmits in RETRANSSEGS, we do count them in FAILEDRETRANS. If the qdisc is

[PATCH net-next 1/2] tcp: record pkts sent and retransmistted

2017-01-27 Thread Yuchung Cheng
Add two stats in SCM_TIMESTAMPING_OPT_STATS: TCP_NLA_DATA_SEGS_OUT: total data packets sent including retransmission TCP_NLA_TOTAL_RETRANS: total data packets retransmitted The names are picked to be consistent with corresponding fields in TCP_INFO. This allows applications that are using the

[PATCH net-next 4/4] net: dsa: bcm_sf2: Add support for port mirroring

2017-01-27 Thread Florian Fainelli
We can use b53_mirror_add and b53_mirror_del because the Starfighter 2 is register compatible in that specific case. Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dsa/bcm_sf2.c

[PATCH net-next 3/4] net: dsa: b53: Add support for port mirroring

2017-01-27 Thread Florian Fainelli
Add support for configuring port mirroring through the cls_matchall classifier. We do a full ingress or egress capture towards the capture port. Future improvements could include leveraging the divider to allow less frames to be captured, as well as matching specific MAC DA/SA. Signed-off-by:

[PATCH net-next 2/4] net: dsa: b53: Add mirror capture register definitions

2017-01-27 Thread Florian Fainelli
Add definitions for the different Roboswitch registers relevant for ingress and egress mirroring. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_regs.h | 32 1 file changed, 32 insertions(+) diff --git

Re: [net-next] openvswitch: Simplify do_execute_actions().

2017-01-27 Thread Andy Zhou
On Fri, Jan 27, 2017 at 12:42 PM, Pravin Shelar wrote: > On Wed, Jan 25, 2017 at 9:24 PM, Andy Zhou wrote: >> do_execute_actions() implements a worthwhile optimization: in case >> an output action is the last action in an action list, skb_clone() >> can be avoided

Re: [PATCH net-next 0/4] net: dsa: bcm_sf2: CFP support

2017-01-27 Thread Florian Fainelli
Hi Chris, On 01/27/2017 01:24 PM, Chris Healy wrote: > Hi Florian, > > In saying the below, I may just be showing my naivety but here goes: > > If I understand this correctly, what you are using is similar to the > TCAM hardware present in the newer Marvell switches. I think Pablo is > doing

[PATCH net-next v2 2/4] net: dsa: b53: Add mirror capture register definitions

2017-01-27 Thread Florian Fainelli
Add definitions for the different Roboswitch registers relevant for ingress and egress mirroring. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_regs.h | 32 1 file changed, 32 insertions(+) diff --git

[PATCH net-next v2 1/4] net: dsa: Add plumbing for port mirroring

2017-01-27 Thread Florian Fainelli
Add necessary plumbing at the slave network device level to have switch drivers implement ndo_setup_tc() and most particularly the cls_matchall classifier. We add support for two switch operations: port_add_mirror and port_del_mirror() which configure, on a per-port basis the mirror parameters

[PATCH net-next v2 0/4] net: dsa: Port mirroring support

2017-01-27 Thread Florian Fainelli
Hi all, This patch series adds support for port mirroring in the two Broadcom switch drivers. The major part of the functional are actually with the plumbing between tc and the drivers. David, this will most likely conflict a little bit with my other series: net: dsa: bcm_sf2: CFP support, so

[PATCH net-next v2 3/4] net: dsa: b53: Add support for port mirroring

2017-01-27 Thread Florian Fainelli
Add support for configuring port mirroring through the cls_matchall classifier. We do a full ingress or egress capture towards the capture port. Future improvements could include leveraging the divider to allow less frames to be captured, as well as matching specific MAC DA/SA. Signed-off-by:

[PATCH net-next v2 4/4] net: dsa: bcm_sf2: Add support for port mirroring

2017-01-27 Thread Florian Fainelli
We can use b53_mirror_add and b53_mirror_del because the Starfighter 2 is register compatible in that specific case. Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dsa/bcm_sf2.c

[net 3/8] net/mlx5: E-Switch, Err when retrieving steering name-space fails

2017-01-27 Thread Saeed Mahameed
From: Or Gerlitz Make sure to return error when we failed retrieving the FDB steering name space. Also, while around, correctly print the error when mode change revert fails in the warning message. Signed-off-by: Or Gerlitz Reported-by: Leon

Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues

2017-01-27 Thread Johannes Berg
On Fri, 2017-01-27 at 22:26 +0300, Pichugin Dmitry wrote: > This fixes the checkpatch.pl warnings: > * Macros should not use a trailing semicolon. > * Spaces required around that '='. > * Symbolic permissions 'S_IRUGO' are not preferred. > * Macro argument reuse 'buflen' - possible side-effects I

[PATCH v2] net: adaptec: starfire: add checks for dma mapping errors

2017-01-27 Thread Alexey Khoroshilov
init_ring(), refill_rx_ring() and start_tx() don't check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov ---

Re: [PATCH 1/2] Documentation: devicetree: change the mediatek ethernet compatible string

2017-01-27 Thread Rob Herring
On Wed, Jan 25, 2017 at 09:20:54AM +0100, John Crispin wrote: > When the binding was defined, I was not aware that mt2701 was an earlier > version of the SoC. For sake of consistency, the ethernet driver should > use mt2701 inside the compat string as this is the earliest SoC with the > ethernet

Re: [PATCH net-next 0/4] net: dsa: Port mirroring support

2017-01-27 Thread Florian Fainelli
On 01/27/2017 04:40 PM, Florian Fainelli wrote: > Hi all, > > This patch series adds support for port mirroring in the two > Broadcom switch drivers. The major part of the functional are actually with > the plumbing between tc and the drivers. Meh, there are two issues that need fixing: - left

net: suspicious RCU usage in nf_hook

2017-01-27 Thread Dmitry Vyukov
Hello, I've got the following report while running syzkaller fuzzer on fd694aaa46c7ed811b72eb47d5eb11ce7ab3f7f1: [ INFO: suspicious RCU usage. ] 4.10.0-rc5+ #192 Not tainted --- ./include/linux/rcupdate.h:561 Illegal context switch in RCU read-side critical section!

Re: net: suspicious RCU usage in nf_hook

2017-01-27 Thread Cong Wang
On Fri, Jan 27, 2017 at 3:22 PM, Cong Wang wrote: > On Fri, Jan 27, 2017 at 1:15 PM, Dmitry Vyukov wrote: >> stack backtrace: >> CPU: 2 PID: 23111 Comm: syz-executor14 Not tainted 4.10.0-rc5+ #192 >> Hardware name: QEMU Standard PC (i440FX + PIIX,

  1   2   3   >