Re: linux-next: manual merge of the akpm tree with the net-next tree

On 02/07/2017 06:23 AM, Stephen Rothwell wrote: > Hi Andrew, > > Today's linux-next merge of the akpm tree got a conflict in: > > drivers/net/can/flexcan.c > > between commits: > > 9eb7aa891101 ("can: flexcan: add quirk FLEXCAN_QUIRK_ENABLE_EACEN_RRS") > b3cf53e988ce ("can: flexcan: add

Re: [PATCHv4 net-next 5/7] net: add confirm_neigh method to dst_ops

On Mon, Feb 06, 2017 at 11:14:15PM +0200, Julian Anastasov wrote: > Add confirm_neigh method to dst_ops and use it from IPv4 and IPv6 > to lookup and confirm the neighbour. Its usage via the new helper > dst_confirm_neigh() should be restricted to MSG_PROBE users for > performance reasons. > >

Re: [PATCH] [net-next] mlxsw: add psample dependency for spectrum

Mon, Feb 06, 2017 at 05:26:30PM CET, a...@arndb.de wrote: >When PSAMPLE is a loadable module, spectrum must not be built-in: > >drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func': >spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet' > >This adds a Kconfig

Re: [PATCH net v2] mlx4: Invoke softirqs after napi_reschedule

On 06/02/2017 8:14 PM, Benjamin Poirier wrote: mlx4 may schedule napi from a workqueue. Afterwards, softirqs are not run in a deterministic time frame and the following message may be logged: NOHZ: local_softirq_pending 08 The problem is the same as what was described in commit ec13ee80145c

Re: wcn36xx: Implement cancel_hw_scan

Bjorn Andersson wrote: > In the event that the wcn36xx interface is brought down while a hw_scan > is active we must abort and wait for the ongoing scan to signal > completion to mac80211. > > Reported-by: Mart Raudsepp > Fixes: 886039036c20

[PATCH RFC ipsec-next 1/5] xfrm: Add a secpath_set helper.

Add a new helper to set the secpath to the skb. This avoids code duplication, as this is used in multiple places. Signed-off-by: Steffen Klassert --- include/net/xfrm.h | 1 + net/ipv6/xfrm6_input.c | 15 +++ net/xfrm/xfrm_input.c | 35

[PATCH RFC ipsec-next 3/5] net: Prepare gro for packet consuming gro callbacks

The upcomming IPsec ESP gro callbacks will consume the skb, so prepare for that. Signed-off-by: Steffen Klassert --- include/linux/netdevice.h | 9 + net/core/dev.c| 7 +++ net/xfrm/Kconfig | 4 3 files changed, 20

[PATCH RFC ipsec-next 2/5] net: Add a skb_gro_flush_final helper.

Add a skb_gro_flush_final helper to prepare for consuming skbs in call_gro_receive. We will extend this helper to not touch the skb if the skb is consumed by a gro callback with a followup patch. We need this to handle the upcomming IPsec ESP callbacks as they reinject the skb to the

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

Adrian Chadd writes: > Removing this method makes the diff to FreeBSD larger, as "vif" in > FreeBSD is a different pointer. > > (Yes, I have ath10k on freebsd working and I'd like to find a way to > reduce the diff moving forward.) I don't like this "(void *) vif->drv_priv"

[PATCH RFC ipsec-next 4/5] xfrm: Export xfrm_parse_spi.

We need it in the ESP offload handlers, so export it. Signed-off-by: Steffen Klassert --- include/net/xfrm.h| 1 + net/xfrm/xfrm_input.c | 1 + 2 files changed, 2 insertions(+) diff --git a/include/net/xfrm.h b/include/net/xfrm.h index 25082e2..8acea1e 100644

[PATCH RFC ipsec-next 0/5] IPsec GRO layer decapsulation

This patchset adds a software GRO codepath for IPsec ESP. The ESP gro_receive callback functions decapsulate the ESP packets at the GRO layer and reinject them back with gro_cells_receive(). This saves a complete round through the stack for IPsec ESP packets. We also need this for ESP HW offload,

[PATCH] arm-proc-root-undeclared-error

From: sreedhar donelli --- net/atm/clip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/atm/clip.c b/net/atm/clip.c index 53b4ac0..7a7cb4a 100644 --- a/net/atm/clip.c +++ b/net/atm/clip.c @@ -930,8 +930,9 @@ static void

[PATCH] arm-proc-root-undeclared-error

From: sreedhar donelli *** BLURB HERE *** sreedhar donelli (1): arm-proc-root-undeclared-error net/atm/clip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 1.9.1 =-=-= Notice: The information contained in this e-mail message

[PATCH] Fixed it by putting the proc cleanup code inside a #ifdef CONFIG_PROC_FS block.

From: sreedhar donelli *** BLURB HERE *** sreedhar donelli (1): arm-proc-root-undeclared-error net/atm/clip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 1.9.1 =-=-= Notice: The information contained in this e-mail message

[PATCH RFC ipsec-next 5/5] esp: Add a software GRO codepath

This patch adds GRO ifrastructure and callbacks for ESP on ipv4 and ipv6. In case the GRO layer detects an ESP packet, the esp{4,6}_gro_receive() function does a xfrm state lookup and calls the xfrm input layer if it finds a matching state. The packet will be decapsulated and reinjected it into

[PATCH 0/2] get rid of immrbar_virt_to_phys()

ucc_geth ethernet driver is the only driver using immrbar_virt_to_phys() and it uses it incorrectly. This patch fixes ucc_geth driver then removes immrbar_virt_to_phys() Christophe Leroy (2): net: ethernet: ucc_geth: fix MEM_PART_MURAM mode soc/fsl/qe: get rid of immrbar_virt_to_phys()

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

On 17-02-06 14:46:21, Johan Hovold wrote: > On Mon, Feb 06, 2017 at 02:32:23PM +0100, Johan Hovold wrote: > > On Mon, Feb 06, 2017 at 02:21:24PM +0100, Johan Hovold wrote: > > > On Mon, Feb 06, 2017 at 02:51:09PM +0200, Petko Manolov wrote: > > > > On 17-02-06 09:28:22, Greg KH wrote: > > > > > On

Re: [patch v2 net-next] sfc: fix an off by one bug

On 07/02/17 07:44, Dan Carpenter wrote: > This bug is harmless because it's just a sanity check and we always > pass valid values for "encap_type" but the test is off by one. > > Fixes: 9b4108012517 ("sfc: insert catch-all filters for encapsulated traffic") > Signed-off-by: Dan Carpenter

[PATCH 1/2] net: ethernet: ucc_geth: fix MEM_PART_MURAM mode

Since commit 5093bb965a163 ("powerpc/QE: switch to the cpm_muram implementation"), muram area is not part of immrbar mapping anymore so immrbar_virt_to_phys() is not usable anymore. Fixes: 5093bb965a163 ("powerpc/QE: switch to the cpm_muram implementation) Signed-off-by: Christophe Leroy

[PATCH 2/2] soc/fsl/qe: get rid of immrbar_virt_to_phys()

immrbar_virt_to_phys() is not used anymore Signed-off-by: Christophe Leroy --- drivers/soc/fsl/qe/qe.c | 4 +--- include/soc/fsl/qe/immap_qe.h | 19 --- 2 files changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/soc/fsl/qe/qe.c

Re: linux-next: manual merge of the akpm tree with the net-next tree

Hi Marc, On Tue, 7 Feb 2017 09:40:09 +0100 Marc Kleine-Budde wrote: > > On 02/07/2017 06:23 AM, Stephen Rothwell wrote: > > diff --cc drivers/net/can/flexcan.c > > index ea57fed375c6,4dc71bce525c.. > > --- a/drivers/net/can/flexcan.c > > +++

Re: [PATCH v2 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

Hi Andrew, Thank you for given review comments. On Wed, Feb 01, 2017 at 02:55:55PM +0100, Andrew Lunn wrote: > EXTERNAL EMAIL > > > On Wed, Feb 01, 2017 at 06:23:46PM +0530, Raju Lakkaraju wrote: > > From: Raju Lakkaraju > > > > LED Mode: > > +

net/sctp: GPF in sctp_addr_id2transport

Hello, The following program triggers GPF in sctp_addr_id2transport: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include #include #include int main() { int sock = socket(AF_INET6, SOCK_SEQPACKET, IPPROTO_SCTP); struct sctp_paddrinfo

RE: Disabling msix interrupts

From: David Miller > Sent: 06 February 2017 19:15 > From: David Laight > Date: Mon, 6 Feb 2017 17:23:54 + > > > Although the 'store buffer' on the sparc cpus I used to use would > > let reads overtake writes. So you did have to read back the address > > of the last

Re: [patch net-next 0/8] mlxsw: cleanup neigh handling

Mon, Feb 06, 2017 at 05:28:44PM CET, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Mon, 6 Feb 2017 16:20:09 +0100 > >> From: Jiri Pirko >> >> Ido says: >> >> This series addresses long standing issues in the mlxsw driver >> concerning neighbour

[PATCH] net: intel: ixgbe: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c |

[BISECTED] Re: Strange ARP behaviour with VXLAN

On 01/02/17 16:20, Edward Cree wrote: > [ Specific kernel version: 624374a56419c2d6d428c862f32cc1b20519095d. > Note that if I do the same on 3.10.327-el7.x86_64 (RHEL7u2) the problem > does not occur. I have not yet tested on older mainline kernels, but plan > to do so shortly. Also note that in

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

On 17-02-07 11:45:06, Greg KH wrote: > On Tue, Feb 07, 2017 at 12:24:12PM +0200, Petko Manolov wrote: > > On 17-02-06 14:46:21, Johan Hovold wrote: > > > On Mon, Feb 06, 2017 at 02:32:23PM +0100, Johan Hovold wrote: > > > > On Mon, Feb 06, 2017 at 02:21:24PM +0100, Johan Hovold wrote: > > > > > On

Re: bridge: per vlan dst_metadata netlink support

On 07/02/17 12:25, Colin Ian King wrote: > Hi, > > Static analysis with CoverityScan on net/bridge/br_netlink_tunnel.c has > picked up and issue where tb[] is being referenced but contains > uninitialized data. > > 222 int br_parse_vlan_tunnel_info(struct nlattr *attr, > 223

Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set

On 07/02/17 11:56, Colin King wrote: > From: Colin Ian King > > The error check on err is redundant as it is being checked > previously each time it has been updated. Remove this redundant > check. > > Detected with CoverityScan, CID#140030("Logically dead code") > >

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On 17-02-07 14:01:02, Greg KH wrote: > On Tue, Feb 07, 2017 at 02:53:24PM +0200, Petko Manolov wrote: > > On 17-02-07 11:51:31, Greg KH wrote: > > > On Tue, Feb 07, 2017 at 12:34:52PM +0200, Petko Manolov wrote: > > > > On 17-02-06 16:25:20, Ben Hutchings wrote: > > > > > On Mon, Feb 06, 2017 at

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On 17-02-06 16:25:20, Ben Hutchings wrote: > On Mon, Feb 06, 2017 at 04:09:18PM +, David Laight wrote: > > From: Ben Hutchings > [...] > > > + ret = usb_control_msg(dev->udev, usb_rcvctrlpipe(dev->udev, 0), > > > + RTL8150_REQ_GET_REGS, RTL8150_REQT_READ, > > > +

[PATCH][net-next] net: bridge: remove redundant check to see if err is set

From: Colin Ian King The error check on err is redundant as it is being checked previously each time it has been updated. Remove this redundant check. Detected with CoverityScan, CID#140030("Logically dead code") Signed-off-by: Colin Ian King

Re: net/sctp: GPF in sctp_addr_id2transport

On Tue, Feb 07, 2017 at 10:42:38AM +0100, Dmitry Vyukov wrote: > Hello, > > The following program triggers GPF in sctp_addr_id2transport: > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #include > #include > #include > #include > #include > > int main()

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On Tue, Feb 07, 2017 at 11:56:51AM +, David Laight wrote: > From: Greg KH > > Sent: 07 February 2017 10:52 > > To: Petko Manolov > > Cc: Ben Hutchings; David Laight; netdev@vger.kernel.org; > > linux-...@vger.kernel.org > > Subject: Re: [PATCH net 2/4] rtl8150: Use heap buffers for all

[patch net-next] net: dsa: bcm_sf2: cleanup bcm_sf2_cfp_rule_get() a little

This patch doesn't affect how the code works. My static checker complains that the mask and shift doesn't make sense because 0xff << 16 goes beyond the end of 32 bits. It should be 0x instead but the existing code won't cause runtime bugs. Also the casting here is not needed and not

RE: [PATCH net-next 4/4] net: dsa: Do not clobber PHY link outside of state machine

From: Andrew Lunn > Sent: 07 February 2017 00:12 > On Mon, Feb 06, 2017 at 03:55:23PM -0800, Florian Fainelli wrote: > > Calling phy_read_status() means that we may call into > > genphy_read_status() which in turn will use genphy_update_link() which > > can make changes to phydev->link outside of

Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set

..and one more thing, in net/bridge/br_netlink_tunnel.c, __get_num_vlan_tunnel_infos, are the args to vlan_tunnel_id_isrange() the wrong way around? I'm not 100% sure, but I'd thought I'd flag it up. if (v_start) { if ((v_end->vid - v->vid) > 0 &&

[PATCH 1/3] gfs2: Use rhashtable walk interface in glock_hash_walk

The function glock_hash_walk walks the rhashtable by hand. This is broken because if it catches the hash table in the middle of a rehash, then it will miss entries. This patch replaces the manual walk by using the rhashtable walk interface. Fixes: 88ffbf3e037e ("GFS2: Use resizable hash table

[PATCH 3/3] rhashtable: Add nested tables

This patch adds code that handles GFP_ATOMIC kmalloc failure on insertion. As we cannot use vmalloc, we solve it by making our hash table nested. That is, we allocate single pages at each level and reach our desired table size by nesting them. When a nested table is created, only a single page

[PATCH 2/3] tipc: Fix tipc_sk_reinit race conditions

There are two problems with the function tipc_sk_reinit. Firstly it's doing a manual walk over an rhashtable. This is broken as an rhashtable can be resized and if you manually walk over it during a resize then you may miss entries. Secondly it's missing memory barriers as previously the code

[PATCH 0/3] rhashtable: Handle table allocation failure during insertion

Hi: This series tackles the problem of table allocation failures during insertion. The issue is that we cannot vmalloc during insertion. This series deals with this by introducing nested tables. The first two patches removes manual hash table walks which cannot work on a nested table. The

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On 17-02-07 11:51:31, Greg KH wrote: > On Tue, Feb 07, 2017 at 12:34:52PM +0200, Petko Manolov wrote: > > On 17-02-06 16:25:20, Ben Hutchings wrote: > > > On Mon, Feb 06, 2017 at 04:09:18PM +, David Laight wrote: > > > > From: Ben Hutchings > > > [...] > > > > > + ret =

Re: [PATCH net] sctp: check af before verify address in sctp_addr_id2transport

On Tue, Feb 07, 2017 at 08:56:08PM +0800, Xin Long wrote: > Commit 6f29a1306131 ("sctp: sctp_addr_id2transport should verify the > addr before looking up assoc") invoked sctp_verify_addr to verify the > addr. > > But it didn't check af variable beforehand, once users pass an address > with family

RE: [PATCH iproute2 v5 2/4] ifstat: Add extended statistics to ifstat

> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, February 03, 2017 8:07 PM > To: Nogah Frankel > Cc: netdev@vger.kernel.org; ro...@cumulusnetworks.com; roszenr...@gmail.com; > jb...@redhat.com;

ANNOUNCE: Netdev 2.1 Location and Hotel

Two important announcements 1) We are pleased to announce a location for netdev 2.1: Le Westin Montréal 270 Rue St. Antoine Ouest, Montreal, QC H2Y 0A3, Canada Le Westin will also be the conference hotel. We have a speacial arrangement for all attendees to get speacial rates at the hotel. We

Re: [PATCH v3 3/3] net: phy: dp83867: Recover from "port mirroring" N/A MODE4

On Tue, Feb 07, 2017 at 06:20:24AM +0100, Lukasz Majewski wrote: > The DP83867 when not properly bootstrapped - especially with LED_0 pin - > can enter N/A MODE4 for "port mirroring" feature. > > To provide normal operation of the PHY, one needs not only to explicitly > disable the port mirroring

Re: [PATCH net] sctp: avoid BUG_ON on sctp_wait_for_sndbuf

On Tue, Feb 7, 2017 at 4:10 AM, Marcelo Ricardo Leitner wrote: > Alexander Popov reported that an application may trigger a BUG_ON in > sctp_wait_for_sndbuf if the socket tx buffer is full, a thread is > waiting on it to queue more data and meanwhile another thread

Re: [PATCH net-next 4/4] net: dsa: Do not clobber PHY link outside of state machine

> Related is that polling the phy status every second can be bad news for > system latency. > Typically it involves bit-bashing an interface with spin-delays to > meet the slow timings (with extra delays to allow for posted writes). > An alternative would be to do a very slow bit-bang on each

Re: [PATCH v3 2/3] net: phy: dp83867: Add lane swapping support in the DP83867 TI's PHY driver

On Tue, Feb 07, 2017 at 06:20:23AM +0100, Lukasz Majewski wrote: > This patch adds support for enabling or disabling the lane swapping (called > "port mirroring" in PHY's CFG4 register) feature of the DP83867 TI's PHY > device. > > One use case is when bootstrap configuration enables this feature

Re: [PATCH 3/3] rhashtable: Add nested tables

On Tue, Feb 07, 2017 at 02:17:28PM +0100, Florian Westphal wrote: > > Ok, but why? Because people expect the hash table insertion to succeed, even on softirq paths where you cannot vmalloc. > It seems to add a whole lot of complexity... > > What users can't handle the insert failure case until

Re: [PATCH v4 net] bpf: add bpf_sk_netns_id() helper

On 02/07/2017 03:02 AM, Alexei Starovoitov wrote: in cases where bpf programs are looking at sockets and packets that belong to different netns, it could be useful to get an id that uniquely identify a netns within the whole system. Therefore introduce 'u64 bpf_sk_netns_id(sk);' helper. It

Re: [PATCH] Revert "net: Remove state argument from skb_find_text()"

On Sat, Feb 04, 2017 at 09:48:30PM -0800, Igor Pylypiv wrote: > This reverts commit 059a2440fd3cf4ec57735db2c0a90401cde84fca. > > Textsearch state parameter should be passed by pointer because > its resulting value is needed for call to textsearch_next(). You're right this renders

[PATCH net] sctp: check af before verify address in sctp_addr_id2transport

Commit 6f29a1306131 ("sctp: sctp_addr_id2transport should verify the addr before looking up assoc") invoked sctp_verify_addr to verify the addr. But it didn't check af variable beforehand, once users pass an address with family = 0 through sockopt, sctp_get_af_specific will return NULL and NULL

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

On Tue, Feb 07, 2017 at 12:24:12PM +0200, Petko Manolov wrote: > On 17-02-06 14:46:21, Johan Hovold wrote: > > On Mon, Feb 06, 2017 at 02:32:23PM +0100, Johan Hovold wrote: > > > On Mon, Feb 06, 2017 at 02:21:24PM +0100, Johan Hovold wrote: > > > > On Mon, Feb 06, 2017 at 02:51:09PM +0200, Petko

[PATCH net-next] bridge: tunnel: fix attribute checks in br_parse_vlan_tunnel_info

These checks should go after the attributes have been parsed otherwise we're using tb uninitialized. Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") Reported-by: Colin Ian King Signed-off-by: Nikolay Aleksandrov ---

Re: net/sctp: GPF in sctp_addr_id2transport

On Tue, Feb 7, 2017 at 7:09 PM, Marcelo Ricardo Leitner wrote: > On Tue, Feb 07, 2017 at 10:42:38AM +0100, Dmitry Vyukov wrote: >> Hello, >> >> The following program triggers GPF in sctp_addr_id2transport: >> >> // autogenerated by syzkaller

RE: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

From: Greg KH > Sent: 07 February 2017 10:52 > To: Petko Manolov > Cc: Ben Hutchings; David Laight; netdev@vger.kernel.org; > linux-...@vger.kernel.org > Subject: Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access > > On Tue, Feb 07, 2017 at 12:34:52PM +0200, Petko Manolov

Re: [PATCH v3 2/3] net: phy: dp83867: Add lane swapping support in the DP83867 TI's PHY driver

On Tue, Feb 07, 2017 at 06:20:23AM +0100, Lukasz Majewski wrote: > This patch adds support for enabling or disabling the lane swapping (called > "port mirroring" in PHY's CFG4 register) feature of the DP83867 TI's PHY > device. > > One use case is when bootstrap configuration enables this feature

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On Tue, Feb 07, 2017 at 02:53:24PM +0200, Petko Manolov wrote: > On 17-02-07 11:51:31, Greg KH wrote: > > On Tue, Feb 07, 2017 at 12:34:52PM +0200, Petko Manolov wrote: > > > On 17-02-06 16:25:20, Ben Hutchings wrote: > > > > On Mon, Feb 06, 2017 at 04:09:18PM +, David Laight wrote: > > > > >

Re: [PATCH 3/3] rhashtable: Add nested tables

Herbert Xu wrote: > This patch adds code that handles GFP_ATOMIC kmalloc failure on > insertion. As we cannot use vmalloc, we solve it by making our > hash table nested. That is, we allocate single pages at each level > and reach our desired table size by nesting

Re: [PATCH net-next] bridge: tunnel: fix attribute checks in br_parse_vlan_tunnel_info

On 2/7/17, 3:46 AM, Nikolay Aleksandrov wrote: > These checks should go after the attributes have been parsed otherwise > we're using tb uninitialized. > > Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") > Reported-by: Colin Ian King >

Re: [PATCH v2 net-next] net: phy: Add LED mode driver for Microsemi

Hi Florian, Thank you for review comments. On Wed, Feb 01, 2017 at 10:04:08AM -0800, Florian Fainelli wrote: > EXTERNAL EMAIL > > > On 02/01/2017 04:53 AM, Raju Lakkaraju wrote: > > From: Raju Lakkaraju > > > > LED Mode: > > Microsemi PHY support 2 LEDs (LED[0]

[PATCH net-next/iproute v2 0/5] tc: bash-completion: Add features

The first 4 patches add support for autompletion of filter actions, thus allowing the following tab completions: $ tc filter add dev eth0 u32 [...] action bpf gactmirred sample $ tc filter add dev eth0 u32 [...] action sample action group ratetrunc $ tc filter add dev eth0 u32

[PATCH ipsec-next 6/6] xfrm: policy: make policy backend const

Signed-off-by: Florian Westphal --- net/ipv4/xfrm4_policy.c | 2 +- net/ipv6/xfrm6_policy.c | 2 +- net/xfrm/xfrm_policy.c | 18 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/net/ipv4/xfrm4_policy.c b/net/ipv4/xfrm4_policy.c index

[PATCH ipsec-next 3/6] xfrm: policy: remove garbage_collect callback

Just call xfrm_garbage_collect_deferred() directly. This gets rid of a write to afinfo in register/unregister and allows to constify afinfo later on. Signed-off-by: Florian Westphal --- include/net/xfrm.h | 2 +- net/ipv4/xfrm4_policy.c | 2 +- net/ipv6/xfrm6_policy.c | 2

[PATCH ipsec-next 4/6] xfrm: policy: remove family field

Only needed it to register the policy backend at init time. Signed-off-by: Florian Westphal --- include/net/xfrm.h | 5 ++--- net/ipv4/xfrm4_policy.c | 5 + net/ipv6/xfrm6_policy.c | 5 + net/xfrm/xfrm_policy.c | 34 +- 4 files

Re: fs, net: deadlock between bind/splice on af_unix

On Sun, Feb 05, 2017 at 11:22:12PM -0800, Cong Wang wrote: > On Tue, Jan 31, 2017 at 10:14 AM, Mateusz Guzik wrote: > > On Mon, Jan 30, 2017 at 10:44:03PM -0800, Cong Wang wrote: > >> Mind being more specific? > > > > Consider 2 threads which bind the same socket, but with

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

On 02/07/2017 01:14 AM, Valo, Kalle wrote: Adrian Chadd writes: Removing this method makes the diff to FreeBSD larger, as "vif" in FreeBSD is a different pointer. (Yes, I have ath10k on freebsd working and I'd like to find a way to reduce the diff moving forward.) I

[PATCH v2] xen-netfront: Improve error handling during initialization

This fixes a crash when running out of grant refs when creating many queues across many netdevs. * If creating queues fails (i.e. there are no grant refs available), call xenbus_dev_fatal() to ensure that the xenbus device is set to the closed state. * If no queues are created, don't call

[PATCH net-next/iproute v2 3/5] tc: bash-completion: Make the *_KIND variables global

The QDISC_KIND, FILTER_KIND, ACTION_KIND variables may be used by other routines, thus make them global variables. Signed-off-by: Yotam Gigi --- bash-completion/tc | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/bash-completion/tc

RE: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

From: Petko Manolov > Sent: 07 February 2017 13:21 ... > > > Would you consider what David proposed (usb_control_msg_with_malloc()) > > > for 4.11, > > > for example? I for one will use something like that in all my drivers. > > > > Sure, but you might want to make it a bit smaller of a function

Re: [net-next PATCH v2 0/5] XDP adjust head support for virtio

From: "Michael S. Tsirkin" Date: Tue, 7 Feb 2017 06:15:13 +0200 > On Thu, Feb 02, 2017 at 07:14:05PM -0800, John Fastabend wrote: >> This series adds adjust head support for virtio. The following is my >> test setup. I use qemu + virtio as follows, >> >>

Re: [PATCH net 0/4] Fix on-stack USB buffers

From: Ben Hutchings Date: Sat, 4 Feb 2017 16:54:51 + > Allocating USB buffers on the stack is not portable, and no longer > works on x86_64 (with VMAP_STACK enabled as per default). This > series fixes all the instances I could find where USB networking > drivers do

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On Tue, Feb 07, 2017 at 12:34:52PM +0200, Petko Manolov wrote: > On 17-02-06 16:25:20, Ben Hutchings wrote: > > On Mon, Feb 06, 2017 at 04:09:18PM +, David Laight wrote: > > > From: Ben Hutchings > > [...] > > > > + ret = usb_control_msg(dev->udev, usb_rcvctrlpipe(dev->udev, 0), > > > >

RE: bridge: per vlan dst_metadata netlink support

Hi, Static analysis with CoverityScan on net/bridge/br_netlink_tunnel.c has picked up and issue where tb[] is being referenced but contains uninitialized data. 222 int br_parse_vlan_tunnel_info(struct nlattr *attr, 223 struct vtunnel_info *tinfo) 224 { 1.

Re: [PATCH v3 1/3] Documentation: devicetree: Add PHY no lane swap binding

On Tue, Feb 07, 2017 at 06:21:34AM +0100, Lukasz Majewski wrote: > Add the documentation to avoid PHY lane swapping. This is a boolean > entry to notify the phy device drivers that the TX/RX lanes NO need > to be swapped. > The use case for this binding mostly happens after wrong HW >

Re: [PATCH v2 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

> > > +- vsc8531,led-1-mode : LED mode. Specify how the LED[1] should behave. > > > + Allowed values are define in > > > + int rc; > > > + > > > + if (!of_node) > > > + return -ENODEV; > > > + > > > + rc = of_property_read_u8(of_node, led, _mode); > >

[PATCH net-next] sctp: drop __packed from almost all SCTP structures

__packed is considered harmful as it potentially generates code that doesn't perform well and its usage should be avoided as much as possible. This patch drops __packed from all SCTP structures except one, which is sctp_signed_cookie. In there it's required, as per changelog on commit

[PATCH ipsec-next] xfrm: input: constify xfrm_input_afinfo

Nothing writes to these structures (the module owner was not used). While at it, size xfrm_input_afinfo[] by the highest existing xfrm family (INET6), not AF_MAX. Signed-off-by: Florian Westphal --- include/net/xfrm.h| 5 ++--- net/ipv4/xfrm4_protocol.c | 3 +--

[PATCH ipsec-next 1/6] xfrm: policy: xfrm_get_tos cannot fail

The comment makes it look like get_tos() is used to validate something, but it turns out the comment was about xfrm_find_bundle() which got removed years ago. xfrm_get_tos will return either the tos (ipv4) or 0 (ipv6). Signed-off-by: Florian Westphal --- net/xfrm/xfrm_policy.c

[PATCH ipsec-next 0/6] xfrm: policy: make policy backend const

Hi Steffen, This series removes all places that need to write to the afinfo policy backends. This then allows us to make the structures const.

[PATCH ipsec-next 2/6] xfrm: policy: xfrm_policy_unregister_afinfo can return void

Nothing checks the return value. Also, the errors returned on unregister are impossible (we only support INET and INET6, so no way xfrm_policy_afinfo[afinfo->family] can be anything other than 'afinfo' itself). Signed-off-by: Florian Westphal --- include/net/xfrm.h | 2 +-

Extending socket timestamping API for NTP

I'd like to propose some changes and new options for the timestamping interface that I think would be useful for NTP implementations and maybe also other applications. Before I or someone else tries to implement them, do you think they would actually make sense and fit well in the current code?

[PATCH ipsec-next 5/6] xfrm: policy: remove xfrm_policy_put_afinfo

Alternative is to keep it an make the (unused) afinfo arg const to avoid the compiler warnings once the afinfo structs get constified. Signed-off-by: Florian Westphal --- net/xfrm/xfrm_policy.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff

Re: mlxsw: spectrum: Introduce ACL core with simple TCAM implementation

Hi Jiri, mlxsw_sp_acl_tcam_chunk_create has an issue picked up by static analysis: 816struct mlxsw_sp_acl_tcam_chunk *chunk; 817int err; 818 CID 1400029 (#1 of 1): Operands don't affect result (CONSTANT_EXPRESSION_RESULT)result_independent_of_operands: priority ==

[patch net-next] spectrum: acl_tcam: Fix catchall prio value

From: Jiri Pirko This fixes an issue reported by smatch: mlxsw_sp_acl_tcam_chunk_create() warn: impossible condition '(priority == (-1)) => (0-u32max == u64max)' Reported-by: Or Gerlitz Reported-by: Ido Schimmel Reported-by: Dan

[net-next PATCH 2/4] doc/bpf: document interacting with eBPF maps

Describe what eBPF maps are, how to create them, and how to interact with them. Thanks to Quentin Monnet for improving this document by fixing many typos and early review. Signed-off-by: Jesper Dangaard Brouer --- Documentation/bpf/ebpf_maps.rst |

[net-next PATCH 3/4] doc/bpf: describes the different types of eBPF maps available

The purpose is to help choose the right map type based on the individual use-case. To start with, only BPF_MAP_TYPE_ARRAY is described. It is the plan that all types should have descriptions here. Signed-off-by: Jesper Dangaard Brouer --- Documentation/bpf/ebpf_maps.rst

[net-next PATCH 4/4] doc/bpf: describe BCC the BPF Compiler Collection

It is worth mentioning BCC (BPF Compiler Collection) in-order to direct developers into that community. Reviewed-by: Alexander Alemayhu Signed-off-by: Jesper Dangaard Brouer --- Documentation/bpf/bcc_tool_chain.rst | 37

[net-next PATCH 1/4] doc/bpf: start eBPF documentation tree bpf/

The learning curve for eBPF programs is hard. The purpose of this documentation (subtree) is to make it easier for developers to get started using and writing eBPF programs. Including bpf/index under section User-oriented documentation. Thanks to Quentin Monnet for

[net-next PATCH 0/4] Documenting eBPF - extended Berkeley Packet Filter

Question: What kernel tree should this go into??? If going through Jonathan Corbet, will it appear sooner here??? https://www.kernel.org/doc/html/latest/ If it will not appear sooner that way, then it's likely best to keep it in sync with the tree that takes eBPF code changes. This marks the

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On 17-02-07 14:14:30, David Laight wrote: > From: Petko Manolov > > Sent: 07 February 2017 13:21 > ... > > > > Would you consider what David proposed (usb_control_msg_with_malloc()) > > > > for 4.11, > > > > for example? I for one will use something like that in all my drivers. > > > > > > Sure,

[PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

From: Raju Lakkaraju LED Mode: Microsemi PHY support 2 LEDs (LED[0] and LED[1]) to display different status information that can be selected by setting LED mode. LED Mode parameter (vsc8531, led-0-mode) and (vsc8531, led-1-mode) get from Device Tree.

[PATCH net-next/iproute v2 2/5] tc: bash-completion: Prepare action autocomplete to support several actions

The action autocomplete routine (_tc_action_options) currently does not support several actions statements in one tc command line as it uses the _tc_once_attr and _tc_one_from_list. For example, in that case: $ tc filter add dev eth0 handle : u32 [...] \ action sample group 5

[PATCH net-next/iproute v2 4/5] tc: bash-completion: Add support for filter actions

Previously, the autocomplete routine did not complete actions after a filter keyword, for example: $ tc filter add dev eth0 u32 [...] action did not suggest the actions list, and: $ tc filter add dev eth0 u32 [...] action mirred did not suggest the specific mirred parameters. Add the support

[PATCH net-next/iproute v2 1/5] tc: bash-completion: Add the _from variant to _tc_one* funcs

The _tc_one_of_list and _tc_once_attr functions simplfy the bash completion task by validating each attr exist only once on the command line. For example, for the command line: $ a b c d e and the call to _tc_once_attr with "a f g", the function will suggest "f g" as "a" existed in the command

[PATCH net-next/iproute v2 5/5] tc: bash-completion: Add support for matchall

Add support for the matchall classifier and its parameters. Signed-off-by: Yotam Gigi --- bash-completion/tc | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/bash-completion/tc b/bash-completion/tc index e4c6804..80d1297 100644 ---

RE: [patch net-next] spectrum: acl_tcam: Fix catchall prio value

From: Jiri Pirko > Sent: 07 February 2017 14:27 > From: Jiri Pirko > > This fixes an issue reported by smatch: > mlxsw_sp_acl_tcam_chunk_create() warn: impossible condition '(priority == > (-1)) => (0-u32max == > u64max)' ... > diff --git

Re: net/icmp: null-ptr-deref in ping_v4_push_pending_frames

On Mon, Feb 6, 2017 at 11:50 PM, Cong Wang wrote: > On Mon, Feb 6, 2017 at 11:39 AM, Andrey Konovalov > wrote: >> Hi, >> >> I've got the following error report while running the syzkaller fuzzer. >> >> The null-ptr-deref is caused by sendto() on

  1   2   3   4   >