Re: [RFC v3 02/11] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) interface

2017-02-07 Thread Vishwanathapura, Niranjana
On Tue, Feb 07, 2017 at 02:19:01PM -0700, Jason Gunthorpe wrote: On Tue, Feb 07, 2017 at 12:23:01PM -0800, Vishwanathapura, Niranjana wrote: Add rdma netdev interface to ib device structure allowing rdma netdev devices to be allocated by ib clients. Define HFI VNIC interface between hardware

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Bart Van Assche
On Tue, 2017-02-07 at 21:44 +, Hefty, Sean wrote: > This is Ethernet - not IP - encapsulation over a non-InfiniBand > device/protocol. That's more than clear from the cover letter. In my opinion the cover letter should explain why it is considered useful to have such a driver upstream and

Re: [PATCH iproute2] ip route: Make name of protocol 0 consistent

2017-02-07 Thread David Ahern
On 2/7/17 2:40 PM, Stephen Hemminger wrote: >> Reading the file changes the string in rtnl_rtprot_tab for >> RTPROT_UNSPEC. Both string values -- "none" and "unspec" come from >> iproute2, so my point is that string is inconsistent within iproute2. > > Why not change the value in the table

netvsc merge conflicts...

2017-02-07 Thread David Miller
Stephen, I just did a merge of net into net-next and had to resolve a merge conflict in the netvsc driver. The problem was that in 'net' the hyperv bug fix that added the calls to "init_cache_read_index()" in netvsc_channel_cb() collided with your RX path cleanups. Please double check my work

[PATCH net-next v3 00/11] Improve BPF selftests and use the library (net-next tree)

2017-02-07 Thread Mickaël Salaün
This series brings some fixes to selftests, add the ability to test unprivileged BPF programs as root and replace bpf_sys.h with calls to the BPF library. This is intended for the net-next tree and apply on 76e0e70e6452 ("liquidio: do not dereference pointer if it's NULL"). Changes since v2: *

[PATCH net-next v3 07/11] bpf: Use bpf_map_delete_elem() from the library

2017-02-07 Thread Mickaël Salaün
Replace bpf_map_delete() with bpf_map_delete_elem() calls. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/lib/bpf/bpf.c| 5 ++---

[PATCH net-next v3 02/11] bpf: Change the include directory for selftest

2017-02-07 Thread Mickaël Salaün
Use the tools include directory instead of the installed one to allow builds from other kernels. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Daniel Borkmann Cc: David S. Miller

[PATCH net-next v3 01/11] tools: Sync {,tools/}include/uapi/linux/bpf.h

2017-02-07 Thread Mickaël Salaün
The tools version of this header is out of date; update it to the latest version from kernel header. Synchronize with the following commits: * b95a5c4db09b ("bpf: add a longest prefix match trie map implementation") * a5e8c07059d0 ("bpf: add bpf_probe_read_str helper") * d1b662adcdb8 ("bpf: allow

[PATCH net-next v3 04/11] bpf: Use bpf_load_program() from the library

2017-02-07 Thread Mickaël Salaün
Replace bpf_prog_load() with bpf_load_program() calls. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/lib/bpf/bpf.c | 9 -

[PATCH net-next v3 10/11] bpf: Remove bpf_sys.h from selftests

2017-02-07 Thread Mickaël Salaün
Add require dependency headers. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/lib/bpf/bpf.c | 6 ++ tools/testing/selftests/bpf/bpf_sys.h

[PATCH net-next v3 05/11] bpf: Use bpf_map_update_elem() from the library

2017-02-07 Thread Mickaël Salaün
Replace bpf_map_update() with bpf_map_update_elem() calls. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/lib/bpf/bpf.c| 5 +--

[PATCH net-next v3 03/11] bpf: Always test unprivileged programs

2017-02-07 Thread Mickaël Salaün
If selftests are run as root, then execute the unprivileged checks as well. This switch from 243 to 368 tests. The test numbers are suffixed with "/u" when executed as unprivileged or with "/p" when executed as privileged. The geteuid() check is replaced with a capability check. Handling

[PATCH net-next v3 08/11] bpf: Use bpf_map_get_next_key() from the library

2017-02-07 Thread Mickaël Salaün
Replace bpf_map_next_key() with bpf_map_get_next_key() calls. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/lib/bpf/bpf.c| 5 ++---

[PATCH net-next v3 06/11] bpf: Use bpf_map_lookup_elem() from the library

2017-02-07 Thread Mickaël Salaün
Replace bpf_map_lookup() with bpf_map_lookup_elem() calls. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/lib/bpf/bpf.c| 5 ++---

[PATCH net-next v3 09/11] bpf: Use bpf_create_map() from the library

2017-02-07 Thread Mickaël Salaün
Replace bpf_map_create() with bpf_create_map() calls. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/testing/selftests/bpf/bpf_sys.h | 15 ---

[PATCH net-next v3 11/11] bpf: Add test_tag to .gitignore

2017-02-07 Thread Mickaël Salaün
Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Shuah Khan --- tools/testing/selftests/bpf/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/bpf/.gitignore

RE: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Hefty, Sean
> This may have been stated before, but what is missing from this > description > is an explanation of why accepting an Ethernet over RDMA driver in the > upstream kernel is considered useful. We already have an IPoIB driver, > so > why to add another driver to the kernel tree for communicating IP

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Vishwanathapura, Niranjana
On Tue, Feb 07, 2017 at 01:00:05PM -0800, Hefty, Sean wrote: I didn't read patches yet, and prefer to ask it in advance. Does this new ULP work with all drivers/infiniband/hw/* devices as it is expected from ULP? Like the way ipoib or srp work with all hw devices? What is the real point of

Re: [PATCH iproute2] ip route: Make name of protocol 0 consistent

2017-02-07 Thread Stephen Hemminger
On Mon, 6 Feb 2017 16:03:35 -0700 David Ahern wrote: > On 2/6/17 3:01 PM, Stephen Hemminger wrote: > > On Thu, 2 Feb 2017 09:22:06 -0800 > > David Ahern wrote: > > > >> iproute2 can inconsistently show the name of protocol 0 if a route

Re: [PATCH net-next 5/7] openvswitch: Add original direction conntrack tuple to sw_flow_key.

2017-02-07 Thread Joe Stringer
On 6 February 2017 at 23:15, Joe Stringer wrote: > On 2 February 2017 at 17:10, Jarno Rajahalme wrote: >> @@ -79,9 +80,17 @@ static inline void ovs_ct_fill_key(const struct sk_buff >> *skb, >> key->ct.zone = 0; >> key->ct.mark = 0; >>

Re: [net-next PATCH 0/4] Documenting eBPF - extended Berkeley Packet Filter

2017-02-07 Thread Jonathan Corbet
On Tue, 7 Feb 2017 21:51:49 +0100 Jesper Dangaard Brouer wrote: > I sounds like Daniel (see other email) have bigger plans for what > Documentation/BPF/ should contain. E.g. consolidating > Documentation/networking/filter.txt which covers the cBPF/eBPF internals. > If that is

Re: [PATCH net 2/2] packet: round up linear to header len

2017-02-07 Thread Eric Dumazet
On Tue, 2017-02-07 at 15:57 -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > Link layer protocols may unconditionally pull headers, as Ethernet > does in eth_type_trans. Ensure that the entire link layer header > always lies in the skb linear segment. tpacket_snd

Re: [PATCH net-next 1/7] openvswitch: Use inverted tuple in ovs_ct_find_existing() if NATted.

2017-02-07 Thread Jarno Rajahalme
> On Feb 7, 2017, at 9:14 AM, Pravin Shelar wrote: > > On Mon, Feb 6, 2017 at 9:15 AM, David Miller wrote: >> From: Pravin Shelar >> Date: Mon, 6 Feb 2017 09:06:29 -0800 >> >>> On Sun, Feb 5, 2017 at 2:28 PM, David Miller

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Bart Van Assche
On Tue, 2017-02-07 at 12:22 -0800, Vishwanathapura, Niranjana wrote: > Intel Omni-Path Host Fabric Interface (HFI) Virtual Network Interface > Controller (VNIC) feature supports Ethernet functionality over Omni-Path > fabric by encapsulating the Ethernet packets between HFI nodes. This may have

Re: [PATCH net 1/2] net: introduce device min_header_len

2017-02-07 Thread Sowmini Varadhan
On (02/07/17 15:57), Willem de Bruijn wrote: > > From: Willem de Bruijn > > The stack must not pass packets to device drivers that are shorter > than the minimum link layer header length. Acked-by: Sowmini Varadhan

Re: [net-next PATCH 0/4] Documenting eBPF - extended Berkeley Packet Filter

2017-02-07 Thread Jesper Dangaard Brouer
On Tue, 07 Feb 2017 17:43:38 +0100 Daniel Borkmann wrote: > Hi Jesper, > > On 02/07/2017 03:30 PM, Jesper Dangaard Brouer wrote: > > Question: What kernel tree should this go into??? > > > > If going through Jonathan Corbet, will it appear sooner here??? > >

Re: [RFC v3 02/11] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) interface

2017-02-07 Thread Jason Gunthorpe
On Tue, Feb 07, 2017 at 12:23:01PM -0800, Vishwanathapura, Niranjana wrote: > Add rdma netdev interface to ib device structure allowing rdma netdev > devices to be allocated by ib clients. > Define HFI VNIC interface between hardware independent VNIC > functionality and the hardware dependent VNIC

Re: [PATCH net 1/2] net: introduce device min_header_len

2017-02-07 Thread Eric Dumazet
On Tue, 2017-02-07 at 15:57 -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > The stack must not pass packets to device drivers that are shorter > than the minimum link layer header length. > > Previously, packet sockets would drop packets smaller than or equal >

RE: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Hefty, Sean
> I didn't read patches yet, and prefer to ask it in advance. Does this > new ULP work with all > drivers/infiniband/hw/* devices as it is expected from ULP? Like the way ipoib or srp work with all hw devices? What is the real point of this question?

[PATCH v3 3/5] samples/bpf: Ignore already processed ELF sections

2017-02-07 Thread Mickaël Salaün
Add a missing check for the map fixup loop. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Daniel Borkmann --- samples/bpf/bpf_load.c | 2 ++ 1 file changed, 2 insertions(+) diff

[Patch net] ping: fix a null pointer dereference

2017-02-07 Thread Cong Wang
Andrey reported a kernel crash: general protection fault: [#1] SMP KASAN Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 2 PID: 3880 Comm: syz-executor1 Not tainted 4.10.0-rc6+ #124 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs

[Patch net] kcm: fix 0-length case for kcm_sendmsg()

2017-02-07 Thread Cong Wang
Dmitry reported a kernel warning: WARNING: CPU: 3 PID: 2936 at net/kcm/kcmsock.c:627 kcm_write_msgs+0x12e3/0x1b90 net/kcm/kcmsock.c:627 CPU: 3 PID: 2936 Comm: a.out Not tainted 4.10.0-rc6+ #209 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 Call Trace:

[PATCH v3 0/5] Miscellaneous fixes for BPF (perf tree)

2017-02-07 Thread Mickaël Salaün
This series brings some fixes and small improvements to the BPF library and samples. This is intended for the perf tree and apply on e06094ab6755 ("Merge remote-tracking branch 'tip/perf/urgent' into perf/core"). Changes since v2: * add this cover letter Changes since v1: * exclude patches not

[PATCH v3 5/5] samples/bpf: Add missing header

2017-02-07 Thread Mickaël Salaün
Include unistd.h to define __NR_getuid and __NR_getsid. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Daniel Borkmann Cc: David S. Miller ---

[PATCH v3 2/5] bpf: Simplify bpf_load_program() error handling in the library

2017-02-07 Thread Mickaël Salaün
Do not call a second time bpf(2) when a program load failed. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Daniel Borkmann Cc: Wang Nan --- tools/lib/bpf/bpf.c

[PATCH net 0/2] Fixes for header length truncation

2017-02-07 Thread Willem de Bruijn
From: Willem de Bruijn Packets should not enter the stack with truncated link layer headers and link layer headers should always be stored in the skb linear segment. Patch 1 ensures the first for PF_PACKET sockets Patch 2 ensures the second for PF_PACKET GSO sockets without

[PATCH v3 4/5] samples/bpf: Reset global variables

2017-02-07 Thread Mickaël Salaün
Before loading a new ELF, clean previous kernel version, license and processed sections. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Daniel Borkmann Cc: David S. Miller

[PATCH v3 1/5] bpf: Add missing header to the library

2017-02-07 Thread Mickaël Salaün
Include stddef.h to define size_t. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Daniel Borkmann Cc: Wang Nan --- tools/lib/bpf/bpf.h | 1 + 1 file changed, 1

[PATCH net 2/2] packet: round up linear to header len

2017-02-07 Thread Willem de Bruijn
From: Willem de Bruijn Link layer protocols may unconditionally pull headers, as Ethernet does in eth_type_trans. Ensure that the entire link layer header always lies in the skb linear segment. tpacket_snd has such a check. Extend this to packet_snd. Variable length link

[PATCH net 1/2] net: introduce device min_header_len

2017-02-07 Thread Willem de Bruijn
From: Willem de Bruijn The stack must not pass packets to device drivers that are shorter than the minimum link layer header length. Previously, packet sockets would drop packets smaller than or equal to dev->hard_header_len, but this has false positives. Zero length payload

Re: [PATCH RFC net-next] packet: always ensure that we pass hard_header_len bytes in skb_headlen() to the driver

2017-02-07 Thread Willem de Bruijn
On Mon, Jan 30, 2017 at 8:41 AM, David Miller wrote: > From: Sowmini Varadhan > Date: Mon, 30 Jan 2017 11:26:03 -0500 > >> On (01/27/17 19:19), Willem de Bruijn wrote: >>> > other than ax25, are there variable length header protocols out there

Re: [net-next PATCH 0/4] Documenting eBPF - extended Berkeley Packet Filter

2017-02-07 Thread Jesper Dangaard Brouer
On Tue, 7 Feb 2017 09:46:08 -0700 Jonathan Corbet wrote: > On Tue, 7 Feb 2017 17:09:08 +0100 > Jesper Dangaard Brouer wrote: > > > > > Question: What kernel tree should this go into??? > > > > > > > > If going through Jonathan Corbet, will it appear sooner

[PATCH net-next] liquidio: do not dereference pointer if it's NULL

2017-02-07 Thread Felix Manlunas
Fix smatch errors by not dereferencing iq pointer if it's NULL. See http://marc.info/?l=kernel-janitors=148637299004834=2 Reported-by: Dan Carpenter Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 2 +-

Re: [PATCH net-next v2 1/8] bpf: Use bpf_load_program() from the library

2017-02-07 Thread Mickaël Salaün
Right, it was a batch of miscellaneous patches at first but I split them in three series. I'm going to resend this patches in two v3 series (with cover letters): one for each tree (net-next and perf). Thanks, Mickaël On 07/02/2017 19:35, David Miller wrote: > > Please post your patch series(s)

Re: [PATCH net-next] liquidio: do not dereference pointer if it's NULL

2017-02-07 Thread David Miller
From: Felix Manlunas Date: Tue, 7 Feb 2017 12:10:58 -0800 > Fix smatch errors by not dereferencing iq pointer if it's NULL. > > See http://marc.info/?l=kernel-janitors=148637299004834=2 > > Reported-by: Dan Carpenter > Signed-off-by: Felix

Re: Extending socket timestamping API for NTP

2017-02-07 Thread sdncurious
On Tue, Feb 7, 2017 at 6:01 AM, Miroslav Lichvar wrote: > 5) new SO_TIMESTAMPING options to get transposed RX timestamps > >PTP uses preamble RX timestamps, but NTP works with trailer RX >timestamps. This means NTP implementations currently need to >transpose HW

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Leon Romanovsky
On Tue, Feb 07, 2017 at 12:22:59PM -0800, Vishwanathapura, Niranjana wrote: > ChangeLog: > = > v2 => v3: > a) Introduce and adopt generic RDMA netdev interface including, > - having bottom hfi1 driver directly interfacing with netstack. > - optimizing interface between hfi_vnic

[PATCH v2 0/6] Updates for Marvell Switch SoCs

2017-02-07 Thread Chris Packham
Shortly after I posted my last series I got access to a more recent Marvell SDK which had some device tree support for the switch SoCs I'd been wanting. It was still based on an older kernel but it was a huge improvement over what came before. Patch 1/6 is a typo I noticed after my initial series

[PATCH v2 2/6] ARM: dts: armada-xp-98dx3236: combine dfx server nodes

2017-02-07 Thread Chris Packham
Rather than having a separate node for the dfx server add a reg property to the parent node. This give somes compatibility with the Marvell supplied SDK. Signed-off-by: Chris Packham --- Notes: Changes in v2: - none

[RFC v3 04/11] IB/hfi-vnic: VNIC Ethernet Management (EM) structure definitions

2017-02-07 Thread Vishwanathapura, Niranjana
Define VNIC EM MAD structures and the associated macros. These structures are used for information exchange between VNIC EM agent (EMA) on the HFI host and the Ethernet manager. These include the virtual ethernet switch (vesw) port information, vesw port mac table, summay and error counters, vesw

[RFC v3 03/11] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) netdev

2017-02-07 Thread Vishwanathapura, Niranjana
HFI VNIC netdev function supports Ethernet functionality over Omni-Path fabric by encapsulating Ethernet packets inside Omni-Path packet header. It allocates a rdma netdev device and interfaces with the network stack to provide standard Ethernet network interfaces. It overrides HFI device's netdev

[RFC v3 10/11] IB/hfi1: Virtual Network Interface Controller (VNIC) HW support

2017-02-07 Thread Vishwanathapura, Niranjana
HFI1 HW specific support for VNIC functionality. Dynamically allocate a set of contexts for VNIC when the first vnic port is instantiated. Allocate VNIC contexts from user contexts pool and return them back to the same pool while freeing up. Set aside enough MSI-X interrupts for VNIC contexts and

[RFC v3 11/11] IB/hfi1: VNIC SDMA support

2017-02-07 Thread Vishwanathapura, Niranjana
HFI1 VNIC SDMA support enables transmission of VNIC packets over SDMA. Map VNIC queues to SDMA engines and support halting and wakeup of the VNIC queues. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny Signed-off-by: Niranjana

[RFC v3 09/11] IB/hfi1: HFI_VNIC RDMA netdev support

2017-02-07 Thread Vishwanathapura, Niranjana
Add support to create and free HFI_VNIC rdma netdev devices. Implement netstack interface functionality including xmit_skb, receive side NAPI etc. Also implement rdma netdev control functions. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny

[RFC v3 07/11] IB/hfi-vnic: VNIC Ethernet Management Agent (VEMA) interface

2017-02-07 Thread Vishwanathapura, Niranjana
HFI VNIC EMA interface functions are the management interfaces to the HFI VNIC netdev. Add support to add and remove VNIC ports. Implement the required GET/SET management interface functions and processing of new management information. Add support to send trap notifications upon various events

[RFC v3 06/11] IB/hfi-vnic: VNIC MAC table support

2017-02-07 Thread Vishwanathapura, Niranjana
HFI VNIC MAC table contains the MAC address to DLID mappings provided by the Ethernet manager. During transmission, the MAC table provides the MAC address to DLID translation. Implement MAC table using simple hash list. Also provide support to update/query the MAC table by Ethernet manager.

[RFC v3 05/11] IB/hfi-vnic: VNIC statistics support

2017-02-07 Thread Vishwanathapura, Niranjana
HFI VNIC driver statistics support maintains various counters including standard netdev counters and the Ethernet manager defined counters. Add the Ethtool hook to read the counters. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny

[RFC v3 08/11] IB/hfi-vnic: VNIC Ethernet Management Agent (VEMA) function

2017-02-07 Thread Vishwanathapura, Niranjana
HFI VEMA function interfaces with the Infiniband MAD stack to exchange the management information packets with the Ethernet Manager (EM). It interfaces with the HFI VNIC netdev function to SET/GET the management information. The information exchanged with the EM includes class port details,

[RFC v3 02/11] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) interface

2017-02-07 Thread Vishwanathapura, Niranjana
Add rdma netdev interface to ib device structure allowing rdma netdev devices to be allocated by ib clients. Define HFI VNIC interface between hardware independent VNIC functionality and the hardware dependent VNIC functionality. Reviewed-by: Dennis Dalessandro

[RFC v3 01/11] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) documentation

2017-02-07 Thread Vishwanathapura, Niranjana
Add HFI VNIC design document explaining the VNIC architecture and the driver design. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny Signed-off-by: Niranjana Vishwanathapura ---

[RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Vishwanathapura, Niranjana
ChangeLog: = v2 => v3: a) Introduce and adopt generic RDMA netdev interface including, - having bottom hfi1 driver directly interfacing with netstack. - optimizing interface between hfi_vnic and hfi1 driver. b) Remove bitfield usage. c) Move hfi_vnic driver to

Re: [PATCH net-next] sctp: avoid list_del_init if it's freeing the memory right away

2017-02-07 Thread David Miller
From: Marcelo Ricardo Leitner Date: Tue, 7 Feb 2017 17:45:09 -0200 > On Tue, Feb 07, 2017 at 02:21:21PM -0500, David Miller wrote: >> From: Marcelo Ricardo Leitner >> Date: Tue, 7 Feb 2017 17:03:21 -0200 >> >> > There is no reason to use

ATENCIÓN;

2017-02-07 Thread administrador
ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de

Re: [PATCH net-next/iproute v2 0/5] tc: bash-completion: Add features

2017-02-07 Thread Stephen Hemminger
On Tue, 7 Feb 2017 15:50:47 +0200 Yotam Gigi wrote: > The first 4 patches add support for autompletion of filter actions, thus > allowing the following tab completions: > > $ tc filter add dev eth0 u32 [...] action > bpf gactmirred sample > > $ tc filter add dev

[GIT] Networking

2017-02-07 Thread David Miller
1) Load correct firmware in rtl8192ce wireless driver, from Jurij Smakov. 2) Fix leak of tx_ring and tx_cq due to overwriting in mlx4 driver, from Martin KaFai Lau. 3) Need to reference count PHY driver module when it is attached, from Mao Wenan. 4) Don't do zero length vzalloc() in

[PATCH] net: qcom/emac: fix semicolon.cocci warnings

2017-02-07 Thread kbuild test robot
drivers/net/ethernet/qualcomm/emac/emac-ethtool.c:155:49-50: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Timur Tabi Signed-off-by: Fengguang Wu --- emac-ethtool.c |2 +- 1 file

[net-next:master 376/390] drivers/net/ethernet/qualcomm/emac/emac-ethtool.c:155:49-50: Unneeded semicolon

2017-02-07 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: ca6d4480f87db9d9470d3d7bbe445953fa105e57 commit: b44700e975848a9a569a509244672ff886ec99b3 [376/390] net: qcom/emac: add ethool support for setting pause parameters coccinelle warnings: (new ones prefixed

Re: [PATCH RFC ipsec-next 5/5] esp: Add a software GRO codepath

2017-02-07 Thread Eric Dumazet
On Tue, 2017-02-07 at 10:14 +0100, Steffen Klassert wrote: > This patch adds GRO ifrastructure and callbacks for ESP on > ipv4 and ipv6. > I am a bit confused. > > -struct xfrm_tunnel_skb_cb { > +/* > + * This structure is used if we get the packet from the gro layer. > + */ > +struct

Re: [PATCH net-next] sctp: avoid list_del_init if it's freeing the memory right away

2017-02-07 Thread Marcelo Ricardo Leitner
On Tue, Feb 07, 2017 at 02:21:21PM -0500, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Tue, 7 Feb 2017 17:03:21 -0200 > > > There is no reason to use list_del_init() in these places as we are > > going to free/destroy the memory in a few lines below. >

ATENCIÓN;

2017-02-07 Thread administrador
ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de

Performance in stmmac

2017-02-07 Thread Joao Pinto
Hi to all, I finished implementing the multi-queue / multi-channel in stmmac and I am now making some tests. The mechanism is working properly, but the performance could be better (~440Mb/s) :). For measuring I am using iperf: synopsys@pt02ipk1:~$ iperf -c 192.168.0.3 --port 5001 -t 20 -i 5

Re: [PATCH net-next] sctp: avoid list_del_init if it's freeing the memory right away

2017-02-07 Thread David Miller
From: Marcelo Ricardo Leitner Date: Tue, 7 Feb 2017 17:03:21 -0200 > There is no reason to use list_del_init() in these places as we are > going to free/destroy the memory in a few lines below. > > Signed-off-by: Marcelo Ricardo Leitner >

Re: [PATCH net-next] bridge: avoid unnecessary read of jiffies

2017-02-07 Thread David Miller
From: Stephen Hemminger Date: Tue, 7 Feb 2017 08:46:46 -0800 > Jiffies is volatile so read it once. > > Signed-off-by: Stephen Hemminger Applied, thanks Stephen.

Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set

2017-02-07 Thread David Miller
From: Colin King Date: Tue, 7 Feb 2017 10:56:38 + > From: Colin Ian King > > The error check on err is redundant as it is being checked > previously each time it has been updated. Remove this redundant > check. > > Detected with

Re: [PATCH net-next] sctp: drop __packed from almost all SCTP structures

2017-02-07 Thread David Miller
From: Marcelo Ricardo Leitner Date: Tue, 7 Feb 2017 11:37:56 -0200 > __packed is considered harmful as it potentially generates code that > doesn't perform well and its usage should be avoided as much as > possible. > > This patch drops __packed from all SCTP

Re: [PATCH net-next 0/9] mlx4: order-0 allocations and page recycling

2017-02-07 Thread Eric Dumazet
On Tue, Feb 7, 2017 at 11:05 AM, Alexei Starovoitov wrote: > On Tue, Feb 07, 2017 at 08:26:23AM -0800, Eric Dumazet wrote: >> On Tue, 2017-02-07 at 08:06 -0800, Eric Dumazet wrote: >> > > Awesome that you've started working on this. I think it's correct approach >

Re: [PATCH net] sctp: check af before verify address in sctp_addr_id2transport

2017-02-07 Thread David Miller
From: Xin Long Date: Tue, 7 Feb 2017 20:56:08 +0800 > Commit 6f29a1306131 ("sctp: sctp_addr_id2transport should verify the > addr before looking up assoc") invoked sctp_verify_addr to verify the > addr. > > But it didn't check af variable beforehand, once users pass an

Re: [patch net-next v2] spectrum: acl_tcam: Fix catchall prio value

2017-02-07 Thread David Miller
From: Jiri Pirko Date: Tue, 7 Feb 2017 17:27:47 +0100 > From: Jiri Pirko > > This fixes an issue reported by smatch: > mlxsw_sp_acl_tcam_chunk_create() warn: impossible condition '(priority == > (-1)) => (0-u32max == u64max)' > > Reported-by: Or Gerlitz

Re: [PATCH net-next] bridge: tunnel: fix attribute checks in br_parse_vlan_tunnel_info

2017-02-07 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 7 Feb 2017 12:46:46 +0100 > These checks should go after the attributes have been parsed otherwise > we're using tb uninitialized. > > Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") > Reported-by: Colin

Re: [PATCH net-next v3 00/12] bnxt_en: Add XDP support.

2017-02-07 Thread David Miller
From: Michael Chan Date: Mon, 6 Feb 2017 16:55:31 -0500 > The first 10 patches refactor the code (rx/tx code paths and ring logic) > and add the basic infrastructure to support XDP. The 11th patch adds > basic ndo_xdp to support XDP_DROP and XDP_PASS only. The 12th

Re: [PATCH net-next] bridge: remove unnecessary check for vtbegin in br_fill_vlan_tinfo_range

2017-02-07 Thread David Miller
From: Roopa Prabhu Date: Tue, 7 Feb 2017 06:43:23 -0800 > From: Roopa Prabhu > > vtbegin should not be NULL in this function, Its already checked by the > caller. > > this should silence the below smatch complaint: >

Re: [PATCH net-next 0/9] mlx4: order-0 allocations and page recycling

2017-02-07 Thread Alexei Starovoitov
On Tue, Feb 07, 2017 at 08:26:23AM -0800, Eric Dumazet wrote: > On Tue, 2017-02-07 at 08:06 -0800, Eric Dumazet wrote: > Awesome that you've started working on this. I think it's correct approach and mlx5 should be cleaned up in similar way. Long term we should be able to move all page alloc/free

[PATCH net-next] sctp: avoid list_del_init if it's freeing the memory right away

2017-02-07 Thread Marcelo Ricardo Leitner
There is no reason to use list_del_init() in these places as we are going to free/destroy the memory in a few lines below. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/associola.c | 14 -- net/sctp/auth.c | 8 ++-- net/sctp/chunk.c

Re: [PATCH v2 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

2017-02-07 Thread David Miller
From: Stefan Brüns Date: Tue, 7 Feb 2017 03:33:16 +0100 > If a context is configured as dualstack ("IPv4v6"), the modem indicates > the context activation with a slightly different indication message. > The dual-stack indication omits the link_type (IPv4/v6) and

Re: Extending socket timestamping API for NTP

2017-02-07 Thread Soheil Hassas Yeganeh
On Tue, Feb 7, 2017 at 6:01 AM, Miroslav Lichvar wrote: > 2) new SO_TIMESTAMPING option to receive from the error queue only >user data as was passed to sendmsg() instead of Ethernet frames > >Parsing Ethernet and IP headers (especially IPv6 options) is not >fun

Re: [PATCH v2 2/2] sierra_net: Skip validating irrelevant fields for IDLE LSIs

2017-02-07 Thread David Miller
From: Stefan Brüns Date: Tue, 7 Feb 2017 03:33:17 +0100 > When the context is deactivated, the link_type is set to 0xff, which > triggers a warning message, and results in a wrong link status, as > the LSI is ignored. > > Signed-off-by: Stefan Brüns

Re: [PATCH v3 3/3] net: phy: dp83867: Recover from "port mirroring" N/A MODE4

2017-02-07 Thread David Miller
From: Lukasz Majewski Date: Tue, 7 Feb 2017 06:20:24 +0100 > The DP83867 when not properly bootstrapped - especially with LED_0 pin - > can enter N/A MODE4 for "port mirroring" feature. > > To provide normal operation of the PHY, one needs not only to explicitly > disable the

Re: [patch v2 net-next] sfc: fix an off by one bug

2017-02-07 Thread David Miller
From: Dan Carpenter Date: Tue, 7 Feb 2017 10:44:31 +0300 > This bug is harmless because it's just a sanity check and we always > pass valid values for "encap_type" but the test is off by one. > > Fixes: 9b4108012517 ("sfc: insert catch-all filters for encapsulated

Re: [PATCH v3 2/3] net: phy: dp83867: Add lane swapping support in the DP83867 TI's PHY driver

2017-02-07 Thread David Miller
From: Lukasz Majewski Date: Tue, 7 Feb 2017 06:20:23 +0100 > This patch adds support for enabling or disabling the lane swapping (called > "port mirroring" in PHY's CFG4 register) feature of the DP83867 TI's PHY > device. > > One use case is when bootstrap configuration enables

Re: [PATCH v3 1/3] Documentation: devicetree: Add PHY no lane swap binding

2017-02-07 Thread David Miller
From: Lukasz Majewski Date: Tue, 7 Feb 2017 06:21:34 +0100 > Add the documentation to avoid PHY lane swapping. This is a boolean > entry to notify the phy device drivers that the TX/RX lanes NO need > to be swapped. > The use case for this binding mostly happens after wrong HW >

[PATCH] xen-netfront: Rework the fix for Rx stall during OOM and network stress

2017-02-07 Thread Vineeth Remanan Pillai
The commit 90c311b0eeea ("xen-netfront: Fix Rx stall during network stress and OOM") caused the refill timer to be triggerred almost on all invocations of xennet_alloc_rx_buffers for certain workloads. This reworks the fix by reverting to the old behaviour and taking into consideration the skb

Re: [PATCH net-next 0/4] net: Incorrect use of phy_read_status()

2017-02-07 Thread David Miller
From: Florian Fainelli Date: Mon, 6 Feb 2017 15:55:19 -0800 > This patch series removes incorrect uses of phy_read_status() which can > clobber > the PHY device link while we are executing with the state machine running. > > greth was potentially another candidate, but

Re: [PATCH v2 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

2017-02-07 Thread David Miller
From: David Miller Date: Tue, 07 Feb 2017 13:53:12 -0500 (EST) > From: Stefan Brüns > Date: Tue, 7 Feb 2017 03:33:16 +0100 > >> If a context is configured as dualstack ("IPv4v6"), the modem indicates >> the context activation with a slightly

Re: [PATCH] dt-bindings: net: remove reference to fixed link support

2017-02-07 Thread Rob Herring
On Fri, Feb 03, 2017 at 03:59:38PM -0500, David Miller wrote: > From: Thomas Petazzoni > Date: Thu, 2 Feb 2017 17:47:44 +0100 > > > Contrary to what the Device Tree binding indicates, the binding for the > > PPv2 network device currently doesn't provide any

Re: [PATCH net-next v2 1/8] bpf: Use bpf_load_program() from the library

2017-02-07 Thread David Miller
Please post your patch series(s) with proper "[PATCH ... 0/N]" header postings. Thank you.

Re: [pull request][net-next V2 0/6] Mellanox mlx5 updates 2017-01-31

2017-02-07 Thread David Miller
From: Saeed Mahameed Date: Tue, 7 Feb 2017 01:38:23 +0200 > This pull request includes two new mlx5 features and two small fixes for > net-next, > Details are bleow. > > Please pull and let me know if there's any problem. > > Sorry for the delay on addressing the

Re: [PATCH] net: ethernet: ti: cpsw: remove netif_trans_update

2017-02-07 Thread David Miller
From: Ivan Khoronzhuk Date: Tue, 7 Feb 2017 00:53:45 +0200 > No need to update jiffies in txq->trans_start twice, it's supposed to be > done in netdev_start_xmit() and anyway is re-written. Also, no reason to > update trans time in case of an error. > >

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-07 Thread Steve Calfee
On Mon, Feb 6, 2017 at 4:51 AM, Petko Manolov wrote: > On 17-02-06 09:28:22, Greg KH wrote: >> On Mon, Feb 06, 2017 at 10:14:44AM +0200, Petko Manolov wrote: >> > On 17-02-05 01:30:39, Greg KH wrote: >> > > On Sat, Feb 04, 2017 at 04:56:03PM +, Ben Hutchings wrote: >> >

Re: [PATCHv4 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces

2017-02-07 Thread David Miller
From: Sainath Grandhi Date: Mon, 6 Feb 2017 13:36:08 -0800 > Tap character devices can be implemented on other virtual interfaces like > ipvlan, similar to macvtap. Source code for tap functionality in macvtap > can be re-used for this purpose. > > This patch series

Re: [PATCH] [net-next] net: qcom/emac: add ethool support for setting pause parameters

2017-02-07 Thread David Miller
From: Timur Tabi Date: Mon, 6 Feb 2017 15:34:52 -0600 > To support setting the pause parameters, the driver can no longer just > mirror the PHY. The set_pauseparam feature allows the driver to > force the setting in the MAC, regardless of how the PHY is configured. > This

<    1   2   3   4   >