Re: [PATCH net-next 4/4] net/sched: cls_bpf: Use skip flags to reflect HW offload status

2017-02-12 Thread Or Gerlitz
On Fri, Feb 10, 2017 at 7:42 PM, Jakub Kicinski wrote: > On Fri, 10 Feb 2017 18:33:13 +0200, Or Gerlitz wrote: >> On Fri, Feb 10, 2017 at 3:22 AM, Jakub Kicinski wrote: >> > On Thu, 9 Feb 2017 16:18:08 +0200, Or Gerlitz wrote: >> >> Currently there is no way of

Re: [net-next 12/14] i40e: allow i40e_update_filter_state to skip broadcast filters

2017-02-12 Thread Sergei Shtylyov
Hello! On 2/12/2017 8:30 AM, Jeff Kirsher wrote: From: Jacob Keller Fix a bug where we modified the mac_filter_hash while outside a lock, when handling addition of broadcast filters. Normally, we add filters to firmware by batching the additions into lists and

Re: [PATH v2 net-next] net: remove member 'max' of struct scm_fp_list

2017-02-12 Thread Sergei Shtylyov
On 2/11/2017 5:36 AM, yuan linyu wrote: From: yuan linyu 'max' only used at three places in scm.c, 1. in scm_fp_copy(), fpl->max = SCM_MAX_FD; 2. in scm_fp_copy(), if (fpl->count + num > fpl->max) 3. in scm_fp_dup(), new_fpl->max = new_fpl->count; at place 2,

RE: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-12 Thread Liran Liss
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Vishwanathapura, Niranjana > > ChangeLog: > = > v2 => v3: > a) Introduce and adopt generic RDMA netdev interface including, > - having bottom hfi1 driver directly interfacing with

[PATCH net V2] net/mlx5e: Disable preemption when doing TC statistics upcall

2017-02-12 Thread Or Gerlitz
When called by HW offloading drivers, the TC action (e.g net/sched/act_mirred.c) code uses this_cpu logic, e.g _bstats_cpu_update(this_cpu_ptr(a->cpu_bstats), bytes, packets) per the kernel documention, preemption should be disabled, add that. Before the fix, when running with CONFIG_PREEMPT

Re: [PATCH v2 net] bpf: introduce BPF_F_ALLOW_OVERRIDE flag

2017-02-12 Thread Daniel Mack
On 02/11/2017 05:28 AM, Alexei Starovoitov wrote: > If BPF_F_ALLOW_OVERRIDE flag is used in BPF_PROG_ATTACH command > to the given cgroup the descendent cgroup will be able to override > effective bpf program that was inherited from this cgroup. > By default it's not passed, therefore override is

Re: [PATCH net-next 4/4] net/sched: cls_bpf: Use skip flags to reflect HW offload status

2017-02-12 Thread Or Gerlitz
On Sat, Feb 11, 2017 at 12:19 AM, Jakub Kicinski wrote: > FWIW I tested this one and it works. I also tested this version which > would take advantage of @offloaded: I assume that if we go on the existing suggestion, the below is what you prefer, so I will pick it

Re: [PATCH v3 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable

2017-02-12 Thread Sergei Shtylyov
Hello! On 2/10/2017 8:38 PM, Shannon Nelson wrote: When the sunvnet_common code was split out for use by both sunvnet and the newer ldmvsw, it was made into a static kernel library, which limits the usefulness of sunvnet and ldmvsw as loadables, since most of the real work is being done in the

Re: [PATCH net-next v4 1/2] qed: Add infrastructure for PTP support.

2017-02-12 Thread Richard Cochran
On Sun, Feb 12, 2017 at 11:27:16AM +, Mintz, Yuval wrote: > Richard, there are quite a bit of inaccuracies in the calculation here. Where? If you compare this algorithm with yours, you will discover that it produces significantly lower error for ppm < 60. > Your suggestion seems to: > a.

Re: [PATCH net-next 4/4] net/sched: cls_bpf: Use skip flags to reflect HW offload status

2017-02-12 Thread Or Gerlitz
On Fri, Feb 10, 2017 at 7:42 PM, Jakub Kicinski wrote: > On Fri, 10 Feb 2017 18:33:13 +0200, Or Gerlitz wrote: >> On Fri, Feb 10, 2017 at 3:22 AM, Jakub Kicinski wrote: >> > In cls_bpf we do store information about whether program is offloaded or >> > not already

Re: [PATCH 1/2] include: Fix checkpatch whitespace error and warning

2017-02-12 Thread Sergei Shtylyov
Hello! On 2/12/2017 5:57 AM, Tobin C. Harding wrote: This patch fixes two trivial whitespace messages (ERROR/WARNING). Fixes trailing whitespace ERROR and fixes space before tabs WARNING. Signed-off-by: Tobin C. Harding --- include/linux/idr.h | 4 ++-- 1 file changed, 2

RE: [PATCH net-next v4 1/2] qed: Add infrastructure for PTP support.

2017-02-12 Thread Mintz, Yuval
> On Sat, Feb 11, 2017 at 09:58:10AM +0100, Richard Cochran wrote: > > If I am not mistaken, then you can skip the cases val==2 and val==3, > > because they are equivalent to val==4 and 6. > > I took a stab at this, and you can see the result, below. My version has > lower average error than

RE: [PATCH net-next v4 1/2] qed: Add infrastructure for PTP support.

2017-02-12 Thread Mintz, Yuval
> The '+8' is not some sort of rounding correction, but rather part of the > required configuration. Just to clarify [since it's bit a meaningless otherwise] - this +8 is a HW-bug workaround.

Re: [PATCH net-next 0/4] net/sched: Use TC skip flags to reflect HW offload status

2017-02-12 Thread Or Gerlitz
On Fri, Feb 10, 2017 at 9:36 PM, David Miller wrote: > From: Or Gerlitz > Date: Thu, 9 Feb 2017 16:18:04 +0200 > >> Currently there is no way of querying whether a filter is >> offloaded to HW or not when using both policy (no flag). >> >> Reuse the

4.9.4 panic, nf_conntrack_tuple_taken

2017-02-12 Thread Denys Fedoryshchenko
Hi, Seems i'm quite "lucky" and hitting another bug. This time it is different server, but i believe i've seen this bug on few pppoe servers, but here it is happening once per 1-2 days. Out of tree patch applied, to optimize gc heuristics. I don't exclude (but very small chance) hardware

Re: [PATCH net-next v3 06/10] net: dsa: Migrate to device_find_class()

2017-02-12 Thread Greg KH
On Fri, Feb 10, 2017 at 10:30:58AM -0800, Florian Fainelli wrote: > On 02/10/2017 05:02 AM, Greg KH wrote: > > On Thu, Jan 19, 2017 at 04:51:55PM +, Russell King - ARM Linux wrote: > >> (This is mainly for Greg's benefit to help him understand the issue.) > >> > >> I think the diagram you gave

Re: [PATCH RFC net] net/mlx5e: Add preemption enable/disable around TC statistics upcall

2017-02-12 Thread Or Gerlitz
On Fri, Feb 10, 2017 at 8:14 PM, Jakub Kicinski wrote: > On Fri, 10 Feb 2017 18:21:25 +0200, Or Gerlitz wrote: >> On Fri, Feb 10, 2017 at 3:34 AM, Jakub Kicinski wrote: >> > On Thu, 9 Feb 2017 17:38:43 +0200, Or Gerlitz wrote: >> >> Running with CONFIG_PREEMPT set,

[PATCH] net: neterion: s2io: use new api ethtool_{get|set}_link_ksettings

2017-02-12 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/neterion/s2io.c | 51

RE: [PATCH 1/2] include: Fix checkpatch whitespace error and warning

2017-02-12 Thread Matthew Wilcox
Don't worry about this file; I have a complete rewrite already queued. > -Original Message- > From: Tobin C. Harding [mailto:m...@tobin.cc] > Sent: Saturday, February 11, 2017 9:58 PM > To: David S . Miller > Cc: Matthew Wilcox ;

Re: [PATCH V5 for-next 16/21] RDMA/bnxt_re: Support poll_cq verb

2017-02-12 Thread Leon Romanovsky
On Fri, Feb 10, 2017 at 03:19:48AM -0800, Selvin Xavier wrote: > Enables the fastpath ib_poll_cq verb. > > v2: Fixed sparse warnings > v3: Fixes endianness related warnings reported by sparse. Also, fixes > smatch and checkpatch warnings > v5: Uses ETH_P_IBOE macro for RoCE ethertype > >

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-12 Thread Tariq Toukan
On 09/02/2017 6:56 PM, Eric Dumazet wrote: Default, out of box. Well. Please report : ethtool -l eth0 ethtool -g eth0 $ ethtool -g p1p1 Ring parameters for p1p1: Pre-set maximums: RX: 8192 RX Mini:0 RX Jumbo: 0 TX: 8192 Current hardware settings: RX:

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-12 Thread Eric Dumazet
Please Tariq do not send HTML messages, they are not making to netdev mailing list. On Sun, Feb 12, 2017 at 7:55 AM, Tariq Toukan wrote: > > On 09/02/2017 6:43 PM, Tariq Toukan wrote: > > We need to test this series again in our functional and performance > regression

[PATCH 01/21] netfilter: nft_exthdr: Add support for existence check

2017-02-12 Thread Pablo Neira Ayuso
From: Phil Sutter If NFT_EXTHDR_F_PRESENT is set, exthdr will not copy any header field data into *dest, but instead set it to 1 if the header is found and 0 otherwise. Signed-off-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso ---

[PATCH 04/21] netfilter: nf_tables: rename deactivate_one() to flush()

2017-02-12 Thread Pablo Neira Ayuso
Although semantics are similar to deactivate() with no implicit element lookup, this is only called from the set flush path, so better rename this to flush(). Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h | 8 net/netfilter/nf_tables_api.c

[PATCH 05/21] netfilter: nf_tables: add flush field to struct nft_set_iter

2017-02-12 Thread Pablo Neira Ayuso
This provides context to walk callback iterator, thus, we know if the walk happens from the set flush path. This is required by the new bitmap set type coming in a follow up patch which has no real struct nft_set_ext, so it has to allocate it based on the two bit compact element representation.

[PATCH 02/21] netfilter: nf_tables: pass netns to set->ops->remove()

2017-02-12 Thread Pablo Neira Ayuso
This new parameter is required by the new bitmap set type that comes in a follow up patch. Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h | 3 ++- net/netfilter/nf_tables_api.c | 6 +++--- net/netfilter/nft_set_hash.c | 3 ++-

[PATCH 07/21] netfilter: nf_tables: add space notation to sets

2017-02-12 Thread Pablo Neira Ayuso
The space notation allows us to classify the set backend implementation based on the amount of required memory. This provides an order of the set representation scalability in terms of memory. The size field is still left in place so use this if the userspace provides no explicit number of

[PATCH 13/21] netfilter: nf_ct_sip: Use mod_timer_pending()

2017-02-12 Thread Pablo Neira Ayuso
From: Gao Feng timer_del() followed by timer_add() can be replaced by mod_timer_pending(). Signed-off-by: Gao Feng Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_conntrack_sip.c | 12 +--- 1 file changed, 5 insertions(+),

[PATCH 15/21] netfilter: nfnetlink: get rid of u_intX_t types

2017-02-12 Thread Pablo Neira Ayuso
Use uX types instead. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nfnetlink.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c index a09fa9fd8f3d..586212ebba9e 100644 ---

[PATCH 03/21] netfilter: nf_tables: use struct nft_set_iter in set element flush

2017-02-12 Thread Pablo Neira Ayuso
Instead of struct nft_set_dump_args, remove unnecessary wrapper structure. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/net/netfilter/nf_tables_api.c

[PATCH 09/21] netfilter: nft_ct: add zone id get support

2017-02-12 Thread Pablo Neira Ayuso
From: Florian Westphal Just like with counters the direction attribute is optional. We set priv->dir to MAX unconditionally to avoid duplicating the assignment for all keys with optional direction. For keys where direction is mandatory, existing code already returns an error.

RE: [PATCH net-next v4 1/2] qed: Add infrastructure for PTP support.

2017-02-12 Thread Mintz, Yuval
> > Your suggestion seems to: > > a. Assume that the required period should be in ns, not in > > 16*ns units. > > b. mishandles the +8/-8 in the calculation. > > c. Doesn't seem to consider the upper bound on period. > > Duh, you would have to convert the result into the proper form

[PATCH] net: neterion: vxge: use new api ethtool_{get|set}_link_ksettings

2017-02-12 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/neterion/vxge/vxge-ethtool.c |

[PATCH 00/21] Netfilter updates for net-next

2017-02-12 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter updates for your net-next tree, most relevantly they are: 1) Extend nft_exthdr to allow to match TCP options bitfields, from Manuel Messner. 2) Allow to check if IPv6 extension header is present in nf_tables, from Phil Sutter. 3) Allow

[PATCH 21/21] netfilter: nf_tables: honor NFT_SET_OBJECT in set backend selection

2017-02-12 Thread Pablo Neira Ayuso
Check for NFT_SET_OBJECT feature flag, otherwise we may end up selecting the wrong set backend. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 3 ++- net/netfilter/nft_set_hash.c | 2 +- net/netfilter/nft_set_rbtree.c | 2 +- 3 files changed, 4

[PATCH 17/21] netfilter: nfnetlink: allow to check for generation ID

2017-02-12 Thread Pablo Neira Ayuso
This patch allows userspace to specify the generation ID that has been used to build an incremental batch update. If userspace specifies the generation ID in the batch message as attribute, then nfnetlink compares it to the current generation ID so you make sure that you work against the right

[PATCH 08/21] netfilter: nf_tables: add bitmap set type

2017-02-12 Thread Pablo Neira Ayuso
This patch adds a new bitmap set type. This bitmap uses two bits to represent one element. These two bits determine the element state in the current and the future generation that fits into the nf_tables commit protocol. When dumping elements back to userspace, the two bits are expanded into a

[PATCH 14/21] netfilter: nf_ct_expect: nf_ct_expect_insert() returns void

2017-02-12 Thread Pablo Neira Ayuso
From: Gao Feng Because nf_ct_expect_insert() always succeeds now, its return value can be just void instead of int. And remove code that checks for its return value. Signed-off-by: Gao Feng Signed-off-by: Pablo Neira Ayuso ---

[PATCH 12/21] netfilter: nft_exthdr: add TCP option matching

2017-02-12 Thread Pablo Neira Ayuso
From: Manuel Messner This patch implements the kernel side of the TCP option patch. Signed-off-by: Manuel Messner Reviewed-by: Florian Westphal Acked-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso ---

[PATCH 19/21] netfilter: nf_tables: add NFTA_RULE_ID attribute

2017-02-12 Thread Pablo Neira Ayuso
This new attribute allows us to uniquely identify a rule in transaction. Robots may trigger an insertion followed by deletion in a batch, in that scenario we still don't have a public rule handle that we can use to delete the rule. This is similar to the NFTA_SET_ID attribute that allows us to

[PATCH 20/21] netfilter: update MAINTAINERS

2017-02-12 Thread Pablo Neira Ayuso
It's been a while since Patrick has been suspended as coreteam member [1]. Update this file to remove him. While at this, remove references to all foo-tables variants, given the project hosts more than just that, eg. ipset, conntrack, ... [1] https://marc.info/?l=netfilter-devel=146887464512702

[PATCH 16/21] netfilter: nfnetlink: add nfnetlink_rcv_skb_batch()

2017-02-12 Thread Pablo Neira Ayuso
Add new nfnetlink_rcv_skb_batch() to wrap initial nfnetlink batch handling. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nfnetlink.c | 51 ++- 1 file changed, 28 insertions(+), 23 deletions(-) diff --git

[PATCH 11/21] netfilter: nft_ct: add zone id set support

2017-02-12 Thread Pablo Neira Ayuso
From: Florian Westphal zones allow tracking multiple connections sharing identical tuples, this is needed e.g. when tracking distinct vlans with overlapping ip addresses (conntrack is l2 agnostic). Thus the zone has to be set before the packet is picked up by the connection

[PATCH 06/21] netfilter: nf_tables: rename struct nft_set_estimate class field

2017-02-12 Thread Pablo Neira Ayuso
Use lookup as field name instead, to prepare the introduction of the memory class in a follow up patch. Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h | 4 ++-- net/netfilter/nf_tables_api.c | 12 ++-- net/netfilter/nft_set_hash.c |

[PATCH 10/21] netfilter: nft_ct: prepare for key-dependent error unwind

2017-02-12 Thread Pablo Neira Ayuso
From: Florian Westphal Next patch will add ZONE_ID set support which will need similar error unwind (put operation) as conntrack labels. Prepare for this: remove the 'label_got' boolean in favor of a switch statement that can be extended in next patch. As we already have that

[PATCH 18/21] netfilter: nf_tables: add check_genid to the nfnetlink subsystem

2017-02-12 Thread Pablo Neira Ayuso
This patch implements the check generation id as provided by nfnetlink. This allows us to reject ruleset updates against stale baseline, so userspace can retry update with a fresh ruleset cache. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 6 ++

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-12 Thread Eric Dumazet
On Sun, Feb 12, 2017 at 7:04 AM, Tariq Toukan wrote: > > We consistently see this behavior: the higher the BW, the sharper the > degradation. > > This is because the page-cache is of a fixed-size. Any fixed-size page-cache > will always meet one of the following: > 1)

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-12 Thread Tariq Toukan
On 12/02/2017 5:32 PM, Eric Dumazet wrote: On Sun, Feb 12, 2017 at 7:04 AM, Tariq Toukan wrote: We consistently see this behavior: the higher the BW, the sharper the degradation. This is because the page-cache is of a fixed-size. Any fixed-size page-cache will

RE: [PATCH net-next v4 1/2] qed: Add infrastructure for PTP support.

2017-02-12 Thread Mintz, Yuval
> The original would return val == 1, period == 6249; While this does have > some error [val / (period * 16 + 8) is slightly bigger than 1 / 10^9, error at > 18[?] digit after dot], it's the best we can configure for the HW. Correction. That's actually not *the best* we could configure - due

Re: [PATCH net-next 0/4] net/sched: Use TC skip flags to reflect HW offload status

2017-02-12 Thread David Miller
From: Or Gerlitz Date: Sun, 12 Feb 2017 11:54:25 +0200 > Re the old kernel argument, these patches are small and pointish, > would it make sense to you to consider them as fixes and push them > back to the relevant stable kernels? Sorry, it doesn't work that way.

Re: [PATCH net-next v4 1/2] qed: Add infrastructure for PTP support.

2017-02-12 Thread Richard Cochran
On Sun, Feb 12, 2017 at 11:52:23AM +, Mintz, Yuval wrote: > Just to clarify [since it's bit a meaningless otherwise] - > this +8 is a HW-bug workaround. Can you please explain exactly what the problem is? Your code does period1 = div_s64(val * 10, ppb);

net/llc: BUG in llc_sap_state_process/skb_set_owner_r

2017-02-12 Thread Andrey Konovalov
Hi, I've got the following error report while fuzzing the kernel with syzkaller. On commit 926af6273fc683cd98cd0ce7bf0d04a02eed6742. A reproducer and .config are attached kernel BUG at ./include/linux/skbuff.h:2389! invalid opcode: [#1] SMP KASAN Dumping ftrace buffer: (ftrace buffer

Re: net/llc: bug in llc_pdu_init_as_xid_cmd/skb_over_panic

2017-02-12 Thread Andrey Konovalov
On Fri, Feb 10, 2017 at 4:12 PM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit 926af6273fc683cd98cd0ce7bf0d04a02eed6742. > > A reproducer and .config are attached > > kernel BUG at

Re: net/ipv6: use-after-free in sock_wfree

2017-02-12 Thread Andrey Konovalov
On Mon, Jan 9, 2017 at 6:21 PM, Eric Dumazet wrote: > On Mon, Jan 9, 2017 at 9:11 AM, Andrey Konovalov > wrote: >> On Mon, Jan 9, 2017 at 6:08 PM, Andrey Konovalov >> wrote: >>> Hi! >>> >>> I've got the following error report

Re: net/llc: BUG in llc_sap_state_process/skb_set_owner_r

2017-02-12 Thread Eric Dumazet
On Sun, Feb 12, 2017 at 8:44 AM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit 926af6273fc683cd98cd0ce7bf0d04a02eed6742. > > A reproducer and .config are attached Thanks for the report. llc

Re: Fw: [Bug 193911] New: net_prio.ifpriomap is not aware of the network namespace, and discloses all network interface

2017-02-12 Thread Eric W. Biederman
Tejun Heo writes: > Hello, > > On Sun, Feb 05, 2017 at 11:05:36PM -0800, Cong Wang wrote: >> > To be more specific, the read operation of net_prio.ifpriomap is handled >> > by the >> > function read_priomap. Tracing from this function, we can find it invokes >> >

Re: [PATCH net-next v4 1/2] qed: Add infrastructure for PTP support.

2017-02-12 Thread Richard Cochran
On Sun, Feb 12, 2017 at 03:07:34PM +, Mintz, Yuval wrote: > Your algorithm ignores the HW limitation. Consider (ppb == 1): > your logic would output N == 7, *M == 70, >Which has perfect accuracy [N / *M is 1 / 10^9]. > But the solution for >'period' * 16 + 8 == 7 * 10^9 >

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-12 Thread Eric Dumazet
On Sun, 2017-02-12 at 18:31 +0200, Tariq Toukan wrote: > On 09/02/2017 6:56 PM, Eric Dumazet wrote: > >> Default, out of box. > > Well. Please report : > > > > ethtool -l eth0 > > ethtool -g eth0 > $ ethtool -g p1p1 > Ring parameters for p1p1: > Pre-set maximums: > RX: 8192 > RX Mini:

[PATCH] net: nuvoton: w90p910: use new api ethtool_{get|set}_link_ksettings

2017-02-12 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/nuvoton/w90p910_ether.c | 14

[PATCH v1] samples/bpf: Add a .gitignore for binaries

2017-02-12 Thread Mickaël Salaün
Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Daniel Borkmann Cc: Wang Nan --- samples/bpf/.gitignore | 32 1 file changed, 32

linux-next: manual merge of the ipsec-next tree with the net-next tree

2017-02-12 Thread Stephen Rothwell
Hi Steffen, Today's linux-next merge of the ipsec-next tree got a conflict in: net/xfrm/xfrm_policy.c between commit: 63fca65d0863 ("net: add confirm_neigh method to dst_ops") from the net-next tree and commits: 3d7d25a68ea5 ("xfrm: policy: remove garbage_collect callback")

[PATCH net-next 3/9] bnxt_en: Fix ethtool -l pre-set max combined channel.

2017-02-12 Thread Michael Chan
With commit d1e7925e6d80 ("bnxt_en: Centralize logic to reserve rings."), ring allocation for combined rings has become stricter. A combined ring must now have an rx-tx ring pair. The pre-set max. for combined rings should now be min(rx, tx). Fixes: d1e7925e6d80 ("bnxt_en: Centralize logic to

[PATCH net-next 7/9] bnxt_en: Print FEC settings as part of the linkup dmesg.

2017-02-12 Thread Michael Chan
Print FEC (Forward Error Correction) autoneg and encoding settings during link up. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 13 - drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 2 files changed, 16 insertions(+), 1

[PATCH net-next 1/9] bnxt_en: Update to firmware interface spec 1.7.0.

2017-02-12 Thread Michael Chan
The new spec has NVRAM defragmentation support which will be used in the next patch to improve ethtool flash operation. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 +- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 5 +-

[PATCH net-next 5/9] bnxt_en: Add hardware NTUPLE filter for encapsulated packets.

2017-02-12 Thread Michael Chan
If skb_flow_dissect_flow_keys() returns with the encapsulation flag set, pass the information to the firmware to setup the NTUPLE filter accordingly. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 17 ++--- 1 file changed, 14

[PATCH net-next 6/9] bnxt_en: Do not setup PHY unless driving a single PF.

2017-02-12 Thread Michael Chan
If it is a VF or an NPAR function, the firmware call to setup the PHY will fail. Adding this check will prevent unnecessary firmware calls to setup the PHY unless calling from the PF. This will also eliminate many unnecessary warning messages when the call from a VF or NPAR fails.

[PATCH net-next 8/9] bnxt_en: Fix bnxt_setup_tc() error message.

2017-02-12 Thread Michael Chan
Add proper puctuation to make the message more clear. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c

[PATCH net-next 0/9] bnxt_en: Misc updates.

2017-02-12 Thread Michael Chan
Miscellaneous updates include update of the firmware spec, ethtool flash enhancement, ethtool -l minor fix, NTUPLE support enhancements, FEC link settings message during link up, and new PCI IDs. Please review. Thanks. Deepak Khungar (1): bnxt_en: Added PCI IDs for BCM57452 and BCM57454 ASICs

[PATCH net-next 2/9] bnxt_en: Retry failed NVM_INSTALL_UPDATE with defragmentation flag.

2017-02-12 Thread Michael Chan
From: Kshitij Soni If the HWRM_NVM_INSTALL_UPDATE command fails with the error code NVM_INSTALL_UPDATE_CMD_ERR_CODE_FRAG_ERR, retry the command with a new flag to allow defragmentation. Since we are checking the response for error code, we also need to take the mutex

[PATCH net-next 9/9] bnxt_en: Added PCI IDs for BCM57452 and BCM57454 ASICs

2017-02-12 Thread Michael Chan
From: Deepak Khungar Signed-off-by: Deepak Khungar Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH net-next 4/9] bnxt_en: Allow NETIF_F_NTUPLE to be enabled on VFs.

2017-02-12 Thread Michael Chan
Commit ae10ae740ad2 ("bnxt_en: Add new hardware RFS mode.") has added code to allow NTUPLE to be enabled on VFs. So we now remove the BNXT_VF() check in rfs_capable() to allow NTUPLE on VFs. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c |

Re: net: hix5hd2_gmac uninitialized net_device

2017-02-12 Thread Dongpo Li
On 2017/2/11 8:51, Marty Plummer wrote: > On Fri, Feb 10, 2017 at 06:21:35PM +0800, Dongpo Li wrote: >> I think the error "No irq resource" happened for some other reason, has no >> relation with >> the info "(unnamed net_device) (uninitialized):". >> You can add more debug info to find bug. >

[PATCH net] net/llc: avoid BUG_ON() in skb_orphan()

2017-02-12 Thread Eric Dumazet
From: Eric Dumazet It seems nobody used LLC since linux-3.12. Fortunately fuzzers like syzkaller still know how to run this code, otherwise it would be no fun. Setting skb->sk without skb->destructor leads to all kinds of bugs, we now prefer to be very strict about it.

Re: [PATCH v2 net] bpf: introduce BPF_F_ALLOW_OVERRIDE flag

2017-02-12 Thread Andy Lutomirski
On Sun, Feb 12, 2017 at 12:01 AM, Daniel Mack wrote: > On 02/11/2017 05:28 AM, Alexei Starovoitov wrote: >> If BPF_F_ALLOW_OVERRIDE flag is used in BPF_PROG_ATTACH command >> to the given cgroup the descendent cgroup will be able to override >> effective bpf program that was

Re: [PATCH net-next v2] net: phy: Allow splitting MDIO bus/device support from PHYs

2017-02-12 Thread kbuild test robot
Hi Florian, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-phy-Allow-splitting-MDIO-bus-device-support-from-PHYs/20170210-115834 config: i386-randconfig-h1-02130126 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-12 Thread Jesper Dangaard Brouer
On Sun, 12 Feb 2017 12:57:46 -0800 Eric Dumazet wrote: > On Sun, 2017-02-12 at 18:31 +0200, Tariq Toukan wrote: > > On 09/02/2017 6:56 PM, Eric Dumazet wrote: > > >> Default, out of box. > > > Well. Please report : > > > > > > ethtool -l eth0 > > > ethtool -g eth0

[PATCH 0/2] IPv4-mapped on wire, :: dst address issue

2017-02-12 Thread Jonathan T. Leighton
Under some circumstances IPv6 datagrams are sent with IPv4-mapped IPv6 addresses as the source. Given an IPv6 socket bound to an IPv4-mapped IPv6 address, and an IPv6 destination address, both TCP and UDP will will send packets using the IPv4-mapped IPv6 address as the source. Per RFC 6890 (Table

[PATCH 1/2] ipv6: Inhibit IPv4-mapped src address on the wire.

2017-02-12 Thread Jonathan T. Leighton
This patch adds a check for the problematic case of an IPv4-mapped IPv6 source address and a destination address that is neither an IPv4-mapped IPv6 address nor in6addr_any, and returns an appropriate error. The check in done before returning from looking up the route. Signed-off-by: Jonathan T.

[PATCH 2/2] ipv6: Handle IPv4-mapped src to in6addr_any dst.

2017-02-12 Thread Jonathan T. Leighton
This patch adds a check on the type of the source address for the case where the destination address is in6addr_any. If the source is an IPv4-mapped IPv6 source address, the destination is changed to :::127.0.0.1, and otherwise the destination is changed to ::1. This is done in three locations

Re: [PATCH v2 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-12 Thread Eric Dumazet
On Sun, 2017-02-12 at 23:38 +0100, Jesper Dangaard Brouer wrote: > Just so others understand this: The number of RX queue slots is > indirectly the size of the page-recycle "cache" in this scheme (that > depend on refcnt tricks to see if page can be reused). Note that the page recycle tricks

RE: [PATCH net 1/1] net: fec: fix multicast filtering hardware setup

2017-02-12 Thread Andy Duan
From: Fabio Estevam Sent: Saturday, February 11, 2017 5:20 AM >To: Andy Duan >Cc: David S. Miller ; netdev@vger.kernel.org; >Stephen Hemminger >Subject: Re: [PATCH net 1/1] net: fec: fix multicast

Re: [PATCH 00/21] Netfilter updates for net-next

2017-02-12 Thread David Miller
From: Pablo Neira Ayuso Date: Sun, 12 Feb 2017 20:42:32 +0100 > The following patchset contains Netfilter updates for your net-next > tree, most relevantly they are: .. > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git

Re: [PATCH V5 for-next 16/21] RDMA/bnxt_re: Support poll_cq verb

2017-02-12 Thread Leon Romanovsky
On Mon, Feb 13, 2017 at 10:47:10AM +0530, Selvin Xavier wrote: > On Sun, Feb 12, 2017 at 8:00 PM, Leon Romanovsky wrote: > >> +static u8 __rc_to_ib_wc_status(u8 qstatus) > >> +{ > >> + switch (qstatus) { > >> + case CQ_RES_RC_STATUS_OK: > >> + return

Re: net/packet: use-after-free in packet_rcv_fanout

2017-02-12 Thread Sowmini Varadhan
On (02/10/17 10:02), Eric Dumazet wrote: > At least, Anoob patch is making a step into the right direction ;) > https://patchwork.ozlabs.org/patch/726532/ I've not been able to reproduce Dmitry's panic (though I did not try very hard either) but there's a call to fanout_release from

Re: [PATCH v4 0/3] Miscellaneous fixes for BPF (perf tree)

2017-02-12 Thread Wangnan (F)
On 2017/2/9 4:27, Mickaël Salaün wrote: This series brings some fixes and small improvements to the BPF samples. This is intended for the perf tree and apply on 7a5980f9c006 ("tools lib bpf: Add missing header to the library"). Changes since v3: * remove applied patch 1/5 * remove patch 2/5

Re: [PATCH net-next v1] bpf: Remove redundant ifdef

2017-02-12 Thread Wangnan (F)
On 2017/2/12 3:37, Mickaël Salaün wrote: Remove a useless ifdef __NR_bpf as requested by Wang Nan. Inline one-line static functions as it was in the bpf_sys.h file. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Daniel Borkmann

Re: [PATCH v2 net] bpf: introduce BPF_F_ALLOW_OVERRIDE flag

2017-02-12 Thread David Miller
From: Alexei Starovoitov Date: Fri, 10 Feb 2017 20:28:24 -0800 > If BPF_F_ALLOW_OVERRIDE flag is used in BPF_PROG_ATTACH command > to the given cgroup the descendent cgroup will be able to override > effective bpf program that was inherited from this cgroup. > By default it's not

Re: [PATCH] net: neterion: vxge: use new api ethtool_{get|set}_link_ksettings

2017-02-12 Thread David Miller
From: Philippe Reynes Date: Sun, 12 Feb 2017 17:33:13 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: microchip: enc28j60: use new api ethtool_{get|set}_link_ksettings

2017-02-12 Thread David Miller
From: Philippe Reynes Date: Thu, 9 Feb 2017 22:02:47 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

[PATCH v2 2/3] Bluetooth: cmtp: fix possible might sleep error in cmtp_session

2017-02-12 Thread Jeffy Chen
It looks like cmtp_session has same pattern as the issue reported in old rfcomm: while (1) { set_current_state(TASK_INTERRUPTIBLE); if (condition) break; // may call might_sleep here schedule();

Re: linux-next: build failure after merge of the rcu tree

2017-02-12 Thread Paul E. McKenney
On Mon, Feb 13, 2017 at 01:21:33PM +1100, Stephen Rothwell wrote: > Hi Paul, > > On Thu, 19 Jan 2017 13:54:37 -0800 Paul McKenney wrote: > > > > On Wed, Jan 18, 2017 at 7:34 PM, Stephen Rothwell > > wrote: > > > Hi Paul, > > > > > > After merging

Re: [PATCH 2/3] Bluetooth: cmtp: fix possible might sleep error in cmtp_session

2017-02-12 Thread jeffy
Hi brian, On 02/11/2017 09:43 AM, Brian Norris wrote: Hi, On Tue, Jan 24, 2017 at 12:07:50PM +0800, Jeffy Chen wrote: It looks like cmtp_session has same pattern as the issue reported in old rfcomm: while (1) { set_current_state(TASK_INTERRUPTIBLE); if

Re: [PATCH] Make EN2 pin optional in the TRF7970A driver

2017-02-12 Thread Heiko Schocher
Hello Rob, Am 10.02.2017 um 16:51 schrieb Rob Herring: On Tue, Feb 07, 2017 at 06:22:04AM +0100, Heiko Schocher wrote: From: Guan Ben Make the EN2 pin optional. This is useful for boards, which have this pin fix wired, for example to ground. Signed-off-by: Guan Ben

Re: [PATCH v1] samples/bpf: Add a .gitignore for binaries

2017-02-12 Thread David Ahern
On 2/12/17 2:23 PM, Mickaël Salaün wrote: > diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore > new file mode 100644 > index ..a7562a5ef4c2 > --- /dev/null > +++ b/samples/bpf/.gitignore > @@ -0,0 +1,32 @@ > +fds_example > +lathist ... Listing each target is going to be a

Re: linux-next: build failure after merge of the rcu tree

2017-02-12 Thread Stephen Rothwell
Hi Paul, On Thu, 19 Jan 2017 13:54:37 -0800 Paul McKenney wrote: > > On Wed, Jan 18, 2017 at 7:34 PM, Stephen Rothwell > wrote: > > Hi Paul, > > > > After merging the rcu tree, today's linux-next build (x86_64 allmodconfig) > > failed like this: > >

Re: [net-next 00/14][pull request] 40GbE Intel Wired LAN Driver Updates 2017-02-11

2017-02-12 Thread David Miller
From: Jeff Kirsher Date: Sat, 11 Feb 2017 21:30:14 -0800 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff. Please address Sergei's feedback for patch #12 in followup changes, if necessary, thank you.

Re: [PATCH 1/3] Bluetooth: bnep: fix possible might sleep error in bnep_session

2017-02-12 Thread jeffy
Hi brian, On 02/11/2017 09:40 AM, Brian Norris wrote: Hi, On Tue, Jan 24, 2017 at 12:07:49PM +0800, Jeffy Chen wrote: It looks like bnep_session has same pattern as the issue reported in old rfcomm: while (1) { set_current_state(TASK_INTERRUPTIBLE); if

[PATCH v3 3/3] Bluetooth: hidp: fix possible might sleep error in hidp_session_thread

2017-02-12 Thread Jeffy Chen
It looks like hidp_session_thread has same pattern as the issue reported in old rfcomm: while (1) { set_current_state(TASK_INTERRUPTIBLE); if (condition) break; // may call might_sleep here schedule();

[PATCH v3 1/3] Bluetooth: bnep: fix possible might sleep error in bnep_session

2017-02-12 Thread Jeffy Chen
It looks like bnep_session has same pattern as the issue reported in old rfcomm: while (1) { set_current_state(TASK_INTERRUPTIBLE); if (condition) break; // may call might_sleep here schedule();

[PATCH v3 2/3] Bluetooth: cmtp: fix possible might sleep error in cmtp_session

2017-02-12 Thread Jeffy Chen
It looks like cmtp_session has same pattern as the issue reported in old rfcomm: while (1) { set_current_state(TASK_INTERRUPTIBLE); if (condition) break; // may call might_sleep here schedule();

  1   2   >