Re: [PATCH net] vxlan: fix oops in dev_fill_metadata_dst

2017-02-17 Thread David Miller
From: Paolo Abeni Date: Fri, 17 Feb 2017 19:14:27 +0100 > Since the commit 0c1d70af924b ("net: use dst_cache for vxlan device") > vxlan_fill_metadata_dst() calls vxlan_get_route() passing a NULL > dst_cache pointer, so the latter should explicitly check for > valid dst_cache

Re: [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread Andrew Lunn
On Fri, Feb 17, 2017 at 10:05:27AM -0500, Vivien Didelot wrote: > Move the Global (1) ATU related code in its own file, and export the > necessary primitives. > > Use that opportunity to provide a cleaner API for the ATU, by renaming a > few underscore prefixed functions, and members of the >

Re: [PATCH] vmxnet3: prevent building with 64K pages

2017-02-17 Thread David Miller
From: Arnd Bergmann Date: Fri, 17 Feb 2017 16:08:30 +0100 > I got a warning about broken code on ARM64 with 64K pages: > > drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_init': > drivers/net/vmxnet3/vmxnet3_drv.c:1679:29: error: large integer implicitly > truncated

Re: CHECKSUM_UNNECESSARY semantics with driver modified.created packets

2017-02-17 Thread Tom Herbert
On Fri, Feb 17, 2017 at 1:04 PM, Tom Herbert wrote: > Alexei and I were looking at the mlx5 LRO code this morning. One > discrepancy I noticed with GRO is that CHECKSUM_UNNECESSARY is set for > the assembled packet whereas in GRO we use CHECKSUM_PARTIAL. The > effect of

Re: [PATCH net-next v2 6/6] net: dsa: mv88e6xxx: add support for 6390 VTU

2017-02-17 Thread Andrew Lunn
On Fri, Feb 17, 2017 at 10:05:31AM -0500, Vivien Didelot wrote: > The 6390 family of chips use only 2 of the 3 VTU Data registers to pack > the MemberTag and PortState VLAN data. This means that they must be > written or read before or after each VTU/STU operations. > > Implement this variant to

Re: [PATCH net-next v2 1/3] net: stmicro: prepare dwmac4 core for mtl

2017-02-17 Thread David Miller
From: Joao Pinto Date: Thu, 16 Feb 2017 11:19:39 + > This patch adds the following features: > > a) RX and TX scheduling algorithm configuration (can be configured in the > Device Tree) > b) TX VLAN tag priority configuration (can be configured in the Device Tree) >

Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock

2017-02-17 Thread Cong Wang
On Thu, Feb 16, 2017 at 10:34 PM, wrote: > From: Gao Feng > > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. > These two functions are invoked in qdisc_create, qdisc_change, and > qdisc_destroy which run fully under RTNL. > > So it already

Re: [PATCH] net: bgmac: store MAC address directly in netdev->dev_addr

2017-02-17 Thread David Miller
From: Tobias Klauser Date: Thu, 16 Feb 2017 15:11:19 +0100 > After commit 34a5102c3235 ("net: bgmac: allocate struct bgmac just once > & don't copy it") the mac_addr member of struct bgmac is no longer > necessary to pass the MAC address to bgmac_enet_probe(). Instead it can

Re: [PATCH] dccp: fix freeing skb too early for IPV6_RECVPKTINFO

2017-02-17 Thread David Miller
From: Andrey Konovalov Date: Thu, 16 Feb 2017 17:22:46 +0100 > In the current DCCP implementation an skb for a DCCP_PKT_REQUEST packet > is forcibly freed via __kfree_skb in dccp_rcv_state_process if > dccp_v6_conn_request successfully returns. > > However, if

Re: [PATCH net-next v2 1/3] net: stmicro: prepare dwmac4 core for mtl

2017-02-17 Thread David Miller
From: Joao Pinto Date: Fri, 17 Feb 2017 18:09:06 + > > Hi David, > > Às 6:02 PM de 2/17/2017, David Miller escreveu: >> From: Joao Pinto >> Date: Thu, 16 Feb 2017 11:19:39 + >> >>> This patch adds the following features: >>> >>> a) RX

[PATCH net-next] netvsc: fix typo on statistics

2017-02-17 Thread Stephen Hemminger
From: Simon Xiao Return the correct tx_errors stats in netvsc. Reviewed-by: Haiyang Zhang Signed-off-by: Simon Xiao Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 2 +- 1 file

[PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist.

2017-02-17 Thread David Daney
Some Cavium dev boards have firmware which doesn't supply a proper ethernet-phy-ieee802.3-c22" compatible property. Restore these boards to working order by whitelisting this compatible value. Signed-off-by: David Daney --- drivers/of/of_mdio.c | 1 + 1 file changed, 1

Re: [PATCH net-next 0/3] sfc: misc. fixes

2017-02-17 Thread David Miller
From: Edward Cree Date: Fri, 17 Feb 2017 15:47:32 + > Three largely unrelated fixes to increase robustness in rare edge cases. Series applied, thanks.

Re: net: use-after-free in tw_timer_handler

2017-02-17 Thread Dmitry Vyukov
On Fri, Feb 17, 2017 at 7:51 PM, Cong Wang wrote: > > This code was changed a long time ago : > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ed2e923945892a8372ab70d2f61d364b0b6d9054 > > So I suspect a recent patch

Re: [PATCH net-next] tcp: use page_ref_inc() in tcp_sendmsg()

2017-02-17 Thread David Miller
From: Eric Dumazet Date: Fri, 17 Feb 2017 09:11:42 -0800 > From: Eric Dumazet > > sk_page_frag_refill() allocates either a compound page or an order-0 > page. We can use page_ref_inc() which is slightly faster than get_page() > > Signed-off-by:

[PATCH net-next v2 04/12] net: ethernet: aquantia: Using module_pci_driver.

2017-02-17 Thread Pavel Belous
From: Pavel Belous Remove boilerplate code by using macro module_pci_driver. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff

[PATCH net-next v2 12/12] net: ethernet: aquantia: Copying tx buffers is not needed.

2017-02-17 Thread Pavel Belous
From: Pavel Belous This fix removes copying of tx biffers. Now we use ring->buff_fing directly. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 170 +--

Re: [PATCH net-next v2 4/6] net: dsa: mv88e6xxx: move VTU code to its own file

2017-02-17 Thread Andrew Lunn
On Fri, Feb 17, 2017 at 10:05:29AM -0500, Vivien Didelot wrote: > Move the Global (1) VTU related code to its own file. > > Use this opportunity to provide a cleaner API for the VTU, by renaming a > few underscore prefixed functions, split the data member of the > mv88e6xxx_vtu_entry structure

Re: [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > This seems to be more than renaming a few functions. There looks to be > real changes here. I think these changes should be split out into a > separate patch with an explanation what is being changed. Keep this > patch for plain renames. > > It

[PATCH net-next 7/7] nfp: allow application firmware to limit number of SR-IOV VFs

2017-02-17 Thread Jakub Kicinski
Some application firmware projects may choose to limit the number of VFs available below what is specified in PCI capability to be able to reuse the PCIe interface resources. There may also be projects which use cases don't require SR-IOV support at all and therefore don't want to spend time

[PATCH net-next 0/7] nfp: expose more firmware and hw debug info

2017-02-17 Thread Jakub Kicinski
Hi! This series is mostly a result of flash firmware team requesting access to some of the information and data necessary for debugging firmware problems. Patch 1 adds a missing error message. Patch 2 prints manufacturing info to logs in case PCI VPD capability is not programmed correctly.

[PATCH net-next 1/7] nfp: refactor NSP initialization and add error message

2017-02-17 Thread Jakub Kicinski
When acquiring NSP communication resource fails user is left with "probe failed with error -2" PCI code message but no info on what caused the problem. Some development boards may not have NSP FW in the flash image. Help users with a more verbouse message. While at it move the whole NSP init to

[PATCH net-next 4/7] nfp: report NSP ABI version in ethtool FW version

2017-02-17 Thread Jakub Kicinski
ethtool_drvinfo->fw_version can cantain multiple FW strings. We already report NFD ABI version there, add NSP ABI version if available (i.e. on PF) with 'sp:' prefix. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 4

[PATCH net-next 6/7] nfp: return nfp_rtsym_read_le() errors correctly

2017-02-17 Thread Jakub Kicinski
nfp_rtsym_read_le() has an out parameter for error codes. We have to use that instead of returning errors directly. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c | 8 +--- 1 file changed, 5 insertions(+), 3

Re: net: use-after-free in tw_timer_handler

2017-02-17 Thread Cong Wang
On Fri, Feb 17, 2017 at 12:36 PM, Dmitry Vyukov wrote: > On Fri, Feb 17, 2017 at 7:51 PM, Cong Wang wrote: >> >> This code was changed a long time ago : >> >>

CHECKSUM_UNNECESSARY semantics with driver modified.created packets

2017-02-17 Thread Tom Herbert
Alexei and I were looking at the mlx5 LRO code this morning. One discrepancy I noticed with GRO is that CHECKSUM_UNNECESSARY is set for the assembled packet whereas in GRO we use CHECKSUM_PARTIAL. The effect of using checksum-unnecessary is that the actual TCP checksum in the packet is not correct

Re: [PATCH v3] net/irda: fix lockdep annotation

2017-02-17 Thread Dmitry Vyukov
On Fri, Jan 20, 2017 at 11:53 PM, Dmitry Vyukov wrote: > On Thu, Jan 19, 2017 at 5:27 PM, David Miller wrote: >> From: Dmitry Vyukov >> Date: Thu, 19 Jan 2017 11:05:36 +0100 >> >>> Thanks for looking into it! This particular issue

[PATCH net-next 5/7] nfp: add very basic access to NSP logs

2017-02-17 Thread Jakub Kicinski
Allow dumping "arm.diag" resource with ethtool -w. This resource should contain a text log of the NSP (control processor) application. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 2 +

[PATCH net-next 2/7] nfp: report manufacturing info on load

2017-02-17 Thread Jakub Kicinski
Report card manufacturing information when driver loads. These identify the version of the board and its subcomponents. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH net-next 3/7] nfp: store NSP ABI version in state structure

2017-02-17 Thread Jakub Kicinski
We read the status register on each NSP open, we can store the NSP ABI version in the state structure so that we don't have to read it again. Signed-off-by: Jakub Kicinski --- .../net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c | 27 +++--- 1 file

Re: [PATCH net-next] rtnl: don't account unused struct ifla_port_vsi in rtnl_port_size

2017-02-17 Thread Daniel Borkmann
On 02/17/2017 08:57 PM, David Miller wrote: From: Daniel Borkmann Date: Fri, 17 Feb 2017 01:56:11 +0100 When allocating rtnl dump messages, struct ifla_port_vsi is never dumped, so we can save header plus payload in rtnl_port_size(). Infact, attribute IFLA_PORT_VSI_TYPE

Re: [PATCH net-next v2 1/6] net: dsa: mv88e6xxx: add port mask helper

2017-02-17 Thread Andrew Lunn
On Fri, Feb 17, 2017 at 10:05:26AM -0500, Vivien Didelot wrote: > Add a mv88e6xxx_port_mask() helper to get the bitmask of ports in a > switch chip, that will be used in several features. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn

Re: [PATCH v3] net/irda: fix lockdep annotation

2017-02-17 Thread David Miller
From: Dmitry Vyukov Date: Fri, 17 Feb 2017 22:13:58 +0100 > On Fri, Jan 20, 2017 at 11:53 PM, Dmitry Vyukov wrote: >> On Thu, Jan 19, 2017 at 5:27 PM, David Miller wrote: >>> From: Dmitry Vyukov >>> Date: Thu, 19

Re: [PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist.

2017-02-17 Thread David Daney
On 02/17/2017 12:09 PM, Florian Fainelli wrote: On 02/17/2017 12:04 PM, David Daney wrote: Some Cavium dev boards have firmware which doesn't supply a proper ethernet-phy-ieee802.3-c22" compatible property. Restore these boards to working order by whitelisting this compatible value.

Re: [PATCHv2, 1/1] tcp: accommodate sequence number to a peer's shrunk receive window caused by precision loss in window scaling

2017-02-17 Thread David Miller
From: "Cui, Cheng" Date: Fri, 17 Feb 2017 17:04:55 + > Prevent sending out a left-shifted sequence number from a Linux sender in > response to a peer's shrunk receive-window caused by losing least significant > bits in window-scaling. > > Cc: "David S. Miller"

[PATCH net-next v2 11/12] net: ethernet: aquantia: Fixed memory allocation if AQ_CFG_RX_FRAME_MAX > 1 page.

2017-02-17 Thread Pavel Belous
From: Pavel Belous We should allocate the number of pages based on the config parameter AQ_CFG_RX_FRAME_MAX. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 4 ++--

[PATCH net-next v2 09/12] net: ethernet: aquantia: Call netdev_register after all initialized.

2017-02-17 Thread Pavel Belous
From: Pavel Belous netdev_register should be called when everything is initialized. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

[PATCH net-next v2 10/12] net: ethernet: aquantia: Fixed incorrect buff->len calculation.

2017-02-17 Thread Pavel Belous
From: Pavel Belous rxd_wb->pkt_len is the total length of the packet. If we received a large packet (with length > AQ_CFG_RX_FRAME_MAX) then we will get multiple buffers. We need to fix the length of the last buffer. Signed-off-by: Pavel Belous

[PATCH net-next v2 07/12] net: ethernet: aquantia: Using NETDEV_TX_OK instead 0.

2017-02-17 Thread Pavel Belous
From: Pavel Belous Use NETDEV_TX_OK as the return value for successful transmission. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next v2 08/12] net: ethernet: aquantia: Null pointer check for aq_nic_ndev_alloc.

2017-02-17 Thread Pavel Belous
From: Pavel Belous We should check for a null pointer for aq_nic_ndev_alloc instead netdev_priv. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[PATCH net-next v2 00/12] net: ethernet: aquantia: improvements and fixes

2017-02-17 Thread Pavel Belous
From: Pavel Belous The following patchset contains improvements and fixes for aQuantia AQtion ethernet driver from net-next tree. Most fixes are based on the comments from Lino Sanfilippo. Sanity testing was performed on real HW. No regression found. v1->v2 :Removed

[PATCH net-next v2 05/12] net: ethernet: aquantia: Superfluous initialization of "err".

2017-02-17 Thread Pavel Belous
From: Pavel Belous Fixed superfluous initialization of err. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git

[PATCH net-next v2 03/12] net: ethernet: aquantia: Removed unnecessary comparsion "old_mtu == new_mtu".

2017-02-17 Thread Pavel Belous
From: Pavel Belous This check is not needed. Function aq_ndev_change_mtu wont be called if mtu has not changed. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 6 ++ 1 file changed, 2 insertions(+), 4

[PATCH net-next v2 02/12] net: ethernet: aquantia: Removed busy_count field.

2017-02-17 Thread Pavel Belous
From: Pavel Belous busy_count field and is_busy flag is not needed at all. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 11 --- drivers/net/ethernet/aquantia/atlantic/aq_utils.h | 1 - 2

[PATCH net-next v2 01/12] net: ethernet: aquantia: Removed extra assignment for skb->dev.

2017-02-17 Thread Pavel Belous
From: Pavel Belous This assignment is not needed. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c

[PATCH net-next v2 06/12] net: ethernet: aquantia: Fixed missing rtnl_unlock.

2017-02-17 Thread Pavel Belous
From: Pavel Belous rtnl_unlock should be called if error occurred. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: add support for 6390 ATU Move

2017-02-17 Thread Andrew Lunn
On Fri, Feb 17, 2017 at 10:05:28AM -0500, Vivien Didelot wrote: > The 6390 family of Marvell chips uses 5 bits to describe the ToPort and > FromPort values of PortVec in the ATU Move operation, while older > switches use 0xf. Hi Vivien Since you say 5 bits for 6390, it would be better to say 4

Re: [PATCH net-next v2 5/6] net: dsa: mv88e6xxx: add VTU ops

2017-02-17 Thread Andrew Lunn
On Fri, Feb 17, 2017 at 10:05:30AM -0500, Vivien Didelot wrote: > Because there are several variant of the VTU operations and because > checking for the presence of an STU is not enough, add new ops to the > info structure to describe the VTU operations that a chip supports. > > Signed-off-by:

Re: [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread Andrew Lunn
> Note that we are very close from 4.10, so unless there is a major issue > in the patchset, I'd prefer not to respin new versions. I'd gladly send > cosmetics fixup later though. I'm waiting for this patchset to land in > net-next to send the second one ready for cross-chip bridging in DSA. I

[PATCH net-next 0/3] sfc: misc. fixes

2017-02-17 Thread Edward Cree
Three largely unrelated fixes to increase robustness in rare edge cases. Bert Kenward (1): sfc: forget filters from sw table if hw replies ENOENT on removing them Jon Cooper (1): sfc: fix filter_id misinterpretation in edge case Peter Dunning (1): sfc: do not device_attach if a reset

[PATCH net-next 1/3] sfc: fix filter_id misinterpretation in edge case

2017-02-17 Thread Edward Cree
From: Jon Cooper On EF10, hardware filter IDs are 13 bits, but in some places we store 32-bit "full filter IDs" in which higher order bits encode the filter match-priority. This could cause a filter to have a full filter ID of 0x, which is also the value

[PATCH net-next 2/3] sfc: forget filters from sw table if hw replies ENOENT on removing them

2017-02-17 Thread Edward Cree
From: Bert Kenward If the hw doesn't think they exist, we should defer to its authority. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/ef10.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[PATCH net-next 3/3] sfc: do not device_attach if a reset is pending

2017-02-17 Thread Edward Cree
From: Peter Dunning efx_start_all can return without initialising queues as a reset is pending. This means that when netif_device_attach is called, the kernel can start sending traffic without having an initialised TX queue to send to. This patch avoids this by not

Re: [PATCH][CFT] Saner error handling in skb_copy_datagram_iter() et.al.

2017-02-17 Thread David Miller
From: Al Viro Date: Tue, 14 Feb 2017 01:33:06 + > OK... Remaining interesting question is whether it adds a noticable > overhead. Could somebody try it on assorted benchmarks and see if > it slows the things down? The patch in question follows: That's about a 40

Re: [PATCH net-next] mlx4: do not fire tasklet unless necessary

2017-02-17 Thread David Miller
From: Eric Dumazet Date: Fri, 10 Feb 2017 04:27:58 -0800 > From: Eric Dumazet > > All rx and rx netdev interrupts are handled by respectively > by mlx4_en_rx_irq() and mlx4_en_tx_irq() which simply schedule a NAPI. > > But mlx4_eq_int() also fires

Re: [PATCH v3 net-next 00/14] mlx4: order-0 allocations and page recycling

2017-02-17 Thread David Miller
From: Eric Dumazet Date: Mon, 13 Feb 2017 11:58:44 -0800 > As mentioned half a year ago, we better switch mlx4 driver to order-0 > allocations and page recycling. > > This reduces vulnerability surface thanks to better skb->truesize > tracking and provides better

Re: [PATCH v2 0/4] PTP attribute handling cleanup

2017-02-17 Thread David Miller
From: Richard Cochran Date: Thu, 16 Feb 2017 21:19:29 +0100 > On Tue, Feb 14, 2017 at 10:23:30AM -0800, Dmitry Torokhov wrote: >> drivers/ptp/ptp_clock.c | 22 +++--- >> drivers/ptp/ptp_private.h | 7 +- >> drivers/ptp/ptp_sysfs.c | 167 >>

Re: [PATCH] net: nvidia: forcedeth: use new api ethtool_{get|set}_link_ksettings

2017-02-17 Thread David Miller
From: Philippe Reynes Date: Tue, 14 Feb 2017 23:36:32 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

[PATCH net-next v2 2/6] net: dsa: mv88e6xxx: move ATU code in its own file

2017-02-17 Thread Vivien Didelot
Move the Global (1) ATU related code in its own file, and export the necessary primitives. Use that opportunity to provide a cleaner API for the ATU, by renaming a few underscore prefixed functions, and members of the mv88e6xxx_atu_entry structures. Signed-off-by: Vivien Didelot

[PATCH net-next v2 0/6] net: dsa: mv88e6xxx: 88E6390 ATU/VTU

2017-02-17 Thread Vivien Didelot
This series adds support to 88E6390 for the ATU (MAC address databases) and VTU (VLAN databases), as well as providing a cleaner API for both. The 6390 family of Marvell switch chip handles the ATU Move operation differently and has a different usage of the VTU Data registers. v2: remove unsused

[PATCH net-next v2 4/6] net: dsa: mv88e6xxx: move VTU code to its own file

2017-02-17 Thread Vivien Didelot
Move the Global (1) VTU related code to its own file. Use this opportunity to provide a cleaner API for the VTU, by renaming a few underscore prefixed functions, split the data member of the mv88e6xxx_vtu_entry structure into membership (for 802.1q) and port state (for 802.1s) members, and add a

Re: [RFC] TCP_NOTSENT_LOWAT behavior

2017-02-17 Thread Eric Dumazet
On Thu, 2017-02-16 at 23:07 -0800, Eric Dumazet wrote: > This adds a cost to fast path. tcp_sendmsg() is insane. > > We have one skb granularity (64KB) already for SO_SNDBUF, regardless of > TCP_NOTSENT_LOWAT being used or not. Note that this granularity is wanted for performance, otherwise our

Re: RFC: unit tests for kernel GTP module

2017-02-17 Thread Andreas Schultz
Hi, - On Feb 16, 2017, at 11:08 PM, laforge lafo...@gnumonks.org wrote: > Dear GTP-interested folks, > > I would love to somehow get towards some degree of unit testing (or even > "continuous integration") for teh kernel GTP code. > > We currently have the original code in the kernel, we

[PATCH net-next v2 6/6] net: dsa: mv88e6xxx: add support for 6390 VTU

2017-02-17 Thread Vivien Didelot
The 6390 family of chips use only 2 of the 3 VTU Data registers to pack the MemberTag and PortState VLAN data. This means that they must be written or read before or after each VTU/STU operations. Implement this variant to add support for VTU with such chips. Signed-off-by: Vivien Didelot

[PATCH net-next v2 3/6] net: dsa: mv88e6xxx: add support for 6390 ATU Move

2017-02-17 Thread Vivien Didelot
The 6390 family of Marvell chips uses 5 bits to describe the ToPort and FromPort values of PortVec in the ATU Move operation, while older switches use 0xf. Add an atu_move_port_mask member in the info structure to describe that. Signed-off-by: Vivien Didelot

[PATCH net-next v2 1/6] net: dsa: mv88e6xxx: add port mask helper

2017-02-17 Thread Vivien Didelot
Add a mv88e6xxx_port_mask() helper to get the bitmask of ports in a switch chip, that will be used in several features. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 5 + drivers/net/dsa/mv88e6xxx/port.c | 2 +- 2 files

[PATCH net-next v2 5/6] net: dsa: mv88e6xxx: add VTU ops

2017-02-17 Thread Vivien Didelot
Because there are several variant of the VTU operations and because checking for the presence of an STU is not enough, add new ops to the info structure to describe the VTU operations that a chip supports. Signed-off-by: Vivien Didelot ---

[PATCH] vmxnet3: prevent building with 64K pages

2017-02-17 Thread Arnd Bergmann
I got a warning about broken code on ARM64 with 64K pages: drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_init': drivers/net/vmxnet3/vmxnet3_drv.c:1679:29: error: large integer implicitly truncated to unsigned type [-Werror=overflow] rq->buf_info[0][i].len = PAGE_SIZE; 'len'

Re: [PATCH net-next v2 2/2] net: mvneta: Use cacheable memory to store the rx buffer DMA address

2017-02-17 Thread Gregory CLEMENT
Hi Thomas, On ven., févr. 17 2017, Thomas Petazzoni wrote: > Does not make sense, because it's not the SW that refills the RX > descriptors with the address of the RX buffers. It's done by the HW. > > With HWBM, I believe you have no choice but to read

[PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling s/wrtie_addr/write_addr/

2017-02-17 Thread Geert Uytterhoeven
As per symmetry with _rtl8821ae_dbi_read(), "wrtie" is not a funky register acronym, but a simple misspelling of "write". Signed-off-by: Geert Uytterhoeven Cc: Larry Finger Cc: Chaoming Li Cc:

Re: [PATCH 1/1] tcp: accommodate sequence number to a peer's shrunk receive window caused by precision loss in window scaling

2017-02-17 Thread David Miller
From: "Cui, Cheng" Date: Tue, 14 Feb 2017 23:14:59 + > This updates tcp_acceptable_seq(), one of the oldest functions since 2.4.0, by > preventing sending out a left-shifted sequence number from a Linux sender in > response to a peer's shrunk receive-window caused by

Re: Autoneg off in TI cpsw driver

2017-02-17 Thread Sriram V
Hi Andrew, The following is the output of the ethtool and iplink. After turning off the autoneg - The Plugin is not detected. Let me know if this is a general behaviour or a bug in cpsw driver. root@am437xevm:/ # ethtool eth1 Settings for eth1: Supported ports: [ TP AUI BNC MII FIBRE ]

Re: [PATCH v3 net] packet: Do not call fanout_release from atomic contexts

2017-02-17 Thread David Miller
From: Anoob Soman Date: Wed, 15 Feb 2017 20:25:39 + > Commit 6664498280cf ("packet: call fanout_release, while UNREGISTERING a > netdev"), unfortunately, introduced the following issues. ... > To fix the above problems, remove the call to fanout_release() under >

Re: [PATCH] net: ethernet: ti: cpsw: correct ale dev to cpsw

2017-02-17 Thread David Miller
From: Ivan Khoronzhuk Date: Wed, 15 Feb 2017 19:45:02 +0200 > The ale is a property of cpsw, so change dev to cpsw->dev, > aka pdev->dev, to be consistent. > > Signed-off-by: Ivan Khoronzhuk > --- > Based on net-next/master Applied,

Re: [PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling s/wrtie_addr/write_addr/

2017-02-17 Thread Larry Finger
On 02/17/2017 09:36 AM, Geert Uytterhoeven wrote: As per symmetry with _rtl8821ae_dbi_read(), "wrtie" is not a funky register acronym, but a simple misspelling of "write". Signed-off-by: Geert Uytterhoeven Cc: Larry Finger Cc: Chaoming Li

Re: [PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling s/wrtie_addr/write_addr/

2017-02-17 Thread Geert Uytterhoeven
Hi Larry, On Fri, Feb 17, 2017 at 5:14 PM, Larry Finger wrote: > On 02/17/2017 09:36 AM, Geert Uytterhoeven wrote: >> As per symmetry with _rtl8821ae_dbi_read(), "wrtie" is not a funky >> register acronym, but a simple misspelling of "write". >> >> Signed-off-by: Geert

Re: [net-next 06/14] ixgbe: Update driver to make use of DMA attributes in Rx path

2017-02-17 Thread Alexander Duyck
On Thu, Feb 16, 2017 at 11:27 PM, maowenan wrote: > > >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] >> On Behalf Of Jeff Kirsher >> Sent: Thursday, February 16, 2017 8:51 PM >> To: da...@davemloft.net >> Cc:

Re: pull-request: wireless-drivers-next 2017-02-17

2017-02-17 Thread David Miller
From: Kalle Valo Date: Thu, 16 Feb 2017 15:41:13 +0200 > few -next patches I'm still hoping to get to 4.11 to keep my backlog > short, nothing major here. Please let me know if there are any problems. Pulled, thanks Kalle.

Re: [PATCH] net/utils: fix semicolon.cocci warnings

2017-02-17 Thread Keith Busch
On Fri, Feb 17, 2017 at 01:52:54PM -0500, David Miller wrote: > From: kbuild test robot > Date: Fri, 17 Feb 2017 05:34:03 +0800 > > > net/core/utils.c:388:2-3: Unneeded semicolon > > > > > > Remove unneeded semicolon. > > > > Generated by:

[PATCH net] vxlan: fix oops in dev_fill_metadata_dst

2017-02-17 Thread Paolo Abeni
Since the commit 0c1d70af924b ("net: use dst_cache for vxlan device") vxlan_fill_metadata_dst() calls vxlan_get_route() passing a NULL dst_cache pointer, so the latter should explicitly check for valid dst_cache ptr. Unfortunately the commit d71785ffc7e7 ("net: add dst_cache to ovs vxlan

Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock

2017-02-17 Thread Eric Dumazet
On Fri, 2017-02-17 at 10:02 -0800, Cong Wang wrote: > On Thu, Feb 16, 2017 at 10:34 PM, wrote: > > From: Gao Feng > > > > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. > > These two functions are invoked in qdisc_create, qdisc_change, and >

Re: [PATCH net] vxlan: fix oops in dev_fill_metadata_dst

2017-02-17 Thread Jiri Benc
On Fri, 17 Feb 2017 19:14:27 +0100, Paolo Abeni wrote: > Since the commit 0c1d70af924b ("net: use dst_cache for vxlan device") > vxlan_fill_metadata_dst() calls vxlan_get_route() passing a NULL > dst_cache pointer, so the latter should explicitly check for > valid dst_cache ptr. Unfortunately the

Re: [PATCH net-next (repost)] nfp: Use PCI_DEVICE_ID_NETRONOME_NFP* defines

2017-02-17 Thread Jakub Kicinski
On Fri, 17 Feb 2017 08:57:54 +0100, Simon Horman wrote: > Use PCI_DEVICE_ID_NETRONOME_NFP*, defined in linux/pci_ids.h, > rather than replicating the same values in the NFP driver. > > Signed-off-by: Simon Horman Perhaps unnecessary and obvious but this was:

Re: [PATCH net-next 0/3] Misc BPF improvements

2017-02-17 Thread David Miller
From: Daniel Borkmann Date: Thu, 16 Feb 2017 22:24:47 +0100 > This last series for this window adds various misc > improvements to BPF, one is to mark registered map and > prog types as __ro_after_init, another one for removing > cBPF stubs in eBPF JITs and moving the stub

Re: [PATCH] net: qlogic: netxen: use new api ethtool_{get|set}_link_ksettings

2017-02-17 Thread David Miller
From: Philippe Reynes Date: Thu, 16 Feb 2017 23:28:01 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: hamachi: use new api ethtool_{get|set}_link_ksettings

2017-02-17 Thread David Miller
From: Philippe Reynes Date: Thu, 16 Feb 2017 22:46:14 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH net-next] netvsc: fix typo on statistics

2017-02-17 Thread David Miller
From: Stephen Hemminger Date: Fri, 17 Feb 2017 11:36:20 -0800 > From: Simon Xiao > > Return the correct tx_errors stats in netvsc. > > Reviewed-by: Haiyang Zhang > Signed-off-by: Simon Xiao >

Re: [PATCH] net: ethoc: Use eth_hw_addr_random()

2017-02-17 Thread David Miller
From: Tobias Klauser Date: Thu, 16 Feb 2017 13:54:32 +0100 > Use eth_hw_addr_random() to set a random dev_addr and update > addr_assign_type instead of open-coding it. > > Signed-off-by: Tobias Klauser Applied to net-next, thanks.

Re: [PATCH] rtlwifi: rtl8723bs: Add firmware for new driver

2017-02-17 Thread Kyle McMartin
On Thu, Jan 19, 2017 at 03:04:27PM -0600, Larry Finger wrote: > This driver is being added for Fedora users, and will then be added > to the mainline kernel. > > Signed-off-by: Larry Finger > c: Hans de Goede Applied.

Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock

2017-02-17 Thread David Miller
From: f...@ikuai8.com Date: Fri, 17 Feb 2017 14:34:19 +0800 > From: Gao Feng > > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. > These two functions are invoked in qdisc_create, qdisc_change, and > qdisc_destroy which run fully under RTNL. > > So it already

Re: [PATCH net-next] rxrpc: Change module filename to rxrpc.ko

2017-02-17 Thread David Miller
From: David Howells Date: Fri, 17 Feb 2017 18:16:21 + > Change module filename from af-rxrpc.ko to rxrpc.ko so as to be consistent > with the other protocol drivers. > > Also adjust the documentation to reflect this. > > Further, there is no longer a standalone rxkad

Re: [PATCH] of_mdio: Add "broadcom,bcm5241" to the whitelist.

2017-02-17 Thread Florian Fainelli
On 02/17/2017 12:04 PM, David Daney wrote: > Some Cavium dev boards have firmware which doesn't supply a proper > ethernet-phy-ieee802.3-c22" compatible property. Restore these boards > to working order by whitelisting this compatible value. > > Signed-off-by: David Daney

Re: [PATCH net] sctp: check duplicate node before inserting a new transport

2017-02-17 Thread David Miller
From: Xin Long Date: Fri, 17 Feb 2017 16:35:24 +0800 > + list = rhltable_lookup(_transport_hashtable, , > +sctp_hash_params); > + > + rhl_for_each_entry_rcu(transport, tmp, list, node) > + if (transport->asoc->ep ==

Re: [PATCH net-next (repost)] nfp: Use PCI_DEVICE_ID_NETRONOME_NFP* defines

2017-02-17 Thread David Miller
From: Simon Horman Date: Fri, 17 Feb 2017 08:57:54 +0100 > Use PCI_DEVICE_ID_NETRONOME_NFP*, defined in linux/pci_ids.h, > rather than replicating the same values in the NFP driver. > > Signed-off-by: Simon Horman > > --- > * Reposted

Re: [PATCHv2, 1/1] tcp: accommodate sequence number to a peer's shrunk receive window caused by precision loss in window scaling

2017-02-17 Thread Eric Dumazet
On Fri, 2017-02-17 at 17:04 +, Cui, Cheng wrote: > Prevent sending out a left-shifted sequence number from a Linux sender in > response to a peer's shrunk receive-window caused by losing least significant > bits in window-scaling. > > Cc: "David S. Miller" > Cc: Alexey

[PATCH net-next] rxrpc: Change module filename to rxrpc.ko

2017-02-17 Thread David Howells
Change module filename from af-rxrpc.ko to rxrpc.ko so as to be consistent with the other protocol drivers. Also adjust the documentation to reflect this. Further, there is no longer a standalone rxkad module, as it has been merged into the rxrpc core, so get rid of references to that.

Re: RFC: unit tests for kernel GTP module

2017-02-17 Thread Harald Welte
Hi Andreas, On Fri, Feb 17, 2017 at 04:02:59PM +0100, Andreas Schultz wrote: > The test suite is proprietary, so we can only share the results but > not the test setup itself. it would be great to have some CI setup where both current stable as well as a development branch of the code is tested,

Re: [PATCH net-next] rtnl: don't account unused struct ifla_port_vsi in rtnl_port_size

2017-02-17 Thread David Miller
From: Daniel Borkmann Date: Fri, 17 Feb 2017 01:56:11 +0100 > When allocating rtnl dump messages, struct ifla_port_vsi is never dumped, > so we can save header plus payload in rtnl_port_size(). Infact, attribute > IFLA_PORT_VSI_TYPE and struct ifla_port_vsi are not used

Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock

2017-02-17 Thread Eric Dumazet
On Fri, 2017-02-17 at 14:34 +0800, f...@ikuai8.com wrote: > From: Gao Feng > > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab. > These two functions are invoked in qdisc_create, qdisc_change, and > qdisc_destroy which run fully under RTNL. > > So it already

Re: net: use-after-free in tw_timer_handler

2017-02-17 Thread Cong Wang
On Wed, Feb 8, 2017 at 9:36 AM, Dmitry Vyukov wrote: > On Tue, Jan 24, 2017 at 4:52 PM, Eric Dumazet wrote: >> On Tue, Jan 24, 2017 at 7:06 AM, Dmitry Vyukov wrote: This code was changed a long time ago :

  1   2   >