Re: [RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers

2017-03-13 Thread Nicolas Pitre
On Mon, 13 Mar 2017, Arnd Bergmann wrote: > On Mon, Mar 13, 2017 at 9:09 PM, Nicolas Pitre > wrote: > > On Mon, 13 Mar 2017, Arnd Bergmann wrote: > > > >> With posix timers having become optional, we get a build error with > >> the cpts time sync option of the CPSW

Re: [PATCH v2] VLAN, support ingress/egress priority map flushing

2017-03-13 Thread Thierry Du Tre
On 13-03-17 16:28, Eric Dumazet wrote: On Mon, 2017-03-13 at 15:36 +0100, Thierry Du Tre wrote: +void vlan_dev_flush_egress_priority(const struct net_device *dev) +{ + struct vlan_dev_priv *vlan = vlan_dev_priv(dev); + struct vlan_priority_tci_mapping *mp; + int i; + +

Re: [net-next sample action optimization 2/3] openvswitch: Refactor recirc key allocation.

2017-03-13 Thread Joe Stringer
On 10 March 2017 at 16:51, Andy Zhou wrote: > The logic of allocating and copy key for each 'exec_actions_level' > was specific to execute_recirc(). However, future patches will reuse > as well. Refactor the logic into its own function clone_key(). > > Signed-off-by: Andy Zhou

Re: [PATCH v2] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-13 Thread David Arcari
On 03/10/2017 04:19 PM, Pavel Belous wrote: > > > On 10.03.2017 17:47, David Arcari wrote: >> Hi, >> >> On 03/09/2017 05:43 PM, Lino Sanfilippo wrote: >>> Hi, >>> >>> On 09.03.2017 22:03, David Arcari wrote: When the aquantia device mtu is changed the net_device structure is not

Re: [PATCH net-next v3 0/2] mpls: allow TTL propagation to/from IP packets to be configured

2017-03-13 Thread Roopa Prabhu
On 3/10/17, 12:43 PM, Robert Shearman wrote: > It is sometimes desirable to present an MPLS transport network as a > single hop to traffic transiting it because it prevents confusion when > diagnosing failures. An example of where confusion can be generated is > when addresses used in the provider

Re: [RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers

2017-03-13 Thread Arnd Bergmann
On Mon, Mar 13, 2017 at 9:09 PM, Nicolas Pitre wrote: > On Mon, 13 Mar 2017, Arnd Bergmann wrote: > >> With posix timers having become optional, we get a build error with >> the cpts time sync option of the CPSW driver: >> >> drivers/net/ethernet/ti/cpts.c: In function

Re: [RFC v1 for accelerated IPoIB 25/25] mlx5_ib: skeleton for mlx5_ib to support ipoib_ops

2017-03-13 Thread Jason Gunthorpe
On Mon, Mar 13, 2017 at 08:31:36PM +0200, Erez Shitrit wrote: > +struct net_device *mlx5_alloc_rdma_netdev(struct ib_device *hca, > + u8 port_num, > + enum rdma_netdev_t type, > + const char *name,

Re: [PATCH net-next] mlx4: Better use of order-0 pages in RX path

2017-03-13 Thread Alexei Starovoitov
On Mon, Mar 13, 2017 at 11:58:05AM -0700, Eric Dumazet wrote: > On Mon, Mar 13, 2017 at 11:31 AM, Alexei Starovoitov > wrote: > > On Mon, Mar 13, 2017 at 10:50:28AM -0700, Eric Dumazet wrote: > >> On Mon, Mar 13, 2017 at 10:34 AM, Alexei Starovoitov > >>

Re: [net-next sample action optimization 3/3] openvswitch: Optimize sample action for the clone use cases

2017-03-13 Thread Andy Zhou
Thanks for the review. Please see comments inline. On Mon, Mar 13, 2017 at 12:08 AM, Pravin Shelar wrote: > On Fri, Mar 10, 2017 at 4:51 PM, Andy Zhou wrote: >> With the introduction of open flow 'clone' action, the OVS user space >> can now translate the 'clone'

Re: [4.10+] sctp lockdep trace

2017-03-13 Thread Marcelo Ricardo Leitner
On Mon, Mar 13, 2017 at 05:10:45PM -0300, Marcelo Ricardo Leitner wrote: > On Fri, Feb 24, 2017 at 05:21:10PM -0500, Dave Jones wrote: > > [ 244.251557] === > > [ 244.263321] [ ERR: suspicious RCU usage. ] > > [ 244.274982] 4.10.0-think+ #7 Not tainted > > [

Re: [RFC v1 for accelerated IPoIB 05/25] IB/ipoib: Support ipoib acceleration options callbacks

2017-03-13 Thread Jason Gunthorpe
On Mon, Mar 13, 2017 at 08:31:16PM +0200, Erez Shitrit wrote: > TODO: We added remote qkey to ipoib_send in order to match send op > signature. > In accel mode this param will be used but in regular mode this param is > redundant. Need to think about better solution. The flow is backwards, in

Re: [4.10+] sctp lockdep trace

2017-03-13 Thread Marcelo Ricardo Leitner
On Fri, Feb 24, 2017 at 05:21:10PM -0500, Dave Jones wrote: > [ 244.251557] === > [ 244.263321] [ ERR: suspicious RCU usage. ] > [ 244.274982] 4.10.0-think+ #7 Not tainted > [ 244.286511] --- > [ 244.298008]

Re: [RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers

2017-03-13 Thread Nicolas Pitre
On Mon, 13 Mar 2017, Arnd Bergmann wrote: > With posix timers having become optional, we get a build error with > the cpts time sync option of the CPSW driver: > > drivers/net/ethernet/ti/cpts.c: In function 'cpts_find_ts': > drivers/net/ethernet/ti/cpts.c:291:23: error: implicit declaration of

Re: [PATCH net-next v5 0/7] gtp: misc improvements

2017-03-13 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 13 Mar 2017 17:48:12 +0100 > On Thu, Mar 09, 2017 at 05:42:55PM +0100, Andreas Schultz wrote: >> Hi Pablo, >> >> This is a resent of last series that missed the merge window. There >> are no changes compared to v4. >> >> v4: Compared to

Re: [PATCH net] bridge: drop netfilter fake rtable unconditionally

2017-03-13 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 13 Mar 2017 17:51:24 +0100 > I also love this bridge netfilter Frankenstein a lot. Looking forward > you kill this via native bridge conntrack support for nf_tables. Indeed, Florian, you will be my hero if you can remove fake_rtable :-)

Re: [RFC v1 for accelerated IPoIB 04/25] IB/verb: Add ipoib_options struct and API

2017-03-13 Thread Jason Gunthorpe
On Mon, Mar 13, 2017 at 08:31:15PM +0200, Erez Shitrit wrote: > diff --git a/include/rdma/ib_ipoib_accel_ops.h > b/include/rdma/ib_ipoib_accel_ops.h > new file mode 100644 > index ..148a5529a559 > +++ b/include/rdma/ib_ipoib_accel_ops.h Both patches need a better naming scheme for

Re: [PATCH net] bridge: drop netfilter fake rtable unconditionally

2017-03-13 Thread David Miller
From: Florian Westphal Date: Mon, 13 Mar 2017 17:38:17 +0100 > Andreas reports kernel oops during rmmod of the br_netfilter module. > Hannes debugged the oops down to a NULL rt6info->rt6i_indev. > > Problem is that br_netfilter has the nasty concept of adding a fake > rtable to

[PATCH net-next] liquidio: use meaningful names for IRQs

2017-03-13 Thread Felix Manlunas
From: Rick Farrington All IRQs owned by the PF and VF drivers share the same nondescript name "octeon"; this makes it difficult to setup interrupt affinity. Change the IRQ names to reflect their specific purpose: LiquidIO--- Examples:

Re: [PATCH net-next RFC v1 00/27] afnetns: new namespace type for separation on protocol level

2017-03-13 Thread Michael Kerrisk
[CC += linux-...@vger.kernel.org] Hannes, Since this is a kernel-user-space API change, please CC linux-api@ (and on future iterations of the series). The kernel source file Documentation/SubmitChecklist notes that all Linux kernel patches that change userspace interfaces should be CCed to

Re: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-13 Thread David Miller
From: David Arcari Date: Mon, 13 Mar 2017 11:50:50 -0400 > On 03/13/2017 02:09 AM, David Miller wrote: >> From: David Arcari >> Date: Wed, 8 Mar 2017 16:33:21 -0500 >> >>> When the aquantia device mtu is changed the net_device structure is not >>>

Re: [PATCH nf] ipv6: avoid write to a possibly cloned skb

2017-03-13 Thread David Miller
From: Florian Westphal Date: Mon, 13 Mar 2017 16:24:28 +0100 > ip6_fragment, in case skb has a fraglist, checks if the > skb is cloned. If it is, it will move to the 'slow path' and allocates > new skbs for each fragment. > > However, right before entering the slowpath loop, it

Re: [RFC PATCH] sock: add SO_RCVQUEUE_SIZE getsockopt

2017-03-13 Thread David Miller
From: Josh Hunt Date: Mon, 13 Mar 2017 12:38:39 -0500 > On 03/13/2017 11:12 AM, Eric Dumazet wrote: >> On Mon, Mar 13, 2017 at 8:59 AM, Josh Hunt wrote: >>> Allows application to read the amount of data sitting in the receive >>> queue. >>> >>>

Re: [PATCH] net: wimax/i2400m: fix NULL-deref at probe

2017-03-13 Thread David Miller
From: Johan Hovold Date: Mon, 13 Mar 2017 13:42:03 +0100 > Make sure to check the number of endpoints to avoid dereferencing a > NULL-pointer or accessing memory beyond the endpoint array should a > malicious device lack the expected endpoints. > > The endpoints are

Re: [PATCH] isdn/gigaset: fix NULL-deref at probe

2017-03-13 Thread David Miller
From: Johan Hovold Date: Mon, 13 Mar 2017 13:39:01 +0100 > Make sure to check the number of endpoints to avoid dereferencing a > NULL-pointer should a malicious device lack endpoints. > > Fixes: cf7776dc05b8 ("[PATCH] isdn4linux: Siemens Gigaset drivers - > direct USB

Re: [PATCH 2/2] ARM: dts: am335x-icev2: Add CPSW ethernet0 and ethernet1

2017-03-13 Thread Grygorii Strashko
On 03/13/2017 08:42 AM, Roger Quadros wrote: Enable the 2 ethernet ports as CPSW ports in dual-mac mode Signed-off-by: Roger Quadros [nsek...@ti.com: use AM33XX_IOPAD()] Signed-off-by: Sekhar Nori --- arch/arm/boot/dts/am335x-icev2.dts | 113

[PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time

2017-03-13 Thread Vivien Didelot
The ATU ageing time value programmed in the switch is rounded up to the nearest multiple of its coefficient (variable depending on the model.) Add a debug message to inform the user about the exact programmed value. On 6352, "brctl setageing br0 18" gives "AgeTime set to 0x01 (15000 ms)" while

[PATCH net-next] net: dsa: mv88e6xxx: set out of range ageing time

2017-03-13 Thread Vivien Didelot
The minimum and maximum value of the ATU Age Time varies depending on the switch model. The current code returns -ERANGE for out-of-range values, and makes switchdev commit phase fail with this stacktrace: # brctl setageing br0 4 [ 8530.082179] WARNING: CPU: 0 PID: 910 at

Re: [PATCH net] ipv6: make ECMP route replacement less greedy

2017-03-13 Thread David Miller
From: Sabrina Dubroca Date: Mon, 13 Mar 2017 13:28:09 +0100 > Commit 27596472473a ("ipv6: fix ECMP route replacement") introduced a > loop that removes all siblings of an ECMP route that is being > replaced. However, this loop doesn't stop when it has replaced > siblings,

Re: [PATCH v4] Enable tx timestamping on loopback and dummy

2017-03-13 Thread David Miller
From: Ezequiel Lara Gomez Date: Mon, 13 Mar 2017 11:16:10 + > > From aef15784aecbf6cb08d181eca6186fe7d2261771 Mon Sep 17 00:00:00 2001 > From: Ezequiel Lara Gomez > Date: Sat, 11 Mar 2017 20:06:54 + > Subject: [PATCH v4] Enable tx timestamping

Re: [PATCH] net: stmmac: set default number of rx and tx queues in stmmac_pci

2017-03-13 Thread David Miller
From: Joao Pinto Date: Mon, 13 Mar 2017 10:07:07 + > This patch configures default number of RX and TX queues when > using the pci glue driver. > > Signed-off-by: Joao Pinto This is a net-next specific patch, you must the target tree properly

Re: [PATCH] net: stmmac: set default number of rx and tx queues in stmmac_pci

2017-03-13 Thread David Miller
From: Joao Pinto Date: Mon, 13 Mar 2017 10:07:07 + > This patch configures default number of RX and TX queues when > using the pci glue driver. > > Signed-off-by: Joao Pinto Applied.

[PATCH net-next] liquidio: remove/replace invalid code

2017-03-13 Thread Felix Manlunas
From: Rick Farrington Remove invalid call to dma_sync_single_for_cpu() because previous DMA allocation was coherent--not streaming. Remove code that references fields in struct list_head; replace it with calls to list_empty() and list_first_entry(). Also, add

Re: [PATCH net-next] mlx4: Better use of order-0 pages in RX path

2017-03-13 Thread Eric Dumazet
On Mon, Mar 13, 2017 at 11:31 AM, Alexei Starovoitov wrote: > On Mon, Mar 13, 2017 at 10:50:28AM -0700, Eric Dumazet wrote: >> On Mon, Mar 13, 2017 at 10:34 AM, Alexei Starovoitov >> wrote: >> > On Sun, Mar 12, 2017 at 05:58:47PM -0700,

Re: Legacy features in PCI Express devices

2017-03-13 Thread Bjorn Helgaas
On Mon, Mar 13, 2017 at 05:10:57PM +0100, Mason wrote: > Hello, > > There are two revisions of our PCI Express controller. > > Rev 1 did not support the following features: > > 1) legacy PCI interrupt delivery (INTx signals) > 2) I/O address space > > Internally, someone stated that such

Re: [PATCH] x86-32: fix tlb flushing when lguest clears PGE

2017-03-13 Thread Rustad, Mark D
On Mar 12, 2017, at 7:02 PM, Kees Cook wrote: > Are there nominations for most comprehensive changelog of the year? :) > This is awesome. Especially for a one-liner! Truly comprehensive and completely relevant. -- Mark Rustad, Networking Division, Intel Corporation

Re: [PATCH net-next v5 0/7] gtp: misc improvements

2017-03-13 Thread Andreas Schultz
Hi Pablo, - On Mar 13, 2017, at 5:48 PM, pablo pa...@netfilter.org wrote: > On Thu, Mar 09, 2017 at 05:42:55PM +0100, Andreas Schultz wrote: >> Hi Pablo, >> >> This is a resent of last series that missed the merge window. There >> are no changes compared to v4. >> >> v4: Compared to v3 it

Re: [PATCH net-next v3 1/2] mpls: allow TTL propagation to IP packets to be configured

2017-03-13 Thread David Ahern
On 3/10/17 1:43 PM, Robert Shearman wrote: > Provide the ability to control on a per-route basis whether the TTL > value from an MPLS packet is propagated to an IPv4/IPv6 packet when > the last label is popped as per the theoretical model in RFC 3443 > through a new route attribute,

Re: [PATCH net-next v3 2/2] mpls: allow TTL propagation from IP packets to be configured

2017-03-13 Thread David Ahern
On 3/10/17 1:43 PM, Robert Shearman wrote: > Allow TTL propagation from IP packets to MPLS packets to be > configured. Add a new optional LWT attribute, MPLS_IPTUNNEL_TTL, which > allows the TTL to be set in the resulting MPLS packet, with the value > of 0 having the semantics of enabling

[RFC v1 for accelerated IPoIB 18/25] net/mlx5e: Export open/close api for IB link

2017-03-13 Thread Erez Shitrit
Now IB device is able to call open or close for its net device. TBD: There is one change that is waiting for the new channels api, till then used an "if" in the code. Signed-off-by: Erez Shitrit --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 +

[RFC v1 for accelerated IPoIB 13/25] net/mlx5e: Export resource creation function to be used in IB link

2017-03-13 Thread Erez Shitrit
mlx5i_attach that creates the resources of IB network device. mlx5i_detach cleans resources for IB device. Signed-off-by: Erez Shitrit --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 122 +++--- 1 file changed, 87 insertions(+), 35 deletions(-)

[RFC v1 for accelerated IPoIB 16/25] net/mlx5e: Change cleanup API in order to enable IB link

2017-03-13 Thread Erez Shitrit
1. Change the mlx5e_detach_netdev api. 2. Let that function to be called after the rtnl_lock is already held, like done in IB link. Signed-off-by: Erez Shitrit --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c

[RFC v1 for accelerated IPoIB 17/25] net/mlx5e: Change mlx5e_open_locked and mlx5e_close_locked api

2017-03-13 Thread Erez Shitrit
Let the IB link to call it directly with the relevant priv. Signed-off-by: Erez Shitrit --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 4 +-- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 24 -

[RFC v1 for accelerated IPoIB 09/25] net/mlx5e: Creating and Destroying flow-steering tables for IB link

2017-03-13 Thread Erez Shitrit
New function to handle RSS table for IB link type. Signed-off-by: Erez Shitrit --- drivers/net/ethernet/mellanox/mlx5/core/en.h| 2 ++ drivers/net/ethernet/mellanox/mlx5/core/en_fs.c | 41 + 2 files changed, 43 insertions(+) diff --git

[RFC v1 for accelerated IPoIB 11/25] net/mlx5e: Refactor attach_netdev API

2017-03-13 Thread Erez Shitrit
Use priv object instead of netdev object, will give tha ability to use it for IB link. Signed-off-by: Erez Shitrit --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 8

[RFC v1 for accelerated IPoIB 22/25] net/mlx5e: New function pointer for build_rx_skb is

2017-03-13 Thread Erez Shitrit
In order to have the ability to support IB link with the same base code. Signed-off-by: Erez Shitrit --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 6 ++ drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 7 +++

[RFC v1 for accelerated IPoIB 12/25] net/mlx5e: Use underlay_qpn in tis creation

2017-03-13 Thread Erez Shitrit
Enable IB link to use the same code, by default the underlay_qp is zero for ETH link. Signed-off-by: Erez Shitrit --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 ++ drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 1 + 2 files changed, 3 insertions(+) diff

[RFC v1 for accelerated IPoIB 14/25] net/mlx5: Enable flow-steering for IB link

2017-03-13 Thread Erez Shitrit
Get the relevant capabilities if supports ipoib_enhanced_offloads and init the flow steering table accordingly. Signed-off-by: Erez Shitrit --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 10 +- drivers/net/ethernet/mellanox/mlx5/core/fw.c | 3 ++- 2

[RFC v1 for accelerated IPoIB 23/25] net/mlx5e: Change the function that checks the packet type

2017-03-13 Thread Erez Shitrit
Now we can use it for non-ethernet type packets (like IB). After changing the order of the skb processing the function now can check the skb->protocol field to check if it is ETH_P_IP/ETH_P_IPV6 packet. Signed-off-by: Erez Shitrit ---

[RFC v1 for accelerated IPoIB 25/25] mlx5_ib: skeleton for mlx5_ib to support ipoib_ops

2017-03-13 Thread Erez Shitrit
Signed-off-by: Erez Shitrit --- drivers/infiniband/hw/mlx5/Makefile | 2 +- drivers/infiniband/hw/mlx5/main.c | 10 + drivers/infiniband/hw/mlx5/mlx5_ipoib_ops.c | 289 3 files changed, 300 insertions(+), 1 deletion(-)

[RFC v1 for accelerated IPoIB 21/25] net/mlx5e: Export send function for IB link type

2017-03-13 Thread Erez Shitrit
The function will be used in IB link in order to send packets. Signed-off-by: Erez Shitrit --- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 55 + include/linux/mlx5/driver.h | 5 ++- 2 files changed, 59 insertions(+), 1

[RFC v1 for accelerated IPoIB 24/25] net/mlx5e: Add support for build_rx_skb for packet from IB type

2017-03-13 Thread Erez Shitrit
New function that parse and build the skb for IPoIB traffic. Signed-off-by: Erez Shitrit --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 8 drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 49 +++ 2 files changed, 57 insertions(+) diff

[RFC v1 for accelerated IPoIB 15/25] net/mlx5e: Enhanced flow table creation to support ETH and IB links.

2017-03-13 Thread Erez Shitrit
IB link needs the the underlay_qp to support flow-steering, so change the API of the flow-steering creation for supporting both types in the same set of functions. Signed-off-by: Erez Shitrit --- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 12 +++-

[RFC v1 for accelerated IPoIB 20/25] net/mlx5e: Refactor TX send flow

2017-03-13 Thread Erez Shitrit
prepare of IB link type packets sending. Signed-off-by: Erez Shitrit --- drivers/net/ethernet/mellanox/mlx5/core/en.h| 4 + drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 237 ++-- 2 files changed, 141 insertions(+), 100 deletions(-) diff

[RFC v1 for accelerated IPoIB 19/25] include/linux/mlx5: Add mlx5_wqe_eth_pad and enhanced-ipoib-qp-mode

2017-03-13 Thread Erez Shitrit
mlx5_wqe_eth_pad will be used for TX flow for IB link type. enhanced-ipoib-qp-mode for QP creation. Signed-off-by: Erez Shitrit --- drivers/infiniband/hw/mlx5/qp.c | 4 include/linux/mlx5/qp.h | 8 2 files changed, 8 insertions(+), 4 deletions(-)

[RFC v1 for accelerated IPoIB 10/25] net/mlx5e: Support netdevice creation for IB link type

2017-03-13 Thread Erez Shitrit
Implement required interface that will able the IB link to be run on top of the ETH data structures. Signed-off-by: Erez Shitrit --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 98 +++ include/linux/mlx5/driver.h | 12 +++

[RFC v1 for accelerated IPoIB 05/25] IB/ipoib: Support ipoib acceleration options callbacks

2017-03-13 Thread Erez Shitrit
IPoIB driver now uses the new set of callback functions. If the HW provider supports the new ipoib_options implementation, the driver uses the callbacks in its datapath flows, otherwise it uses the driver default implementation for all data flows in its code. The default implementation is exactly

[RFC v1 for accelerated IPoIB 03/25] IB/ipoib: Rename qpn to dqpn in ipoib_send and post_send functions

2017-03-13 Thread Erez Shitrit
Signed-off-by: Erez Shitrit --- drivers/infiniband/ulp/ipoib/ipoib.h| 2 +- drivers/infiniband/ulp/ipoib/ipoib_ib.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib.h b/drivers/infiniband/ulp/ipoib/ipoib.h

[RFC v1 for accelerated IPoIB 04/25] IB/verb: Add ipoib_options struct and API

2017-03-13 Thread Erez Shitrit
The idea is to allow vendors to optimize IPoIB data path. New struct that includes functions and data member is exposed. It exposes set of callback functions for handling data path flows in IPoIB driver. Each vendor can support these set of functions in order to optimize its specific data path,

[RFC v1 for accelerated IPoIB 08/25] net/mlx5e: Refactor EN code to support IB link

2017-03-13 Thread Erez Shitrit
The idea is to use the same infrastructures for both ETH and IB link types, so the first step is to refactor the ETH handling to be able to use IB link as well. 1. Check requirments for ETH and for IB 2. Move code to common functions, where it will be used for both link types. 3. Change init and

[RFC v1 for accelerated IPoIB 01/25] IB/ipoib: Separate control and data related initializations

2017-03-13 Thread Erez Shitrit
This patch prepares init and and teardown flows so we can call them through ipoib_options function pointers. It arranges that area of code as the following: All operations which deal with the resource allocation/deletion are done in one place. All operations that are control oriented, meaning

[RFC v1 for accelerated IPoIB 07/25] linux/mlx5/mlx5_ifc.h: Add underlay_qpn field to PRM objects

2017-03-13 Thread Erez Shitrit
Add to the TIS and flow_table objects, and to hca capability table. 1. New capability bit: ipoib_enhanced_offloads, indicates new ability for UD QP to do RSS. 2. In order to support SET_ROOT cmd, to connect between QP to FS table. Signed-off-by: Erez Shitrit ---

[RFC v1 for accelerated IPoIB 06/25] hw/mlx5: Add New bit to check over QP creation

2017-03-13 Thread Erez Shitrit
Add check for bit IB_QP_CREATE_NETIF_QP while creating QP. Signed-off-by: Erez Shitrit --- drivers/infiniband/hw/mlx5/qp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index dc0ea63900c1..41e14d57fec9

[RFC v1 for accelerated IPoIB 00/25] Enhanced mode for IPoIB driver

2017-03-13 Thread Erez Shitrit
The IPoIB protocol encapsulates IP packets over Infiniband datagrams. As a direct RDMA Upper Layer Protocol (ULP), IPoIB cannot support HW features that are specific to the IP protocol stack. Nevertheless, RDMA interfaces have been extended to support some of the prominent IP

[RFC v1 for accelerated IPoIB 02/25] IB/ipoib: separate control from HW operation on ipoib_open/stop ndo

2017-03-13 Thread Erez Shitrit
This patch is preparing the netdev part at the ipoib driver to be able to use the ipoib_options. It deals with the two flows from the .ndo: ipoib_open and ipoib_stop. It arranges that area of code as follows: All operations which deal with the HW resources, (for example change QP state,

Re: [PATCH net-next] mlx4: Better use of order-0 pages in RX path

2017-03-13 Thread Alexei Starovoitov
On Mon, Mar 13, 2017 at 10:50:28AM -0700, Eric Dumazet wrote: > On Mon, Mar 13, 2017 at 10:34 AM, Alexei Starovoitov > wrote: > > On Sun, Mar 12, 2017 at 05:58:47PM -0700, Eric Dumazet wrote: > >> @@ -767,10 +814,30 @@ int mlx4_en_process_rx_cq(struct net_device

Re: Legacy features in PCI Express devices

2017-03-13 Thread Robin Murphy
On 13/03/17 17:39, Mason wrote: > On 13/03/2017 18:12, Robin Murphy wrote: > >> On 13/03/17 16:10, Mason wrote: >> >>> There are two revisions of our PCI Express controller. >>> >>> Rev 1 did not support the following features: >>> >>> 1) legacy PCI interrupt delivery (INTx signals) >>> 2)

Re: [PATCH net-next] mlx4: Better use of order-0 pages in RX path

2017-03-13 Thread Eric Dumazet
On Mon, Mar 13, 2017 at 10:34 AM, Alexei Starovoitov wrote: > On Sun, Mar 12, 2017 at 05:58:47PM -0700, Eric Dumazet wrote: >> @@ -767,10 +814,30 @@ int mlx4_en_process_rx_cq(struct net_device *dev, >> struct mlx4_en_cq *cq, int bud >> case

Re: [PATCH net] ipv6: make ECMP route replacement less greedy

2017-03-13 Thread Michal Kubecek
On Mon, Mar 13, 2017 at 01:28:09PM +0100, Sabrina Dubroca wrote: > Commit 27596472473a ("ipv6: fix ECMP route replacement") introduced a > loop that removes all siblings of an ECMP route that is being > replaced. However, this loop doesn't stop when it has replaced > siblings, and keeps removing

Re: net/atm: warning in alloc_tx/__might_sleep

2017-03-13 Thread Andrey Konovalov
On Thu, Jan 12, 2017 at 11:40 AM, Chas Williams <3ch...@gmail.com> wrote: > On Wed, 2017-01-11 at 20:36 -0800, Cong Wang wrote: >> On Wed, Jan 11, 2017 at 11:46 AM, Michal Hocko wrote: >> > On Wed 11-01-17 20:45:25, Michal Hocko wrote: >> >> On Wed 11-01-17 09:37:06, Chas

Re: ip_rcv_finish() NULL pointer kernel panic

2017-03-13 Thread Florian Westphal
Dan Streetman wrote: > > But I have to say that this netfilter bridging fake dst has caused > > several dozen bugs over the years, it is fundamentally a serious > > problem in and of itself. It provides DST facilities by hand, in a > > static object, without using

Re: Legacy features in PCI Express devices

2017-03-13 Thread Mason
On 13/03/2017 18:12, Robin Murphy wrote: > On 13/03/17 16:10, Mason wrote: > >> There are two revisions of our PCI Express controller. >> >> Rev 1 did not support the following features: >> >> 1) legacy PCI interrupt delivery (INTx signals) >> 2) I/O address space >> >> Internally, someone

Re: [PATCH] net: usb: asix88179_178a: use new api ethtool_{get|set}_link_ksettings

2017-03-13 Thread Chris Roth
I have tested this patch on the Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller (Vendor=04b4 ProdID=3610) and the device still functions properly with the patch applied. Feel free to add my name / email to the tested-by portion of the patch. Chris On 2017-03-12 11:02 AM, Philippe

Re: [RFC PATCH] sock: add SO_RCVQUEUE_SIZE getsockopt

2017-03-13 Thread Josh Hunt
On 03/13/2017 11:12 AM, Eric Dumazet wrote: On Mon, Mar 13, 2017 at 8:59 AM, Josh Hunt wrote: Allows application to read the amount of data sitting in the receive queue. Signed-off-by: Josh Hunt --- A team here is looking for a way to get the amount of

Re: [PATCH net-next] mlx4: Better use of order-0 pages in RX path

2017-03-13 Thread Alexei Starovoitov
On Sun, Mar 12, 2017 at 05:58:47PM -0700, Eric Dumazet wrote: > @@ -767,10 +814,30 @@ int mlx4_en_process_rx_cq(struct net_device *dev, > struct mlx4_en_cq *cq, int bud > case XDP_PASS: > break; > case XDP_TX: > +

Re: [patch net-next 03/10] ipv4: fib_rules: Dump FIB rules when registering FIB notifier

2017-03-13 Thread Ido Schimmel
On Mon, Mar 13, 2017 at 08:52:45AM -0600, David Ahern wrote: > On 3/13/17 1:38 AM, Jiri Pirko wrote: > > From: Ido Schimmel > > > > In commit c3852ef7f2f8 ("ipv4: fib: Replay events when registering FIB > > notifier") we dumped the FIB tables and replayed the events to the >

Re: ip_rcv_finish() NULL pointer kernel panic

2017-03-13 Thread Dan Streetman
On Thu, Jan 26, 2017 at 1:04 PM, David Miller wrote: > From: Florian Westphal > Date: Thu, 26 Jan 2017 17:24:33 +0100 > >> Eric Dumazet wrote: >>> > Though possibly with different things not setting the "input" function >>> > pointer

[PATCH net] net/mlx4_core: Avoid delays during VF driver device shutdown

2017-03-13 Thread Tariq Toukan
From: Jack Morgenstein Some Hypervisors detach VFs from VMs by instantly causing an FLR event to be generated for a VF. In the mlx4 case, this will cause that VF's comm channel to be disabled before the VM has an opportunity to invoke the VF device's "shutdown" method.

Re: Legacy features in PCI Express devices

2017-03-13 Thread David Daney
On 03/13/2017 09:10 AM, Mason wrote: Hello, There are two revisions of our PCI Express controller. Rev 1 did not support the following features: 1) legacy PCI interrupt delivery (INTx signals) 2) I/O address space Internally, someone stated that such missing support would prevent some

[PATCH net-next] netem: apply correct delay when rate throttling

2017-03-13 Thread Stephen Hemminger
From: Nik Unger I recently reported on the netem list that iperf network benchmarks show unexpected results when a bandwidth throttling rate has been configured for netem. Specifically: 1) The measured link bandwidth *increases* when a higher delay is added 2) The measured

Re: Legacy features in PCI Express devices

2017-03-13 Thread Robin Murphy
On 13/03/17 16:10, Mason wrote: > Hello, > > There are two revisions of our PCI Express controller. > > Rev 1 did not support the following features: > > 1) legacy PCI interrupt delivery (INTx signals) > 2) I/O address space > > Internally, someone stated that such missing support would

Re: [PATCH net-next v5 0/7] gtp: misc improvements

2017-03-13 Thread Harald Welte
Hi Pablo, On Mon, Mar 13, 2017 at 05:48:12PM +0100, Pablo Neira Ayuso wrote: > I would like you take the time to develop the VRF idea that you want > to introduce, I just would like that we avoid bloating the GTP tunnel > with features that we can just achieve via composite of different >

[RESEND PATCH -net] cpsw/netcp: work around reverse cpts dependency

2017-03-13 Thread Arnd Bergmann
The dependency is reversed: cpsw and netcp call into cpts, but cpts depends on the other two in Kconfig. This can lead to cpts being a loadable module and its callers built-in: drivers/net/ethernet/ti/cpsw.o: In function `cpsw_remove': cpsw.c:(.text.cpsw_remove+0xd0): undefined reference to

Re: Legacy features in PCI Express devices

2017-03-13 Thread Greg
On Mon, 2017-03-13 at 17:10 +0100, Mason wrote: > Hello, > > There are two revisions of our PCI Express controller. > > Rev 1 did not support the following features: > > 1) legacy PCI interrupt delivery (INTx signals) I'm not sure about this... > 2) I/O address space But yes, definitely

Re: [PATCH net-next 2/4] net-next: dsa: add Mediatek tag RX/TX handler

2017-03-13 Thread Vivien Didelot
Hi Sean, sean.w...@mediatek.com writes: > + mtk_tag[1] = (1 << p->port) & MTK_HDR_XMIT_DP_BIT_MASK; This won't apply, the port index in now stored in p->dp->index. Thanks, Vivien

[RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers

2017-03-13 Thread Arnd Bergmann
With posix timers having become optional, we get a build error with the cpts time sync option of the CPSW driver: drivers/net/ethernet/ti/cpts.c: In function 'cpts_find_ts': drivers/net/ethernet/ti/cpts.c:291:23: error: implicit declaration of function 'ptp_classify_raw';did you mean

Re: [PATCH net 1/3] cpsw/netcp: cpts depends on posix_timers

2017-03-13 Thread Arnd Bergmann
On Fri, Dec 16, 2016 at 7:18 PM, Nicolas Pitre wrote: > On Fri, 16 Dec 2016, Arnd Bergmann wrote: > >> With posix timers having become optional, we get a build error with >> the cpts time sync option of the CPSW driver: >> >> drivers/net/ethernet/ti/cpts.c: In function

Re: [PATCH net] bridge: drop netfilter fake rtable unconditionally

2017-03-13 Thread Pablo Neira Ayuso
On Mon, Mar 13, 2017 at 05:38:17PM +0100, Florian Westphal wrote: > Andreas reports kernel oops during rmmod of the br_netfilter module. > Hannes debugged the oops down to a NULL rt6info->rt6i_indev. > > Problem is that br_netfilter has the nasty concept of adding a fake > rtable to skb->dst;

Re: [PATCH net-next 0/4] net-next: dsa: add Mediatek MT7530 support

2017-03-13 Thread John Crispin
On 13/03/17 17:11, sean.w...@mediatek.com wrote: From: Sean Wang MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on Mediatek router platforms such as MT7623A or MT7623N which includes 7-port Gigabit Ethernet MAC and 5-port Gigabit Ethernet PHY. Among

Re: [PATCH net-next 1/4] dt-bindings: net: dsa: add Mediatek MT7530 binding

2017-03-13 Thread Florian Fainelli
On 03/13/2017 09:11 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > Add device-tree binding for Mediatek MT7530 switch. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Sean Wang > --- > .../devicetree/bindings/net/dsa/mt7530.txt

Re: [PATCH net-next v5 0/7] gtp: misc improvements

2017-03-13 Thread Pablo Neira Ayuso
On Thu, Mar 09, 2017 at 05:42:55PM +0100, Andreas Schultz wrote: > Hi Pablo, > > This is a resent of last series that missed the merge window. There > are no changes compared to v4. > > v4: Compared to v3 it contains mostly smallish naming and spelling fixes. > It also drops the documentation

Re: [PATCH] MIPS: BPF: Add support for SKF_AD_HATYPE

2017-03-13 Thread David Daney
On 03/13/2017 03:56 AM, James Hogan wrote: On Fri, Mar 10, 2017 at 02:14:05PM -0800, David Daney wrote: This let's us pass some additional "modprobe test-bpf" tests. Reuse the code for SKF_AD_IFINDEX, but substitute the offset and size of the "type" field. Signed-off-by: David Daney

Re: [PATCH net-next 1/4] dt-bindings: net: dsa: add Mediatek MT7530 binding

2017-03-13 Thread Andrew Lunn
> +- mediatek,reset-pin: Phandle to the pinctrl node used for the reset. Which > + must be required if the property mediatek,mcm of specified as > + "disabled". See > + Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt for > + the mediatek pintcrl setting for the

Re: [PATCH net-next 2/4] net-next: dsa: add Mediatek tag RX/TX handler

2017-03-13 Thread Florian Fainelli
On 03/13/2017 09:11 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > Add the support for the 4-bytes tag for DSA port distinguishing inserted > allowing receiving and transmitting the packet via the particular port. > The tag is being added after the source MAC

Re: [PATCH net-next 4/4] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-03-13 Thread Andrew Lunn
Hi Sean Just looking at the GPIO handling at the moment. > + /* Reset whole chip through gpio pin or > + * memory-mapped registers for different > + * type of hardware > + */ > + if (priv->mcm) { > + regmap_update_bits(priv->ethsys, SYSC_REG_RSTCTRL, > +

[PATCH net] bridge: drop netfilter fake rtable unconditionally

2017-03-13 Thread Florian Westphal
Andreas reports kernel oops during rmmod of the br_netfilter module. Hannes debugged the oops down to a NULL rt6info->rt6i_indev. Problem is that br_netfilter has the nasty concept of adding a fake rtable to skb->dst; this happens in a br_netfilter prerouting hook. A second hook (in bridge

Re: [PATCH net-next 3/4] net-next: ethernet: mediatek: add CDM able to recognize the tag for DSA

2017-03-13 Thread Florian Fainelli
On 03/13/2017 09:11 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > Allowing CDM can recognize these packets with carrying port-distinguishing > tag when CONFIG_NET_DSA_TAG_MTK is enabled. Otherwise, these packets will > be dropped by CDM ingress. > >

Re: [PATCH net-next 3/4] net-next: ethernet: mediatek: add CDM able to recognize the tag for DSA

2017-03-13 Thread Andrew Lunn
On Tue, Mar 14, 2017 at 12:11:27AM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > Allowing CDM can recognize these packets with carrying port-distinguishing > tag when CONFIG_NET_DSA_TAG_MTK is enabled. Otherwise, these packets will > be dropped by CDM

Re: [PATCH net-next 2/4] net-next: dsa: add Mediatek tag RX/TX handler

2017-03-13 Thread Andrew Lunn
On Tue, Mar 14, 2017 at 12:11:26AM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > Add the support for the 4-bytes tag for DSA port distinguishing inserted > allowing receiving and transmitting the packet via the particular port. > The tag is being added after

[PATCH net-next 4/4] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-03-13 Thread sean.wang
From: Sean Wang MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on Mediatek router platforms such as MT7623A or MT7623N platform which includes 7-port Gigabit Ethernet MAC and 5-port Gigabit Ethernet PHY. Among these ports, The port from 0 to 4 are the

[PATCH 00/11] net: stmmac: prepare dma operations for multiple queues

2017-03-13 Thread Joao Pinto
As agreed with David Miller, this patch-set is the second of 3 to enable multiple queues in stmmac. This second one concentrates on dma operations adding functionalities as: a) DMA Operation Mode configuration per channel and done in the multiple queues configuration function b) DMA IRQ enable

<    1   2   3   4   >