[PATCH net-next] net: fix dma operation mode config for older versions

2017-03-21 Thread Joao Pinto
This patch fixes a bug introduced in commit: 6deee22 (net: stmmac: prepare dma op mode config for multiple queues) The dma operation mode configuration routine was wrongly moved to a function (stmmac_mtl_configuration) that is only executed if the core version is >= 4.00. Reported-by: Corentin

[PATCH net-next 4/4] drivers: net: xgene-v2: misc fixes

2017-03-21 Thread Iyappan Subramanian
Fixed review comments from the previous patch-set. - changed return value check of platform_get_irq() to < 0 - replaced devm_request(free)_irq() calls by request(free)_irq() since they are called from open() and close() - changed sizeof(struct mystruct) to sizeof(*mystruct) - reduced

[PATCH v2 net-next] net: fix dma operation mode config for older versions

2017-03-21 Thread Joao Pinto
This patch fixes a bug introduced in: commit 6deee2221e11 ("net: stmmac: prepare dma op mode config for multiple queues") The dma operation mode configuration routine was wrongly moved to a function (stmmac_mtl_configuration) that is only executed if the core version is >= 4.00. Reported-by:

Re: [PATCH net-next] net: fix dma operation mode config for older versions

2017-03-21 Thread Sergei Shtylyov
On 03/21/2017 08:36 PM, Joao Pinto wrote: This patch fixes a bug introduced in commit: 6deee22 (net: stmmac: prepare dma op mode config for multiple queues) Need 12 hex digits and the commit summary enclosed into (""). The dma operation mode configuration routine was wrongly moved to a

Re: [PATCH v2 net-next] net: fix dma operation mode config for older versions

2017-03-21 Thread Florian Fainelli
On 03/21/2017 11:02 AM, Joao Pinto wrote: > This patch fixes a bug introduced in: > commit 6deee2221e11 ("net: stmmac: prepare dma op mode config for multiple > queues") So even though this is against net-next which is the only tree so far having the offending commit, it is nice to see this

[PATCH net-next 2/4] drivers: net: xgene-v2: Add ethtool support

2017-03-21 Thread Iyappan Subramanian
Added basic ethtool support. Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene-v2/Makefile | 2 +- drivers/net/ethernet/apm/xgene-v2/ethtool.c | 121 drivers/net/ethernet/apm/xgene-v2/main.c| 1 +

[PATCH net-next 0/4] drivers: net: xgene-v2: Add MDIO and ethtool support

2017-03-21 Thread Iyappan Subramanian
This patch set, - adds phy management and ethtool support - fixes ethernet reset - addresses review comments from previous patch set Signed-off-by: Iyappan Subramanian --- Iyappan Subramanian (4): drivers: net: xgene-v2: Add MDIO support drivers: net: xgene-v2:

[PATCH net-next] rtnetlink: Add dump all for netconf

2017-03-21 Thread David Ahern
Use the rtnl_dump_all to dump all netconf handlers that have been registered. Allows userspace to send a dump request for PF_UNSPEC and get all families. Cc: Nicolas Dichtel Signed-off-by: David Ahern --- net/core/rtnetlink.c | 1 + 1 file

[PATCH net-next 3/4] drivers: net: xgene-v2: Fix port reset

2017-03-21 Thread Iyappan Subramanian
Fixed port reset sequence by adding ECC init. Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene-v2/enet.c | 24 ++-- drivers/net/ethernet/apm/xgene-v2/enet.h | 2 ++ drivers/net/ethernet/apm/xgene-v2/mac.h | 1 - 3 files changed,

[PATCH net-next 1/4] drivers: net: xgene-v2: Add MDIO support

2017-03-21 Thread Iyappan Subramanian
Added phy management support by using phy abstraction layer APIs. Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene-v2/Makefile | 2 +- drivers/net/ethernet/apm/xgene-v2/mac.c| 2 +- drivers/net/ethernet/apm/xgene-v2/mac.h| 1 +

Re: [PATCH net-next] net: fix dma operation mode config for older versions

2017-03-21 Thread Joao Pinto
Às 5:53 PM de 3/21/2017, Sergei Shtylyov escreveu: > On 03/21/2017 08:36 PM, Joao Pinto wrote: > >> This patch fixes a bug introduced in commit: >> 6deee22 (net: stmmac: prepare dma op mode config for multiple queues) > >Need 12 hex digits and the commit summary enclosed into (""). > >> The

Re: SCTP MSG_MORE code

2017-03-21 Thread Xin Long
On Tue, Mar 21, 2017 at 1:49 AM, David Laight wrote: > Something needs to be done with SCTP MSG_MORE before the end of the rc cycle. > The current code is definitely broken. agreed. > > I objected to the last 'fix' patch because it clears the flag is a place where > I

Re: [PATCH] enic: Store permanent MAC address during probe()

2017-03-21 Thread PJ Waskiewicz
On Mon, Mar 20, 2017 at 6:49 PM, Govindarajulu Varadarajan wrote: > On Mon, 20 Mar 2017, PJ Waskiewicz wrote: > >> On Mon, Mar 20, 2017 at 5:33 PM, Govindarajulu Varadarajan >> wrote: >>> >>> On Mon, 20 Mar 2017, PJ Waskiewicz wrote: >>> From: PJ

[PATCH 1/5] netfilter: ipvs: Clean up tests if NULL returned on failure

2017-03-21 Thread simran singhal
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal --- --This is

[PATCH 2/5] netfilter: Clean up tests if NULL returned on failure

2017-03-21 Thread simran singhal
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal

[PATCH 3/5] netfilter: nf_tables_api: Clean up tests if NULL returned on failure

2017-03-21 Thread simran singhal
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal

[PATCH 5/5] netfilter: xt_TEE: Clean up tests if NULL returned on failure

2017-03-21 Thread simran singhal
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal

[PATCH 4/5] netfilter: nfnetlink: Clean up tests if NULL returned on failure

2017-03-21 Thread simran singhal
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

2017-03-21 Thread Niklas Cassel
On 03/20/2017 11:07 PM, Florian Fainelli wrote: > > (snip) >> >> However, it is kind of sad that drivers are so inconsistent of what goes >> in probe and what goes in ndo_open...which is tied together with the >> whole mess of when certain ethtool commands work or do not work. > Well, inconsistent

Re: linux-next-20170320 break stmmac on dwmac-sunxi

2017-03-21 Thread Giuseppe CAVALLARO
+ Joao please Joao, could you do a check if new changes have any impact on that? peppe On 3/20/2017 8:54 PM, Corentin Labbe wrote: Hello Just pushed next-20170320 to my boards and stmmac stop working on both intree dwmac-sunxi and my dev dwmac-sun8i. It seems that interrupts never fire, and

[PATCH net-next v2 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-03-21 Thread sean.wang
From: Sean Wang MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on Mediatek router platforms such as MT7623A or MT7623N platform which includes 7-port Gigabit Ethernet MAC and 5-port Gigabit Ethernet PHY. Among these ports, The port from 0 to 4 are the

Re: [PATCH 24/29] drivers: convert iblock_req.pending from atomic_t to refcount_t

2017-03-21 Thread Nicholas A. Bellinger
Hi Elena, On Mon, 2017-03-06 at 16:21 +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free >

Re: "tipc: fix socket timer deadlock" to stable?

2017-03-21 Thread Tommi Rantala
On 13.03.2017 14:18, Jon Maloy wrote: -Original Message- From: Tommi Rantala [mailto:tommi.t.rant...@nokia.com] We're seeing this tipc deadlock in 4.4.y, that was fixed in the mainline commit f1d048f24e66ba85d3dabf3d076cefa5f2b546b0 "tipc: fix socket timer deadlock". Could/should this

Re: [PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

2017-03-21 Thread Marcel Holtmann
Hi Bjorn, > By moving these client drivers to use RPMSG instead of the direct SMD > API we can reuse them ontop of the newly added GLINK wire-protocol > support found in the 820 and 835 Qualcomm platforms. > > As the new (RPMSG-based) and old SMD implementations are mutually > exclusive we have

[PATCH net-next v2 1/5] dt-bindings: net: dsa: add Mediatek MT7530 binding

2017-03-21 Thread sean.wang
From: Sean Wang Add device-tree binding for Mediatek MT7530 switch. Cc: devicet...@vger.kernel.org Signed-off-by: Sean Wang --- .../devicetree/bindings/net/dsa/mt7530.txt | 92 ++ 1 file changed, 92 insertions(+)

Re: [PATCH net-next v6 2/3] Add a eBPF helper function to retrieve socket uid

2017-03-21 Thread Lorenzo Colitti
On Tue, Mar 21, 2017 at 1:08 PM, Chenbo Feng wrote: > + if (!sk || !sk_fullsock(sk)) > + return overflowuid; > + kuid = sock_net_uid(sock_net(sk), sk); > + return from_kuid_munged(current_user_ns(), kuid); Is current_user_ns() correct

[PATCH 0/5] netfilter: Clean up tests if NULL returned on failure

2017-03-21 Thread simran singhal
This patch series clean up tests if NULL returned on failure. simran singhal (5): netfilter: ipvs: Clean up tests if NULL returned on failure netfilter: Clean up tests if NULL returned on failure netfilter: nf_tables_api: Clean up tests if NULL returned on failure netfilter: nfnetlink:

[PATCH 0/2] netfilter: ,netdev@vger.kernel.org

2017-03-21 Thread simran singhal
This patch series Simplify function returns by merging assignment and return into one command line. simran singhal (2): netfilter: ipset: Compress return logic netfilter: ipvs: Compress return logic net/netfilter/ipset/ip_set_list_set.c | 5 + net/netfilter/ipvs/ip_vs_ftp.c| 5

[PATCH 1/2] netfilter: ipset: Compress return logic

2017-03-21 Thread simran singhal
Simplify function returns by merging assignment and return into one command line. Signed-off-by: simran singhal --- --This is my contribution to the netfilter project of Outreachy Round 14. net/netfilter/ipset/ip_set_list_set.c | 5 + 1 file changed, 1

[PATCH 2/2] netfilter: ipvs: Compress return logic

2017-03-21 Thread simran singhal
Simplify function returns by merging assignment and return into one command line. Signed-off-by: simran singhal --- --This is my contribution to the netfilter project of Outreachy Round 14. net/netfilter/ipvs/ip_vs_ftp.c | 5 + 1 file changed, 1 insertion(+),

[PATCH v2 0/2] netfilter: Compress return logic

2017-03-21 Thread simran singhal
This patch series Simplify function returns by merging assignment and return into one command line. v2: -Change the subject of cover patch simran singhal (2): netfilter: ipset: Compress return logic netfilter: ipvs: Compress return logic net/netfilter/ipset/ip_set_list_set.c | 5 +

[PATCH v2 2/2] netfilter: ipvs: Compress return logic

2017-03-21 Thread simran singhal
Simplify function returns by merging assignment and return into one command line. Signed-off-by: simran singhal --- --This is my contribution to the netfilter project of Outreachy Round 14. net/netfilter/ipvs/ip_vs_ftp.c | 5 + 1 file changed, 1 insertion(+),

[PATCH v2 1/2] netfilter: ipset: Compress return logic

2017-03-21 Thread simran singhal
Simplify function returns by merging assignment and return into one command line. Signed-off-by: simran singhal --- --This is my contribution to the netfilter project of Outreachy Round 14. net/netfilter/ipset/ip_set_list_set.c | 5 + 1 file changed, 1

pull-request: wireless-drivers 2017-03-21

2017-03-21 Thread Kalle Valo
Hi Dave, few smallish fixes for 4.11. Please let me know if there are any problems. Kalle The following changes since commit 22a0e18eac7a9e986fec76c60fa4a2926d1291e2: net: properly release sk_frag.page (2017-03-15 15:37:45 -0700) are available in the git repository at:

[PATCH net 0/8] Mellanox mlx5 fixes 2017-03-21

2017-03-21 Thread Saeed Mahameed
Hi Dave, This series contains some mlx5 core and ethernet driver fixes. For -stable: net/mlx5e: Count LRO packets correctly (for kernel >= 4.2) net/mlx5e: Count GSO packets correctly (for kernel >= 4.2) net/mlx5: Increase number of max QPs in default profile (for kernel >= 4.0) net/mlx5e: Avoid

[PATCH net 8/8] net/mlx5e: Count LRO packets correctly

2017-03-21 Thread Saeed Mahameed
From: Gal Pressman RX packets statistics ('rx_packets' counter) used to count LRO packets as one, even though it contains multiple segments. This patch will increment the counter by the number of segments, and align the driver with the behavior of other drivers in the stack.

[PATCH net 5/8] net/mlx5e: Avoid supporting udp tunnel port ndo for VF reps

2017-03-21 Thread Saeed Mahameed
From: Paul Blakey This was added to allow the TC offloading code to identify offloading encap/decap vxlan rules. The VF reps are effectively related to the same mlx5 PCI device as the PF. Since the kernel invokes the (say) delete ndo for each netdev, the FW erred on multiple

[PATCH net 4/8] net/mlx5e: Use the proper UAPI values when offloading TC vlan actions

2017-03-21 Thread Saeed Mahameed
From: Or Gerlitz Currently we use the non UAPI values and we miss erring on the modify action which is not supported, fix that. Fixes: 8b32580df1cb ('net/mlx5e: Add TC vlan action for SRIOV offloads') Signed-off-by: Or Gerlitz Reported-by: Petr

[PATCH net 6/8] net/mlx5: Increase number of max QPs in default profile

2017-03-21 Thread Saeed Mahameed
From: Maor Gottlieb With ConnectX-4 sharing SRQs from the same space as QPs, we hit a limit preventing some applications to allocate needed QPs amount. Double the size to 256K. Fixes: e126ba97dba9e ('mlx5: Add driver for Mellanox Connect-IB adapters') Signed-off-by: Maor

[PATCH net 7/8] net/mlx5e: Count GSO packets correctly

2017-03-21 Thread Saeed Mahameed
From: Gal Pressman TX packets statistics ('tx_packets' counter) used to count GSO packets as one, even though it contains multiple segments. This patch will increment the counter by the number of segments, and align the driver with the behavior of other drivers in the stack.

[PATCH net-next v2 2/5] net-next: dsa: add Mediatek tag RX/TX handler

2017-03-21 Thread sean.wang
From: Sean Wang Add the support for the 4-bytes tag for DSA port distinguishing inserted allowing receiving and transmitting the packet via the particular port. The tag is being added after the source MAC address in the ethernet header. Signed-off-by: Sean Wang

Re: mlx5e backports for v4.9 -stable

2017-03-21 Thread Saeed Mahameed
On Mon, Mar 20, 2017 at 11:32 PM, Saeed Mahameed wrote: > > > On 03/17/2017 02:06 AM, David Miller wrote: >> >> Commits: >> >> >> From b0d4660b4cc52e6477ca3a43435351d565dfcedc Mon Sep 17 00:00:00 2001 >> From: Tariq Toukan >> Date:

Re: [net-next 05/13] i40e: rework exit flow of i40e_add_fdir_ethtool

2017-03-21 Thread Sergei Shtylyov
Hello! On 3/21/2017 2:47 AM, Jeff Kirsher wrote: From: Jacob Keller Refactor the exit flow of the i40e_add_fdir_ethtool function. Move the input_label to the end of the function, removing the dependency on I don't see 'input_label' anywhere. Perhaps

[PATCH net-next] net: greth: Utilize of_get_mac_address()

2017-03-21 Thread Tobias Klauser
Do not open code getting the MAC address exclusively from the "local-mac-address" property, but instead use of_get_mac_address() which looks up the MAC address using the 3 typical property names. Signed-off-by: Tobias Klauser --- drivers/net/ethernet/aeroflex/greth.c | 10

Re: [PATCH net-next 1/8] ptr_ring: introduce batch dequeuing

2017-03-21 Thread Sergei Shtylyov
Hello! On 3/21/2017 7:04 AM, Jason Wang wrote: Signed-off-by: Jason Wang --- include/linux/ptr_ring.h | 65 1 file changed, 65 insertions(+) diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h index

RE: [PATCH] net: convert sk_filter.refcnt from atomic_t to refcount_t

2017-03-21 Thread Reshetova, Elena
> On 03/20/2017 10:37 AM, Elena Reshetova wrote: > [...] > > diff --git a/net/core/filter.c b/net/core/filter.c > > index ebaeaf2..389cb8d 100644 > > --- a/net/core/filter.c > > +++ b/net/core/filter.c > > @@ -928,7 +928,7 @@ static void sk_filter_release_rcu(struct rcu_head *rcu) > >*/ > >

[PATCH net-next v2 3/5] net-next: ethernet: mediatek: add CDM able to recognize the tag for DSA

2017-03-21 Thread sean.wang
From: Sean Wang The patch adds the setup for allowing CDM can recognize these packets with carrying port-distinguishing tag. Otherwise, these tagging packets will be handled incorrectly by CDM. The setup is working out for general untag packets as well. Signed-off-by:

[PATCH net-next v2 4/5] net-next: ethernet: mediatek: add device_node of GMAC pointing into the netdev instance

2017-03-21 Thread sean.wang
From: Sean Wang the patch adds the setup of the corresponding device node of GMAC into the netdev instance which could allow other modules such as DSA to find the instance through the node in dt-bindings using of_find_net_device_by_node() call. Signed-off-by: Sean Wang

[PATCH net-next v2 0/5] net-next: dsa: add Mediatek MT7530 support

2017-03-21 Thread sean.wang
From: Sean Wang MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on Mediatek router platforms such as MT7623A or MT7623N which includes 7-port Gigabit Ethernet MAC and 5-port Gigabit Ethernet PHY. Among these ports, The port from 0 to 4 are the user ports

[PATCH net v1 1/1] tipc: fix nametbl deadlock at tipc_nametbl_unsubscribe

2017-03-21 Thread Parthasarathy Bhuvaragan
From: Ying Xue Until now, tipc_nametbl_unsubscribe() is called at subscriptions reference count cleanup. Usually the subscriptions cleanup is called at subscription timeout or at subscription cancel or at subscriber delete. We have ignored the possibility of this being

Re: [Bridge] [PATCH net] bridge: ebtables: fix reception of frames DNAT-ed to bridge device

2017-03-21 Thread Pablo Neira Ayuso
On Tue, Mar 21, 2017 at 01:09:47AM +0100, Linus Lüssing wrote: > On Sun, Mar 19, 2017 at 05:55:06PM +0100, Linus Lüssing wrote: > > On Fri, Mar 17, 2017 at 02:10:44PM +0100, Pablo Neira Ayuso wrote: > > > Wait. > > > > > > May this break local multicast listener that are bound to the bridge > > >

Re: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for PHYs with interrupts

2017-03-21 Thread Roger Quadros
On 20/03/17 18:41, Florian Fainelli wrote: > On 03/16/2017 12:46 AM, Roger Quadros wrote: >> On 15/03/17 17:49, Andrew Lunn wrote: >>> On Wed, Mar 15, 2017 at 05:00:08PM +0200, Roger Quadros wrote: Andrew, On 15/03/17 16:08, Andrew Lunn wrote: > On Wed, Mar 15, 2017 at

Re: linux-next-20170320 breaks stmmac on meson (Amlogic S905GXBB)

2017-03-21 Thread Joao Pinto
Hi Heiner and Corentin, Às 9:58 PM de 3/20/2017, Heiner Kallweit escreveu: > As reported by Corentin Labbe before: > stmmac in the latest next kernel is broken also on meson8b. > > The following commit seems to create the trouble: > 6deee2221e11 "net: stmmac: prepare dma op mode config for

Re: [PATCH net-stable] ipv4: keep skb->dst around in presence of IP options

2017-03-21 Thread Ben Hutchings
On Mon, 2017-03-20 at 21:23 -0700, Eric Dumazet wrote: > From: Eric Dumazet > > Upstream commit 34b2cef20f19c87999fff3da4071e66937db9644 > ("ipv4: keep skb->dst around in presence of IP options") incorrectly > root caused commit d826eb14ecef ("ipv4: PKTINFO doesnt need dst >

Re: [PATCH net] sctp: declare struct sctp_stream before using it

2017-03-21 Thread Neil Horman
On Mon, Mar 20, 2017 at 10:33:57PM +0800, Xin Long wrote: > On Mon, Mar 20, 2017 at 9:29 PM, Neil Horman wrote: > > On Mon, Mar 20, 2017 at 05:46:27PM +0800, Xin Long wrote: > >> sctp_stream_free uses struct sctp_stream as a param, but struct sctp_stream > >> is defined

Re: [PATCH RFC 0/7] phylib MMD accessor cleanups

2017-03-21 Thread Russell King - ARM Linux
On Sun, Mar 19, 2017 at 03:30:38PM -0700, Florian Fainelli wrote: > Le 03/19/17 à 03:59, Russell King - ARM Linux a écrit : > > This series of patches does exactly that - we merge the functionality > > of the indirect accesses into the clause 45 accessors, and use these > > exclusively to access

Re: run_timer_softirq gpf. [smc]

2017-03-21 Thread Dave Jones
On Tue, Mar 21, 2017 at 08:25:39PM +0100, Thomas Gleixner wrote: > > I just hit this while fuzzing.. > > > > general protection fault: [#1] PREEMPT SMP DEBUG_PAGEALLOC > > CPU: 2 PID: 0 Comm: swapper/2 Not tainted 4.11.0-rc2-think+ #1 > > task: 88017f0ed440 task.stack:

Re: [PATCH 00/22] Netfilter/IPVS updates for net-next

2017-03-21 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 20 Mar 2017 11:08:28 +0100 > The following patchset contains Netfilter/IPVS updates for your > net-next tree. A couple of new features for nf_tables, and unsorted > cleanups and incremental updates for the Netfilter tree. More >

Re: [PATCH-v5 0/4] vsock: cancel connect packets when failing to connect

2017-03-21 Thread David Miller
From: Peng Tao Date: Wed, 15 Mar 2017 09:32:13 +0800 > Currently, if a connect call fails on a signal or timeout (e.g., guest is > still > in the process of starting up), we'll just return to caller and leave the > connect > packet queued and they are sent even though the

Re: [PATCH net 0/4] ibmvnic: Initialization fixes and improvements

2017-03-21 Thread David Miller
From: John Allen Date: Fri, 17 Mar 2017 17:13:39 -0500 > These patches resolve issues with the ibmvnic initialization process. Series applied, thanks.

Re: [PATCH] rhashtable: Add rhashtable_lookup_get_insert_fast

2017-03-21 Thread David Miller
From: Andreas Gruenbacher Date: Sat, 18 Mar 2017 00:36:15 +0100 > Add rhashtable_lookup_get_insert_fast for fixed keys, similar to > rhashtable_lookup_get_insert_key for explicit keys. > > Signed-off-by: Andreas Gruenbacher > Acked-by: Herbert Xu

[PATCH net-next 14/15] nfp: remove defensive checks around ndo_open()/ndo_close()

2017-03-21 Thread Jakub Kicinski
Device open and close handlers check if the device is already in the desired state. Thanks to our reconfig infrastructure this should not be necessary, there doesn't seem to be any code in the driver which depends on it. Signed-off-by: Jakub Kicinski ---

[PATCH net-next 09/15] nfp: fix invalid area detection

2017-03-21 Thread Jakub Kicinski
Core should detect when someone is trying to request an access window which is too large for a given type of access. Otherwise the requester will be put on a wait queue for ever without any error message. Add const qualifiers to clarify that we are only looking at read- -only members in relevant

Re: [PATCH net] sctp: remove temporary variable confirm from sctp_packet_transmit

2017-03-21 Thread David Miller
From: Xin Long Date: Sat, 18 Mar 2017 19:12:22 +0800 > Commit c86a773c7802 ("sctp: add dst_pending_confirm flag") introduced > a temporary variable "confirm" in sctp_packet_transmit. > > But it broke the rule that longer lines should be above shorter ones. > Besides, this

[PATCH 1/2] netfilter: ipset: warn users of list:set that parameter 'size' is ignored

2017-03-21 Thread Vishwanath Pai
Since kernel commit 00590fdd5be0 ("netfilter: ipset: Introduce RCU locking in list type"), the parameter 'size' has not been in use and is ignored by the kernel. This is not very apparent to the user. This commit makes 'size' optional and also warns the user if they try to specify it. We also

Re: [PATCH 3/4] flowcache: make struct flow_cache_percpu::hash_rnd_recalc bool

2017-03-21 Thread David Miller
From: Alexey Dobriyan Date: Mon, 20 Mar 2017 01:27:43 +0300 > ->hash_rnd_recalc is only used in boolean context. > > Space savings on x86_64 come from the fact that "MOV rm8, imm8" is > shorter than "MOV rm32, imm32" by at least 3 bytes. > > add/remove: 0/0

[PATCH net] ipv4: provide stronger user input validation in nl_fib_input()

2017-03-21 Thread Eric Dumazet
From: Eric Dumazet Alexander reported a KMSAN splat caused by reads of uninitialized field (tb_id_in) from user provided struct fib_result_nl It turns out nl_fib_input() sanity tests on user input is a bit wrong : User can pretend nlh->nlmsg_len is big enough, but provide

Re: [PATCH net] sch_dsmark: fix invalid skb_cow() usage

2017-03-21 Thread David Miller
From: Eric Dumazet Date: Fri, 17 Mar 2017 08:05:28 -0700 > From: Eric Dumazet > > skb_cow(skb, sizeof(ip header)) is not very helpful in this context. > > First we need to use pskb_may_pull() to make sure the ip header > is in skb linear part, then

Re: [PATCH v2 net-next 0/3] net: stmmac: adding multiple buffers and routing

2017-03-21 Thread David Miller
From: Joao Pinto Date: Fri, 17 Mar 2017 16:11:04 + > As agreed with David Miller, this patch-set is the third and last to enable > multiple queues in stmmac. > > This third one focuses on: > > a) Enable multiple buffering to the driver and queue independent data >

[PATCH net-next 13/15] nfp: flush xmit_more on error paths

2017-03-21 Thread Jakub Kicinski
In case of ring full or DMA mapping error remember to flush xmit_more delayed kicks. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH net-next 05/15] nfp: document expected locking in the core

2017-03-21 Thread Jakub Kicinski
Document which fields of nfp_cpp are protected by which locks. Signed-off-by: Jakub Kicinski --- .../ethernet/netronome/nfp/nfpcore/nfp_cppcore.c | 33 ++ 1 file changed, 27 insertions(+), 6 deletions(-) diff --git

[PATCH v2 net-next 3/4] drivers: net: xgene-v2: Fix port reset

2017-03-21 Thread Iyappan Subramanian
Fixed port reset sequence by adding ECC init. Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene-v2/enet.c | 24 ++-- drivers/net/ethernet/apm/xgene-v2/enet.h | 2 ++ drivers/net/ethernet/apm/xgene-v2/mac.h | 1 - 3 files changed,

[PATCH v2 net-next 1/4] drivers: net: xgene-v2: Add MDIO support

2017-03-21 Thread Iyappan Subramanian
Added phy management support by using phy abstraction layer APIs. Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene-v2/Makefile | 2 +- drivers/net/ethernet/apm/xgene-v2/mac.c| 2 +- drivers/net/ethernet/apm/xgene-v2/mac.h| 1 +

[PATCH v2 net-next 4/4] drivers: net: xgene-v2: misc fixes

2017-03-21 Thread Iyappan Subramanian
Fixed review comments from the previous patch-set. - changed return value check of platform_get_irq() to < 0 - replaced devm_request(free)_irq() calls by request(free)_irq() since they are called from open() and close() - changed sizeof(struct mystruct) to sizeof(*mystruct) - reduced

[PATCH v2 net-next 0/4] drivers: net: xgene-v2: Add MDIO and ethtool support

2017-03-21 Thread Iyappan Subramanian
This patch set, - adds phy management and ethtool support - fixes ethernet reset - addresses review comments from previous patch set Signed-off-by: Iyappan Subramanian --- v2: Address review comments from v1 - removed mdio_lock, since there is a top level lock

[PATCH v2 net-next 2/4] drivers: net: xgene-v2: Add ethtool support

2017-03-21 Thread Iyappan Subramanian
Added basic ethtool support. Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene-v2/Makefile | 2 +- drivers/net/ethernet/apm/xgene-v2/ethtool.c | 121 drivers/net/ethernet/apm/xgene-v2/main.c| 1 +

Re: [PATCH net] sctp: define dst_pending_confirm as a bit in sctp_transport

2017-03-21 Thread David Miller
From: Xin Long Date: Sat, 18 Mar 2017 19:27:23 +0800 > As tp->dst_pending_confirm's value can only be set 0 or 1, this > patch is to change to define it as a bit instead of __u32. > > Signed-off-by: Xin Long Applied.

Re: [PATCH net] sctp: out_qlen should be updated when pruning unsent queue

2017-03-21 Thread David Miller
From: Xin Long Date: Sat, 18 Mar 2017 20:03:59 +0800 > This patch is to fix the issue that sctp_prsctp_prune_sent forgot > to update q->out_qlen when removing a chunk from unsent queue. > > Fixes: 8dbdf1f5b09c ("sctp: implement prsctp PRIO policy") > Signed-off-by: Xin

Re: [PATCH v2 net] selftests/bpf: fix broken build, take 2

2017-03-21 Thread David Miller
From: Shuah Khan Date: Mon, 20 Mar 2017 10:37:26 -0600 > On 03/20/2017 09:45 AM, Alexei Starovoitov wrote: >> On Mon, Mar 20, 2017 at 04:31:28PM +0100, Daniel Borkmann wrote: >>> On 03/20/2017 07:03 AM, Zi Shen Lim wrote: Merge of 'linux-kselftest-4.11-rc1': 1.

[PATCH] netfilter: ipset: print out warnings generated by commands

2017-03-21 Thread Vishwanath Pai
Warnings are only printed out for IPSET_CMD_TEST. The user won't see warnings from other commands. Reviewed-by: Josh Hunt Signed-off-by: Vishwanath Pai --- src/ipset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ipset.c

Re: [patch net-next 0/2] mlxsw: small driver update

2017-03-21 Thread David Miller
From: Jiri Pirko Date: Fri, 17 Mar 2017 09:37:59 +0100 > From: Jiri Pirko > > Contains two cleanup patches. Series applied, thanks.

Re: [PATCH net-next] r8152: check hw version first

2017-03-21 Thread David Miller
From: Hayes Wang Date: Fri, 17 Mar 2017 11:20:13 +0800 > Check hw version first in probe(). Do nothing if the driver doesn't > support the chip. > > Signed-off-by: Hayes Wang Applied, thanks.

Re: [PATCH net-next] net: ethoc: Use ether_addr_copy()

2017-03-21 Thread David Miller
From: Tobias Klauser Date: Fri, 17 Mar 2017 11:52:15 +0100 > Use ether_addr_copy() instead of memcpy() to set netdev->dev_addr (which > is 2-byte aligned). > > Signed-off-by: Tobias Klauser Applied.

Re: [PATCH net,stable] qmi_wwan: add Dell DW5811e

2017-03-21 Thread David Miller
From: Bjørn Mork Date: Fri, 17 Mar 2017 17:20:48 +0100 > This is a Dell branded Sierra Wireless EM7455. It is operating in > MBIM mode by default, but can be configured to provide two QMI/RMNET > functions. > > Signed-off-by: Bjørn Mork > --- > Note regarding

Re: [PATCH net-next] liquidio: remove duplicate code

2017-03-21 Thread David Miller
From: Felix Manlunas Date: Fri, 17 Mar 2017 10:50:05 -0700 > From: Satanand Burla > > Remove code duplicated in PF and VF; define that code once only in a common > header file included by PF and VF. > > Signed-off-by: Satanand Burla

Re: [PATCH] bna: integer overflow bug in debugfs

2017-03-21 Thread David Miller
From: Dan Carpenter Date: Fri, 17 Mar 2017 23:52:35 +0300 > We could allocate less memory than intended because we do: > > bnad->regdata = kzalloc(len << 2, GFP_KERNEL); > > The shift can overflow leading to a crash. This is debugfs code so the > impact is very

Re: [PATCH net-next] liquidio: add debug error messages to report command timeout

2017-03-21 Thread David Miller
From: Felix Manlunas Date: Fri, 17 Mar 2017 11:23:08 -0700 > From: Rick Farrington > > Add timeout error message in lio_process_ordered_list(). Add host failure > status in existing error message in if_cfg_callback(). > >

Re: [PATCH net-next] liquidio: fix for vf mac addr command sent to nic firmware

2017-03-21 Thread David Miller
From: Felix Manlunas Date: Fri, 17 Mar 2017 15:43:26 -0700 > From: Rick Farrington > > Change to support host<->firmware command return value. > Fix for vf mac addr state command. > 1. Added support for firmware commands to return a

Re: [PATCH] net: vrf: Reset rt6i_idev in local dst after put

2017-03-21 Thread David Miller
From: David Ahern Date: Fri, 17 Mar 2017 16:07:11 -0700 > The VRF driver takes a reference to the inet6_dev on the VRF device for > its rt6_local dst when handling local traffic through the VRF device as > a loopback. When the device is deleted the driver does a put on

[PATCH net-next 04/15] nfp: move mutex code out of nfp_cppcore.c

2017-03-21 Thread Jakub Kicinski
After mutex cache removal we can put the mutex code in a separate source file. This makes it clear it doesn't play with internals of struct nfp_cpp any more. No functional changes. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/Makefile

[PATCH net-next 00/15] nfp: allow concurrency in core and minor fixes

2017-03-21 Thread Jakub Kicinski
Hi! The first 10 patches of this series prepare nfpcore for concurrent accesses. This will be needed by upcoming hwmon and devlink patches. Most locking is already in place, the patches in this series iron out a few bugs. Last 5 patches are fixes and cleanups to the netdev code, including

[PATCH net-next 07/15] nfp: correct return codes when msleep gets interrupted

2017-03-21 Thread Jakub Kicinski
msleep_interruptible() returns time left to wait, not error code. Return ERESTARTSYS when interrupted. While at it correct a comment and make the polling a bit more aggressive. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c

[PATCH net-next 02/15] nfp: fail graciously when someone tries to grab global lock

2017-03-21 Thread Jakub Kicinski
The global device lock is acquired to search the resource table. The lock is actually itself part of the table (entry 0). Therefore if someone asks for resource 0 we would deadlock since double locking is no longer allowed. Currently the driver doesn't try to lock that resource so let's simply

[PATCH net-next 15/15] nfp: disable FW on reconfiguration errors

2017-03-21 Thread Jakub Kicinski
Since we no longer need to keep the FW enabled for .ndo_close() to work we can always stop FW after reconfiguration failure. This seems to make most FWs more resilient to faults (at least in error injection scenarios). Signed-off-by: Jakub Kicinski ---

[PATCH net-next 01/15] nfp: disallow sharing mutexes on the same machine

2017-03-21 Thread Jakub Kicinski
NFP can be connected to multiple machines via PCI or other buses. Access to hardware resources is arbitrated using locks residing in device memory. Currently nfpcore only respects the mutexes when it comes to inter-host locking, but if we try to acquire the same lock again, on one host - it will

[PATCH net-next 06/15] nfp: lock area cache earlier

2017-03-21 Thread Jakub Kicinski
We shouldn't access area_cache_list without its lock even to check if it's empty. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git

[PATCH net-next 10/15] nfp: fix nfp_cpp_read()/nfp_cpp_write() error paths

2017-03-21 Thread Jakub Kicinski
When acquiring an area fails we can't call function doing both release and free. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

[PATCH net-next 11/15] nfp: don't use netdev_warn() before netdev is registered

2017-03-21 Thread Jakub Kicinski
Fix warning which was using netdev_warn() instead of dev_warn() to early. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH net-next 12/15] nfp: remove RX queue pointers

2017-03-21 Thread Jakub Kicinski
NFP6000 doesn't use queue pointers/doorbells for RX, it uses 'done' bit in descriptors. Remove the pointers from data structures. Since we are saving space in rx_ring structure make fields we previously compressed to 16bits word size again. Signed-off-by: Jakub Kicinski

[PATCH net-next 03/15] nfp: remove cpp mutex cache

2017-03-21 Thread Jakub Kicinski
CPP mutex cache was introduced to work around the fact that the same host could successfully acquire a lock multiple times. It used to collapse multiple users to the same struct nfp_cpp_mutex and track use count. Unfortunately it's racy. Since we now force all nfp_mutex_lock() callers within

  1   2   3   >