Re: [PATCH net-next] bpf: remove reference to sock_filter_ext from kerneldoc comment

From: Tobias Klauser Date: Tue, 18 Apr 2017 11:27:00 +0200 > struct sock_filter_ext didn't make it into the tree and is now called > struct bpf_insn. Reword the kerneldoc comment for bpf_convert_filter() > accordingly. > > Signed-off-by: Tobias Klauser

[PATCH netnext 0/3] packet: Add option to create new fanout group with unique id.

From: Mike Maloney Fanout uses a per net global namespace. A process that intends to create a new fanout group can accidentally join an existing group. It is not possible to detect this. Add a socket option to specify on the first call to setsockopt(..., PACKET_FANOUT, ...)

Re: [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable

+ linux-wireless On 4/20/2017 1:16 PM, James Hughes wrote: The driver was adding header information to incoming skb without ensuring the head was uncloned and hence writable. skb_cow_head has been used to ensure they are writable, however, this required some changes to error handling to ensure

Re: stmmac still supporting spear600 ?

Viresh, Shiraz, As the SPEAr600 platform maintainers, have you tested Ethernet in recent times, especially with a MII PHY ? I'm still struggling to get it working. Quick summary: - The same kernel works fine on another SPEAr600 platform that has a GMII PHY - The SPEAr600 platform with a

Re: net/xfrm: stack-out-of-bounds in xfrm_state_find

2017-04-20, 19:30:27 +0200, Andrey Konovalov wrote: > On Thu, Apr 20, 2017 at 6:47 PM, Andrey Konovalov > wrote: > > Hi, > > > > I've got the following error report while fuzzing the kernel with syzkaller. > > > > On linux-next commit

Re: [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable

On 4/20/2017 2:09 PM, James Hughes wrote: On 20 April 2017 at 12:31, Kalle Valo wrote: + linux-wireless James Hughes writes: The driver was adding header information to incoming skb without ensuring the head was uncloned and hence

Re: [PATCH] netpoll: Check for skb->queue_mapping

On Thu, Apr 20, 2017 at 12:08 PM, tndave wrote: > > > On 04/12/2017 03:37 PM, tndave wrote: >> >> >> >> On 04/06/2017 12:14 PM, Eric Dumazet wrote: >>> >>> On Thu, 2017-04-06 at 12:07 -0700, tndave wrote: >>> > +q_index = q_index %

Re: [PATCH net] mac80211: reject ToDS broadcast data frames

From: Johannes Berg Date: Thu, 20 Apr 2017 21:32:16 +0200 > From: Johannes Berg > > AP/AP_VLAN modes don't accept any real 802.11 multicast data > frames, but since they do need to accept broadcast management > frames the same is currently

Re: [PATCH] dp83640: don't recieve time stamps twice

From: Richard Cochran Date: Wed, 19 Apr 2017 12:31:35 +0200 > On Wed, Apr 19, 2017 at 09:16:56AM +, Sørensen, Stefan wrote: >> You are correct that these lines was added accidentally. > > Can we please fix this in another way? There is no need to hold the > spin

Re: pull request (net): ipsec 2017-04-19

From: Steffen Klassert Date: Wed, 19 Apr 2017 07:10:34 +0200 > Two fixes for af_key: > > 1) Add a lock to key dump to prevent a NULL pointer dereference. >From Yuejie Shi. > > 2) Fix slab-out-of-bounds in parse_ipsecrequests. >From Herbert Xu. > > Please

[PATCH net-next 2/3] net/tcp_fastopen: Add snmp counter for blackhole detection

From: Wei Wang This counter records the number of times the firewall blackhole issue is detected and active TFO is disabled. Signed-off-by: Wei Wang --- include/net/tcp.h | 2 +- include/uapi/linux/snmp.h | 1 + net/ipv4/proc.c | 1 +

Re: net/bonding: stack-out-of-bounds in bond_enslave

On Thu, Apr 20, 2017 at 9:32 AM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On linux-next commit 4f7d029b9bf009fbee76bb10c0c4351a1870d2f3 (4.11-rc7). > > A reproducer and .config are attached. > >

[PATCH net-next 3/3] net/tcp_fastopen: Remove mss check in tcp_write_timeout()

From: Wei Wang Christoph Paasch from Apple found another firewall issue for TFO: After successful 3WHS using TFO, server and client starts to exchange data. Afterwards, a 10s idle time occurs on this connection. After that, firewall starts to drop every packet on this

Re: [PATCH net] netdevice: Prefer NETIF_F_HW_CSUM when intersecting features

On 04/20/2017 02:36 PM, Alexander Duyck wrote: > On Wed, Apr 19, 2017 at 6:12 PM, Vladislav Yasevich > wrote: >> While hardware device use either NETIF_F_(IP|IPV6)_CSUM or >> NETIF_F_HW_CSUM, all of the software devices use HW_CSUM. >> This results in an interesting

Re: [PATCH net-next 0/2] tcp: address two poll() flakes

From: Eric Dumazet Date: Tue, 18 Apr 2017 09:45:50 -0700 > Some packetdrill tests are failing when host kernel is using ASAN > or other debugging infrastructure. > > I was able to fix the flakes by making sure we were not > sending wakeup events too soon. Series applied,

RE: [net-next 04/14] i40e: dump VF information in debugfs

> > the HW pipeline itself can't be abstracted in this case. > > I've heard that argument before, and I'm glad Jiri didn't drink the koolaide > and instead wrote dpipe. Perhaps "can't" was the wrong term to use, but I still believe there's an inherent problem with applying the dpipe approach

RE: [net-next 04/14] i40e: dump VF information in debugfs

> > I surely wouldn't want to write a million lines of code just to > > provide such a detailed abstraction. > > So now the argument has gone from "it's not possible" to "it's going to be a > HUGE amount of code." Nothing here's is strictly impossible - you can always create a simulated HW model

Re: [PATCHv2 next] bonding: fix wq initialization for links created via netlink

On Thu, Apr 20, 2017 at 12:49:24PM -0700, Mahesh Bandewar wrote: > From: Mahesh Bandewar > > Earlier patch 4493b81bea ("bonding: initialize work-queues during > creation of bond") moved the work-queue initialization from bond_open() > to bond_create(). However this caused the

[PATCH net-next 1/3] net/tcp_fastopen: Disable active side TFO in certain scenarios

From: Wei Wang Middlebox firewall issues can potentially cause server's data being blackholed after a successful 3WHS using TFO. Following are the related reports from Apple: https://www.nanog.org/sites/default/files/Paasch_Network_Support.pdf Slide 31 identifies an issue

[PATCH net-next 0/3] net/tcp_fastopen: Fix for various TFO firewall issues

From: Wei Wang Currently there are still some firewall issues in the middlebox which make the middlebox drop packets silently for TFO sockets. This kind of issue is hard to be detected by the end client. This patch series tries to detect such issues in the kernel and disable

Re: [PATCH net-next] qede: allocate enough data for ->arfs_fltr_bmap

From: Dan Carpenter Date: Wed, 19 Apr 2017 12:54:33 +0300 > We've got the number of longs, yes, but we should multiply by > sizeof(long) to get the number of bytes needed. > > Fixes: e4917d46a653 ("qede: Add aRFS support") > Signed-off-by: Dan Carpenter

Re: [PATCH v3 net] net sched actions: allocate act cookie early

From: Wolfgang Bumiller Date: Thu, 20 Apr 2017 14:08:26 +0200 > Policing filters do not use the TCA_ACT_* enum and the tb[] > nlattr array in tcf_action_init_1() doesn't get filled for > them so we should not try to look for a TCA_ACT_COOKIE > attribute in the then

Re: [PATCH] Fix values type used in test_maps

On 04/20/2017 09:20 PM, David Miller wrote: Maps of per-cpu type have their value element size adjusted to 8 if it is specified smaller during various map operations. This makes test_maps as a 32-bit binary fail, in fact the kernel writes past the end of the value's array on the user's stack.

[PATCH] Fix values type used in test_maps

Maps of per-cpu type have their value element size adjusted to 8 if it is specified smaller during various map operations. This makes test_maps as a 32-bit binary fail, in fact the kernel writes past the end of the value's array on the user's stack. To be quite honest, I think the kernel should

Re: [patch net-next 0/8] mlxsw: Allow flow based forwarding in OVS

From: Jiri Pirko Date: Tue, 18 Apr 2017 16:55:30 +0200 > This patchset does some fixes so the HW is setup correctly to do > flow-based (ACL based) forwarding for OVS-enslaved port. > > The first patch is just trivial fix spotted on the way. > > Patches 2-4 take care of proper

mlx5en not able to communicate between VF and PF

After figuring out that CentOS requires a newer version of iproute to enable trust mode on VFs, I'm now having a problem getting a VM on a bridge on a VF to communicate with the host on the PF or a different VF. The set-up: Host1Host2

Re: [PATCH v2 0/3] uapi glibc compat: fix musl libc compatibility

From: Hauke Mehrtens Date: Tue, 18 Apr 2017 23:00:33 +0200 > The code from libc-compat.h depends on some glibc specific defines and > causes compile problems with the musl libc. These patches remove some > of the glibc dependencies. With these patches the LEDE (OpenWrt) base

Re: [PATCH v2 0/3] uapi glibc compat: fix musl libc compatibility

From: David Woodhouse Date: Thu, 20 Apr 2017 21:14:37 +0100 > I agree, except I don't think you're going far enough. Those "standard > names" you mention... some of this stuff actually depends on __GLIBC__, > and *that* isn't right either. Yep, that's something that needs

Re: more on FP operations

On 04/20/2017 08:06 PM, David Miller wrote: I'm running test_verifier for testing, and I notice in my JIT that a 32-bit move from the frame pointer (BPF_REG_10) ends up in the JIT. It is from this test: "unpriv: partial copy of pointer", .insns = {

Re: [PATCH 1/1] bonding: use 'M' or 'G' based on the speed

On Thu, 20 Apr 2017 05:06:35 -0400 Zhu Yanjun wrote: > If the speed of the slave netdev is more than 1000M, > it is better to use 'G' instead of 'M'. > > Signed-off-by: Zhu Yanjun > --- > drivers/net/bonding/bond_main.c | 8 ++-- >

[PATCH stable 4.4] tipc: fix crash during node removal

From: Jon Paul Maloy commit d25a01257e422a4bdeb426f69529d57c73b235fe upstream When the TIPC module is unloaded, we have identified a race condition that allows a node reference counter to go to zero and the node instance being freed before the node timer is finished with

Re: [PATCH v4] smsc95xx: Use skb_cow_head to deal with cloned skbs

From: James Hughes Date: Wed, 19 Apr 2017 11:13:40 +0100 > The driver was failing to check that the SKB wasn't cloned > before adding checksum data. > Replace existing handling to extend/copy the header buffer > with skb_cow_head. > > Signed-off-by: James Hughes

Re: [PATCH net-next] net/mlx5e: IPoIB, Fix error handling in mlx5_rdma_netdev_alloc()

From: Dan Carpenter Date: Wed, 19 Apr 2017 12:59:15 +0300 > The labels were out of order, so it either could result in an Oops or a > leak. > > Fixes: 48935bbb7ae8 ("net/mlx5e: IPoIB, Add netdevice profile skeleton") > Signed-off-by: Dan Carpenter

Re: [PATCH net 0/4] qed: Dcbx bug fixes

From: Sudarsana Reddy Kalluru Date: Wed, 19 Apr 2017 03:19:51 -0700 > The series has set of bug fixes for dcbx implementation of qed driver. > Please consider applying this to 'net' branch. Series applied, thanks.

Re: [net-next 04/14] i40e: dump VF information in debugfs

From: "Mintz, Yuval" Date: Thu, 20 Apr 2017 20:50:55 + > Nope, I don't mind doing the work. What I would appreciate is some > constructive suggestions on a seemingly feasible approach that might work. > I feel like I've been bashed enough for one day. :-) Well, it

[GIT] [4.12] NFC update

Hi David, This is the NFC pull request for 4.12. We have: - Improvements for the pn533 command queue handling and device registration order. - Removal of platform data for the pn544 and st21nfca drivers. - Additional device tree options to support more trf7970a hardware options. - Support for

Re: [PATCH net] selftests/net: Fixes psock_fanout CBPF test case

From: Mike Maloney Date: Tue, 18 Apr 2017 11:14:16 -0400 > From: Mike Maloney > > 'psock_fanout' has been failing since commit 4d7b9dc1f36a9 ("tools: > psock_lib: harden socket filter used by psock tests"). That commit > changed the CBPF filter to

Re: [PATCH] net/packet: initialize val in packet_getsockopt()

From: Alexander Potapenko Date: Tue, 18 Apr 2017 19:47:08 +0200 > In the case getsockopt() is called with PACKET_HDRLEN and zero length, > |val| remains uninitialized and the syscall may behave differently > depending on its value. This doesn't have security consequences (as

Order

Hi , I would like to place an order for some items which I want to know the below : Do you ship to Liechtenstein ? Do you accept Credit Card payment Also send me your current product price list. Thanks

Re: [PATCH] netpoll: Check for skb->queue_mapping

On 04/12/2017 03:37 PM, tndave wrote: On 04/06/2017 12:14 PM, Eric Dumazet wrote: On Thu, 2017-04-06 at 12:07 -0700, tndave wrote: +q_index = q_index % dev->real_num_tx_queues; cpu interrupted here and dev->real_num_tx_queues has reduced! +

[PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

While hardware device use either NETIF_F_(IP|IPV6)_CSUM or NETIF_F_HW_CSUM, all of the software devices use HW_CSUM. This results in an interesting situation when the software device is configured on top of hw device using (IP|IPV6)_CSUM. In this situation, the user can't turn off checksum

[PATCH netnext 1/3] selftests/net: cleanup unused parameter in psock_fanout

From: Mike Maloney sock_fanout_open no longer sets the size of packet_socket ring, so stop passing the parameter. Tested: Built and ran the test, it passed. Signed-off-by: Mike Maloney Acked-by: Willem de Bruijn ---

[PATCH netnext 3/3] selftests/net: add tests for PACKET_FANOUT_FLAG_UNIQUEID

From: Mike Maloney Create two groups with PACKET_FANOUT_FLAG_UNIQUEID, add a socket to one. Ensure that the groups can only be joined if all options are consistent with the original except for this flag. Tested: ran tools/testing/selftests/net/psock_fanout 10 times, all

Re: [PATCH net-next] tcp_cubic: fix typo in module param description

From: Chema Gonzalez Date: Tue, 18 Apr 2017 19:22:23 -0700 > From: Chema Gonzalez > > Signed-off-by: Chema Gonzalez Applied, thanks.

Re: [net-next 04/14] i40e: dump VF information in debugfs

From: "Mintz, Yuval" Date: Thu, 20 Apr 2017 20:12:59 + > I surely wouldn't want to write a million lines of code just to > provide such a detailed abstraction. So now the argument has gone from "it's not possible" to "it's going to be a HUGE amount of code." I

[PATCH net] mac80211: reject ToDS broadcast data frames

From: Johannes Berg AP/AP_VLAN modes don't accept any real 802.11 multicast data frames, but since they do need to accept broadcast management frames the same is currently permitted for data frames. This opens a security problem because such frames would be decrypted

Re: [PATCH net] ipv6: sr: fix out-of-bounds access in SRH validation

From: David Lebrun Date: Tue, 18 Apr 2017 17:59:49 +0200 > This patch fixes an out-of-bounds access in seg6_validate_srh() when the > trailing data is less than sizeof(struct sr6_tlv). > > Reported-by: Andrey Konovalov > Cc: Andrey Konovalov

[PATCHv2 next] bonding: fix wq initialization for links created via netlink

From: Mahesh Bandewar Earlier patch 4493b81bea ("bonding: initialize work-queues during creation of bond") moved the work-queue initialization from bond_open() to bond_create(). However this caused the link those are created using netlink 'create bond option' (ip link add

Re: [PATCH net-next v3] bindings: net: stmmac: add missing note about LPI interrupt

On Tue, Apr 18, 2017 at 02:39:53PM +0200, Niklas Cassel wrote: > From: Niklas Cassel > > The hardware has a LPI interrupt. > There is already code in the stmmac driver to parse and handle the > interrupt. However, this information was missing from the DT binding. > > At

Re: [net-next 00/15][pull request] 10GbE Intel Wired LAN Driver Updates 2017-04-18

From: Jeff Kirsher Date: Tue, 18 Apr 2017 16:01:50 -0700 > This series contains updates to mainly ixgbe with only one ixgbevf > change. Pulled, thanks Jeff.

Re: [PATCH net-next 1/2] Add Cong Wang as TC subsystem co-maintainer

From: Jamal Hadi Salim Date: Tue, 18 Apr 2017 21:23:59 -0400 > From: Jamal Hadi Salim > > Signed-off-by: Jamal Hadi Salim Applied.

Re: [PATCH v2 0/3] uapi glibc compat: fix musl libc compatibility

On Thu, 2017-04-20 at 16:07 -0400, David Miller wrote: > > I think I have to put the brakes on this patch series, after much > consideration. > > It does not scale if we continually add a hodge-podge of different > ifdef tests to the UAPI headers in order to prevent mutliple > definitions. > >

Re: [PATCH net-next 2/2] Add Jiri Pirko as TC subsystem co-maintainer

From: Jamal Hadi Salim Date: Tue, 18 Apr 2017 21:24:00 -0400 > From: Jamal Hadi Salim > > Signed-off-by: Jamal Hadi Salim Applied.

Re: [PATCH] MAINTAINERS: update entry for TI's CPSW driver

From: Sekhar Nori Date: Wed, 19 Apr 2017 14:08:24 +0530 > Mugunthan V N, who was reviewing TI's CPSW driver patches is > not working for TI anymore and wont be reviewing patches for > that driver. > > Drop Mugunthan as the maintiainer for this driver. > > Grygorii continues to

Re: [PATCH net-next 00/16] Mellanox, mlx5 RDMA net device support

On Thu, 2017-04-20 at 21:49 +0300, Leon Romanovsky wrote: > On Thu, Apr 20, 2017 at 02:41:17PM -0400, Doug Ledford wrote: > > > > On Mon, 2017-04-17 at 11:08 -0400, David Miller wrote: > > > > > > From: Saeed Mahameed > > > Date: Thu, 13 Apr 2017 06:36:50 +0300 > > > > > >

Re: [PATCH] dp83640: don't recieve time stamps twice

On Thu, Apr 20, 2017 at 04:02:27PM -0400, David Miller wrote: > Oops, I read this too late. > > I already applied and pushed out Dan's fix. No problem, i'll submit a patch on top of that to move the netif calls out of the spin-locked regions. Thanks, Richard

Re: [PATCH v4 net-next RFC] net: Generic XDP

On Wed, Apr 19, 2017 at 09:40:49PM -0400, David Miller wrote: > From: Andy Gospodarek > Date: Wed, 19 Apr 2017 10:29:03 -0400 > > > So I tried a variety of things and the simplest change on top of yours that > > works well for xdp1, xdp2, and xdp_tx_iptunnel. > > > > diff

[net-next 4/7] igb: improve MAC filter handling

From: Yury Kylulin Using the work which was done for ixgbe driver by Jacob Keller commit 5d7daa35b9eb ("ixgbe: improve mac filter handling") and Alexander Duyck commit 0f079d22834a ("ixgbe: Use __dev_uc_sync and __dev_uc_unsync for unicast addresses") and out-of-tree igb

[net-next 0/7][pull request] 1GbE Intel Wired LAN Driver Updates 2017-04-20

This series contains updates to e1000, e1000e, igb/vf and ixgb. Tobias Klauser cleans up e1000, ixgb and igbvf from having a local function or structure for netdev stats. Bernd Faust fixes an issue for 82579 devices, where the clock frequency was being incorrectly set for these devices. These

[net-next 1/7] e1000: Omit private ndo_get_stats function

From: Tobias Klauser e1000_get_stats() just returns dev->stats so we can leave it out altogether and let dev_get_stats() do the job. Suggested-by: Joe Perches Signed-off-by: Tobias Klauser Tested-by: Aaron Brown

[net-next 3/7] e1000e: fix timing for 82579 Gigabit Ethernet controller

From: Bernd Faust After an upgrade to Linux kernel v4.x the hardware timestamps of the 82579 Gigabit Ethernet Controller are different than expected. The values that are being read are almost four times as big as before the kernel upgrade. The difference is that after the

[net-next 2/7] ixgb: Omit private ndo_get_stats function

From: Tobias Klauser ixgb_get_stats() just returns dev->stats so we can leave it out altogether and let dev_get_stats() do the job. Suggested-by: Joe Perches Signed-off-by: Tobias Klauser Tested-by: Aaron Brown

[net-next 5/7] igb/igbvf: Add VF MAC filter request capabilities

From: Yury Kylulin Add functionality for the VF to request up to 3 additional MAC filters. This is done using existing E1000_VF_SET_MAC_ADDR message, but with additional message info - E1000_VF_MAC_FILTER_CLR to clear all unicast MAC filters previously set for this VF and

[net-next 7/7] igbvf: Use net_device_stats from struct net_device

From: Tobias Klauser Instead of using a private copy of struct net_device_stats in struct igbvf_adapter, use stats from struct net_device. Also remove the now unnecessary .ndo_get_stats function. Signed-off-by: Tobias Klauser Tested-by: Aaron Brown

[net:master 15/18] drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1267:13-20: WARNING: kzalloc should be used for dcbx_info, instead of kmalloc/memset

tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master head: e0535ce58b92d7baf0b33284a6c4f8f0338f943e commit: 62289ba27558553871fd047baadaaeda886c6a63 [15/18] qed: Fix possible system hang in the dcbnl-getdcbx() path. coccinelle warnings: (new ones prefixed by >>) >>

Re: [PATCH net-next 2/3] net/tcp_fastopen: Add snmp counter for blackhole detection

On Thu, Apr 20, 2017 at 2:45 PM, Wei Wang wrote: > From: Wei Wang > > This counter records the number of times the firewall blackhole issue is > detected and active TFO is disabled. > > Signed-off-by: Wei Wang Acked-by: Yuchung Cheng

Re: [PATCH v3 net-next 5/8] net/ncsi: Dump NCSI packet statistics

On Fri, 2017-04-21 at 11:35 +1000, Gavin Shan wrote: > Yes, it's definitely good idea to cover everything using one interface. > It's for sure that the statistics collected by hardware should be dumped > by ethtool in future. I will move functionalities introduced by this > patchset to ethtool as

Re: [PATCH net-next 00/16] Mellanox, mlx5 RDMA net device support

On Thu, Apr 20, 2017 at 04:45:43PM -0400, Doug Ledford wrote: > On Thu, 2017-04-20 at 21:49 +0300, Leon Romanovsky wrote: > > On Thu, Apr 20, 2017 at 02:41:17PM -0400, Doug Ledford wrote: > > > > > > On Mon, 2017-04-17 at 11:08 -0400, David Miller wrote: > > > > > > > > From: Saeed Mahameed

Re: [PATCH net-next 0/3] l3mdev: Improve use with main table

On 4/10/17 8:21 AM, Robert Shearman wrote: > Attempting to create a TCP socket not bound to a VRF device when a TCP > socket bound to a VRF device with the same port exists (and vice > versa) fails with EADDRINUSE. This limits the ability to use programs > in selected mixed VRF/non-VRF contexts. >

Re: [PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

On 04/20/2017 06:31 PM, Alexander Duyck wrote: > On Thu, Apr 20, 2017 at 12:17 PM, Vladislav Yasevich > wrote: >> While hardware device use either NETIF_F_(IP|IPV6)_CSUM or >> NETIF_F_HW_CSUM, all of the software devices use HW_CSUM. >> This results in an interesting

RE: netlink: question about netlink testsuite

Hi, > -Original Message- > From: Cong Wang [mailto:xiyou.wangc...@gmail.com] > Sent: Wednesday, April 19, 2017 3:06 PM > Hello, > > On Tue, Apr 18, 2017 at 10:00 PM, Yasuhara, Hiroyuki > wrote: > > Hi, > > > > I'm looking for a testset about netlink function,

Re: [PATCH v3 net-next 5/8] net/ncsi: Dump NCSI packet statistics

On 04/20/2017 04:38 PM, Gavin Shan wrote: > On Thu, Apr 20, 2017 at 01:21:03PM -0400, David Miller wrote: >> From: Gavin Shan >> Date: Tue, 18 Apr 2017 16:51:32 +1000 >> >>> This creates /sys/kernel/debug/ncsi//stats to dump the NCSI >>> packets sent and received over

Re: [PATCH v3 net-next 5/8] net/ncsi: Dump NCSI packet statistics

On Thu, Apr 20, 2017 at 05:26:14PM -0700, Florian Fainelli wrote: >On 04/20/2017 04:38 PM, Gavin Shan wrote: >> On Thu, Apr 20, 2017 at 01:21:03PM -0400, David Miller wrote: >>> From: Gavin Shan >>> Date: Tue, 18 Apr 2017 16:51:32 +1000 >>> This creates

Re: [PATCH v3 net-next 5/8] net/ncsi: Dump NCSI packet statistics

On Thu, Apr 20, 2017 at 05:58:58PM -0700, David Miller wrote: >From: Gavin Shan >Date: Fri, 21 Apr 2017 09:38:12 +1000 > >> (1) ethtool usually dumps statistics collected by hardware, but this >> debugfs file dumps the statistics of packets seen (collected) by >>

Re: [PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

On Thu, Apr 20, 2017 at 4:19 PM, Vlad Yasevich wrote: > On 04/20/2017 06:31 PM, Alexander Duyck wrote: >> On Thu, Apr 20, 2017 at 12:17 PM, Vladislav Yasevich >> wrote: >>> While hardware device use either NETIF_F_(IP|IPV6)_CSUM or >>> NETIF_F_HW_CSUM,

[PATCH 1/2] ipv6: check raw payload size correctly in ioctl

In situations where an skb is paged, the transport header pointer and tail pointer will be the same because the payload is in skb frags. This results in ioctl(SIOCINQ/FIONREAD) returning a length of 0 when the length to receive is actually greater than zero. skb->len is already correctly set in

[PATCH 2/2] ipv6: don't deliver packets with zero length to raw sockets

IPv6 assumes there is data after the network header and blindly delivers skbs to raw sockets without checking the presence of data. With an application in a common loop where it checks select/poll/epoll then ioctl(SIOCINQ/FIONREAD) is positive before continuing to recvfrom(), this behaviour can

Re: [PATCH] p54: Prevent from dereferencing null pointer when releasing SKB

On Thu, Apr 20, 2017 at 04:03:43PM -0700, Greg Rose wrote: > On Thu, 2017-04-20 at 11:25 -0700, Myungho Jung wrote: > > Added NULL check to make __dev_kfree_skb_irq consistent with kfree > > family of functions. > > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=195289 > > > >

[net-next 6/7] igb: Enable reading of wake up packet

From: Kim Tatt Chuah Currently, in igb_resume(), igb driver ignores the Wake Up Status (WUS) and Wake Up Packet Memory (WUPM) registers. This patch enables the igb driver to read the WUPM if the controller was woken by a wake up packet that is not more than 128 bytes

Re: [PATCH net] net: ipv6: RTF_PCPU should not be settable from userspace

On Thu, Apr 20, 2017 at 04:37:18PM -0700, Cong Wang wrote: > On Thu, Apr 20, 2017 at 3:43 PM, David Ahern wrote: > > > > I scanned the others. It is not clear that others should fail with > > EINVAL. Certainly a mask of unused flags can be added, but to me that is > > on

Re: [PATCH net-next 1/3] net/tcp_fastopen: Disable active side TFO in certain scenarios

On Thu, Apr 20, 2017 at 2:45 PM, Wei Wang wrote: > From: Wei Wang > > Middlebox firewall issues can potentially cause server's data being > blackholed after a successful 3WHS using TFO. Following are the related > reports from Apple: >

Re: [PATCH net-next 3/3] net/tcp_fastopen: Remove mss check in tcp_write_timeout()

On Thu, Apr 20, 2017 at 2:45 PM, Wei Wang wrote: > From: Wei Wang > > Christoph Paasch from Apple found another firewall issue for TFO: > After successful 3WHS using TFO, server and client starts to exchange > data. Afterwards, a 10s idle time occurs on this

Re: [PATCH v3 net-next 5/8] net/ncsi: Dump NCSI packet statistics

From: Gavin Shan Date: Fri, 21 Apr 2017 09:38:12 +1000 > (1) ethtool usually dumps statistics collected by hardware, but this > debugfs file dumps the statistics of packets seen (collected) by > software. ethtool is not strictly for hardware statistics, it's often

Re: [PATCH v3 net-next] mdio_bus: Issue GPIO RESET to PHYs.

On Thu, Apr 20, 2017 at 05:11:53PM +0300, Roger Quadros wrote: > Some boards [1] leave the PHYs at an invalid state > during system power-up or reset thus causing unreliability > issues with the PHY which manifests as PHY not being detected > or link not functional. To fix this, these PHYs need to

Re: [PATCH net-next 3/3] net/tcp_fastopen: Remove mss check in tcp_write_timeout()

On Thu, Apr 20, 2017 at 5:29 PM, Yuchung Cheng wrote: > On Thu, Apr 20, 2017 at 2:45 PM, Wei Wang wrote: >> From: Wei Wang >> >> Christoph Paasch from Apple found another firewall issue for TFO: >> After successful 3WHS using TFO, server

Re: [PATCH net-next 2/3] net/tcp_fastopen: Add snmp counter for blackhole detection

On Thu, Apr 20, 2017 at 8:30 PM, Yuchung Cheng wrote: > On Thu, Apr 20, 2017 at 2:45 PM, Wei Wang wrote: >> From: Wei Wang >> >> This counter records the number of times the firewall blackhole issue is >> detected and active TFO is

RE: [net-next 04/14] i40e: dump VF information in debugfs

> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of David Miller > Sent: Thursday, April 20, 2017 8:20 AM > To: yuval.mi...@cavium.com > Cc: gerlitz...@gmail.com; Kirsher, Jeffrey T ; > Williams,

[PATCH net-next] net: dsa: Remove redundant NULL dst check

tag_lan9303.c does check for a NULL dst but that's already checked by dsa_switch_rcv() one layer above. Signed-off-by: Florian Fainelli --- net/dsa/tag_lan9303.c | 5 - 1 file changed, 5 deletions(-) diff --git a/net/dsa/tag_lan9303.c b/net/dsa/tag_lan9303.c index

[PATCH v2] netpoll: Check for skb->queue_mapping

Reducing real_num_tx_queues needs to be in sync with skb queue_mapping otherwise skbs with queue_mapping greater than real_num_tx_queues can be sent to the underlying driver and can result in kernel panic. One such event is running netconsole and enabling VF on the same device. Or running

Re: more on FP operations

On Thu, Apr 20, 2017 at 11:52:44PM +0200, Daniel Borkmann wrote: > On 04/20/2017 08:06 PM, David Miller wrote: > > > >I'm running test_verifier for testing, and I notice in my JIT that a > >32-bit move from the frame pointer (BPF_REG_10) ends up in the JIT. > > > >It is from this test: > > > >

Re: [PATCH] p54: Prevent from dereferencing null pointer when releasing SKB

On Thu, 2017-04-20 at 16:23 -0700, Myungho Jung wrote: > On Thu, Apr 20, 2017 at 04:03:43PM -0700, Greg Rose wrote: > > On Thu, 2017-04-20 at 11:25 -0700, Myungho Jung wrote: > > > Added NULL check to make __dev_kfree_skb_irq consistent with kfree > > > family of functions. > > > > > > Link:

[PATCH v2] net: core: Prevent from dereferencing null pointer when

Added NULL check to make __dev_kfree_skb_irq consistent with kfree family of functions. Link: https://bugzilla.kernel.org/show_bug.cgi?id=195289 Signed-off-by: Myungho Jung --- Changes in v2: - Correct category in subject net/core/dev.c | 3 +++ 1 file changed, 3

Re: [PATCH v3 net-next 5/8] net/ncsi: Dump NCSI packet statistics

On Thu, Apr 20, 2017 at 05:59:27PM -0700, Florian Fainelli wrote: >On 04/20/2017 05:44 PM, Gavin Shan wrote: >> On Thu, Apr 20, 2017 at 05:26:14PM -0700, Florian Fainelli wrote: >>> On 04/20/2017 04:38 PM, Gavin Shan wrote: On Thu, Apr 20, 2017 at 01:21:03PM -0400, David Miller wrote: >

Re: [PATCH] p54: Prevent from dereferencing null pointer when releasing SKB

On Thu, 2017-04-20 at 11:25 -0700, Myungho Jung wrote: > Added NULL check to make __dev_kfree_skb_irq consistent with kfree > family of functions. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=195289 > > Signed-off-by: Myungho Jung Hi, I think the patch is fine but

Re: [PATCH net] net: ipv6: RTF_PCPU should not be settable from userspace

On Thu, Apr 20, 2017 at 3:43 PM, David Ahern wrote: > > I scanned the others. It is not clear that others should fail with > EINVAL. Certainly a mask of unused flags can be added, but to me that is > on top of this bug fix. > If we want to preserve those unused bits, we

Re: [PATCH net] net: ipv6: RTF_PCPU should not be settable from userspace

On Thu, Apr 20, 2017 at 04:43:03PM -0600, David Ahern wrote: > On 4/20/17 4:39 PM, Cong Wang wrote: > > On Wed, Apr 19, 2017 at 2:19 PM, David Ahern > > wrote: > >> > >> Fix by checking for the flag and failing with EINVAL. > >> > > > > I am still not sure about this.

Re: FEC on i.MX 7 transmit queue timeout

On 2017年04月20日 07:15, Stefan Agner wrote: > I tested again with imx6sx-fec compatible string. I could reproduce it > on a Colibri with i.MX 7Dual. But not always: It really depends whether > queue 2 is counting up or not. Just after boot, I check /proc/interrupts > twice, if queue 2 is counting

Re: [PATCH net-next v2 2/5] virtio-net: transmit napi

On 2017年04月20日 21:58, Willem de Bruijn wrote: On Thu, Apr 20, 2017 at 2:27 AM, Jason Wang wrote: On 2017年04月19日 04:21, Willem de Bruijn wrote: +static void virtnet_napi_tx_enable(struct virtnet_info *vi, + struct virtqueue *vq, +

Re: [PATCH net] ipv4: Avoid caching dsts when lookup skipped nh oif check

On 4/20/17 6:58 AM, Robert Shearman wrote: > diff --git a/net/ipv4/route.c b/net/ipv4/route.c > index acd69cfe2951..f667783ffd19 100644 > --- a/net/ipv4/route.c > +++ b/net/ipv4/route.c > @@ -2125,6 +2125,14 @@ static struct rtable *__mkroute_output(const struct > fib_result *res, >

Re: [PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

On Thu, Apr 20, 2017 at 12:17 PM, Vladislav Yasevich wrote: > While hardware device use either NETIF_F_(IP|IPV6)_CSUM or > NETIF_F_HW_CSUM, all of the software devices use HW_CSUM. > This results in an interesting situation when the software > device is configured on top of

  1   2   3   4   >