Re: [ISSUE: sky2 - rx error] Link stops working under heavy traffic load connected to a mv88e6176

2017-04-24 Thread Rafa Corvillo
I resend the mail with the schema fixed. Sorry for the inconvenience. We are working in an ARMv7 embedded system running kernel 4.9 (LEDE build). It is an imx6 board with 2 ethernet interfaces. One of them is connected to a Marvell switch. The schema of the system is the following:

Re: [PATCH v3 07/29] x86: bpf_jit, use ENTRY+ENDPROC

2017-04-24 Thread Jiri Slaby
On 04/21/2017, 09:32 PM, Alexei Starovoitov wrote: > On Fri, Apr 21, 2017 at 04:12:43PM +0200, Jiri Slaby wrote: >> Do not use a custom macro FUNC for starts of the global functions, use >> ENTRY instead. >> >> And while at it, annotate also ends of the functions by ENDPROC. >> >> Signed-off-by:

Re: [PATCH] ipvs: explicitly forbid ipv6 service/dest creation if ipv6 mod is disabled

2017-04-24 Thread Paolo Abeni
Hi, On Sat, 2017-04-22 at 14:16 +0300, Julian Anastasov wrote: > On Thu, 20 Apr 2017, Paolo Abeni wrote: > > > When creating a new ipvs service, ipv6 addresses are always accepted > > if CONFIG_IP_VS_IPV6 is enabled. On dest creation the address family > > is not explicitly checked. > > > >

Re: [PATCH net-next 1/2] flow_dissector: add mpls support (v2)

2017-04-24 Thread Jiri Pirko
Sat, Apr 22, 2017 at 10:52:46PM CEST, benjamin.laha...@netronome.com wrote: >Add support for parsing MPLS flows to the flow dissector in preparation for >adding MPLS match support to cls_flower. > >Signed-off-by: Benjamin LaHaise >Signed-off-by: Benjamin LaHaise

[PATCH 2/2] net: team: fix memory leak in team_nl_send_options_get

2017-04-24 Thread Pan Bian
In function team_nl_send_options_get(), pointer skb keeps the return value of function nlmsg_new(). When the call to genlmsg_put() fails, the control flow directly returns and does not free skb. This will result in a memory leak bug. This patch fixes it. Fixes: 8ea7fd0d8792 ("team: fix memory

[PATCH 1/2] net: team: fix memory leak in team_nl_send_port_list_get

2017-04-24 Thread Pan Bian
In function team_nl_send_port_list_get(), pointer skb keeps the return value of nlmsg_new(). When the call to genlmsg_put() fails, the memory is not freed. This will result in a memory leak bug. This patch fixes it. Fixes: fbd69cda90e7 ("team: fix memory leak") Signed-off-by: Pan Bian

Re: [PATCH net-next 2/2] cls_flower: add support for matching MPLS fields (v2)

2017-04-24 Thread Jiri Pirko
Sat, Apr 22, 2017 at 10:52:47PM CEST, benjamin.laha...@netronome.com wrote: >Add support to the tc flower classifier to match based on fields in MPLS >labels (TTL, Bottom of Stack, TC field, Label). > >Signed-off-by: Benjamin LaHaise >Signed-off-by: Benjamin

Re: [PATCH 2/2] net: team: fix memory leak in team_nl_send_options_get

2017-04-24 Thread Jiri Pirko
Mon, Apr 24, 2017 at 09:04:55AM CEST, bianpan2...@163.com wrote: >In function team_nl_send_options_get(), pointer skb keeps the return >value of function nlmsg_new(). When the call to genlmsg_put() fails, the >control flow directly returns and does not free skb. This will result in >a memory leak

Re: [PATCH] ipvs: explicitly forbid ipv6 service/dest creation if ipv6 mod is disabled

2017-04-24 Thread Julian Anastasov
Hello, On Mon, 24 Apr 2017, Paolo Abeni wrote: > Hi, > > The problem with the patched code is that it tries to resolve ipv6 > addresses that are not created/validated by the kernel. OK. Simon, please apply to ipvs tree. Acked-by: Julian Anastasov Regards --

[PATCH net] bridge: shutdown bridge device before removing it

2017-04-24 Thread Xin Long
During removing a bridge device, if the bridge is still up, a new mdb entry still can be added in br_multicast_add_group() after all mdb entries are removed in br_multicast_dev_del(). Like the path: mld_ifc_timer_expire -> mld_sendpack -> ... br_multicast_rcv ->

[PATCH net] xfrm: do the garbage collection after flushing policy

2017-04-24 Thread Xin Long
Now xfrm garbage collection can be triggered by 'ip xfrm policy del'. These is no reason not to do it after flushing policies, especially considering that 'garbage collection deferred' is only triggered when it reaches gc_thresh. It's no good that the policy is gone but the xdst still hold there.

Re: [PATCH v3 07/29] x86: bpf_jit, use ENTRY+ENDPROC

2017-04-24 Thread David Miller
From: Jiri Slaby Date: Mon, 24 Apr 2017 17:41:06 +0200 > On 04/24/2017, 05:08 PM, David Miller wrote: >> If you align the entry points, then the code sequence as a whole is >> are no longer densely packed. > > Sure. > >> Or do I misunderstand how your macros work? > > Perhaps.

Re: [PATCH v4 net-next] mdio_bus: Issue GPIO RESET to PHYs.

2017-04-24 Thread Florian Fainelli
On 04/24/2017 02:04 AM, Roger Quadros wrote: > On 24/04/17 02:35, Andrew Lunn wrote: >> On Fri, Apr 21, 2017 at 03:31:09PM +0200, Lars-Peter Clausen wrote: >>> On 04/21/2017 03:15 PM, Roger Quadros wrote: diff --git a/Documentation/devicetree/bindings/net/mdio.txt

Re: [PATCH v3 07/29] x86: bpf_jit, use ENTRY+ENDPROC

2017-04-24 Thread Alexei Starovoitov
On Mon, Apr 24, 2017 at 06:02:51PM +0200, Jiri Slaby wrote: > On 04/24/2017, 05:55 PM, Ingo Molnar wrote: > > * Jiri Slaby wrote: > > > >> On 04/24/2017, 05:08 PM, David Miller wrote: > >>> If you align the entry points, then the code sequence as a whole is > >>> are no longer

Re: [PATCH net-next 0/3] packet: Add option to create new fanout group with unique id.

2017-04-24 Thread David Miller
From: Willem de Bruijn Date: Fri, 21 Apr 2017 10:56:09 -0400 > Fanout uses a per net global namespace. A process that intends to create a > new fanout group can accidentally join an existing group. It is > not possible to detect this. > > Add a socket option to

cpsw regression in mainline with "cpsw/netcp: cpts depends on posix_timers"

2017-04-24 Thread Tony Lindgren
Hi, Looks like commit 07fef3623407 ("cpsw/netcp: cpts depends on posix_timers") in mainline started triggering the following oops at least on j5eco-evm. Adding CONFIG_PTP_1588_CLOCK to .config solves it, but the oops hints something is wrong with the dependencies.. CONFIG_TI_CPTS defaults to N

Re: [PATCH net] ipv6: move stub initialization after ipv6 setup completion

2017-04-24 Thread Cong Wang
On Mon, Apr 24, 2017 at 5:18 AM, Paolo Abeni wrote: > The ipv6 stub pointer is currently initialized before the ipv6 > routing subsystem: a 3rd party can access and use such stub > before the routing data is ready. > Moreover, such pointer is not cleared in case of

qed*: debug infrastructures

2017-04-24 Thread Elior, Ariel
Hi Dave, According to the recent messages on the list indicating debugfs is not the way to go, I am looking for some guidance on what is. dpipe approach was mentioned as favorable, but I wanted to make sure molding our debug features to this infrastructure will result in something acceptable. A

Re: [PATCH net] udp: disable inner UDP checksum offloads in IPsec case

2017-04-24 Thread David Miller
From: Ansis Atteka Date: Fri, 21 Apr 2017 15:23:05 -0700 > Otherwise, UDP checksum offloads could corrupt ESP packets by attempting > to calculate UDP checksum when this inner UDP packet is already protected > by IPsec. > > One way to reproduce this bug is to have a VM with

[PATCH net-next v3 2/5] virtio-net: transmit napi

2017-04-24 Thread Willem de Bruijn
From: Willem de Bruijn Convert virtio-net to a standard napi tx completion path. This enables better TCP pacing using TCP small queues and increases single stream throughput. The virtio-net driver currently cleans tx descriptors on transmission of new packets in

[PATCH net-next v3 3/5] virtio-net: move free_old_xmit_skbs

2017-04-24 Thread Willem de Bruijn
From: Willem de Bruijn An upcoming patch will call free_old_xmit_skbs indirectly from virtnet_poll. Move the function above this to avoid having to introduce a forward declaration. This is a pure move: no code changes. Signed-off-by: Willem de Bruijn

[PATCH net-next v3 1/5] virtio-net: napi helper functions

2017-04-24 Thread Willem de Bruijn
From: Willem de Bruijn Prepare virtio-net for tx napi by converting existing napi code to use helper functions. This also deduplicates some logic. Signed-off-by: Willem de Bruijn Signed-off-by: Jason Wang ---

[PATCH net-next v3 0/5] virtio-net tx napi

2017-04-24 Thread Willem de Bruijn
From: Willem de Bruijn Add napi for virtio-net transmit completion processing. Changes: v2 -> v3: - convert __netif_tx_trylock to __netif_tx_lock on tx napi poll ensure that the handler always cleans, to avoid deadlock - unconditionally clean in

[PATCH net-next v3 5/5] virtio-net: keep tx interrupts disabled unless kick

2017-04-24 Thread Willem de Bruijn
From: Willem de Bruijn Tx napi mode increases the rate of transmit interrupts. Suppress some by masking interrupts while more packets are expected. The interrupts will be reenabled before the last packet is sent. This optimization reduces the througput drop with tx napi for

Re: [PATCH] net: atheros: atl1: use offset_in_page() macro

2017-04-24 Thread David Miller
From: Geliang Tang Date: Sat, 22 Apr 2017 09:21:10 +0800 > Use offset_in_page() macro instead of open-coding. > > Signed-off-by: Geliang Tang Applied, thanks.

Re: [PATCH v2 net-next] net: ipv6: send unsolicited NA if enabled for all interfaces

2017-04-24 Thread David Miller
From: David Ahern Date: Sat, 22 Apr 2017 09:10:13 -0700 > When arp_notify is set to 1 for either a specific interface or for 'all' > interfaces, gratuitous arp requests are sent. Since ndisc_notify is the > ipv6 equivalent to arp_notify, it should follow the same

Re: [PATCH v2] brcmfmac: Make skb header writable before use

2017-04-24 Thread Eric Dumazet
On Mon, 2017-04-24 at 14:03 +0100, James Hughes wrote: > The driver was making changes to the skb_header without > ensuring it was writable (i.e. uncloned). > This patch also removes some boiler plate header size > checking/adjustment code as that is also handled by the > skb_cow_header function

Re: PATCH drivers:net:cris/eth_v10: alternate string char arrary

2017-04-24 Thread David Miller
From: Karim Eshapa Date: Mon, 24 Apr 2017 19:49:39 +0200 > static char pointer creates two variables in final assembly. > static string and pointer to it according to > Jeff Garzik janitors TODO. > > Signed-off-by: Karim Eshapa Instead of

Re: macvlan: Fix device ref leak when purging bc_queue

2017-04-24 Thread Joe.Ghalam
> I'm waiting for this discussion to settle down before I apply the patch. Thanks David. I will get some answers soon, and hopefully the change is a good one.

Re: [PATCH net-next v2 2/5] virtio-net: transmit napi

2017-04-24 Thread Michael S. Tsirkin
On Fri, Apr 21, 2017 at 10:50:12AM -0400, Willem de Bruijn wrote: > >>> Maybe I was wrong, but according to Michael's comment it looks like he > >>> want > >>> check affinity_hint_set just for speculative tx polling on rx napi > >>> instead > >>> of disabling it at all. > >>> > >>> And I'm not

[PATCH net-next 6/6] qed - VF tunnelling support [VXLAN/GENEVE/GRE]

2017-04-24 Thread Manish Chopra
This patch adds hardware channel APIs support between VF and PF for tunnelling configuration for the VFs. According to that configuration VFs can run VXLAN/GENEVE/GRE tunnels over it with tunnel features offloaded. Using these APIs VF can also request for UDP ports configuration to the PF,

[PATCH net-next 5/6] qed/qede: Add UDP ports in bulletin board

2017-04-24 Thread Manish Chopra
This patch adds support for UDP ports in bulletin board to notify UDP ports change to the VFs Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_l2.c | 19 +++

[PATCH net-next 3/6] qede: Disable tunnel offloads for non offloaded UDP ports

2017-04-24 Thread Manish Chopra
This patch disables tunnel offloads via ndo_features_check() if given UDP port is not offloaded to hardware. This in turn allows to run multiple tunnel interfaces using different UDP ports. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz

[PATCH net-next 4/6] qede: Configure UDP ports in local context.

2017-04-24 Thread Manish Chopra
This patch configures UDP ports locally instead of configuring them in deferred context which would be helpful in synchronizing UDP ports configuration for VFs which will be enabled in further patches. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz

Re: [PATCH v3 07/29] x86: bpf_jit, use ENTRY+ENDPROC

2017-04-24 Thread Jiri Slaby
On 04/24/2017, 05:55 PM, Ingo Molnar wrote: > * Jiri Slaby wrote: > >> On 04/24/2017, 05:08 PM, David Miller wrote: >>> If you align the entry points, then the code sequence as a whole is >>> are no longer densely packed. >> >> Sure. >> >>> Or do I misunderstand how your macros

Re: net/ipv6: slab-out-of-bounds in ip6_tnl_xmit

2017-04-24 Thread Andrey Konovalov
On Mon, Apr 24, 2017 at 5:03 PM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit 5a7ad1146caa895ad718a534399e38bd2ba721b7 (4.11-rc8). > > Unfortunately it's not reproducible. > > The issue might be

Re: [PATCH v3 07/29] x86: bpf_jit, use ENTRY+ENDPROC

2017-04-24 Thread Jiri Slaby
On 04/24/2017, 06:47 PM, Alexei Starovoitov wrote: > On Mon, Apr 24, 2017 at 06:02:51PM +0200, Jiri Slaby wrote: >> On 04/24/2017, 05:55 PM, Ingo Molnar wrote: >>> * Jiri Slaby wrote: >>> On 04/24/2017, 05:08 PM, David Miller wrote: > If you align the entry points, then

Re: [PATCH net-next v2 2/5] virtio-net: transmit napi

2017-04-24 Thread Willem de Bruijn
On Mon, Apr 24, 2017 at 1:14 PM, Michael S. Tsirkin wrote: > On Mon, Apr 24, 2017 at 01:05:45PM -0400, Willem de Bruijn wrote: >> On Mon, Apr 24, 2017 at 12:40 PM, Michael S. Tsirkin wrote: >> > On Fri, Apr 21, 2017 at 10:50:12AM -0400, Willem de Bruijn wrote:

Re: [PATCH net-next] net: add rcu locking when changing early demux

2017-04-24 Thread David Miller
From: David Ahern Date: Sat, 22 Apr 2017 09:33:16 -0700 > systemd-sysctl is triggering a suspicious RCU usage message when > net.ipv4.tcp_early_demux or net.ipv4.udp_early_demux is changed via > a sysctl config file: > > [ 33.896184] === >

Re: [PATCH v3 07/29] x86: bpf_jit, use ENTRY+ENDPROC

2017-04-24 Thread David Miller
From: Jiri Slaby Date: Mon, 24 Apr 2017 19:51:54 +0200 > For example what's the point of making the sk_load_word_positive_offset > label a global, callable function? Note that this is exactly the reason > why this particular two hunks look weird to you even though the >

Re: [PATCH v3 07/29] x86: bpf_jit, use ENTRY+ENDPROC

2017-04-24 Thread Jiri Slaby
On 04/24/2017, 05:08 PM, David Miller wrote: > If you align the entry points, then the code sequence as a whole is > are no longer densely packed. Sure. > Or do I misunderstand how your macros work? Perhaps. So the suggested macros for the code are: #define BPF_FUNC_START_LOCAL(name) \

Re: [PATCH v4] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

2017-04-24 Thread Yuval Shaia
On Tue, Mar 14, 2017 at 07:58:43PM +0200, Leon Romanovsky wrote: > On Tue, Mar 14, 2017 at 04:01:57PM +0200, Yuval Shaia wrote: > > This logic seems to be duplicated in (at least) three separate files. > > Move it to one place so code can be re-use. > > > > Signed-off-by: Yuval Shaia

Re: [net-next 0/7][pull request] 1GbE Intel Wired LAN Driver Updates 2017-04-20

2017-04-24 Thread David Miller
From: Jeff Kirsher Date: Thu, 20 Apr 2017 16:33:28 -0700 > This series contains updates to e1000, e1000e, igb/vf and ixgb. Pulled, thanks Jeff.

Re: I find one aspect of the ip link show command confusing and I'd like you to fix it, please

2017-04-24 Thread Stephen Hemminger
On Sun, 23 Apr 2017 15:36:32 -0700 Jeff Silverman wrote: > People, > > When my NIC is up, but not connected, I see: > > root@jeff-desktop:~# ip link show enp3s0 > 2: enp3s0: mtu 1500 qdisc mq state > DOWN mode DEFAULT group default

Re: [PATCH net] bridge: shutdown bridge device before removing it

2017-04-24 Thread Nikolay Aleksandrov
On 24/04/17 18:21, Xin Long wrote: > On Mon, Apr 24, 2017 at 10:53 PM, Nikolay Aleksandrov > wrote: >> On 24/04/17 17:41, Xin Long wrote: >>> On Mon, Apr 24, 2017 at 8:07 PM, Nikolay Aleksandrov >>> wrote: On 24/04/17 14:01, Nikolay

Re: [PATCH v4 net-next] mdio_bus: Issue GPIO RESET to PHYs.

2017-04-24 Thread David Miller
From: Roger Quadros Date: Fri, 21 Apr 2017 16:15:38 +0300 > Some boards [1] leave the PHYs at an invalid state > during system power-up or reset thus causing unreliability > issues with the PHY which manifests as PHY not being detected > or link not functional. To fix this, these

Re: [PATCH v3 07/29] x86: bpf_jit, use ENTRY+ENDPROC

2017-04-24 Thread Ingo Molnar
* Jiri Slaby wrote: > On 04/24/2017, 05:55 PM, Ingo Molnar wrote: > > * Jiri Slaby wrote: > > > >> On 04/24/2017, 05:08 PM, David Miller wrote: > >>> If you align the entry points, then the code sequence as a whole is > >>> are no longer densely packed. > >> >

Re: [PATCH net-next 0/7] ibmvnic: Additional updates and bug fixes

2017-04-24 Thread David Miller
From: Nathan Fontenot Date: Fri, 21 Apr 2017 15:38:29 -0400 > This set of patches is an additional set of updates and bug fixes to > the ibmvnic driver which applies on top of the previous set of updates > sent out on 4/19. Series applied, thanks.

Re: [PATCH] macsec: avoid heap overflow in skb_to_sgvec

2017-04-24 Thread David Miller
From: "Jason A. Donenfeld" Date: Fri, 21 Apr 2017 23:14:48 +0200 > While this may appear as a humdrum one line change, it's actually quite > important. An sk_buff stores data in three places: > > 1. A linear chunk of allocated memory in skb->data. This is the easiest >one

Re: [PATCH v2] net: natsemi: ns83820: add checks for dma mapping error

2017-04-24 Thread David Miller
From: Alexey Khoroshilov Date: Sat, 22 Apr 2017 16:06:05 +0300 > + free_idx = (free_idx + NR_TX_DESC - 1) % NR_TX_DESC; This is more simply stated as "(free_idx - 1) % NR_TX_DESC.

Re: pull request: bluetooth-next 2017-04-22

2017-04-24 Thread David Miller
From: Johan Hedberg Date: Sat, 22 Apr 2017 16:13:02 +0300 > Here are some more Bluetooth patches (and one 802.15.4 patch) in the > bluetooth-next tree targeting the 4.12 kernel. Most of them are pure > fixes. > > Please let me know if there are any issues pulling.

Re: [PATCH net-next 0/3] net/tcp_fastopen: Fix for various TFO firewall issues

2017-04-24 Thread David Miller
From: Wei Wang Date: Thu, 20 Apr 2017 14:45:45 -0700 > Currently there are still some firewall issues in the middlebox > which make the middlebox drop packets silently for TFO sockets. > This kind of issue is hard to be detected by the end client. > > This patch series tries

Re: [PATCH net-next 0/5] bnxt_en: Updates for net-next.

2017-04-24 Thread David Miller
From: Michael Chan Date: Fri, 21 Apr 2017 20:11:21 -0400 > Miscellaneous updates include passing DCBX RoCE VLAN priority to firmware, > checking one more new firmware flag before allowing DCBX to run on the host, > adding 100Gbps speed support, adding check to disallow

Re: cpsw regression in mainline with "cpsw/netcp: cpts depends on posix_timers"

2017-04-24 Thread Arnd Bergmann
On Mon, Apr 24, 2017 at 7:44 PM, Tony Lindgren wrote: > * Arnd Bergmann [170424 10:38]: >> On Mon, Apr 24, 2017 at 6:51 PM, Tony Lindgren wrote: >> > Hi, >> > >> > Looks like commit 07fef3623407 ("cpsw/netcp: cpts depends on posix_timers") >> >

[iproute PATCH] man: ip-rule.8: Further clarify how to interpret priority value

2017-04-24 Thread Phil Sutter
Despite the past changes, users seemed to get confused by the seemingly contradictory relation of priority value and actual rule priority. Signed-off-by: Phil Sutter --- man/man8/ip-rule.8 | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2] net: core: Prevent from dereferencing null pointer when

2017-04-24 Thread David Miller
From: Myungho Jung Date: Thu, 20 Apr 2017 16:59:20 -0700 > Added NULL check to make __dev_kfree_skb_irq consistent with kfree > family of functions. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=195289 > > Signed-off-by: Myungho Jung > --- >

Re: [PATCH net-next 0/5] qed*: Dcbx/dcbnl enhancements.

2017-04-24 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Thu, 20 Apr 2017 22:31:15 -0700 > From: Sudarsana Reddy Kalluru > > The series has set of enhancements for dcbx/dcbnl implementation of > qed/qede drivers. > - Patches (1) & (3) capture the sematic

Re: [PATCH net v2 0/3] net: hns: bug fix for HNS driver

2017-04-24 Thread David Miller
From: Yankejian Date: Fri, 21 Apr 2017 15:44:41 +0800 > From: lipeng > > This series adds support defered probe when mdio or mbigen module > insmod behind HNS driver, and fixes a bug that a skb has been > freed, but it may be still used in driver. >

Re: pull-request: wireless-drivers-next 2017-04-21

2017-04-24 Thread David Miller
From: Kalle Valo Date: Fri, 21 Apr 2017 12:08:10 +0300 > here's most likely the last pull request to net-next for 4.12, unless > Linus delayes the start of merge window. More info in the signed tag > below and please let me know if there are any problems. Pulled, thanks

Re: net/ipv6: slab-out-of-bounds in ip6_tnl_xmit

2017-04-24 Thread Cong Wang
On Mon, Apr 24, 2017 at 8:03 AM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit 5a7ad1146caa895ad718a534399e38bd2ba721b7 (4.11-rc8). > > Unfortunately it's not reproducible. > > The issue might be

Re: [PATCH net-next v2 2/5] virtio-net: transmit napi

2017-04-24 Thread Michael S. Tsirkin
On Mon, Apr 24, 2017 at 01:05:45PM -0400, Willem de Bruijn wrote: > On Mon, Apr 24, 2017 at 12:40 PM, Michael S. Tsirkin wrote: > > On Fri, Apr 21, 2017 at 10:50:12AM -0400, Willem de Bruijn wrote: > >> >>> Maybe I was wrong, but according to Michael's comment it looks like he >

Re: [PATCH net-next v2 2/2] openvswitch: Add eventmask support to CT action.

2017-04-24 Thread David Miller
From: Jarno Rajahalme Date: Fri, 21 Apr 2017 16:48:06 -0700 > Add a new optional conntrack action attribute OVS_CT_ATTR_EVENTMASK, > which can be used in conjunction with the commit flag > (OVS_CT_ATTR_COMMIT) to set the mask of bits specifying which > conntrack events (IPCT_*)

Re: [PATCH net-next v2 1/2] openvswitch: Typo fix.

2017-04-24 Thread David Miller
From: Jarno Rajahalme Date: Fri, 21 Apr 2017 16:48:05 -0700 > Fix typo in a comment. > > Signed-off-by: Jarno Rajahalme > Acked-by: Greg Rose Applied.

Re: [PATCH] net: netcp: fix spelling mistake: "memomry" -> "memory"

2017-04-24 Thread David Miller
From: Colin King Date: Sat, 22 Apr 2017 13:22:01 +0100 > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err message and rejoin > line. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH v3 net] net: ipv6: regenerate host route if moved to gc list

2017-04-24 Thread Eric Dumazet
On Mon, 2017-04-24 at 08:09 -0700, David Ahern wrote: > Taking down the loopback device wreaks havoc on IPv6 routing. By > extension, taking down a VRF device wreaks havoc on its table. > > Dmitry and Andrey both reported heap out-of-bounds reports in the IPv6 > FIB code while running syzkaller

Re: [PATCH] net: tc35815: move free after the dereference

2017-04-24 Thread David Miller
From: Dan Carpenter Date: Fri, 21 Apr 2017 13:49:37 +0300 > We dereference "skb" to get "skb->len" so we should probably do that > step before freeing the skb. > > Fixes: eea221ce4880 ("tc35815 driver update (take 2)") > Signed-off-by: Dan Carpenter

Re: cpsw regression in mainline with "cpsw/netcp: cpts depends on posix_timers"

2017-04-24 Thread Tony Lindgren
* Arnd Bergmann [170424 10:38]: > On Mon, Apr 24, 2017 at 6:51 PM, Tony Lindgren wrote: > > Hi, > > > > Looks like commit 07fef3623407 ("cpsw/netcp: cpts depends on posix_timers") > > in mainline started triggering the following oops at least on j5eco-evm. > > >

PATCH drivers:net:cris/eth_v10: alternate string char arrary

2017-04-24 Thread Karim Eshapa
static char pointer creates two variables in final assembly. static string and pointer to it according to Jeff Garzik janitors TODO. Signed-off-by: Karim Eshapa --- drivers/net/cris/eth_v10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next v3 4/5] virtio-net: clean tx descriptors from rx napi

2017-04-24 Thread Willem de Bruijn
From: Willem de Bruijn Amortize the cost of virtual interrupts by doing both rx and tx work on reception of a receive interrupt if tx napi is enabled. With VIRTIO_F_EVENT_IDX, this suppresses most explicit tx completion interrupts for bidirectional workloads. Signed-off-by:

Re: [PATCH v3 07/29] x86: bpf_jit, use ENTRY+ENDPROC

2017-04-24 Thread Ingo Molnar
* Jiri Slaby wrote: > On 04/24/2017, 05:08 PM, David Miller wrote: > > If you align the entry points, then the code sequence as a whole is > > are no longer densely packed. > > Sure. > > > Or do I misunderstand how your macros work? > > Perhaps. So the suggested macros for

Re: [PATCH] qed: fix kzalloc-simple.cocci warnings

2017-04-24 Thread David Miller
From: kbuild test robot Date: Fri, 21 Apr 2017 08:20:07 +0800 > drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1267:13-20: WARNING: kzalloc > should be used for dcbx_info, instead of kmalloc/memset > > > Use kzalloc rather than kmalloc followed by memset with 0 > > This

Re: [PATCH v5 0/3] VSOCK: vsockmon virtual device to monitor AF_VSOCK sockets.

2017-04-24 Thread David Miller
From: Stefan Hajnoczi Date: Fri, 21 Apr 2017 10:10:43 +0100 > This is a continuation of Gerard Garcia's work on the vsockmon packet capture > interface for AF_VSOCK. Packet capture is an essential feature for network > communication. Gerard began addressing this feature

Re: [PATCH net-next v2 2/5] virtio-net: transmit napi

2017-04-24 Thread Willem de Bruijn
On Mon, Apr 24, 2017 at 12:40 PM, Michael S. Tsirkin wrote: > On Fri, Apr 21, 2017 at 10:50:12AM -0400, Willem de Bruijn wrote: >> >>> Maybe I was wrong, but according to Michael's comment it looks like he >> >>> want >> >>> check affinity_hint_set just for speculative tx polling

Re: [PATCH net] ravb: Double free on error in ravb_start_xmit()

2017-04-24 Thread David Miller
From: Dan Carpenter Date: Sat, 22 Apr 2017 13:46:56 +0300 > If skb_put_padto() fails then it frees the skb. I shifted that code > up a bit to make my error handling a little simpler. > > Fixes: a0d2f20650e8 ("Renesas Ethernet AVB PTP clock driver") > Signed-off-by:

Re: [pull request][net-next 0/5] Mellanox, mlx5 updates 2017-04-22

2017-04-24 Thread David Miller
From: Saeed Mahameed Date: Sat, 22 Apr 2017 21:45:02 +0300 > This series contains some updates to mlx5 driver. > > Sparse and compiler warnings fixes from Stephen Hemminger. > > From Roi Dayan and Or Gerlitz, Add devlink and mlx5 support for controlling > E-Switch

Re: cpsw regression in mainline with "cpsw/netcp: cpts depends on posix_timers"

2017-04-24 Thread Tony Lindgren
* Arnd Bergmann [170424 11:14]: > On Mon, Apr 24, 2017 at 7:44 PM, Tony Lindgren wrote: > > * Arnd Bergmann [170424 10:38]: > >> On Mon, Apr 24, 2017 at 6:51 PM, Tony Lindgren wrote: > >> > Hi, > >> > > >> > Looks like commit

Re: [PATCH v3 07/29] x86: bpf_jit, use ENTRY+ENDPROC

2017-04-24 Thread Jiri Slaby
On 04/24/2017, 05:51 PM, David Miller wrote: > I said I'm not OK with the alignment So in short, the suggested macros add no alignment. -- js suse labs

[PATCH RFC v2] ptr_ring: add ptr_ring_unconsume

2017-04-24 Thread Michael S. Tsirkin
Applications that consume a batch of entries in one go can benefit from ability to return some of them back into the ring. Add an API for that - assuming there's space. If there's no space naturally can't do this and have to drop entries, but this implies ring is full so we'd likely drop some

Re: [PATCH net v3] net/mlx5e: Fix race in mlx5e_sw_stats and mlx5e_vport_stats

2017-04-24 Thread David Miller
From: Martin KaFai Lau Date: Thu, 20 Apr 2017 21:40:12 -0700 > We have observed a sudden spike in rx/tx_packets and rx/tx_bytes > reported under /proc/net/dev. There is a race in mlx5e_update_stats() > and some of the get-stats functions (the one that we hit is the >

RE: IT Notification

2017-04-24 Thread Martin Burnell
From: Martin Burnell Sent: 24 April 2017 16:16 Subject: IT Notification Please click to confirm your account is up to date, https://owawebapp.000webhostapp.com/

Re: [PATCH net v2] ipv4: Avoid caching l3mdev dst on mismatched local route

2017-04-24 Thread David Miller
From: Robert Shearman Date: Fri, 21 Apr 2017 21:34:59 +0100 > David reported that doing the following: > > ip li add red type vrf table 10 > ip link set dev eth1 vrf red > ip addr add 127.0.0.1/8 dev red > ip link set dev eth1 up > ip li set red up >

[PATCH net-next 0/6] qed/qede: VF tunnelling support

2017-04-24 Thread Manish Chopra
Hi David, With this series VFs can run vxlan/geneve/gre tunnels over it. Please consider applying this series to "net-next" Thanks, Manish Manish Chopra (6): qed: refactor tunnelling - API/Structs qed/qede: Enable tunnel offloads based on hw configuration qede: Disable tunnel offloads for

[PATCH net-next 1/6] qed: refactor tunnelling - API/Structs

2017-04-24 Thread Manish Chopra
This patch changes the tunnel APIs to use per tunnel info instead of using bitmasks for all tunnels and also uses single struct to hold the data to prepare multiple variant of tunnel configuration ramrods to be sent to the hardware. Signed-off-by: Manish Chopra

[PATCH net-next 2/6] qed/qede: Enable tunnel offloads based on hw configuration

2017-04-24 Thread Manish Chopra
This patch enables tunnel feature offloads based on hw configuration at initialization time instead of enabling them always. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_main.c | 15

Re: [PATCH RFC (resend) net-next 0/6] virtio-net: Add support for virtio-net header extensions

2017-04-24 Thread Michael S. Tsirkin
On Thu, Apr 20, 2017 at 11:34:57AM -0400, Vlad Yasevich wrote: > > - For 1.1, do we really want something like vnet header? AFAIK, it was not > > used by modern > > NICs, is this better to pack all meta-data into descriptor itself? This may > > need a some > > changes in tun/macvtap, but looks

Re: cpsw regression in mainline with "cpsw/netcp: cpts depends on posix_timers"

2017-04-24 Thread Arnd Bergmann
On Mon, Apr 24, 2017 at 6:51 PM, Tony Lindgren wrote: > Hi, > > Looks like commit 07fef3623407 ("cpsw/netcp: cpts depends on posix_timers") > in mainline started triggering the following oops at least on j5eco-evm. > > Adding CONFIG_PTP_1588_CLOCK to .config solves it, but the

Re: [PATCH net-next v5 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-24 Thread Jamal Hadi Salim
On 17-04-24 04:30 PM, David Miller wrote: Which is fine. But two things: 1) Again, bits you aren't using now, make sure userspace doesn't set them. And if it does, reject. I meet those goals on the bit checks but i went a slightly different path with a patch I posted[1] With the

Re: [PATCH net 0/3] net: dsa: b53: BCM58xx devices fixes

2017-04-24 Thread David Miller
From: Florian Fainelli Date: Mon, 24 Apr 2017 14:27:20 -0700 > This patch series contains fixes for the 58xx devices (Broadcom Northstar > Plus), which were identified thanks to the help of Eric Anholt. Series applied, thanks Florian.

Re: [PATCH 1/2] net: dsa: b53: Add compatible strings for the Cygnus-family BCM11360.

2017-04-24 Thread Arun Parameswaran
On 17-04-24 04:07 PM, Florian Fainelli wrote: > On 04/24/2017 04:03 PM, Arun Parameswaran wrote: >> Hi Eric >> >> A comment on the Device ID. >> >> >> On 17-04-24 02:50 PM, Eric Anholt wrote: >>> Cygnus is a small family of SoCs, of which we currently have >>> devicetree for BCM11360 and

Re: [PATCH net-next v3 0/5] virtio-net tx napi

2017-04-24 Thread Michael S. Tsirkin
On Mon, Apr 24, 2017 at 01:49:25PM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > Add napi for virtio-net transmit completion processing. Acked-by: Michael S. Tsirkin > Changes: > v2 -> v3: > - convert __netif_tx_trylock to

Re: Fw: New Defects reported by Coverity Scan for Linux

2017-04-24 Thread Jamal Hadi Salim
Yeah, not sure i see it either. cheers, jamal On Mon, Apr 24, 2017 at 8:09 PM, Cong Wang wrote: > On Mon, Apr 24, 2017 at 4:41 PM, Stephen Hemminger > wrote: >> This looks like a false positive >>

Re: [PATCH v2] net: core: Prevent from dereferencing null pointer when

2017-04-24 Thread Myungho Jung
On Mon, Apr 24, 2017 at 12:02:35PM -0400, David Miller wrote: > From: Myungho Jung > Date: Thu, 20 Apr 2017 16:59:20 -0700 > > > Added NULL check to make __dev_kfree_skb_irq consistent with kfree > > family of functions. > > > > Link:

Re: Blogpost evaluation this [PATCH v4 net-next RFC] net: Generic XDP

2017-04-24 Thread David Miller
From: Jesper Dangaard Brouer Date: Mon, 24 Apr 2017 16:24:05 +0200 > I've done a very detailed evaluation of this patch, and I've created a > blogpost like report here: > > > https://prototype-kernel.readthedocs.io/en/latest/blogposts/xdp25_eval_generic_xdp_tx.html Thanks

Re: [PATCH 1/2] net: dsa: b53: Add compatible strings for the Cygnus-family BCM11360.

2017-04-24 Thread Scott Branden
Minor comment in line On 17-04-24 02:50 PM, Eric Anholt wrote: Cygnus is a small family of SoCs, of which we currently have devicetree for BCM11360 and BCM58300. The 11360's B53 is mostly the same as 58xx, just requiring a tiny bit of setup that was previously missing. Signed-off-by: Eric

test_progs packed...

2017-04-24 Thread David Miller
Alexei, why the packed attribute usage in test_progs.c? There should be no reason for this and it results in the object(s) having odd addresses (and thus be unaligned) on sparc.

Fw: New Defects reported by Coverity Scan for Linux

2017-04-24 Thread Stephen Hemminger
This looks like a false positive Date: Mon, 24 Apr 2017 14:40:46 -0700 From: scan-ad...@coverity.com To: step...@networkplumber.org Subject: New Defects reported by Coverity Scan for Linux 1 new defect(s) introduced to Linux found with Coverity Scan. 2 defect(s), reported by Coverity Scan

EXTREMELY IMPORTANT

2017-04-24 Thread Ms. Katherine
Dear Beloved, Sorry for the inconvenience, I am getting in touch with you regarding an extremely important and urgent matter, Please I need your urgent assistance and idea to finish up a project (Orphanage Home) Due to my health condition, Everything is available to finish up the project, All I

Re: [PATCH net-next 0/2] flower: add MPLS matching support

2017-04-24 Thread Jamal Hadi Salim
On 17-04-24 09:05 PM, Benjamin LaHaise wrote: On Mon, Apr 24, 2017 at 08:58:18PM -0400, Jamal Hadi Salim wrote: On 17-04-24 02:32 PM, David Miller wrote: You have 3 TLVs, one of which is u8 that only allows use of 3 bits. The other is a u32 which allows only 20 bits to be set. What are the

[PATCH net] netvsc: fix calculation of available send sections

2017-04-24 Thread Stephen Hemminger
My change (introduced in 4.11) to use find_first_clear_bit incorrectly assumed that the size argument was words, not bits. The effect was only a small limited number of the available send sections were being actually used. This can cause performance loss with some workloads. Since map_words is

Re: [PATCH net-next 0/2] flower: add MPLS matching support

2017-04-24 Thread Jamal Hadi Salim
On 17-04-24 09:20 PM, Jakub Kicinski wrote: On Mon, 24 Apr 2017 20:58:18 -0400, Jamal Hadi Salim wrote: On 17-04-24 02:32 PM, David Miller wrote: You have 3 TLVs, one of which is u8 that only allows use of 3 bits. The other is a u32 which allows only 20 bits to be set. I don't think we

  1   2   3   >