RE: [PATCH 5/7] IB/hfi1: use pcie_flr instead of duplicating it

2017-04-24 Thread Byczkowski, Jakub
Tested-by: Jakub Byczkowski -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Christoph Hellwig Sent: Friday, April 14, 2017 9:11 PM To: Bjorn Helgaas ; Cabiddu, Giovanni

[PATCH] net: bridge: suppress broadcast when multicast flood is disabled

2017-04-24 Thread Mike Manning
Flood suppression for packets that are not unicast needs to be handled consistently by also not flooding broadcast packets. As broadcast is a special case of multicast, the same kernel parameter should be used to suppress flooding for both of these packet types. Fixes: b6cb5ac8331b ("net: bridge:

Re: [PATCH v2 net] net: ipv6: regenerate host route if moved to gc list

2017-04-24 Thread Andrey Konovalov
On Sat, Apr 22, 2017 at 6:40 PM, David Ahern wrote: > Taking down the loopback device wreaks havoc on IPv6 routes. By > extension, taking a VRF device wreaks havoc on its table. > > Dmitry and Andrey both reported heap out-of-bounds reports in the IPv6 > FIB code while

[PATCH net-next 1/3] samples/bpf: add -Wno-unknown-warning-option to clang

2017-04-24 Thread Alexander Alemayhu
I was initially going to remove '-Wno-address-of-packed-member' because I thought it was not supposed to be there but Daniel suggested using '-Wno-unknown-warning-option'. This silences several warnings similiar to the one below warning: unknown warning option '-Wno-address-of-packed-member'

[PATCH net-next 2/3] samples/bpf: add static to function with no prototype

2017-04-24 Thread Alexander Alemayhu
Fixes the following warning samples/bpf/cookie_uid_helper_example.c: At top level: samples/bpf/cookie_uid_helper_example.c:276:6: warning: no previous prototype for ‘finish’ [-Wmissing-prototypes] void finish(int ret) ^~ HOSTLD samples/bpf/per_socket_stats_example Signed-off-by:

[PATCH net-next 3/3] samples/bpf: check before defining offsetof

2017-04-24 Thread Alexander Alemayhu
Fixes the following warning samples/bpf/test_lru_dist.c:28:0: warning: "offsetof" redefined #define offsetof(TYPE, MEMBER) ((size_t)&((TYPE *)0)->MEMBER) In file included from ./tools/lib/bpf/bpf.h:25:0, from samples/bpf/libbpf.h:5, from

[PATCH net-next 0/3] Misc BPF cleanup

2017-04-24 Thread Alexander Alemayhu
Hei, while looking into making the Makefile in samples/bpf better handle O= I saw several warnings when running `make clean && make samples/bpf/`. This series reduces those warnings. Thanks. Alexander Alemayhu (3): samples/bpf: add -Wno-unknown-warning-option to clang samples/bpf: add

Re: [PATCH v4 net-next RFC] net: Generic XDP

2017-04-24 Thread Jesper Dangaard Brouer
On Thu, 20 Apr 2017 16:30:34 +0200 Jesper Dangaard Brouer wrote: > On Wed, 19 Apr 2017 10:29:03 -0400 > Andy Gospodarek wrote: > > > I ran this on top of a card that uses the bnxt_en driver on a desktop > > class system with an i7-6700 CPU @ 3.40GHz,

[PATCH net v1 2/2] tipc: fix socket flow control accounting error at tipc_recv_stream

2017-04-24 Thread Parthasarathy Bhuvaragan
Until now in tipc_recv_stream(), we update the received unacknowledged bytes based on a stack variable and not based on the actual message size. If the user buffer passed at tipc_recv_stream() is smaller than the received skb, the size variable in stack differs from the actual message size in the

[PATCH v2] brcmfmac: Make skb header writable before use

2017-04-24 Thread James Hughes
The driver was making changes to the skb_header without ensuring it was writable (i.e. uncloned). This patch also removes some boiler plate header size checking/adjustment code as that is also handled by the skb_cow_header function used to make header writable. This patch depends on brcmfmac:

[PATCH net v1 1/2] tipc: fix socket flow control accounting error at tipc_send_stream

2017-04-24 Thread Parthasarathy Bhuvaragan
Until now in tipc_send_stream(), we return -1 when the socket encounters link congestion even if the socket had successfully sent partial data. This is incorrect as the application resends the same the partial data leading to data corruption at receiver's end. In this commit, we return the

[PATCH v2] net/packet: initialize val in packet_getsockopt()

2017-04-24 Thread Alexander Potapenko
In the case getsockopt() is called with PACKET_HDRLEN and optlen < 4 |val| remains uninitialized and the syscall may behave differently depending on its value. This doesn't have security consequences (as the uninit bytes aren't copied back), but it's still cleaner to initialize |val| and ensure

Re: [PATCH v4 13/18] arm64: allwinner: sun50i-a64: add dwmac-sun8i Ethernet driver

2017-04-24 Thread Chen-Yu Tsai
On Mon, Apr 24, 2017 at 8:24 PM, Corentin Labbe wrote: > On Wed, Apr 12, 2017 at 02:41:53PM +0200, Maxime Ripard wrote: >> On Wed, Apr 12, 2017 at 01:13:55PM +0200, Corentin Labbe wrote: >> > The dwmac-sun8i is an Ethernet MAC that supports 10/100/1000 Mbit >> >

Re: [PATCH net-next v4 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-24 Thread Jamal Hadi Salim
On 17-04-24 05:27 AM, Simon Horman wrote: On Fri, Apr 21, 2017 at 02:11:00PM -0400, Jamal Hadi Salim wrote: On 17-04-21 12:12 PM, David Miller wrote: From my PoV, for #d user-space has to either get smart or fail. Creating new tc involved work in order to support the new feature. Part of

Re: [PATCH net-next v5 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-24 Thread Jamal Hadi Salim
On 17-04-24 05:14 AM, Simon Horman wrote: [..] Jamal, I am confused about why are you so concerned about the space consumed by this attribute, it's per-message, right? Is it the bigger picture you are worried about - a similar per-entry flag at some point in the future? To me the two worries

Re: [PATCH v4 13/18] arm64: allwinner: sun50i-a64: add dwmac-sun8i Ethernet driver

2017-04-24 Thread Corentin Labbe
On Wed, Apr 12, 2017 at 02:41:53PM +0200, Maxime Ripard wrote: > On Wed, Apr 12, 2017 at 01:13:55PM +0200, Corentin Labbe wrote: > > The dwmac-sun8i is an Ethernet MAC that supports 10/100/1000 Mbit > > connections. It is very similar to the device found in the Allwinner > > H3, but lacks the

[PATCH net] ipv6: move stub initialization after ipv6 setup completion

2017-04-24 Thread Paolo Abeni
The ipv6 stub pointer is currently initialized before the ipv6 routing subsystem: a 3rd party can access and use such stub before the routing data is ready. Moreover, such pointer is not cleared in case of initialization error, possibly leading to dangling pointers usage. This change addresses

[PATCH net-next 2/2] l2tp: define "l2tpeth" device type

2017-04-24 Thread Guillaume Nault
Export type of l2tpeth interfaces to userspace (/sys/class/net//uevent). Signed-off-by: Guillaume Nault --- net/l2tp/l2tp_eth.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/l2tp/l2tp_eth.c b/net/l2tp/l2tp_eth.c index 5e44b3cc1212..59aba8aeac03 100644 ---

[PATCH net-next 1/2] l2tp: set name_assign_type for devices created by l2tp_eth.c

2017-04-24 Thread Guillaume Nault
Export naming scheme used when creating l2tpeth interfaces (/sys/class/net//name_assign_type). This let userspace know if the device's name has been generated automatically or defined manually. Signed-off-by: Guillaume Nault --- net/l2tp/l2tp_eth.c | 8 ++-- 1 file

[PATCH net-next 0/2] l2tp: add informations about l2tpeth interfaces in /sys

2017-04-24 Thread Guillaume Nault
Patch #1 lets userspace retrieve the naming scheme of an l2tpeth interface, using /sys/class/net//name_assign_type. Patch #2 adds the DEVTYPE field in /sys/class/net//uevent so that userspace can reliably know if a device is an l2tpeth interface. Guillaume Nault (2): l2tp: set

Re: [PATCH] macsec: avoid heap overflow in skb_to_sgvec

2017-04-24 Thread Jason A. Donenfeld
On Mon, Apr 24, 2017 at 1:02 PM, David Laight wrote: > ... > > Shouldn't skb_to_sgvec() be checking the number of fragments against > the size of the sg list? > The callers would then all need auditing to allow for failure. This has never been done before, since this is

Re: net: cleanup_net is slow

2017-04-24 Thread Florian Westphal
Andrey Konovalov wrote: > On Fri, Apr 21, 2017 at 9:45 PM, Florian Westphal wrote: > > Florian Westphal wrote: > >> Indeed. Setting net.netfilter.nf_conntrack_default_on=0 cuts time > >> cleanup time by 2/3 ... > >> > >> nf unregister is

Re: [PATCH net] bridge: shutdown bridge device before removing it

2017-04-24 Thread Nikolay Aleksandrov
On 24/04/17 14:01, Nikolay Aleksandrov wrote: > On 24/04/17 10:25, Xin Long wrote: >> During removing a bridge device, if the bridge is still up, a new mdb entry >> still can be added in br_multicast_add_group() after all mdb entries are >> removed in br_multicast_dev_del(). Like the path: >> >>

Re: [PATCH RFC] ptr_ring: add ptr_ring_unconsume

2017-04-24 Thread Michael S. Tsirkin
On Mon, Apr 24, 2017 at 07:54:18PM +0800, Jason Wang wrote: > > > On 2017年04月24日 07:28, Michael S. Tsirkin wrote: > > On Tue, Apr 18, 2017 at 11:07:42AM +0800, Jason Wang wrote: > > > > > > On 2017年04月17日 07:19, Michael S. Tsirkin wrote: > > > > Applications that consume a batch of entries in

Re: net: cleanup_net is slow

2017-04-24 Thread Andrey Konovalov
On Fri, Apr 21, 2017 at 9:45 PM, Florian Westphal wrote: > Florian Westphal wrote: >> Indeed. Setting net.netfilter.nf_conntrack_default_on=0 cuts time >> cleanup time by 2/3 ... >> >> nf unregister is way too happy to issue synchronize_net(), I'll work on >> a

Re: [PATCH RFC] ptr_ring: add ptr_ring_unconsume

2017-04-24 Thread Jason Wang
On 2017年04月24日 07:28, Michael S. Tsirkin wrote: On Tue, Apr 18, 2017 at 11:07:42AM +0800, Jason Wang wrote: On 2017年04月17日 07:19, Michael S. Tsirkin wrote: Applications that consume a batch of entries in one go can benefit from ability to return some of them back into the ring. Add an API

[PATCH v2] brcmfmac: Ensure pointer correctly set if skb data location changes

2017-04-24 Thread James Hughes
The incoming skb header may be resized if header space is insufficient, which might change the data adddress in the skb. Ensure that a cached pointer to that data is correctly set by moving assignment to after any possible changes. Signed-off-by: James Hughes

Re: [PATCH net] bridge: shutdown bridge device before removing it

2017-04-24 Thread Nikolay Aleksandrov
On 24/04/17 14:01, Nikolay Aleksandrov wrote: > On 24/04/17 10:25, Xin Long wrote: >> During removing a bridge device, if the bridge is still up, a new mdb entry >> still can be added in br_multicast_add_group() after all mdb entries are >> removed in br_multicast_dev_del(). Like the path: >> >>

Re: [PATCH] brcmfmac: Ensure pointer correctly set if skb data location changes

2017-04-24 Thread Arend van Spriel
On 4/24/2017 12:52 PM, James Hughes wrote: The incoming skb header may be resized if header space is insufficient, which might change the data adddress in the skb. Ensure that a cached pointer to that data is correctly set by moving assignment to after any possible changes. Thanks, James

Re: [PATCH net] team: fix memory leaks

2017-04-24 Thread Jiri Pirko
Mon, Apr 24, 2017 at 12:29:16PM CEST, bianpan2...@163.com wrote: >In functions team_nl_send_port_list_get() and >team_nl_send_options_get(), pointer skb keeps the return value of >nlmsg_new(). When the call to genlmsg_put() fails, the memory is not >freed(). This will result in memory leak bugs. >

Re: [PATCH iproute2 net 3/8] tc/pedit: Introduce 'add' operation

2017-04-24 Thread Or Gerlitz
On Mon, Apr 24, 2017 at 10:52 AM, Amir Vadai wrote: > On Sun, Apr 23, 2017 at 01:44:51PM -0400, Jamal Hadi Salim wrote: >> Thanks for the excellent work. sure, it's Amir, you know.. >> On 17-04-23 08:53 AM, Amir Vadai wrote: >> Mostly curious about hardware handling. > As to

RE: [PATCH] macsec: avoid heap overflow in skb_to_sgvec

2017-04-24 Thread David Laight
From: Jason A. Donenfeld > Sent: 21 April 2017 22:15 > While this may appear as a humdrum one line change, it's actually quite > important. An sk_buff stores data in three places: > > 1. A linear chunk of allocated memory in skb->data. This is the easiest >one to work with, but it precludes

Re: [PATCH net] bridge: shutdown bridge device before removing it

2017-04-24 Thread Nikolay Aleksandrov
On 24/04/17 10:25, Xin Long wrote: > During removing a bridge device, if the bridge is still up, a new mdb entry > still can be added in br_multicast_add_group() after all mdb entries are > removed in br_multicast_dev_del(). Like the path: > > mld_ifc_timer_expire -> > mld_sendpack -> ... >

Re: PROBLEM: IPVS incorrectly reverse-NATs traffic to LVS host

2017-04-24 Thread Nick Moriarty
Hi Julian, Many thanks for your prompt fix! I've now tested this patch against the 4.11.0-rc8 kernel on Ubuntu, and I can confirm that my check script is no longer seeing incorrect addresses in its responses. Could you please keep me posted as this is merged? Thanks again On 22 April 2017 at

[PATCH] brcmfmac: Ensure pointer correctly set if skb data location changes

2017-04-24 Thread James Hughes
The incoming skb header may be resized if header space is insufficient, which might change the data adddress in the skb. Ensure that a cached pointer to that data is correctly set by moving assignment to after any possible changes. Signed-off-by: James Hughes ---

Re: bluetooth 6lowpan interfaces are not virtual anymore

2017-04-24 Thread Luiz Augusto von Dentz
Hi Alex, On Wed, Apr 19, 2017 at 8:43 PM, Alexander Aring wrote: > Hi, > > at first I want to clarify what my definition of virtual and non virtual > interface is: > > - virtual interfaces: has no queue(s) > - non virtual interfaces: has a queue(s) > > I did some "big" ASCII

[PATCH net] team: fix memory leaks

2017-04-24 Thread Pan Bian
In functions team_nl_send_port_list_get() and team_nl_send_options_get(), pointer skb keeps the return value of nlmsg_new(). When the call to genlmsg_put() fails, the memory is not freed(). This will result in memory leak bugs. Fixes: 9b00cf2d1024 ("team: implement multipart netlink messages for

Re: [PATCH net v2 1/3] net: hns: support deferred probe when can not obtain irq

2017-04-24 Thread Matthias Brugger
On 21/04/17 09:44, Yankejian wrote: From: lipeng In the hip06 and hip07 SoCs, the interrupt lines from the DSAF controllers are connected to mbigen hw module. The mbigen module is probed with module_init, and, as such, is not guaranteed to probe before the HNS driver. So

Re: [PATCH] ipvs: explicitly forbid ipv6 service/dest creation if ipv6 mod is disabled

2017-04-24 Thread Simon Horman
On Mon, Apr 24, 2017 at 10:21:30AM +0300, Julian Anastasov wrote: > > Hello, > > On Mon, 24 Apr 2017, Paolo Abeni wrote: > > > Hi, > > > > The problem with the patched code is that it tries to resolve ipv6 > > addresses that are not created/validated by the kernel. > > OK. Simon,

Re: [PATCH] net: ipv6: check route protocol when deleting routes

2017-04-24 Thread Lorenzo Colitti
On Fri, Dec 16, 2016 at 5:30 PM, Mantas Mikulėnas wrote: > The protocol field is checked when deleting IPv4 routes, but ignored for > IPv6, which causes problems with routing daemons accidentally deleting > externally set routes (observed by multiple bird6 users). > > This can

Re: [net 1/1] team: fix memory leaks

2017-04-24 Thread Jiri Pirko
Plus since you have only one patch, please do not do "1/1" in the email subject. Thanks. Mon, Apr 24, 2017 at 11:36:52AM CEST, bianpan2...@163.com wrote: >In functions team_nl_send_port_list_get() and >team_nl_send_options_get(), pointer skb keeps the return value of >nlmsg_new(). When the call

Re: [net 1/1] team: fix memory leaks

2017-04-24 Thread Jiri Pirko
Interesting. In last reply, I put the "[]" prefix example exactly as it should be, yet you managed to have it wrong... Mon, Apr 24, 2017 at 11:36:52AM CEST, bianpan2...@163.com wrote: >In functions team_nl_send_port_list_get() and >team_nl_send_options_get(), pointer skb keeps the return value

Re: [PATCH v2 net-next] net: ipv6: send unsolicited NA if enabled for all interfaces

2017-04-24 Thread Simon Horman
On Sat, Apr 22, 2017 at 09:10:13AM -0700, David Ahern wrote: > When arp_notify is set to 1 for either a specific interface or for 'all' > interfaces, gratuitous arp requests are sent. Since ndisc_notify is the > ipv6 equivalent to arp_notify, it should follow the same semantics. > Commit

[net 1/1] team: fix memory leaks

2017-04-24 Thread Pan Bian
In functions team_nl_send_port_list_get() and team_nl_send_options_get(), pointer skb keeps the return value of nlmsg_new(). When the call to genlmsg_put() fails, the memory is not freed(). This will result in memory leak bugs. Fixes: 9b00cf2d1024 ("team: implement multipart netlink messages for

Re: [PATCH net-next v4 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-24 Thread Simon Horman
On Fri, Apr 21, 2017 at 02:11:00PM -0400, Jamal Hadi Salim wrote: > On 17-04-21 12:12 PM, David Miller wrote: > > >Yes for existing attributes we are stuck in the mud because of how > >we've handled things in the past. I'm not saying we should change > >behavior for existing attributes. > > >

Re: [PATCH net-next v5 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-24 Thread Simon Horman
On Thu, Apr 20, 2017 at 04:24:53PM +0200, Jiri Pirko wrote: > Thu, Apr 20, 2017 at 04:18:50PM CEST, j...@mojatatu.com wrote: > >On 17-04-20 09:59 AM, Jiri Pirko wrote: > >> Thu, Apr 20, 2017 at 03:06:21PM CEST, j...@mojatatu.com wrote: > >> > From: Jamal Hadi Salim ... > >> >

Re: [PATCH v4 net-next] mdio_bus: Issue GPIO RESET to PHYs.

2017-04-24 Thread Roger Quadros
On 24/04/17 02:35, Andrew Lunn wrote: > On Fri, Apr 21, 2017 at 03:31:09PM +0200, Lars-Peter Clausen wrote: >> On 04/21/2017 03:15 PM, Roger Quadros wrote: >>> diff --git a/Documentation/devicetree/bindings/net/mdio.txt >>> b/Documentation/devicetree/bindings/net/mdio.txt >>> new file mode 100644

Re: [RFC PATCH 3/7] net: add option to get information about timestamped packets

2017-04-24 Thread Miroslav Lichvar
On Thu, Apr 13, 2017 at 12:16:09PM -0400, Willem de Bruijn wrote: > On Thu, Apr 13, 2017 at 11:18 AM, Miroslav Lichvar > wrote: > > On Thu, Apr 13, 2017 at 10:37:07AM -0400, Willem de Bruijn wrote: > >> Why is this L2 length needed? > > > > It's needed for incoming packets

Re: [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable

2017-04-24 Thread James Hughes
On 23 April 2017 at 20:34, Arend Van Spriel wrote: > On 21-4-2017 11:22, James Hughes wrote: >> On 20 April 2017 at 20:48, Arend van Spriel >> wrote: >>> + linux-wireless >>> >>> On 4/20/2017 1:16 PM, James Hughes wrote: The

Re: [PATCH v2 2/2] iproute2: add support for invisible qdisc dumping

2017-04-24 Thread Jiri Pirko
Wed, Mar 08, 2017 at 01:04:42PM CET, ji...@kernel.org wrote: >From: Jiri Kosina > >Support the new TCA_DUMP_INVISIBLE netlink attribute that allows asking >kernel to perform 'full qdisc dump', as for historical reasons some of the >default qdiscs are being hidden by the kernel.

Re: [Intel-wired-lan] [PATCH 1/2] e1000e: Don't return uninitialized stats

2017-04-24 Thread Paul Menzel
Dear Benjamin, Thank you for your fix. On 04/21/17 23:20, Benjamin Poirier wrote: Some statistics passed to ethtool are garbage because e1000e_get_stats64() doesn't write them, for example: tx_heartbeat_errors. This leaks kernel memory to userspace and confuses users. Could you please give

Re: [PATCH net-next] net: dsa: LAN9303: add i2c dependency

2017-04-24 Thread Juergen Borleis
Hi Tobias, On Monday 24 April 2017 10:07:37 Tobias Regnery wrote: > The Kconfig symbol for the I2C mode of the LAN9303 driver selects > REGMAP_I2C. This symbol depends on I2C but the driver doesen't has a > dependency on I2C. > > With CONFIG_I2C=n kconfig fails to select REGMAP_I2C and we get the

Re: [Intel-wired-lan] [PATCH 1/2] e1000e: Don't return uninitialized stats

2017-04-24 Thread Neftin, Sasha
On 4/23/2017 15:53, Neftin, Sasha wrote: -Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Benjamin Poirier Sent: Saturday, April 22, 2017 00:20 To: Kirsher, Jeffrey T Cc: netdev@vger.kernel.org;

[PATCH net-next] net: dsa: LAN9303: add i2c dependency

2017-04-24 Thread Tobias Regnery
The Kconfig symbol for the I2C mode of the LAN9303 driver selects REGMAP_I2C. This symbol depends on I2C but the driver doesen't has a dependency on I2C. With CONFIG_I2C=n kconfig fails to select REGMAP_I2C and we get the following warning: warning: (NET_DSA_SMSC_LAN9303_I2C) selects REGMAP_I2C

Re: [PATCH net] xfrm: fix stack access out of bounds with CONFIG_XFRM_SUB_POLICY

2017-04-24 Thread Herbert Xu
On Fri, Apr 21, 2017 at 02:05:31PM +0200, Sabrina Dubroca wrote: > > You're right. I had a note about that but it got lost. The bug > (ignoring what flavor of flowi is passed) is older than that (from the > introduction of subpolicies, I suspect, but I would have to dig more > into the history),

Re: macvlan: Fix device ref leak when purging bc_queue

2017-04-24 Thread Herbert Xu
On Fri, Apr 21, 2017 at 02:40:50PM +, joe.gha...@dell.com wrote: > That's not true. macvlan_dellink() unregisters the queue, and > macvlan_process_broadcast() will never get called. Please note that I'm not > speculating. I have traced enabled on the dev_put and dev_hold, and I'm >

Re: [PATCH iproute2 net 3/8] tc/pedit: Introduce 'add' operation

2017-04-24 Thread Amir Vadai
On Sun, Apr 23, 2017 at 01:44:51PM -0400, Jamal Hadi Salim wrote: > > Thanks for the excellent work. > > On 17-04-23 08:53 AM, Amir Vadai wrote: > > This command could be useful to increase/decrease fields value. > > > > Does this contradict the "retain" feature? Example rule to > retain the

[PATCH net] xfrm: do the garbage collection after flushing policy

2017-04-24 Thread Xin Long
Now xfrm garbage collection can be triggered by 'ip xfrm policy del'. These is no reason not to do it after flushing policies, especially considering that 'garbage collection deferred' is only triggered when it reaches gc_thresh. It's no good that the policy is gone but the xdst still hold there.

[PATCH net] bridge: shutdown bridge device before removing it

2017-04-24 Thread Xin Long
During removing a bridge device, if the bridge is still up, a new mdb entry still can be added in br_multicast_add_group() after all mdb entries are removed in br_multicast_dev_del(). Like the path: mld_ifc_timer_expire -> mld_sendpack -> ... br_multicast_rcv ->

Re: [PATCH] ipvs: explicitly forbid ipv6 service/dest creation if ipv6 mod is disabled

2017-04-24 Thread Julian Anastasov
Hello, On Mon, 24 Apr 2017, Paolo Abeni wrote: > Hi, > > The problem with the patched code is that it tries to resolve ipv6 > addresses that are not created/validated by the kernel. OK. Simon, please apply to ipvs tree. Acked-by: Julian Anastasov Regards --

Re: [PATCH 2/2] net: team: fix memory leak in team_nl_send_options_get

2017-04-24 Thread Jiri Pirko
Mon, Apr 24, 2017 at 09:04:55AM CEST, bianpan2...@163.com wrote: >In function team_nl_send_options_get(), pointer skb keeps the return >value of function nlmsg_new(). When the call to genlmsg_put() fails, the >control flow directly returns and does not free skb. This will result in >a memory leak

Re: [PATCH net-next 2/2] cls_flower: add support for matching MPLS fields (v2)

2017-04-24 Thread Jiri Pirko
Sat, Apr 22, 2017 at 10:52:47PM CEST, benjamin.laha...@netronome.com wrote: >Add support to the tc flower classifier to match based on fields in MPLS >labels (TTL, Bottom of Stack, TC field, Label). > >Signed-off-by: Benjamin LaHaise >Signed-off-by: Benjamin

Re: [PATCH net-next 1/2] flow_dissector: add mpls support (v2)

2017-04-24 Thread Jiri Pirko
Sat, Apr 22, 2017 at 10:52:46PM CEST, benjamin.laha...@netronome.com wrote: >Add support for parsing MPLS flows to the flow dissector in preparation for >adding MPLS match support to cls_flower. > >Signed-off-by: Benjamin LaHaise >Signed-off-by: Benjamin LaHaise

[PATCH 2/2] net: team: fix memory leak in team_nl_send_options_get

2017-04-24 Thread Pan Bian
In function team_nl_send_options_get(), pointer skb keeps the return value of function nlmsg_new(). When the call to genlmsg_put() fails, the control flow directly returns and does not free skb. This will result in a memory leak bug. This patch fixes it. Fixes: 8ea7fd0d8792 ("team: fix memory

[PATCH 1/2] net: team: fix memory leak in team_nl_send_port_list_get

2017-04-24 Thread Pan Bian
In function team_nl_send_port_list_get(), pointer skb keeps the return value of nlmsg_new(). When the call to genlmsg_put() fails, the memory is not freed. This will result in a memory leak bug. This patch fixes it. Fixes: fbd69cda90e7 ("team: fix memory leak") Signed-off-by: Pan Bian

Re: [PATCH] ipvs: explicitly forbid ipv6 service/dest creation if ipv6 mod is disabled

2017-04-24 Thread Paolo Abeni
Hi, On Sat, 2017-04-22 at 14:16 +0300, Julian Anastasov wrote: > On Thu, 20 Apr 2017, Paolo Abeni wrote: > > > When creating a new ipvs service, ipv6 addresses are always accepted > > if CONFIG_IP_VS_IPV6 is enabled. On dest creation the address family > > is not explicitly checked. > > > >

Re: [PATCH v3 07/29] x86: bpf_jit, use ENTRY+ENDPROC

2017-04-24 Thread Jiri Slaby
On 04/21/2017, 09:32 PM, Alexei Starovoitov wrote: > On Fri, Apr 21, 2017 at 04:12:43PM +0200, Jiri Slaby wrote: >> Do not use a custom macro FUNC for starts of the global functions, use >> ENTRY instead. >> >> And while at it, annotate also ends of the functions by ENDPROC. >> >> Signed-off-by:

Re: [ISSUE: sky2 - rx error] Link stops working under heavy traffic load connected to a mv88e6176

2017-04-24 Thread Rafa Corvillo
I resend the mail with the schema fixed. Sorry for the inconvenience. We are working in an ARMv7 embedded system running kernel 4.9 (LEDE build). It is an imx6 board with 2 ethernet interfaces. One of them is connected to a Marvell switch. The schema of the system is the following:

<    1   2   3