Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

On 2017/05/19 16:09, Vlad Yasevich wrote: > On 05/18/2017 10:13 PM, Toshiaki Makita wrote: >> On 2017/05/18 22:31, Vladislav Yasevich wrote: >>> It appears that since commit 8cb65d000, Q-in-Q vlans have been >>> broken. The series that commit is part of enabled TSO and checksum >>> offloading on

Re: [PATCH v4 net-next 6/7] net: allow simultaneous SW and HW transmit timestamping

On Thu, May 18, 2017 at 04:16:26PM -0400, Willem de Bruijn wrote: > On Thu, May 18, 2017 at 9:06 AM, Miroslav Lichvar wrote: > > +/* On transmit, software and hardware timestamps are returned > > independently. > > + * As the two skb clones share the hardware timestamp,

[PATCH 10/12] netfilter: nf_tables: revisit chain/object refcounting from elements

Andreas reports that the following incremental update using our commit protocol doesn't work. # nft -f incremental-update.nft delete element ip filter client_to_any { 10.180.86.22 : goto CIn_1 } delete chain ip filter CIn_1 ... Error: Could not process rule: Device or resource busy The

[PATCH 09/12] netfilter: nf_tables: missing sanitization in data from userspace

Do not assume userspace always sends us NFT_DATA_VALUE for bitwise and cmp expressions. Although NFT_DATA_VERDICT does not make any sense, it is still possible to handcraft a netlink message using this incorrect data type. Signed-off-by: Pablo Neira Ayuso ---

[PATCH 00/12] Netfilter/IPVS fixes for net

Hi David, The following patchset contains Netfilter/IPVS fixes for your net tree, they are: 1) When using IPVS in direct-routing mode, normal traffic from the LVS host to a back-end server is sometimes incorrectly NATed on the way back into the LVS host. Patch to fix this from Julian

[PATCH 03/12] netfilter: don't setup nat info for confirmed ct

From: Liping Zhang We cannot setup nat info if the ct has been confirmed already, else, different cpu may race to handle the same ct. In extreme situation, we may hit the "BUG_ON(nf_nat_initialized(ct, maniptype))" in the nf_nat_setup_info. Also running the following

[PATCH 02/12] netfilter: ctnetlink: Make some parameters integer to avoid enum mismatch

From: Matthias Kaehlcke Not all parameters passed to ctnetlink_parse_tuple() and ctnetlink_exp_dump_tuple() match the enum type in the signatures of these functions. Since this is intended change the argument type of to be an unsigned integer value. Signed-off-by: Matthias

RE: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Jim Baxter > Sent: 16 May 2017 18:41 > > The CDC-NCM driver can require large amounts of memory to create > skb's and this can be a problem when the memory becomes fragmented. > > This especially affects

Re: [PATCH v2] xfrm: fix state migration copy replay sequence numbers

On Fri, May 19, 2017 at 12:47:00PM +0200, Antony Antony wrote: > During xfrm migration copy replay and preplay sequence numbers > from the previous state. > > Here is a tcpdump output showing the problem. > 10.0.10.46 is running vanilla kernel, is the IKE/IPsec responder. > After the migration it

Re: [PATCH] xfrm: fix state migration replay sequence numbers

On Thu, May 18, 2017 at 04:39:53PM +0200, Antony Antony wrote: > During xfrm migration replay and preplay sequence numbers are not > copied from the previous state. > > Here is tcpdump output showing the problem. > 10.0.10.46 is running vanilla kernel, IKE/IPsec responder. > After the migration

Re: [PATCH net-next] xfrm: Make function xfrm_dev_register static

On Thu, May 18, 2017 at 03:51:38PM +, Wei Yongjun wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > net/xfrm/xfrm_device.c:141:5: warning: > symbol 'xfrm_dev_register' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun

Re: ipsec doesn't route TCP with 4.11 kernel

On Tue, May 16, 2017 at 03:05:40PM -0400, Don Bowman wrote: > On 3 May 2017 at 04:14, Steffen Klassert wrote: > > On Sat, Apr 29, 2017 at 08:39:34PM -0400, Don Bowman wrote: > >> On 28 April 2017 at 03:13, Steffen Klassert > >> wrote: >

Re: [PATCH v2] e1000e: Don't return uninitialized stats

On Thu, 2017-05-18 at 10:46 -0400, David Miller wrote: > From: Benjamin Poirier > Date: Wed, 17 May 2017 16:24:13 -0400 > > > Some statistics passed to ethtool are garbage because > > e1000e_get_stats64() > > doesn't write them, for example: tx_heartbeat_errors. This leaks

RE: [PATCH net-next 9/9] nfp: eliminate an if statement in calculation of completed frames

From: Jakub Kicinski > Sent: 17 May 2017 18:37 .. > > > while (todo--) { > > > idx = D_IDX(tx_ring, tx_ring->rd_p++); > > > > That '++' looks suspicious. > > I think you need to decide whether you are incrementing pointers into the > > ring > > or indexes into it. > > Sometimes it is

[PATCH net-next] cxgb4: fix incorrect cim_la output for T6

take care of UpDbgLaRdPtr[0-3] restriction for T6 Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c

Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

On 18/05/17 09:11, Greg KH wrote: So backporting that one patch solves the issue here? Can you please verify it, and let me know before I apply it? thanks, greg k-h yes, I can do that.

[PATCH 11/12] ebtables: arpreply: Add the standard target sanity check

From: Gao Feng The info->target comes from userspace and it would be used directly. So we need to add the sanity check to make sure it is a valid standard target, although the ebtables tool has already checked it. Kernel needs to validate anything coming from userspace.

[PATCH 08/12] netfilter: nf_tables: can't assume lock is acquired when dumping set elems

From: Liping Zhang When dumping the elements related to a specified set, we may invoke the nf_tables_dump_set with the NFNL_SUBSYS_NFTABLES lock not acquired. So we should use the proper rcu operation to avoid race condition, just like other nft dump operations.

[PATCH 12/12] netfilter: xtables: fix build failure from COMPAT_XT_ALIGN outside CONFIG_COMPAT

From: Willem de Bruijn The patch in the Fixes references COMPAT_XT_ALIGN in the definition of XT_DATA_TO_USER, outside an #ifdef CONFIG_COMPAT block. Split XT_DATA_TO_USER into separate compat and non compat variants and define the first inside an CONFIG_COMPAT block. This

[PATCH 04/12] netfilter: introduce nf_conntrack_helper_put helper function

From: Liping Zhang And convert module_put invocation to nf_conntrack_helper_put, this is prepared for the followup patch, which will add a refcnt for cthelper, so we can reject the deleting request when cthelper is in use. Signed-off-by: Liping Zhang

[PATCH 06/12] netfilter: xtables: zero padding in data_to_user

From: Willem de Bruijn When looking up an iptables rule, the iptables binary compares the aligned match and target data (XT_ALIGN). In some cases this can exceed the actual data size to include padding bytes. Before commit f77bc5b23fb1 ("iptables: use match, target and data

[PATCH 07/12] netfilter: synproxy: fix conntrackd interaction

From: Eric Leblond This patch fixes the creation of connection tracking entry from netlink when synproxy is used. It was missing the addition of the synproxy extension. This was causing kernel crashes when a conntrack entry created by conntrackd was used after the switch of

[PATCH 05/12] netfilter: nfnl_cthelper: reject del request if helper obj is in use

From: Liping Zhang We can still delete the ct helper even if it is in use, this will cause a use-after-free error. In more detail, I mean: # nfct helper add ssdp inet udp # iptables -t raw -A OUTPUT -p udp -j CT --helper ssdp # nfct helper delete ssdp //--> oops,

[PATCH 01/12] ipvs: SNAT packet replies only for NATed connections

From: Julian Anastasov We do not check if packet from real server is for NAT connection before performing SNAT. This causes problems for setups that use DR/TUN and allow local clients to access the real server directly, for example: - local client in director creates IPVS-DR/TUN

Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

On 05/19/2017 04:16 AM, Toshiaki Makita wrote: > On 2017/05/19 16:09, Vlad Yasevich wrote: >> On 05/18/2017 10:13 PM, Toshiaki Makita wrote: >>> On 2017/05/18 22:31, Vladislav Yasevich wrote: It appears that since commit 8cb65d000, Q-in-Q vlans have been broken. The series that commit

Re: [PATCH v5 net-next 5/7] net: fix documentation of struct scm_timestamping

On Thu, May 18, 2017 at 03:38:30PM -0400, Willem de Bruijn wrote: > On Thu, May 18, 2017 at 10:07 AM, Miroslav Lichvar > wrote: > > +Note that if the SO_TIMESTAMP or SO_TIMESTAMPNS option is enabled > > +together with SO_TIMESTAMPING using SOF_TIMESTAMPING_SOFTWARE, a false

[PATCH net-next v2] ibmveth: Support to enable LSO/CSO for Trunk VEA.

Current largesend and checksum offload feature in ibmveth driver, - Source VM sends the TCP packets with ip_summed field set as CHECKSUM_PARTIAL and TCP pseudo header checksum is placed in checksum field - CHECKSUM_PARTIAL flag in SKB will enable ibmveth driver to mark "no checksum" and

Re: [PATCH v5 net-next 4/7] net: add new control message for incoming HW-timestamped packets

On Thu, May 18, 2017 at 04:20:53PM -0400, Willem de Bruijn wrote: > On Thu, May 18, 2017 at 10:07 AM, Miroslav Lichvar > wrote: > > +SOF_TIMESTAMPING_OPT_PKTINFO: > > + > > + Enable the SCM_TIMESTAMPING_PKTINFO control message for incoming > > + packets with hardware

[PATCH v2] xfrm: fix state migration copy replay sequence numbers

During xfrm migration copy replay and preplay sequence numbers from the previous state. Here is a tcpdump output showing the problem. 10.0.10.46 is running vanilla kernel, is the IKE/IPsec responder. After the migration it sent wrong sequence number, reset to 1. The migration is from 10.0.0.52 to

Re: [RFC net-next PATCH 4/5] net: new XDP feature for reading HW rxhash from drivers

On Thu, 18 May 2017 17:41:48 +0200 Jesper Dangaard Brouer wrote: > Introducing a new XDP feature and associated bpf helper bpf_xdp_rxhash. > > The rxhash and type allow filtering on packets without touching > packet memory. The performance difference on my system with a >

Re: [PATCH v3 net-next 5/5] dsa: add maintainer of Microchip KSZ switches

On 05/19/2017 03:57 PM, woojung@microchip.com wrote: > From: Woojung Huh > > Adding maintainer of Microchip KSZ switches. > > Signed-off-by: Woojung Huh > Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli

Re: [PATCH v3 net-next 4/5] dsa: Add spi support to Microchip KSZ switches

On 05/19/2017 03:57 PM, woojung@microchip.com wrote: > From: Woojung Huh > > A sample SPI configuration for Microchip KSZ switches. > > Signed-off-by: Woojung Huh > Reviewed-by: Andrew Lunn Subject should be something

RE: [PATCH v3 net-next 1/5] dsa: add support for Microchip KSZ tail tagging

>> + if (padlen) { >> + u8 *pad = skb_put(nskb, padlen); >> + >> + memset(pad, 0, padlen); >> + } > >Can you use skb_put_padto() here instead of open coding this? > >> + >> + tag = skb_put(nskb, KSZ_INGRESS_TAG_LEN); >> + tag[0] = 0; >> + tag[1] = 1 <<

Re: [RFC net-next PATCH 4/5] net: new XDP feature for reading HW rxhash from drivers

On Fri, 19 May 2017 20:07:52 -0700, Alexei Starovoitov wrote: > How about exposing 'struct mlx5_cqe64 *' to XDP programs as-is? > We can make sure that XDP program does read only access into it and > it will see cqe->rss_hash_result, cqe->rss_hash_type and everything else > in there, but this will

[PATCH v2 net-next] net: ipv6: fix code style error and warning of ndisc.c

From: yuan linyu Signed-off-by: yuan linyu --- net/ipv6/ndisc.c | 300 --- 1 file changed, 155 insertions(+), 145 deletions(-) diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c

Re: [PATCH v3 net-next 3/5] dsa: add DSA switch driver for Microchip KSZ9477

On 05/19/2017 03:57 PM, woojung@microchip.com wrote: > From: Woojung Huh > > The KSZ9477 is a fully integrated layer 2, managed, 7 ports GigE switch > with numerous advanced features. 5 ports incorporate 10/100/1000 Mbps PHYs. > The other 2 ports have interfaces

[PATCH] i40e: Fix incorrect pf->flags

Fix bug introduced by 'commit 47994c119a36e ("i40e: remove hw_disabled_flags in favor of using separate flag bits")' that mistakenly wipes out pf->flags. Signed-off-by: Tushar Dave --- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++-- 1 file changed, 2

Re: [PATCH v3 net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

On 05/19/2017 03:57 PM, woojung@microchip.com wrote: > From: Woojung Huh > > Adding Microchip 9477 Phy included in KSZ9477 Switch. > > Signed-off-by: Woojung Huh > Signed-off-by: Andrew Lunn Reviewed-by: Florian

Re: [PATCH v3 net-next 1/5] dsa: add support for Microchip KSZ tail tagging

On 05/19/2017 03:57 PM, woojung@microchip.com wrote: > From: Woojung Huh > > Adding support for the Microchip KSZ switch family tail tagging. > > Signed-off-by: Woojung Huh > Reviewed-by: Andrew Lunn > --- >

Re: [PATCH v2 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

On 5/19/17 4:16 PM, David Miller wrote: From: Alexei Starovoitov Date: Fri, 19 May 2017 14:37:56 -0700 On 5/19/17 1:41 PM, David Miller wrote: From: Edward Cree Date: Fri, 19 May 2017 18:17:42 +0100 One question: is there a way to build the verifier as

Re: [RFC net-next PATCH 4/5] net: new XDP feature for reading HW rxhash from drivers

On Fri, 19 May 2017 20:34:00 -0700, Alexei Starovoitov wrote: > On Fri, May 19, 2017 at 08:21:47PM -0700, Jakub Kicinski wrote: > > On Fri, 19 May 2017 20:07:52 -0700, Alexei Starovoitov wrote: > > > How about exposing 'struct mlx5_cqe64 *' to XDP programs as-is? > > > We can make sure that XDP

Re: [PATCH net-next] geneve: always fill CSUM6_RX configuration

On Thu, May 18, 2017 at 12:59 PM, Eric Garver wrote: > CSMU6_RX is relevant for collect_metadata as well. As such leave it > outside of the dev's IPv4/IPv6 checks. > Can you explain it bit? is this flag used with ipv4 tunnels? > Fixes: 9b4437a5b870 ("geneve: Unify LWT and netdev

[net-next] net: ipv6: fix code style error and warning of ndisc.c

From: yuan linyu Signed-off-by: yuan linyu --- net/ipv6/ndisc.c | 300 --- 1 file changed, 155 insertions(+), 145 deletions(-) diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c

Re: [RFC net-next PATCH 4/5] net: new XDP feature for reading HW rxhash from drivers

On Thu, May 18, 2017 at 05:41:48PM +0200, Jesper Dangaard Brouer wrote: > > +/* XDP rxhash have an associated type, which is related to the RSS > + * (Receive Side Scaling) standard, but NIC HW have different mapping > + * and support. Thus, create mapping that is interesting for XDP. XDP > + *

Re: [RFC net-next PATCH 4/5] net: new XDP feature for reading HW rxhash from drivers

On Fri, May 19, 2017 at 08:21:47PM -0700, Jakub Kicinski wrote: > On Fri, 19 May 2017 20:07:52 -0700, Alexei Starovoitov wrote: > > How about exposing 'struct mlx5_cqe64 *' to XDP programs as-is? > > We can make sure that XDP program does read only access into it and > > it will see

Re: [PATCH net-next v2] bridge: fix hello and hold timers starting/stopping

On Fri, May 19, 2017 at 07:30:43PM +0200, Ivan Vecera wrote: > Current bridge code incorrectly handles starting/stopping of hello and > hold timers during STP enable/disable. > > 1. Timers are stopped in br_stp_start() during NO_STP->USER_STP >transition. The timers are already stopped in

Re: [PATCH net] ah: use crypto_memneq to check the ICV

On Fri, May 19, 2017 at 02:25:14PM +0200, Sabrina Dubroca wrote: > Hi Steffen, > > 2017-05-04, 12:41:24 +0200, Steffen Klassert wrote: > > On Wed, May 03, 2017 at 04:57:57PM +0200, Sabrina Dubroca wrote: > > > Signed-off-by: Sabrina Dubroca > > > --- > > > net/ipv4/ah4.c |

RE: [PATCH net-next] cxgb4: fix incorrect cim_la output for T6

From: Ganesh Goudar > Sent: 19 May 2017 11:12 T6 > > take care of UpDbgLaRdPtr[0-3] restriction for T6 > > Signed-off-by: Ganesh Goudar > --- > drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: general protection fault in skb_release_data

On Fri, May 19, 2017 at 5:57 AM, Andrey Konovalov wrote: > On Fri, May 19, 2017 at 12:18 PM, wrote: >> Hi, >> >> I've got the following bug report while fuzzing the >> kernel(master-f83246089ca) with syzkaller. >> >> program and config are attached. >

Re: [PATCH v2 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

On 5/19/17 7:21 AM, Edward Cree wrote: I'm currently translating the algos to C. But for the kernel patch, I'll need to read & understand the existing verifier code, so it might take a while :) (I don't suppose there's any design document or hacking-notes you could point me at?) Dave just

[PATCH v2 net] smsc95xx: Support only IPv4 TCP/UDP csum offload

From: Nisar Sayed When TX checksum offload is used, if the computed checksum is 0 the LAN95xx device do not alter the checksum to 0x. In the case of ipv4 UDP checksum, it indicates to receiver that no checksum is calculated. Under ipv6, UDP checksum yields a

Re: general protection fault in skb_release_data

On Fri, May 19, 2017 at 4:36 PM, 'Eric Dumazet' via syzkaller wrote: > On Fri, May 19, 2017 at 5:57 AM, Andrey Konovalov > wrote: >> On Fri, May 19, 2017 at 12:18 PM, wrote: >>> Hi, >>> >>> I've got the following bug

[PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop kernel hello and hold timers"), bridge would not start hello_timer if stp_enabled is not KERNEL_STP when br_dev_open. The problem is even if users set stp_enabled with KERNEL_STP later, the timer will still not be started. It

RE: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

From: Bjørn Mork > Sent: 19 May 2017 14:56 ... > Unless someone has a nice way to just collect a list of skbs and have > them converted to proper framing on the fly when transmitting, without > having to care about USB packet boundaries. skb can be linked into arbitrary chains (or even trees),

[PATCH v2] hdlcdrv: fix divide error bug if bitrate is 0

The divisor s->par.bitrate will always be 0 until initialized by ndo_open() and hdlcdrv_open(). In order to fix this divide zero error, check whether the netdevice was opened by ndo_open() before performing divide.And we also check the the value of bitrate in case of bad setting of it.

Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

On 17/05/19 (金) 18:53, Vlad Yasevich wrote: On 05/19/2017 04:16 AM, Toshiaki Makita wrote: On 2017/05/19 16:09, Vlad Yasevich wrote: On 05/18/2017 10:13 PM, Toshiaki Makita wrote: On 2017/05/18 22:31, Vladislav Yasevich wrote: It appears that since commit 8cb65d000, Q-in-Q vlans have been

Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

David Laight writes: > From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Jim Baxter >> Sent: 16 May 2017 18:41 >> >> The CDC-NCM driver can require large amounts of memory to create >> skb's and this can be a problem when the

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

On 5/19/17 5:48 PM, Florian Westphal wrote: Nikolay Aleksandrov wrote: On 5/19/17 5:20 PM, Xin Long wrote: Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop kernel hello and hold timers"), bridge would not start hello_timer if stp_enabled is

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-19 16:57 GMT+02:00 Nikolay Aleksandrov : > On 5/19/17 5:51 PM, Ivan Vecera wrote: >> >> 2017-05-19 16:45 GMT+02:00 Nikolay Aleksandrov >> : >>> >>> On 5/19/17 5:20 PM, Xin Long wrote: Since commit 76b91c32dd86

[PATCH iproute2] ip: add handling for new CAN netlink interface

This patch adds handling for new CAN netlink interface introduced in 4.11 kernel: - IFLA_CAN_TERMINATION, - IFLA_CAN_TERMINATION_CONST, - IFLA_CAN_BITRATE_CONST, - IFLA_CAN_DATA_BITRATE_CONST Output example: $ip -d link show can0 6: can0: mtu 16 qdisc noop state DOWN mode DEFAULT

Good day my dear, please i need your assistant

How are you doing today, Hope you are in perfect condition? Please i apologies with you to exercise a little patience and read through my letter i am contacting you for obvious reason and important business. My Name is Aisha Gaddafi,i am open minded person and easy going person romance and hard

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

Nikolay Aleksandrov wrote: > On 5/19/17 5:20 PM, Xin Long wrote: > >Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop > >kernel hello and hold timers"), bridge would not start hello_timer if > >stp_enabled is not KERNEL_STP when br_dev_open. > > >

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-19 16:45 GMT+02:00 Nikolay Aleksandrov : > On 5/19/17 5:20 PM, Xin Long wrote: >> >> Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop >> kernel hello and hold timers"), bridge would not start hello_timer if >> stp_enabled is not KERNEL_STP

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

On 5/19/17 6:03 PM, Ivan Vecera wrote: 2017-05-19 16:57 GMT+02:00 Nikolay Aleksandrov : On 5/19/17 5:51 PM, Ivan Vecera wrote: 2017-05-19 16:45 GMT+02:00 Nikolay Aleksandrov : On 5/19/17 5:20 PM, Xin Long wrote: Since commit

Re: [PATCH net 3/3] virtio-net: enable TSO/checksum offloads for Q-in-Q vlans

On 2017年05月18日 21:31, Vladislav Yasevich wrote: Since virtio does not provide it's own ndo_features_check handler, TSO, and now checksum offload, are disabled for stacked vlans. Re-enable the support and let the host take care of it. This restores/improves Guest-to-Guest performance over

Re: [PATCH v4 net-next 6/7] net: allow simultaneous SW and HW transmit timestamping

On Fri, May 19, 2017 at 6:00 AM, Miroslav Lichvar wrote: > On Thu, May 18, 2017 at 04:16:26PM -0400, Willem de Bruijn wrote: >> On Thu, May 18, 2017 at 9:06 AM, Miroslav Lichvar >> wrote: >> > +/* On transmit, software and hardware timestamps are

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-19 17:05 GMT+02:00 Nikolay Aleksandrov : > On 5/19/17 6:03 PM, Ivan Vecera wrote: >> >> 2017-05-19 16:57 GMT+02:00 Nikolay Aleksandrov >> : >>> >>> On 5/19/17 5:51 PM, Ivan Vecera wrote: 2017-05-19 16:45 GMT+02:00

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-19 16:20 GMT+02:00 Xin Long : > Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop > kernel hello and hold timers"), bridge would not start hello_timer if > stp_enabled is not KERNEL_STP when br_dev_open. > > The problem is even if users set

[PATCH net] sctp: fix ICMP processing if skb is non-linear

when the ICMP packet is carried by a paged skb, sctp_err_lookup() may fail validation even if the payload contents match an open socket: as a consequence, sometimes ICMPs are wrongly ignored. Use skb_header_pointer() to retrieve encapsulated SCTP headers, to ensure that ICMP payloads are validated

Re: [RFC net-next PATCH 2/5] mlx5: fix bug reading rss_hash_type from CQE

On 05/18/2017 05:41 PM, Jesper Dangaard Brouer wrote: Masks for extracting part of the Completion Queue Entry (CQE) field rss_hash_type was swapped, namely CQE_RSS_HTYPE_IP and CQE_RSS_HTYPE_L4. The bug resulted in setting skb->l4_hash, even-though the rss_hash_type indicated that hash was NOT

[PATCH v6 net-next 7/7] net: ethernet: update drivers to make both SW and HW TX timestamps

Some drivers were calling the skb_tx_timestamp() function only when a hardware timestamp was not requested. Now that applications can use the SOF_TIMESTAMPING_OPT_TX_SWHW option to request both software and hardware timestamps, the drivers need to be modified to unconditionally call

[PATCH v6 net-next 5/7] net: fix documentation of struct scm_timestamping

The scm_timestamping struct may return multiple non-zero fields, e.g. when both software and hardware RX timestamping is enabled, or when the SO_TIMESTAMP(NS) option is combined with SCM_TIMESTAMPING and a false software timestamp is generated in the recvmsg() call in order to always return a

[PATCH v6 net-next 6/7] net: allow simultaneous SW and HW transmit timestamping

Add SOF_TIMESTAMPING_OPT_TX_SWHW option to allow an outgoing packet to be looped to the socket's error queue with a software timestamp even when a hardware transmit timestamp is expected to be provided by the driver. Applications using this option will receive two separate messages from the error

Re: [PATCH net] bridge: fix hello and hold timers starting/stopping

On Fri, 19 May 2017 18:25:43 +0200 Ivan Vecera wrote: > Current bridge code incorrectly handles starting/stopping of hello and > hold timers during STP enable/disable. > > 1. Timers are stopped in br_stp_start() during NO_STP->USER_STP >transition. This is not correct as the

[PATCH net-next 7/9] fou: make local function static

The build header functions are not used by any other code. net/ipv6/fou6.c:36:5: warning: no previous prototype for ‘fou6_build_header’ [-Wmissing-prototypes] net/ipv6/fou6.c:54:5: warning: no previous prototype for ‘gue6_build_header’ [-Wmissing-prototypes] Need to do some code rearranging to

[PATCH net-next 1/9] dcb: enforce minimum length on IEEE_APPS attribute

Found by reviewing the warning about unused policy table. The code implies that it meant to check for size, but since it unrolled the loop for attribute validation that is never used. Instead do explicit check for attribute. Compile tested only. Needs review by original author. Signed-off-by:

[PATCH net-next 4/9] inet: fix warning about missing prototype

The prototype for inet_rcv_saddr_equal was not being included. Signed-off-by: Stephen Hemminger --- net/ipv4/inet_connection_sock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c index

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

On 5/19/17 5:20 PM, Xin Long wrote: Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop kernel hello and hold timers"), bridge would not start hello_timer if stp_enabled is not KERNEL_STP when br_dev_open. The problem is even if users set stp_enabled with KERNEL_STP later,

Re: [PATCH v6 net-next 5/7] net: fix documentation of struct scm_timestamping

On Fri, May 19, 2017 at 11:52 AM, Miroslav Lichvar wrote: > The scm_timestamping struct may return multiple non-zero fields, e.g. > when both software and hardware RX timestamping is enabled, or when the > SO_TIMESTAMP(NS) option is combined with SCM_TIMESTAMPING and a false

Re: [PATCH v6 net-next 6/7] net: allow simultaneous SW and HW transmit timestamping

On Fri, May 19, 2017 at 11:52 AM, Miroslav Lichvar wrote: > Add SOF_TIMESTAMPING_OPT_TX_SWHW option to allow an outgoing packet to > be looped to the socket's error queue with a software timestamp even > when a hardware transmit timestamp is expected to be provided by the >

Re: [PATCH v5 net-next 5/7] net: fix documentation of struct scm_timestamping

On Fri, May 19, 2017 at 6:11 AM, Miroslav Lichvar wrote: > On Thu, May 18, 2017 at 03:38:30PM -0400, Willem de Bruijn wrote: >> On Thu, May 18, 2017 at 10:07 AM, Miroslav Lichvar >> wrote: >> > +Note that if the SO_TIMESTAMP or SO_TIMESTAMPNS option is

[PATCH net] bridge: fix hello and hold timers starting/stopping

Current bridge code incorrectly handles starting/stopping of hello and hold timers during STP enable/disable. 1. Timers are stopped in br_stp_start() during NO_STP->USER_STP transition. This is not correct as the timers are stopped in NO_STP case. 2. Timers are started in br_stp_stop()

Re: [PATCH net] bridge: fix hello and hold timers starting/stopping

On 5/19/17 7:25 PM, Ivan Vecera wrote: Current bridge code incorrectly handles starting/stopping of hello and hold timers during STP enable/disable. 1. Timers are stopped in br_stp_start() during NO_STP->USER_STP transition. This is not correct as the timers are stopped in NO_STP case.

Re: [PATCH net] bridge: fix hello and hold timers starting/stopping

2017-05-19 18:51 GMT+02:00 Xin Long : > On Sat, May 20, 2017 at 12:25 AM, Ivan Vecera wrote: >> Current bridge code incorrectly handles starting/stopping of hello and >> hold timers during STP enable/disable. >> >> 1. Timers are stopped in br_stp_start() during

Re: [PATCH net] bridge: fix hello and hold timers starting/stopping

2017-05-19 18:55 GMT+02:00 Nikolay Aleksandrov : > On 5/19/17 7:25 PM, Ivan Vecera wrote: >> >> Current bridge code incorrectly handles starting/stopping of hello and >> hold timers during STP enable/disable. >> >> 1. Timers are stopped in br_stp_start() during

[PATCH iproute2 1/1] tc: fix Makefile to build skbmod

Signed-off-by: Roman Mashak --- tc/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tc/Makefile b/tc/Makefile index 9a6bb1d..678b302 100644 --- a/tc/Makefile +++ b/tc/Makefile @@ -45,6 +45,7 @@ TCMODULES += m_nat.o TCMODULES += m_pedit.o TCMODULES += m_ife.o

Re: [RFC net-next PATCH 1/5] samples/bpf: xdp_tx_iptunnel make use of map_data[]

On 05/18/2017 05:41 PM, Jesper Dangaard Brouer wrote: There is no reason to use a compile time constant MAX_IPTNL_ENTRIES shared between the _user.c and _kern.c, when map_data[].def.max_entries can tell us dynamically what the max_entries were of the ELF map that the bpf loaded created.

[PATCH v6 net-next 4/7] net: add new control message for incoming HW-timestamped packets

Add SOF_TIMESTAMPING_OPT_PKTINFO option to request a new control message for incoming packets with hardware timestamps. It contains the index of the real interface which received the packet and the length of the packet at layer 2. The index is useful with bonding, bridges and other interfaces,

[PATCH v6 net-next 2/7] net: ethernet: update drivers to handle HWTSTAMP_FILTER_NTP_ALL

Include HWTSTAMP_FILTER_NTP_ALL in net_hwtstamp_validate() as a valid filter and update drivers which can timestamp all packets, or which explicitly list unsupported filters instead of using a default case, to handle the filter. CC: Richard Cochran CC: Willem de Bruijn

[PATCH v6 net-next 3/7] net: add function to retrieve original skb device using NAPI ID

Since commit b68581778cd0 ("net: Make skb->skb_iif always track skb->dev") skbs don't have the original index of the interface which received the packet. This information is now needed for a new control message related to hardware timestamping. Instead of adding a new field to skb, we can find

[PATCH v6 net-next 0/7] Extend socket timestamping API

Changes v5->v6: - fixed skb_is_swtx_tstamp() when OPT_TX_SWHW is disabled and improved its description - improved OPT_PKTINFO documentation - improved scm_timestamping documentation Changes v4->v5: - fixed initialization of reserved fields in struct scm_ts_pktinfo Changes v3->v4: - added

[PATCH v6 net-next 1/7] net: define receive timestamp filter for NTP

Add HWTSTAMP_FILTER_NTP_ALL to the hwtstamp_rx_filters enum for timestamping of NTP packets. There is currently only one driver (phyter) that could support it directly. CC: Richard Cochran CC: Willem de Bruijn Signed-off-by: Miroslav Lichvar

HELLO!!!!!

HELLO! I am Mr Neil Trotter, the current winner of 108 Euro millions jackpot, if you have received this email then you are of the lucky fellows to benefit from me,so do get back to me for a better understanding. Here is the website for proof

Re: [PATCH net-next V5 0/9] vhost_net rx batch dequeuing

On Fri, May 19, 2017 at 02:27:16PM +0800, Jason Wang wrote: > > > On 2017年05月18日 04:59, Michael S. Tsirkin wrote: > > On Wed, May 17, 2017 at 12:14:36PM +0800, Jason Wang wrote: > > > This series tries to implement rx batching for vhost-net. This is done > > > by batching the dequeuing from

Re: [PATCH net] bridge: fix hello and hold timers starting/stopping

On Sat, May 20, 2017 at 12:25 AM, Ivan Vecera wrote: > Current bridge code incorrectly handles starting/stopping of hello and > hold timers during STP enable/disable. > > 1. Timers are stopped in br_stp_start() during NO_STP->USER_STP >transition. This is not correct as the

Re: [PATCH net-next] net: sched: provide stubs for tcf_chain_{get,put} for CONFIG_NET_CLS=n

On Thu, May 18, 2017 at 9:24 AM, Sabrina Dubroca wrote: > This also changes tcf_chain_get() to return an error pointer instead of > NULL, so that tcf_action_goto_chain_init() can differentiate memory > allocation failure from lack of support. > > Fixes: 5bc1701881e3 ("net:

[PATCH net-next 3/9] udp: make local function static

udp_queue_rcv_skb was global but only used in one file. Identified by this warning: net/ipv4/udp.c:1775:5: warning: no previous prototype for ‘udp_queue_rcv_skb’ [-Wmissing-prototypes] int udp_queue_rcv_skb(struct sock *sk, struct sk_buff *skb) Signed-off-by: Stephen Hemminger

[PATCH net-next 6/9] xfrm: make xfrm_dev_register static

This function is only used in this file and should not be global. Signed-off-by: Stephen Hemminger --- net/xfrm/xfrm_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_device.c b/net/xfrm/xfrm_device.c index

[PATCH net-next 8/9] ipv6: drop unused variables in seg6_genl_dumphac

THe seg6_pernet_data variable was set but never used. Signed-off-by: Stephen Hemminger --- net/ipv6/seg6.c | 4 1 file changed, 4 deletions(-) diff --git a/net/ipv6/seg6.c b/net/ipv6/seg6.c index 5f44ffed2576..15fba55e3da8 100644 --- a/net/ipv6/seg6.c +++

[PATCH net-next 2/9] ila: propagate error code in ila_output

This warning: net/ipv6/ila/ila_lwt.c: In function ‘ila_output’: net/ipv6/ila/ila_lwt.c:42:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable] It looks like the code attempts to set propagate different error values, but always returned -EINVAL. Compile tested only. Needs

  1   2   3   >