[PATCH net-next 9/9] ipv6: remove unused variables in esp6

2017-05-19 Thread Stephen Hemminger
Resolves warnings: net/ipv6/esp6.c: In function ‘esp_ssg_unref’: net/ipv6/esp6.c:121:10: warning: variable ‘seqhi’ set but not used [-Wunused-but-set-variable] net/ipv6/esp6.c: In function ‘esp6_output_head’: net/ipv6/esp6.c:227:21: warning: variable ‘esph’ set but not used

[PATCH net-next 5/9] tcpnv: do not export local function

2017-05-19 Thread Stephen Hemminger
The TCP New Vegas congestion control was exporting an internal function tcpnv_get_info which is not used by any other in tree kernel code. Make it static. Signed-off-by: Stephen Hemminger --- net/ipv4/tcp_nv.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

[PATCH net-next 0/9] warning cleanups

2017-05-19 Thread Stephen Hemminger
This series addresses a number of warnings in common networking code visible when kernel is built with W=1 The DCB patch needs review from John Fastbend the original author of the netlink interface since it adds missing checks. Stephen Hemminger (9): dcb: enforce minimum length on IEEE_APPS

Re: [RFC net-next PATCH 3/5] net: introduce XDP driver features interface

2017-05-19 Thread Daniel Borkmann
On 05/18/2017 05:41 PM, Jesper Dangaard Brouer wrote: There is a fundamental difference between normal eBPF programs and (XDP) eBPF programs getting attached in a driver. For normal eBPF programs it is easy to add a new bpf feature, like a bpf helper, because is it strongly tied to the feature

[Patch net] vsock: use new wait API for vsock_stream_sendmsg()

2017-05-19 Thread Cong Wang
As reported by Michal, vsock_stream_sendmsg() could still sleep at vsock_stream_has_space() after prepare_to_wait(): vsock_stream_has_space vmci_transport_stream_has_space vmci_qpair_produce_free_space qp_lock qp_acquire_queue_mutex mutex_lock Just

Re: [PATCH] e1000e: use disable_hardirq() also for MSIX vectors in e1000_netpoll()

2017-05-19 Thread Cong Wang
On Fri, May 19, 2017 at 12:18 AM, Konstantin Khlebnikov wrote: > Replace disable_irq() which waits for threaded irq handlers with > disable_hardirq() which waits only for hardirq part. > > Signed-off-by: Konstantin Khlebnikov > Fixes:

[PATCH net-next v2] bridge: fix hello and hold timers starting/stopping

2017-05-19 Thread Ivan Vecera
Current bridge code incorrectly handles starting/stopping of hello and hold timers during STP enable/disable. 1. Timers are stopped in br_stp_start() during NO_STP->USER_STP transition. The timers are already stopped in NO_STP state so this is confusing no-op. 2. During USER_STP->NO_STP

Re: [PATCH net] fix BUG: scheduling while atomic in netlink broadcast

2017-05-19 Thread Cong Wang
On Fri, May 19, 2017 at 10:22 AM, Akshay Narayan wrote: > netlink_broadcast_filtered() calls yield() when a slow listener causes > the buffer to fill. yield() is the wrong choice here, as pointed out by > Commit 8e3fabfde4 (sched: Update yield() docs); in some cases, its use

Re: [PATCH net] sctp: fix ICMP processing if skb is non-linear

2017-05-19 Thread Xin Long
On Fri, May 19, 2017 at 11:34 PM, Davide Caratti wrote: > when the ICMP packet is carried by a paged skb, sctp_err_lookup() may fail > validation even if the payload contents match an open socket: as a > consequence, sometimes ICMPs are wrongly ignored. Use

Re: [PATCH] net: sched: fix a use-after-free error on chain on the error exit path

2017-05-19 Thread Cong Wang
On Thu, May 18, 2017 at 7:07 AM, Colin King wrote: > diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c > index 4020b8d932a1..82ebdc3fcb2e 100644 > --- a/net/sched/cls_api.c > +++ b/net/sched/cls_api.c > @@ -511,6 +511,7 @@ static int tc_ctl_tfilter(struct sk_buff

Re: [PATCH v2 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

2017-05-19 Thread Edward Cree
On 19/05/17 15:55, Alexei Starovoitov wrote: > On 5/19/17 7:21 AM, Edward Cree wrote: >> I'm currently translating the algos to C. But for the kernel patch, >> I'll need to read & understand the existing verifier code, so it >> might take a while :) (I don't suppose there's any design document

[PATCH net] fix BUG: scheduling while atomic in netlink broadcast

2017-05-19 Thread Akshay Narayan
netlink_broadcast_filtered() calls yield() when a slow listener causes the buffer to fill. yield() is the wrong choice here, as pointed out by Commit 8e3fabfde4 (sched: Update yield() docs); in some cases, its use causes "BUG: scheduling while atomic" and, when fewer cores are available, kernel

Re: [PATCH net] bridge: fix hello and hold timers starting/stopping

2017-05-19 Thread Xin Long
On Sat, May 20, 2017 at 12:25 AM, Ivan Vecera wrote: [...] > @@ -197,13 +191,14 @@ static void br_stp_stop(struct net_bridge *br) > br_err(br, "failed to stop userspace STP (%d)\n", > err); > > /* To start timers on any ports left in blocking

Re: [PATCH net-next v2] bridge: fix hello and hold timers starting/stopping

2017-05-19 Thread Xin Long
On Sat, May 20, 2017 at 1:30 AM, Ivan Vecera wrote: > Current bridge code incorrectly handles starting/stopping of hello and > hold timers during STP enable/disable. > > 1. Timers are stopped in br_stp_start() during NO_STP->USER_STP >transition. The timers are already stopped

[PATCH net] bonding: fix randomly populated arp target array

2017-05-19 Thread Jarod Wilson
In commit dc9c4d0fe023, the arp_target array moved from a static global to a local variable. By the nature of static globals, the array used to be initialized to all 0. At present, it's full of random data, which that gets interpreted as arp_target values, when none have actually been specified.

Re: [PATCH net] fix BUG: scheduling while atomic in netlink broadcast

2017-05-19 Thread Akshay Narayan
> I don't want to defend the use of yield() but it looks like there is other > problem. I believe this use of yield() should be replaced with cond_resched() even if it turns out there is an unrelated problem. > Does this module call netlink_broadcast() with __GFP_DIRECT_RECLAIM > in IRQ context?

Re: Alignment in BPF verifier

2017-05-19 Thread David Miller
From: Edward Cree Date: Fri, 19 May 2017 21:00:13 +0100 > Here's what I'm thinking of doing: > struct bpf_reg_state { > enum bpf_reg_type type; > union { > /* valid when type == PTR_TO_PACKET */ > u16 range; > > /* valid when type ==

[PATCH net-next 01/20] net: dsa: change scope of STP state setter

2017-05-19 Thread Vivien Didelot
Instead of having multiple STP state helpers scoping a slave device supporting both the DSA logic and the switchdev binding, provide a single dsa_port_set_state helper scoping a DSA port, as well as its dsa_port_set_state_now wrapper which skips the prepare phase. This allows us to better

[PATCH net-next 00/20] net: dsa: distribute switch events

2017-05-19 Thread Vivien Didelot
DSA is by nature the support for a switch fabric, which can be composed of a single, or multiple interconnected Ethernet switch chips. The current DSA core behavior is to identify the slave port targeted by a request (e.g. adding a VLAN entry), and program the switch chip to which it belongs

[PATCH net-next 10/20] net: dsa: move bridging routines

2017-05-19 Thread Vivien Didelot
Move the DSA port code which bridges a port in port.c, where it belongs. Signed-off-by: Vivien Didelot --- net/dsa/dsa_priv.h | 2 ++ net/dsa/port.c | 58 ++ net/dsa/slave.c| 57

[PATCH net-next 04/20] net: dsa: change scope of FDB handlers

2017-05-19 Thread Vivien Didelot
Change the scope of the switchdev FDB object handlers from the DSA slave device to the generic DSA port, so that the future port-wide API can also be used for other port types, such as CPU and DSA links. Signed-off-by: Vivien Didelot --- net/dsa/slave.c | 50

[PATCH net-next 07/20] net: dsa: change scope of VLAN filtering setter

2017-05-19 Thread Vivien Didelot
Change the scope of the switchdev VLAN filtering attribute setter from the DSA slave device to the generic DSA port, so that the future port-wide API can also be used for other port types, such as CPU and DSA links. Signed-off-by: Vivien Didelot ---

[PATCH net-next 13/20] net: dsa: move FDB handlers

2017-05-19 Thread Vivien Didelot
Move the DSA port code which handles FDB objects in port.c, where it belongs. Signed-off-by: Vivien Didelot --- net/dsa/dsa_priv.h | 7 +++ net/dsa/port.c | 40 net/dsa/slave.c| 42

[PATCH net-next 14/20] net: dsa: move MDB handlers

2017-05-19 Thread Vivien Didelot
Move the DSA port code which handles MDB objects in port.c, where it belongs. Signed-off-by: Vivien Didelot --- net/dsa/dsa_priv.h | 7 +++ net/dsa/port.c | 40 net/dsa/slave.c| 41

[PATCH net-next 12/20] net: dsa: move ageing time setter

2017-05-19 Thread Vivien Didelot
Move the DSA port code which sets a port ageing time in port.c, where it belongs. Signed-off-by: Vivien Didelot --- net/dsa/dsa_priv.h | 2 ++ net/dsa/port.c | 40 net/dsa/slave.c| 40

[PATCH net-next 06/20] net: dsa: change scope of VLAN handlers

2017-05-19 Thread Vivien Didelot
Change the scope of the switchdev VLAN object handlers from the DSA slave device to the generic DSA port, so that the future port-wide API can also be used for other port types, such as CPU and DSA links. Signed-off-by: Vivien Didelot --- net/dsa/slave.c |

[PATCH net-next 03/20] net: dsa: change scope of bridging code

2017-05-19 Thread Vivien Didelot
Now that the bridge join and leave functions only deal with a DSA port, change their scope from the DSA slave net_device to the DSA generic dsa_port. Signed-off-by: Vivien Didelot --- net/dsa/slave.c | 36 +--- 1 file changed,

Re: [PATCH v5 15/17] dt-bindings: qca7000: append UART interface to binding

2017-05-19 Thread Rob Herring
On Fri, May 19, 2017 at 2:13 AM, Stefan Wahren wrote: > Hi Rob, > > Am 12.05.2017 um 08:43 schrieb Jakub Kicinski: >> On Fri, 12 May 2017 06:15:52 +, Michael Heimpold wrote: >>> Hi, >>> >>> Zitat von Jakub Kicinski : >>> On Thu, 11 May 2017

Re: [PATCH v2 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

2017-05-19 Thread Edward Cree
On 19/05/17 02:22, Alexei Starovoitov wrote: > In your .py I'd only change __str__(self) to print them in mask,value > as the order they're passed into constructor to make it easier to read. Actually I was going to go the other way and change the ctor to take value,mask. But I agree they're

Re: [PATCH net] bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-05-19 Thread Nikolay Aleksandrov
On 5/19/17 5:20 PM, Xin Long wrote: Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop kernel hello and hold timers"), bridge would not start hello_timer if stp_enabled is not KERNEL_STP when br_dev_open. The problem is even if users set stp_enabled with KERNEL_STP later,

Re: [PATCH net-next] tcp: warn on negative reordering values

2017-05-19 Thread David Miller
From: Soheil Hassas Yeganeh Date: Tue, 16 May 2017 17:39:02 -0400 > From: Soheil Hassas Yeganeh > > Commit bafbb9c73241 ("tcp: eliminate negative reordering > in tcp_clean_rtx_queue") fixes an issue for negative > reordering metrics. > > To be

Re: [PATCH net] fix BUG: scheduling while atomic in netlink broadcast

2017-05-19 Thread Cong Wang
On Fri, May 19, 2017 at 11:47 AM, Akshay Narayan wrote: >> I don't want to defend the use of yield() but it looks like there is other >> problem. > > I believe this use of yield() should be replaced with cond_resched() > even if it turns out there is an unrelated problem. Yeah,

[PATCH net-next 20/20] net: dsa: add VLAN notifier

2017-05-19 Thread Vivien Didelot
Add two new DSA_NOTIFIER_VLAN_ADD and DSA_NOTIFIER_VLAN_DEL events to notify not only a single switch, but all switches of a the fabric when an VLAN entry is added or removed. For the moment, keep the current behavior and ignore other switches. Signed-off-by: Vivien Didelot

[PATCH net-next 05/20] net: dsa: change scope of MDB handlers

2017-05-19 Thread Vivien Didelot
Change the scope of the switchdev MDB object handlers from the DSA slave device to the generic DSA port, so that the future port-wide API can also be used for other port types, such as CPU and DSA links. Signed-off-by: Vivien Didelot --- net/dsa/slave.c | 41

[PATCH net-next 11/20] net: dsa: move VLAN filtering setter

2017-05-19 Thread Vivien Didelot
Move the DSA port code which sets VLAN filtering on a port in port.c, where it belongs. Signed-off-by: Vivien Didelot --- net/dsa/dsa_priv.h | 2 ++ net/dsa/port.c | 16 net/dsa/slave.c| 16 3 files changed, 18

[PATCH net-next 08/20] net: dsa: change scope of ageing time setter

2017-05-19 Thread Vivien Didelot
Change the scope of the switchdev bridge ageing time attribute setter from the DSA slave device to the generic DSA port, so that the future port-wide API can also be used for other port types, such as CPU and DSA links. Also ds->ports is now a contiguous array of dsa_port structures, thus their

[PATCH net-next 02/20] net: dsa: change scope of notifier call chain

2017-05-19 Thread Vivien Didelot
Change the scope of the fabric notification helper from the DSA slave to the DSA port, since this is a DSA layer specific notion, that can be used by non-slave ports (CPU and DSA). Signed-off-by: Vivien Didelot --- net/dsa/slave.c | 9 - 1 file

[PATCH net-next 19/20] net: dsa: add MDB notifier

2017-05-19 Thread Vivien Didelot
Add two new DSA_NOTIFIER_MDB_ADD and DSA_NOTIFIER_MDB_DEL events to notify not only a single switch, but all switches of a the fabric when an MDB entry is added or removed. For the moment, keep the current behavior and ignore other switches. Signed-off-by: Vivien Didelot

[PATCH net-next 16/20] net: dsa: move notifier info to private header

2017-05-19 Thread Vivien Didelot
The DSA notifier events and info structure definitions are not meant for DSA drivers and users, but only used internally by the DSA core files. Move them from the public net/dsa.h file to the private dsa_priv.h file. Also use this opportunity to turn the events into an anonymous enum, because we

[PATCH net-next 17/20] net: dsa: add notifier for ageing time

2017-05-19 Thread Vivien Didelot
This patch keeps the port-wide ageing time handling code in dsa_port_ageing_time, pushes the requested ageing time value in a new switch fabric notification, and moves the switch-wide ageing time handling code in dsa_switch_ageing_time. This has the effect that now not only the switch that the

[PATCH net-next 15/20] net: dsa: move VLAN handlers

2017-05-19 Thread Vivien Didelot
Move the DSA port code which handles VLAN objects in port.c, where it belongs. Signed-off-by: Vivien Didelot --- net/dsa/dsa_priv.h | 8 net/dsa/port.c | 41 + net/dsa/slave.c| 41

[PATCH net-next 09/20] net: dsa: move port state setters

2017-05-19 Thread Vivien Didelot
Add a new port.c file to hold all DSA port-wide logic. This patch moves in the code which sets a port state. Signed-off-by: Vivien Didelot --- net/dsa/Makefile | 2 +- net/dsa/dsa_priv.h | 5 + net/dsa/port.c | 55

[PATCH net-next 18/20] net: dsa: add FDB notifier

2017-05-19 Thread Vivien Didelot
Add two new DSA_NOTIFIER_FDB_ADD and DSA_NOTIFIER_FDB_DEL events to notify not only a single switch, but all switches of a the fabric when an FDB entry is added or removed. For the moment, keep the current behavior and ignore other switches. Signed-off-by: Vivien Didelot

RE: [PATCH v2] e1000e: Don't return uninitialized stats

2017-05-19 Thread Brown, Aaron F
> From: Kirsher, Jeffrey T > Sent: Friday, May 19, 2017 1:17 AM > To: David Miller ; bpoir...@suse.com > Cc: s.pri...@profihost.ag; intel-wired-...@lists.osuosl.org; > netdev@vger.kernel.org; pmen...@molgen.mpg.de; Neftin, Sasha > ; Brown, Aaron F

Re: [PATCH net] bonding: fix accounting of active ports in 3ad

2017-05-19 Thread David Miller
From: Jarod Wilson Date: Wed, 17 May 2017 11:11:44 -0400 > As of 7bb11dc9f59d and 0622cab0341c, bond slaves in a 3ad bond are not > removed from the aggregator when they are down, and the active slave count > is NOT equal to number of ports in the aggregator, but rather the

[PATCH net] ipv6: fix out of bound writes in __ip6_append_data()

2017-05-19 Thread Eric Dumazet
From: Eric Dumazet Andrey Konovalov and idaif...@gmail.com reported crashes caused by one skb shared_info being overwritten from __ip6_append_data() Andrey program lead to following state : copy -4200 datalen 2000 fraglen 2040 maxfraglen 2040 alloclen 2048 transhdrlen 0

Re: [PATCH v2 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

2017-05-19 Thread Alexei Starovoitov
On 5/19/17 1:41 PM, David Miller wrote: From: Edward Cree Date: Fri, 19 May 2017 18:17:42 +0100 One question: is there a way to build the verifier as userland code (or at least as a module), or will I have to reboot every time I want to test a change? There currently

Re: [PATCH v2] hdlcdrv: fix divide error bug if bitrate is 0

2017-05-19 Thread David Miller
From: Firo Yang Date: Fri, 19 May 2017 21:21:46 +0800 > @@ -576,6 +576,10 @@ static int hdlcdrv_ioctl(struct net_device *dev, struct > ifreq *ifr, int cmd) > case HDLCDRVCTL_CALIBRATE: > if(!capable(CAP_SYS_RAWIO)) > return -EPERM; > +

Darlehen angebot 3 %

2017-05-19 Thread Frau SCHMIDT
Sehr geehrte Damen und Herren, Haben Sie Interesse über einer finanziellen Darlehen zu 3%? kontaktieren Sie mich für mehr Details und Bedingungen. ich kann all jenen helfen, wer ein Darlehen benötigen. Ich kann Ihnen biete ein darlehen in hohe von 10.000.000 EUR Meine mail:

Re: [PATCH v6 net-next 0/7] Extend socket timestamping API

2017-05-19 Thread Richard Cochran
On Fri, May 19, 2017 at 05:52:34PM +0200, Miroslav Lichvar wrote: > Changes v5->v6: > - fixed skb_is_swtx_tstamp() when OPT_TX_SWHW is disabled and improved > its description > - improved OPT_PKTINFO documentation > - improved scm_timestamping documentation For the series: Acked-by: Richard

[PATCH 1/4] [next-queue]net: mqprio: Introduce new hardware offload mode in mqprio for offloading full TC configurations

2017-05-19 Thread Amritha Nambiar
This patch introduces a new hardware offload mode in mqprio which makes full use of the mqprio options, the TCs, the queue configurations and the bandwidth rates for the TCs. This is achieved by setting the value 2 for the "hw" option. This new offload mode supports new attributes for traffic

[PATCH 0/4] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

2017-05-19 Thread Amritha Nambiar
The following series introduces a new harware offload mode in tc/mqprio where the TCs, the queue configurations and bandwidth rate limits are offloaded to the hardware. The i40e driver enables the new mqprio hardware offload mechanism factoring the TCs, queue configuration and bandwidth rates

Re: [PATCH net] bonding: fix randomly populated arp target array

2017-05-19 Thread महेश बंडेवार
On Fri, May 19, 2017 at 11:46 AM, Jarod Wilson wrote: > In commit dc9c4d0fe023, the arp_target array moved from a static global > to a local variable. By the nature of static globals, the array used to > be initialized to all 0. At present, it's full of random data, which > that

Re: [PATCH net] fix BUG: scheduling while atomic in netlink broadcast

2017-05-19 Thread Eric Dumazet
On Fri, 2017-05-19 at 14:47 -0400, Akshay Narayan wrote: > > I don't want to defend the use of yield() but it looks like there is other > > problem. > > I believe this use of yield() should be replaced with cond_resched() > even if it turns out there is an unrelated problem. > > > Does this

Alignment in BPF verifier

2017-05-19 Thread Edward Cree
Well, I've managed to get somewhat confused by reg->id. In particular, I'm unsure which bpf_reg_types can have an id, and what exactly it means. There seems to be some code that checks around map value pointers, which seems strange as maps have fixed sizes (and the comments in enum

Re: [PATCH net-next v2] bridge: fix hello and hold timers starting/stopping

2017-05-19 Thread Nikolay Aleksandrov
On 5/19/17 8:30 PM, Ivan Vecera wrote: Current bridge code incorrectly handles starting/stopping of hello and hold timers during STP enable/disable. 1. Timers are stopped in br_stp_start() during NO_STP->USER_STP transition. The timers are already stopped in NO_STP state so this is

[PATCH 3/4] [next-queue]net: i40e: Enable mqprio full offload mode in the i40e driver for configuring TCs and queue mapping

2017-05-19 Thread Amritha Nambiar
The i40e driver is modified to enable the new mqprio hardware offload mode and factor the TCs and queue configuration by creating channel VSIs. In this mode, the priority to traffic class mapping and the user specified queue ranges are used to configure the traffic classes when the 'hw' option is

[PATCH 2/4] [next-queue]net: i40e: Add infrastructure for queue channel support with the TCs and queue configurations offloaded via mqprio scheduler

2017-05-19 Thread Amritha Nambiar
This patch sets up the infrastructure for offloading TCs and queue configurations to the hardware by creating HW channels(VSI). A new channel is created for each of the traffic class configuration offloaded via mqprio framework except for the first TC (TC0). TC0 for the main VSI is also

[PATCH 4/4] [next-queue]net: i40e: Add support to set max bandwidth rates for TCs offloaded via tc/mqprio

2017-05-19 Thread Amritha Nambiar
This patch enables setting up maximum Tx rates for the traffic classes in i40e. The maximum rate offloaded to the hardware through the mqprio framework is configured for the VSI. Configuring minimum Tx rate limit is not supported in the device. The minimum usable value for Tx rate is 50Mbps.

Re: [PATCH net] bonding: fix randomly populated arp target array

2017-05-19 Thread Andy Gospodarek
On Fri, May 19, 2017 at 02:46:46PM -0400, Jarod Wilson wrote: > In commit dc9c4d0fe023, the arp_target array moved from a static global > to a local variable. By the nature of static globals, the array used to > be initialized to all 0. At present, it's full of random data, which > that gets

Re: Alignment in BPF verifier

2017-05-19 Thread David Miller
From: Edward Cree Date: Fri, 19 May 2017 21:00:13 +0100 > Well, I've managed to get somewhat confused by reg->id. > In particular, I'm unsure which bpf_reg_types can have an id, and what > exactly it means. There seems to be some code that checks around map value >

Re: [PATCH v2 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

2017-05-19 Thread David Miller
From: Edward Cree Date: Fri, 19 May 2017 18:17:42 +0100 > One question: is there a way to build the verifier as userland code > (or at least as a module), or will I have to reboot every time I > want to test a change? There currently is no such machanism, you will have

Re: [PATCH net-next V5 0/9] vhost_net rx batch dequeuing

2017-05-19 Thread Jason Wang
On 2017年05月18日 04:59, Michael S. Tsirkin wrote: On Wed, May 17, 2017 at 12:14:36PM +0800, Jason Wang wrote: This series tries to implement rx batching for vhost-net. This is done by batching the dequeuing from skb_array which was exported by underlayer socket and pass the sbk back through

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

2017-05-19 Thread Arnd Bergmann
On Fri, May 19, 2017 at 7:18 AM, Kalle Valo wrote: > Arnd Bergmann writes: > >> I've managed to split up my long patch into a series of reasonble >> steps now. >> >> The first two are required to fix a regression from commit 41977e86c984 >> ("rt2x00: add

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

2017-05-19 Thread Arnd Bergmann
On Fri, May 19, 2017 at 8:44 AM, Tom Psyborg wrote: > warning: 'rt2800_bbp_read' used but never defined > static u8 rt2800_bbp_read(struct rt2x00_dev *rt2x00dev, >^ >

[PATCH 1/4] net-next: stmmac: Convert new_state to bool

2017-05-19 Thread Corentin Labbe
This patch convert new_state from int to bool since it store only 1 or 0 Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

2017-05-19 Thread Vlad Yasevich
On 05/18/2017 10:13 PM, Toshiaki Makita wrote: > On 2017/05/18 22:31, Vladislav Yasevich wrote: >> It appears that since commit 8cb65d000, Q-in-Q vlans have been >> broken. The series that commit is part of enabled TSO and checksum >> offloading on Q-in-Q vlans. However, most HW we support can't

Re: mwifiex: add missing USB-descriptor endianness conversion

2017-05-19 Thread Kalle Valo
Johan Hovold wrote: > Add the missing endianness conversions to a debug statement printing > the USB device-descriptor bcdUSB field during probe. > > Signed-off-by: Johan Hovold Patch applied to wireless-drivers-next.git, thanks. a1ad7198202f mwifiex: add

[PATCH net-next 03/13] nfp: rename netdev/port to vNIC

2017-05-19 Thread Jakub Kicinski
vNIC is a PCIe-side abstraction NFP firmwares supported by this driver use. It was initially meant to represent a device port and therefore a netdev but today should be thought of as a way of grouping descriptor rings and associated state. Advanced apps will have vNICs without netdevs and ports

[PATCH net-next 05/13] nfp: introduce very minimal nfp_app

2017-05-19 Thread Jakub Kicinski
Introduce a concept of an application. For now it's just grouping pointers and serving as a layer of indirection. It will help us weaken the dependency on nfp_net in ethtool code. Later series will flesh out support for different apps in the driver. Signed-off-by: Jakub Kicinski

[PATCH net-next 06/13] nfp: disallow mixing vNICs with and without NSP port entry

2017-05-19 Thread Jakub Kicinski
We only support core NIC apps which have vNICs for each physical port/ split and no representors right now. Enforce that either each vNIC has a NSP eth_table entry or if NSP port table is not available none do. One scenario this will prevent from happening is user force-loading wrong firmware

[PATCH net-next 08/13] nfp: update port state in place

2017-05-19 Thread Jakub Kicinski
Always updating port state in place by overriding values in exiting pf->eth_tbl makes things easier to manage and allows us to have a common helper for both full and per-port refresh. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman

[PATCH net-next 01/13] nfp: add nfp_cppcore_pcie_unit() helper

2017-05-19 Thread Jakub Kicinski
From: Simon Horman Add nfp_cppcore_pcie_unit() helper to retrieve the PCIE unit of a CPP handle and use the new helper as appropriate. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski ---

[PATCH net-next 02/13] nfp: make nfp_net alloc/init/cleanup/free not depend on netdevs

2017-05-19 Thread Jakub Kicinski
struct nfp_net represents a vNIC, we will be moving away from the requirement for every vNIC to have a netdev associated with it. Remove "netdev" from some function names and prefer passing struct nfp_net pointer as argument instead of struct net_device *. Signed-off-by: Jakub Kicinski

[PATCH net-next 07/13] nfp: introduce nfp_port

2017-05-19 Thread Jakub Kicinski
Encapsulate port information into struct nfp_port. nfp_port will soon be extended to contain devlink_port information. It also makes it easier to reuse port-related code between vNICs and representors. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman

[PATCH net-next 13/13] nfp: refresh port state before reporting autonegotiation

2017-05-19 Thread Jakub Kicinski
State of autonegotiation may have changed but is not yet refreshed. Make sure ethtool respects the NFP_PORT_CHANGED flag when looking at autoneg. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman ---

[PATCH net-next 09/13] nfp: move refresh tracking into the port structure

2017-05-19 Thread Jakub Kicinski
Track whether physical port's state have changed since last refresh inside the nfp_port structure instead of the vNIC structure. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_net.h

[PATCH net-next 10/13] nfp: provide linking on port structures

2017-05-19 Thread Jakub Kicinski
Add link to nfp_ports to make it possible to iterate over all ports. This will come in handy when some ports may be representors. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_main.c

[PATCH net-next 04/13] nfp: add nfp_net_pf_free_vnic() function

2017-05-19 Thread Jakub Kicinski
Soon a third place will need to free a struct nfp_net. Add a free counterpart to nfp_net_pf_alloc_vnic(). Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_net_main.c | 16

[PATCH net-next 11/13] nfp: mark port state as stale after reconfig

2017-05-19 Thread Jakub Kicinski
After port configuration is performed mark it as changed. This will close a window of time between configuration and async state refresh which runs from a workqueue where old port state would be reported. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman

[PATCH net-next 12/13] nfp: mark port state as stale if update failed

2017-05-19 Thread Jakub Kicinski
If reading new state of the port failed, mark the port back as CHANGED. This way next user state request will trigger refresh, which will hopefully succeed. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman ---

[PATCH net-next 00/13] nfp: introduce nfp_port and nfp_app

2017-05-19 Thread Jakub Kicinski
Hi! This series builds foundation for upcoming development. So far the nfp driver was focused on delivering basic NIC-like functionality. We want to switch gears a bit going forward and support more advanced applications. First few patches are naming clean ups and reshuffling. The two main

Re: [PATCH net] bonding: fix randomly populated arp target array

2017-05-19 Thread Jarod Wilson
On 2017-05-19 4:38 PM, Mahesh Bandewar (महेश बंडेवार) wrote: On Fri, May 19, 2017 at 11:46 AM, Jarod Wilson wrote: In commit dc9c4d0fe023, the arp_target array moved from a static global to a local variable. By the nature of static globals, the array used to be initialized to

Re: [PATCH net] bonding: fix accounting of active ports in 3ad

2017-05-19 Thread Jarod Wilson
On 2017-05-19 5:14 PM, David Miller wrote: From: Jarod Wilson Date: Wed, 17 May 2017 11:11:44 -0400 As of 7bb11dc9f59d and 0622cab0341c, bond slaves in a 3ad bond are not removed from the aggregator when they are down, and the active slave count is NOT equal to number of

Re: [Intel-wired-lan] [PATCH 0/4] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

2017-05-19 Thread John Fastabend
On 05/19/2017 05:58 PM, Amritha Nambiar wrote: > The following series introduces a new harware offload mode in > tc/mqprio where the TCs, the queue configurations and bandwidth rate > limits are offloaded to the hardware. The i40e driver enables the new > mqprio hardware offload mechanism

[PATCH net-next] macsec: double accounting of dropped rx/tx packets

2017-05-19 Thread Girish Moodalbail
The macsec implementation shouldn't account for rx/tx packets that are dropped in the netdev framework. The netdev framework itself accounts for such packets by atomically updating struct net_device`rx_dropped and struct net_device`tx_dropped fields. Later on when the stats for macsec link is

Hiking Enthusiasts

2017-05-19 Thread Patrick Grimes
Hi, Would you be interested in acquiring an email list of "Hiking Enthusiasts List" from USA? We also have data for Sports Enthusiasts List, Scuba Divers List, Fishing Enthusiasts List, Outdoor and Camping Enthusiasts, Running Enthusiasts List, Boxing Enthusiasts List, Cycling Enthusiasts

[PATCH 2/4] net-next: stmmac: Remove unnecessary parenthesis

2017-05-19 Thread Corentin Labbe
Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index

[PATCH 0/4] net-next: stmmac: rework the speed selection

2017-05-19 Thread Corentin Labbe
Hello The current stmmac_adjust_link() part which handle speed have some if (has_platform) code and my dwmac-sun8i will add more of them. So we need to handle better speed selection. Moreover the struct link member speed and port are hard to guess their purpose. And their unique usage are to be

[PATCH 4/4] net-next: stmmac: rework the speed selection

2017-05-19 Thread Corentin Labbe
The current stmmac_adjust_link() part which handle speed have some if (has_platform) code and my dwmac-sun8i will add more of them. So we need to handle better speed selection. Moreover the struct link member speed and port are hard to guess their purpose. And their unique usage are to be

[PATCH 3/4] net-next: stmmac: use SPEED_xxx instead of raw value

2017-05-19 Thread Corentin Labbe
Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

2017-05-19 Thread Kalle Valo
Arnd Bergmann writes: > On Fri, May 19, 2017 at 8:44 AM, Tom Psyborg > wrote: >> warning: 'rt2800_bbp_read' used but never defined >> static u8 rt2800_bbp_read(struct rt2x00_dev *rt2x00dev, >>^ >>

Re: [PATCH v5 15/17] dt-bindings: qca7000: append UART interface to binding

2017-05-19 Thread Stefan Wahren
Hi Rob, Am 12.05.2017 um 08:43 schrieb Jakub Kicinski: > On Fri, 12 May 2017 06:15:52 +, Michael Heimpold wrote: >> Hi, >> >> Zitat von Jakub Kicinski : >> >>> On Thu, 11 May 2017 21:12:22 +0200, Michael Heimpold wrote: Am Mittwoch, 10. Mai 2017, 10:53:26 CEST schrieb

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

2017-05-19 Thread Kalle Valo
Arnd Bergmann writes: > On Fri, May 19, 2017 at 7:18 AM, Kalle Valo wrote: >> Arnd Bergmann writes: >> >>> I've managed to split up my long patch into a series of reasonble >>> steps now. >>> >>> The first two are required to fix a regression

Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

2017-05-19 Thread Arnd Bergmann
On Fri, May 19, 2017 at 9:15 AM, Kalle Valo wrote: > Arnd Bergmann writes: > >> On Fri, May 19, 2017 at 7:18 AM, Kalle Valo wrote: >>> Arnd Bergmann writes: >>> I've managed to split up my long patch into a series

[PATCH] e1000e: use disable_hardirq() also for MSIX vectors in e1000_netpoll()

2017-05-19 Thread Konstantin Khlebnikov
Replace disable_irq() which waits for threaded irq handlers with disable_hardirq() which waits only for hardirq part. Signed-off-by: Konstantin Khlebnikov Fixes: 311191297125 ("e1000: use disable_hardirq() for e1000_netpoll()") ---

Re: net: ath: tx99: fixed a spelling issue

2017-05-19 Thread Kalle Valo
ammly wrote: > Fixed a spelling issue. > > Signed-off-by: Ammly Fredrick Patch applied to ath-next branch of ath.git, thanks. c46e2a848f29 ath9k: fix spelling in ath9k_tx99_init() -- https://patchwork.kernel.org/patch/9703211/

Re: ath5k: fix memory leak on buf on failed eeprom read

2017-05-19 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > The AR5K_EEPROM_READ macro returns with -EIO if a read error > occurs causing a memory leak on the allocated buffer buf. Fix > this by explicitly calling ath5k_hw_nvram_read and exiting on > the

Re: wil6210: use memdup_user

2017-05-19 Thread Kalle Valo
Geliang Tang wrote: > Use memdup_user() helper instead of open-coding to simplify the code. > > Signed-off-by: Geliang Tang Patch applied to ath-next branch of ath.git, thanks. 9a49290919e1 wil6210: use memdup_user --

Re: [v2] ath9k: remove unnecessary code

2017-05-19 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > The array field eeprom_data in struct th9k_platform_data > is a fixed size array so it can never be NULL. > > Addresses-Coverity-ID: 1364903 > Cc: Arend Van Spriel > Cc: Kalle Valo >

<    1   2   3   >