Re: [PATCH v3 net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

2017-05-19 Thread Florian Fainelli
On 05/19/2017 03:57 PM, woojung@microchip.com wrote: > From: Woojung Huh > > Adding Microchip 9477 Phy included in KSZ9477 Switch. > > Signed-off-by: Woojung Huh > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 net-next 5/5] dsa: add maintainer of Microchip KSZ switches

2017-05-19 Thread Florian Fainelli
On 05/19/2017 03:57 PM, woojung@microchip.com wrote: > From: Woojung Huh > > Adding maintainer of Microchip KSZ switches. > > Signed-off-by: Woojung Huh > Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli > --- > MAINTAINERS | 10 ++ > 1 file changed, 10 insertions(+) > >

Re: [PATCH v3 net-next 4/5] dsa: Add spi support to Microchip KSZ switches

2017-05-19 Thread Florian Fainelli
On 05/19/2017 03:57 PM, woojung@microchip.com wrote: > From: Woojung Huh > > A sample SPI configuration for Microchip KSZ switches. > > Signed-off-by: Woojung Huh > Reviewed-by: Andrew Lunn Subject should be something like: dt-bindings: net: dsa: Add Microchip KSZ switches binding With

Re: [PATCH v3 net-next 3/5] dsa: add DSA switch driver for Microchip KSZ9477

2017-05-19 Thread Florian Fainelli
On 05/19/2017 03:57 PM, woojung@microchip.com wrote: > From: Woojung Huh > > The KSZ9477 is a fully integrated layer 2, managed, 7 ports GigE switch > with numerous advanced features. 5 ports incorporate 10/100/1000 Mbps PHYs. > The other 2 ports have interfaces that can be configured as SGMI

Re: [PATCH v2 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

2017-05-19 Thread Alexei Starovoitov
On 5/19/17 4:16 PM, David Miller wrote: From: Alexei Starovoitov Date: Fri, 19 May 2017 14:37:56 -0700 On 5/19/17 1:41 PM, David Miller wrote: From: Edward Cree Date: Fri, 19 May 2017 18:17:42 +0100 One question: is there a way to build the verifier as userland code (or at least as a modu

[PATCH] i40e: Fix incorrect pf->flags

2017-05-19 Thread Tushar Dave
Fix bug introduced by 'commit 47994c119a36e ("i40e: remove hw_disabled_flags in favor of using separate flag bits")' that mistakenly wipes out pf->flags. Signed-off-by: Tushar Dave --- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --g

Re: [PATCH net-next] geneve: always fill CSUM6_RX configuration

2017-05-19 Thread Pravin Shelar
On Thu, May 18, 2017 at 12:59 PM, Eric Garver wrote: > CSMU6_RX is relevant for collect_metadata as well. As such leave it > outside of the dev's IPv4/IPv6 checks. > Can you explain it bit? is this flag used with ipv4 tunnels? > Fixes: 9b4437a5b870 ("geneve: Unify LWT and netdev handling.") > Sig

RE: [PATCH v3 net-next 1/5] dsa: add support for Microchip KSZ tail tagging

2017-05-19 Thread Woojung.Huh
>> + if (padlen) { >> + u8 *pad = skb_put(nskb, padlen); >> + >> + memset(pad, 0, padlen); >> + } > >Can you use skb_put_padto() here instead of open coding this? > >> + >> + tag = skb_put(nskb, KSZ_INGRESS_TAG_LEN); >> + tag[0] = 0; >> + tag[1] = 1 << p-

Re: [RFC net-next PATCH 4/5] net: new XDP feature for reading HW rxhash from drivers

2017-05-19 Thread Alexei Starovoitov
On Thu, May 18, 2017 at 05:41:48PM +0200, Jesper Dangaard Brouer wrote: > > +/* XDP rxhash have an associated type, which is related to the RSS > + * (Receive Side Scaling) standard, but NIC HW have different mapping > + * and support. Thus, create mapping that is interesting for XDP. XDP > + *

Re: [RFC net-next PATCH 4/5] net: new XDP feature for reading HW rxhash from drivers

2017-05-19 Thread Jakub Kicinski
On Fri, 19 May 2017 20:07:52 -0700, Alexei Starovoitov wrote: > How about exposing 'struct mlx5_cqe64 *' to XDP programs as-is? > We can make sure that XDP program does read only access into it and > it will see cqe->rss_hash_result, cqe->rss_hash_type and everything else > in there, but this will

Re: [RFC net-next PATCH 4/5] net: new XDP feature for reading HW rxhash from drivers

2017-05-19 Thread Alexei Starovoitov
On Fri, May 19, 2017 at 08:21:47PM -0700, Jakub Kicinski wrote: > On Fri, 19 May 2017 20:07:52 -0700, Alexei Starovoitov wrote: > > How about exposing 'struct mlx5_cqe64 *' to XDP programs as-is? > > We can make sure that XDP program does read only access into it and > > it will see cqe->rss_hash_r

Re: [RFC net-next PATCH 4/5] net: new XDP feature for reading HW rxhash from drivers

2017-05-19 Thread Jakub Kicinski
On Fri, 19 May 2017 20:34:00 -0700, Alexei Starovoitov wrote: > On Fri, May 19, 2017 at 08:21:47PM -0700, Jakub Kicinski wrote: > > On Fri, 19 May 2017 20:07:52 -0700, Alexei Starovoitov wrote: > > > How about exposing 'struct mlx5_cqe64 *' to XDP programs as-is? > > > We can make sure that XDP p

[net-next] net: ipv6: fix code style error and warning of ndisc.c

2017-05-19 Thread yuan linyu
From: yuan linyu Signed-off-by: yuan linyu --- net/ipv6/ndisc.c | 300 --- 1 file changed, 155 insertions(+), 145 deletions(-) diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index d310dc4..5a3dfaa 100644 --- a/net/ipv6/ndisc.c +++ b/net/ipv

[PATCH v2 net-next] net: ipv6: fix code style error and warning of ndisc.c

2017-05-19 Thread yuan linyu
From: yuan linyu Signed-off-by: yuan linyu --- net/ipv6/ndisc.c | 300 --- 1 file changed, 155 insertions(+), 145 deletions(-) diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index d310dc4..5a3dfaa 100644 --- a/net/ipv6/ndisc.c +++ b/net/ipv

Re: [PATCH net-next v2] bridge: fix hello and hold timers starting/stopping

2017-05-19 Thread Hangbin Liu
On Fri, May 19, 2017 at 07:30:43PM +0200, Ivan Vecera wrote: > Current bridge code incorrectly handles starting/stopping of hello and > hold timers during STP enable/disable. > > 1. Timers are stopped in br_stp_start() during NO_STP->USER_STP >transition. The timers are already stopped in NO_S

Re: [PATCH net-next 6/9] xfrm: make xfrm_dev_register static

2017-05-19 Thread Steffen Klassert
On Fri, May 19, 2017 at 09:55:53AM -0700, Stephen Hemminger wrote: > This function is only used in this file and should not be global. > > Signed-off-by: Stephen Hemminger > --- > net/xfrm/xfrm_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/xfrm/xfrm_devic

Re: [PATCH net-next v2] bridge: fix hello and hold timers starting/stopping

2017-05-19 Thread Nikolay Aleksandrov
On 5/20/17 8:57 AM, Hangbin Liu wrote: On Fri, May 19, 2017 at 07:30:43PM +0200, Ivan Vecera wrote: Current bridge code incorrectly handles starting/stopping of hello and hold timers during STP enable/disable. 1. Timers are stopped in br_stp_start() during NO_STP->USER_STP transition. The t

<    1   2   3