[PATCH net-next v1 2/2] net: ndisc.c: minor code improvement

From: yuan linyu on x86_64, text size decrease 64 bytes Signed-off-by: yuan linyu --- net/ipv6/ndisc.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/net/ipv6/ndisc.c

Re: [PATCH net-next 1/2] net: ndisc.c: fix coding style issue

On 五, 2017-05-26 at 22:45 +0900, 吉藤英明 wrote: > Hi, > > 2017-05-26 22:23 GMT+09:00 yuan linyu : > > > > From: yuan linyu > > > > Signed-off-by: yuan linyu > > --- > >  net/ipv6/ndisc.c | 109 > >

Re: [for-next 5/6] net/mlx5: Bump driver version

On 5/23/2017 7:44 AM, Saeed Mahameed wrote: From: Tariq Toukan Remove date and bump version for mlx5_core driver. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed So I just complained about the bnxt_re doing this. I

[PATCH net-next 0/2] ndisc.c minor clean and improvement

From: yuan linyu 1. fix part of checkpatch issue which I like to fix 2. __ndisc_fill_addr_option() clean yuan linyu (2): net: ndisc.c: fix coding style issue net: ndisc.c: minor code improvement net/ipv6/ndisc.c | 139

[PATCH net-next v1 1/2] net: ndisc.c: fix coding style issue

From: yuan linyu Signed-off-by: yuan linyu --- net/ipv6/ndisc.c | 109 --- 1 file changed, 55 insertions(+), 54 deletions(-) diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c

[PATCH net-next v1 0/2] ndisc.c minor clean and improvement

From: yuan linyu 1. fix part of checkpatch issue which I like to fix 2. __ndisc_fill_addr_option() clean v1: correct space value yuan linyu (2): net: ndisc.c: fix coding style issue net: ndisc.c: minor code improvement net/ipv6/ndisc.c | 141

Re: [patch net-next 01/18] bridge: Export VLAN filtering state

Hi Nik, On Fri, May 26, 2017 at 11:55:18AM +0300, Nikolay Aleksandrov wrote: > On 5/26/17 9:37 AM, Jiri Pirko wrote: > > From: Ido Schimmel > > > > It's useful for drivers supporting bridge offload to be able to query > > the bridge's VLAN filtering state. > > > >

[PATCH net-next 1/2] net: ndisc.c: fix coding style issue

From: yuan linyu Signed-off-by: yuan linyu --- net/ipv6/ndisc.c | 109 --- 1 file changed, 55 insertions(+), 54 deletions(-) diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c

Re: [PATCH v3 2/2] dt-bindings: net: Add Cortina device tree bindings

> + cs4340_phy@1 { > + compatible = "ethernet-phy-id13e5.1002"; > + reg = <0x10>; The @1 and the reg value should be the same. Please change it to cs4340_phy@10. Andrew

Re: [PATCH v3 1/2] net: phy: Add Cortina CS4340 driver (fwd)

@vger.kernel.org CC: Hi Bogdan, [auto build test WARNING on net-next/master] [also build test WARNING on v4.12-rc2 next-20170526] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Bogdan-Purcareata/ne

[PATCH v3] hdlcdrv: Fix divide by zero in hdlcdrv_ioctl

syszkaller fuzzer triggered a divide by zero, when set calibration through ioctl(). To fix it, test 'bitrate' if it is negative or 0, just return -EINVAL. Reported-by: Andrey Konovalov Signed-off-by: Firo Yang --- v2->v3: Just fix divide error

Re: [PATCH net-next 1/2] net: ndisc.c: fix coding style issue

Hi, 2017-05-26 22:23 GMT+09:00 yuan linyu : > From: yuan linyu > > Signed-off-by: yuan linyu > --- > net/ipv6/ndisc.c | 109 > --- > 1 file changed, 55

Re: [PATCH net-next 3/4] tls: kernel TLS support

On Wed, 2017-05-24 at 09:27 -0700, Dave Watson wrote: > Software implementation of transport layer security, implemented using ULP > infrastructure. tcp proto_ops are replaced with tls equivalents of sendmsg > and > sendpage. ... > + > +int tls_sw_sendmsg(struct sock *sk, struct msghdr *msg,

RE: [PATCH v3 1/2] net: phy: Add Cortina CS4340 driver (fwd)

> -Original Message- > From: Julia Lawall [mailto:julia.law...@lip6.fr] > Sent: Friday, May 26, 2017 5:32 PM > To: Bogdan Purcareata > Cc: and...@lunn.ch; f.faine...@gmail.com; netdev@vger.kernel.org; > devicet...@vger.kernel.org; linux-ker...@vger.kernel.org;

running an eBPF program

Hi I'm trying to run this eBPF program: https://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git/tree/examples/bpf and I get this error: :~/iproute2/examples/bpf$sudo tc filter add dev enx00e11100329b parent 1: bpf obj bpf.o exp /tmp/bpf-uds flowid 1:1 action bpf obj bpf.o sec

Re: [PATCH v2 net-next 1/3] perf, bpf: Add BPF support to all perf_event types

Hi Teng, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Alexei-Starovoitov/bpf-Add-BPF-support-to-all-perf_event/20170526-171542 config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 6.2.0 reproduce: wget https

[PATCH net-next 2/2] net: ndisc.c: minor code improvement

From: yuan linyu on x86_64, text size decrease 80 bytes Signed-off-by: yuan linyu --- net/ipv6/ndisc.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/net/ipv6/ndisc.c

Re: [for-next 5/6] net/mlx5: Bump driver version

On Fri, May 26, 2017 at 3:56 PM, Dennis Dalessandro wrote: > On 5/23/2017 7:44 AM, Saeed Mahameed wrote: >> >> From: Tariq Toukan >> >> Remove date and bump version for mlx5_core driver. >> >> Signed-off-by: Tariq Toukan >>

Re: [PATCH net] ipv4: add reference counting to metrics

On Fri, May 26, 2017 at 10:13 AM, Eric Dumazet wrote: > On Fri, May 26, 2017 at 10:08 AM, Cong Wang wrote: >> On Thu, May 25, 2017 at 2:27 PM, Eric Dumazet wrote: > >> Just one nit below. >> >>> -const u32

Re: [PATCH net-next 1/2] net: ndisc.c: fix coding style issue

Hi, 2017-05-26 22:55 GMT+09:00 yuan linyu : > On 五, 2017-05-26 at 22:45 +0900, 吉藤英明 wrote: >> Hi, >> >> 2017-05-26 22:23 GMT+09:00 yuan linyu : >> > >> > From: yuan linyu >> > >> > Signed-off-by: yuan linyu

[PATCH net-next 08/11] ibmvnic: Check adapter state during ibmvnic_poll

We do not want to process any receive frames if the ibmvnic_poll routine is invoked while a reset is in process. Also, before replenishing the rx pools in the ibmvnic_poll, we want to make sure the adapter is not in the process of closing. Signed-off-by: Nathan Fontenot

[PATCH net-next 09/11] ibmvnic: Reset the CRQ queue during driver reset

When a driver reset operation occurs there is not a need to release the CRQ resources and re-allocate them. Instead a reset of the CRQ will suffice. Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c | 10 -- 1 file changed, 8

[PATCH net-next 11/11] ibmvnic: Reset sub-crqs during driver reset

When the ibmvnic driver is resetting, we can just reset the sub crqs instead of releasing all of their resources and re-allocting them. Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c | 46 ++-- 1 file changed, 43

[PATCH net-next 10/11] ibmvnic: Reset tx/rx pools on driver reset

When resetting the ibmvnic driver there is not a need to release and re-allocate the resources for the tx and rx pools. These resources can just be reset to avoid the re-allocations. Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c | 71

Re: [PATCH net-next v2 0/6] nfp: devlink port implementation

From: Jiri Pirko Date: Fri, 26 May 2017 10:25:32 +0200 > Fri, May 26, 2017 at 10:03:30AM CEST, jakub.kicin...@netronome.com wrote: >>Hi! >> >>This series adds basic devlink support. The operations we can perform >>are port show and port split/unsplit. >> >>v2: >>Register

Re: [PATCH net] sky2: Do not deadlock on sky2_hw_down

On Thu, 25 May 2017 23:58:30 -0400 (EDT) David Miller wrote: > From: Stephen Hemminger > Date: Thu, 25 May 2017 15:05:02 -0700 > > > Ok, the issue is that lockdep is being stupid and thinking that > > seqcount's behave like locks. > > Well..

[PATCH v2 1/6] stmmac: pci: Make stmmac_pci_info structure constant

By removing the PCI device reference from the structure and passing it as parameters to the interested functions, we can make quark_pci_info const. Signed-off-by: Jan Kiszka --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 23 +++ 1 file

[PATCH v2 5/6] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses

Avoids reimplementation of DMI matching in stmmac_pci_find_phy_addr. Signed-off-by: Jan Kiszka --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 77 ++-- 1 file changed, 45 insertions(+), 32 deletions(-) diff --git

[PATCH v2 4/6] stmmac: pci: Select quark_pci_dmi_data from quark_default_data

No need to carry this reference in stmmac_pci_info - the Quark-specific setup handler knows that it needs to use the Quark-specific DMI table. This also allows to drop the stmmac_pci_info reference from the setup handler parameter list. Signed-off-by: Jan Kiszka ---

[PATCH v2 0/6] stmmac: pci: Refactor DMI probing

Some cleanups of the way we probe DMI platforms in the driver. Reduces a bit of open-coding and makes the logic easier reusable for any potential DMI platform != Quark. Tested on IOT2000 and Galileo Gen2. Changes in v2: - fixed bug that broke x86-64 build (and likely more) - refactored series

[PATCH net-next v3] ibmvnic: Enable TSO support

Enable TSO in the ibmvnic driver. Scatter-gather is also enabled, though there currently is no support for scatter-gather in vNIC-compatible hardware, resulting in forced linearization of all fragmented SKB's. Though not ideal, given the throughput improvement gained by enabling TSO, it has been

[PATCH] tcp: reinitialize MTU probing when setting MSS in a TCP repair

From: Douglas Caetano dos Santos MTU probing initialization occurred only at connect() and at SYN or SYN-ACK reception, but the former sets MSS to either the default or the user set value (through TCP_MAXSEG sockopt) and the latter never happens with repaired sockets.

Re: [PATCH 5/5] MIPS: Add support for eBPF JIT.

On 05/26/2017 02:38 AM, David Daney wrote: Since the eBPF machine has 64-bit registers, we only support this in 64-bit kernels. As of the writing of this commit log test-bpf is showing: test_bpf: Summary: 316 PASSED, 0 FAILED, [308/308 JIT'ed] All current test cases are successfully

Re: [PATCH net-next 3/4] tls: kernel TLS support

From: Eric Dumazet Date: Fri, 26 May 2017 07:16:59 -0700 > On Wed, 2017-05-24 at 09:27 -0700, Dave Watson wrote: >> Software implementation of transport layer security, implemented using ULP >> infrastructure. tcp proto_ops are replaced with tls equivalents of sendmsg

Re: [PATCH 5/5] MIPS: Add support for eBPF JIT.

From: David Daney Date: Thu, 25 May 2017 17:38:26 -0700 > +static int gen_int_prologue(struct jit_ctx *ctx) > +{ > + int stack_adjust = 0; > + int store_offset; > + int locals_size; > + > + if (ctx->flags & EBPF_SAVE_RA) > + /* > +

Re: [PATCH 5/5] MIPS: Add support for eBPF JIT.

On 05/26/2017 08:14 AM, Daniel Borkmann wrote: On 05/26/2017 02:38 AM, David Daney wrote: Since the eBPF machine has 64-bit registers, we only support this in 64-bit kernels. As of the writing of this commit log test-bpf is showing: test_bpf: Summary: 316 PASSED, 0 FAILED, [308/308

[PATCH v2 6/6] stmmac: pci: Remove setup handler indirection via stmmac_pci_info

By now, stmmac_pci_info only contains a single entry. Register this directly with the PCI device table, removing one indirection. Signed-off-by: Jan Kiszka --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 35 +--- 1 file changed, 13

Re: [for-next 5/6] net/mlx5: Bump driver version

On 5/26/2017 12:35 PM, Saeed Mahameed wrote: On Fri, May 26, 2017 at 3:56 PM, Dennis Dalessandro wrote: On 5/23/2017 7:44 AM, Saeed Mahameed wrote: From: Tariq Toukan Remove date and bump version for mlx5_core driver. Signed-off-by: Tariq

Re: [PATCH net] ipv4: add reference counting to metrics

On Thu, May 25, 2017 at 2:27 PM, Eric Dumazet wrote: > From: Eric Dumazet > > Andrey Konovalov reported crashes in ipv4_mtu() > > I could reproduce the issue with KASAN kernels, between > 10.246.7.151 and 10.246.7.152 : > > 1) 20 concurrent netperf -t

[PATCH net-next 07/11] ibmvnic: Deactivate RX pool buffer replenishment on H_CLOSED

From: Thomas Falcon If H_CLOSED is returned, halt RX buffer replenishment activity until firmware sends a notification that the driver can reset. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 21

[PATCH net-next 02/11] ibmvnic: Handle failover after failed init crq

From: John Allen Handle case where phyp sends a failover after failing to send the init crq. Signed-off-by: John Allen --- drivers/net/ethernet/ibm/ibmvnic.c | 11 ++- drivers/net/ethernet/ibm/ibmvnic.h |2 +- 2 files

[PATCH net-next 05/11] ibmvnic: Non-fatal error handling

From: John Allen Handle non-fatal error conditions. The process to do this when resetting the driver is to just do __ibmvnic_close followed by __ibmvnic_open. Signed-off-by: John Allen --- drivers/net/ethernet/ibm/ibmvnic.c | 56

[PATCH net-next 06/11] ibmvnic: Halt TX and report carrier off on H_CLOSED return code

From: Thomas Falcon This patch disables transmissions and reports carrier off if xmit function returns that the hardware TX queue is closed. The driver can then await a signal from firmware to determine the correct reset method. Signed-off-by: Thomas Falcon

[PATCH net-next 01/11] ibmvnic: Track state of adapter napis

From: John Allen Track the state of ibmvnic napis. The driver can get into states where it can be reset when napis are already disabled and attempting to disable them again will cause the driver to hang. Signed-off-by: John Allen

Re: please revert. Was: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

From: Alexei Starovoitov Date: Thu, 25 May 2017 21:40:59 -0700 > On Fri, May 26, 2017 at 12:13:27AM -0400, David Miller wrote: >> From: Alexei Starovoitov >> Date: Thu, 25 May 2017 20:58:32 -0700 >> >> > Dave, please revert this

[PATCH v2 2/6] stmmac: pci: Use stmmac_pci_info for all devices

Make stmmac_default_data compatible with stmmac_pci_info.setup and use an info structure for all devices. This allows to make the probing more regular. Signed-off-by: Jan Kiszka --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 33 +++- 1 file

Re: [PATCH 5/5] MIPS: Add support for eBPF JIT.

On 05/25/2017 07:23 PM, Alexei Starovoitov wrote: On Thu, May 25, 2017 at 05:38:26PM -0700, David Daney wrote: Since the eBPF machine has 64-bit registers, we only support this in 64-bit kernels. As of the writing of this commit log test-bpf is showing: test_bpf: Summary: 316 PASSED, 0

[PATCH v2 3/6] stmmac: pci: Make stmmac_pci_find_phy_addr truly generic

Move the special case for the early Galileo firmware into quark_default_setup. This allows to use stmmac_pci_find_phy_addr for non-quark cases. Signed-off-by: Jan Kiszka --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 19 --- 1 file changed, 12

[PATCH net-next 00/11] ibmvnic: Driver updates

This set of patches implements several updates to the ibmvnic driver to fix issues that have been found in testing. Most of the updates invovle updating queue handling during driver close and reset operations. -Nathan --- John Allen (4): ibmvnic: Track state of adapter napis ibmvnic:

Re: [RFC] skbuff: introduce skb_put_zero()

From: Johannes Berg Date: Fri, 26 May 2017 08:58:49 +0200 > On Thu, 2017-05-25 at 13:01 -0400, David Miller wrote: >> From: Johannes Berg >> Date: Wed, 24 May 2017 09:07:47 +0200 >> >> > From: Johannes Berg >> > 

Re: [PATCH 5/5] MIPS: Add support for eBPF JIT.

On 05/26/2017 05:14 PM, Daniel Borkmann wrote: On 05/26/2017 02:38 AM, David Daney wrote: Since the eBPF machine has 64-bit registers, we only support this in 64-bit kernels. As of the writing of this commit log test-bpf is showing: test_bpf: Summary: 316 PASSED, 0 FAILED, [308/308 JIT'ed]

Re: [Patch net-next] net_sched: only create filter chains for new filters/actions

On Fri, May 26, 2017 at 7:54 AM, David Miller wrote: > And I also didn't find the boolean logic hard to understand at all. > > It is in fact a very common pattern to pass a "create" boolean into > lookup functions, to tell them whether to create a new object on > lookup

Re: [PATCH net] ipv4: add reference counting to metrics

On Fri, May 26, 2017 at 10:08 AM, Cong Wang wrote: > On Thu, May 25, 2017 at 2:27 PM, Eric Dumazet wrote: > Just one nit below. > >> -const u32 dst_default_metrics[RTAX_MAX + 1] = { >> +const struct dst_metrics dst_default_metrics = { >>

Re: [PATCH 5/5] MIPS: Add support for eBPF JIT.

Hi David, [auto build test ERROR on linus/master] [also build test ERROR on v4.12-rc2] [cannot apply to next-20170526] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/David-Daney/MIPS-Implement

Re: [Patch net-next] net_sched: only create filter chains for new filters/actions

From: Jiri Pirko Date: Fri, 26 May 2017 07:53:52 +0200 > Thu, May 25, 2017 at 06:14:56PM CEST, da...@davemloft.net wrote: >>From: Cong Wang >>Date: Tue, 23 May 2017 09:42:37 -0700 >> >>> tcf_chain_get() always creates a new filter chain if not found

Re: [patch net-next] net/sched: let chain_get to figure out the return value

From: Jiri Pirko Date: Fri, 26 May 2017 09:21:29 +0200 > From: Jiri Pirko > > Alhough I believe that this create/nocreate dance is completelly > pointless, at least make it a bit nicer and easier to read. > Push the decision on what error value is returned

Re: [PATCH net-next 3/4] tls: kernel TLS support

On Fri, 2017-05-26 at 11:18 -0400, David Miller wrote: > From: Eric Dumazet > Date: Fri, 26 May 2017 07:16:59 -0700 > > > On Wed, 2017-05-24 at 09:27 -0700, Dave Watson wrote: > >> Software implementation of transport layer security, implemented using ULP > >>

Re: [PATCH] mwifiex: simplify the code around ra_list

On Fri, May 26, 2017 at 09:41:49AM +0800, Shawn Lin wrote: > We don't need to check if the list is empty separately > as we could use list_first_entry_or_null to cover it. > > Signed-off-by: Shawn Lin Looks fine to me. Reviewed-by: Brian Norris

Re: A bug report for Linux TCP congestion control algorithms

On Thu, May 25, 2017 at 11:08 PM, Wei Sun wrote: > > Hi there, > > we find a special case for Linux TCP undo operations where > tp->snd_cwnd could be extremely large (e.g., 4294967294) by two > consecutive cwnd undo operations when using >

[PATCH net-next 04/11] ibmvnic: Fix cleanup of SKB's on driver close

From: Thomas Falcon A race condition occurs when closing the driver. Free'ing of skb's can race between the close routine and ibmvnic_tx_interrupt. To fix this we move the claenup of tx pools during close to after the sub-CRQ interrupts are disabled. Signed-off-by:

[PATCH net-next 03/11] ibmvnic: Send gratuitous arp on reset

From: John Allen Send gratuitous arp after any reset. Signed-off-by: John Allen --- drivers/net/ethernet/ibm/ibmvnic.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c

Re: [PATCH v2 net-next 1/3] perf, bpf: Add BPF support to all perf_event types

From: Alexei Starovoitov Date: Thu, 25 May 2017 22:55:47 -0700 > + if (event->attach_state & PERF_ATTACH_TASK) > + goto err_out; The attach_state member only exists when PERF_EVENTS is enabled.

Re: [PATCH net-next v2 0/6] nfp: devlink port implementation

From: Jakub Kicinski Date: Fri, 26 May 2017 01:03:30 -0700 > This series adds basic devlink support. The operations we can perform > are port show and port split/unsplit. > > v2: > Register devlink first, and then register all the ports. Port {,un}split >

Re: [PATCH net-next] ibmvnic: Enable TSO support

On 05/25/2017 01:49 PM, David Miller wrote: > From: David Miller > Date: Thu, 25 May 2017 14:46:26 -0400 (EDT) > >> From: Thomas Falcon >> Date: Wed, 24 May 2017 21:29:26 -0500 >> >>> The feature is also enabled by a module parameter. >>> This

[PATCH net-next] net: dsa: mv88e6xxx: handle SERDES error appropriately

mv88e6xxx_serdes_power returns an error, so no need to print an error message inside of it. Rather print it in its caller when the error is ignored, which is in the mv88e6xxx_port_disable void function. Catch and return its error in the counterpart mv88e6xxx_port_enable. Fixes: 04aca9938255

Re: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

Hi Woojung, On 05/26/2017 05:43 PM, woojung@microchip.com wrote: > Hi Florian, > >> OK, so here is what is happening: macb_mii_init() calls macb_mii_probe() >> and so by the time we call phy_connect_direct(), we have not called >> register_netdevice() yet, netdev_register_kobject() has not

Re: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

On 05/26/2017 05:20 PM, woojung@microchip.com wrote: >> OK, I am confused now. You are describing what is going on with your >> platform right? Can you describe a bit further here what is happening >> and with which type of interface? Is this with the CPU interface or >> something? > > Yes.

Re: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

On 05/26/2017 04:52 PM, woojung@microchip.com wrote: > Hi Florian, > >>> I knew that it is applied to net-next. >>> However, sysfs_create_link() fails when fixed phy >> (drivers/net/phy/fixed_phy.c) >>> Do you have a chance to test with it? >> >> I did, my main test system (BCM7445 w/

RE: [PATCH] e1000e: use disable_hardirq() also for MSIX vectors in e1000_netpoll()

> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Konstantin Khlebnikov > Sent: Friday, May 19, 2017 12:19 AM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey > T > Cc: Dave Jones

Re: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

On 05/26/2017 06:00 PM, woojung@microchip.com wrote: > Hi Florian, OK, so here is what is happening: macb_mii_init() calls macb_mii_probe() and so by the time we call phy_connect_direct(), we have not called register_netdevice() yet, netdev_register_kobject() has not been

RE: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

> > Yes, that's a very valid point, how about we even do this: > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index f84414b8f2ee..dc666ec13651 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -960,15 +960,21 @@ int

RE: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

Hi Florian, > >> OK, so here is what is happening: macb_mii_init() calls macb_mii_probe() > >> and so by the time we call phy_connect_direct(), we have not called > >> register_netdevice() yet, netdev_register_kobject() has not been called > >> either, and so sysfs_create_link() fails > > I

RE: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

Hi Florian, > OK, so here is what is happening: macb_mii_init() calls macb_mii_probe() > and so by the time we call phy_connect_direct(), we have not called > register_netdevice() yet, netdev_register_kobject() has not been called > either, and so sysfs_create_link() fails I just found same

Re: [PATCH net-next] net: dsa: remove dsa_port_is_bridged

On 05/26/2017 03:12 PM, Vivien Didelot wrote: > The helper is only used once and makes the code more complicated that it > should. Remove it and reorganize the variables so that it fits on 80 > columns. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian

RE: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

> OK, I am confused now. You are describing what is going on with your > platform right? Can you describe a bit further here what is happening > and with which type of interface? Is this with the CPU interface or > something? Yes. It's on our platform. Like your platform, fixed phy is used to

Re: [patch iproute2 v2 repost 1/3] tc_filter: add support for chain index

On 05/27/2017 02:11 AM, Stephen Hemminger wrote: On Fri, 26 May 2017 21:48:05 +0200 Daniel Borkmann wrote: On 05/23/2017 03:40 PM, Jiri Pirko wrote: Mon, May 22, 2017 at 10:33:15PM CEST, step...@networkplumber.org wrote: [...] Applied to net-next branch of iproute2

Re: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

Hi Woojung, On 05/26/2017 04:34 PM, woojung@microchip.com wrote: >> @@ -960,6 +960,15 @@ int phy_attach_direct(struct net_device *dev, struct >> phy_device *phydev, >> >> phydev->attached_dev = dev; >> dev->phydev = phydev; >> +err = sysfs_create_link(>mdio.dev.kobj, >dev.kobj,

RE: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

> @@ -960,6 +960,15 @@ int phy_attach_direct(struct net_device *dev, struct > phy_device *phydev, > > phydev->attached_dev = dev; > dev->phydev = phydev; > + err = sysfs_create_link(>mdio.dev.kobj, >dev.kobj, > + "attached_dev"); > + if (err) > +

RE: [PATCH net-next 1/3] net: phy: Create sysfs reciprocal links for attached_dev/phydev

Hi Florian, > > I knew that it is applied to net-next. > > However, sysfs_create_link() fails when fixed phy > (drivers/net/phy/fixed_phy.c) > > Do you have a chance to test with it? > > I did, my main test system (BCM7445 w/ bcm_sf2) has one normal PHY > driver and 3 fixed PHYs (including one

Re: [patch iproute2 v2 repost 1/3] tc_filter: add support for chain index

On Fri, 26 May 2017 21:48:05 +0200 Daniel Borkmann wrote: > On 05/23/2017 03:40 PM, Jiri Pirko wrote: > > Mon, May 22, 2017 at 10:33:15PM CEST, step...@networkplumber.org wrote: > [...] > >> Applied to net-next branch of iproute2 > > > > Looks like you missed the uapi

Re: [PATCH net-next] net: dsa: b53: remove unused dev argument

On 05/26/2017 03:07 PM, Vivien Didelot wrote: > The port net device passed to b53_fdb_copy is not used. Remove it. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian

[PATCH net-next] net: dsa: remove dsa_port_is_bridged

The helper is only used once and makes the code more complicated that it should. Remove it and reorganize the variables so that it fits on 80 columns. Signed-off-by: Vivien Didelot --- net/dsa/slave.c | 13 - 1 file changed, 4 insertions(+), 9

[PATCH net-next 2/3] net: dsa: mv88e6xxx: rename PHY PPU accessors

Make it clear that mv88e6xxx_phy_ppu_{read,write} are an implementation of the .phy_{read,write} operations, by renaming them with the mv88e6185 prefix, since 88E6185 it is the reference switch model supported in an upstream board (ZII Dev Rev B), which makes use of them. Distinguish the

[PATCH net-next 1/3] net: dsa: mv88e6xxx: provide a PHY setup helper

Similarly to the VTU, PVT and ATU setup, provide a mv88e6xxx_phy_setup helper which wraps mv88e6xxx_ppu_enable, so that no more PPU-related functions are exposed outside of phy.c. Thus make mv88e6xxx_ppu_enable static. Signed-off-by: Vivien Didelot ---

[PATCH net-next] net: dsa: remove dev arg of dsa_register_switch

The current dsa_register_switch function takes a useless struct device pointer argument, which always equals ds->dev. Drivers either call it with ds->dev, or with the same device pointer passed to dsa_switch_alloc, which ends up being assigned to ds->dev. This patch removes the second argument

Re: [PATCH net-next 1/2] net: ndisc.c: fix coding style issue

On 六, 2017-05-27 at 02:25 +0900, 吉藤英明 wrote: > Hi, > > 2017-05-26 22:55 GMT+09:00 yuan linyu : > > > > On 五, 2017-05-26 at 22:45 +0900, 吉藤英明 wrote: > > > > > > Hi, > > > > > > 2017-05-26 22:23 GMT+09:00 yuan linyu : > > > > > > > > > > > > From: yuan linyu

[PATCH net-next 3/3] net: dsa: mv88e6xxx: rename PHY PPU functions

Respect the implicit naming convention used in all register sets specific files, by renaming the mv88e6xxx_ppu_* functions with the mv88e6xxx_phy_* prefix. This is simply a s/xxx_ppu/xxx_phy_ppu/ substitution. Signed-off-by: Vivien Didelot ---

[PATCH net-next 0/3] net: dsa: mv88e6xxx: PHY nitpicks

This patchset isolates more PPU code into phy.c and makes distinction between PHY Registers read and write implementations vs. generic PHY routines. Vivien Didelot (3): net: dsa: mv88e6xxx: provide a PHY setup helper net: dsa: mv88e6xxx: rename PHY PPU accessors net: dsa: mv88e6xxx: rename

[PATCH net-next] net: dsa: b53: remove unused dev argument

The port net device passed to b53_fdb_copy is not used. Remove it. Signed-off-by: Vivien Didelot --- drivers/net/dsa/b53/b53_common.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/dsa/b53/b53_common.c

Re: [for-next 5/6] net/mlx5: Bump driver version

On Fri, 26 May 2017 12:55:22 -0400, Dennis Dalessandro wrote: > >> I realize Dave has already pulled this and I'm not asking for it to be > >> reverted but maybe some discussion will help guide future patch submissions > >> which do this stuff. > >> > > > > Sure, although i don't think we are

[PATCH 6/7] mlx5: Stub out sqs2vport functions

These aren't called if CONFIG_MLX5_EN_ESWITCH_OFFLOADS isn't enabled, so do not build them. Signed-off-by: Jes Sorensen --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 14 ++ drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 -- 2

[PATCH 5/7] mlx5: Stub out create_vport_rx_rule when eswitch_offloads disabled

One more vport related function to disable. Signed-off-by: Jes Sorensen --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 11 --- drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 +- 2 files changed, 9 insertions(+), 4 deletions(-) diff

[PATCH 7/7] mlx5: Do not build eswitch_offloads if CONFIG_MLX5_EN_ESWITCH_OFFLOADS is set

This gets rid of the temporary #ifdef spaghetti and allows the code to compile without offload support enabled. Signed-off-by: Jes Sorensen --- drivers/net/ethernet/mellanox/mlx5/core/Makefile | 4 +++- drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 9

[PATCH net-next] net: ndisc.c: reduce size of __ndisc_fill_addr_option()

From: yuan linyu Signed-off-by: yuan linyu --- net/ipv6/ndisc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index d310dc4..414e929 100644 ---

[PATCH 0/7] mlx5: Make eswitch_offloads a compile option

Hi, This changes the code to allow for eswitch_offloads to be compile time option, reducing the size of the driver module for those who do not need it. The patches do it step by step by introducing stubs and then finally gets rid of all the #ifdefs once the code can compile and link without

[PATCH 3/7] mlx5: Disable {add,del}_offloaded_rule() code if eswitch offloads are disabled

This code will not be called if CONFIG_MLX5_EN_ESWITCH_OFFLOADS is disabled. Signed-off-by: Jes Sorensen --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 17 + .../net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 +- 2 files changed, 18

[PATCH 4/7] mlx5: Stub out eswitch offload vport functions

This code isn't called if CONFIG_MLX5_EN_ESWITCH_OFFLOADS isn't enabled Signed-off-by: Jes Sorensen --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h| 20 +++- .../ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 ++ 2 files changed, 21

[PATCH 1/7] mlx5: Allow support for eswitch offloads to be disabled

This allows users to disable eswitch offloads. Follow-on patches will clean up how the eswitch_offloads code is being called and get rid of all the #ifdefs. Signed-off-by: Jes Sorensen --- drivers/net/ethernet/mellanox/mlx5/core/Kconfig| 10 ++

[PATCH 2/7] mlx5: eswitch vlan functionality is only called if SRIOV_OFFLOADS is set

This allows not compiling this code if eswitch offloads are disabled. Signed-off-by: Jes Sorensen --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 13 + drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 ++ 2 files changed, 15

Re: [PATCH net,v2] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets

From: Peter Dawson Date: Fri, 26 May 2017 06:35:18 +1000 > This fix addresses two problems in the way the DSCP field is formulated > on the encapsulating header of IPv6 tunnels. > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=195661 > > 1) The IPv6 tunneling code

  1   2   >