[PATCH] virtio_net: lower limit on buffer size

2017-06-01 Thread Michael S. Tsirkin
commit d85b758f72b0 "virtio_net: fix support for small rings" was supposed to increase the buffer size for small rings but had an unintentional side effect of decreasing it for large rings. This seems to break some setups - it's not yet clear why, but increasing buffer size back to what it was

Re: [PATCH] virtio_net: lower limit on buffer size

2017-06-01 Thread J. Bruce Fields
On Fri, Jun 02, 2017 at 02:56:04AM +0300, Michael S. Tsirkin wrote: > commit d85b758f72b0 "virtio_net: fix support for small rings" > was supposed to increase the buffer size for small rings > but had an unintentional side effect of decreasing > it for large rings. This seems to break some setups

Re: [PATCH net-next v2 2/2] bpf: Remove the capability check for cgroup skb eBPF program

2017-06-01 Thread Alexei Starovoitov
On Thu, Jun 01, 2017 at 06:55:09PM -0700, Chenbo Feng wrote: > On Thu, Jun 1, 2017 at 4:42 PM, Alexei Starovoitov < > alexei.starovoi...@gmail.com> wrote: > > > On Wed, May 31, 2017 at 06:16:00PM -0700, Chenbo Feng wrote: > > > From: Chenbo Feng > > > > > > Currently loading a

Re: [PATCH 04/12] fs: ceph: CURRENT_TIME with ktime_get_real_ts()

2017-06-01 Thread Yan, Zheng
On Fri, Jun 2, 2017 at 8:57 AM, Deepa Dinamani wrote: > On Thu, Jun 1, 2017 at 5:36 PM, John Stultz wrote: >> On Thu, Jun 1, 2017 at 5:26 PM, Yan, Zheng wrote: >>> On Thu, Jun 1, 2017 at 6:22 PM, Arnd Bergmann

[PATCH net-next 1/4] qed: Correct order of wwnn and wwpn

2017-06-01 Thread Yuval Mintz
Driver reads values via HSI splitting this 8-byte into 2 32-bit values and builds a single u64 field - but it does so by shifting the lower field instead of the higher. Luckily, we still don't use these fields for anything - but we're about to start. Signed-off-by: Yuval Mintz

[PATCH net-next 2/4] qed: Share additional information with qedf

2017-06-01 Thread Yuval Mintz
Share several new tidbits with qedf: - wwpn & wwnn - Absolute pf-id [this one is actually meant for qedi as well] - Number of available CQs While we're at it, now that qedf will be aware of the available CQs we can add some validation on the inputs it provides. Signed-off-by: Yuval Mintz

[PATCH net-next 0/4] qed: Enhance storage APIs

2017-06-01 Thread Yuval Mintz
This series is intended to add additional information and features to the API between qed and its storage protocol drivers [qedi, qedf]. Patch #2 adds some information stored on device such as wwpn & wwnn to allow qedf utilize it; #1 fixes an issue with the reading of those values [which were

Re: [PATCH 04/12] fs: ceph: CURRENT_TIME with ktime_get_real_ts()

2017-06-01 Thread Yan, Zheng
On Thu, Jun 1, 2017 at 6:22 PM, Arnd Bergmann wrote: > On Thu, Jun 1, 2017 at 11:56 AM, Yan, Zheng wrote: >> On Sat, Apr 8, 2017 at 8:57 AM, Deepa Dinamani >> wrote: > >>> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c >>> index

Re: [PATCH 04/12] fs: ceph: CURRENT_TIME with ktime_get_real_ts()

2017-06-01 Thread John Stultz
On Thu, Jun 1, 2017 at 5:26 PM, Yan, Zheng wrote: > On Thu, Jun 1, 2017 at 6:22 PM, Arnd Bergmann wrote: >> On Thu, Jun 1, 2017 at 11:56 AM, Yan, Zheng wrote: >>> On Sat, Apr 8, 2017 at 8:57 AM, Deepa Dinamani >>>

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

2017-06-01 Thread kbuild test robot
Hi Jia-Ju, [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.12-rc3 next-20170601] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jia-Ju-Bai/b43legacy-Fix

[PATCH v3 net-next 1/3] perf, bpf: Add BPF support to all perf_event types

2017-06-01 Thread Alexei Starovoitov
Allow BPF_PROG_TYPE_PERF_EVENT program types to attach to all perf_event types, including HW_CACHE, RAW, and dynamic pmu events. Only tracepoint/kprobe events are treated differently which require BPF_PROG_TYPE_TRACEPOINT/BPF_PROG_TYPE_KPROBE program types accordingly. Also add support for

[PATCH net] net: dsa: Move dsa_switch_{suspend,resume} out of legacy.c

2017-06-01 Thread Florian Fainelli
dsa_switch_suspend() and dsa_switch_resume() are functions that belong in net/dsa/dsa.c and are not part of the legacy platform support code. Fixes: a6a71f19fe5e ("net: dsa: isolate legacy code") Signed-off-by: Florian Fainelli --- net/dsa/dsa.c| 47

Re: [net,V2] vxlan: fix use-after-free on deletion

2017-06-01 Thread Roopa Prabhu
On 6/1/17, 5:24 PM, Mark Bloch wrote: > Adding a vxlan interface to a socket isn't symmetrical, while adding > is done in vxlan_open() the deletion is done in vxlan_dellink(). > This can cause a use-after-free error when we close the vxlan > interface before deleting it. > > We add

Ciao サ

2017-06-01 Thread hi
Ciao Benvenuto al nostro negozio 24.88 euro per gli occhiali da sole di Ray Ban, trasporto libero direttamente alla vostra casa web: rbewpt .com 放飞心情,释放真情,愿我们的心灵像湖水般的晶莹清澈,友情像山泉一样源远流长!

Re: [PATCH iproute2] iproute: extend route get to return matching fib route

2017-06-01 Thread David Ahern
On 6/1/17 10:53 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > Uses newly introduced RTM_GETROUTE flag RTM_F_FIB_MATCH > to return a matching fib route. Introduces 'fibmatch' > keyword to ip route get. ... > > Signed-off-by: Roopa Prabhu

Re: [PATCH 04/12] fs: ceph: CURRENT_TIME with ktime_get_real_ts()

2017-06-01 Thread Deepa Dinamani
On Thu, Jun 1, 2017 at 5:36 PM, John Stultz wrote: > On Thu, Jun 1, 2017 at 5:26 PM, Yan, Zheng wrote: >> On Thu, Jun 1, 2017 at 6:22 PM, Arnd Bergmann wrote: >>> On Thu, Jun 1, 2017 at 11:56 AM, Yan, Zheng wrote:

:::::::::BUSINESS PROPOSAL::::::

2017-06-01 Thread Johnson King & Co
Attn, My name is Johnson King, the principal attorney of my law firm., Johnson King & Co. A deceased client Mr. Henry died in 2010 and left a sum little above US$ 28 million in his account here in Unity Bank Plc. Normally banking procedures requires that the bank declares the account

Re: [PATCH net-next v2 1/2] bpf: Allow CGROUP_SKB eBPF program to access sk_buff

2017-06-01 Thread Alexei Starovoitov
On Wed, May 31, 2017 at 06:15:59PM -0700, Chenbo Feng wrote: > From: Chenbo Feng > > This allows cgroup eBPF program to classify packet based on their > protocol or other detail information. Currently program need > CAP_NET_ADMIN privilege to attach a cgroup eBPF program, and A

Re: [PATCH net-next v2 2/2] bpf: Remove the capability check for cgroup skb eBPF program

2017-06-01 Thread Alexei Starovoitov
On Wed, May 31, 2017 at 06:16:00PM -0700, Chenbo Feng wrote: > From: Chenbo Feng > > Currently loading a cgroup skb eBPF program require a CAP_SYS_ADMIN > capability while attaching the program to a cgroup only requires the > user have CAP_NET_ADMIN privilege. We can escape the

[net,V2] vxlan: fix use-after-free on deletion

2017-06-01 Thread Mark Bloch
Adding a vxlan interface to a socket isn't symmetrical, while adding is done in vxlan_open() the deletion is done in vxlan_dellink(). This can cause a use-after-free error when we close the vxlan interface before deleting it. We add vxlan_vs_del_dev() to match vxlan_vs_add_dev() and call it from

Re: [PATCH 04/12] fs: ceph: CURRENT_TIME with ktime_get_real_ts()

2017-06-01 Thread Yan, Zheng
On Thu, Jun 1, 2017 at 6:22 PM, Arnd Bergmann wrote: > On Thu, Jun 1, 2017 at 11:56 AM, Yan, Zheng wrote: >> On Sat, Apr 8, 2017 at 8:57 AM, Deepa Dinamani >> wrote: > >>> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c >>> index

[PATCH net] net: systemport: Fix missing Wake-on-LAN interrupt for SYSTEMPORT Lite

2017-06-01 Thread Florian Fainelli
On SYSTEMPORT Lite, since we have the main interrupt source in the first cell, the second cell is the Wake-on-LAN interrupt, yet the code was not properly updated to fetch the second cell, and instead looked at the third and non-existing cell for Wake-on-LAN. Fixes: 44a4524c54af ("net:

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

2017-06-01 Thread Jia-Ju Bai
On 06/02/2017 12:11 AM, Jonathan Corbet wrote: On Thu, 01 Jun 2017 09:05:07 +0800 Jia-Ju Bai wrote: I admit my patches are not well tested, and they may not well fix the bugs. I am looking forward to opinions and suggestions :) May I politely suggest that sending out

[PATCH v3 net-next 3/3] bpf: update perf event helper functions documentation

2017-06-01 Thread Alexei Starovoitov
From: Teng Qin This commit updates documentation of the bpf_perf_event_output and bpf_perf_event_read helpers to match their implementation. Signed-off-by: Teng Qin Signed-off-by: Alexei Starovoitov --- include/uapi/linux/bpf.h | 11

[PATCH v3 net-next 0/3] bpf: Add BPF support to all perf_event

2017-06-01 Thread Alexei Starovoitov
v2->v3: more refactoring to address Peter's feedback. Now all perf_events are attachable and readable v1->v2: address Peter's feedback. Refactor patch 1 to allow attaching bpf programs to all event types and reading counters from all of them as well patch 2 - more tests patch 3 - address Dave's

[PATCH v3 net-next 2/3] samples/bpf: add tests for more perf event types

2017-06-01 Thread Alexei Starovoitov
From: Teng Qin $ trace_event tests attaching BPF program to HW_CPU_CYCLES, SW_CPU_CLOCK, HW_CACHE_L1D and other events. It runs 'dd' in the background while bpf program collects user and kernel stack trace on counter overflow. User space expects to see sys_read and sys_write in

[PATCH iproute2] iproute: extend route get to return matching fib route

2017-06-01 Thread Roopa Prabhu
From: Roopa Prabhu Uses newly introduced RTM_GETROUTE flag RTM_F_FIB_MATCH to return a matching fib route. Introduces 'fibmatch' keyword to ip route get. ipv4: $ip route show default via 192.168.0.2 dev eth0 10.0.14.0/24 nexthop via 172.16.0.3 dev dummy0

[PATCH net] ip6_tunnel: fix traffic class routing for tunnels

2017-06-01 Thread Liam McBirnie
From: Liam McBirnie Date: Thu, 1 Jun 2017 15:36:01 +1000 Subject: [PATCH net] ip6_tunnel: fix traffic class routing for tunnels ip6_route_output() requires that the flowlabel contains the traffic class for policy routing. Commit 0e9a709560db ("ip6_tunnel, ip6_gre: fix

Re: [PATCH net] netlink: don't send unknown nsid

2017-06-01 Thread Flavio Leitner
On Thu, Jun 01, 2017 at 10:42:13PM +0200, Nicolas Dichtel wrote: > Le 01/06/2017 à 19:02, Flavio Leitner a écrit : > > On Thu, Jun 01, 2017 at 10:00:07AM +0200, Nicolas Dichtel wrote: > >> The NETLINK_F_LISTEN_ALL_NSID otion enables to listen all netns that have a > >> nsid assigned into the netns

Re: [pull request][for-next 0/6] Mellanox mlx5 updates 2017-05-23

2017-06-01 Thread Doug Ledford
On Thu, 2017-05-25 at 12:02 -0400, David Miller wrote: > From: Saeed Mahameed > Date: Tue, 23 May 2017 14:43:58 +0300 > > > Hi Dave and Doug, > >  > > This series introduces some small updates and FPGA support to the > mlx5 > > core/ethernet and IB drivers. > >  > > For more

Re: [PATCH net-next 2/3] udp: avoid a cache miss on dequeue

2017-06-01 Thread Eric Dumazet
On Thu, 2017-06-01 at 22:35 +0200, Paolo Abeni wrote: > To make the code robust we would have to NULL all the other fields > (nfct, nf_bridge, destructor, sk) that are currently not cleared in > skb_release_head_state(), elsewhere if one day, after some change, any > that fields become non-NULL

Re: [PATCH net-next 1/9] sched: add helper for updating statistics on all actions

2017-06-01 Thread Or Gerlitz
On Wed, May 31, 2017 at 6:06 PM, Jakub Kicinski wrote: > Forgetting to disable preemption around tcf_action_stats_update() > seems to be a common mistake. Add a helper function for updating > stats on all actions of a filter. > > Signed-off-by: Jakub Kicinski

[PATCH net-next] tcp: remove unnecessary skb_reset_tail_pointer()

2017-06-01 Thread Eric Dumazet
From: Eric Dumazet __pskb_trim_head() does not need to reset skb tail pointer. Also change the comments, __pskb_pull_head() does not exist. Signed-off-by: Eric Dumazet --- net/ipv4/tcp_output.c |6 ++ 1 file changed, 2 insertions(+), 4

Re: [PATCH net-next v3 0/5] net: dsa: tagger simplification

2017-06-01 Thread David Miller
From: Vivien Didelot Date: Thu, 1 Jun 2017 16:07:10 -0400 > This series clarifies the hot path, removes the labels in tagging > implementations, and frees the original SKB in the xmit caller. > > Changes in v3: > - drop removal of usused rcv arguments

[for 4.12] net: qcom/emac: do not use hardware mdio automatic polling

2017-06-01 Thread Timur Tabi
Use software polling (PHY_POLL) to check for link state changes instead of relying on the EMAC's hardware polling feature. Some PHY drivers are unable to get a functioning link because the HW polling is not robust enough. The EMAC is able to poll the PHY on the MDIO bus looking for link state

[for 4.12] net: qcom/emac: do not use hardware mdio automatic polling

2017-06-01 Thread Timur Tabi
Use software polling (PHY_POLL) to check for link state changes instead of relying on the EMAC's hardware polling feature. Some PHY drivers are unable to get a functioning link because the HW polling is not robust enough. The EMAC is able to poll the PHY on the MDIO bus looking for link state

[net-next 02/14] i40e/i40evf: create and use new unified header file

2017-06-01 Thread Jeff Kirsher
From: Jesse Brandeburg This moves a header for i40evf to include/linux/avf/virtchnl.h. The directory name AVF is an acronym for the Intel(R) Adaptive Virtual Function. This first step creates the new file, which is a rename of

[net-next 10/14] i40e/virtchnl: move function to virtchnl

2017-06-01 Thread Jeff Kirsher
From: Jesse Brandeburg This moves a function that is needed for the virtchnl interface from the i40e PF driver over to the virtchnl.h file. It was manually verified that the function in question is unchanged except for the function name and function header, which

Re: loosing netdevices with namespaces and unshare?

2017-06-01 Thread Eric W. Biederman
Cong Wang writes: > Network namespace does not special-case the physical devices, > it treats them all equally as abstract net devices. Absolutely not true. The relevant code is in net/core/dev.c:default_device_exit If a network device does not implement rntl_link_ops

Re: running an eBPF program

2017-06-01 Thread Adel Fuchs
Hi, Thanks for your reply. Where do I need to add this workaround? Thanks, Adel On Mon, May 29, 2017 at 8:31 AM, Y Song wrote: > On Sun, May 28, 2017 at 12:38 AM, Adel Fuchs wrote: >> Hi, >> Is there any way to run this eBPF program without that patch?

[PATCH v2] xfrm: fix xfrm_dev_event() missing when compile without CONFIG_XFRM_OFFLOAD

2017-06-01 Thread Hangbin Liu
In commit d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API") we make xfrm_device.o only compiled when enable option CONFIG_XFRM_OFFLOAD. But this will make xfrm_dev_event() missing if we only enable default XFRM options. Then if we set down and unregister an interface with IPsec on it.

Re: [PATCH] net: ethernet: stmmac: Fix altr_tse_pcs SGMII Initialization

2017-06-01 Thread Giuseppe CAVALLARO
On 5/31/2017 9:28 PM, thor.tha...@linux.intel.com wrote: From: Thor Thayer Fix NETDEV WATCHDOG timeout on startup by adding missing register writes that properly setup SGMII. Signed-off-by: Thor Thayer Thanks a lot for this fix.

Re: loosing netdevices with namespaces and unshare?

2017-06-01 Thread Harald Welte
Hi Eric, On Thu, Jun 01, 2017 at 01:32:49AM -0500, Eric W. Biederman wrote: > If a network device does not implement rntl_link_ops it is returned to > the initial network namespace. Anything else will loose physical > devices. Thanks a lot for your statement. This is a big relief, my line of

Re: [PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes

2017-06-01 Thread Johan Hovold
Hi Samuel, On Tue, May 16, 2017 at 11:42:29AM +0200, Johan Hovold wrote: > On Thu, Apr 27, 2017 at 12:42:38AM +0200, Samuel Ortiz wrote: > > Hi Johan, > > > > On Thu, Mar 30, 2017 at 12:15:34PM +0200, Johan Hovold wrote: > > > This started out with the observation that the nfcmrvl_uart driver >

Re: [net] vxlan: fix use-after-free on deletion

2017-06-01 Thread Jiri Benc
On Thu, 1 Jun 2017 11:43:35 +0300, Mark Bloch wrote: > Adding a vxlan interface to a socket isn't symmetrical, while adding > is done in vxlan_open() the deletion is done in vxlan_dellink(). > This can cause a use-after-free error when we close the vxlan > interface before deleting it. > > We add

[PATCH net] netlink: don't send unknown nsid

2017-06-01 Thread Nicolas Dichtel
The NETLINK_F_LISTEN_ALL_NSID otion enables to listen all netns that have a nsid assigned into the netns where the netlink socket is opened. The nsid is sent as metadata to userland, but the existence of this nsid is checked only for netns that are different from the socket netns. Thus, if no nsid

Re: loosing netdevices with namespaces and unshare?

2017-06-01 Thread Eric W. Biederman
Harald Welte writes: > Hi Eric, > > On Thu, Jun 01, 2017 at 01:32:49AM -0500, Eric W. Biederman wrote: > >> If a network device does not implement rntl_link_ops it is returned to >> the initial network namespace. Anything else will loose physical >> devices. > > Thanks a

[PATCH iproute2] iplink: Update usage in help message

2017-06-01 Thread Tariq Toukan
From: Eli Cohen Add to usage message a description of how to configure Infiniband node and port GUIDs. Fixes: d91fb3f4c7e4 ('Add support for configuring Infiniband GUIDs') Signed-off-by: Eli Cohen Signed-off-by: Tariq Toukan ---

Re: [PATCH nf-next] netns: add and use net_ns_barrier

2017-06-01 Thread Florian Westphal
Eric W. Biederman wrote: > Florian Westphal writes: > > > Quoting Joe Stringer: > > If a user loads nf_conntrack_ftp, sends FTP traffic through a network > > namespace, destroys that namespace then unloads the FTP helper module, > > then the kernel

Re: running an eBPF program

2017-06-01 Thread Adel Fuchs
OK. Found it. Thanks! it works! On Thu, Jun 1, 2017 at 9:43 AM, Adel Fuchs wrote: > Hi, > Thanks for your reply. Where do I need to add this workaround? > > Thanks, > Adel > > On Mon, May 29, 2017 at 8:31 AM, Y Song wrote: >> On Sun, May 28, 2017 at

[net-next] team: add macro MODULE_ALIAS_TEAM_MODE for team mode alias

2017-06-01 Thread Zhang Shengju
Add a new macro MODULE_ALIAS_TEAM_MODE to unify and simplify the declaration of team mode alias. Signed-off-by: Zhang Shengju --- drivers/net/team/team_mode_activebackup.c | 2 +- drivers/net/team/team_mode_broadcast.c| 2 +-

Re: Oops with commit 6d18c73 bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

2017-06-01 Thread Xin Long
On Thu, Jun 1, 2017 at 12:32 AM, Sebastian Ott wrote: [...] > > A system running v4.12-rc3-11-gf511c0b on s390 hangs after boot with no > messages on the console. The message buffer obtained via a system dump > looked like this: > > [...] > [ 17.870712] virbr0: port

Re: [PATCH net-next] netlink: include netnsid only when netns differs.

2017-06-01 Thread Nicolas Dichtel
Le 31/05/2017 à 20:34, Flavio Leitner a écrit : > On Wed, May 31, 2017 at 03:48:06PM +0200, Nicolas Dichtel wrote: >> Le 31/05/2017 à 14:28, Flavio Leitner a écrit : >>> On Wed, May 31, 2017 at 10:38:21AM +0200, Nicolas Dichtel wrote: Le 30/05/2017 à 23:33, Flavio Leitner a écrit : >

[PATCH] qlcnic: Fix a sleep-in-atomic bug in qlcnic_82xx_hw_write_wx_2M and qlcnic_82xx_hw_read_wx_2M

2017-06-01 Thread Jia-Ju Bai
The driver may sleep under a write spin lock, and the function call path is: qlcnic_82xx_hw_write_wx_2M (acquire the lock by write_lock_irqsave) crb_win_lock qlcnic_pcie_sem_lock usleep_range qlcnic_82xx_hw_read_wx_2M (acquire the lock by write_lock_irqsave) crb_win_lock

[net] vxlan: fix use-after-free on deletion

2017-06-01 Thread Mark Bloch
Adding a vxlan interface to a socket isn't symmetrical, while adding is done in vxlan_open() the deletion is done in vxlan_dellink(). This can cause a use-after-free error when we close the vxlan interface before deleting it. We add vxlan_vs_del_dev() to match vxlan_vs_add_dev() and call it from

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

2017-06-01 Thread Soheil Hassas Yeganeh
On Thu, Jun 1, 2017 at 11:10 AM, Cyril Hrubis wrote: >> Thank you for the confirmation. Could you please try the following >> patch to see if it fixes your issue? > > Does not seem to help, I still got the same bussy loop. Thank you for trying the patch. Unfortunately, I can't

Re: [PATCH v2 net-next 1/3] perf, bpf: Add BPF support to all perf_event types

2017-06-01 Thread Alexei Starovoitov
On 6/1/17 6:32 AM, Peter Zijlstra wrote: OK, do that. Something like the below should do I suppose. It will return -EOPNOTSUPP for permanent failure (it cannot ever work) and -EINVAL for temporary failure (could work if you call it on another task/cpu). Thanks! Will test it and report back.

Re: [PATCH 2/5] net: phy: hook up clause 45 autonegotiation restart

2017-06-01 Thread Russell King - ARM Linux
On Thu, Jun 01, 2017 at 03:19:55PM +0200, Andrew Lunn wrote: > On Thu, Jun 01, 2017 at 02:09:00PM +0100, Russell King - ARM Linux wrote: > > On Thu, Jun 01, 2017 at 03:05:27PM +0200, Andrew Lunn wrote: > > > So you are saying a 10G PHY driver always needs to have a aneg_done > > > callback, even

Re: [PATCH net V3] net/mlx4: Fix the check in attaching steering rules

2017-06-01 Thread David Miller
From: Tariq Toukan Date: Thu, 1 Jun 2017 12:16:46 +0300 > From: Talat Batheesh > > Our previous patch (cited below) introduced a regression > for RAW Eth QPs. > > Fix it by checking if the QP number provided by user-space > exists, hence allowing

Re: [PATCH][net-next] net: dsa: make function ksz_rcv static

2017-06-01 Thread David Miller
From: Colin King Date: Thu, 1 Jun 2017 13:22:42 +0100 > From: Colin Ian King > > function ksz_rcv can be made static as it does not need to be > in global scope. Reformat arguments to make it checkpatch warning > free too. > > Cleans up

Re: [PATCH net-next] mlxsw: spectrum: Implement the ethtool flash_device callback

2017-06-01 Thread David Miller
From: Yotam Gigi Date: Thu, 1 Jun 2017 16:26:46 +0300 > Add callback to the ethtool flash_device op. This callback uses the mlxfw > module to flash the new firmware file to the device. > > As the firmware flash process takes about 20 seconds and ethtool takes the > rtnl

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

2017-06-01 Thread Cyril Hrubis
Hi! > Thank you for the confirmation. Could you please try the following > patch to see if it fixes your issue? Does not seem to help, I still got the same bussy loop. -- Cyril Hrubis chru...@suse.cz

Re: [PATCH] qlcnic: Fix a sleep-in-atomic bug in qlcnic_82xx_hw_write_wx_2M and qlcnic_82xx_hw_read_wx_2M

2017-06-01 Thread David Miller
From: Jia-Ju Bai Date: Thu, 1 Jun 2017 16:18:10 +0800 > The driver may sleep under a write spin lock, and the function > call path is: > qlcnic_82xx_hw_write_wx_2M (acquire the lock by write_lock_irqsave) > crb_win_lock > qlcnic_pcie_sem_lock > usleep_range >

Re: [PATCH 0/5] Add phylib support for MV88X3310 10G phy

2017-06-01 Thread David Miller
From: Russell King - ARM Linux Date: Thu, 1 Jun 2017 11:23:27 +0100 > This patch series adds support for the Marvell 88x3310 PHY found on > the SolidRun Macchiatobin board. Andrew has asked for some comment documentation additions to patch #5 so I'm expecting at least one

Re: [PATCH net] cxgb4: update latest firmware version supported

2017-06-01 Thread David Miller
From: Ganesh Goudar Date: Thu, 1 Jun 2017 17:11:30 +0530 > Change t4fw_version.h to update latest firmware version > number to 1.16.45.0. > > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH net] bnx2x: Fix Multi-Cos

2017-06-01 Thread David Miller
From: Yuval Mintz Date: Thu, 1 Jun 2017 15:57:56 +0300 > Apparently multi-cos isn't working for bnx2x quite some time - > driver implements ndo_select_queue() to allow queue-selection > for FCoE, but the regular L2 flow would cause it to modulo the > fallback's result by

Re: [PATCH net] net: bridge: start hello timer only if device is up

2017-06-01 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 1 Jun 2017 18:07:55 +0300 > When the transition of NO_STP -> KERNEL_STP was fixed by always calling > mod_timer in br_stp_start, it introduced a new regression which causes > the timer to be armed even when the bridge is down,

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

2017-06-01 Thread Soheil Hassas Yeganeh
On Thu, Jun 1, 2017 at 11:36 AM, Cyril Hrubis wrote: > It seems to repeatedly produce (until I plug the cable back): > > ee_errno = 113 ee_origin = 2 ee_type = 3 ee_code = 1 ee_info = 0 ee_data = 0 > > So we get EHOSTUNREACH on SO_EE_ORIGIN_ICMP. Thank you very much! I have a

Re: [PATCH net-next] ipv4: route: restore skb_dst_set in inet_rtm_getroute

2017-06-01 Thread David Miller
From: Roopa Prabhu Date: Wed, 31 May 2017 22:53:25 -0700 > From: Roopa Prabhu > > recent updates to inet_rtm_getroute dropped skb_dst_set in > inet_rtm_getroute. This patch restores it because it is > needed to release the dst correctly. >

Re: [PATCH net-next 00/11] qed: Status block changes

2017-06-01 Thread David Miller
From: Yuval Mintz Date: Thu, 1 Jun 2017 15:29:00 +0300 > The device maintains a CAM mapping of the internal status blocks > and the various PF/VF MSI-x vector mappings. > During initialization, the driver reads the HW memory and constructs > a shadow SW implementation

Re: [PATCH net-next 2/3] udp: avoid a cache miss on dequeue

2017-06-01 Thread Paolo Abeni
On Thu, 2017-06-01 at 08:58 -0700, Eric Dumazet wrote: > On Thu, 2017-06-01 at 12:39 +0200, Paolo Abeni wrote: > > On Wed, 2017-05-31 at 10:00 -0700, Eric Dumazet wrote: > > > On Mon, 2017-05-29 at 17:27 +0200, Paolo Abeni wrote: > > > > Since UDP no more uses sk->destructor, we can clear

Re: [PATCH net] ibmvnic: Update module author

2017-06-01 Thread David Miller
From: Thomas Falcon Date: Thu, 1 Jun 2017 10:53:13 -0500 > Would it be better to include a second or more authors and/or remove > the original author's mailing address, which isn't valid anymore? > How should this be handled? You can remove the email address if it

Re: [PATCH net-next 2/3] udp: avoid a cache miss on dequeue

2017-06-01 Thread Eric Dumazet
On Thu, Jun 1, 2017 at 9:21 AM, Paolo Abeni wrote: > I'm sorry, I do not follow. I'm concerned about the secpath field (skb- >>sp), which is the only one that can be not NULL in > __udp_queue_rcv_skb(). > > If the secpath is not NULL, calling there secpath_reset() (or the to-

Re: [PATCH 0/5] Add phylib support for MV88X3310 10G phy

2017-06-01 Thread Russell King - ARM Linux
On Thu, Jun 01, 2017 at 12:07:36PM -0400, David Miller wrote: > From: Russell King - ARM Linux > Date: Thu, 1 Jun 2017 11:23:27 +0100 > > > This patch series adds support for the Marvell 88x3310 PHY found on > > the SolidRun Macchiatobin board. > > Andrew has asked for

Re: [PATCH net] netlink: don't send unknown nsid

2017-06-01 Thread Flavio Leitner
On Thu, Jun 01, 2017 at 10:00:07AM +0200, Nicolas Dichtel wrote: > The NETLINK_F_LISTEN_ALL_NSID otion enables to listen all netns that have a > nsid assigned into the netns where the netlink socket is opened. > The nsid is sent as metadata to userland, but the existence of this nsid is > checked

Re: [PATCH net] ibmvnic: Update module author

2017-06-01 Thread Thomas Falcon
On 05/31/2017 04:12 PM, David Miller wrote: > From: Thomas Falcon > Date: Wed, 31 May 2017 15:35:31 -0500 > >> Update the module author to be one of the original co-maintainers >> of the driver. The original author left the project long ago and >> so far has not

Re: [PATCH net-next 1/4] net/flow_dissector: add support for dissection of misc ip header fields

2017-06-01 Thread Or Gerlitz
On Tue, May 30, 2017 at 7:18 PM, David Miller wrote: > The top level merge commit explains everything, and since the patches > are grouped together logically, even if you just look at the merge > commit in the GIT tree, it is mentioned. Hi Dave, Do you want to see a repost

Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

2017-06-01 Thread Jason Gunthorpe
On Mon, May 29, 2017 at 04:09:06PM +, Ilan Tayari wrote: > > For IPSec, this is already in the kernel. > > See this patchset: > > http://www.mail-archive.com/netdev@vger.kernel.org/msg162876.html > > Sorry, I pointed at the RFC by mistake. > > This is the relevant pull request: >

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

2017-06-01 Thread Cyril Hrubis
Hi! > >> Thank you for the confirmation. Could you please try the following > >> patch to see if it fixes your issue? > > > > Does not seem to help, I still got the same bussy loop. > > Thank you for trying the patch. Unfortunately, I can't reproduce on my > machines here.Would you humor me with

Re: [net] vxlan: fix use-after-free on deletion

2017-06-01 Thread David Miller
From: Mark Bloch Date: Thu, 1 Jun 2017 11:43:35 +0300 > Adding a vxlan interface to a socket isn't symmetrical, while adding > is done in vxlan_open() the deletion is done in vxlan_dellink(). > This can cause a use-after-free error when we close the vxlan > interface before

Re: [PATCH net-next] ppp: remove unnecessary bh disable in xmit path

2017-06-01 Thread David Miller
From: gfree.w...@vip.163.com Date: Thu, 1 Jun 2017 17:58:39 +0800 > From: Gao Feng > > Since the commit 55454a565836 ("ppp: avoid dealock on recursive xmit"), > the PPP xmit path is protected by wrapper functions which disable the > bh already. So it is unnecessary to

Re: Cherry pick commit *net: better skb->sender_cpu and skb->napi_id cohabitation* to 4.4 series?

2017-06-01 Thread David Miller
Neither of us have anything to do with the 4.4 -stable series. We only manage stable backport submissions for the most recent two releases.

Re: [PATCH net-next 1/4] net/flow_dissector: add support for dissection of misc ip header fields

2017-06-01 Thread David Miller
From: Or Gerlitz Date: Thu, 1 Jun 2017 19:08:56 +0300 > On Tue, May 30, 2017 at 7:18 PM, David Miller wrote: > >> The top level merge commit explains everything, and since the patches >> are grouped together logically, even if you just look at the

[PATCH net] net: bridge: start hello timer only if device is up

2017-06-01 Thread Nikolay Aleksandrov
When the transition of NO_STP -> KERNEL_STP was fixed by always calling mod_timer in br_stp_start, it introduced a new regression which causes the timer to be armed even when the bridge is down, and since we stop the timers in its ndo_stop() function, they never get disabled if the device is

Re: [net-next] team: add macro MODULE_ALIAS_TEAM_MODE for team mode alias

2017-06-01 Thread David Miller
From: Zhang Shengju Date: Thu, 1 Jun 2017 15:37:02 +0800 > Add a new macro MODULE_ALIAS_TEAM_MODE to unify and simplify the > declaration of team mode alias. > > Signed-off-by: Zhang Shengju Jiri, please review.

Re: [PATCH net] netlink: don't send unknown nsid

2017-06-01 Thread David Miller
From: Nicolas Dichtel Date: Thu, 1 Jun 2017 10:00:07 +0200 > The NETLINK_F_LISTEN_ALL_NSID otion enables to listen all netns that have a > nsid assigned into the netns where the netlink socket is opened. > The nsid is sent as metadata to userland, but the existence of

Re: [PATCH net-next 2/3] udp: avoid a cache miss on dequeue

2017-06-01 Thread Eric Dumazet
On Thu, 2017-06-01 at 12:39 +0200, Paolo Abeni wrote: > On Wed, 2017-05-31 at 10:00 -0700, Eric Dumazet wrote: > > On Mon, 2017-05-29 at 17:27 +0200, Paolo Abeni wrote: > > > Since UDP no more uses sk->destructor, we can clear completely > > > the skb head state before enqueuing. > > > > ... > >

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

2017-06-01 Thread Jonathan Corbet
On Thu, 01 Jun 2017 09:05:07 +0800 Jia-Ju Bai wrote: > I admit my patches are not well tested, and they may not well fix the bugs. > I am looking forward to opinions and suggestions :) May I politely suggest that sending out untested locking changes is a dangerous thing to

Re: [PATCH 2/5] net: phy: hook up clause 45 autonegotiation restart

2017-06-01 Thread Russell King - ARM Linux
On Thu, Jun 01, 2017 at 04:47:35PM +0100, Russell King - ARM Linux wrote: > On Thu, Jun 01, 2017 at 03:19:55PM +0200, Andrew Lunn wrote: > > On Thu, Jun 01, 2017 at 02:09:00PM +0100, Russell King - ARM Linux wrote: > > > On Thu, Jun 01, 2017 at 03:05:27PM +0200, Andrew Lunn wrote: > > > > So you

Re: [PATCH 4/5] net: phy: add XAUI and 10GBASE-KR PHY connection types

2017-06-01 Thread Florian Fainelli
On 06/01/2017 03:26 AM, Russell King wrote: > XAUI allows XGMII to reach an extended distance by using a XGXS layer at > each end of the MAC to PHY link, operating over four Serdes lanes. > > 10GBASE-KR is a single lane Serdes backplane ethernet connection method > with autonegotiation on the

Re: [net-next 09/15] ixgbevf: Resolve truncation warning for q_vector->name

2017-06-01 Thread Sergei Shtylyov
Hello! On 6/1/2017 12:19 AM, Jeff Kirsher wrote: From: Tony Nguyen The following warning is now shown as a result of new checks added for gcc 7: drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c: In function ‘ixgbevf_open’:

Re: [PATCH 04/12] fs: ceph: CURRENT_TIME with ktime_get_real_ts()

2017-06-01 Thread Arnd Bergmann
On Thu, Jun 1, 2017 at 11:56 AM, Yan, Zheng wrote: > On Sat, Apr 8, 2017 at 8:57 AM, Deepa Dinamani wrote: >> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c >> index 517838b..77204da 100644 >> --- a/drivers/block/rbd.c >> +++

[PATCH 0/5] Add phylib support for MV88X3310 10G phy

2017-06-01 Thread Russell King - ARM Linux
Hi, This patch series adds support for the Marvell 88x3310 PHY found on the SolidRun Macchiatobin board. The first patch introduces a set of generic Clause 45 PHY helpers that C45 PHY drivers can make use of if they wish. Patch 2 fixes the aneg restart to be compatible with C45 PHYs - it can

[PATCH 1/5] net: phy: add 802.3 clause 45 support to phylib

2017-06-01 Thread Russell King
Add generic helpers for 802.3 clause 45 PHYs for >= 10Gbps support. Signed-off-by: Russell King --- drivers/net/phy/Makefile | 2 +- drivers/net/phy/phy-c45.c| 231 +++ drivers/net/phy/phy_device.c | 20 ++--

[PATCH net V3] net/mlx4: Fix the check in attaching steering rules

2017-06-01 Thread Tariq Toukan
From: Talat Batheesh Our previous patch (cited below) introduced a regression for RAW Eth QPs. Fix it by checking if the QP number provided by user-space exists, hence allowing steering rules to be added for valid QPs only. Fixes: 89c557687a32 ("net/mlx4_en: Avoid adding

Re: BRCMFMAC OOB interrupt problem

2017-06-01 Thread Arend van Spriel
On 01-06-17 09:44, Hegr, Jiri wrote: > Dears, > We use small WiFi evaluation board WM-BN-BM-04_EVB_V1.2 with BCM43362 chip > (Broadcom). > This board is connected to OMAP-L138 via SDIO interface with Linux 4.9.10 > containing WiFi driver brcmfmac. > Our problem is in OOB interrupt. The driver

Re: cw1200: Fix a sleep-in-atomic bug in cw1200_tx_confirm_cb and cw1200_cqm_bssloss_sm

2017-06-01 Thread Kalle Valo
Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > cw1200_tx_confirm_cb (acquire the lock by spin_lock) > __cw1200_cqm_bssloss_sm > cancel_work_sync --> may sleep > > cw1200_cqm_bssloss_sm > __cw1200_cqm_bssloss_sm >

Re: [PATCH net-next 2/3] udp: avoid a cache miss on dequeue

2017-06-01 Thread Paolo Abeni
On Wed, 2017-05-31 at 10:00 -0700, Eric Dumazet wrote: > On Mon, 2017-05-29 at 17:27 +0200, Paolo Abeni wrote: > > Since UDP no more uses sk->destructor, we can clear completely > > the skb head state before enqueuing. > > ... > > > @@ -1739,6 +1740,9 @@ static int __udp_queue_rcv_skb(struct

Re: [PATCH net-next 3/3] udp: try to avoid 2 cache miss on dequeue

2017-06-01 Thread Paolo Abeni
On Wed, 2017-05-31 at 10:04 -0700, Eric Dumazet wrote: > On Mon, 2017-05-29 at 17:27 +0200, Paolo Abeni wrote: > > when udp_recvmsg() is executed, on x86_64 and other archs, most skb > > fields are on cold cachelines. > > If the skb are linear and the kernel don't need to compute the udp > > csum,

Re: mwifiex: simplify the code around ra_list

2017-06-01 Thread Kalle Valo
Shawn Lin wrote: > We don't need to check if the list is empty separately > as we could use list_first_entry_or_null to cover it. > > Signed-off-by: Shawn Lin > Reviewed-by: Brian Norris Patch applied to

  1   2   3   >