[patch net-next v2 12/19] mlxsw: spectrum: Remove support for bridge bypass FDB add/del

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky The FDB add/del are now done through the notification chain. The FDBs are synced with the bridge and there is no need for extra dumping. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel

[patch net-next v2 19/19] rocker: Remove support bridge bypass FDB

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky The FDB add/delete are now done through the notification chain. The FDBs are synced with the bridge and there is no need for extra dumping. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko ---

[patch net-next v2 16/19] rocker: Change world_ops API and implementation to be switchdev independant

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky Currently the switchdev_trans struct is embedded in the world_ops API. In order to add support for adding FDB via a notfication chain the API should be switchdev independent. Signed-off-by: Arkadi Sharshevsky Signed-off-by:

[patch net-next v2 14/19] rocker: Remove support for bridge FDB learning sync

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky Currently the rocker driver supports an option for disabling syncing the hardware learned FDBs with the software bridge. This behavior breaks the bridge offload model and thus it is removed. Signed-off-by: Arkadi Sharshevsky

[patch net-next v2 13/19] net: Remove support for bridge bypass ndos from stacked devices

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky Remove support for bridge bypass ndos from stacked devices. At this point no driver which supports stack device behavior offload supports operation with SELF flag. The case for upper device is already taken care of in both of the following cases:

[patch net-next v2 09/19] mlxsw: spectrum: Remove support for bypass bridge port attributes/vlan set

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky The bridge port attributes/vlan for mlxsw devices should be set only from bridge code. The vlans are synced totally with the bridge so there is no need to special dump support. Signed-off-by: Arkadi Sharshevsky Reviewed-by:

[patch net-next v2 17/19] rocker: Add support for learning FDB through notification

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky Add support for learning FDB through notification. The driver defers the hardware update via ordered work queue. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko ---

[patch net-next v2 18/19] rocker: Remove support for bypass bridge port attributes/vlan set

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky The bridge port attributes/vlan for mlxsw devices should be set only from bridge code. The vlans are synced totally with the bridge so there is no need to special dump support. Signed-off-by: Arkadi Sharshevsky Signed-off-by:

RE: [linuxwifi] [PATCH] net: wireless: intel: iwlwifi: dvm: fix tid mask

2017-06-08 Thread Grumbach, Emmanuel
> > On Thu, Jun 08, 2017 at 06:31:01AM +, Grumbach, Emmanuel wrote: > > Hi, > > Hi, > > > True, OTOH we need tid to be 8 sometimes. We *just* need to make sure > > that we don't index tid_data with this. Hence I think the proper fix is: > > > > diff --git

Re: [PATCH RFC net-next 2/4] net/mlx5e: NIC netdev init flow cleanup

2017-06-08 Thread Or Gerlitz
On Thu, Jun 8, 2017 at 2:42 AM, Saeed Mahameed wrote: > Remove redundant mlx5_eswitch_unregister_vport_rep in mlx5e_add error flow. Maybe have point patch that makes it clear we fix commit 26e59d807 ? > Hide mlx5e_rep_priv and eswitch internal structures from en_main.c in

Re: [PATCH 9/9] arm64: marvell: dts: add xmdio nodes for 7k/8k

2017-06-08 Thread Antoine Tenart
On Thu, Jun 08, 2017 at 10:45:15AM +0200, Antoine Tenart wrote: > On Wed, Jun 07, 2017 at 10:38:10AM +0200, Antoine Tenart wrote: > > diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi > > b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi > > index 2a99ff8fca2a..594356243ddb

Re: linux-next: build failure after merge of the net tree

2017-06-08 Thread Stephen Rothwell
Hi Greg, On Thu, 8 Jun 2017 09:22:20 +0200 Greg Kroah-Hartman wrote: > > Looks good to me, thanks for this, I'll keep it around for when the > merge window happens. Actually, that patch needs to go into the net tree before Dave asks Linus to merge it - the net tree

Re: [PATCH RFC net-next 3/4] net/mlx5: Separate between eswitch and MPFS l2 table logic

2017-06-08 Thread Or Gerlitz
On Thu, Jun 8, 2017 at 2:42 AM, Saeed Mahameed wrote: [...] > 9 files changed, 376 insertions(+), 223 deletions(-) a bit of heavy duty for this sort of sensitive change, should investigate if it can be broken a bit > +int mlx5_mpfs_init(struct mlx5_core_dev *dev) > +{ > +

[PATCH] af_unix: Add sockaddr length checks before accessing sa_family in bind and connect handlers

2017-06-08 Thread Mateusz Jurczyk
Verify that the caller-provided sockaddr structure is large enough to contain the sa_family field, before accessing it in bind() and connect() handlers of the AF_UNIX socket. Since neither syscall enforces a minimum size of the corresponding memory region, very short sockaddrs (zero or one byte

RE: [linuxwifi] [PATCH] net: wireless: intel: iwlwifi: dvm: fix tid mask

2017-06-08 Thread Grumbach, Emmanuel
Hi, > Subject: [linuxwifi] [PATCH] net: wireless: intel: iwlwifi: dvm: fix tid mask > > Currently the tid mask covers the first 4 bits of iwlagn_tx_resp::ra_tid, > which gives 16 possible values for tid. > This is problematic because IWL_MAX_TID_COUNT is 8, so indexing > iwl_priv::tid_data can

Re: [PATCH net-next 0/3] LiquidIO: avoid VM low memory crashes

2017-06-08 Thread Leon Romanovsky
On Wed, Jun 07, 2017 at 08:50:45PM -0700, Felix Manlunas wrote: > From: Rick Farrington > > This patchset addresses issues brought about by low memory conditions > in a VM. These conditions were only seen when VM's were intentionally > created with small amounts of

[PATCH 0/2] drivers: net: add const to mii_phy_ops structures

2017-06-08 Thread Bhumika Goyal
The object references of mii_phy_ops structures are only stored in the ops field of a mii_phy_def structure. This ops field is of type const. So, mii_phy_ops structures having similar properties can be declared as const. Bhumika Goyal (2): drivers/net/sungem: add const to mii_phy_ops structures

[PATCH 1/2] drivers/net/sungem: add const to mii_phy_ops structures

2017-06-08 Thread Bhumika Goyal
The object references of mii_phy_ops structures are only stored in the ops field of a mii_phy_def structure. This ops field is of type const. So, mii_phy_ops structures having similar properties can be declared as const. Signed-off-by: Bhumika Goyal ---

RE: [PATCH net-next 00/16] nfp: ctrl vNIC

2017-06-08 Thread Mintz, Yuval
> >> >> >> >What were your plans with pre-netdev config? > >> >> >> > >> >> >> We need to pass come initial resource division. Generally the > >> >> >> consensus is to have these options exposed through devlink, let > >> >> >> the user configure them all and then to have a trigger that > >> >> >>

[patch net-next v2 02/19] net: bridge: Add support for offloading port attributes

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky Currently the flood, learning and learning_sync port attributes are offloaded by setting the SELF flag. Add support for offloading the flood and learning attribute through the bridge code. In case of setting an unsupported flag on a offloded port

[patch net-next v2 01/19] net: switchdev: Add support for querying supported bridge flags by hardware

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky This is done as a preparation stage before setting the bridge port flags from the bridge code. Currently the device can be queried for the bridge flags state, but the querier cannot distinguish if the flag is disabled or if it is not supported at

[patch net-next v2 03/19] net: bridge: Add support for calling FDB external learning under rcu

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky This is done as a preparation to moving the switchdev notifier chain to be atomic. The FDB external learning should be called under rtnl or rcu. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel

[patch net-next v2 06/19] net: bridge: Receive notification about successful FDB offload

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky When a new static FDB is added to the bridge a notification is sent to the driver for offload. In case of successful offload the driver should notify the bridge back, which in turn should mark the FDB as offloaded. Currently, externally learned is

[patch net-next v2 08/19] mlxsw: spectrum_switchdev: Add support for querying supported bridge flags

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky Add support for querying supported bridge flags. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko ---

[patch net-next v2 15/19] rocker: Add support for querying supported bridge flags

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky Add support for querying supported bridge flags. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker.h | 4

[PATCH net-next] cxgb4: handle interrupt raised when FW crashes

2017-06-08 Thread Ganesh Goudar
From: Rahul Lakkireddy Handle TIMER0INT when FW crashes. Check for PCIE_FW[FW_EVAL] and if it says "Device FW Crashed", then treat it as fatal. Else, non-fatal. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar

[PATCH net] openvswitch: warn about missing first netlink attribute

2017-06-08 Thread Nicolas Dichtel
The first netlink attribute (value 0) must always be defined as none/unspec. Because we cannot change an existing UAPI, I add a comment to point the mistake and avoid to propagate it in a new ovs API in the future. Signed-off-by: Nicolas Dichtel ---

Re: [PATCH 9/9] arm64: marvell: dts: add xmdio nodes for 7k/8k

2017-06-08 Thread Antoine Tenart
Hi Gregory, On Thu, Jun 08, 2017 at 10:55:01AM +0200, Gregory CLEMENT wrote: > On jeu., juin 08 2017, Antoine Tenart > wrote: > > On Wed, Jun 07, 2017 at 10:38:10AM +0200, Antoine Tenart wrote: > >> diff --git

Re: kisskb: FAILED linux-next/s390-defconfig/s390x Thu Jun 08, 18:28

2017-06-08 Thread Stephen Rothwell
Hi Dave, On Thu, 08 Jun 2017 08:29:32 - nore...@ellerman.id.au wrote: > > FAILED linux-next/s390-defconfig/s390x Thu Jun 08, 18:28 > > http://kisskb.ellerman.id.au/kisskb/buildresult/13055728/ > > Commit: Add linux-next specific

Re: [patch net-next v2 01/19] net: switchdev: Add support for querying supported bridge flags by hardware

2017-06-08 Thread Ivan Vecera
On 8.6.2017 08:44, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > This is done as a preparation stage before setting the bridge port flags > from the bridge code. Currently the device can be queried for the bridge > flags state, but the querier cannot distinguish if the

Re: [patch net-next v2 04/19] net: switchdev: Change notifier chain to be atomic

2017-06-08 Thread Ivan Vecera
On 8.6.2017 08:44, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > In order to use the switchdev notifier chain for FDB sync with the > device it has to be changed to atomic. The is done because the bridge > can learn new FDBs in atomic context. > > Signed-off-by: Arkadi

Re: [patch net-next v2 05/19] net: bridge: Add support for notifying devices about FDB add/del

2017-06-08 Thread Ivan Vecera
On 8.6.2017 08:44, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > Currently the bridge doesn't notify the underlying devices about new > FDBs learned. The FDB sync is placed on the switchdev notifier chain > because devices may potentially learn FDB that are not directly

Re: [patch net-next v2 02/19] net: bridge: Add support for offloading port attributes

2017-06-08 Thread Ivan Vecera
On 8.6.2017 08:44, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > Currently the flood, learning and learning_sync port attributes are > offloaded by setting the SELF flag. Add support for offloading the > flood and learning attribute through the bridge code. In case of >

[PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-08 Thread Antoine Tenart
This patch adds the xMDIO interface support in the mvmdio driver. This interface is used in Ethernet controllers on Marvell 370, 7k and 8k (as of now). The xSMI interface supported by this driver complies with the IEEE 802.3 clause 45 (while the SMI interface complies with the clause 22). The xSMI

[PATCH v2 0/8] net: mvmdio: add xSMI support

2017-06-08 Thread Antoine Tenart
Hello, This series aims to add the xSMI support (also called xMDIO) to the mvmdio driver. The xSMI interface complies with the IEEE 802.3 clause 45 and is used by 10GbE devices. On 7k and 8k (as of now), such an interface is found and is used by Ethernet controllers. Patches 1-3 are cosmetic

[PATCH v2 5/8] net: mvmdio: introduce an ops structure

2017-06-08 Thread Antoine Tenart
Introduce an ops structure to add an indirection on functions accessing the registers. This is needed to add the xMDIO support later. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvmdio.c | 71 ++- 1 file

[PATCH v2 6/8] net: mvmdio: put the poll intervals in the ops structure

2017-06-08 Thread Antoine Tenart
Put the two poll intervals (min and max) in the driver's ops structure. This is needed to add the xmdio support later. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvmdio.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)

[PATCH v2 2/8] net: mvmdio: use tabs for defines

2017-06-08 Thread Antoine Tenart
Cosmetic patch replacing spaces by tabs for defined values. Signed-off-by: Antoine Tenart Reviewed-by: Florian Fainelli --- drivers/net/ethernet/marvell/mvmdio.c | 26 +- 1 file changed, 13 insertions(+), 13

[PATCH v2 4/8] net: mvmdio: move the read valid check into its own function

2017-06-08 Thread Antoine Tenart
Move the read valid check in its own function. This is needed as a requirement to factorize the driver to add the xMDIO support in the future. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvmdio.c | 11 +++ 1 file changed, 7

[PATCH 2/2] drivers: net: emac: add const to mii_phy_ops structures

2017-06-08 Thread Bhumika Goyal
The object references of mii_phy_ops structures are only stored in the ops field of a mii_phy_def structure. This ops field is of type const. So, mii_phy_ops structures having similar properties can be declared as const. Signed-off-by: Bhumika Goyal ---

[patch net-next v2 11/19] mlxsw: spectrum_switchdev: Add support for learning FDB through notification

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky Add support for learning FDB through notification. The driver defers the hardware update via ordered work queue. Support for stacked devices is also provided. In case of a successful FDB add a notification is sent back to bridge. Signed-off-by:

[patch net-next v2 00/19] Remove support from bridge bypass for mlxsw/rocker drivers

2017-06-08 Thread Jiri Pirko
From: Jiri Pirko Currently setting bridge port attributes and adding FDBs are done via setting the SELF flag which implies unconsistent offloading model. This patch-set fixes this behavior by making the bridge and drivers which are using it to be totally in sync. This implies

[patch net-next v2 05/19] net: bridge: Add support for notifying devices about FDB add/del

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky Currently the bridge doesn't notify the underlying devices about new FDBs learned. The FDB sync is placed on the switchdev notifier chain because devices may potentially learn FDB that are not directly related to their ports, for example: 1. Mixed

[patch net-next v2 10/19] mlxsw: spectrum_switchdev: Change switchdev notifier API

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky The current API for sending switchdev notifications implies only FDB add/del. In order to support notification about successful FDB offload the API is changed. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido Schimmel

[patch net-next v2 07/19] mlxsw: spectrum: Remove support for bridge FDB learning sync

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky Currently the mlxsw driver supports an option for disabling syncing the hardware learned FDBs with the software bridge. This behavior breaks the bridge offload model and thus it is removed. Signed-off-by: Arkadi Sharshevsky

[patch net-next v2 04/19] net: switchdev: Change notifier chain to be atomic

2017-06-08 Thread Jiri Pirko
From: Arkadi Sharshevsky In order to use the switchdev notifier chain for FDB sync with the device it has to be changed to atomic. The is done because the bridge can learn new FDBs in atomic context. Signed-off-by: Arkadi Sharshevsky Reviewed-by: Ido

Re: [PATCH RFC net-next 1/4] net/mlx5e: Rearrange netdevice ops structures

2017-06-08 Thread Or Gerlitz
On Thu, Jun 8, 2017 at 2:42 AM, Saeed Mahameed wrote: > Since we are going to allow compiling the driver without eswitch, > it means we will have to compile out mlx5e_netdev_ops_sriov and will > replace it with mlx5e_netdev_ops_basic. > > Move missing vxlan ndos into

[no subject]

2017-06-08 Thread Oliver Carter
Hey Netdev http://arc-protect.com/m7_gift_giver.php?isnt=pfcz272prn36hk Oliver

[PATCH v2 1/8] net: mvmdio: reorder headers alphabetically

2017-06-08 Thread Antoine Tenart
Cosmetic fix reordering headers alphabetically. Signed-off-by: Antoine Tenart Reviewed-by: Florian Fainelli --- drivers/net/ethernet/marvell/mvmdio.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v2 3/8] net: mvmdio: use GENMASK for masks

2017-06-08 Thread Antoine Tenart
Cosmetic patch to use the GENMASK helper for masks. Signed-off-by: Antoine Tenart Reviewed-by: Florian Fainelli --- drivers/net/ethernet/marvell/mvmdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 8/8] arm64: marvell: dts: add xmdio nodes for 7k/8k

2017-06-08 Thread Antoine Tenart
Add the description of the xMDIO bus for the Marvell Armada 7k and Marvell Armada 8k; for both CP110 slave and master. This bus is found on Marvell Ethernet controllers and provides an interface with the xMDIO bus. Signed-off-by: Antoine Tenart --- @Dave:

[patch net-next 3/3] mlxsw: spectrum: Pass port argument to module mapping functions

2017-06-08 Thread Jiri Pirko
From: Ido Schimmel Previous patch made it unnecessary to map ports to modules before we allocate their struct. We can now therefore pass the port struct to these functions, thereby making them consistent with other functions that operate on ports. Signed-off-by: Ido

[patch net-next 0/3] mlxsw: Remove compatibility with old firmware

2017-06-08 Thread Jiri Pirko
From: Jiri Pirko Up until recently we couldn't enforce a minimal firmware version, which forced us to be compatible with old firmware versions. This patchset removes this code and simplifies the driver. Ido Schimmel (3): mlxsw: spectrum_router: Mark only first LPM tree as

[patch net-next 2/3] mlxsw: spectrum: Simplify port split flow

2017-06-08 Thread Jiri Pirko
From: Ido Schimmel In commit be94535f9531 ("mlxsw: spectrum: Make split flow match firmware requirements") we had to modify the port split flow to overcome quirks in the device's firmware. This resulted in asymmetrical code with regards to port creation and removal. The

[patch net-next 1/3] mlxsw: spectrum_router: Mark only first LPM tree as reserved

2017-06-08 Thread Jiri Pirko
From: Ido Schimmel In new firmware versions (that we can now enforce via request_firmware()), only the first LPM tree is reserved and not the first two as in older versions. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko ---

Re: linux-next: build failure after merge of the net tree

2017-06-08 Thread Greg Kroah-Hartman
On Thu, Jun 08, 2017 at 10:08:58AM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the net tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c: In function > 'rtw_cfg80211_add_monitor_if': >

Re: [PATCH 9/9] arm64: marvell: dts: add xmdio nodes for 7k/8k

2017-06-08 Thread Gregory CLEMENT
Hi Antoine, On jeu., juin 08 2017, Antoine Tenart wrote: > Hi Gregory, > > On Wed, Jun 07, 2017 at 10:38:10AM +0200, Antoine Tenart wrote: >> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi >>

Re: [PATCH RFC net-next 3/4] net/mlx5: Separate between eswitch and MPFS l2 table logic

2017-06-08 Thread Or Gerlitz
On Thu, Jun 8, 2017 at 2:42 AM, Saeed Mahameed wrote: > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c > @@ -363,17 +364,28 @@ static void mlx5e_del_vlan_rules(struct mlx5e_priv > *priv) > static void

Re: [PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-08 Thread 严海双
> On 8 Jun 2017, at 1:00 PM, Alexei Starovoitov > wrote: > > On Thu, Jun 08, 2017 at 12:56:58PM +0800, 严海双 wrote: >> >>> On 8 Jun 2017, at 12:38 PM, Alexei Starovoitov >>> wrote: >>> >>> On Thu, Jun 08, 2017 at 12:32:44PM +0800,

Re: [linuxwifi] [PATCH] net: wireless: intel: iwlwifi: dvm: fix tid mask

2017-06-08 Thread Seraphime Kirkovski
On Thu, Jun 08, 2017 at 06:31:01AM +, Grumbach, Emmanuel wrote: > Hi, Hi, > True, OTOH we need tid to be 8 sometimes. We *just* need to make sure > that we don't index tid_data with this. Hence I think the proper fix is: > > diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/tx.c >

[PATCH] ila_xlat: add missing hash secret initialization

2017-06-08 Thread Arnd Bergmann
While discussing the possible merits of clang warning about unused initialized functions, I found one function that was clearly meant to be called but never actually is. __ila_hash_secret_init() initializes the hash value for the ila locator, apparently this is intended to prevent hash collision

Re: [PATCH net] netlink: don't send unknown nsid

2017-06-08 Thread Nicolas Dichtel
Le 07/06/2017 à 21:14, Flavio Leitner a écrit : > On Mon, Jun 05, 2017 at 10:40:24AM +0200, Nicolas Dichtel wrote: >>> Let me ask this instead: How do you think userspace should behave when >>> netnsid allocation fails? >>> >> There is two ways to assign a nsid: >> - manually with netlink ('ip

Re: [patch net-next v2 02/19] net: bridge: Add support for offloading port attributes

2017-06-08 Thread Nikolay Aleksandrov
On 08/06/17 09:44, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > Currently the flood, learning and learning_sync port attributes are > offloaded by setting the SELF flag. Add support for offloading the > flood and learning attribute through the bridge code. In case of >

Re: [patch net-next v2 05/19] net: bridge: Add support for notifying devices about FDB add/del

2017-06-08 Thread Nikolay Aleksandrov
On 08/06/17 09:44, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > Currently the bridge doesn't notify the underlying devices about new > FDBs learned. The FDB sync is placed on the switchdev notifier chain > because devices may potentially learn FDB that are not directly

Re: [PATCH RFC net-next 4/4] net/mlx5: Add CONFIG_MLX5_ESWITCH Kconfig

2017-06-08 Thread Or Gerlitz
On Thu, Jun 8, 2017 at 2:42 AM, Saeed Mahameed wrote: > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > @@ -2961,9 +2961,8 @@ static int mlx5e_modify_channels_vsd(struct > mlx5e_channels *chs, bool vsd) >

Re: ath9k_htc - Division by zero in kernel (as well as firmware panic)

2017-06-08 Thread Oleksij Rempel
Am 08.06.2017 um 00:39 schrieb Tobias Diedrich: > Oleksij Rempel wrote: >> Am 07.06.2017 um 02:12 schrieb Tobias Diedrich: >>> Oleksij Rempel wrote: Yes, this is "normal" problem. The firmware has no error handler for PCI bus related exceptions. So if we filed to read PCI bus first time,

Re: [PATCH 9/9] arm64: marvell: dts: add xmdio nodes for 7k/8k

2017-06-08 Thread Antoine Tenart
Hi Gregory, On Wed, Jun 07, 2017 at 10:38:10AM +0200, Antoine Tenart wrote: > diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi > b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi > index 2a99ff8fca2a..594356243ddb 100644 > ---

Re: [PATCH net-next 00/16] nfp: ctrl vNIC

2017-06-08 Thread Jiri Pirko
Thu, Jun 08, 2017 at 08:33:11AM CEST, yuval.mi...@cavium.com wrote: >> >> >> >> >What were your plans with pre-netdev config? >> >> >> >> >> >> >> >> We need to pass come initial resource division. Generally the >> >> >> >> consensus is to have these options exposed through devlink, let >> >> >>

Re: [patch iproute2/net-next] tc: add support for TRAP action

2017-06-08 Thread Jiri Pirko
Mon, Jun 05, 2017 at 04:39:45PM CEST, j...@resnulli.us wrote: >From: Jiri Pirko > >Signed-off-by: Jiri Pirko Stephen, note that the kernel part was accepted in v2. Thanks. >--- > include/linux/pkt_cls.h | 5 + > tc/tc_util.c| 3 +++ > 2

[PATCH net 2/3] bonding: fix 802.3ad support for 14G speed

2017-06-08 Thread Nicolas Dichtel
This patch adds 14 Gbps enum definition, and fixes aggregated bandwidth calculation based on above slave links. Fixes: 0d7e2d2166f6 ("IB/ipoib: add get_link_ksettings in ethtool") Signed-off-by: Nicolas Dichtel --- drivers/net/bonding/bond_3ad.c | 9 + 1 file

[PATCH net 1/3] bonding: fix 802.3ad support for 5G and 50G speeds

2017-06-08 Thread Nicolas Dichtel
From: Thibaut Collet This patch adds [5|50] Gbps enum definition, and fixes aggregated bandwidth calculation based on above slave links. Fixes: c9a70d43461d ("net-next: ethtool: Added port speed macros.") Signed-off-by: Thibaut Collet

[PATCH net 3/3] ethtool.h: remind to update 802.3ad when adding new speeds

2017-06-08 Thread Nicolas Dichtel
Each time a new speed is added, the bonding 802.3ad isn't updated. Add a comment to remind the developer to update this driver. Signed-off-by: Nicolas Dichtel --- include/uapi/linux/ethtool.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v3 2/2] ip6_tunnel: fix potential issue in __ip6_tnl_rcv

2017-06-08 Thread 严海双
> On 8 Jun 2017, at 9:59 PM, David Miller wrote: > > From: 严海双 > Date: Thu, 8 Jun 2017 15:33:58 +0800 > >>> On 8 Jun 2017, at 1:00 PM, Alexei Starovoitov >>> wrote: >>> >>> On Thu, Jun 08, 2017 at

Re: [PATCH net] ipv4: igmp: fix a use after free

2017-06-08 Thread Cong Wang
On Thu, Jun 8, 2017 at 1:33 PM, Eric Dumazet wrote: > I mentioned (in https://lkml.org/lkml/2017/5/31/619 ) that we might need > to defer freeing after rcu grace period but for some reason decided it > was not needed. This one makes sense, it is the second time I saw the

[PATCH net-next 5/5] nfp: report application FW build name in ethtool -i

2017-06-08 Thread Jakub Kicinski
Make sure application FW build name is NULL-terminated and print it as a part of ethtool's firmware version string. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_app.c | 8 drivers/net/ethernet/netronome/nfp/nfp_app.h

[PATCH net-next 3/5] nfp: remove automatic caching of HWInfo

2017-06-08 Thread Jakub Kicinski
Make callers take care of managing life time of HWInfo. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_app_nic.c | 2 +- drivers/net/ethernet/netronome/nfp/nfp_main.c | 20 --- drivers/net/ethernet/netronome/nfp/nfp_main.h

[PATCH net-next 1/5] nfp: make sure to cancel port refresh on the error path

2017-06-08 Thread Jakub Kicinski
If very last stages of netdev registering and init fail some other netdevs and devlink ports may have been visible to user space before we torn them back down. In this case there is a slight chance user may have triggered port refresh. We need to make sure the async work is cancelled. We have

[PATCH net-next 2/5] nfp: remove automatic caching of RTsym table

2017-06-08 Thread Jakub Kicinski
The fact that RTsym table is cached inside nfp_cpp handle is a relic of old times when nfpcore was a library module. All the nfp_cpp "caches" are awkward to deal with because of concurrency and prone to keeping stale information. Make the run time symbol table be an object read out from the

[PATCH net-next 4/5] nfp: keep MIP object around

2017-06-08 Thread Jakub Kicinski
Microcode Information Page contains some useful information, like application firmware build name. Keep it around, similar to RTSym and HWInfo. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 5 -

[PATCH net-next 0/5] nfp: FW app build name reporting

2017-06-08 Thread Jakub Kicinski
Hi! This series adds reporting FW build name in ethtool -i. Most of the patches are restructuring where information caching is done. There is also a minor error path fix. These are last few patches finishing the basic nfp_app support. Jakub Kicinski (5): nfp: make sure to cancel port

Re: [PATCH net-next 1/5] net: dsa: Remove master_netdev and use dst->cpu_dp->netdev

2017-06-08 Thread kbuild test robot
Hi Florian, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-dsa-Multi-CPU-ground-work/20170607-164203 config: x86_64-randconfig-s0-06090601 (attached as .config) compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7 reproduce: # save

[PATCH] wireless: wlcore: spi: remove unnecessary variable

2017-06-08 Thread Gustavo A. R. Silva
Remove unnecessary variable and refactor the code. Addresses-Coverity-ID: 1365000 Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ti/wlcore/spi.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ti/wlcore/spi.c

[PATCH net-next 1/2] bpf: Fix test_bpf_obj_id() when the bpf_jit_enable sysctl is diabled

2017-06-08 Thread Martin KaFai Lau
test_bpf_obj_id() should not expect a non zero jited_prog_len to be returned by bpf_obj_get_info_by_fd() when net.core.bpf_jit_enable is 0. The patch checks for net.core.bpf_jit_enable and has different expectation on jited_prog_len. This patch also removes the pwd.h header which I forgot to

[PATCH net-next 2/2] bpf: Fix test_obj_id.c for llvm 5.0

2017-06-08 Thread Martin KaFai Lau
llvm 5.0 does not like the section name and the function name to be the same: clang -I. -I./include/uapi -I../../../include/uapi \ -I../../../../samples/bpf/ \ -Wno-compare-distinct-pointer-types \ -O2 -target bpf -c \

[PATCH net-next v2] cxgb4: handle interrupt raised when FW crashes

2017-06-08 Thread Ganesh Goudar
From: Rahul Lakkireddy Handle TIMER0INT when FW crashes. Check for PCIE_FW[FW_EVAL] and if it says "Device FW Crashed", then treat it as fatal. Else, non-fatal. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar

Re: [PATCH net 2/3] bonding: fix 802.3ad support for 14G speed

2017-06-08 Thread Joe Perches
On Thu, 2017-06-08 at 11:18 +0200, Nicolas Dichtel wrote: > This patch adds 14 Gbps enum definition, and fixes > aggregated bandwidth calculation based on above slave links. Doesn't 14G need to be added to phy.c? --- diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index

[PATCH net-next v2] geneve: add missing rx stats accounting

2017-06-08 Thread Girish Moodalbail
There are few places on the receive path where packet drops and packet errors were not accounted for. This patch fixes that issue. Signed-off-by: Girish Moodalbail --- v0 -> v1: -modified to use canonical post-increment "x++" --- drivers/net/geneve.c | 36

[PATCH net-next] liquidio: disallow enabling firmware debug from a VF

2017-06-08 Thread Felix Manlunas
From: Derek Chickles Disallow enabling firmware debug from a VF. Only PF is allowed to do that. Signed-off-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_ethtool.c

Re: Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+

2017-06-08 Thread Cong Wang
On Thu, Jun 8, 2017 at 2:27 PM, Ben Greear wrote: > > As far as I can tell, the patch did not help, or at least we still reproduce > the > crash easily. netlink dump is serialized by nlk->cb_mutex so I don't think that patch makes any sense w.r.t race condition. >

Re: [PATCH net] ipv4: igmp: fix a use after free

2017-06-08 Thread Eric Dumazet
On Thu, 2017-06-08 at 17:59 -0700, Cong Wang wrote: > On Thu, Jun 8, 2017 at 1:33 PM, Eric Dumazet wrote: > > I mentioned (in https://lkml.org/lkml/2017/5/31/619 ) that we might need > > to defer freeing after rcu grace period but for some reason decided it > > was not

[PATCH] netfilter: ctnetlink: move CTA_TIMEOUT case to outside

2017-06-08 Thread Haishuang Yan
When cda[CTA_TIMEOUT] is zero, ctnetlink_new_conntrack will free allocated ct and return, so move it to outside to optimize this situation. Signed-off-by: Haishuang Yan --- net/netfilter/nf_conntrack_netlink.c | 5 + 1 file changed, 1 insertion(+), 4

Re: [PATCH RFC net-next 3/4] net/mlx5: Separate between eswitch and MPFS l2 table logic

2017-06-08 Thread Or Gerlitz
On Thu, Jun 8, 2017 at 1:26 PM, Saeed Mahameed wrote: > On Thu, Jun 8, 2017 at 12:13 PM, Or Gerlitz wrote: >>> +int mlx5_mpfs_add_mac(struct mlx5_core_dev *dev, u8 *mac) >>> +{ >> >>> + if (!MLX5_VPORT_MANAGER(dev)) >>> +

RE: [PATCH v2 4/4] net: macb: Add hardware PTP support

2017-06-08 Thread Rafal Ozieblo
> From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: 7 czerwca 2017 15:28 > To: Rafal Ozieblo > Cc: David Miller ; nicolas.fe...@atmel.com; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > devicet...@vger.kernel.org;

[PATCH 07/44] xen-swiotlb: consolidate xen_swiotlb_dma_ops

2017-06-08 Thread Christoph Hellwig
ARM and x86 had duplicated versions of the dma_ops structure, the only difference is that x86 hasn't wired up the set_dma_mask, mmap, and get_sgtable ops yet. On x86 all of them are identical to the generic version, so they aren't needed but harmless. All the symbols used only for

[PATCH 06/44] iommu/dma: don't rely on DMA_ERROR_CODE

2017-06-08 Thread Christoph Hellwig
DMA_ERROR_CODE is not a public API and will go away soon. dma dma-iommu driver already implements a proper ->mapping_error method, so it's only using the value internally. Add a new local define using the value that arm64 which is the only current user of dma-iommu. Signed-off-by: Christoph

[PATCH 23/44] x86/calgary: implement ->mapping_error

2017-06-08 Thread Christoph Hellwig
DMA_ERROR_CODE is going to go away, so don't rely on it. Signed-off-by: Christoph Hellwig --- arch/x86/kernel/pci-calgary_64.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/arch/x86/kernel/pci-calgary_64.c

[PATCH 18/44] iommu/amd: implement ->mapping_error

2017-06-08 Thread Christoph Hellwig
DMA_ERROR_CODE is going to go away, so don't rely on it. Signed-off-by: Christoph Hellwig --- drivers/iommu/amd_iommu.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index

[PATCH 24/44] x86: remove DMA_ERROR_CODE

2017-06-08 Thread Christoph Hellwig
All dma_map_ops instances now handle their errors through ->mapping_error. Signed-off-by: Christoph Hellwig --- arch/x86/include/asm/dma-mapping.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/include/asm/dma-mapping.h b/arch/x86/include/asm/dma-mapping.h index

[PATCH 08/44] xen-swiotlb: implement ->mapping_error

2017-06-08 Thread Christoph Hellwig
DMA_ERROR_CODE is going to go away, so don't rely on it. Signed-off-by: Christoph Hellwig --- drivers/xen/swiotlb-xen.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index

[PATCH 15/44] xtensa: remove DMA_ERROR_CODE

2017-06-08 Thread Christoph Hellwig
xtensa already implements the mapping_error method for its only dma_map_ops instance. Signed-off-by: Christoph Hellwig --- arch/xtensa/include/asm/dma-mapping.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/xtensa/include/asm/dma-mapping.h

  1   2   3   4   >