[PATCH net] net/act_pedit: fix an error code

2017-06-14 Thread Dan Carpenter
I'm reviewing static checker warnings where we do ERR_PTR(0), which is the same as NULL. I'm pretty sure we intended to return ERR_PTR(-EINVAL) here. Sometimes these bugs lead to a NULL dereference but I don't immediately see that problem here. Fixes: 71d0ed7079df ("net/act_pedit: Support using

Re: Re: [PATCH] mwifiex: fixes the trivial print

2017-06-14 Thread Xinming Hu
Hi Caesar, It proved to be a feature to get better scan result from overlapping channel, introduced in commit 1b499cb72f26bbf44f2fa158c2d1487730aae96a Author: Amitkumar Karwar Date: Sun Apr 24 23:49:51 2016 -0700 mwifiex: disable channel filtering feature in

WARNING: CPU: 0 PID: 0 at net/sched/sch_generic.c:316 dev_watchdog

2017-06-14 Thread Borislav Petkov
Hi, when I run a small CPU hotplugging script while I'm logged into the machine over ssh, I see the dev watchdog timeout below. Driver is e1000e. After the eth0 reset, I ifdown/ifup the eth0 interface and it comes back up again just fine. Any ideas? Kernel is -rc5 + tip/master. ... [

Re: [B.A.T.M.A.N.] Odd use of %14pM in net/batman-adv/distributed-arp-table.c

2017-06-14 Thread Sven Eckelmann
On Dienstag, 13. Juni 2017 14:51:41 CEST Joe Perches wrote: > An output mac address is 17 bytes [...] > but in net/batman-adv/distributed-arp-table.c [...] > %14pM is odd as this should not emit the last byte of the > mac address. So given the example above, it would output > 00:11:22:33:44 [...]

[PATCH net-next] net: use skb_unref() in napi_consume_skb()

2017-06-14 Thread Paolo Abeni
The commit 83ada39bb79d ("net: factor out a helper to decrement the skb refcount") provided and used a helper for decrementing skb usage, but I missed at least a spot for it. This change remove some more duplicated code reusing skb_unref() in napi_consume_skb(), too. The helper uses an

Re: [PATCH v2 0/5] MIPS: Implement eBPF JIT.

2017-06-14 Thread Ralf Baechle
On Tue, Jun 13, 2017 at 03:28:42PM -0700, David Daney wrote: > Changes in v2: > > - Squash a couple of the uasm cleanups. > > - Make insn_table_MM const (suggested by Matt Redfearn) > > - Put the eBPF in its own source file (should fix build > warnings/errors on 32-bit kernel

pull request: bluetooth-next 2017-06-14

2017-06-14 Thread Johan Hedberg
Hi Dave, Here's another batch of Bluetooth patches for the 4.13 kernel: - Fix for Broadcom controllers not supporting Event Mask Page 2 - New QCA ROME USB ID for btusb - Fix for Security Manager Protocol to use constant-time memcmp - Improved support for TI WiLink chips Please let me know

[PATCH] batman-adv: Remove unnecessary length qualifier in %14pM

2017-06-14 Thread Joe Perches
It's misleading and unnecessary. Signed-off-by: Joe Perches --- net/batman-adv/distributed-arp-table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c index

Re: [B.A.T.M.A.N.] Odd use of %14pM in net/batman-adv/distributed-arp-table.c

2017-06-14 Thread Joe Perches
On Wed, 2017-06-14 at 10:23 +0200, Sven Eckelmann wrote: > On Dienstag, 13. Juni 2017 14:51:41 CEST Joe Perches wrote: > > An output mac address is 17 bytes > > [...] > > but in net/batman-adv/distributed-arp-table.c > > [...] > > %14pM is odd as this should not emit the last byte of the > > mac

Re: [PATCH nf-next] netns: add and use net_ns_barrier

2017-06-14 Thread Pablo Neira Ayuso
Hi! On Tue, Jun 13, 2017 at 09:35:20AM -0700, Cong Wang wrote: > On Mon, Jun 12, 2017 at 11:16 PM, Florian Westphal wrote: > > Cong Wang wrote: > >> On Thu, Jun 1, 2017 at 1:52 AM, Florian Westphal wrote: > >> > Joe described it nicely,

RE: [PATCH net-next] qed: Fix an off by one bug

2017-06-14 Thread Mintz, Yuval
> The p_l2_info->pp_qid_usage[] array has "p_l2_info->queues" elements so > the > here should be a >= or we write beyond the end of the array. > > Fixes: bbe3f233ec5e ("qed: Assign a unique per-queue index to queue-cid") > Signed-off-by: Dan Carpenter While it's a

Re: [PATCH 21/44] powerpc: implement ->mapping_error

2017-06-14 Thread Michael Ellerman
Christoph Hellwig writes: > DMA_ERROR_CODE is going to go away, so don't rely on it. Instead > define a ->mapping_error method for all IOMMU based dma operation > instances. The direct ops don't ever return an error and don't > need a ->mapping_error method. > > Signed-off-by:

[PATCH net-next] qed: Fix an off by one bug

2017-06-14 Thread Dan Carpenter
The p_l2_info->pp_qid_usage[] array has "p_l2_info->queues" elements so the > here should be a >= or we write beyond the end of the array. Fixes: bbe3f233ec5e ("qed: Assign a unique per-queue index to queue-cid") Signed-off-by: Dan Carpenter diff --git

Re: [PATCH 03/44] dmaengine: ioat: don't use DMA_ERROR_CODE

2017-06-14 Thread Vinod Koul
On Thu, Jun 08, 2017 at 03:25:28PM +0200, Christoph Hellwig wrote: > DMA_ERROR_CODE is not a public API and will go away. Instead properly > unwind based on the loop counter. Acked-By: Vinod Koul -- ~Vinod

[PATCH] netfilter: conntrack: fix clash resolution in nat

2017-06-14 Thread Haishuang Yan
In our openstack environment, slow dns lookup for hostname when parallel dns requests for IPv4 and IPv6 addresses from VM, the second IPv6 request( record) is dropped on its way in compute node. We found many similar related links: https://bbs.archlinux.org/viewtopic.php?id=75770

RE: [PATCH net-next 1/9] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-14 Thread Mintz, Yuval
> > > +static void hns3_nic_net_down(struct net_device *ndev) { > > > + struct hns3_nic_priv *priv = netdev_priv(ndev); > > > + struct hnae3_ae_ops *ops; > > > + int i; > > > + > > > + netif_tx_stop_all_queues(ndev); > > > + netif_carrier_off(ndev); > > > + netif_tx_disable(ndev); > > > + > > > +

Re: [PATCH net-next 2/3] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-14 Thread Nicolas Dichtel
Le 13/06/2017 à 19:08, Julien Gomes a écrit : > Add Netlink notifications on cache reports in ipmr, in addition to the > existing igmpmsg sent to mroute_sk. > Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE. > > MSGTYPE, VIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the >

[patch net-next 1/2] mlxsw: reg: Add MCIA register for cable info access

2017-06-14 Thread Jiri Pirko
From: Arkadi Sharshevsky The MCIA register is used to access the SFP+ and QSFP connector's EPROM. It will be used to query the cable info. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko ---

[patch net-next 2/2] mlxsw: spectrum: Add support for access cable info via ethtool

2017-06-14 Thread Jiri Pirko
From: Arkadi Sharshevsky Add support for access cable info via ethtool. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 131 + 1 file

[patch net-next 0/2] mlxsw: Add support for cable info access

2017-06-14 Thread Jiri Pirko
From: Jiri Pirko Add support for cable info access via ethtool. This is done by accessing the SFP+/QSFP internal EEPROM. Arkadi Sharshevsky (2): mlxsw: reg: Add MCIA register for cable info access mlxsw: spectrum: Add support for access cable info via ethtool

Re: [PATCH net-next 1/2] pktgen: Specify num packets per thread

2017-06-14 Thread Jesper Dangaard Brouer
On Tue, 13 Jun 2017 18:04:48 +0300 Tariq Toukan wrote: > Use -n , to specify the number of packets every > thread sends. > Zero means indefinitely. > > Signed-off-by: Tariq Toukan > Cc: Jesper Dangaard Brouer Patch 1/2 looks good

[PATCH] net: update undefined ->ndo_change_mtu() comment

2017-06-14 Thread Magnus Damm
From: Magnus Damm Update ->ndo_change_mtu() callback comment to remove text about returning error in case of undefined callback. This change makes the comment match the existing code behavior. Signed-off-by: Magnus Damm --- Applies on

Re: [PATCH net-next 2/2] pktgen: Specify the index of first thread

2017-06-14 Thread Jesper Dangaard Brouer
On Tue, 13 Jun 2017 18:04:49 +0300 Tariq Toukan wrote: > Use "-f ", to specify the index of the first > sender thread. > In default first thread is #0. > > Signed-off-by: Tariq Toukan > Cc: Jesper Dangaard Brouer > --- >

Re: kernel BUG at net/ipv4/tcp_output.c:2748!

2017-06-14 Thread Dison River
Hi: I tested the PoC on v3.18 ~ v4.11,all the kenel have crashed.But,The v4.12-rc4 version is not affected thanks. 2017-06-13 21:02 GMT+08:00 Greg KH : > On Tue, Jun 13, 2017 at 07:39:00PM +0800, Dison River wrote: >> Hi >>I've got the following error report while fuzzing the

Re: [PATCH] via-rhine: add support for changing MTU

2017-06-14 Thread Magnus Damm
On Wed, Jun 14, 2017 at 6:33 AM, David Miller wrote: > From: Magnus Damm > Date: Wed, 14 Jun 2017 02:18:27 +0900 > >> From: Magnus Damm >> >> Allow adjusting the MTU for via-rhine devices in case of no TX alignment >>

<    1   2   3