Re: [kbuild-all] [PATCH net-next] networking: use skb_put_zero()

2017-06-16 Thread Johannes Berg
On Fri, 2017-06-16 at 16:30 +0800, Ye Xiaolong wrote: > Hi, David > > On 06/13, David Miller wrote: > > > > These are bogus reports I think. > > > > Johannes's changes depends upon the wireless GIT tree I pulled in > > right before I applied his patch. > > Did you applied the patch on top of ma

Re: [PATCH 33/44] openrisc: remove arch-specific dma_supported implementation

2017-06-16 Thread Christoph Hellwig
On Fri, Jun 09, 2017 at 02:20:42PM +0200, Geert Uytterhoeven wrote: > Hi Christoph, > > On Thu, Jun 8, 2017 at 3:25 PM, Christoph Hellwig wrote: > > This implementation is simply bogus - hexagon only has a simple > > openrisc? Yeah.

Re: [PATCH 06/44] iommu/dma: don't rely on DMA_ERROR_CODE

2017-06-16 Thread Christoph Hellwig
On Thu, Jun 08, 2017 at 02:59:07PM +0100, Robin Murphy wrote: > Hi Christoph, > > On 08/06/17 14:25, Christoph Hellwig wrote: > > DMA_ERROR_CODE is not a public API and will go away soon. dma dma-iommu > > driver already implements a proper ->mapping_error method, so it's only > > using the value

Re: [kbuild-all] [PATCH net-next] networking: use skb_put_zero()

2017-06-16 Thread Ye Xiaolong
Hi, David On 06/13, David Miller wrote: > >These are bogus reports I think. > >Johannes's changes depends upon the wireless GIT tree I pulled in >right before I applied his patch. Did you applied the patch on top of master branch? Thanks, Xiaolong >__

Re: [RFC 1/3] networking: make skb_put & friends return void pointers

2017-06-16 Thread Bjørn Mork
Johannes Berg writes: > From: Johannes Berg > > It seems like a historic accident that these return unsigned char *, > and in many places that means casts are required, more often than not. > > Make these functions (skb_put, __skb_put and pskb_put) return void * > and remove all the casts across

Request for -stable inclusion (xt_TCPMSS)

2017-06-16 Thread Guillaume Nault
Hi David, Please queue 2638fd0f92d4 ("netfilter: xt_TCPMSS: add more sanity tests on tcph->doff") for -stable. It fixes hard to debug crashes in production, that can be triggered by remote peers. Regards, Guillaume

[PATCH 05/11] serial/mpsc: switch to dma_alloc_attrs

2017-06-16 Thread Christoph Hellwig
Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent wrapper. Signed-off-by: Christoph Hellwig --- drivers/tty/serial/mpsc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/mpsc.c b/drivers/tty/serial/mpsc.c index 1a60a2063e75..67ffe

[PATCH 08/11] sgiseeq: switch to dma_alloc_attrs

2017-06-16 Thread Christoph Hellwig
Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent wrapper. Signed-off-by: Christoph Hellwig --- drivers/net/ethernet/seeq/sgiseeq.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/seeq/sgiseeq.c b/drivers/net/ethernet/seeq/sgiseeq

[PATCH 07/11] 53c700: switch to dma_alloc_attrs

2017-06-16 Thread Christoph Hellwig
Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent wrapper. Signed-off-by: Christoph Hellwig --- drivers/scsi/53c700.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c index 95e32a47face..4b3b08025ef6 100644

[PATCH 06/11] sigwd93: switch to dma_alloc_attrs

2017-06-16 Thread Christoph Hellwig
Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent wrapper. Signed-off-by: Christoph Hellwig --- drivers/scsi/sgiwd93.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/sgiwd93.c b/drivers/scsi/sgiwd93.c index 71b4b91d2215..80cfa93e407c 1

pull-request: mac80211 2017-06-16

2017-06-16 Thread Johannes Berg
Hi Dave, Here I just have the cleanups with the fix for that ancient bug I sent the RFC patches for. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit c5549ee40112f2511a794c9aad7eb6ac5f18b0eb: Merge tag 'mac80211-for-davem-2017-06-13' o

[PATCH 09/11] au1000_eth: switch to dma_alloc_attrs

2017-06-16 Thread Christoph Hellwig
Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent wrapper. Signed-off-by: Christoph Hellwig --- drivers/net/ethernet/amd/au1000_eth.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/amd/au1000_eth.c b/drivers/net/ether

[PATCH 04/11] sound/hal2: switch to dma_alloc_attrs

2017-06-16 Thread Christoph Hellwig
Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent wrapper. Signed-off-by: Christoph Hellwig --- sound/mips/hal2.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/sound/mips/hal2.c b/sound/mips/hal2.c index 00fc9241d266..17a78a93e885 1006

[PATCH 03/11] au1100fb: remove a bogus dma_free_nonconsistent call

2017-06-16 Thread Christoph Hellwig
au1100fb is using managed dma allocations, so it doesn't need to explicitly free the dma memory in the error path (and if it did it would have to use the managed version). Signed-off-by: Christoph Hellwig --- drivers/video/fbdev/au1100fb.c | 4 1 file changed, 4 deletions(-) diff --git a/d

[PATCH 10/11] i825xx: switch to switch to dma_alloc_attrs

2017-06-16 Thread Christoph Hellwig
This way we can always pass DMA_ATTR_NON_CONSISTENT, the SNI mips version will simply ignore the flag. Signed-off-by: Christoph Hellwig --- drivers/net/ethernet/i825xx/lasi_82596.c | 6 ++ drivers/net/ethernet/i825xx/lib82596.c | 9 + drivers/net/ethernet/i825xx/sni_82596.c | 6 ++

[PATCH 11/11] dma-mapping: remove dma_alloc_noncoherent and dma_free_noncoherent

2017-06-16 Thread Christoph Hellwig
No users left, everyone switched to the _attrs versions. Signed-off-by: Christoph Hellwig --- Documentation/DMA-API.txt| 30 -- arch/metag/include/asm/dma-mapping.h | 2 +- arch/nios2/include/asm/dma-mapping.h | 2 +- arch/tile/include/asm/dma-mapping.h

[PATCH 01/11] dma-mapping: remove dmam_free_noncoherent

2017-06-16 Thread Christoph Hellwig
This function was never used since it was added. Signed-off-by: Christoph Hellwig --- Documentation/driver-model/devres.txt | 1 - drivers/base/dma-mapping.c| 20 include/linux/dma-mapping.h | 2 -- 3 files changed, 23 deletions(-) diff --git a/Docum

[PATCH 02/11] dma-mapping: replace dmam_alloc_noncoherent with dmam_alloc_attrs

2017-06-16 Thread Christoph Hellwig
dmam_alloc_noncoherent is a trivial wrapper around dmam_alloc_attrs, that hardcodes one particular flag. Make the devres code more flexible by allowing the callers to pass arbitrary flags. Signed-off-by: Christoph Hellwig --- Documentation/driver-model/devres.txt | 2 +- drivers/base/dma-mappi

remove dma_alloc_noncoherent

2017-06-16 Thread Christoph Hellwig
For many years we've had the dma_alloc_attrs API that is more flexible than dma_alloc_noncoherent. This series moves the remaining users over to the attrs API.

[PATCH 1/5] networking: convert many more places to skb_put_zero()

2017-06-16 Thread Johannes Berg
From: Johannes Berg There were many places that my previous spatch didn't find, as pointed out by yuan linyu in various patches. The following spatch found many more and also removes the now unnecessary casts: @@ identifier p, p2; expression len; expression skb; type t, t2;

[PATCH 0/5] skb data accessors cleanup

2017-06-16 Thread Johannes Berg
Hi, Over night, Fengguang's bot told me that it compiled all of its many various configurations successfully, and I had done allyesconfig on x86_64 myself yesterday to iron out the things I missed. So now I think I'm happy with it. My tree was based on your commit 3715c47bcda8bb56f7e2be2727

[PATCH 5/5] networking: make skb_push & __skb_push return void pointers

2017-06-16 Thread Johannes Berg
From: Johannes Berg It seems like a historic accident that these return unsigned char *, and in many places that means casts are required, more often than not. Make these functions return void * and remove all the casts across the tree, adding a (u8 *) cast only where the unsigned char pointer w

[PATCH 4/5] networking: make skb_pull & friends return void pointers

2017-06-16 Thread Johannes Berg
From: Johannes Berg It seems like a historic accident that these return unsigned char *, and in many places that means casts are required, more often than not. Make these functions return void * and remove all the casts across the tree, adding a (u8 *) cast only where the unsigned char pointer w

[PATCH net] net: 8021q: Fix one possible panic caused by BUG_ON in free_netdev

2017-06-16 Thread gfree . wind
From: Gao Feng The register_vlan_device would invoke free_netdev directly, when register_vlan_dev failed. It would trigger the BUG_ON in free_netdev if the dev was already registered. In this case, the netdev would be freed in netdev_run_todo later. So add one condition check now. Only when dev

<    1   2   3