Re: [PATCH] net: intel: e1000e: add check on e1e_wphy() return value

2017-06-20 Thread Ethan Zhao
Gustavo, The return value of ret_val seems used to check if the access to PHY/NVM got its semaphore, generally speaking, it is needed for every PHY access of this driver. Reviewed-by: Ethan Zhao On Wed, Jun 21, 2017 at 5:22 AM, Gustavo A. R. Silva

Re: Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+

2017-06-20 Thread David Ahern
On 6/20/17 5:41 PM, Ben Greear wrote: > On 06/20/2017 11:05 AM, Michal Kubecek wrote: >> On Tue, Jun 20, 2017 at 07:12:27AM -0700, Ben Greear wrote: >>> On 06/14/2017 03:25 PM, David Ahern wrote: On 6/14/17 4:23 PM, Ben Greear wrote: > On 06/13/2017 07:27 PM, David Ahern wrote: >

Investment portfolio

2017-06-20 Thread HDD Investment Co.
Hello, How are you today? we have the financial capability to finance any investment portfolio as far as is genuine, all we need is a capable business partner that possesses investment strategies or profitable business information for good turn over within 10-20years. We can provide proof of

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Russell King - ARM Linux
On Wed, Jun 21, 2017 at 12:00:30AM +0200, Thomas Gleixner wrote: > Yes, but there are still quite some issues to solve there: > > 1) How do you tell the system that it should apply the offset in the > first place, i.e at boot time before NTP or any other mechanism can > correct

linux-next: manual merge of the net-next tree with the net tree

2017-06-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/core/rtnetlink.c between commit: db833d40ad32 ("rtnetlink: add IFLA_GROUP to ifla_policy") from the net tree and commit: 3d3ea5af5c0b ("rtnl: Add support for netdev event to link messages") from the net-next

linux-next: manual merge of the net-next tree with the pci tree

2017-06-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/wireless/marvell/mwifiex/pcie.c between commit: c336cc0ee4eb ("PCI: Split ->reset_notify() method into ->reset_prepare() and ->reset_done()") from the pci tree and commit: 68efd0386988 ("mwifiex:

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread l00371289
Hi, Andrew On 2017/6/20 21:27, Andrew Lunn wrote: > On Tue, Jun 20, 2017 at 11:05:54AM +0800, l00371289 wrote: >> hi, Florian >> >> On 2017/6/20 5:00, Florian Fainelli wrote: >>> On 06/16/2017 02:24 AM, Lin Yun Sheng wrote: This patch fixes the phy loopback self_test failed issue. when

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread l00371289
Hi, Andrew On 2017/6/21 11:13, Andrew Lunn wrote: > On Wed, Jun 21, 2017 at 10:03:29AM +0800, l00371289 wrote: >> Hi, Andrew >> >> On 2017/6/20 21:27, Andrew Lunn wrote: >>> On Tue, Jun 20, 2017 at 11:05:54AM +0800, l00371289 wrote: hi, Florian On 2017/6/20 5:00, Florian Fainelli

[net-next 09/15] i40e: Add message for unsupported MFP mode

2017-06-20 Thread Jeff Kirsher
From: Carolyn Wyborny This patch adds a check and message if the device is in MFP mode as changing RSS input set is not supported in MFP mode. Signed-off-by: Carolyn Wyborny Tested-by: Andrew Bowers Signed-off-by:

[net-next 14/15] i40e: Handle PE_CRITERR properly with IWARP enabled

2017-06-20 Thread Jeff Kirsher
From: Catherine Sullivan When IWARP is enabled, we weren't clearing the PE_CRITERR, just logging it and removing it from the mask. We need to do a corer to reset the PE_CRITERR register, so set the bit for that as we handle the interrupt. We should also be checking

[net-next 07/15] i40e: Fix potential out of bound array access

2017-06-20 Thread Jeff Kirsher
From: Sudheer Mogilappagari This is a fix for the static code analysis issue where dcbcfg->numapps could be greater than size of array (i.e dcbcfg->app[I40E_DCBX_MAX_APPS]). The fix makes sure that the array is not accessed past the size of of the array (i.e.

[net-next 15/15] i40e: don't hold RTNL lock for the entire reset

2017-06-20 Thread Jeff Kirsher
From: Jacob Keller We recently refactored i40e_do_reset() and its friends to be able to hold the RTNL lock only for the portions that actually need to be protected. However, a separate refactoring added several new callers of these functions during the PCIe error

[net-next 02/15] i40e: add support for XDP_TX action

2017-06-20 Thread Jeff Kirsher
From: Björn Töpel This patch adds proper XDP_TX action support. For each Tx ring, an additional XDP Tx ring is allocated and setup. This version does the DMA mapping in the fast-path, which will penalize performance for IOMMU enabled systems. Further, debugfs support is

[net-next 12/15] i40e: fix disabling overflow promiscuous mode

2017-06-20 Thread Jeff Kirsher
From: Alan Brady There exists a bug in which the driver does not correctly exit overflow promiscuous mode. This can occur if "too many" mac filters are added, putting the driver into overflow promiscuous mode, and the filters are then removed. When the failed filters are

[net-next 10/15] i40e: genericize the partition bandwidth control

2017-06-20 Thread Jeff Kirsher
From: Shannon Nelson Partition bandwidth control is not in just one form of MFP (multi-function partitioning), so make the code more generic and be sure to nudge the Tx scheduler for all MFP. Copyright updated to 2017. Signed-off-by: Shannon Nelson

[net-next 08/15] i40e: Support firmware CEE DCB UP to TC map re-definition

2017-06-20 Thread Jeff Kirsher
From: Greg Bowers Changes parsing of FW 4.33 AQ command Get CEE DCBX OPER CFG (0x0A07). Change is required because FW now creates the oper_prio_tc nibbles reversed from those in the CEE Priority Group sub-TLV. This change will only apply to FW 4.33 as future FW

[net-next 13/15] i40e: clear only cause_ena bit

2017-06-20 Thread Jeff Kirsher
From: Shannon Nelson When disabling interrupts, we should only be clearing the CAUSE_ENA bit, not clearing the whole register. Clearing the whole register sets the NEXTQ_IDX field to 0 instead of 0x7ff which can confuse the Firmware in some reset sequences.

[net-next 05/15] i40e: use dev_dbg instead of dev_info when warning about missing routine

2017-06-20 Thread Jeff Kirsher
From: Jacob Keller When searching for the vf_capability client routine, dev_info() was used, instead of the normal dev_dbg(). This causes the message to be displayed at standard log levels which can cause administrators to worry. Avoid this by using dev_dbg instead.

[net-next 04/15] i40e/i40evf: update WOL and I40E_AQC_ADDR_VALID_MASK flags

2017-06-20 Thread Jeff Kirsher
From: Alice Michael Update a few flags related to FW interactions. Copyright updated to 2017. Signed-off-by: Alice Michael Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 03/15] i40evf: assign num_active_queues inside i40evf_alloc_queues

2017-06-20 Thread Jeff Kirsher
From: Jacob Keller The variable num_active_queues represents the number of active queues we have for the device. We assign this pretty early in i40evf_init_subtask. Several code locations are written with loops over the tx_rings and rx_rings structures, which don't get

[net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2017-06-20

2017-06-20 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Björn adds additional XDP support for i40e, by adding pass and drop actions and XDP_TX action support. Jake fixes a possible NULL pointer dereference in i40evf_get_ethtool_stats() which could occur if the VF fails to recover from a reset, and

[net-next 11/15] i40e: Add support for OEM firmware version

2017-06-20 Thread Jeff Kirsher
From: Filip Sadowski This patch adds support for OEM firmware version. If OEM specific adapter is detected ethtool reports OEM product version in firmware version string instead of etrack id. Signed-off-by: Filip Sadowski Tested-by: Andrew

[net-next 06/15] i40e: comment that udp_port must be in host byte order

2017-06-20 Thread Jeff Kirsher
From: Jacob Keller The firmware expects the port number passed when setting up the UDP tunnel configuration to be in Little Endian format. The i40e_aq_add_udp_tunnel command byte swaps the value from host order to Little Endian. Since commit fe0b0cd97b4f ("i40e: send

Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread David Miller
From: Felix Manlunas Date: Tue, 20 Jun 2017 13:51:25 -0700 > From: Derek Chickles > Date: Tue, 20 Jun 2017 13:15:34 -0700 > >> > From: David Miller [mailto:da...@davemloft.net] >> > Sent: Tuesday, June 20, 2017 12:22 PM >> > >> > From:

[PATCH] PATCH v3 Convert multiple netdev_info messages to netdev_dbg

2017-06-20 Thread Michael J Dilmore
The bond_options.c file contains multiple netdev_info messages that clutter kernel output. This patches replaces these with netdev_dbg messages and adds a netdev_dbg for packets for slave. Signed-off-by: Michael J Dilmore Suggested-by: Joe Perches

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread Andrew Lunn
On Wed, Jun 21, 2017 at 10:03:29AM +0800, l00371289 wrote: > Hi, Andrew > > On 2017/6/20 21:27, Andrew Lunn wrote: > > On Tue, Jun 20, 2017 at 11:05:54AM +0800, l00371289 wrote: > >> hi, Florian > >> > >> On 2017/6/20 5:00, Florian Fainelli wrote: > >>> On 06/16/2017 02:24 AM, Lin Yun Sheng

[PATCH net-next] Add a tcp_filter hook before handle ack packet

2017-06-20 Thread Chenbo Feng
From: Chenbo Feng Currently in both ipv4 and ipv6 code path, the ack packet received when sk at TCP_NEW_SYN_RECV state is not filtered by socket filter or cgroup filter since it is handled from tcp_child_process and never reaches the tcp_filter inside tcp_v4_rcv or tcp_v6_rcv.

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread l00371289
Hi, Andrew On 2017/6/20 21:28, Andrew Lunn wrote: The question really is, why is not this properly integrated into the PHY driver and PHYLIB such that the only thing the Ethernet MAC driver has to call is a function of the PHY driver putting it in self-test? >>> >>> This whole

Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread Felix Manlunas
From: David Miller Date: Tue, 20 Jun 2017 21:17:13 -0400 > From: Felix Manlunas > Date: Tue, 20 Jun 2017 13:51:25 -0700 > > > From: Derek Chickles > > Date: Tue, 20 Jun 2017 13:15:34 -0700 > > > >> > From: David

Re: [Patch net] ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER

2017-06-20 Thread jeffy
Hi Cong Wang, i don't know much about net core, maybe i'm misreading the code...but On 06/21/2017 02:42 AM, Cong Wang wrote: In commit 242d3a49a2a1 ("ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf") I assumed NETDEV_REGISTER and NETDEV_UNREGISTER are paired, unfortunately, as

Re: [Patch net] ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER

2017-06-20 Thread jeffy
Hi Cong Wang, oh, oops, i did misread. also, Tested-by: Jeffy Chen On 06/21/2017 11:01 AM, jeffy wrote: Hi Cong Wang, i don't know much about net core, maybe i'm misreading the code...but On 06/21/2017 02:42 AM, Cong Wang wrote: In commit 242d3a49a2a1 ("ipv6:

Re: [Patch net] ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER

2017-06-20 Thread David Ahern
On 6/20/17 2:42 PM, Cong Wang wrote: > In commit 242d3a49a2a1 ("ipv6: reorder ip6_route_dev_notifier after > ipv6_dev_notf") > I assumed NETDEV_REGISTER and NETDEV_UNREGISTER are paired, > unfortunately, as reported by jeffy, netdev_wait_allrefs() > could rebroadcast NETDEV_UNREGISTER event until

Re: [PATCH] [PATCH v2 net-next] bonding: Convert multiple netdev_info messages to netdev_dbg

2017-06-20 Thread Joe Perches
On Tue, 2017-06-20 at 23:05 +0100, Michael J Dilmore wrote: > The bond_options.c file contains several netdev_info messages that clutter > kernel output. This patch changes all netdev_info messages > to netdev_dbg and adds a netdev debug for the packets per slave parameter. Hey Michael. You

[net-next 01/15] i40e: add XDP support for pass and drop actions

2017-06-20 Thread Jeff Kirsher
From: Björn Töpel This commit adds basic XDP support for i40e derived NICs. All XDP actions will end up in XDP_DROP. Signed-off-by: Björn Töpel Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[PATCH net-next] r8152: correct the definition

2017-06-20 Thread Hayes Wang
Replace VLAN_HLEN and CRC_SIZE with ETH_FCS_LEN. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 8bc4573..6cfffef

[PATCH] cfg80211: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'

2017-06-20 Thread Christophe JAILLET
If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error handling path to free it in such a case. Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload support") Signed-off-by: Christophe JAILLET ---

Re: [PATCH] cfg80211: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'

2017-06-20 Thread Kalle Valo
Christophe JAILLET writes: > If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error > handling path to free it in such a case. > > Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload support") > Signed-off-by: Christophe JAILLET

Re: [PATCH net-next] net/mlx4_en: don't set CHECKSUM_COMPLETE on SCTP packets

2017-06-20 Thread Tariq Toukan
On 19/06/2017 8:04 PM, Davide Caratti wrote: hello Tariq, On Sun, 2017-06-18 at 14:10 +0300, Tariq Toukan wrote: @@ -624,12 +632,13 @@ static int check_csum(struct mlx4_cqe *cqe, struct sk_buff *skb, void *va, hdr += sizeof(struct vlan_hdr); } - if

[PATCH net-next] sctp: uncork the old asoc before changing to the new one

2017-06-20 Thread Xin Long
local_cork is used to decide if it should uncork asoc outq after processing some cmds, and it is set when replying or sending msgs. local_cork should always have the same value with current asoc q->cork in some way. The thing is when changing to a new asoc by cmd SET_ASOC, local_cork may not be

Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

2017-06-20 Thread Daniel Vetter
On Wed, Jun 07, 2017 at 01:07:33AM +, Brown, Aaron F wrote: > > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > > Of Jeff Kirsher > > Sent: Tuesday, June 6, 2017 1:46 PM > > To: David Miller ; Nikula, Jani > > > > Cc:

Re: [PATCH net-next v2 2/4] rtnetlink: add restricted rtnl groups for ipv4 and ipv6 mroute

2017-06-20 Thread Nikolay Aleksandrov
On 19/06/17 23:44, Julien Gomes wrote: > Add RTNLGRP_{IPV4,IPV6}_MROUTE_R as two new restricted groups for the > NETLINK_ROUTE family. > Binding to these groups specifically requires CAP_NET_ADMIN to allow > multicast of sensitive messages (e.g. mroute cache reports). > > Signed-off-by: Julien

[PATCH] rtnetlink: add IFLA_GROUP to ifla_policy

2017-06-20 Thread Serhey Popovych
Network interface groups support added while ago, however there is no IFLA_GROUP attribute description in policy and netlink message size calculations until now. Add IFLA_GROUP attribute to the policy. Fixes: cbda10fa97d7 ("net_device: add support for network device groups") Signed-off-by:

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Pavel Machek
On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > > rely on 32bits variables and that will make rtc break in y2038/2016. > > Please don't, because this hide the

Re: [PATCH net-next v2 3/4] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-20 Thread Nikolay Aleksandrov
On 19/06/17 23:44, Julien Gomes wrote: > Add Netlink notifications on cache reports in ipmr, in addition to the > existing igmpmsg sent to mroute_sk. > Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE_R. > > MSGTYPE, VIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the > same

[PATCH net] sfc: remove duplicate up_write on VF filter_sem

2017-06-20 Thread Edward Cree
Somehow two copies of the line 'up_write(>efx->filter_sem);' got into efx_ef10_sriov_set_vf_vlan(). This would put the mutex in a bad state and cause all subsequent down attempts to hang. Fixes: 671b53eec2ed ("sfc: Ensure down_write(_sem) and up_write() are matched before calling

Re: TCP Vegas per-socket alpha, beta, gamma parameters

2017-06-20 Thread Lars Erik Storbukås
On Mon, Jun 19, 2017 at 3:30 PM, Lawrence Brakmo wrote: > Hi Lars, > > You would need to modify the source code to support per connection alpha, > beta and gamma parameters. Although you can modify the parameters at runtime, > they would apply to all connections using Vegas, both

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > rely on 32bits variables and that will make rtc break in y2038/2016. Please don't, because this hide the fact that the hardware will not handle dates in y2038 anyway and

Re: [PATCH] loopback: Force LOOPBACK_IFINDEX for registration

2017-06-20 Thread Serhey Popovych
> From: Serhey Popovych > Date: Fri, 16 Jun 2017 15:10:03 +0300 > >> Now with commit 9c7dafb (net: Allow to create links with >> given ifindex) support registration of network devices >> with specific ifindex is added. >> >> We can force loopback network device index

Re: [PATCH net-next 09/10] net/mlx4_en: Replace TXBB_SIZE multiplications with shift operations

2017-06-20 Thread Tariq Toukan
On 20/06/2017 11:45 AM, David Laight wrote: From: Tariq Toukan Sent: 15 June 2017 12:36 Define LOG_TXBB_SIZE, log of TXBB_SIZE, and use it with a shift operation instead of a multiplication with TXBB_SIZE. Operations are equivalent as TXBB_SIZE is a power of two. Performance tests: Tested on

Re: [PATCH] net: introduce SO_PEERGROUPS getsockopt

2017-06-20 Thread Tom Gundersen
On Fri, Jun 16, 2017 at 10:31 PM, David Herrmann wrote: > This adds the new getsockopt(2) option SO_PEERGROUPS on SOL_SOCKET to > retrieve the auxiliary groups of the remote peer. It is designed to > naturally extend SO_PEERCRED. That is, the underlying data is from the >

ipv6: Do not leak throw route references

2017-06-20 Thread Serhey Popovych
While commit 73ba57bfae4a ("ipv6: fix backtracking for throw routes") does good job on error propagation to the fib_rules_lookup() in fib rules core framework that also corrects throw routes handling, it does not solve route reference leakage problem happened when we return -EAGAIN to the

Re: [PATCH 03/11] au1100fb: remove a bogus dma_free_nonconsistent call

2017-06-20 Thread Bartlomiej Zolnierkiewicz
On Tuesday, June 20, 2017 11:10:45 AM Christoph Hellwig wrote: > On Mon, Jun 19, 2017 at 01:15:04PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Friday, June 16, 2017 09:17:08 AM Christoph Hellwig wrote: > > > au1100fb is using managed dma allocations, so it doesn't need to > > > explicitly free

Re: [PATCH net-next 0/1] Introduction of the tc tests

2017-06-20 Thread Jamal Hadi Salim
On 17-06-20 01:40 AM, Stephen Hemminger wrote: The "Occum's razor" for deciding where tests belong should be does the test need to change to respond to kernel change? Don't want to have iproute2 tests that have if (kernel_version > ...) The suite is intended to include both forward and

Re: [PATCH] dt-bindings: net: sms911x: Add missing optional VDD regulators

2017-06-20 Thread Linus Walleij
On Mon, Jun 19, 2017 at 6:05 PM, Krzysztof Kozlowski wrote: > The lan911x family of devices require supplying from 3.3 V power > supplies (connected to VDD_IO, VDD_A and VREG_3.3 pins). The existing > driver however obtains only VDD_IO and VDD_A regulators in an optional > way

Re: [PATCH net-next v2 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

2017-06-20 Thread Nikolay Aleksandrov
On 19/06/17 23:44, Julien Gomes wrote: > Add Netlink notifications on cache reports in ip6mr, in addition to the > existing mrt6msg sent to mroute6_sk. > Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV6_MROUTE_R. > > MSGTYPE, MIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the >

[PATCH 03/51] net: broadcom: stop using rtc deprecated functions

2017-06-20 Thread Benjamin Gaignard
rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they rely on 32bits variables and that will make rtc break in y2038/2016. Stop using those two functions to safer 64bits ones. Signed-off-by: Benjamin Gaignard CC: Michael Chan

[PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Benjamin Gaignard
rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they rely on 32bits variables and that will make rtc break in y2038/2016. The goal of this series of patches is ti stop using those two functions and use instead to safer 64bits ones. It also remove change .set_mmss to set_mmss64

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 12:03:48 +0200, Alexandre Belloni wrote: > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > > rely on 32bits variables and that will make rtc break in y2038/2016. > > Please don't, because this hide

Re: [RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread Sergei Shtylyov
Hello! On 6/20/2017 11:06 AM, John Crispin wrote: RPS and probably other kernel features are currently broken on some if not all DSA devices. The root cause of this that skb_hash will call the "Is" missing between "this" and "that"? flow_disector. At this point the skb still contains the

Re: [PATCH net 1/2] xfrm6: Fix IPv6 payload_len in xfrm6_transport_finish

2017-06-20 Thread Steffen Klassert
On Mon, Jun 19, 2017 at 11:33:20AM +0300, yoss...@mellanox.com wrote: > From: Yossi Kuperman > > IPv6 payload length indicates the size of the payload, including any > extension headers. In xfrm6_transport_finish, ipv6_hdr(skb)->payload_len > is set to the payload size

[PATCH v2] brcmfmac: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'

2017-06-20 Thread Christophe JAILLET
If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error handling path to free it in such a case. Cc: sta...@vger.kernel.org Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload support") Signed-off-by: Christophe JAILLET --- v2: Add CC tag

[PATCH net-next] qede: Fix compilation without QED_RDMA

2017-06-20 Thread Yuval Mintz
From: Chad Dupuis When CONFIG_QED_RDMA isn't defined, we'd hit the following: /include/linux/qed/qede_rdma.h:84:19: warning: ‘qede_rdma_dev_add’ used but never defined [enabled by default] static inline int qede_rdma_dev_add(struct qede_dev *dev); Fixes: bbfcd1e8e167

Re: [RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread John Crispin
On 20/06/17 23:52, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 07:37:35PM +0200, John Crispin wrote: On 20/06/17 16:01, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: RPS and probably other kernel features are currently broken on some if not all DSA

RE: [PATCH net-next 09/10] net/mlx4_en: Replace TXBB_SIZE multiplications with shift operations

2017-06-20 Thread David Laight
From: Tariq Toukan > Sent: 15 June 2017 12:36 > Define LOG_TXBB_SIZE, log of TXBB_SIZE, and use it with a shift > operation instead of a multiplication with TXBB_SIZE. > Operations are equivalent as TXBB_SIZE is a power of two. > > Performance tests: > Tested on ConnectX3Pro, Intel(R) Xeon(R) CPU

[RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread John Crispin
RPS and probably other kernel features are currently broken on some if not all DSA devices. The root cause of this that skb_hash will call the flow_disector. At this point the skb still contains the magic switch header and the skb->protocol field is not set up to the correct 802.3 value yet. by

[RFC 2/2] net-next: mt7530: add nh and proto offsets to the ops struct

2017-06-20 Thread John Crispin
The MT7530 inserts the 4 magic header in between the 802.3 address and protocol field. The patch defines these header such that the flow_disector can properly parse the packet and thus allows hashing to function properly. Signed-off-by: John Crispin ---

Re: [PATCH] net: macb: add fixed-link node support

2017-06-20 Thread Michael Grzeschik
Hi Nicolas, On Mon, Jun 19, 2017 at 12:54:10PM +0200, Nicolas Ferre wrote: > Le 16/06/2017 à 10:55, Michael Grzeschik a écrit : > > In case the MACB is directly connected to a > > non-mdio PHY/device, it should be possible to provide > > a fixed link configuration in the DT. > > > >

Re: [PATCH 03/11] au1100fb: remove a bogus dma_free_nonconsistent call

2017-06-20 Thread Christoph Hellwig
On Mon, Jun 19, 2017 at 01:15:04PM +0200, Bartlomiej Zolnierkiewicz wrote: > On Friday, June 16, 2017 09:17:08 AM Christoph Hellwig wrote: > > au1100fb is using managed dma allocations, so it doesn't need to > > explicitly free the dma memory in the error path (and if it did > > it would have to

[PATCH net] dccp: call inet_add_protocol after register_pernet_subsys in dccp_v6_init

2017-06-20 Thread Xin Long
Patch "call inet_add_protocol after register_pernet_subsys in dccp_v4_init" fixed a null pointer dereference issue for dccp_ipv4 module. The same fix is needed for dccp_ipv6 module. Signed-off-by: Xin Long --- net/dccp/ipv6.c | 20 ++-- 1 file changed, 10

Re: [net,v2] ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf

2017-06-20 Thread jeffy
Hi Cong Wang, On 06/20/2017 12:54 PM, Cong Wang wrote: Hello, On Mon, Jun 19, 2017 at 8:15 PM, jeffy wrote: but actually they are not guaranteed to be paired: the netdev_run_todo(see the first dump stack above) would call netdev_wait_allrefs to rebroadcast

[PATCH net] dccp: call inet_add_protocol after register_pernet_subsys in dccp_v4_init

2017-06-20 Thread Xin Long
Now dccp_ipv4 works as a kernel module. During loading this module, if one dccp packet is being recieved after inet_add_protocol but before register_pernet_subsys in which v4_ctl_sk is initialized, a null pointer dereference may be triggered because of init_net.dccp.v4_ctl_sk is 0x0. Jianlin

Re: clean up and modularize arch dma_mapping interface

2017-06-20 Thread Daniel Vetter
On Thu, Jun 08, 2017 at 03:25:25PM +0200, Christoph Hellwig wrote: > Hi all, > > for a while we have a generic implementation of the dma mapping routines > that call into per-arch or per-device operations. But right now there > still are various bits in the interfaces where don't clearly operate

[PATCH net-next] sctp: handle errors when updating asoc

2017-06-20 Thread Xin Long
It's a bad thing not to handle errors when updating asoc. The memory allocation failure in any of the functions called in sctp_assoc_update() would cause sctp to work unexpectedly. This patch is to fix it by aborting the asoc and reporting the error when any of these functions fails.

Re: [PATCH net-next v3 10/15] bpf: Add support for changing congestion control

2017-06-20 Thread kbuild test robot
Hi Lawrence, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Lawrence-Brakmo/bpf-BPF-support-for-sock_ops/20170620-142609 config: i386-randconfig-i0-201725 (attached as .config) compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4 reproduce: # save

Re: [PATCH net-next v2 1/4] rtnetlink: add NEWCACHEREPORT message type

2017-06-20 Thread Nikolay Aleksandrov
On 19/06/17 23:44, Julien Gomes wrote: > New NEWCACHEREPORT message type to be used for cache reports sent > via Netlink, effectively allowing splitting cache report reception from > mroute programming. > > Suggested-by: Ryan Halbrook > Signed-off-by: Julien Gomes

RE: [net-next 11/15] net/mlx5e: Reduce number of heap allocated buffers for update stats

2017-06-20 Thread David Laight
From: Saeed Mahameed > Sent: 15 June 2017 22:43 > Allocating buffers on the heap every 200ms is something we should avoid, > let's use buffers located on the stack instead. ... > + u32 in[MLX5_ST_SZ_DW(ppcnt_reg)] = {0}; How big is that? Allocating large on-stack buffers is even worse. One

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Pavel Machek
On Tue 2017-06-20 14:24:00, Alexandre Belloni wrote: > On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: > > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: > > > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > > > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because

Re: [RFC 2/2] net-next: mt7530: add nh and proto offsets to the ops struct

2017-06-20 Thread Andrew Lunn
On Tue, Jun 20, 2017 at 10:06:55AM +0200, John Crispin wrote: > The MT7530 inserts the 4 magic header in between the 802.3 address and > protocol field. The patch defines these header such that the flow_disector > can properly parse the packet and thus allows hashing to function properly. This is

new dma-mapping tree, was Re: clean up and modularize arch dma_mapping interface V2

2017-06-20 Thread Christoph Hellwig
On Fri, Jun 16, 2017 at 08:10:15PM +0200, Christoph Hellwig wrote: > I plan to create a new dma-mapping tree to collect all this work. > Any volunteers for co-maintainers, especially from the iommu gang? Ok, I've created the new tree: git://git.infradead.org/users/hch/dma-mapping.git for-next

[PATCH v4 net-next 0/7] qed*: RDMA and infrastructure for iWARP

2017-06-20 Thread Yuval Mintz
This series focuses on RDMA in general with emphasis on required changes toward adding iWARP support. The vast majority of the changes introduced are in qed/qede, with a couple of small changes to qedr [mentioned below]. The infrastructure changes: - Patch #1 adds the ability to pass PBL memory

[PATCH v4 net-next 1/7] qed: Chain support for external PBL

2017-06-20 Thread Yuval Mintz
iWARP would require the chains to allocate/free their PBL memory independently, so add the infrastructure to provide it externally. Signed-off-by: Yuval Mintz --- drivers/infiniband/hw/qedr/main.c | 2 +- drivers/infiniband/hw/qedr/verbs.c| 6

Re: clean up and modularize arch dma_mapping interface

2017-06-20 Thread Christoph Hellwig
On Tue, Jun 20, 2017 at 11:19:02AM +0200, Daniel Vetter wrote: > Ack for the 2 drm patches, but I can also pick them up through drm-misc if > you prefer that (but then it'll be 4.14). Nah, I'll plan to set up a dma-mapping tree so that we'll have common place for dma-mapping work.

Re: [PATCH net-next] net: phy: lxt: Export link partner advertising

2017-06-20 Thread Andrew Lunn
On Mon, Jun 19, 2017 at 04:00:22PM +0200, Thomas Bogendoerfer wrote: > From: Thomas Bogendoerfer > > Provide link partner advertising information. > Removed testing for gigabit modes, which is useless for a fast ethernet phy. > > Signed-off-by: Thomas Bogendoerfer

RE: remove dma_alloc_noncoherent

2017-06-20 Thread David Laight
From: Christoph Hellwig > Sent: 16 June 2017 08:17 > > For many years we've had the dma_alloc_attrs API that is more flexible > than dma_alloc_noncoherent. This series moves the remaining users over > to the attrs API. And most of the callers probably only want to specify 'noncoherent'. Grepping

Re: new dma-mapping tree, was Re: clean up and modularize arch dma_mapping interface V2

2017-06-20 Thread Stephen Rothwell
Hi Christoph, On Tue, 20 Jun 2017 14:41:40 +0200 Christoph Hellwig wrote: > > On Fri, Jun 16, 2017 at 08:10:15PM +0200, Christoph Hellwig wrote: > > I plan to create a new dma-mapping tree to collect all this work. > > Any volunteers for co-maintainers, especially from the iommu

Re: new dma-mapping tree, was Re: clean up and modularize arch dma_mapping interface V2

2017-06-20 Thread Robin Murphy
Hi Christoph, On 20/06/17 13:41, Christoph Hellwig wrote: > On Fri, Jun 16, 2017 at 08:10:15PM +0200, Christoph Hellwig wrote: >> I plan to create a new dma-mapping tree to collect all this work. >> Any volunteers for co-maintainers, especially from the iommu gang? > > Ok, I've created the new

Re: new dma-mapping tree, was Re: clean up and modularize arch dma_mapping interface V2

2017-06-20 Thread Christoph Hellwig
On Tue, Jun 20, 2017 at 02:14:36PM +0100, Robin Murphy wrote: > Hi Christoph, > > On 20/06/17 13:41, Christoph Hellwig wrote: > > On Fri, Jun 16, 2017 at 08:10:15PM +0200, Christoph Hellwig wrote: > >> I plan to create a new dma-mapping tree to collect all this work. > >> Any volunteers for

RE: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Steve Twiss
Hi Pavel, On 20 June 2017 14:26, Pavel Machek wrote: > Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions > > On Tue 2017-06-20 14:24:00, Alexandre Belloni wrote: > > On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: > > > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote:

Re: [RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread Andrew Lunn
On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: > RPS and probably other kernel features are currently broken on some if not > all DSA devices. The root cause of this that skb_hash will call the > flow_disector. Hi John What is the call path when the flow_disector is called? I'm

[PATCH net-next 4/4] s390/qeth: use diag26c to get MAC address on L2

2017-06-20 Thread Julian Wiedmann
When a s390 guest runs on a z/VM host that's part of a SSI cluster, it can be migrated to a different host. In this case, the MAC address it originally obtained on the old host may be re-assigned to a new guest. This would result in address conflicts between the two guests. When running as z/VM

[PATCH net-next 2/4] s390/qeth: fix packing buffer statistics

2017-06-20 Thread Julian Wiedmann
There's two spots in qeth_send_packet() where we don't accurately account for transmitted packing buffers in qeth's performance statistics: 1) when flushing the current buffer due to insufficient size, and the next buffer is not EMPTY, we need to account for that flushed buffer. 2) when

[net-next 03/10] net/mlx5e: IPoIB, Add ethtool support

2017-06-20 Thread Saeed Mahameed
From: Erez Shitrit Add support for the following: "ethtool -S" (statistics). "ethtool -i" (driver info). "ethtool -g/G" (rings parameters). "ethtool -l/L" (channels parameters). "ethtool -c/C" (coalesce options). Signed-off-by: Erez

[pull request][net-next 00/10] Mellanox, mlx5 IPoIB updates 2017-06-20

2017-06-20 Thread Saeed Mahameed
Hi Dave, This series mainly from Erez and Feras includes some updates and ethtool/ndos extension to the mlx5 IPoIB netdevice. for more detalis please see tag log below. Please pull and let me know if there's any problem. Thanks, Saeed. --- The following changes since commit

[net-next 01/10] net/mlx5e: IPoIB, Move to a separate directory

2017-06-20 Thread Saeed Mahameed
IPoIB netdevice driver was only introduced in previous kernel release and it is growing in terms of features and LOC, move it to a separate directory. Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/Makefile| 2 +-

[net-next 07/10] net/mlx5e: IPoIB, Handle change_mtu

2017-06-20 Thread Saeed Mahameed
From: Erez Shitrit Add the ndo that supports change mtu for IPoIB. The callback called from the ipoib ULP driver, that gives the ability to change the SW and HW resources accordingly in the lower driver. Signed-off-by: Erez Shitrit Signed-off-by: Saeed

[net-next 09/10] net/mlx5e: IPoIB, Add PTP support to IPoIB device driver

2017-06-20 Thread Saeed Mahameed
From: Feras Daoud Enable PTP for IPoIB rdma_netdev and add the ability to get the time stamping parameters using ethtool. Signed-off-by: Feras Daoud Signed-off-by: Eitan Rabin Signed-off-by: Saeed Mahameed

[net-next 06/10] net/mlx5e: Use hard_mtu as part of the mlx5e_priv struct

2017-06-20 Thread Saeed Mahameed
From: Erez Shitrit The mtu extra space that kept for the HW is specific for each link type, and it is different in mlx5e and mlx5i modules. Now it is kept in the priv structures, set by the mlx5e/mlx5i driver accordingly. Signed-off-by: Erez Shitrit

[net-next 02/10] net/mlx5e: Prevent PFC call for non ethernet ports

2017-06-20 Thread Saeed Mahameed
From: Feras Daoud Port flow control supported only for ethernet ports, therefore, prevent any call if the port type differs from MLX5_CAP_PORT_TYPE_ETH. Signed-off-by: Feras Daoud Signed-off-by: Saeed Mahameed ---

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: > > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > > > rely on 32bits variables and that will make rtc

[PATCH net] net: stmmac: free an skb first when there are no longer any descriptors using it

2017-06-20 Thread Niklas Cassel
When having the skb pointer in the first descriptor, stmmac_tx_clean can get called at a moment where the IP has only cleared the own bit of the first descriptor, thus freeing the skb, even though there can be several descriptors whose buffers point into the same skb. By simply moving the skb

  1   2   3   >