Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

On Mon, Jul 03, 2017 at 09:40:22AM -0700, Linus Torvalds wrote: > On Mon, Jul 3, 2017 at 9:18 AM, Paul E. McKenney > wrote: > > > > Agreed, and my next step is to look at spin_lock() followed by > > spin_is_locked(), not necessarily the same lock. > > Hmm. Most (all?)

Re: [PATCH net-next] qed: initialize ll2_syn_handle at start of function

From: Michal Kalderon Date: Mon, 3 Jul 2017 21:55:25 +0300 > Fix compilation warning > qed_iwarp.c:1721:5: warning: ll2_syn_handle may be used > uninitialized in this function > > Signed-off-by: Michal Kalderon > Signed-off-by: Ariel

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

On Mon, Jul 03, 2017 at 03:49:42PM -0700, Linus Torvalds wrote: > On Mon, Jul 3, 2017 at 3:30 PM, Paul E. McKenney > wrote: > > > > That certainly is one interesting function, isn't it? I wonder what > > happens if you replace the raw_spin_is_locked() calls with an >

'skb' buffer address information leakage

Hi all: I'd found several address leaks of "skb" buffer.When i have a arbitrary address write vulnerability in kernel(enabled kASLR),I can use skb's address find sk_destruct's address and overwrite it. And then,invoke close(sock_fd) function can trigger the shellcode(sk_destruct func). In kernel

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

On Mon, Jul 3, 2017 at 3:30 PM, Paul E. McKenney wrote: > > That certainly is one interesting function, isn't it? I wonder what > happens if you replace the raw_spin_is_locked() calls with an > unlock under a trylock check? ;-) Deadlock due to interrupts again?

Re: 'skb' buffer address information leakage

On Tue, 4 Jul 2017 13:12:18 +0800, Dison River wrote: > drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c:167 > seq_printf(file, " frag=%p", skb); FWIW that's actually not a skb pointer. The structure is defined like this: struct nfp_net_tx_buf { union {

Re: [PATCH] vmalloc: respect the GFP_NOIO and GFP_NOFS flags

On Mon, 3 Jul 2017, Michal Hocko wrote: > We can add a warning (or move it from kvmalloc) and hope that the > respective maintainers will fix those places properly. The reason I > didn't add the warning to vmalloc and kept it in kvmalloc was to catch > only new users rather than suddenly splat

[PATCH net-next] mpls: route get support

From: Roopa Prabhu This patch adds RTM_GETROUTE doit handler for mpls routes. Input: RTA_DST - input label RTA_NEWDST - labels in packet for multipath selection By default the getroute handler returns matched nexthop label, via and oif With RTM_F_FIB_MATCH flag,

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

On Mon, Jul 03, 2017 at 06:13:38PM +0100, Will Deacon wrote: > On Mon, Jul 03, 2017 at 09:40:22AM -0700, Linus Torvalds wrote: > > On Mon, Jul 3, 2017 at 9:18 AM, Paul E. McKenney > > wrote: > > > > > > Agreed, and my next step is to look at spin_lock() followed by > >

Re: [RFC/RFT PATCH 2/4] net: ethernat: ti: cpts: enable irq

On Mon, Jul 03, 2017 at 02:31:06PM -0500, Grygorii Strashko wrote: > > > On 06/30/2017 08:31 PM, Ivan Khoronzhuk wrote: > > On Tue, Jun 13, 2017 at 06:16:21PM -0500, Grygorii Strashko wrote: > >> There are two reasons for this change: > >> 1) enabling of HW_TS_PUSH events as suggested by Richard

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

On Mon, Jul 03, 2017 at 05:39:36PM -0700, Paul E. McKenney wrote: > On Mon, Jul 03, 2017 at 03:49:42PM -0700, Linus Torvalds wrote: > > On Mon, Jul 3, 2017 at 3:30 PM, Paul E. McKenney > > wrote: > > > > > > That certainly is one interesting function, isn't it? I

[PATCH] net: ethernet: mediatek: fixed deadlock captured by lockdep

From: Sean Wang Lockdep found an inconsistent lock state when mtk_get_stats64 is called in user context while NAPI updates MAC statistics in softirq. Use spin_trylock_bh/spin_unlock_bh fix following lockdep warning. [ 81.321030] WARNING: inconsistent lock state [

[PATCH net-next] bridge: allow ext learned entries to change ports

From: Nikolay Aleksandrov current code silently ignores change of port in the request message. This patch makes sure the port is modified and notification is sent to userspace. Fixes: cf6b8e1eedff ("bridge: add API to notify bridge driver of learned FBD on

[PATCH 1/1] net sched: Added the TC_LINKLAYER_CUSTOM linklayer type

This is to support user-space modification of the qdisc stab. Signed-off-by: McCabe, Robert J --- include/uapi/linux/pkt_sched.h | 1 + net/sched/sch_api.c| 2 ++ 2 files changed, 3 insertions(+) diff --git a/include/uapi/linux/pkt_sched.h

[PATCH 1/1] tc: custom qdisc pkt size translation table

Added the "custom" linklayer qdisc stab option. Allows the user to specify the pkt size translation parameters from stdin. Example: tc qdisc add ... stab tsize 8 linklayer custom htb Custom size table: InputSizeStart -> IntputSizeEnd: OutputSize 0 -> 511

Re: [PATCH 1/1] net sched: Added the TC_LINKLAYER_CUSTOM linklayer type

Tue, Jul 04, 2017 at 02:14:25AM CEST, robert.mcc...@rockwellcollins.com wrote: >This is to support user-space modification of the qdisc stab. > >Signed-off-by: McCabe, Robert J >--- > include/uapi/linux/pkt_sched.h | 1 + > net/sched/sch_api.c| 2 ++ >

Re: [PATCH RFC 01/26] netfilter: Replace spin_unlock_wait() with lock/unlock pair

On Mon, 3 Jul 2017, Paul E. McKenney wrote: > On Mon, Jul 03, 2017 at 10:39:49AM -0400, Alan Stern wrote: > > On Sat, 1 Jul 2017, Manfred Spraul wrote: > > > > > As we want to remove spin_unlock_wait() and replace it with explicit > > > spin_lock()/spin_unlock() calls, we can use this to

Re: [PATCH RFC 01/26] netfilter: Replace spin_unlock_wait() with lock/unlock pair

On Mon, Jul 03, 2017 at 04:04:14PM -0400, Alan Stern wrote: > On Mon, 3 Jul 2017, Paul E. McKenney wrote: > > > On Mon, Jul 03, 2017 at 10:39:49AM -0400, Alan Stern wrote: > > > On Sat, 1 Jul 2017, Manfred Spraul wrote: > > > > > > > As we want to remove spin_unlock_wait() and replace it with

Re: [PATCH 1/1] mlx4_en: make mlx4_log_num_mgm_entry_size static

On Mon, Jul 03, 2017 at 01:35:19AM -0400, Zhu Yanjun wrote: > The variable mlx4_log_num_mgm_entry_size is only called in main.c. > > CC: Joe Jin > CC: Junxiao Bi > Signed-off-by: Zhu Yanjun > --- >

[PATCH rdma-next V2 27/27] RDMA/netlink: Export node_type

From: Leon Romanovsky Add ability to get node_type for RDAM netlink users. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 3 +++ include/uapi/rdma/rdma_netlink.h | 2 ++ 2 files changed, 5 insertions(+) diff --git

[PATCH rdma-next V2 26/27] RDMA/netlink: Provide port state and physical link state

From: Leon Romanovsky Add port state and physical link state to the users of RDMA netlink. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 6 ++ include/uapi/rdma/rdma_netlink.h | 3 +++ 2 files changed, 9 insertions(+) diff

[PATCH rdma-next V2 17/27] RDMA/netlink: Add nldev port dumpit implementation

From: Leon Romanovsky This patch implements the query interface to get all ports data for the specific device. Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise --- drivers/infiniband/core/nldev.c | 61

[PATCH rdma-next V2 11/27] RDMA/netlink: Convert LS to doit callback

From: Leon Romanovsky RDMA_NL_LS protocol is actually does not dump anything, but sets data and it should be handled by doit callback. This patch actually converts RDMA_NL_LS to doit callback, while preserving IWCM and RDMA_CM flows through netlink_dump_start().

[PATCH rdma-next V2 06/27] RDMA/netlink: Rename netlink callback struct

From: Leon Romanovsky The RDMA netlink client infrastructure was removed and made obsolete the old name (ibnl_client_cbs). This patch renames to the more appropriate name (rdma_nl_cbs). Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise

[PATCH rdma-next V2 02/27] RDMA/netlink: Simplify the put_msg and put_attr

From: Leon Romanovsky Reuse standard macros to cancel the netlink message in case of error. Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise --- drivers/infiniband/core/netlink.c | 31 +--

[PATCH rdma-next V2 01/27] RDMA/netlink: Add flag to consolidate common handing

From: Leon Romanovsky Add ability to provide flags to control RDMA netlink callbacks and convert addr.c and sa_query.c to be first users of such infrastructure. It allows to move their CAP_NET_ADMIN checks into netlink core. Signed-off-by: Leon Romanovsky

[PATCH rdma-next V2 00/27] RDMA Netlink Device Client

Hi, This is third version of the RDMA netlink patch set. The following patch set is an implementation of NLDEV - RDMA netlink device client. It is based on the already sent patch [1] and patch set [2]. This client is needed to properly integrate coming RDMAtool [3] into iproute2 package which

[PATCH rdma-next V2 14/27] RDMA/netlink: Add nldev initialization flows

From: Leon Romanovsky Add nldev init and exit flows to the RDMA/core. Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise --- drivers/infiniband/core/Makefile | 4 +++- drivers/infiniband/core/device.c | 2 ++

[PATCH rdma-next V2 07/27] RDMA/core: Add iterator over ib_devices

From: Leon Romanovsky The coming nldev needs to iterate over all IB devices in the system and in order to not expose the ib_devices list outside the devices.c, it is necessary to provide function iterator. Current version is written explicitly for nldev callback to avoid

[PATCH rdma-next V2 08/27] RDMA/core: Add and expose static device index

From: Leon Romanovsky This patch adds static device index in similar fashion to already available in netdev world (struct net->ifindex). In downstream patches, the RDMA nelink will use this idx-to-ib_device conversion, so as part of this commit, we are exposing the

[PATCH rdma-next V2 03/27] RDMA/netlink: Rename and remove redundant parameter from ibnl_unicast

From: Leon Romanovsky Netlink message header is not needed for unicast reply, hence remove it. Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise --- drivers/infiniband/core/iwpm_msg.c | 6 +++---

[PATCH rdma-next V2 10/27] RDMA/netlink: Reduce indirection access to cb_table

From: Leon Romanovsky Introduce intermediate variable to store access to fields of cb_table. Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise --- drivers/infiniband/core/netlink.c | 13 - 1 file changed,

[PATCH rdma-next V2 18/27] RDMA/netlink: Implement nldev port doit callback

From: Leon Romanovsky Provide ability to get specific to device and port information. Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise --- drivers/infiniband/core/nldev.c | 44

[PATCH rdma-next V2 13/27] RDMA/netlink: Add netlink device definitions to UAPI

From: Leon Romanovsky Introduce new defines to rdma_netlink.h, so the RDMA configuration tool will be able to communicate with RDMA subsystem by using the shared defines. The addition of new client (NLDEV) revealed the fact that we exposed by mistake the RDMA_NL_I40IW

Re: [PATCH] [net-next] net/mlx5: include wq.o in non-ethernet build for FPGA

On Sun, Jul 2, 2017 at 10:45 AM, Saeed Mahameed wrote: > On Fri, Jun 30, 2017 at 10:25 PM, Arnd Bergmann wrote: >> On Fri, Jun 30, 2017 at 8:58 PM, Ilan Tayari wrote: >> diff --git

Re: linux-next: manual merge of the net-next tree with the net tree

On Mon, Jul 3, 2017 at 4:43 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got conflicts in: > > drivers/net/ethernet/mellanox/mlx5/core/health.c > include/linux/mlx5/driver.h > > between commit: > > 2a0165a034ac ("net/mlx5:

Re: [PATCH 1/1] mlx4_en: make mlx4_log_num_mgm_entry_size static

On Mon, Jul 03, 2017 at 01:35:19AM -0400, Zhu Yanjun wrote: > The variable mlx4_log_num_mgm_entry_size is only called in main.c. > > CC: Joe Jin > CC: Junxiao Bi > Signed-off-by: Zhu Yanjun > --- >

[PATCH rdma-next V2 05/27] RDMA/netlink: Simplify and rename ibnl_chk_listeners

From: Leon Romanovsky Make ibnl_chk_listeners function to be one line by removing unneeded comparison. Rename that function to be complaint to other functions in RDMA netlink. Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise

[PATCH rdma-next V2 15/27] RDMA/netlink: Implement nldev device dumpit calback

From: Leon Romanovsky This patch adds the ability to return all available devices together with their properties. Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise --- drivers/infiniband/core/nldev.c | 64

Re: linux-next: manual merge of the net-next tree with the arm64 tree

On 07/03/2017 03:37 AM, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the net-next tree got a conflict in: arch/arm64/net/bpf_jit_comp.c between commit: 425e1ed73e65 ("arm64: fix endianness annotation for 'struct jit_ctx' and friends") from the arm64 tree and commit:

Re: [PATCH] vmalloc: respect the GFP_NOIO and GFP_NOFS flags

On Fri 30-06-17 20:36:12, Mikulas Patocka wrote: > > > On Fri, 30 Jun 2017, Michal Hocko wrote: > > > On Fri 30-06-17 14:11:57, Mikulas Patocka wrote: > > > > > > > > > On Fri, 30 Jun 2017, Michal Hocko wrote: > > > > > > > On Thu 29-06-17 22:25:09, Mikulas Patocka wrote: > > > > > The

[PATCH rdma-next V2 20/27] RDMA: Simplify get firmware interface

From: Leon Romanovsky There is a need to forward FW version to user space application through RDMA netlink. In order to make it safe, there is need to declare nla_policy and limit the size of FW string. The new define IB_FW_VERSION_NAME_MAX will limit the size of FW version

[PATCH rdma-next V2 22/27] RDMA/netlink: Export node_guid and sys_image_guid

From: Leon Romanovsky Add Node GUID and system image GUID to the device properties exported by RDMA netlink, to be used by RDMAtool. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 8 include/uapi/rdma/rdma_netlink.h |

[PATCH rdma-next V2 04/27] RDMA/netlink: Rename and remove redundant parameter from ibnl_multicast

From: Leon Romanovsky The pointer to netlink header was not used in the ibnl_multicast function, so let's remove it and simplify the function signature. Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise ---

[PATCH rdma-next V2 16/27] RDMA/netlink: Add nldev device doit implementation

From: Leon Romanovsky Provide ability to query specific device. Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise --- drivers/infiniband/core/nldev.c | 40 1 file changed, 40

[PATCH rdma-next V2 24/27] RDMA/netink: Export lids and sm_lids

From: Leon Romanovsky According to the IB specification, the LID and SM_LID are 16-bit wide, but to support OmniPath users, export it as 32-bit value from the beginning. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 9 -

[PATCH rdma-next V2 21/27] RDMA/netlink: Export FW version

From: Leon Romanovsky Add FW version to the device properties exported by RDMA netlink, to be used by RDMAtool. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 9 + include/uapi/rdma/rdma_netlink.h | 4 2 files

[PATCH rdma-next V2 09/27] RDMA/netlink: Add and implement doit netlink callback

From: Leon Romanovsky The .doit callback is used by netlink core to differentiate between get and set operations. Common convention is to use that call for command operations like (SET, ADD, e.t.c.) and/or access without NLF_M_DUMP flag. This commit adds proper declaration

[PATCH rdma-next V2 12/27] RDMA/netlink: Update copyright

From: Leon Romanovsky Add Mellanox to the copyright header. Signed-off-by: Leon Romanovsky Reviewed-by: Steve Wise --- drivers/infiniband/core/netlink.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH rdma-next V2 23/27] RDMA/netlink: Advertise IB subnet prefix

From: Leon Romanovsky Add IB subnet prefix to the port properties exported by RDMA netlink. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 5 + include/uapi/rdma/rdma_netlink.h | 5 + 2 files changed, 10 insertions(+)

[PATCH rdma-next V2 19/27] RDMA/netlink: Expose device and port capability masks

From: Leon Romanovsky The port capability mask is exposed to user space via sysfs interface, while device capabilities are available for verbs only. This patch provides those capabilities through netlink interface. Signed-off-by: Leon Romanovsky

[PATCH rdma-next V2 25/27] RDMA/netlink: Export LID mask counter (LMC)

From: Leon Romanovsky Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/nldev.c | 3 +++ include/uapi/rdma/rdma_netlink.h | 5 + 2 files changed, 8 insertions(+) diff --git a/drivers/infiniband/core/nldev.c

[PATCH] mwifiex: uninit wakeup info when failed to add card

We inited wakeup info at the beginning of mwifiex_add_card, so we need to uninit it in the error handling. It's much the same as what we did in: 36908c4 mwifiex: uninit wakeup info when removing device Signed-off-by: Jeffy Chen ---

Re: [PATCH net-next] vxlan: correctly set vxlan->net when creating the device in a netns

From: Sabrina Dubroca Date: Fri, 30 Jun 2017 15:50:00 +0200 > Commit a985343ba906 ("vxlan: refactor verification and application of > configuration") modified vxlan device creation, and replaced the > assignment of vxlan->net to src_net with dev_net(netdev) in ->setup(). >

Re: [PATCH v2] Documentation: fix wrong example command

From: Matteo Croce Date: Fri, 30 Jun 2017 18:21:47 +0200 > In the IPVLAN documentation there is an example command line where the > master and slave interface names are inverted. > Fix the command line and also add the optional `name' keyword to better > describe what the

Re: [PATCH net-next] net/packet: Fix Tx queue selection for AF_PACKET

From: Iván Briano Date: Fri, 30 Jun 2017 14:02:32 -0700 > When PACKET_QDISC_BYPASS is not used, Tx queue selection will be done > before the packet is enqueued, taking into account any mappings set by > a queuing discipline such as mqprio without hardware offloading. This

Re: [PATCH net-next 0/7] Misc BPF helper/verifier improvements

From: Daniel Borkmann Date: Sun, 2 Jul 2017 02:13:24 +0200 > Miscellanous improvements I still had in my queue, it adds a new > bpf_skb_adjust_room() helper for cls_bpf, exports to fdinfo whether > tail call array owner is JITed, so iproute2 error reporting can be >

Re: [PATCH 00/17] v3 net generic subsystem refcount conversions

On Fri, 2017-06-30 at 13:07 +0300, Elena Reshetova wrote: > Changes in v3: > Rebased on top of the net-next tree. > > Changes in v2: > No changes in patches apart from rebases, but now by > default refcount_t = atomic_t (*) and uses all atomic standard operations > unless CONFIG_REFCOUNT_FULL is

Re: [PATCH net 0/2] vxlan, geneve: fix hlist corruption

From: Jiri Benc Date: Sun, 2 Jul 2017 19:00:56 +0200 > Fix memory corruption introduced with the support of both IPv4 and IPv6 > sockets in a single device. The same bug is present in VXLAN and Geneve. > > Signed-off-by: Jiri Benc Series applied and queued

Re: linux-next: build failure after merge of the akpm tree

Hi all, On Fri, 30 Jun 2017 16:32:41 +1000 Stephen Rothwell wrote: > > After merging the akpm tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from include/linux/bitmap.h:8:0, > from

Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

From: Jim Baxter Date: Wed, 28 Jun 2017 21:35:29 +0100 > The CDC-NCM driver can require large amounts of memory to create > skb's and this can be a problem when the memory becomes fragmented. > > This especially affects embedded systems that have constrained > resources

Re: linux-next: build failure after merge of the akpm tree

From: Stephen Rothwell Date: Fri, 30 Jun 2017 16:32:41 +1000 > From: Stephen Rothwell > Date: Fri, 30 Jun 2017 16:24:35 +1000 > Subject: [PATCH] net/mlx5: fix memcpy limit? > > Signed-off-by: Stephen Rothwell Applied,

Re: [PATCH net-next v8 0/2] Add loopback support in phy_driver and hns ethtool fix

From: Lin Yun Sheng Date: Fri, 30 Jun 2017 17:44:14 +0800 > This Patch Set add set_loopback in phy_driver and use it to setup loopback > when doing ethtool phy self_test. Series applied, thank you.

Re: [PATCH] net: cdc_mbim: apply "NDP to end" quirk to HP lt4132

From: Tore Anderson Date: Sat, 1 Jul 2017 15:20:02 +0200 > The HP lt4132 LTE/HSPA+ 4G Module (03f0:a31d) is a rebranded Huawei > ME906s-158 device. It, like the ME906s-158, requires the "NDP to end" > quirk for correct operation. > > Signed-off-by: Tore Anderson

Re: [PATCH net-next 00/12] qed: Add iWARP support for QL4xxxx

You really have to compile test your work and do something with the warnings: drivers/net/ethernet/qlogic/qed/qed_iwarp.c:1721:5: warning: ‘ll2_syn_handle’ may be used uninitialized in this funct This one is completely legitimate, you can goto "err" and use the ll2_syn_handle without it being

RE: [PATCH 00/17] v3 net generic subsystem refcount conversions

> On Fri, 2017-06-30 at 13:07 +0300, Elena Reshetova wrote: > > Changes in v3: > > Rebased on top of the net-next tree. > > > > Changes in v2: > > No changes in patches apart from rebases, but now by > > default refcount_t = atomic_t (*) and uses all atomic standard operations > > unless

Re: [PATCH NET V5 2/2] net: hns: Use phy_driver to setup Phy loopback

Hi, Andrew On 2017/7/1 23:17, Andrew Lunn wrote: > On Sat, Jul 01, 2017 at 11:57:32AM +, linyunsheng wrote: >> Hi, Andrew >> >> I am agreed wih you on this. >> But self test is also a feature of our product, and our >> customer way choose to diagnose a problem using >> self test, even if self

Re: [PATCH 1/1] mlx4_en: make mlx4_log_num_mgm_entry_size static

Hello! On 7/3/2017 8:35 AM, Zhu Yanjun wrote: The variable mlx4_log_num_mgm_entry_size is only called in main.c. s/called/used/. CC: Joe Jin CC: Junxiao Bi Signed-off-by: Zhu Yanjun [...] MBR, Sergei

[PATCH net-next] net: make sk_ehashfn() static

From: Eric Dumazet sk_ehashfn() is only used from a single file. Signed-off-by: Eric Dumazet --- include/net/inet_hashtables.h |1 - net/ipv4/inet_hashtables.c|2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [PATCH net-next] vxlan: correctly set vxlan->net when creating the device in a netns

On 06/30/2017 03:50 PM, Sabrina Dubroca wrote: > Commit a985343ba906 ("vxlan: refactor verification and application of > configuration") modified vxlan device creation, and replaced the > assignment of vxlan->net to src_net with dev_net(netdev) in ->setup(). > > But dev_net(netdev) is not the

Re: [PATCH net 1/2] vxlan: fix hlist corruption

On Sun, 2 Jul 2017 16:06:10 -0400, Waiman Long wrote: > I didn't see any init code for hlist4 and hlist6. Is vxlan_dev going to > be *zalloc'ed so that they are guaranteed to be NULL? If not, you may > need to add init code as not both hlists will be hashed and so one of > them may contain

Re: [PATCH net-next 00/12] qed: Add iWARP support for QL4xxxx

From: Michal Kalderon Date: Sun, 2 Jul 2017 10:29:20 +0300 > This patch series adds iWARP support to our QL4 networking adapters. > The code changes span across qed and qedr drivers, but this series contains > changes to qed only. Once the series is accepted, the

Re: [PATCH net] ipv6: dad: don't remove dynamic addresses if link is down

From: Sabrina Dubroca Date: Thu, 29 Jun 2017 16:56:54 +0200 > Currently, when the link for $DEV is down, this command succeeds but the > address is removed immediately by DAD (1): > > ip addr add ::12/64 dev $DEV valid_lft 3600 preferred_lft 1800 > > In the same

Re: [PATCH] net: core: Fix slab-out-of-bounds in netdev_stats_to_stats64

From: Alban Browaeys Date: Mon, 3 Jul 2017 03:20:13 +0200 > commit 9256645af098 ("net/core: relax BUILD_BUG_ON in > netdev_stats_to_stats64") made an attempt to read beyond > the size of the source a possibility. > > Fix to only copy src size to dest. As dest might be

Re: [PATCH] netxen_nic: Remove unused pointer hdr in netxen_setup_minidump()

From: Christos Gkekas Date: Sun, 2 Jul 2017 23:16:11 +0100 > Pointer hdr in netxen_setup_minidump() is set but never used, thus > should be removed. > > Signed-off-by: Christos Gkekas Applied, thanks.

[PATCH net-next] net: avoid one splat in fib_nl_delrule()

From: Eric Dumazet We need to use refcount_set() on a newly created rule to avoid following error : [ 64.601749] [ cut here ] [ 64.601757] WARNING: CPU: 0 PID: 6476 at lib/refcount.c:184 refcount_sub_and_test+0x75/0xa0 [ 64.601758] Modules

Re: [PATCH net-next] net/mlxfw: Properly handle dependancy with non-loadable mlx5

From: Or Gerlitz Date: Sun, 2 Jul 2017 18:57:28 +0300 > If mlx5 is set to be built-in and mlxfw as a module, we > get a link error: > > drivers/built-in.o: In function `mlx5_firmware_flash': > (.text+0x5aed72): undefined reference to `mlxfw_firmware_flash' > > Since we

Re: [PATCH 1/1] mlx4_en: make mlx4_log_num_mgm_entry_size static

From: Zhu Yanjun Date: Mon, 3 Jul 2017 01:35:19 -0400 > The variable mlx4_log_num_mgm_entry_size is only called in main.c. > > CC: Joe Jin > CC: Junxiao Bi > Signed-off-by: Zhu Yanjun Applied, thank

Re: [PATCH net-next] net: make sk_ehashfn() static

From: Eric Dumazet Date: Mon, 03 Jul 2017 02:57:54 -0700 > From: Eric Dumazet > > sk_ehashfn() is only used from a single file. > > Signed-off-by: Eric Dumazet Applied.

Re: [PATCH 00/17] v3 net generic subsystem refcount conversions

On Mon, 2017-07-03 at 09:57 +, Reshetova, Elena wrote: > Thank you very much for the report! This is an underflow (dec/sub from > zero) that is reported by WARNING. > I guess it is unlikely that actual code underflows, so the most > probable cause is that it attempted to do

[PATCH] openvswitch: fix mis-ordered comment lines for ovs_skb_cb

I was trying to wrap my head around meaning of mru, and realised that the second line of the comment defining it had somehow ended up after the line defining cutlen, leading to much confusion. Reorder the lines to make sense. Signed-off-by: Daniel Axtens ---

Re: [PATCH 0/2] Fixes for errors reported by 0day on net-next tree

From: Elena Reshetova Date: Mon, 3 Jul 2017 14:50:26 +0300 > Despite the fact that we have automatic testing enabled > on all our branches, there s390-config related errors got through. > I will investigate separately why it happened. > Sorry for the inconvince and

[PATCH net] ixgbe: fix masking of bits read from IXGBE_VXLANCTRL register

In ixgbe_clear_udp_tunnel_port(), we read the IXGBE_VXLANCTRL register and then try to mask some bits out of the value, using the logical instead of bitwise and operator. Fixes: a21d0822ff69 ("ixgbe: add support for geneve Rx offload") Signed-off-by: Sabrina Dubroca ---

[PATCH 2/2] drivers, s390: fix errors resulting from refcount conversions

For some reason it looks like our tree hasn't been tested with s390-default_defconfig, so this commit fixes errors reported from it. --- drivers/s390/net/ctcm_fsms.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/s390/net/ctcm_fsms.c

[PATCH 1/2] net, iucv: fixing error from refcount conversion

Fixing "net/iucv/af_iucv.c:405:22: error: passing argument 1 of 'atomic_read' from incompatible pointer type" --- net/iucv/af_iucv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index ac033e4..1485331 100644 --- a/net/iucv/af_iucv.c

[PATCH 0/2] Fixes for errors reported by 0day on net-next tree

Despite the fact that we have automatic testing enabled on all our branches, there s390-config related errors got through. I will investigate separately why it happened. Sorry for the inconvince and please pull. Elena Reshetova (2): net, iucv: fixing error from refcount conversion drivers,

Re: [PATCH net-next] net: avoid one splat in fib_nl_delrule()

From: Eric Dumazet Date: Mon, 03 Jul 2017 02:54:33 -0700 > From: Eric Dumazet > > We need to use refcount_set() on a newly created rule to avoid > following error : ... > Fixes: 717d1e993ad8 ("net: convert fib_rule.refcnt from atomic_t to >

Re: [PATCH] openvswitch: fix mis-ordered comment lines for ovs_skb_cb

From: Daniel Axtens Date: Mon, 3 Jul 2017 21:46:43 +1000 > I was trying to wrap my head around meaning of mru, and realised > that the second line of the comment defining it had somehow > ended up after the line defining cutlen, leading to much confusion. > > Reorder the lines

Re: [PATCH RFC 2/2] kproxy: Kernel proxy

From: Tom Herbert Date: Thu, 29 Jun 2017 11:27:05 -0700 > A proc file (/prox/net/kproxy) is created to list all the running > kernel proxies and relevant statistics for them. proc is deprecated for dumping information like this, please use sock diag instead.

Re: pull-request: wireless-drivers-next 2017-07-03

From: Kalle Valo Date: Mon, 03 Jul 2017 14:39:07 +0300 > here's the late pull request to net-next I mentioned about last week to > get some new iwlwifi hw support to 4.13. > > If this is too late just drop the request and let me know, I can then > resend it for 4.14 after

Re: [PATCH RFC 1/2] skbuff: Function to send an skbuf on a socket

From: Tom Herbert Date: Thu, 29 Jun 2017 11:27:04 -0700 > +int skb_send_sock(struct sk_buff *skb, struct socket *sock, unsigned int > offset) > +{ > + unsigned int sent = 0; > + unsigned int ret; > + unsigned short fragidx; Please use reverse christmas tree

pull-request: wireless-drivers-next 2017-07-03

Hi Dave, here's the late pull request to net-next I mentioned about last week to get some new iwlwifi hw support to 4.13. If this is too late just drop the request and let me know, I can then resend it for 4.14 after the merge window. These patches were included in today's linux-next build and I

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

On Fri, Jun 30, 2017 at 03:18:40PM -0700, Paul E. McKenney wrote: > On Fri, Jun 30, 2017 at 02:13:39PM +0100, Will Deacon wrote: > > On Fri, Jun 30, 2017 at 05:38:15AM -0700, Paul E. McKenney wrote: > > > I also need to check all uses of spin_is_locked(). There might no > > > longer be any that

locking issues in macvtap (looks like due to tap: Extending tap device create/destroy APIs)

Sainath, with rcu debugging and lock debugging I get the following splats. I think doing a mutex_lock while in an rcu read-side is not allowed, since mutex_lock can sleep. This is in 4.11 and 4.12 and seems to be introduced with commit d9f1f61c0801a7("tap: Extending tap device create/destroy

Re: [PATCH RFC 01/26] netfilter: Replace spin_unlock_wait() with lock/unlock pair

On Sat, 1 Jul 2017, Manfred Spraul wrote: > As we want to remove spin_unlock_wait() and replace it with explicit > spin_lock()/spin_unlock() calls, we can use this to simplify the > locking. > > In addition: > - Reading nf_conntrack_locks_all needs ACQUIRE memory ordering. > - The new code

Re: [PATCH net 1/2] vxlan: fix hlist corruption

On 07/03/2017 04:23 AM, Jiri Benc wrote: > On Sun, 2 Jul 2017 16:06:10 -0400, Waiman Long wrote: >> I didn't see any init code for hlist4 and hlist6. Is vxlan_dev going to >> be *zalloc'ed so that they are guaranteed to be NULL? If not, you may >> need to add init code as not both hlists will be

[PATCH iproute2 V2 4/4] rdma: Add initial manual for the tool

From: Leon Romanovsky Signed-off-by: Leon Romanovsky --- man/man8/Makefile | 3 +- man/man8/rdma.8 | 82 +++ 2 files changed, 84 insertions(+), 1 deletion(-) create mode 100644 man/man8/rdma.8

Re: [PATCH iproute2 V2 1/4] rdma: Add basic infrastructure for RDMA tool

On Mon, Jul 03, 2017 at 05:06:55PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > RDMA devices are cross-functional devices from one side, > but very tailored for the specific markets from another. > > Such diversity caused to spread of RDMA related configuration

[PATCH net v2 1/1] net: reflect mark on tcp syn ack packets

From: Jamal Hadi Salim SYN-ACK responses on a server in response to a SYN from a client did not get the injected skb mark that was tagged on the SYN packet. Fixes: 84f39b08d786 ("net: support marking accepting TCP sockets") Reviewed-by: Lorenzo Colitti

[PATCH net v2 0/1] reflect mark on tcp syn ack packets

From: Jamal Hadi Salim Changes from v1(Lorenzo): unconditionally set skb->mark = ireq->ir_mark; Jamal Hadi Salim (1): net: reflect mark on tcp syn ack packets net/ipv4/ip_output.c | 3 ++- net/ipv4/tcp_output.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) --

  1   2   >