Re: [PATCH V3 net-next 5/8] net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver

On Sat, Jul 22, 2017 at 11:38:26PM +, Salil Mehta wrote: > > On Sat, Jun 17, 2017 at 06:24:28PM +0100, Salil Mehta wrote: > > > + > > > +int hclge_tm_schd_init(struct hclge_dev *hdev); > > > +int hclge_tm_setup_tc(struct hclge_dev *hdev); > > > > The definition of this function DNE. > Sorry,

[PATCH net] openvswitch: fix potential out of bound access in parse_ct

From: Liping Zhang Before the 'type' is validated, we shouldn't use it to fetch the ovs_ct_attr_lens's minlen and maxlen, else, out of bound access may happen. Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action") Signed-off-by: Liping Zhang ---

Re: [PATCH V4 net-next 5/8] net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver

On Sat, Jul 22, 2017 at 11:09:39PM +0100, Salil Mehta wrote: > +int hclge_tm_setup_tc(struct hclge_dev *hdev); Like I said before, this function DNE. Thanks, Richard

Re: [PATCH V4 net-next 8/8] net: hns3: Add HNS3 driver to kernel build framework & MAINTAINERS

On Sat, Jul 22, 2017 at 11:09:42PM +0100, Salil Mehta wrote: > This patch updates the MAINTAINERS file with HNS3 Ethernet driver > maintainers names and other details. This also introduces the new > Makefiles required to build the HNS3 Ethernet driver and updates > the existing Kconfig file in the

RE: af_packet: use after free in prb_retire_rx_blk_timer_expired

Hi, Do we need delete the v3 ring, when tp_version changed from TPACKET_V3 to TPACKET_V1 ? Best Regards, liujian > -Original Message- > From: liujian (CE) > Sent: Sunday, July 23, 2017 4:21 PM > To: 'Cong Wang'; Dingtianhong > Cc: Willem de Bruijn; Dave Jones;

RE: [PATCH V4 net-next 5/8] net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver

Hi Richard, > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Richard Cochran > Sent: Sunday, July 23, 2017 7:17 AM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); >

Re: af_packet: use after free in prb_retire_rx_blk_timer_expired

On Sat, Jul 22, 2017 at 8:40 PM, Ding Tianhong wrote: > Hi, Cong: > > Thanks for your quirk solution, but I still has some doubts about it, > it looks like fix the problem in the packet_setsockopt->packet_set_ring > processing, > but when in packet_release processing, it

Re: [PATCH V2 net-next 12/21] net-next/hinic: Add qp resources

Hi David, Strange that checkpatch.pl --strict didn't warn about it. We will fix it. Thanks for review, Aviad On 7/20/2017 2:13 AM, David Miller wrote: > From: Aviad Krawczyk > Date: Wed, 19 Jul 2017 17:19:10 +0800 > >> diff --git

Re: [PATCH V4 net-next 2/8] net: hns3: Add support of the HNAE3 framework

On Sat, Jul 22, 2017 at 11:09:36PM +0100, Salil Mehta wrote: > This patch adds the support of the HNAE3 (Hisilicon Network > Acceleration Engine 3) framework support to the HNS3 driver. > > Framework facilitates clients like ENET(HNS3 Ethernet Driver), RoCE > and user-space Ethernet drivers (like

RE: af_packet: use after free in prb_retire_rx_blk_timer_expired

Hi Wang Cong, With this patch , the system was crashed when setsockopt. The call trace as below: crash> bt PID: 3069 TASK: 8800afcc CPU: 0 COMMAND: "trinity-main" #0 [8801bec03ce0] machine_kexec at 8105354b #1 [8801bec03d40] crash_kexec at 810f7e82 #2

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

Hi Francois, ERR_PTR / IS ERR - we will change it err_xyz labels - we will change it according to other companies style. hinic_free_hwdev - It is there to mark us changes for VF code. We will remove it, it can't be failed. hinic_remove - If insmod failed and someone calls rmmod, we will get a

RE: af_packet: use after free in prb_retire_rx_blk_timer_expired

Hi I find it caused by below steps: 1. set tp_version to TPACKET_V3 and req->tp_block_nr to 1 2. set tp_block_nr to 0 Then pg_vec was freed, and we did not delete the timer? Best Regards, liujian > -Original Message- > From: liujian (CE) > Sent: Sunday, July 23, 2017 5:47 PM > To:

Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

On 07/22/2017 03:09 PM, Salil Mehta wrote: > This patch adds the support of the Ethtool interface to > the HNS3 Ethernet driver. Various commands to read the > statistics, configure the offloading, loopback selftest etc. > are supported. > > Signed-off-by: Daode Huang

Re: af_packet: use after free in prb_retire_rx_blk_timer_expired

On Sun, Jul 23, 2017 at 5:48 AM, liujian (CE) wrote: > Hi > > I find it caused by below steps: > 1. set tp_version to TPACKET_V3 and req->tp_block_nr to 1 > 2. set tp_block_nr to 0 > Then pg_vec was freed, and we did not delete the timer? Thanks for testing! Ah, I overlook

Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

On Sat, 22 Jul 2017 23:09:41 +0100 Salil Mehta wrote: > + HNS3_NETDEV_STAT("rx_packets", rx_packets), > + HNS3_NETDEV_STAT("tx_packets", tx_packets), > + HNS3_NETDEV_STAT("rx_bytes", rx_bytes), > + HNS3_NETDEV_STAT("tx_bytes", tx_bytes), > +

[PATCH-next] net: ethernet: mediatek: fix implicit irq include causing build fails

To fix: drivers/net/ethernet/mediatek/mtk_eth_soc.c:1685:1: error: unknown type name 'irqreturn_t' drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function 'mtk_handle_irq_rx': drivers/net/ethernet/mediatek/mtk_eth_soc.c:1694:9: error: 'IRQ_HANDLED' undeclared (first use in this function)

Re: [PATCH net-next v3 1/1] geneve: add rtnl changelink support

On Thu, Jul 20, 2017 at 10:44 PM, Girish Moodalbail wrote: > This patch adds changelink rtnl operation support for geneve devices > and the code changes involve: > > - added geneve_quiesce() which quiesces the geneve device data path > for both TX and RX. This

Re: [PATCH V4 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC

On 07/22/2017 03:09 PM, Salil Mehta wrote: > This patch adds the support of MDIO bus interface for HNS3 driver. > Code provides various interfaces to start and stop the PHY layer > and to read and write the MDIO bus or PHY. > > Signed-off-by: Daode Huang >

[PATCH net-next] skbuff: re-add check for NULL skb->head in kfree_skb path

A null check is needed after all. netlink skbs can have skb->head be backed by vmalloc. The netlink destructor vfree()s head, then sets it to NULL. We then panic in skb_release_data with a NULL dereference. Re-add such a test. Alternative would be to switch to kvfree to free skb->head memory

Kernel TLS in 4.13-rc1

Hi! I recently wanted to take a look at the kernel TLS support that made it into 4.13-rc1, but ran into some issues. After fixing the benchmark/test tool that the patch description linked to (https://github.com/Mellanox/tls-af_ktls_tool) to make sure that the server and client actually *agree*

[PATCH-next] liquidio: fix implicit irq include causing build failures

To fix In file included from drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:24:0: drivers/net/ethernet/cavium/liquidio/octeon_device.h:216:2: error: expected specifier-qualifier-list before ‘irqreturn_t’ irqreturn_t (*process_interrupt_regs)(void *); ^ as seen on arm64 allmodconfig

[PATCH] of_mdio: kill useless variable in of_phy_register_fixed_link()

of_phy_register_fixed_link() declares the 'err' variable to hold the result of of_property_read_string() but only uses it once after that, while that function can be called directly from the *if* statement... Remove that variable and move/regroup 'link_gpio' and 'len' variables in order to sort

?

> Did you receive my previous mail ? When and what time can i call you?

Re: [PATCH net-next v2 00/13] Change DSA's FDB API and perform switchdev cleanup

On 07/20/2017 07:26 PM, Vivien Didelot wrote: > Hi Arkadi, > > Arkadi Sharshevsky writes: > >> Hi, thanks for the test. If the fdb is marked as self its not in the >> bridge at all. So before my patch it was OK because you supported the >> self thing. >> >> Please notice

Re: [PATCH-next] net: ethernet: mediatek: fix implicit irq include causing build fails

[Re: [PATCH-next] net: ethernet: mediatek: fix implicit irq include causing build fails] On 23/07/2017 (Sun 17:16) John Crispin wrote: > Hi Paul > > mark sent the same patch a couple of days ago [1] OK, thanks -- I searched for mediatek in my mail and scanned netdev patchworks for patches in

Re: [PATCH-next] net: ethernet: mediatek: fix implicit irq include causing build fails

Hi Paul mark sent the same patch a couple of days ago [1] John [1] https://patchwork.ozlabs.org/patch/791550/ On 23/07/17 16:56, Paul Gortmaker wrote: To fix: drivers/net/ethernet/mediatek/mtk_eth_soc.c:1685:1: error: unknown type name 'irqreturn_t'

Greetings'''''

Greetings! I have a proposal for you, this however is not mandatory nor will I in any manner compel you to honor against your will. I am Dr.Paul Benk a former executive director with Arab Tunisian Bank here in Tunis; I retired 1 year 7 months ago after putting in 28 years of meticulous service.

Re: [PATCH net] openvswitch: fix potential out of bound access in parse_ct

On Sun, Jul 23, 2017 at 2:52 AM, Liping Zhang wrote: > From: Liping Zhang > > Before the 'type' is validated, we shouldn't use it to fetch the > ovs_ct_attr_lens's minlen and maxlen, else, out of bound access > may happen. > > Fixes: 7f8a436eaa2c

Re: [PATCH V4 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

On 07/22/2017 03:09 PM, Salil Mehta wrote: > This patch adds the support of Hisilicon Network Subsystem 3 > Ethernet driver to hip08 family of SoCs. > > This driver includes basic Rx/Tx functionality. It also includes > the client registration code with the HNAE3(Hisilicon Network >

Re: af_packet: use after free in prb_retire_rx_blk_timer_expired

On 2017/7/24 1:03, Cong Wang wrote: > On Sun, Jul 23, 2017 at 5:48 AM, liujian (CE) wrote: >> Hi >> >> I find it caused by below steps: >> 1. set tp_version to TPACKET_V3 and req->tp_block_nr to 1 >> 2. set tp_block_nr to 0 >> Then pg_vec was freed, and we did not delete

Re: af_packet: use after free in prb_retire_rx_blk_timer_expired

On 2017/7/24 9:09, Ding Tianhong wrote: > > > On 2017/7/24 1:03, Cong Wang wrote: >> On Sun, Jul 23, 2017 at 5:48 AM, liujian (CE) wrote: >>> Hi >>> >>> I find it caused by below steps: >>> 1. set tp_version to TPACKET_V3 and req->tp_block_nr to 1 >>> 2. set tp_block_nr

Re: [PATCH] ceph: kernel client startsync can be removed

> On 21 Jul 2017, at 17:20, Yanhu Cao wrote: > > kernel client is still sending write,startsync. > that startsync is a no-op (has been for years) and can probably be removed > > Link: http://tracker.ceph.com/issues/20604 > > Signed-off-by: Yanhu Cao >

Re: [PATCH] lib: test_rhashtable: fix for large entry counts

On Fri, Jul 21, 2017 at 04:51:31PM +0200, Phil Sutter wrote: > During concurrent access testing, threadfunc() concatenated thread ID > and object index to create a unique key like so: > > | tdata->objs[i].value = (tdata->id << 16) | i; > > This breaks if a user passes an entries parameter of 64k

[PATCH 1/1] mlx4_en: remove unnecessary returned value

The function mlx4_en_arm_cq always returns zero. So change the return type of the function mlx4_en_arm_cq to void. CC: Joe Jin CC: Junxiao Bi Signed-off-by: Zhu Yanjun --- drivers/net/ethernet/mellanox/mlx4/en_cq.c | 4 +---

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

Hi Cong, On Fri, Jul 21, 2017 at 11:42:46AM -0700, Cong Wang wrote: > On Thu, Jul 20, 2017 at 8:23 AM, Hangbin Liu wrote: > > 2017-07-20 23:06 GMT+08:00 Hangbin Liu : > >>> +++ b/net/ipv6/route.c > >>> @@ -3637,12 +3637,6 @@ static int

[PATCH net-next v11 1/4] net netlink: Add new type NLA_BITFIELD_32

From: Jamal Hadi Salim Generic bitflags attribute content sent to the kernel by user. With this type the user can either set or unset a flag in the kernel. The nla_value is a bitmap that defines the values being set The nla_selector is a bitmask that defines which value is

[PATCH net-next v11 4/4] net sched actions: add time filter for action dumping

From: Jamal Hadi Salim This patch adds support for filtering based on time since last used. When we are dumping a large number of actions it is useful to have the option of filtering based on when the action was last used to reduce the amount of data crossing to user space.

[PATCH net-next v11 2/4] net sched actions: Use proper root attribute table for actions

From: Jamal Hadi Salim Bug fix for an issue which has been around for about a decade. We got away with it because the enumeration was larger than needed. Fixes: 7ba699c604ab ("[NET_SCHED]: Convert actions from rtnetlink to new netlink API") Suggested-by: Jiri Pirko

[PATCH net-next v11 3/4] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

From: Jamal Hadi Salim When you dump hundreds of thousands of actions, getting only 32 per dump batch even when the socket buffer and memory allocations allow is inefficient. With this change, the user will get as many as possibly fitting within the given constraints

[PATCH net-next v11 0/4] net sched actions: improve dump performance

From: Jamal Hadi Salim Changes since v10: - 1) Jiri: move type->validate_content() to its own patch Jamal: decided to remove it altogether so we can get this patch set in. 2) Change name of NLA_FLAG_BITS to NLA_BITFIELD_32 based on discussions with D. Ahern

Re: [PATCH V2 3/4] net-next: dsa: fix flow dissection

Hi John, [auto build test ERROR on net-next/master] [also build test ERROR on v4.13-rc1 next-20170721] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

Hi Roopa, On Sat, Jul 22, 2017 at 09:55:51PM -0700, Roopa Prabhu wrote: > On Thu, Jul 20, 2017 at 7:51 AM, Hangbin Liu wrote: > > After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib > > result when requested"). When we get a prohibit ertry, we will return

Re: A buggy behavior for Linux TCP Reno and HTCP

On Fri, Jul 21, 2017 at 5:16 PM, Yuchung Cheng wrote: > On Fri, Jul 21, 2017 at 1:46 PM, Neal Cardwell wrote: >> On Fri, Jul 21, 2017 at 4:27 PM, Lisong Xu wrote: >>> >>> Hi Yuchung, >>> >>> This test scenario is only one example to trigger

Re: A buggy behavior for Linux TCP Reno and HTCP

On Sun, Jul 23, 2017 at 10:36 PM, Neal Cardwell wrote: > On Fri, Jul 21, 2017 at 5:16 PM, Yuchung Cheng wrote: >> On Fri, Jul 21, 2017 at 1:46 PM, Neal Cardwell wrote: >>> On Fri, Jul 21, 2017 at 4:27 PM, Lisong Xu