Re: [PATCH] netfilter: ipvs: Fix space before '[' error.

On Sun, Jul 30, 2017 at 12:29:25PM +0530, Arvind Yadav wrote: > Fix checkpatch.pl error: > ERROR: space prohibited before open square bracket '['. > > Signed-off-by: Arvind Yadav Thanks, applied for v4.14.

[PATCH net-next v3 4/4] MAINTAINERS: add Sean/Nelson as MediaTek ethernet maintainers

From: Sean Wang Sean and Nelson work for MediaTek on maintaining the MediaTek ethernet driver for the existing SoCs and adding support for the following SoCs. In the past, Sean has been active at making most of the qualifications , stress test and submitting a lot of

[PATCH net-next v3 1/4] dt-bindings: net: mediatek: add support for MediaTek MT7623 and MT7622 SoC

From: Sean Wang The patch adds the supplements in the dt-binding document for MediaTek MT7622 SoC with extra SGMII system controller and relevant clock consumers listed as the requirements for those SoCs equipped with the SGMII circuit. Also, add the missing binding

Re: [PATCH 1/2] ipv6: constify inet6_protocol structures

On Mon, 31 Jul 2017, Eric Dumazet wrote: > On Fri, 2017-07-28 at 22:18 +0200, Julia Lawall wrote: > > The inet6_protocol structure is only passed as the first argument to > > inet6_add_protocol or inet6_del_protocol, both of which are declared as > > const. Thus the inet6_protocol structure

[PATCH] netfilter: fix stringop-overflow warning with UBSAN

Using gcc-7 with UBSAN enabled, we get this false-positive warning: net/netfilter/ipset/ip_set_core.c: In function 'ip_set_sockfn_get': net/netfilter/ipset/ip_set_core.c:1998:3: error: 'strncpy' writing 32 bytes into a region of size 2 overflows the destination [-Werror=stringop-overflow=]

Re: [RFC PATCH v1] net: ethernet: nb8800: Reset HW block in ndo_open

On 29/07/2017 17:18, Florian Fainelli wrote: > On 07/29/2017 05:02 AM, Mason wrote: > >> I have identified a 100% reproducible flaw. >> I have proposed a work-around that brings this down to 0 >> (tested 1000 cycles of link up / ping / link down). > > Can you also try to get help from your HW

RE: [PATCH V5 net-next 2/8] net: hns3: Add support of the HNAE3 framework

Hi Leon, > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Leon Romanovsky > Sent: Sunday, July 30, 2017 10:59 AM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); >

[PATCH] ISDN: eicon: fix array-bounds warning properly

I patched a variant of this warning before, but now saw it come back in a different configuration with gcc-7 and UBSAN: drivers/isdn/hardware/eicon/message.c: In function 'mixer_notify_update': drivers/isdn/hardware/eicon/message.c:11162:54: error: array subscript is above array bounds

Re: [PATCH v2 net-next 0/4] net: dsa: lan9303: Fix MDIO issues.

Hi Egil, On Sunday 30 July 2017 19:58:52 Egil Hjelmeland wrote: > This series fix the MDIO interface for the lan9303 DSA driver. > Bugs found after testing on actual HW. > > This series is extracted from the first patch of my first large > series. Significant changes from that version are: > -

[PATCH net-next] ipv6: Avoid going through ->sk_net to access the netns

There is no need to go through sk->sk_net to access the net namespace and its sysctl variables because we allocate the sock and initialize sk_net just a few lines earlier in the same routine. Signed-off-by: Jakub Sitnicki --- net/ipv6/af_inet6.c | 2 +- 1 file changed, 1

[PATCH net-next v3 3/4] net-next: mediatek: add support for MediaTek MT7622 SoC

From: Sean Wang This patch adds the driver for ethernet controller on MT7622 SoC. It has the similar handling logic as the previously MT7623 does, but there are additions against with MT7623 SoC, the shared SGMII given for the dual GMACs and including 5-ports 10/100

[PATCH net-next v3 2/4] net-next: mediatek: add platform data to adapt into various hardware

From: Sean Wang This patch is the preparation patch in order to adapt into various hardware through adding platform data which holds specific characteristics among MediaTek SoCs and introducing the unified clock handler for those distinct clock requirements depending on

C O N G R A T U L A T I O N S

If You Are Still Using This E-mail : - YOU WON $500,000.00 USD - For More Details, Contact - Name: MELISSA BINTI MUBARAK E-mail: westernunion.melissamuba...@gmail.com

Re: [PATCH] ss: Enclose IPv6 address in brackets

On Sat, Jul 29, 2017 at 02:29:10PM +0200, Florian Lehner wrote: > This patch adds support for RFC2732 IPv6 address format with brackets > for the tool ss. So output for ss changes from > 2a00:1450:400a:804::200e:443 to [2a00:1450:400a:804::200e]:443 for IPv6 > addresses with attached port number.

[PATCH net-next v3 0/4] net-next: mediatek: add support for ethernet on MT7622 SoC

From: Sean Wang Changes since v2: - update John's mail Changes since v1: - add refinement for ethernet clock management - take out the code block for ESW, add it until ESW driver is actually introduced The series adds the driver for ethernet controller found on MT7622

Re: [PATCH net-next v3 4/4] MAINTAINERS: add Sean/Nelson as MediaTek ethernet maintainers

On 31/07/17 12:05, sean.w...@mediatek.com wrote: From: Sean Wang Sean and Nelson work for MediaTek on maintaining the MediaTek ethernet driver for the existing SoCs and adding support for the following SoCs. In the past, Sean has been active at making most of the

[PATCH net-next 1/2] net: dsa: lan9303: Refactor lan9303_xxx_packet_processing()

lan9303_enable_packet_processing, lan9303_disable_packet_processing() Pass port number (0,1,2) as parameter instead of port offset. Plus replaced a constant 0x400 with LAN9303_SWITCH_PORT_REG(). Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 59

[PATCH net-next 0/2] Refactor lan9303_xxx_packet_processing

First patch: Change lan9303_enable_packet_processing, lan9303_disable_packet_processing(): Pass port number (0,1,2) as parameter instead of port offset. Plus replaced a constant 0x400 with LAN9303_SWITCH_PORT_REG() Second patch: Simplify accordingly. Comments welcome! Egil Hjelmeland (2):

Re: [PATCH v5 net-next] net: systemport: Support 64bit statistics

On Mon, 2017-07-31 at 01:01 +0100, Jianming.qiao wrote: ... > + for (q = 0; q < dev->num_tx_queues; q++) { > + ring = >tx_rings[q]; > + do { > + start = u64_stats_fetch_begin_irq(>syncp); > + tx_bytes += ring->bytes; > +

Re: [RFC] net: make net.core.{r,w}mem_{default,max} namespaced

On Wed, 2017-07-26 at 19:03 +0200, Matteo Croce wrote: > The following sysctl are global and can't be read or set from a netns: > > net.core.rmem_default > net.core.rmem_max > net.core.wmem_default > net.core.wmem_max > > Make the following sysctl parameters available from within a network >

[PATCH net] ppp: Fix a scheduling-while-atomic bug in del_chan

From: Gao Feng The PPTP set the pptp_sock_destruct as the sock's sk_destruct, it would trigger this bug when __sk_free is invoked in atomic context, because of the call path pptp_sock_destruct->del_chan->synchronize_rcu. Now move the synchronize_rcu to pptp_release from

[PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage

Simplify usage of lan9303_enable_packet_processing, lan9303_disable_packet_processing() Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git

Re: [net-next PATCH 11/12] net: add notifier hooks for devmap bpf map

On 07/30/2017 03:28 PM, Levin, Alexander (Sasha Levin) wrote: On Mon, Jul 17, 2017 at 09:30:02AM -0700, John Fastabend wrote: @@ -341,9 +368,11 @@ static int dev_map_update_elem(struct bpf_map *map, void *key, void *value, * Remembering the driver side flush operation will happen

Re: [patch net-next 10/20] net: sched: cls_bpf: rename cls_bpf_modify_existing function

On 07/28/2017 04:40 PM, Jiri Pirko wrote: From: Jiri Pirko The name cls_bpf_modify_existing is highly misleading, as it indeed does not modify anything existing. It does not modify at all. Signed-off-by: Jiri Pirko Acked-by: Daniel Borkmann

Re: [PATCH 1/2] ipv6: constify inet6_protocol structures

On Fri, 2017-07-28 at 22:18 +0200, Julia Lawall wrote: > The inet6_protocol structure is only passed as the first argument to > inet6_add_protocol or inet6_del_protocol, both of which are declared as > const. Thus the inet6_protocol structure itself can be const. > > Also drop __read_mostly

RE: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

From: Florian Fainelli > Sent: 28 July 2017 18:05 ... > +EXPORT_SYMBOL(lan9303_indirect_phy_ops); > >>> > >>> Isn't EXPORT_SYMBOL_GPL prefered over EXPORT_SYMBOL? > >> > >> I have no opinion. I just used the same variant as the other EXPORTS > >> in the file. > > > > If there is no concern

Re: [patch net-next 16/20] net: sched: cls_bpf: no need to call tcf_exts_change for newly allocated struct

On 07/28/2017 04:40 PM, Jiri Pirko wrote: From: Jiri Pirko As the prog struct was allocated right before cls_bpf_set_parms call, no need to use tcf_exts_change to do atomic change, and we can just fill-up the unused exts struct directly by tcf_exts_validate. Signed-off-by:

Re: [PATCH net-next v12 0/4] net sched actions: improve dump performance

On 17-07-30 10:28 PM, David Miller wrote: Series applied, thanks. Thanks David. Attaching the iproute2 patch. I will submit an official one with man page changes later. Stephen - you take net-next changes? cheers, jamal diff --git a/include/linux/netlink.h b/include/linux/netlink.h index

[PATCH-net-next] net: add skb_frag_foreach_page and use with kmap_atomic

From: Willem de Bruijn Skb frags may contain compound pages. Various operations map frags temporarily using kmap_atomic, but this function works on single pages, not whole compound pages. The distinction is only relevant for high mem pages that require temporary mappings.

Re: Performance regression with virtio_net

On Sun, Jul 30, 2017 at 03:25:52PM -0700, Euan Kemp wrote: > I've also observed this performance regression. > > The minimal fix for me is removing the two > > if (unlikely(len > (unsigned long)ctx)) > checks added in 680557c. > > After digging a little more, the reason that check can fail

Re: [PATCH net-next 0/2] Refactor lan9303_xxx_packet_processing

On 31. juli 2017 15:22, Andrew Lunn wrote: On Mon, Jul 31, 2017 at 01:33:53PM +0200, Egil Hjelmeland wrote: First patch: Change lan9303_enable_packet_processing, lan9303_disable_packet_processing(): Pass port number (0,1,2) as parameter instead of port offset. Plus replaced a constant 0x400

Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage

Hi Egil, A few nitpicks below for lan9303_disable_processing. Egil Hjelmeland writes: > static int lan9303_disable_processing(struct lan9303 *chip) > { > - int ret; > + int p; > > - ret = lan9303_disable_packet_processing(chip, 0); > - if (ret) >

[PATCH V5 1/2] firmware: add more flexible request_firmware_async function

From: Rafał Miłecki So far we got only one function for loading firmware asynchronously: request_firmware_nowait. It didn't allow much customization of firmware loading process - there is only one bool uevent argument. Moreover this bool also controls user helper in an unclear

[PATCH net 1/2] vxlan: fix remcsum when GRO on and CHECKSUM_PARTIAL boundary is outer UDP

In the case that GRO is turned on and the original received packet is CHECKSUM_PARTIAL, if the outer UDP header is exactly at the last csum-unnecessary point, which for instance could occur if the packet comes from another Linux guest on the same Linux host, we have to do either remcsum_adjust or

[PATCH net 2/2] gue: fix remcsum when GRO on and CHECKSUM_PARTIAL boundary is outer UDP

In the case that GRO is turned on and the original received packet is CHECKSUM_PARTIAL, if the outer UDP header is exactly at the last csum-unnecessary point, which for instance could occur if the packet comes from another Linux guest on the same Linux host, we have to do either remcsum_adjust or

Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage

On 31. juli 2017 17:01, Vivien Didelot wrote: Hi Egil, Egil Hjelmeland writes: Would doing - chip->ds = dsa_switch_alloc(chip->dev, DSA_MAX_PORTS); + chip->ds = dsa_switch_alloc(chip->dev, LAN9303_NUM_PORTS); at the same time be good, or breaking the

Re: [PATCH 3/5] net: stmmac: Add Adaptrum Anarion GMAC glue layer

Hi David, On 07/28/2017 07:01 PM, David Miller wrote: From: Alexandru Gagniuc Date: Fri, 28 Jul 2017 15:07:03 -0700 Before the GMAC on the Anarion chip can be used, the PHY interface selection must be configured with the DWMAC block in reset. This layer covers a block

[PATCH V5 2/2] brcmfmac: don't warn user about NVRAM if fallback to the platform one succeeds

From: Rafał Miłecki Failing to load NVRAM *file* isn't critical if we manage to get platform NVRAM in the fallback path. It means warnings like: [ 10.801506] brcmfmac :01:00.0: Direct firmware load for brcm/brcmfmac43602-pcie.txt failed with error -2 are unnecessary &

Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage

Hi Egil, Egil Hjelmeland writes: >> It is indeed out of scope. You may want to add a first commit "net: dsa: >> lan9303: introduce LAN9303_NUM_PORTS" for instance. > > In a later series I assume? Or is allowed to add patches to a series > under review? If it makes

Re: [RFC PATCH v1] net: ethernet: nb8800: Reset HW block in ndo_open

Mason writes: > On 31/07/2017 13:59, Måns Rullgård wrote: > >> Mason writes: >> >>> On 29/07/2017 17:18, Florian Fainelli wrote: >>> On 07/29/2017 05:02 AM, Mason wrote: > I have identified a 100% reproducible flaw. > I have proposed a work-around that

Re: [RFC PATCH v1] net: ethernet: nb8800: Reset HW block in ndo_open

On 31/07/2017 16:08, Mason wrote: > Other things make no sense to me, for example in nb8800_dma_stop() > there is a polling loop: > > do { > mdelay(100); > nb8800_writel(priv, NB8800_TX_DESC_ADDR, txb->dma_desc); > wmb(); >

new sysctl tunable knob : tcp_retries2_time

I wish to suggest to developers to add this new knob : tcp_retries2_time - INTEGER This value influences the timeout (seconds) of an alive TCP connection, when RTO retransmissions remain unacknowledged. RFC 1122 recommends at least 100 seconds for the timeout,

RE: [PATCH V5 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

Hi Andrew, > -Original Message- > From: Salil Mehta > Sent: Saturday, July 29, 2017 12:57 AM > To: 'Andrew Lunn' > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil@gmail.com; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org;

Re: [PATCH V3 net-next] TLP: Don't reschedule PTO when there's one outstanding TLP retransmission

On Sun, Jul 30, 2017 at 11:29 PM, maowenan wrote: > [Mao Wenan]please refer to the attachment, test.pkt is packetdrill script. > In test.pcap, packet number 17 is the TLP probe, packet number 218 is the > retransmission packet because client don't send data packet to server.

Re: [RFC PATCH v1] net: ethernet: nb8800: Reset HW block in ndo_open

Mason writes: > On 31/07/2017 16:08, Mason wrote: > >> Other things make no sense to me, for example in nb8800_dma_stop() >> there is a polling loop: >> >> do { >> mdelay(100); >> nb8800_writel(priv, NB8800_TX_DESC_ADDR, txb->dma_desc); >>

Re: [PATCH] ss: Enclose IPv6 address in brackets

On Mon, 31 Jul 2017 12:30:10 +0200 Phil Sutter wrote: > On Sat, Jul 29, 2017 at 02:29:10PM +0200, Florian Lehner wrote: > > This patch adds support for RFC2732 IPv6 address format with brackets > > for the tool ss. So output for ss changes from > > 2a00:1450:400a:804::200e:443 to

Re: [PATCH net-next 1/2] net: dsa: lan9303: Refactor lan9303_xxx_packet_processing()

On Mon, Jul 31, 2017 at 01:33:54PM +0200, Egil Hjelmeland wrote: > lan9303_enable_packet_processing, lan9303_disable_packet_processing() > Pass port number (0,1,2) as parameter instead of port offset. > > Plus replaced a constant 0x400 with LAN9303_SWITCH_PORT_REG(). > > Signed-off-by: Egil

Re: [RFC PATCH v1] net: ethernet: nb8800: Reset HW block in ndo_open

Mason writes: > On 29/07/2017 17:18, Florian Fainelli wrote: > >> On 07/29/2017 05:02 AM, Mason wrote: >> >>> I have identified a 100% reproducible flaw. >>> I have proposed a work-around that brings this down to 0 >>> (tested 1000 cycles of link up / ping / link down). >> >>

Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage

Hi Egil, Egil Hjelmeland writes: > Would doing > > - chip->ds = dsa_switch_alloc(chip->dev, DSA_MAX_PORTS); > + chip->ds = dsa_switch_alloc(chip->dev, LAN9303_NUM_PORTS); > > at the same time be good, or breaking the scope of the patch? It is indeed out of

Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec

On 17-07-31 02:36 AM, Jiri Pirko wrote: Sun, Jul 30, 2017 at 09:48:24PM CEST, j...@mojatatu.com wrote: I am probably missing something. All those changes to just replace "if (exts->nr_actions)" with "if (tcf_exts_has_actions(exts))" ? That is what the description says :) I meant I wouldve

Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode

On Sat, Jul 29, 2017 at 2:48 PM, Corentin Labbe wrote: > On Fri, Jul 28, 2017 at 10:54:30AM -0700, Florian Fainelli wrote: >> On 07/28/2017 07:44 AM, Corentin Labbe wrote: >> > On Fri, Jul 28, 2017 at 04:36:00PM +0200, Andrew Lunn wrote: >> I've probably asked this

Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode

On Mon, Jul 31, 2017 at 08:19:40PM +0800, Chen-Yu Tsai wrote: > On Sat, Jul 29, 2017 at 2:48 PM, Corentin Labbe > wrote: > > On Fri, Jul 28, 2017 at 10:54:30AM -0700, Florian Fainelli wrote: > >> On 07/28/2017 07:44 AM, Corentin Labbe wrote: > >> > On Fri, Jul 28, 2017

Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage

On 31. juli 2017 15:46, Andrew Lunn wrote: On Mon, Jul 31, 2017 at 01:33:55PM +0200, Egil Hjelmeland wrote: Simplify usage of lan9303_enable_packet_processing, lan9303_disable_packet_processing() Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c |

[PATCH net] udp6: fix jumbogram reception

Since commit 67a51780aebb ("ipv6: udp: leverage scratch area helpers") udp6_recvmsg() read the skb len from the scratch area, to avoid a cache miss. But the UDP6 rx path support RFC 2675 UDPv6 jumbograms, and their length exceeds the 16 bits available in the scratch area. As a side effect the

RE: [RFC PATCH v1 5/5] wave: Added basic version of TCP Wave

From: Natale Patriciello > Sent: 28 July 2017 20:59 .. > +static __always_inline bool test_flag(u8 value, const u8 *flags) > +{ > + return (*flags & value) == value; > +} ... > + if (!test_flag(FLAG_INIT, >flags)) > + return; ... That is a completely unnecessary 'helper'. It

Re: [RFC PATCH v1] net: ethernet: nb8800: Reset HW block in ndo_open

On 31/07/2017 13:59, Måns Rullgård wrote: > Mason writes: > >> On 29/07/2017 17:18, Florian Fainelli wrote: >> >>> On 07/29/2017 05:02 AM, Mason wrote: >>> I have identified a 100% reproducible flaw. I have proposed a work-around that brings this down to 0 (tested 1000 cycles of

Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec

Mon, Jul 31, 2017 at 02:09:22PM CEST, j...@mojatatu.com wrote: >On 17-07-31 02:36 AM, Jiri Pirko wrote: >> Sun, Jul 30, 2017 at 09:48:24PM CEST, j...@mojatatu.com wrote: >> > I am probably missing something. All those changes to just >> > replace "if (exts->nr_actions)" with "if

Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage

On Mon, Jul 31, 2017 at 01:33:55PM +0200, Egil Hjelmeland wrote: > Simplify usage of lan9303_enable_packet_processing, > lan9303_disable_packet_processing() > > Signed-off-by: Egil Hjelmeland > --- > drivers/net/dsa/lan9303-core.c | 24 ++-- > 1

Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage

Hi Egil, Egil Hjelmeland writes: >>> + for (p = 0; p <= 2; p++) { >> >> Exclusive limits are often prefer, i.e. 'p < 3'. >> > OK, that can be nice when I later introduce LAN9303_NUM_PORTS = 3. This is indeed another reason what exclusive limits are prefered ;-)

Re: [net-next PATCH 11/12] net: add notifier hooks for devmap bpf map

On 07/31/2017 01:55 AM, Daniel Borkmann wrote: > On 07/30/2017 03:28 PM, Levin, Alexander (Sasha Levin) wrote: >> On Mon, Jul 17, 2017 at 09:30:02AM -0700, John Fastabend wrote: >>> @@ -341,9 +368,11 @@ static int dev_map_update_elem(struct bpf_map *map, >>> void *key, void *value, >>> *

Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage

> >Reviewed-by: Andrew Lunn > > > > Andrew > > > > Hi Andrew > > This time I took the extra effort to split my original patch... > > Your lan9303_write_switch_port suggestion (in previous reply) is fine. > And I can improve the coverletter. > > So I will do a v2 of the

Re: [PATCH net-next v12 1/4] net netlink: Add new type NLA_BITFIELD32

On 17-07-31 02:38 AM, Jiri Pirko wrote: Sun, Jul 30, 2017 at 09:59:10PM CEST, j...@mojatatu.com wrote: Jiri, This is getting exhausting, seriously. I posted the code you are commenting one two days ago so i dont have to repost. And I commented on the "*u32 = *u32" thing. But you ignored it.

Re: [PATCH net-next v12 1/4] net netlink: Add new type NLA_BITFIELD32

Mon, Jul 31, 2017 at 02:03:55PM CEST, j...@mojatatu.com wrote: >On 17-07-31 02:38 AM, Jiri Pirko wrote: >> Sun, Jul 30, 2017 at 09:59:10PM CEST, j...@mojatatu.com wrote: >> > Jiri, >> > >> > This is getting exhausting, seriously. >> > I posted the code you are commenting one two days ago so i

Re: [PATCH net-next 0/2] Refactor lan9303_xxx_packet_processing

On Mon, Jul 31, 2017 at 01:33:53PM +0200, Egil Hjelmeland wrote: > First patch: > Change lan9303_enable_packet_processing, > lan9303_disable_packet_processing(): > Pass port number (0,1,2) as parameter instead of port offset. > Plus replaced a constant 0x400 with LAN9303_SWITCH_PORT_REG() Hi

Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage

On 31. juli 2017 16:00, Vivien Didelot wrote: Hi Egil, A few nitpicks below for lan9303_disable_processing. Egil Hjelmeland writes: static int lan9303_disable_processing(struct lan9303 *chip) { - int ret; + int p; - ret =

Re: Performance regression with virtio_net

On Mon, Jul 31, 2017 at 04:26:08PM +0300, Michael S. Tsirkin wrote: > On Sun, Jul 30, 2017 at 03:25:52PM -0700, Euan Kemp wrote: > > I've also observed this performance regression. > > > > The minimal fix for me is removing the two > > > if (unlikely(len > (unsigned long)ctx)) > > checks added in

Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage

On 31. juli 2017 16:43, Vivien Didelot wrote: Hi Egil, Egil Hjelmeland writes: + for (p = 0; p <= 2; p++) { Exclusive limits are often prefer, i.e. 'p < 3'. OK, that can be nice when I later introduce LAN9303_NUM_PORTS = 3. This is indeed another reason

Re: [PATCH net V3 2/2] net: fix tcp reset packet flowlabel for ipv6

On Mon, Jul 31, 2017 at 11:10:38AM -0700, Cong Wang wrote: > On Mon, Jul 31, 2017 at 10:08 AM, Shaohua Li wrote: > > +/* Like ip6_make_flowlabel, but already has hash */ > > +static inline __be32 ip6_make_flowlabel_from_hash(struct net *net, > > +

Re: [RFC net-next] net ipv6: convert fib6_table rwlock to a percpu lock

On Mon, Jul 31, 2017 at 11:30:53AM -0700, Eric Dumazet wrote: > On Mon, 2017-07-31 at 10:18 -0700, Shaohua Li wrote: > > From: Shaohua Li > > > > In a syn flooding test, the fib6_table rwlock is a significant > > bottleneck. While converting the rwlock to rcu sounds straighforward,

Re: [PATCH] ISDN: eicon: fix array-bounds warning properly

Hi Arnd, I think you are right, but removing this is maybe the wrong fix. The issue is, that CAPI messages are packed byte streams and yes the 64bit extension of CAPI is not very good designed for modern CPU constrains with alignment, since the data pointer for the buffer is not on a 64bit

Re: [RFC net-next 0/6] tcp: remove prequeue and header prediction

On Sat, Jul 29, 2017 at 7:25 PM, Neal Cardwell wrote: > On Thu, Jul 27, 2017 at 7:31 PM, Florian Westphal wrote: >> This RFC removes tcp prequeueing and header prediction support. >> >> After a hallway discussion with Eric Dumazet some >>

Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec

On Fri, Jul 28, 2017 at 7:40 AM, Jiri Pirko wrote: > +static inline int > +tcf_exts_exec(struct sk_buff *skb, struct tcf_exts *exts, > + struct tcf_result *res) > +{ > +#ifdef CONFIG_NET_CLS_ACT > + if (tcf_exts_has_actions(exts)) > + return

[PATCH v2] ss: Enclose IPv6 address in brackets

This updated patch adds support for RFC2732 IPv6 address format with brackets for the tool ss. Resolved hostnames will not be enclosed in brackets, therefore the global variable resolve_hosts is initialized and checked. Signed-off-by: Lehner Florian --- misc/ss.c | 8 ++--

Re: [PATCH net] Revert "net: bcmgenet: Remove init parameter from bcmgenet_mii_config"

On 07/31/2017 11:05 AM, Florian Fainelli wrote: > This reverts commit 28b45910ccda ("net: bcmgenet: Remove init parameter > from bcmgenet_mii_config") because in the process of moving from > dev_info() to dev_info_once() we essentially lost the helpful printed > messages once the second instance

Re: [PATCH v2] ss: Enclose IPv6 address in brackets

On Mon, Jul 31, 2017 at 09:50:04PM +0200, Florian Lehner wrote: > This updated patch adds support for RFC2732 IPv6 address format with > brackets for the tool ss. Resolved hostnames will not be enclosed in > brackets, therefore the global variable resolve_hosts is initialized and > checked. > >

[PATCH net V3 1/2] net: remove unnecessary rotation

From: Shaohua Li According to David Miller, the rotation doesn't really help avoid security problem, so delte it. Suggested-by: David Miller Signed-off-by: Shaohua Li --- include/net/ipv6.h | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH net V3 2/2] net: fix tcp reset packet flowlabel for ipv6

From: Shaohua Li Please see below tcpdump output: 21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload length: 40) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.: Flags [S], cksum 0x0529 (incorrect -> 0xf56c), seq 3282214508, win 43690,

[RFC net-next] net ipv6: convert fib6_table rwlock to a percpu lock

From: Shaohua Li In a syn flooding test, the fib6_table rwlock is a significant bottleneck. While converting the rwlock to rcu sounds straighforward, but is very challenging if it's possible. A percpu spinlock is quite trival for this problem since updating the routing table is a

Re: [PATCH] hyperv: netvsc: Neaten netvsc_send_pkt by using a temporary

On Mon, 2017-07-31 at 10:05 -0700, Stephen Hemminger wrote: > On Sun, 30 Jul 2017 14:19:30 -0700 Joe Perches wrote: > > Repeated dereference of nvmsg.msg.v1_msg.send_rndis_pkt can be > > shortened by using a temporary. Do so. [] > Looks good, several other places also suffer

Re: [PATCH net] mcs7780: Silence uninitialized variable warning

From: Dan Carpenter Date: Mon, 31 Jul 2017 10:41:40 +0300 > On Sat, Jul 29, 2017 at 11:28:55PM -0700, David Miller wrote: >> From: Dan Carpenter >> Date: Fri, 28 Jul 2017 17:45:11 +0300 >> >> > - __u16 rval; >> > + __u16 rval = -1; >> >>

Re: Please merge net into net-next

From: Edward Cree Date: Mon, 31 Jul 2017 18:25:16 +0100 > Could you please merge net into net-next, so I can rebase my BPF patches? > Otherwise there's likely to be merge conflicts with the BPF_SUB fix. I'll do this soon.

Re: [PATCH v2] ravb: add wake-on-lan support via magic packet

Hello! On 07/30/2017 05:06 PM, Niklas Söderlund wrote: WoL is enabled in the suspend callback by setting MagicPacket detection and disabling all interrupts expect MagicPacket. In the resume path the driver needs to reset the hardware to rearm the WoL logic, this prevents the driver from simply

Re: [PATCH] Cipso: cipso_v4_optptr enter infinite loop

On Sun, Jul 30, 2017 at 11:23 PM, Yujuan Qi wrote: > From: "yujuan.qi" > > in for(),if((optlen > 0) && (optptr[1] == 0)), enter infinite loop. > > Test: receive a packet which the ip length > 20 and the first byte of ip > option is 0, produce this

Re: [RFC net-next 0/6] tcp: remove prequeue and header prediction

On Mon, Jul 31, 2017 at 1:04 PM, Yuchung Cheng wrote: > by the time these devices use 4.12 kernels they are likely powerful > enough to make header prediction irrelevant... Also note that TCP stack complexity has increased a lot, I seriously doubt anyone could notice any

Re: [PATCH] ISDN: eicon: fix array-bounds warning properly

On Mon, Jul 31, 2017 at 9:38 PM, wrote: > Hi Arnd, > > I think you are right, but removing this is maybe the wrong fix. > > The issue is, that CAPI messages are packed byte streams and yes the > 64bit extension of CAPI is not very good designed for modern CPU > constrains

Re: [PATCH] hyperv: netvsc: Neaten netvsc_send_pkt by using a temporary

On Sun, 30 Jul 2017 14:19:30 -0700 Joe Perches wrote: > Repeated dereference of nvmsg.msg.v1_msg.send_rndis_pkt can be > shortened by using a temporary. Do so. > > No change in object code. > > Signed-off-by: Joe Perches Looks good, several other places

Please merge net into net-next

Hi Dave, Could you please merge net into net-next, so I can rebase my BPF patches? Otherwise there's likely to be merge conflicts with the BPF_SUB fix. Thanks, -Ed

[PATCH V2] hyperv: netvsc: Neaten netvsc_send_pkt by using a temporary

Repeated dereference of nvmsg.msg.v1_msg.send_rndis_pkt can be shortened by using a temporary. Do so. No change in object code. Miscellanea: o Use * const for rpkt and nvchan Signed-off-by: Joe Perches --- v2: Use * const for rpkt and nvchan This is a fairly unusual

Re: [PATCH net V3 2/2] net: fix tcp reset packet flowlabel for ipv6

On Mon, Jul 31, 2017 at 10:08 AM, Shaohua Li wrote: > +/* Like ip6_make_flowlabel, but already has hash */ > +static inline __be32 ip6_make_flowlabel_from_hash(struct net *net, > + bool autolabel, u32 hash) > +{ > + __be32

[PATCH net] Revert "net: bcmgenet: Remove init parameter from bcmgenet_mii_config"

This reverts commit 28b45910ccda ("net: bcmgenet: Remove init parameter from bcmgenet_mii_config") because in the process of moving from dev_info() to dev_info_once() we essentially lost the helpful printed messages once the second instance of the driver is loaded. dev_info_once() does not

Re: [RFC net-next] net ipv6: convert fib6_table rwlock to a percpu lock

On Mon, 2017-07-31 at 10:18 -0700, Shaohua Li wrote: > From: Shaohua Li > > In a syn flooding test, the fib6_table rwlock is a significant > bottleneck. While converting the rwlock to rcu sounds straighforward, > but is very challenging if it's possible. A percpu spinlock is quite >

Re: [PATCH 1/1 v2] netfilter: constify nf_conntrack_l3/4proto parameters

Hi Julia, On Sun, Jul 30, 2017 at 09:38:44PM +0200, Julia Lawall wrote: > When a nf_conntrack_l3/4proto parameter is not on the left hand side > of an assignment, its address is not taken, and it is not passed to a > function that may modify its fields, then it can be declared as const. > > This

Re: [PATCH] ss: Enclose IPv6 address in brackets

On Mon, Jul 31, 2017 at 09:27:55AM -0700, Stephen Hemminger wrote: > On Mon, 31 Jul 2017 12:30:10 +0200 > Phil Sutter wrote: > > > On Sat, Jul 29, 2017 at 02:29:10PM +0200, Florian Lehner wrote: > > > This patch adds support for RFC2732 IPv6 address format with brackets > > > for

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

Hi Kurt, On 07/28/2017 09:41 PM, Kurt Van Dijck wrote: The transceiver is an analog device that needs to support faster switching frequency (FETs) including minimizing delay to support CAN-FD ie higher bitrate. From the transceiver perspective the bits for "arbitration" and "data" look exactly

[PATCH net] virtio_net: fix truesize for mergeable buffers

Seth Forshee noticed a performance degradation with some workloads. This turns out to be due to packet drops. Euan Kemp noticed that this is because we drop all packets where length exceeds the truesize, but for some packets we add in extra memory without updating the truesize. This in turn was

Re: Performance regression with virtio_net

On Mon, Jul 31, 2017 at 11:38:00AM -0700, Euan Kemp wrote: > On Mon, Jul 31, 2017 at 04:26:08PM +0300, Michael S. Tsirkin wrote: > > I kept this around unchanged from > > ab7db91705e95ed1bba1304388936fccfa58c992. That commit had an internal > > reason not to account for that space: not enough

[PATCH net-next 1/7] net: phy: mdio-bcm-unimac: factor busy polling loop

Factor the code that does the busy polling on the MDIO_BUSY bit since we will have different code-paths for for completion depending on whether we are using interrupts or polling. Signed-off-by: Florian Fainelli --- drivers/net/phy/mdio-bcm-unimac.c | 43

[PATCH net-next 4/7] net: phy: mdio-bcm-unimac: Allow specifying platform data

In preparation for having the bcmgenet driver migrate over the mdio-bcm-unimac driver, add a platform data structure which allows passing integrating specific details like bus name, wait function to complete MDIO operations and PHY mask. We also define what the platform device name contract is by

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On Fri, Jul 28, 2017 at 10:39 AM, David Ahern wrote: > On 7/28/17 11:13 AM, Roopa Prabhu wrote: >> for fibmatch, my original intent was to return with an error code. >> This is similar >> to the ipv4 behavior. One option is to keep the check in there and put >> the 'fibmatch'

Re: Performance regression with virtio_net

On Mon, Jul 31, 2017 at 04:26:08PM +0300, Michael S. Tsirkin wrote: > I kept this around unchanged from > ab7db91705e95ed1bba1304388936fccfa58c992. That commit had an internal > reason not to account for that space: not enough bits to do it. No > longer true so let's account for length exactly.

  1   2   3   >