Re: [PATCH net] datagram: When peeking datagrams with offset < 0 don't skip empty skbs

On Mon, Aug 14, 2017 at 2:33 PM, Thiago Macieira wrote: > On Monday, 14 August 2017 11:25:23 PDT Willem de Bruijn wrote: >> > Do applications using SOCK_DGRAM rely on the behaviour of skipping over >> > datagrams that are too short? >> >> It is established behavior. It

Re: [PATCH net] udp: fix linear skb reception with PEEK_OFF

On Mon, 2017-08-14 at 21:31 +0200, Paolo Abeni wrote: > From: Al Viro > > copy_linear_skb() is broken; both of its callers actually > expect 'len' to be the amount we are trying to copy, > not the offset of the end. > Fix it keeping the meanings of arguments in sync with

Re: [patch net-next 0/3] mlxsw: spectrum_router: Increase VRF scale

From: Jiri Pirko Date: Mon, 14 Aug 2017 10:54:02 +0200 > From: Jiri Pirko > > Ido says: > > The purpose of this set is to increase the maximum number of supported VRF > devices on top of the Spectrum ASIC under different workloads. > > This is achieved by

Re: [PATCH net] datagram: When peeking datagrams with offset < 0 don't skip empty skbs

On Mon, Aug 14, 2017 at 1:02 PM, Thiago Macieira wrote: > On Monday, 14 August 2017 09:33:48 PDT Willem de Bruijn wrote: >> > But here's a question: if the peek offset is equal to the length, should >> > the reading return an empty datagram? This would indicate to the

[PATCH V2 net-next 3/8] liquidio: moved octeon_setup_droq to lio_core.c

From: Intiyaz Basha Moving common octeon_setup_droq to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 35

[PATCH V2 net-next 7/8] liquidio: moved liquidio_setup_io_queues to lio_core.c

From: Intiyaz Basha Moving common liquidio_setup_io_queues to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 119

[PATCH V2 net-next 4/8] liquidio: moved liquidio_push_packet to lio_core.c

From: Intiyaz Basha Moving common liquidio_push_packet to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 149 +

[PATCH V2 net-next 8/8] liquidio: added support for ethtool --set-ring feature

From: Intiyaz Basha added support for ethtool --set-ring feature Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 131 +

[PATCH V2 net-next 5/8] liquidio: moved liquidio_napi_drv_callback to lio_core.c

From: Intiyaz Basha Moving common liquidio_napi_drv_callback to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 39

[PATCH V2 net-next 1/8] liquidio: moved wait_for_pending_requests to octeon_network.h

From: Intiyaz Basha Moving common function wait_for_pending_requests to octeon_network.h Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- .../ethernet/cavium/liquidio/cn23xx_vf_device.h| 2 --

[PATCH V2 net-next 6/8] liquidio: moved liquidio_napi_poll to lio_core.c

From: Intiyaz Basha Moving common liquidio_napi_poll to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 61 +-

Re: [PATCH] net/sched: reset block pointer in tcf_block_put()

On Mon, Aug 14, 2017 at 5:59 AM, Konstantin Khlebnikov wrote: > > This should work, I suppose. > > But this approach requires careful review for all qdisc, mine is completely > mechanical. Well, we don't have many classful qdisc's. Your patch actually touches more

Re: [PATCH net] datagram: When peeking datagrams with offset < 0 don't skip empty skbs

On Monday, 14 August 2017 11:25:23 PDT Willem de Bruijn wrote: > > Do applications using SOCK_DGRAM rely on the behaviour of skipping over > > datagrams that are too short? > > It is established behavior. It cannot be ruled out that an application > somewhere depends on it. Understood. By the

Re: [Intel-wired-lan] [PATCH 4/6] [net-next]net: i40e: Admin queue definitions for cloud filters

On 8/1/2017 12:16 PM, Shannon Nelson wrote: > On 7/31/2017 5:37 PM, Amritha Nambiar wrote: >> Add new admin queue definitions and extended fields for cloud >> filter support. Define big buffer for extended general fields >> in Add/Remove Cloud filters command. >> >> Signed-off-by: Amritha Nambiar

Re: [PATCH net] datagram: When peeking datagrams with offset < 0 don't skip empty skbs

On Monday, 14 August 2017 12:03:16 PDT Willem de Bruijn wrote: > On Mon, Aug 14, 2017 at 2:58 PM, Thiago Macieira > > wrote: > > On Monday, 14 August 2017 11:46:42 PDT Willem de Bruijn wrote: > >> > By the way, what were the usecases for the peek offset feature? > >>

Re: [PATCH net] ipv4: route: fix inet_rtm_getroute induced crash

From: Florian Westphal Date: Mon, 14 Aug 2017 00:52:58 +0200 > "ip route get $daddr iif eth0 from $saddr" causes: > BUG: KASAN: use-after-free in ip_route_input_rcu+0x1535/0x1b50 > Call Trace: > ip_route_input_rcu+0x1535/0x1b50 > ip_route_input_noref+0xf9/0x190 >

Re: [net 1/1] tipc: avoid inheriting msg_non_seq flag when message is returned

From: Jon Maloy Date: Mon, 14 Aug 2017 18:28:49 +0200 > In the function msg_reverse(), we reverse the header while trying to > reuse the original buffer whenever possible. Those rejected/returned > messages are always transmitted as unicast, but the msg_non_seq field > is

Re: [Intel-wired-lan] [PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier

On 8/1/2017 12:16 PM, Shannon Nelson wrote: > On 7/31/2017 5:38 PM, Amritha Nambiar wrote: >> This patch enables tc-flower based hardware offloads. tc/flower >> filter provided by the kernel is configured as driver specific >> cloud filter. The patch implements functions and admin queue >>

Re: [PATCH net] datagram: When peeking datagrams with offset < 0 don't skip empty skbs

On Mon, Aug 14, 2017 at 3:15 PM, Thiago Macieira wrote: > On Monday, 14 August 2017 12:03:16 PDT Willem de Bruijn wrote: >> On Mon, Aug 14, 2017 at 2:58 PM, Thiago Macieira >> >> wrote: >> > On Monday, 14 August 2017 11:46:42 PDT Willem de

[PATCH V2 net-next 2/8] liquidio: moved update_txq_status to lio_core.c

From: Intiyaz Basha Moving common update_txq_status to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 33

[PATCH V2 net-next 0/8] liquidio: adding support for ethtool --set-ring feature

From: Intiyaz Basha Code reorganization is required for adding ethtool --set-ring feature. First seven patches are for code reorganization. The last patch is for adding this feature. Change Log: V1 -> V2 Only patch #8 was changed: unnecessary parentheses were

Re: [PATCH net] datagram: When peeking datagrams with offset < 0 don't skip empty skbs

On Mon, Aug 14, 2017 at 2:58 PM, Thiago Macieira wrote: > On Monday, 14 August 2017 11:46:42 PDT Willem de Bruijn wrote: >> > By the way, what were the usecases for the peek offset feature? >> >> The idea was to be able to peek at application headers of upper >> layer

[patch net-next 0/2] mlxsw: Add support for nexthop group consolidation for IPv6

From: Jiri Pirko Arkadi says: Due to limited ASIC resources the maximum number of routes is limited by the nexthop resource. In order to improve the routing scale nexthop consolidation should be performed. In case of IPv4, the kernel does the consolidation of nexthops in the

[patch net-next 1/2] mlxsw: spectrum_router: Prepare nexthop group's hash table for IPv6

From: Arkadi Sharshevsky This patch does preparation before introducing IPv6 nexthop group consolidation. Currently the nexthop group hash table is used only by IPv4 and uses fixed key size. In order to support the IPv6's variable length key the current table is changed.

[patch net-next 2/2] mlxsw: spectrum_router: Add support for nexthop group consolidation for IPv6

From: Arkadi Sharshevsky Due to limited ASIC resources the maximum number of routes is limited by the nexthop resource. In order to improve the routing scale nexthop consolidation should be performed. This patch adds support for IPv6 neighbor consolidation. The hash value

[PATCH net] udp: fix linear skb reception with PEEK_OFF

From: Al Viro copy_linear_skb() is broken; both of its callers actually expect 'len' to be the amount we are trying to copy, not the offset of the end. Fix it keeping the meanings of arguments in sync with what the callers (both of them) expect. Also restore a saner

Re: ipv4: distinguish EHOSTUNREACH from the ENETUNREACH

Hi, It seems like commit cd0f0b is trying to add back these two errors values into ip_route_input_slow(). However, if you follow the code path further down you get to the two exit points of this function, in net/ipv4/route.c:ip_route_input_slow() if (rt_cache_valid(rth)) {

Cycling Enthusiasts List

Hi, Greetings of the day! Would you be interested in acquiring an email list of "Cycling Enthusiasts" from USA? We also have data for Hikign Enthusiasts, Running Enthusiasts, Camping and Outdoor Enthusiasts, Skiers List, Health and Fitness Enthusiasts, Tennis Enthusiasts, Boxing

Re: [net-next 15/15] i40e: synchronize nvmupdate command and adminq subtask

On Sat, Aug 12, 2017 at 4:08 AM, Jeff Kirsher wrote: > From: Sudheer Mogilappagari > > During NVM update, state machine gets into unrecoverable state because > i40e_clean_adminq_subtask can get scheduled after the admin queue >

RE: [net-next 08/15] i40e/i40evf: organize and re-number feature flags

> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Saturday, August 12, 2017 1:04 PM > To: Kirsher, Jeffrey T > Cc: Keller, Jacob E ; netdev@vger.kernel.org; > nhor...@redhat.com; sassm...@redhat.com;

[PATCH net-next] bpf/verifier: track liveness for pruning

State of a register doesn't matter if it wasn't read in reaching an exit; a write screens off all reads downstream of it from all explored_states upstream of it. This allows us to prune many more branches; here are some processed insn counts for some Cilium programs: Program

Re: [PATCH] qlge: fix duplicated code for different branches

From: "Gustavo A. R. Silva" Date: Sat, 12 Aug 2017 20:58:40 -0500 > Refactor code in order to avoid identical code for different branches. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH] liquidio: fix duplicated code for different branches

From: "Gustavo A. R. Silva" Date: Sat, 12 Aug 2017 20:38:55 -0500 > Refactor code in order to avoid identical code for different branches. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH net] datagram: When peeking datagrams with offset < 0 don't skip empty skbs

On Monday, 14 August 2017 11:46:42 PDT Willem de Bruijn wrote: > > By the way, what were the usecases for the peek offset feature? > > The idea was to be able to peek at application headers of upper > layer protocols and multiplex messages among threads. It proved > so complex even for UDP that

Re: [Intel-wired-lan] [PATCH 5/6] [net-next]net: i40e: Clean up of cloud filters

On 8/1/2017 12:16 PM, Shannon Nelson wrote: > On 7/31/2017 5:38 PM, Amritha Nambiar wrote: >> Introduce the cloud filter datastructure and cleanup of cloud >> filters associated with the device. >> >> Signed-off-by: Amritha Nambiar >> --- >>

Re: [iproute PATCH 51/51] lib/bpf: Check return value of write()

On 08/14/2017 07:25 PM, Phil Sutter wrote: [...] But I really think we shouldn't make such a fuss about it - writing to stderr either always works or we're in trouble everywhere. This patch was merely to shut gcc up, so no need to waste much energy on a scenario which won't happen anyway. Yup,

[PATCH net] dccp: purge write queue in dccp_destroy_sock()

From: Eric Dumazet syzkaller reported that DCCP could have a non empty write queue at dismantle time. WARNING: CPU: 1 PID: 2953 at net/core/stream.c:199 sk_stream_kill_queues+0x3ce/0x520 net/core/stream.c:199 Kernel panic - not syncing: panic_on_warn set ... CPU: 1 PID:

Re: [patch net-next 0/2] mlxsw: Add support for nexthop group consolidation for IPv6

From: Jiri Pirko Date: Mon, 14 Aug 2017 21:09:18 +0200 > From: Jiri Pirko > > Arkadi says: > > Due to limited ASIC resources the maximum number of routes is limited by > the nexthop resource. In order to improve the routing scale nexthop > consolidation

Re: [net 1/1] tipc: accept PACKET_MULTICAST packets

From: Jon Maloy Date: Mon, 14 Aug 2017 17:55:56 +0200 > On L2 bearers, the TIPC broadcast function is sending out packets using > the corresponding L2 broadcast address. At reception, we filter such > packets under the assumption that they will also be delivered as >

Re: [patch v2 0/2] Enable Mellanox switch device in I2C mode

From: Ohad Oz Date: Mon, 14 Aug 2017 15:38:20 + > The following patch set updates global to Mellanox Kconfig files to support > configuration of Mellanox Switch (mlxsw) without PCI and with I2C only. Series applied to net-next.

[PATCH net-next] liquidio: fix issues with fw_type module parameter

From: Derek Chickles The fw_type module parameter isn't showing up in the /sys/module/liquidio/parameters directory. Fix it by setting the read permission bits for user, group, other in module_param_string(). Revise the description of fw_type. Initialize the fw_type

Re: [PATCH net-next] liquidio: fix issues with fw_type module parameter

From: Felix Manlunas Date: Mon, 14 Aug 2017 12:17:56 -0700 > From: Derek Chickles > > The fw_type module parameter isn't showing up in the > /sys/module/liquidio/parameters directory. Fix it by setting the read > permission bits for user,

Re: [PATCH net] udp: fix linear skb reception with PEEK_OFF

From: Paolo Abeni Date: Mon, 14 Aug 2017 21:31:38 +0200 > From: Al Viro > > copy_linear_skb() is broken; both of its callers actually > expect 'len' to be the amount we are trying to copy, > not the offset of the end. > Fix it keeping the meanings of

Re: [PATCH V2 net-next 0/8] liquidio: adding support for ethtool --set-ring feature

From: Felix Manlunas Date: Mon, 14 Aug 2017 12:00:34 -0700 > From: Intiyaz Basha > > Code reorganization is required for adding ethtool --set-ring feature. > First seven patches are for code reorganization. The last patch is for > adding

Re: [PATCH net] ipv6: release rt6->rt6i_idev properly during ifdown

From: Wei Wang Date: Mon, 14 Aug 2017 10:44:59 -0700 > From: Wei Wang > > When a dst is created by addrconf_dst_alloc() for a host route or an > anycast route, dst->dev points to loopback dev while rt6->rt6i_idev > points to a real device. > When the real

Re: [PATCH net] af_key: do not use GFP_KERNEL in atomic contexts

From: Eric Dumazet Date: Mon, 14 Aug 2017 10:16:45 -0700 > From: Eric Dumazet > > pfkey_broadcast() might be called from non process contexts, > we can not use GFP_KERNEL in these cases [1]. > > This patch partially reverts commit ba51b6be38c1

Re: [PATCH net] tcp: ulp: avoid module refcnt leak in tcp_set_ulp

From: Sabrina Dubroca Date: Mon, 14 Aug 2017 18:04:24 +0200 > __tcp_ulp_find_autoload returns tcp_ulp_ops after taking a reference on > the module. Then, if ->init fails, tcp_set_ulp propagates the error but > nothing releases that reference. > > Fixes: 734942cc4ea6 ("tcp:

Re: [PATCH net] dccp: purge write queue in dccp_destroy_sock()

From: Eric Dumazet Date: Mon, 14 Aug 2017 14:10:25 -0700 > From: Eric Dumazet > > syzkaller reported that DCCP could have a non empty > write queue at dismantle time. > > WARNING: CPU: 1 PID: 2953 at net/core/stream.c:199 >

Re: [PATCH net] tcp: fix possible deadlock in TCP stack vs BPF filter

From: Eric Dumazet Date: Mon, 14 Aug 2017 17:44:43 -0700 > From: Eric Dumazet > > Filtering the ACK packet was not put at the right place. > > At this place, we already allocated a child and put it > into accept queue. > > We absolutely need to

Re: [PATCH net-next 07/11] net: dsa: debugfs: add port fdb

On Mon, Aug 14, 2017 at 06:22:38PM -0400, Vivien Didelot wrote: > Add a debug filesystem "fdb" entry to query a port's hardware FDB > entries through the .port_fdb_dump switch operation. > > This is really convenient to query directly the hardware or inspect DSA > or CPU links, since these ports

Re: [PATCH net-next 08/11] net: dsa: restore mdb dump

On Mon, Aug 14, 2017 at 06:22:39PM -0400, Vivien Didelot wrote: > The same dsa_fdb_dump_cb_t callback is used since there is no > distinction to do between FDB and MDB entries at this layer. > > Implement mv88e6xxx_port_mdb_dump so that multicast addresses associated > to a switch port can be

Re: [PATCH net-next 1/1 v3] drivers: net: rmnet: Initial implementation

+ */ +void rmnet_egress_handler(struct sk_buff *skb, + struct rmnet_logical_ep_conf_s *ep) +{ + struct rmnet_phys_ep_conf_s *config; + struct net_device *orig_dev; + int rc; + + orig_dev = skb->dev; + skb->dev = ep->egress_dev; + +

Re: [PATCH v2] sctp: fully initialize the IPv6 address in sctp_v6_to_addr()

On Tue, Aug 15, 2017 at 10:43:59AM +0900, 吉藤英明 wrote: > Hi, > > 2017-08-15 3:43 GMT+09:00 Alexander Potapenko : > > KMSAN reported use of uninitialized sctp_addr->v4.sin_addr.s_addr and > > sctp_addr->v6.sin6_scope_id in sctp_v6_cmp_addr() (see below). > > Make sure all fields

[PATCH net-next 00/11] net: dsa: add generic debugfs interface

This patch series adds a generic debugfs interface for the DSA framework, so that all switch devices benefit from it, e.g. Marvell, Broadcom, Microchip or any other DSA driver. This is really convenient for debugging, especially CPU ports and DSA links which are not exposed to userspace as net

[PATCH net-next 04/11] net: dsa: debugfs: add tag_protocol

Add a debug filesystem "tag_protocol" entry to query the switch tagging protocol through the .get_tag_protocol operation. # cat switch1/tag_protocol EDSA Signed-off-by: Vivien Didelot --- net/dsa/debugfs.c | 54

[PATCH net-next 03/11] net: dsa: debugfs: add tree

This commit adds the boiler plate to create a DSA related debug filesystem entry as well as a "tree" file, containing the tree index. # cat switch1/tree 0 Signed-off-by: Vivien Didelot --- net/dsa/debugfs.c | 108

[PATCH net-next 09/11] net: dsa: debugfs: add port mdb

Add a debug filesystem "mdb" entry to query a port's hardware MDB entries through the .port_mdb_dump switch operation. This is really convenient to query directly the hardware or inspect DSA or CPU links, since these ports are not exposed to userspace. Signed-off-by: Vivien Didelot

[PATCH net] tcp: fix possible deadlock in TCP stack vs BPF filter

From: Eric Dumazet Filtering the ACK packet was not put at the right place. At this place, we already allocated a child and put it into accept queue. We absolutely need to call tcp_child_process() to release its spinlock, or we will deadlock at accept() or close() time.

Re: [PATCH net-next v2] openvswitch: enable NSH support

On Tue, Aug 15, 2017 at 12:09:14AM +0800, Eric Garver wrote: > On Thu, Aug 10, 2017 at 09:21:15PM +0800, Yi Yang wrote: > > Hi Yi, > > In general I'd like to echo Jiri's comments on the netlink attributes. > I'd like to see the metadata separate. > > I have a few other comments below. > >

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Mon, 2017-08-14 at 18:07 -0700, Eric Dumazet wrote: > Or try to hack the IFF_XMIT_DST_RELEASE flag on the vlan netdev. Something like : diff --git a/net/8021q/vlan_netlink.c b/net/8021q/vlan_netlink.c index 5e831de3103e2f7092c7fa15534def403bc62fb4..9472de846d5c0960996261cb2843032847fa4bf7

Re: [PATCH net] datagram: When peeking datagrams with offset < 0 don't skip empty skbs

On Mon, Aug 14, 2017 at 11:31 AM, Paolo Abeni wrote: > On Mon, 2017-08-14 at 11:03 -0400, Willem de Bruijn wrote: >> > I'm actually surprised that only unix sockets can have negative values. Is >> > there a reason for that? I had assumed that sk_set_peek_off would allow >> >

linux-next: manual merge of the net-next tree with the rockchip tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: arch/arm64/boot/dts/rockchip/rk3328.dtsi between commit: c60c0373a5e8 ("arm64: dts: rockchip: add usb2 nodes for RK3328 SoCs") from the rockchip tree and commit: 9c4cc910fe28 ("ARM64: dts: rockchip: Add gmac2phy

[PATCH net-next 05/11] net: dsa: debugfs: add port stats

Add a debug filesystem "stats" entry to query a port's hardware statistics through the DSA switch .get_sset_count, .get_strings and .get_ethtool_stats operations. This allows one to get statistics about DSA links interconnecting switches, which is very convenient because this kind of port is not

Re: [PATCH net-next 04/11] net: dsa: debugfs: add tag_protocol

On Mon, Aug 14, 2017 at 06:22:35PM -0400, Vivien Didelot wrote: > Add a debug filesystem "tag_protocol" entry to query the switch tagging > protocol through the .get_tag_protocol operation. > > # cat switch1/tag_protocol > EDSA > > Signed-off-by: Vivien Didelot

Re: [PATCH net-next 05/11] net: dsa: debugfs: add port stats

On Mon, Aug 14, 2017 at 06:22:36PM -0400, Vivien Didelot wrote: > Add a debug filesystem "stats" entry to query a port's hardware > statistics through the DSA switch .get_sset_count, .get_strings and > .get_ethtool_stats operations. > > This allows one to get statistics about DSA links

Re: [PATCH net-next 06/11] net: dsa: debugfs: add port registers

On Mon, Aug 14, 2017 at 06:22:37PM -0400, Vivien Didelot wrote: > Add a debug filesystem "regs" entry to query a port's hardware registers > through the .get_regs_len and .get_regs_len switch operations. > > This is very convenient because it allows one to dump the registers of > DSA links, which

Re: [PATCH net-next 10/11] net: dsa: restore VLAN dump

On Mon, Aug 14, 2017 at 06:22:41PM -0400, Vivien Didelot wrote: > This commit defines a dsa_vlan_dump_cb_t callback, similar to the FDB > dump callback and partly reverts commit a0b6b8c9fa3c ("net: dsa: Remove > support for vlan dump from DSA's drivers") to restore the DSA drivers > VLAN dump

Re: [PATCH net-next 11/11] net: dsa: debugfs: add port vlan

On Mon, Aug 14, 2017 at 06:22:42PM -0400, Vivien Didelot wrote: > Add a debug filesystem "vlan" entry to query a port's hardware VLAN > entries through the .port_vlan_dump switch operation. > > This is really convenient to query directly the hardware or inspect DSA > or CPU links, since these

Re: [PATCH net-next 03/11] net: dsa: debugfs: add tree

On Mon, Aug 14, 2017 at 06:22:34PM -0400, Vivien Didelot wrote: > This commit adds the boiler plate to create a DSA related debug > filesystem entry as well as a "tree" file, containing the tree index. > > # cat switch1/tree > 0 > > Signed-off-by: Vivien Didelot

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

W dniu 2017-08-14 o 18:19, Jesper Dangaard Brouer pisze: On Sun, 13 Aug 2017 18:58:58 +0200 Paweł Staszewski wrote: To show some difference below comparision vlan/no-vlan traffic 10Mpps forwarded traffic vith no-vlan vs 6.9Mpps with vlan I'm trying to reproduce in

Re: [PATCH v2] sctp: fully initialize the IPv6 address in sctp_v6_to_addr()

Hi, 2017-08-15 3:43 GMT+09:00 Alexander Potapenko : > KMSAN reported use of uninitialized sctp_addr->v4.sin_addr.s_addr and > sctp_addr->v6.sin6_scope_id in sctp_v6_cmp_addr() (see below). > Make sure all fields of an IPv6 address are initialized, which > guarantees that the

[PATCH net-next 02/11] net: dsa: add debugfs interface

This commit adds a DEBUG_FS dependent DSA core file creating a generic debug filesystem interface for the DSA switch devices. The interface can be mounted with: # mount -t debugfs none /sys/kernel/debug The dsa directory contains one directory per switch chip: # cd

[PATCH net-next 06/11] net: dsa: debugfs: add port registers

Add a debug filesystem "regs" entry to query a port's hardware registers through the .get_regs_len and .get_regs_len switch operations. This is very convenient because it allows one to dump the registers of DSA links, which are not exposed to userspace. Here are the registers of a zii-rev-b CPU

[PATCH net-next 01/11] net: dsa: legacy: assign dst->applied

The "applied" boolean of the dsa_switch_tree is only set in the new bindings. This patch sets it in the legacy code as well. Signed-off-by: Vivien Didelot --- net/dsa/legacy.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/dsa/legacy.c

[PATCH net-next 07/11] net: dsa: debugfs: add port fdb

Add a debug filesystem "fdb" entry to query a port's hardware FDB entries through the .port_fdb_dump switch operation. This is really convenient to query directly the hardware or inspect DSA or CPU links, since these ports are not exposed to userspace. # cat port1/fdb vid 0

Re: [PATCH net-next 09/11] net: dsa: debugfs: add port mdb

On Mon, Aug 14, 2017 at 06:22:40PM -0400, Vivien Didelot wrote: > Add a debug filesystem "mdb" entry to query a port's hardware MDB > entries through the .port_mdb_dump switch operation. > > This is really convenient to query directly the hardware or inspect DSA > or CPU links, since these ports

Re: [PATCH net-next 01/11] net: dsa: legacy: assign dst->applied

On Mon, Aug 14, 2017 at 06:22:32PM -0400, Vivien Didelot wrote: > The "applied" boolean of the dsa_switch_tree is only set in the new > bindings. This patch sets it in the legacy code as well. What is missing here is: Why? I see the next patch does a WARN_ON(!applied). Why have a WARN_ON?

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Tue, 2017-08-15 at 02:45 +0200, Paweł Staszewski wrote: > > W dniu 2017-08-14 o 18:57, Paolo Abeni pisze: > > On Mon, 2017-08-14 at 18:19 +0200, Jesper Dangaard Brouer wrote: > >> The output (extracted below) didn't show who called 'do_raw_spin_lock', > >> BUT it showed another interesting

[PATCH net-next 08/11] net: dsa: restore mdb dump

The same dsa_fdb_dump_cb_t callback is used since there is no distinction to do between FDB and MDB entries at this layer. Implement mv88e6xxx_port_mdb_dump so that multicast addresses associated to a switch port can be dumped. Signed-off-by: Vivien Didelot

[PATCH net-next 10/11] net: dsa: restore VLAN dump

This commit defines a dsa_vlan_dump_cb_t callback, similar to the FDB dump callback and partly reverts commit a0b6b8c9fa3c ("net: dsa: Remove support for vlan dump from DSA's drivers") to restore the DSA drivers VLAN dump operations. Signed-off-by: Vivien Didelot

[PATCH net-next 11/11] net: dsa: debugfs: add port vlan

Add a debug filesystem "vlan" entry to query a port's hardware VLAN entries through the .port_vlan_dump switch operation. This is really convenient to query directly the hardware or inspect DSA or CPU links, since these ports are not exposed to userspace. Here are the VLAN entries for a CPU

Re: [PATCH net] af_key: do not use GFP_KERNEL in atomic contexts

On 8/14/17 11:16 AM, Eric Dumazet wrote: > From: Eric Dumazet > > pfkey_broadcast() might be called from non process contexts, > we can not use GFP_KERNEL in these cases [1]. > > This patch partially reverts commit ba51b6be38c1 ("net: Fix RCU splat in > af_key"), only

Re: [PATCH v2] sctp: fully initialize the IPv6 address in sctp_v6_to_addr()

On Mon, Aug 14, 2017 at 08:43:04PM +0200, Alexander Potapenko wrote: > KMSAN reported use of uninitialized sctp_addr->v4.sin_addr.s_addr and > sctp_addr->v6.sin6_scope_id in sctp_v6_cmp_addr() (see below). > Make sure all fields of an IPv6 address are initialized, which > guarantees that the IPv4

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

W dniu 2017-08-14 o 18:57, Paolo Abeni pisze: On Mon, 2017-08-14 at 18:19 +0200, Jesper Dangaard Brouer wrote: The output (extracted below) didn't show who called 'do_raw_spin_lock', BUT it showed another interesting thing. The kernel code __dev_queue_xmit() in might create route dst-cache

Re: [PATCH v10 3/5] PCI: Disable Relaxed Ordering Attributes for AMD A1100

On 2017/8/15 1:19, Raj, Ashok wrote: > On Mon, Aug 14, 2017 at 11:44:57PM +0800, Ding Tianhong wrote: >> Casey reported that the AMD ARM A1100 SoC has a bug in its PCIe >> Root Port where Upstream Transaction Layer Packets with the Relaxed >> Ordering Attribute clear are allowed to bypass

[PATCH v11 1/5] PCI: Disable PCIe Relaxed Ordering if unsupported

When bit4 is set in the PCIe Device Control register, it indicates whether the device is permitted to use relaxed ordering. On some platforms using relaxed ordering can have performance issues or due to erratum can cause data-corruption. In such cases devices must avoid using relaxed ordering.

[PATCH v11 0/5] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

Some devices have problems with Transaction Layer Packets with the Relaxed Ordering Attribute set. This patch set adds a new PCIe Device Flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING, a set of PCI Quirks to catch some known devices with Relaxed Ordering issues, and a use of this new flag by the cxgb4

[PATCH v11 2/5] PCI: Disable Relaxed Ordering for some Intel processors

According to the Intel spec section 3.9.1 said: 3.9.1 Optimizing PCIe Performance for Accesses Toward Coherent Memory and Toward MMIO Regions (P2P) In order to maximize performance for PCIe devices in the processors listed in Table 3-6 below, the soft- ware should determine

[PATCH v11 5/5] net/cxgb4vf: Use new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

From: Casey Leedom cxgb4vf Ethernet driver now queries PCIe configuration space to determine if it can send TLPs to it with the Relaxed Ordering Attribute set, just like the pf did. Signed-off-by: Casey Leedom Signed-off-by: Ding Tianhong

Re: general protection fault in fib_dump_info

On Tue, 2017-08-15 at 10:49 +0800, idaifish wrote: > Syzkaller hit 'general protection fault in fib_dump_info' bug on > commit 4.13-rc5.. > > Guilty file: net/ipv4/fib_semantics.c > > kasan: GPF could be caused by NULL-ptr deref or user memory access > general protection fault: [#1] SMP

Re: [PATCH net-next V2 3/3] tap: XDP support

On 2017年08月15日 00:01, Michael S. Tsirkin wrote: On Sat, Aug 12, 2017 at 10:48:49AM +0800, Jason Wang wrote: On 2017年08月12日 07:12, Jakub Kicinski wrote: On Fri, 11 Aug 2017 19:41:18 +0800, Jason Wang wrote: This patch tries to implement XDP for tun. The implementation was split into two

Re: [PATCH v11 0/5] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

From: Ding Tianhong Date: Tue, 15 Aug 2017 11:23:22 +0800 > Some devices have problems with Transaction Layer Packets with the Relaxed > Ordering Attribute set. This patch set adds a new PCIe Device Flag, > PCI_DEV_FLAGS_NO_RELAXED_ORDERING, a set of PCI Quirks to catch

[PATCH v11 4/5] net/cxgb4: Use new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

From: Casey Leedom cxgb4 Ethernet driver now queries PCIe configuration space to determine if it can send TLPs to it with the Relaxed Ordering Attribute set. Remove the enable_pcie_relaxed_ordering() to avoid enable PCIe Capability Device Control[Relaxed Ordering Enable] at

[PATCH v11 3/5] PCI: Disable Relaxed Ordering Attributes for AMD A1100

Casey reported that the AMD ARM A1100 SoC has a bug in its PCIe Root Port where Upstream Transaction Layer Packets with the Relaxed Ordering Attribute clear are allowed to bypass earlier TLPs with Relaxed Ordering set, it would cause Data Corruption, so we need to disable Relaxed Ordering

Re: [PATCH net-next V2 3/3] tap: XDP support

On 2017年08月14日 16:43, Daniel Borkmann wrote: On 08/11/2017 01:41 PM, Jason Wang wrote: This patch tries to implement XDP for tun. The implementation was split into two parts: [...] @@ -1402,6 +1521,22 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile,

linux-next: build failure after merge of the net-next tree

Hi all, After merging the net-next tree, today's linux-next build (arm multi_v7_defconfig) failed like this: arch/arm/boot/dts/rk3228-evb.dtb: ERROR (phandle_references): Reference to non-existent node or label "phy0" Caused by commit db40f15b53e4 ("ARM: dts: rk3228-evb: Enable the

Re: [PATCH v2] sctp: fully initialize the IPv6 address in sctp_v6_to_addr()

From: Marcelo Ricardo Leitner Date: Mon, 14 Aug 2017 22:58:14 -0300 > On Tue, Aug 15, 2017 at 10:43:59AM +0900, 吉藤英明 wrote: >> > diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c >> > index 2a186b201ad2..a15d691829c6 100644 >> > --- a/net/sctp/ipv6.c >> > +++

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

On Fri, Aug 11, 2017 at 06:00:20PM -0700, Tom Herbert wrote: > On Thu, Aug 10, 2017 at 12:13 PM, Shaohua Li wrote: > > On Thu, Aug 10, 2017 at 11:30:51AM -0700, Tom Herbert wrote: > >> On Thu, Aug 10, 2017 at 9:30 AM, Shaohua Li wrote: > >> > On Wed, Aug 09,

[PATCH v5 net 2/2] net: fix tcp reset packet flowlabel for ipv6

From: Shaohua Li Please see below tcpdump output: 21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload length: 40) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.: Flags [S], cksum 0x0529 (incorrect -> 0xf56c), seq 3282214508, win 43690,

[PATCH v5 net 0/2] ipv6: fix flowlabel issue for reset packet

From: Shaohua Li Please see below tcpdump output: 21:00:48.109122 IP6 (flowlabel 0x43304, hlim 64, next-header TCP (6) payload length: 40) fec0::5054:ff:fe12:3456.55804 > fec0::5054:ff:fe12:3456.: Flags [S], cksum 0x0529 (incorrect -> 0xf56c), seq 3282214508, win 43690,

  1   2   >