[PATCH 4/4] esp: Fix error handling on layer 2 xmit.

2017-08-20 Thread Steffen Klassert
esp_output_tail() and esp6_output_tail() can return negative and positive error values. We currently treat only negative values as errors, fix this to treat both cases as error. Fixes: fca11ebde3f0 ("esp4: Reorganize esp_output") Fixes: 383d0350f2cc ("esp6: Reorganize esp_output") Signed-off-by: S

Re: [PATCH net-next v4] openvswitch: enable NSH support

2017-08-20 Thread Yang, Yi
On Fri, Aug 18, 2017 at 09:26:01PM +0800, Jiri Benc wrote: > On Fri, 18 Aug 2017 15:24:31 +0800, Yi Yang wrote: > > +struct nsh_md2_tlv { > > + __be16 md_class; > > + u8 type; > > + u8 length; > > + /* Followed by variable-length data. */ > > +}; > > What was wrong with the u8[] field that

Re: [PATCH net-next v4] openvswitch: enable NSH support

2017-08-20 Thread Yang, Yi
On Sat, Aug 19, 2017 at 03:09:47AM +0800, Eric Garver wrote: > On Fri, Aug 18, 2017 at 03:24:31PM +0800, Yi Yang wrote: > > v3->v4 > > - Add new NSH match field ttl > > - Update NSH header to the latest format > >which will be final format and won't change > >per its author's confirmation

Re: [PATCH net-next v4] openvswitch: enable NSH support

2017-08-20 Thread Yang, Yi
On Fri, Aug 18, 2017 at 09:31:03PM +0800, Jiri Benc wrote: > On Fri, 18 Aug 2017 15:26:01 +0200, Jiri Benc wrote: > > Out of time for today, will continue the review next week. Again, feel > > free to send a new version meanwhile or wait for the rest of the > > review, whatever works better for you

<    1   2