Re: [PATCH net-next 0/2] addrlabel: don't use rtnl locking

From: Florian Westphal Date: Tue, 29 Aug 2017 13:29:40 +0200 > addrlabel doesn't appear to require rtnl lock as the addrlabel > table uses a spinlock to serialize add/delete operations. > > Also, entries are reference counted so it should be safe > to call the rtnl ops without

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

From: Greg Kroah-Hartman Date: Tue, 29 Aug 2017 16:48:50 +0200 > On Tue, Aug 29, 2017 at 02:11:39PM +0200, Geert Uytterhoeven wrote: >> Hi Greg, >> >> On Tue, Aug 29, 2017 at 1:28 PM, Greg Kroah-Hartman >> wrote: >> > On Tue, Aug 29, 2017

Re: pull request (net): ipsec 2017-08-29

From: Steffen Klassert Date: Tue, 29 Aug 2017 12:31:27 +0200 > 1) Fix dst_entry refcount imbalance when using socket policies. >From Lorenzo Colitti. > > 2) Fix locking when adding the ESP trailers. > > 3) Fix tailroom calculation for the ESP trailer by using

[patch v1 2/2] mlxsw: core: add support for the external thermal zone setting (by DTS)

It allows: - thermal zone setting for mlxsw based HW and from DTS file; - binding ASIC temperature sensor to cooling devices. It requires setting of CONFIG_OF. Signed-off-by: Vadim Pasternak --- drivers/net/ethernet/mellanox/mlxsw/core_thermal.c | 107 -

[PATCH] net: dsa: make some structures const

Make these const as they are not modified anywhere. Signed-off-by: Bhumika Goyal --- drivers/net/dsa/bcm_sf2.c | 2 +- drivers/net/dsa/qca8k.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c index

[patch v1 1/2] dt-bindings: net: add binding documentation for mlxsw thermal control

Add binding document for Mellanox switch devices. Signed-off-by: Vadim Pasternak --- .../devicetree/bindings/net/mellanox,mlxsw.txt | 46 ++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/mellanox,mlxsw.txt

[patch v1 0/2] add support for the external thermal zone and cooling device binding for Mellanox network devices

It allows binding of AISC thermal sensor to externally defined thermal zones and cooling device. Such definition can be provided from DTS. Vadim Pasternak (2): dt-bindings: net: add binding documentation for mlxsw thermal control mlxsw: core: add support for the external thermal zone setting

Re: [PATCH net-next 7/7] samples/bpf: xdp_monitor tool based on tracepoints

On Tue, Aug 29, 2017 at 04:38:11PM +0200, Jesper Dangaard Brouer wrote: > This tool xdp_monitor demonstrate how to use the different xdp_redirect > tracepoints xdp_redirect{,_map}{,_err} from a BPF program. > > The default mode is to only monitor the error counters, to avoid > affecting the per

Re: [PATCH net-next 7/7] samples/bpf: xdp_monitor tool based on tracepoints

On 08/29/2017 07:05 PM, Alexei Starovoitov wrote: On Tue, Aug 29, 2017 at 04:38:11PM +0200, Jesper Dangaard Brouer wrote: This tool xdp_monitor demonstrate how to use the different xdp_redirect tracepoints xdp_redirect{,_map}{,_err} from a BPF program. The default mode is to only monitor the

Re: UDP sockets oddities

On Tue, 2017-08-29 at 10:53 -0700, Florian Fainelli wrote: > On 08/26/2017 11:56 AM, Florian Fainelli wrote: > > > > > > On 08/26/2017 05:47 AM, Eric Dumazet wrote: > >> On Fri, 2017-08-25 at 21:19 -0700, David Miller wrote: > >> > >>> Agreed, but the ARP resolution queue really needs to scale

Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into the kernel

On Tue, Aug 29, 2017 at 10:49:45AM -0700, David Miller wrote: > From: Greg KH > Date: Tue, 29 Aug 2017 19:46:22 +0200 > > > When moving the IRDA code out of net/ into drivers/staging/irda/net, the > > link order changes when IRDA is built into the kernel. That causes

Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface

On 08/29/2017 03:50 PM, Andrew Lunn wrote: > On Tue, Aug 29, 2017 at 08:25:23AM +0200, Jiri Pirko wrote: >> Mon, Aug 28, 2017 at 10:08:34PM CEST, and...@lunn.ch wrote: I see this overlaps a lot with DPIPE. Why won't you use that to expose your hw state? >>> >>> We took a look at dpipe

Re: mlxsw and rtnl lock

On 08/28/2017 09:00 PM, David Ahern wrote: > On 8/26/17 11:04 AM, Ido Schimmel wrote: >> Regarding the silent abort, that's intentional. You can look at the same >> code in v4.9 - when the chain was still blocking - and you'll see that >> we didn't propagate the error even then. This was

[PATCH net] nfp: double free on error in probe

Both the nfp_net_pf_app_start() and the nfp_net_pci_probe() functions call nfp_net_pf_app_stop_ctrl(pf) so there is a double free. The free should be done from the probe function because it's allocated there so I have removed the call from nfp_net_pf_app_start(). Fixes: 02082701b974 ("nfp:

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

On Fri, Aug 25, 2017 at 9:03 PM, Willem de Bruijn wrote: > On Fri, Aug 25, 2017 at 7:32 PM, Michael S. Tsirkin wrote: >> On Fri, Aug 25, 2017 at 06:44:36PM -0400, Willem de Bruijn wrote: >>> >> >> > We don't enable network watchdog on virtio but

Re: [PATCH net-next 0/7] rxrpc: Miscellany

husly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-next-20170829 Pulled, thanks David.

Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints

On Tue, Aug 29, 2017 at 9:46 AM, Florian Fainelli wrote: > On 08/28/2017 09:22 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> A few useful tracepoints to trace bridge forwarding >> database updates. >> >> Signed-off-by: Roopa Prabhu

[PATCH net] sch_htb: fix crash on init failure

The commit below added a call to the ->destroy() callback for all qdiscs which failed in their ->init(), but some were not prepared for such change and can't handle partially initialized qdisc. HTB is one of them and if any error occurs before the qdisc watchdog timer and qdisc work are

[PATCH] rsi: remove memset before memcpy

calling memcpy immediately after memset with the same region of memory makes memset redundant. Signed-off-by: Himanshu Jha --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 1 - drivers/net/wireless/rsi/rsi_91x_usb.c | 1 - 2 files changed, 2 deletions(-) diff --git

[PATCH net v2] sch_multiq: fix double free on init failure

The below commit added a call to ->destroy() on init failure, but multiq still frees ->queues on error in init, but ->queues is also freed by ->destroy() thus we get double free and corrupted memory. Very easy to reproduce (eth0 not multiqueue): $ tc qdisc add dev eth0 root multiq RTNETLINK

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

On Tue, Aug 29, 2017 at 03:35:38PM -0400, Willem de Bruijn wrote: > By the way, I have had an unrelated patch outstanding for a while > to have virtio-net support the VIRTIO_CONFIG_S_NEEDS_RESET > command. Will send that as RFC. Oh nice. One needs to be careful about locking there which is why no

Re: mlxsw and rtnl lock

On 8/29/17 12:10 AM, Arkadi Sharshevsky wrote: > > > On 08/28/2017 09:00 PM, David Ahern wrote: >> On 8/26/17 11:04 AM, Ido Schimmel wrote: >>> Regarding the silent abort, that's intentional. You can look at the same >>> code in v4.9 - when the chain was still blocking - and you'll see that >>>

Re: [PATCH net-next 4/7] xdp: separate xdp_redirect tracepoint in error case

On Tue, Aug 29, 2017 at 04:37:56PM +0200, Jesper Dangaard Brouer wrote: > There is a need to separate the xdp_redirect tracepoint into two > tracepoints, for separating the error case from the normal forward > case. > > Due to the extreme speeds XDP is operating at, loading a tracepoint > have a

Re: [PATCH] dt-binding: net/phy: fix interrupts description

On Wed, Aug 23, 2017 at 09:11:00AM +0300, Baruch Siach wrote: > Commit b053dc5a722ea (powerpc: Refactor device tree binding) split the > Ethernet PHY binding documentation out of the big booting-without-of.txt > file, leaving a dangling reference to "section 2" in the 'interrupts' > property

Re: [PATCH net-next] staging: irda: force to be a kernel module

On Tue, Aug 29, 2017 at 09:35:07AM -0700, David Miller wrote: > From: Greg Kroah-Hartman > Date: Tue, 29 Aug 2017 11:14:17 +0200 > > > Now that the IRDA networking code has moved into drivers/staging/, the > > link order is changed for when it is initialized if built

Re: [PATCH net] ipv6: do not set sk_destruct in IPV6_ADDRFORM sockopt

From: Xin Long Date: Mon, 28 Aug 2017 10:45:01 +0800 > ChunYu found a kernel warn_on during syzkaller fuzzing: > > [40226.038539] WARNING: CPU: 5 PID: 23720 at net/ipv4/af_inet.c:152 > inet_sock_destruct+0x78d/0x9a0 > [40226.144849] Call Trace: > [40226.147590] >

Re: XDP redirect measurements, gotchas and tracepoints

On Tue, Aug 29, 2017 at 09:23:49AM -0700, Alexander Duyck wrote: > On Tue, Aug 29, 2017 at 6:26 AM, Jesper Dangaard Brouer > wrote: > > > > On Mon, 28 Aug 2017 09:11:25 -0700 Alexander Duyck > > wrote: > > > >> My advice would be to not over

[PATCH net] sch_hhf: fix null pointer dereference on init failure

If sch_hhf fails in its ->init() function (either due to wrong user-space arguments as below or memory alloc failure of hh_flows) it will do a null pointer deref of q->hh_flows in its ->destroy() function. To reproduce the crash: $ tc qdisc add dev eth0 root hhf quantum 200 non_hh_weight

[PATCH net-next] net: bcmgenet: Use correct I/O accessors

From: Florian Fainelli The GENET driver currently uses __raw_{read,write}l which means native I/O endian. This works correctly for an ARM LE kernel (default) but fails miserably on an ARM BE (BE8) kernel where registers are kept little endian, so replace uses with

Re: [PATCH net] nfp: double free on error in probe

On Tue, 29 Aug 2017 22:15:16 +0300, Dan Carpenter wrote: > Both the nfp_net_pf_app_start() and the nfp_net_pci_probe() functions > call nfp_net_pf_app_stop_ctrl(pf) so there is a double free. The free > should be done from the probe function because it's allocated there so > I have removed the

Re: [PATCH net-next] Revert "ipv4: make net_protocol const"

On 8/29/17 12:46 AM, Bhumika Goyal wrote: > I am compile testing them. In this case I did: make > net/ipv4/af_inet.o and it compiled. Is this error because of > typecasting net_protocol inside inet_add_protocol function? Compile testing is not sufficient. Marking data structures read-only leaves

Re: [PATCH net-next 3/4] net: add NSH header structures and helpers

On Mon, 28 Aug 2017 21:43:23 +0200, Jiri Benc wrote: > This patch adds NSH header structures and helpers for NSH GSO > support and Open vSwitch NSH support. > > [1] https://datatracker.ietf.org/doc/draft-ietf-sfc-nsh/ One thing to know before applying this to the kernel: NSH is still a draft.

[PATCH net-next 1/6] flow_dissector: Move ETH_P_TEB processing to main switch

Support for processing TEB is currently in GRE flow dissection as a special case. This can be moved to be a case the main proto switch in __skb_flow_dissect. --- net/core/flow_dissector.c | 44 +++- 1 file changed, 23 insertions(+), 21 deletions(-) diff

[PATCH net-next 2/6] udp: Constify skb argument in lookup functions

For UDP socket lookup functions, and associateed functions that take an skbuf as argument, declare the skb argument as constant. One caveat is that reuseport_select_sock can be called from the UDP lookup functions with an skb argument. This function temporarily modifies the skbuff data pointer

[PATCH net-next 3/6] flow_dissector: Add protocol specific flow dissection offload

Add offload capability for performing protocol specific flow dissection (either by EtherType or IP protocol). Specifically: - Add flow_dissect to offload callbacks - Move flow_dissect_ret enum to flow_dissector.h, cleanup names and add a couple of values - Create GOTO_BY_RESULT macro to use in

[PATCH net-next 5/6] fou: Support flow dissection

Populate offload flow_dissect callabck appropriately for fou and gue. --- net/ipv4/fou.c | 63 ++ 1 file changed, 63 insertions(+) diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c index 1540db65241a..a831dd49fb28 100644 --- a/net/ipv4/fou.c +++

[PATCH net-next 4/6] udp: flow dissector offload

Add support to perform UDP specific flow dissection. This is primarily intended for dissecting encapsulated packets in UDP encapsulation. This patch adds a flow_dissect offload for UDP4 and UDP6. The backend function performs a socket lookup and calls the flow_dissect function if a socket is

[PATCH net-next 6/6] vxlan: support flow dissect

Populate offload flow_dissect callback appropriately for VXLAN and VXLAN-GPE. --- drivers/net/vxlan.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index ae3a1da703c2..41e50de40af4 100644 ---

Re: UDP sockets oddities

On 08/26/2017 11:56 AM, Florian Fainelli wrote: > > > On 08/26/2017 05:47 AM, Eric Dumazet wrote: >> On Fri, 2017-08-25 at 21:19 -0700, David Miller wrote: >> >>> Agreed, but the ARP resolution queue really needs to scale it's backlog >>> to the physical technology it is attached to. >> Yes,

[PATCH net-next v2] net: bcmgenet: Use correct I/O accessors

The GENET driver currently uses __raw_{read,write}l which means native I/O endian. This works correctly for an ARM LE kernel (default) but fails miserably on an ARM BE (BE8) kernel where registers are kept little endian, so replace uses with {read,write}l_relaxed here which is what we want because

Re: [PATCH net] sch_hhf: fix null pointer dereference on init failure

On 29/08/17 22:02, Nikolay Aleksandrov wrote: > If sch_hhf fails in its ->init() function (either due to wrong > user-space arguments as below or memory alloc failure of hh_flows) it > will do a null pointer deref of q->hh_flows in its ->destroy() function. > > To reproduce the crash: > $ tc

Re: [PATCH net-next 1/4] net: Add SRIOV VGT+ support

2017-08-29, 13:13:09 +0300, Saeed Mahameed wrote: > On Mon, Aug 28, 2017 at 6:52 PM, Sabrina Dubroca wrote: > > 2017-08-27, 14:06:15 +0300, Saeed Mahameed wrote: > > [...] > >> +#define VF_VLAN_BITMAP DIV_ROUND_UP(VF_VLAN_N_VID, sizeof(__u64) * > >> BITS_PER_BYTE) >

[PATCH v2 net-next] irda: fix link order if IRDA is built into the kernel

When moving the IRDA code out of net/ into drivers/staging/irda/net, the link order changes when IRDA is built into the kernel. That causes a kernel crash at boot time as netfilter isn't initialized yet. To fix this, build and link the irda networking code in the same exact order that it was

RE: [patch v1 1/2] dt-bindings: net: add binding documentation for mlxsw thermal control

> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Tuesday, August 29, 2017 8:23 PM > To: Vadim Pasternak > Cc: robh...@kernel.org; da...@davemloft.net; j...@resnulli.us; > ivec...@redhat.com; devicet...@vger.kernel.org; netdev@vger.kernel.org

Re: [PATCH] net: stmmac: constify clk_div_table

From: Arvind Yadav Date: Mon, 28 Aug 2017 11:22:20 +0530 > clk_div_table are not supposed to change at runtime. > meson8b_dwmac structure is working with const clk_div_table. > So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav

Re: pull-request: wireless-drivers-next 2017-08-28

From: Kalle Valo Date: Mon, 28 Aug 2017 12:22:34 +0300 > here's a pull request to net-next for 4.14. Because I pulled > wireless-drivers (at least that's my suspicion) the diffstat was wrong > again and I created it manually. I recall Linus somewhere saying that in >

Re: [PATCH] rtlwifi: rtl8822be: Add firmware for new driver/device

On Fri, Aug 25, 2017 at 09:23:40AM -0500, Larry Finger wrote: > A driver for the RTL8822BE has been added to staging. This commit supplies > the firmware for it. > > Signed-off-by: Larry Finger > --- applied. thanks Larry. --kyle

[PATCH net-next 1/4] net: systemport: Use correct I/O accessors

The SYSTEMPORT driver currently uses __raw_{read,write}l which means native I/O endian. This works correctly for an ARM LE kernel (default) but fails miserably on an ARM BE (BE8) kernel where registers are kept little endian, so replace uses with {read,write}l_relaxed here which is what we want

[PATCH net-next 0/4] Endian fixes for SYSTEMPORT/SF2/MDIO

Hi David, While trying an ARM BE kernel for kinks, the 3 drivers below started not working and the reasons why became pretty obvious because the register space remains LE (hardwired), except for Broadcom MIPS where it follows the CPU's native endian (let's call that a feature). Thanks! Florian

[PATCH net-next 3/4] net: systemport: Set correct RSB endian bits based on host

LE CPU: * set RSB_SWAP0 (both SYSTEMPORT and SYSTEMPORT Lite) * clear RSB_SWAP1 (SYSTEMPORT Lite only) BE CPU: * clear RSB_SWAP0 (both SYSTEMPORT and SYSTEMPORTE lite) * set RSB_SWAP1 (SYSTEMPORT Lite only) With these settings, we have the Receive Status Block always match the host endian and we

[PATCH net-next 4/4] net: phy: mdio-bcm-unimac: Use correct I/O accessors

The driver currently uses __raw_{read,write}l which works for all platforms supported: Broadcom MIPS LE/BE (native endian), ARM LE (native endian) but not ARM BE (registers are still LE). Switch to using the proper accessors for all platforms and explain why Broadcom MIPS BE is special here, in

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

From: Geert Uytterhoeven Date: Tue, 29 Aug 2017 12:59:00 +0200 > Hi Greg, > > On Sun, Aug 27, 2017 at 5:03 PM, Greg Kroah-Hartman > wrote: >> The IRDA code has long been obsolete and broken. So, to keep people >> from trying to use it, and to

Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints

On 08/28/2017 09:22 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > A few useful tracepoints to trace bridge forwarding > database updates. > > Signed-off-by: Roopa Prabhu Reviewed-by: Florian Fainelli Small nit

Re: [PATCH] dt-binding: net/phy: fix interrupts description

On Mon, Aug 28, 2017 at 01:20:39PM +0300, Baruch Siach wrote: > Hi Dave, > > On Wed, Aug 23, 2017 at 09:11:00AM +0300, Baruch Siach wrote: > > Commit b053dc5a722ea (powerpc: Refactor device tree binding) split the > > Ethernet PHY binding documentation out of the big booting-without-of.txt > >

Re: [PATCH net-next] staging: irda: force to be a kernel module

On Tue, Aug 29, 2017 at 07:26:08PM +0200, Greg KH wrote: > On Tue, Aug 29, 2017 at 09:35:07AM -0700, David Miller wrote: > > From: Greg Kroah-Hartman > > Date: Tue, 29 Aug 2017 11:14:17 +0200 > > > > > Now that the IRDA networking code has moved into drivers/staging/,

Re: [PATCH net-next] staging: irda: force to be a kernel module

From: Greg KH Date: Tue, 29 Aug 2017 19:26:08 +0200 > On Tue, Aug 29, 2017 at 09:35:07AM -0700, David Miller wrote: >> From: Greg Kroah-Hartman >> Date: Tue, 29 Aug 2017 11:14:17 +0200 >> >> > Now that the IRDA networking code has moved

Re: [PATCH net] sch_htb: fix crash on init failure

On Tue, 2017-08-29 at 20:58 +0300, Nikolay Aleksandrov wrote: > The commit below added a call to the ->destroy() callback for all qdiscs > which failed in their ->init(), but some were not prepared for such > change and can't handle partially initialized qdisc. HTB is one of them > and if any

Re: [PATCH net] sch_htb: fix crash on init failure

On Tue, Aug 29, 2017 at 10:58 AM, Nikolay Aleksandrov wrote: > The commit below added a call to the ->destroy() callback for all qdiscs > which failed in their ->init(), but some were not prepared for such > change and can't handle partially initialized qdisc. HTB is

Re: [PATCH net] sch_multiq: fix double free on init failure

On Tue, 2017-08-29 at 21:26 +0300, Nikolay Aleksandrov wrote: > The below commit added a call to ->destroy() on init failure, but multiq > still frees ->queues on error in init, but ->queues is also freed by > ->destroy() thus we get double free and corrupted memory. > > Very easy to reproduce

Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface

On 08/29/2017 12:05 PM, Arkadi Sharshevsky wrote: > > > On 08/29/2017 03:50 PM, Andrew Lunn wrote: >> On Tue, Aug 29, 2017 at 08:25:23AM +0200, Jiri Pirko wrote: >>> Mon, Aug 28, 2017 at 10:08:34PM CEST, and...@lunn.ch wrote: > I see this overlaps a lot with DPIPE. Why won't you use that to

[PATCH V2 net-next] liquidio: show NIC's U-Boot version in a dev_info() message

From: Weilin Chang Signed-off-by: Weilin Chang Signed-off-by: Felix Manlunas --- Patch Change Log: V1 -> V2: * Move octeon_get_uboot_version() to a proper place to avoid forward declaration. * Remove

Re: XDP redirect measurements, gotchas and tracepoints

On Tue, Aug 29, 2017 at 12:02 PM, Andy Gospodarek wrote: > On Tue, Aug 29, 2017 at 09:23:49AM -0700, Alexander Duyck wrote: >> On Tue, Aug 29, 2017 at 6:26 AM, Jesper Dangaard Brouer >> wrote: >> > >> > On Mon, 28 Aug 2017 09:11:25 -0700 Alexander Duyck >>

Re: [PATCH net-next] staging: irda: force to be a kernel module

From: Greg Kroah-Hartman Date: Tue, 29 Aug 2017 11:14:17 +0200 > Now that the IRDA networking code has moved into drivers/staging/, the > link order is changed for when it is initialized if built into the > system. This can cause a crash when initializing as the

Re: [PATCH net] sch_htb: fix crash on init failure

On 29/08/17 21:09, Eric Dumazet wrote: > On Tue, 2017-08-29 at 20:58 +0300, Nikolay Aleksandrov wrote: >> The commit below added a call to the ->destroy() callback for all qdiscs >> which failed in their ->init(), but some were not prepared for such >> change and can't handle partially initialized

[PATCH net-next 2/4] net: dsa: bcm_sf2: Use correct I/O accessors

The Starfigther 2 driver currently uses __raw_{read,write}l which means native I/O endian. This works correctly for an ARM LE kernel (default) but fails miserably on an ARM BE (BE8) kernel where registers are kept little endian, so replace uses with {read,write}l_relaxed here which is what we want

Re: [PATCH net] sch_multiq: fix double free on init failure

On Tue, Aug 29, 2017 at 11:26 AM, Nikolay Aleksandrov wrote: > diff --git a/net/sched/sch_multiq.c b/net/sched/sch_multiq.c > index f143b7bbaa0d..b07f8b01aa07 100644 > --- a/net/sched/sch_multiq.c > +++ b/net/sched/sch_multiq.c > @@ -259,9 +259,6 @@ static int

Re: [patch v1 1/2] dt-bindings: net: add binding documentation for mlxsw thermal control

On Tue, Aug 29, 2017 at 05:57:01PM +, Vadim Pasternak wrote: > > > > -Original Message- > > From: Andrew Lunn [mailto:and...@lunn.ch] > > Sent: Tuesday, August 29, 2017 8:23 PM > > To: Vadim Pasternak > > Cc: robh...@kernel.org; da...@davemloft.net;

Re: [PATCH net-next] net: bcmgenet: Use correct I/O accessors

On 08/29/2017 12:23 PM, Florian Fainelli wrote: > From: Florian Fainelli Oh nooo I just exposed myself, let me resend with the gmail address. > > The GENET driver currently uses __raw_{read,write}l which means > native I/O endian. This works correctly for an ARM

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

On Tue, Aug 29, 2017 at 3:42 PM, Michael S. Tsirkin wrote: > On Tue, Aug 29, 2017 at 03:35:38PM -0400, Willem de Bruijn wrote: >> By the way, I have had an unrelated patch outstanding for a while >> to have virtio-net support the VIRTIO_CONFIG_S_NEEDS_RESET >> command. Will send

Re: [PATCH v2 net-next 1/8] bpf: Add support for recursively running cgroup sock filters

On Tue, Aug 29, 2017 at 09:38:16PM -0600, David Ahern wrote: > On 8/29/17 8:58 PM, Alexei Starovoitov wrote: > > On Tue, Aug 29, 2017 at 07:03:43PM -0600, David Ahern wrote: > >> On 8/28/17 10:11 PM, Alexei Starovoitov wrote: > >>> > >>> Agree on the above, but you're mixing semantics of the new

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

Hi Antoine, On Monday 28 August 2017 08:27 PM, Antoine Tenart wrote: > On the CP110 unit, which can be found on various Marvell platforms such > as the 7k and 8k (currently), a comphy (common PHYs) hardware block can > be found. This block provides a number of PHYs which can be used in > various

[net-next:master 427/429] arch/sh/include/asm/io.h:30:43: warning: 'return' with a value, in function returning void

tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: eaa72dc47488d599439cd0fd0f8c4f1bcb3906bb commit: 69d2ea9c798983c4a7157278ec84ff969d1cd8e8 [427/429] net: bcmgenet: Use correct I/O accessors config: sh-allmodconfig (attached as .config) compiler:

Re: [PATCH net-next v3 0/3] NCSI VLAN Filtering Support

From: Samuel Mendoza-Jonas Date: Wed, 30 Aug 2017 14:37:21 +1000 > On Mon, 2017-08-28 at 16:50 -0700, David Miller wrote: >> From: Samuel Mendoza-Jonas >> Date: Mon, 28 Aug 2017 16:18:40 +1000 >> >> > This series (mainly patch 2) adds VLAN

Re: [PATCH net-next] net: bcmgenet: Do not return from void function

From: Florian Fainelli Date: Tue, 29 Aug 2017 21:48:51 -0700 > A stray return was added in the macro bcmgenet_##name##_writel where it > should not, drop it. > > Reported-by: kbuild test robot > Fixes: 69d2ea9c7989 ("net: bcmgenet: Use correct I/O

Re: [PATCH net-next v3 02/13] phy: add the mvebu cp110 comphy driver

Hi, On Tuesday 29 August 2017 06:42 PM, Antoine Tenart wrote: > Hi Kishon, > > On Tue, Aug 29, 2017 at 05:55:06PM +0530, Kishon Vijay Abraham I wrote: >> On Tuesday 29 August 2017 04:53 PM, Antoine Tenart wrote: >>> On Tue, Aug 29, 2017 at 04:34:17PM +0530, Kishon Vijay Abraham I wrote: On

Re: Fwd: DA850-evm MAC Address is random

On Wednesday 30 August 2017 06:19 AM, Adam Ford wrote: > On Tue, Aug 29, 2017 at 10:20 AM, Adam Ford wrote: >> On Tue, Aug 29, 2017 at 10:16 AM, Sekhar Nori wrote: >>> On Tuesday 29 August 2017 05:32 PM, Adam Ford wrote: On Tue, Aug 29, 2017 at 6:42 AM,

Re: [PATCH net-next 0/4] nsh: headers, GSO

On Wed, Aug 30, 2017 at 06:17:07AM +0800, David Miller wrote: > From: Jiri Benc > Date: Mon, 28 Aug 2017 21:43:20 +0200 > > > This adds header structs and helpers for NSH together with GSO support. > > > > Note there is no code in this patchset that actually manipulates the

Re: [PATCH net-next v3 0/3] NCSI VLAN Filtering Support

On Mon, 2017-08-28 at 16:50 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas > Date: Mon, 28 Aug 2017 16:18:40 +1000 > > > This series (mainly patch 2) adds VLAN filtering to the NCSI implementation. > > A fair amount of code already exists in the NCSI stack for

[PATCH net-next 3/3 v11] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

RmNet driver provides a transport agnostic MAP (multiplexing and aggregation protocol) support in embedded module. Module provides virtual network devices which can be attached to any IP-mode physical device. This will be used to provide all MAP functionality on future hardware in a single

[PATCH net-next 0/3 v11] Add support for rmnet driver

This patch series adds support for the rmnet driver which is required to support recent chipsets using Qualcomm Technologies, Inc. modems. The data from hardware follows the multiplexing and aggregation protocol (MAP). This driver can be used to register onto any physical network device in IP

[PATCH net-next 1/3 v11] net: ether: Add support for multiplexing and aggregation type

Define the Qualcomm multiplexing and aggregation (MAP) ether type 0x00F9. This is needed for receiving data in the MAP protocol like RMNET. This is not an officially registered ID. Signed-off-by: Subash Abhinov Kasiviswanathan --- include/uapi/linux/if_ether.h | 3 +++

[PATCH net-next 2/3 v11] net: arp: Add support for raw IP device

Define the raw IP type. This is needed for raw IP net devices like rmnet. Signed-off-by: Subash Abhinov Kasiviswanathan --- include/uapi/linux/if_arp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/if_arp.h b/include/uapi/linux/if_arp.h index

[PATCH net-next] net: bcmgenet: Do not return from void function

A stray return was added in the macro bcmgenet_##name##_writel where it should not, drop it. Reported-by: kbuild test robot Fixes: 69d2ea9c7989 ("net: bcmgenet: Use correct I/O accessors") Signed-off-by: Florian Fainelli ---

Re: [PATCH net-next v3] bridge: fdb add and delete tracepoints

On 08/29/2017 01:16 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > A few useful tracepoints to trace bridge forwarding > database updates. > > Signed-off-by: Roopa Prabhu Reviewed-by: Florian Fainelli thanks for

Re: [PATCH RFC 2/2] virtio_net: enable probing for NEEDS_RESET support

On Tue, Aug 29, 2017 at 04:27:41PM -0400, Willem de Bruijn wrote: > On Tue, Aug 29, 2017 at 4:16 PM, Michael S. Tsirkin wrote: > > On Tue, Aug 29, 2017 at 04:07:59PM -0400, Willem de Bruijn wrote: > >> From: Willem de Bruijn > >> > >> Implement a mechanism to

Re: [PATCH net-next 0/4] Endian fixes for SYSTEMPORT/SF2/MDIO

On 08/29/2017 11:39 AM, Florian Fainelli wrote: > Hi David, > > While trying an ARM BE kernel for kinks, the 3 drivers below started not > working and the reasons why became pretty obvious because the register space > remains LE (hardwired), except for Broadcom MIPS where it follows the CPU's >

[PATCH] net: remove dmaengine.h inclusion from netdevice.h

Since the removal of NET_DMA, dmaengine.h header file shouldn't be needed by netdevice.h anymore. Signed-off-by: Dave Jiang --- include/linux/netdevice.h |1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index

[PATCH net-next v2 2/4] net: dsa: bcm_sf2: Use correct I/O accessors

The Starfigther 2 driver currently uses __raw_{read,write}l which means native I/O endian. This works correctly for an ARM LE kernel (default) but fails miserably on an ARM BE (BE8) kernel where registers are kept little endian, so replace uses with {read,write}l_relaxed here which is what we want

[PATCH net-next v2 0/4] Endian fixes for SYSTEMPORT/SF2/MDIO

Hi David, While trying an ARM BE kernel for kinks, the 3 drivers below started not working and the reasons why became pretty obvious because the register space remains LE (hardwired), except for Broadcom MIPS where it follows the CPU's native endian (let's call that a feature). Thanks! Changes

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

On Tue, Aug 29, 2017 at 03:53:08PM -0400, Willem de Bruijn wrote: > On Tue, Aug 29, 2017 at 3:42 PM, Michael S. Tsirkin wrote: > > On Tue, Aug 29, 2017 at 03:35:38PM -0400, Willem de Bruijn wrote: > >> By the way, I have had an unrelated patch outstanding for a while > >> to have

Re: [patch v1 1/2] dt-bindings: net: add binding documentation for mlxsw thermal control

> +- compatible : "mellanox,mlxsw_minimal" Interesting product name. Is there a mlxsw_maximal planned? > +- reg: The I2C address of the device. > + > +Optional properties: > +- cooling-phandle: phandle of the cooling device, which is to be used > +

Re: [PATCH net-next 0/7] XDP redirect tracepoints

From: Jesper Dangaard Brouer Date: Tue, 29 Aug 2017 16:37:35 +0200 > I feel this is as far as I can take the tracepoint infrastructure to > assist XDP monitoring. > > Tracepoints comes with a base overhead of 25 nanosec for an attached > bpf_prog, and 48 nanosec for using a

Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into the kernel

From: Greg KH Date: Tue, 29 Aug 2017 19:46:22 +0200 > When moving the IRDA code out of net/ into drivers/staging/irda/net, the > link order changes when IRDA is built into the kernel. That causes a > kernel crash at boot time as netfilter isn't initialized yet. > >

Re: [PATCH net] sch_htb: fix crash on init failure

On Tue, Aug 29, 2017 at 11:09 AM, Eric Dumazet wrote: > On Tue, 2017-08-29 at 20:58 +0300, Nikolay Aleksandrov wrote: >> The commit below added a call to the ->destroy() callback for all qdiscs >> which failed in their ->init(), but some were not prepared for such >>

Re: [PATCH net] sch_htb: fix crash on init failure

On Tue, 2017-08-29 at 11:09 -0700, Eric Dumazet wrote: > On Tue, 2017-08-29 at 20:58 +0300, Nikolay Aleksandrov wrote: > > The commit below added a call to the ->destroy() callback for all qdiscs > > which failed in their ->init(), but some were not prepared for such > > change and can't handle

Re: [PATCH net] sch_htb: fix crash on init failure

On Tue, 2017-08-29 at 11:13 -0700, Cong Wang wrote: > On Tue, Aug 29, 2017 at 11:09 AM, Eric Dumazet wrote: > > On Tue, 2017-08-29 at 20:58 +0300, Nikolay Aleksandrov wrote: > >> The commit below added a call to the ->destroy() callback for all qdiscs > >> which failed in

[PATCH net] sch_multiq: fix double free on init failure

The below commit added a call to ->destroy() on init failure, but multiq still frees ->queues on error in init, but ->queues is also freed by ->destroy() thus we get double free and corrupted memory. Very easy to reproduce (eth0 not multiqueue): $ tc qdisc add dev eth0 root multiq RTNETLINK

[PATCH RFC 2/2] virtio_net: enable probing for NEEDS_RESET support

From: Willem de Bruijn Implement a mechanism to signal that a virtio device implements the VIRTIO_CONFIG_S_NEEDS_RESET command. Testing for VIRTIO_CONFIG_S_NEEDS_RESET support by issuing the request and verifying the reset state would require an expensive state change. To

[PATCH RFC 1/2] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

From: Willem de Bruijn Implement the reset communication request defined in the VIRTIO 1.0 specification and introduces in Linux in commit c00bbcf862896 ("virtio: add VIRTIO_CONFIG_S_NEEDS_RESET device status bit"). Since that patch, the virtio-net driver has added a

Re: [PATCH] DSA support for Micrel KSZ8895

On 08/29/2017 02:15 PM, Pavel Machek wrote: > On Tue 2017-08-29 14:26:04, Andrew Lunn wrote: >>> But the MDIO emaulation code is from their driver, after lots of >>> deletions. >> >> Is this driver supposed to run on lots of different OSs? That would >> explain why they ignored the Linux MDIO and

  1   2   3   >