Re: net/ipv4: divide error in __tcp_select_window

On Thu, Aug 31, 2017 at 1:56 AM, idaifish wrote: > Hi: >This bug seems still can be triggered by the attached PoC on latest > Ubuntu1604 (4.4.0-94-generic) > > > divide error: [#1] SMP KASAN

[PATCH net-next] samples/bpf: Fix compilation issue in redirect dummy program

Fix compilation error below: $ make samples/bpf/ LLVM ERROR: 'xdp_redirect_dummy' label emitted multiple times to assembly file make[1]: *** [samples/bpf/xdp_redirect_kern.o] Error 1 make: *** [samples/bpf/] Error 2 Fixes: 306da4e685b4 ("samples/bpf: xdp_redirect load XDP dummy prog on TX

Re: DSA mv88e6xxx RX frame errors and TCP/IP RX failure

check with ping -s 1500 that packets passed to cpu. mv88e6xxx add additional dsa tag before the frame so small packets can pass and big rejected. also ethtool -S dsaethdevX shows more details stats for Marvell chips. or opposite, lower mtu on cpu to 1400 and check that ping works. So from

Re: [PATCH net-next 6/7] samples/bpf: xdp_redirect load XDP dummy prog on TX device

Hi Jesper, On 29/08/2017 5:38 PM, Jesper Dangaard Brouer wrote: +/* Redirect require an XDP bpf_prog loaded on the TX device */ +SEC("xdp_redirect_dummy") +int xdp_redirect_dummy(struct xdp_md *ctx) +{ + return XDP_PASS; +} + I get a compilation error related to this: $ make

[PATCH net-next] net: fix two typos in net_device_ops documentation.

This patch fixes two trivial typos in net_device_ops documentation, related to ndo_xdp_flush callback. Signed-off-by: Rami Rosen --- include/linux/netdevice.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/netdevice.h

Re: [PATCH net-next] samples/bpf: Fix compilation issue in redirect dummy program

On Thu, 31 Aug 2017 14:16:39 +0300 Tariq Toukan wrote: > Fix compilation error below: > > $ make samples/bpf/ > > LLVM ERROR: 'xdp_redirect_dummy' label emitted multiple times to > assembly file > make[1]: *** [samples/bpf/xdp_redirect_kern.o] Error 1 > make: ***

Re: [PATCH v2 net-next 0/6] flow_dissector: Protocol specific flow dissector offload

Hello, Tom Herbert writes: > On Wed, Aug 30, 2017 at 1:41 AM, Hannes Frederic Sowa > wrote: >> Hello Tom, >> >> Tom Herbert writes: >> >>> This patch set adds a new offload type to perform flow dissection for >>> specific

Re: [PATCH net-next v7] openvswitch: enable NSH support

On Wed, 30 Aug 2017 20:39:12 +0800, Yi Yang wrote: > --- a/net/nsh/nsh.c > +++ b/net/nsh/nsh.c > @@ -14,6 +14,47 @@ > #include > #include > > +int skb_push_nsh(struct sk_buff *skb, const struct nshhdr *nsh_src, bool > is_eth) > +{ > + struct nshhdr *nsh; > + size_t length =

[RFC PATCH] net: frag limit checks need to use percpu_counter_compare

To: Liujian can you please test this patch? I want to understand if using __percpu_counter_compare() solves the problem correctness wise (even-though this will be slower than using a simple atomic_t on your big system). Fix bug in fragmentation codes use of the percpu_counter API, that cause

Re: [PATCH net-next 6/7] samples/bpf: xdp_redirect load XDP dummy prog on TX device

On Thu, 31 Aug 2017 13:08:22 +0300 Tariq Toukan wrote: > Hi Jesper, > > On 29/08/2017 5:38 PM, Jesper Dangaard Brouer wrote: > > > > +/* Redirect require an XDP bpf_prog loaded on the TX device */ > > +SEC("xdp_redirect_dummy") > > +int xdp_redirect_dummy(struct xdp_md

hi

you speak French or English

Re: [PATCH net 0/2] netfilter: ipvs: some fixes in sctp_conn_schedule

On Mon, Aug 28, 2017 at 06:17:32PM +0200, Pablo Neira Ayuso wrote: > On Sun, Aug 20, 2017 at 01:38:06PM +0800, Xin Long wrote: > > Patch 1/2 fixes the regression introduced by commit 5e26b1b3abce. > > Patch 2/2 makes ipvs not create conn for sctp ABORT packet. > > Will wait for Julian and Simon

Re: [PATCH net] Revert "net: phy: Correctly process PHY_HALTED in phy_stop_machine()"

On 31/08/2017 02:49, Florian Fainelli wrote: > This reverts commit 7ad813f208533cebfcc32d3d7474dc1677d1b09a ("net: phy: > Correctly process PHY_HALTED in phy_stop_machine()") because it is > creating the possibility for a NULL pointer dereference. > > David Daney provide the following call trace

[PATCH net-next 8/8] net: hns3: reimplemmentation of pkt buffer allocation

Current implemmentation of buffer allocation in SSU do not meet the requirement to do the buffer reallocation. This patch fixs that in order to support buffer reallocation between Mac and PFC pause. Signed-off-by: Yunsheng Lin Signed-off-by: Lipeng

[PATCH net-next 1/8] net: hns3: add check when initialize

private waterline and and common packet buffer Command HCLGE_OPC_RX_PRIV_WL_ALLOC configure waterline for TC's PFC, which has private buffer.Command HCLGE_OPC_RX_COM_THRD_ALLOC Control each TC's occupation in common packet buffer, also generate PFC for TC, which has not private buffer.When device

[PATCH net-next 6/8] net: hns3: fix bug of reuse command description

When reuse command description, the in/out bit and W/R bit of the command flag should be both updated. The old code did not update in/out bit, this patch fix it. Signed-off-by: Mingguang Qu Signed-off-by: Lipeng ---

Re: [PATCH net-next] xfrm: Add support for network devices capable of removing the ESP trailer

On Wed, Aug 30, 2017 at 11:30:39AM +0300, yoss...@mellanox.com wrote: > From: Yossi Kuperman > > In conjunction with crypto offload [1], removing the ESP trailer by > hardware can potentially improve the performance by avoiding (1) a > cache miss incurred by reading the

Re: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

On Tue, Aug 29, 2017 at 03:37:07PM +, Jorgen S. Hansen wrote: > > On Aug 29, 2017, at 4:36 AM, Dexuan Cui wrote: > If we allow multiple host side transports, virtio host side support and > vmci should be able to coexist regardless of the order of initialization. That

Re: [PATCH 24/25] net/cdc_ncm: Replace tasklet with softirq hrtimer

Anna-Maria Gleixner writes: > From: Thomas Gleixner > > The bh tasklet is used in invoke the hrtimer (cdc_ncm_tx_timer_cb) in > softirq context. This can be also achieved without the tasklet but with > CLOCK_MONOTONIC_SOFT as hrtimer base. > >

[PATCH] net: phy: bcm7xxx: make array bcm7xxx_suspend_cfg static, reduces object code size

From: Colin Ian King Don't populate the array bcm7xxx_suspend_cfg A on the stack, instead make it static. Makes the object code smaller by over 300 bytes: Before: textdata bss dec hex filename 63518146 0 1449738a1

[PATCH 24/25] net/cdc_ncm: Replace tasklet with softirq hrtimer

From: Thomas Gleixner The bh tasklet is used in invoke the hrtimer (cdc_ncm_tx_timer_cb) in softirq context. This can be also achieved without the tasklet but with CLOCK_MONOTONIC_SOFT as hrtimer base. Signed-off-by: Thomas Gleixner Signed-off-by:

Re: [PATCH net-next] samples/bpf: Fix compilation issue in redirect dummy program

On 31/08/2017 2:43 PM, Daniel Borkmann wrote: On 08/31/2017 01:27 PM, Jesper Dangaard Brouer wrote: On Thu, 31 Aug 2017 14:16:39 +0300 Tariq Toukan wrote: Fix compilation error below: $ make samples/bpf/ LLVM ERROR: 'xdp_redirect_dummy' label emitted multiple times

Re: [PATCH net-next] bridge: add tracepoint in br_fdb_update

On Wed, 30 Aug 2017 22:18:13 -0700 Roopa Prabhu wrote: > From: Roopa Prabhu > > This extends bridge fdb table tracepoints to also cover > learned fdb entries in the br_fdb_update path. Note that > unlike other tracepoints I have moved this

Re: [ovs-dev] [PATCH net-next v6 3/3] openvswitch: enable NSH support

Hello, "Mooney, Sean K" writes: [...] >> >> > +struct ovs_key_nsh { >> >> > + u8 flags; >> >> > + u8 ttl; >> >> > + u8 mdtype; >> >> > + u8 np; >> >> > + __be32 path_hdr; >> >> > + __be32 context[NSH_MD1_CONTEXT_SIZE]; }; >> >> > +

[PATCH net-next 7/8] net: hns3: add vlan filter config of Ports

Config the self_define vlan_type as TPID(0x8100) for vlan identification. When normal port initialize vlan configure, set default vlan id as 0. Signed-off-by: Mingguang Qu Signed-off-by: Lipeng ---

[PATCH net-next 3/8] net: hns3: set default mac vlan mask

Add the mask configuration of the MAC_VLAN table. Command HCLGE_OPC_MAC_VLAN_MASK_SET is used to add/read the mask configuration of the MAC_VLAN (u/m vlan) table. Set default mask as {0x00, 0x00, 0x00, 0x00, 0x00, 0x00} means that all bits of mac_vlan are not masked. Signed-off-by: Mingguang Qu

Re: [pull request][net-next 0/3] Mellanox, mlx5 GRE tunnel offloads

Saeed Mahameed writes: > The first patch from Gal and Ariel provides the mlx5 driver support for > ConnectX capability to perform IP version identification and matching in > order to distinguish between IPv4 and IPv6 without the need to specify the > encapsulation type, thus

Re: [PATCH net-next] samples/bpf: Fix compilation issue in redirect dummy program

On 08/31/2017 01:27 PM, Jesper Dangaard Brouer wrote: On Thu, 31 Aug 2017 14:16:39 +0300 Tariq Toukan wrote: Fix compilation error below: $ make samples/bpf/ LLVM ERROR: 'xdp_redirect_dummy' label emitted multiple times to assembly file make[1]: ***

[PATCH net-next 0/8] Bug fixes & Code improvements in HNS driver

This patch-set introduces some bug fixes and code improvements. These have been identified during internal review or testing of the driver by internal Hisilicon teams. Lipeng (8): net: hns3: add check when initialize net: hns3: update ring and vector map command net: hns3: set default mac

[PATCH net-next 2/8] net: hns3: update ring and vector map command

Add INT_GL and VF id to vector configure when bind ring with vector. INT_GL means Interrupt Gap Limiting.Vector id starts from 0 in each VF, so the bind command must specify VF id. Signed-off-by: Lipeng Signed-off-by: Mingguang Qu ---

[PATCH net-next 4/8] net: hns3: set default vlan id to PF

When there is no vlan id in the packets, hardware will treat the vlan id as 0 and look for the mac_vlan table. This patch set the default vlan id of PF as 0. Signed-off-by: Mingguang Qu Signed-off-by: Lipeng ---

[PATCH] fsl/fman: make arrays port_ids static, reduces object code size

From: Colin Ian King Don't populate the arrays port_ids on the stack, instead make them static. Makes the object code smaller by over 700 bytes: Before: textdata bss dec hex filename 287855832 192 3480987f9 fman.o After: text

[PATCH net-next] x86: bpf_jit: small optimization in emit_bpf_tail_call()

From: Eric Dumazet Saves 4 bytes replacing following instructions : lea rax, [rsi + rdx * 8 + offsetof(...)] mov rax, qword ptr [rax] cmp rax, 0 by : mov rax, [rsi + rdx * 8 + offsetof(...)] test rax, rax Signed-off-by: Eric Dumazet Cc: Alexei

[PATCH 21/25] xfrm: Replace hrtimer tasklet with softirq hrtimer

From: Thomas Gleixner Switch the timer to CLOCK_MONOTONIC_SOFT, which executed the timer callback in softirq context and remove the hrtimer_tasklet. Signed-off-by: Thomas Gleixner Signed-off-by: Anna-Maria Gleixner Cc: Steffen

Re: [PATCH net-next] x86: bpf_jit: small optimization in emit_bpf_tail_call()

On 08/31/2017 01:53 PM, Eric Dumazet wrote: From: Eric Dumazet Saves 4 bytes replacing following instructions : lea rax, [rsi + rdx * 8 + offsetof(...)] mov rax, qword ptr [rax] cmp rax, 0 by : mov rax, [rsi + rdx * 8 + offsetof(...)] test rax, rax Signed-off-by: Eric

Re: rtlwifi: rtl8723be: fix duplicated code for different branches

"Gustavo A. R. Silva" wrote: > Refactor code in order to avoid identical code for different branches. > > Addresses-Coverity-ID: 1248728 > Signed-off-by: Gustavo A. R. Silva > Acked-by: Larry Finger Patch applied to

[PATCH] ath9k: remove cast to void pointer

casting to void pointer from any pointer type and vice-versa is done implicitly and therefore casting is not needed in such a case. Signed-off-by: Himanshu Jha --- drivers/net/wireless/ath/ath9k/ar9003_mac.c | 4 ++-- drivers/net/wireless/ath/ath9k/dfs.c

[PATCH net-next 5/8] net: hns3: set the VLAN Ethernet type to HW

This patch set the VLAN Ethetnet type(0x8100) to HW. With this configure, HW can identify vlan packets. Signed-off-by: Mingguang Qu Signed-off-by: Lipeng --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 13 +

netdev watchdog enp1s0 (tg3): transmit queue 0 timed out

Dear NetDev Team, I am new to this machine. And this list. On a marketplace website I bought a Dell PowerEdge sc1435. [0.00] Linux version 4.11.8-300.fc26.x86_64 (mockbuild@bkernel0 2.phx2.fedoraproject.org) (gcc version 7.1.1 20170622 (Red Hat 7.1.1-3) (GCC) ) #1 SMP Thu Jun 29

Re: [PATCH 24/25] net/cdc_ncm: Replace tasklet with softirq hrtimer

On Thu, Aug 31, 2017 at 12:23:46PM -, Anna-Maria Gleixner wrote: > From: Thomas Gleixner > > The bh tasklet is used in invoke the hrtimer (cdc_ncm_tx_timer_cb) in > softirq context. This can be also achieved without the tasklet but with > CLOCK_MONOTONIC_SOFT as hrtimer

Re: [PATCH net-next 2/3] net: mvpp2: use the GoP interrupt for link status changes

On Thu, Aug 31, 2017 at 09:12:55AM +0200, Antoine Tenart wrote: > +static void mvpp22_gop_unmask_irq(struct mvpp2_port *port) > +{ > + u32 val; > + > + if (port->phy_interface == PHY_INTERFACE_MODE_RGMII || > + port->phy_interface == PHY_INTERFACE_MODE_RGMII_ID || > +

Re: [GIT] Networking

(Adding linux-wireless) Pavel Machek writes: > On Thu 2017-08-31 07:44:58, Kalle Valo wrote: >> David Miller writes: >> >> > From: Kalle Valo >> > Date: Wed, 30 Aug 2017 20:31:31 +0300 >> > >> >> AFAICS the bug was introduced by

Re: [patch net-next 0/8] mlxsw: Add IPv6 host dpipe table

On 08/30/2017 08:26 PM, Andrew Lunn wrote: > On Wed, Aug 30, 2017 at 02:02:58PM +0200, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Arkadi says: >> >> This patchset adds IPv6 host dpipe table support. This will provide the >> ability to observe the hardware offloaded IPv6

Re: [PATCH net-next 2/3] net: mvpp2: use the GoP interrupt for link status changes

Hi Andrew, On Thu, Aug 31, 2017 at 03:47:24PM +0200, Andrew Lunn wrote: > On Thu, Aug 31, 2017 at 09:12:55AM +0200, Antoine Tenart wrote: > > +static void mvpp22_gop_unmask_irq(struct mvpp2_port *port) > > +{ > > + u32 val; > > + > > + if (port->phy_interface == PHY_INTERFACE_MODE_RGMII || >

[PATCH net-next v6] net: stmmac: Delete dead code for MDIO registration

This code is no longer used, the logging function was changed by commit fbca164776e4 ("net: stmmac: Use the right logging function in stmmac_mdio_register"). It was previously showing information about the type of the IRQ, if it's polled, ignored or a normal interrupt. As we don't want

[PATCH v2 net-next 0/2] net: ubuf_info.refcnt conversion

Yet another atomic_t -> refcount_t conversion, split in two patches. First patch prepares the automatic conversion done in the second patch. Eric Dumazet (2): net: prepare (struct ubuf_info)->refcnt conversion net: convert (struct ubuf_info)->refcnt to refcount_t drivers/vhost/net.c|

Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data

On Thu, Aug 31, 2017 at 4:45 PM, Dmitry Torokhov wrote: > On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook wrote: >> In several places, .data is checked for initialization to gate early >> calls to del_timer_sync(). Checking for .function is equally

Re: [PATCH net-next v5 2/2] tcp_diag: report TCP MD5 signing keys and addresses

On Fri, Sep 01, 2017 at 01:26:33AM +0200, Sabrina Dubroca wrote: > 2017-08-31, 09:59:39 -0700, Ivan Delalande wrote: > > diff --git a/net/ipv4/tcp_diag.c b/net/ipv4/tcp_diag.c > > index a748c74aa8b7..abbf0edcf6c2 100644 > > --- a/net/ipv4/tcp_diag.c > > +++ b/net/ipv4/tcp_diag.c > [...] > >

Re: [PATCH v3 net-next 1/7] bpf: Add mark and priority to sock options that can be set

On 09/01/2017 12:05 AM, David Ahern wrote: Add socket mark and priority to fields that can be set by ebpf program when a socket is created. Signed-off-by: David Ahern Acked-by: Alexei Starovoitov --- include/uapi/linux/bpf.h | 2 ++ net/core/filter.c

Re: [PATCH v3 net-next 2/7] bpf: Allow cgroup sock filters to use get_current_uid_gid helper

On 09/01/2017 12:05 AM, David Ahern wrote: Allow BPF programs run on sock create to use the get_current_uid_gid helper. IPv4 and IPv6 sockets are created in a process context so there is always a valid uid/gid Signed-off-by: David Ahern Acked-by: Alexei Starovoitov

Re: [PATCH net-next] bridge: add tracepoint in br_fdb_update

On Thu, 31 Aug 2017 23:50:26 +0200 Jesper Dangaard Brouer wrote: > On Thu, 31 Aug 2017 11:43:25 -0700 (PDT) > David Miller wrote: > > > From: Roopa Prabhu > > Date: Wed, 30 Aug 2017 22:18:13 -0700 > > > > > From: Roopa

[RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.

This patch introduces a new socket option SO_SYMMETRIC_QUEUES that can be used to enable symmetric tx and rx queues on a socket. This option is specifically useful for epoll based multi threaded workloads where each thread handles packets received on a single RX queue . In this model, we have

Re: [PATCH net-next v5 2/2] tcp_diag: report TCP MD5 signing keys and addresses

2017-08-31, 09:59:39 -0700, Ivan Delalande wrote: > diff --git a/net/ipv4/tcp_diag.c b/net/ipv4/tcp_diag.c > index a748c74aa8b7..abbf0edcf6c2 100644 > --- a/net/ipv4/tcp_diag.c > +++ b/net/ipv4/tcp_diag.c [...] > +static int tcp_diag_get_aux(struct sock *sk, bool net_admin, > +

[PATCH 31/31] timer: Switch to testing for .function instead of .data

In several places, .data is checked for initialization to gate early calls to del_timer_sync(). Checking for .function is equally valid, so switch to this in all callers. Cc: "Rafael J. Wysocki" Cc: Pavel Machek Cc: Len Brown Cc: Greg

[PATCH 30/31] appletalk: Remove unneeded synchronization

The use of del_timer_sync() will make sure a timer is not rescheduled. As such, there is no need to add external signals to kill timers. In preparation for switching the timer callback argument to the timer pointer, this drops the .data argument since it doesn't serve a meaningful purpose here.

Re: [PATCH v2 net-next 1/2] net: prepare (struct ubuf_info)->refcnt conversion

On Thu, Aug 31, 2017 at 7:48 PM, Eric Dumazet wrote: > In order to convert this atomic_t refcnt to refcount_t, > we need to init the refcount to one to not trigger > a 0 -> 1 transition. > > This also removes one atomic operation in fast path. > > v2: removed dead code in

Re: netdev carrier changes is one even after ethernet link up.

On 08/30/2017 10:53 PM, Bhadram Varka wrote: > Hi, > > > > I have observed that carrier_changes is one even in case of the ethernet > link is up. > > > > After investigating the code below is my observation – > > > > ethernet_driver_probe() > > +--->phy_connect() > > |

Re: [PATCH v3 net-next 7/7] samples/bpf: Update cgroup socket examples to use uid gid helper

On Thu, Aug 31, 2017 at 03:05:50PM -0700, David Ahern wrote: > Signed-off-by: David Ahern Acked-by: Alexei Starovoitov

Re: [PATCH v3 net-next 5/7] samples/bpf: Add option to dump socket settings

On Thu, Aug 31, 2017 at 03:05:48PM -0700, David Ahern wrote: > Add option to dump socket settings. Will be used in the next patch > to verify bpf programs are correctly setting mark, priority and > device based on the cgroup attachment for the program run. > > Signed-off-by: David Ahern

Re: [PATCH v3 net-next 6/7] samples/bpf: Update cgrp2 socket tests

On Thu, Aug 31, 2017 at 03:05:49PM -0700, David Ahern wrote: > Update cgrp2 bpf sock tests to check that device, mark and priority > can all be set on a socket via bpf programs attached to a cgroup. > > Signed-off-by: David Ahern Acked-by: Alexei Starovoitov

[PATCH] ipv6: sr: Use ARRAY_SIZE macro

Grepping for "sizeof\(.+\) / sizeof\(" found this as one of the first candidates. Maybe a coccinelle can catch all of those. Signed-off-by: Thomas Meyer --- net/ipv6/seg6_hmac.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/ipv6/seg6_hmac.c

Re: [PATCH net-next] bridge: add tracepoint in br_fdb_update

On 31/08/17 08:18, Roopa Prabhu wrote: > From: Roopa Prabhu > > This extends bridge fdb table tracepoints to also cover > learned fdb entries in the br_fdb_update path. Note that > unlike other tracepoints I have moved this to when the fdb > is modified because this is

Re: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi

On Tue, Aug 29, 2017 at 3:35 PM, Willem de Bruijn wrote: > On Fri, Aug 25, 2017 at 9:03 PM, Willem de Bruijn > wrote: >> On Fri, Aug 25, 2017 at 7:32 PM, Michael S. Tsirkin wrote: >>> On Fri, Aug 25, 2017 at

[PATCH] wl1251: add a missing spin_lock_init()

From: Cong Wang wl1251: add a missing spin_lock_init() This fixes the following kernel warning: [ 5668.771453] BUG: spinlock bad magic on CPU#0, kworker/u2:3/9745 [ 5668.771850] lock: 0xce63ef20, .magic: , .owner: /-1, .owner_cpu: 0 [ 5668.772277]

Re: [PATCH] rtlwifi: refactor code in halbtcoutsrc module

On 08/30/2017 11:46 AM, Gustavo A. R. Silva wrote: Function halbtc_get_wifi_rssi always returns rtlpriv->dm.undec_sm_pwdb. So this function can be removed and the value of rtlpriv->dm.undec_sm_pwdb assigned to *s32_tmp directly. This issue was first reported by Coverity as "identical code for

Re: [PATCH net-next] bridge: add tracepoint in br_fdb_update

On Thu, Aug 31, 2017 at 5:38 AM, Jesper Dangaard Brouer wrote: > On Wed, 30 Aug 2017 22:18:13 -0700 > Roopa Prabhu wrote: > >> From: Roopa Prabhu >> >> This extends bridge fdb table tracepoints to also cover >> learned fdb

Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement fast refcount overflow protection

On Wed, 2017-08-30 at 21:10 -0700, Kees Cook wrote: > On Wed, Aug 30, 2017 at 9:01 PM, Kees Cook wrote: > > On Wed, Aug 30, 2017 at 8:12 PM, Mike Galbraith wrote: > >> On Wed, 2017-08-30 at 19:27 -0700, Kees Cook wrote: > >> > >>> Interesting! Can you try

[PATCH][net-next] net: qualcomm: rmnet: remove unused variable priv

From: Colin Ian King priv is being assigned but is never used, so remove it. Cleans up clang build warning: "warning: Value stored to 'priv' is never read" Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation") Signed-off-by: Colin

Re: [PATCH net-next] x86: bpf_jit: small optimization in emit_bpf_tail_call()

On Thu, Aug 31, 2017 at 04:53:42AM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > Saves 4 bytes replacing following instructions : > > lea rax, [rsi + rdx * 8 + offsetof(...)] > mov rax, qword ptr [rax] > cmp rax, 0 > > by : > > mov rax, [rsi + rdx * 8 +

Re: [PATCH net-next] net/ncsi: Define {add, kill}_vid callbacks for !CONFIG_NET_NCSI

On 31-Aug-2017 01:38 PM, Samuel Mendoza-Jonas wrote: > Patch "net/ncsi: Configure VLAN tag filter" defined two new callback > functions in include/net/ncsi.h, but neglected the !CONFIG_NET_NCSI > case. This can cause a build error if these are referenced elsewhere > without NCSI enabled, for

Re: [PATCH net-next] bridge: add tracepoint in br_fdb_update

On 8/31/17 9:21 AM, Roopa Prabhu wrote: > On Thu, Aug 31, 2017 at 5:38 AM, Jesper Dangaard Brouer > wrote: >> On Wed, 30 Aug 2017 22:18:13 -0700 >> Roopa Prabhu wrote: >> >>> From: Roopa Prabhu >>> >>> This extends bridge

Re: [PATCH net] Revert "net: phy: Correctly process PHY_HALTED in phy_stop_machine()"

On 31/08/2017 14:29, Marc Gonzalez wrote: > On 31/08/2017 02:49, Florian Fainelli wrote: > >> The original motivation for this change originated from Marc Gonzalez >> indicating that his network driver did not have its adjust_link callback >> executing with phydev->link = 0 while he was

Re: [PATCH v2 net-next 1/8] bpf: Add support for recursively running cgroup sock filters

Hello, David, Alexei. Sorry about late reply. On Sun, Aug 27, 2017 at 08:49:23AM -0600, David Ahern wrote: > On 8/25/17 8:49 PM, Alexei Starovoitov wrote: > > > >> + if (prog && curr_recursive && !new_recursive) > >> + /* if a parent has recursive prog attached, only > >> +

Re: DSA mv88e6xxx RX frame errors and TCP/IP RX failure

On Wed, Aug 30, 2017 at 6:46 PM, Andrew Lunn wrote: >> >/* Report late collisions as a frame error. */ >> > if (status & (BD_ENET_RX_NO | BD_ENET_RX_CL)) >> > ndev->stats.rx_frame_errors++; >> > >> > I

Re: [PATCH v2 net-next 4/6] udp: flow dissector offload

On Wed, Aug 30, 2017 at 6:36 AM, Paolo Abeni wrote: > On Tue, 2017-08-29 at 16:27 -0700, Tom Herbert wrote: >> Add support to perform UDP specific flow dissection. This is >> primarily intended for dissecting encapsulated packets in UDP >> encapsulation. >> >> This patch adds a

[patch net-next repost 0/8] mlxsw: Add IPv6 host dpipe table

From: Jiri Pirko This patchset adds IPv6 host dpipe table support. This will provide the ability to observe the hardware offloaded IPv6 neighbors. Arkadi Sharshevsky (8): devlink: Add IPv6 header for dpipe mlxsw: spectrum_router: Export IPv6 link local address check

[patch net-next repost 5/8] mlxsw: spectrum_dpipe: Make host entry fill handler more generic

From: Arkadi Sharshevsky Change the host entry filler helper to be applicable for both IPv4/6 addresses. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c | 13

[patch net-next repost 1/8] devlink: Add IPv6 header for dpipe

From: Arkadi Sharshevsky This will be used by the IPv6 host table which will be introduced in the following patches. The fields in the header are added per-use. This header is global and can be reused by many drivers. Signed-off-by: Arkadi Sharshevsky

[patch net-next repost 8/8] mlxsw: spectrum_dpipe: Add support for controlling IPv6 neighbor counters

From: Arkadi Sharshevsky Add support for controlling IPv6 neighbor counters via dpipe. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c | 18 +-

[patch net-next repost 3/8] mlxsw: spectrum_dpipe: Add IPv6 host table initial support

From: Arkadi Sharshevsky Add IPv6 host table initial support. The action behavior for both IPv4/6 tables is the same, thus the same action dump op is used. Neighbors with link local address are ignored. Signed-off-by: Arkadi Sharshevsky

[PATCH net] ipv4: Don't override return code from ip_route_input_noref()

After ip_route_input() calls ip_route_input_noref(), another check on skb_dst() is done, but if this fails, we shouldn't override the return code from ip_route_input_noref(), as it could have been more specific (i.e. -EHOSTUNREACH). This also saves one call to skb_dst_force_safe() and one to

Re: [PATCH net-next] bridge: add tracepoint in br_fdb_update

On Thu, 31 Aug 2017 09:30:05 -0600 David Ahern wrote: > On 8/31/17 9:21 AM, Roopa Prabhu wrote: > > On Thu, Aug 31, 2017 at 5:38 AM, Jesper Dangaard Brouer > > wrote: > >> On Wed, 30 Aug 2017 22:18:13 -0700 > >> Roopa Prabhu

Re: [PATCH net] Revert "net: phy: Correctly process PHY_HALTED in phy_stop_machine()"

On 08/31/2017 05:29 AM, Marc Gonzalez wrote: On 31/08/2017 02:49, Florian Fainelli wrote: This reverts commit 7ad813f208533cebfcc32d3d7474dc1677d1b09a ("net: phy: Correctly process PHY_HALTED in phy_stop_machine()") because it is creating the possibility for a NULL pointer dereference. David

Re: tip -ENOBOOT - bisected to locking/refcounts, x86/asm: Implement fast refcount overflow protection

On Thu, Aug 31, 2017 at 6:58 AM, Mike Galbraith wrote: > On Wed, 2017-08-30 at 21:10 -0700, Kees Cook wrote: >> On Wed, Aug 30, 2017 at 9:01 PM, Kees Cook wrote: >> > On Wed, Aug 30, 2017 at 8:12 PM, Mike Galbraith wrote: >> >> On Wed,

virtio_net: ethtool supported link modes

Hello, Looking at the code in virtnet_set_link_ksettings, it seems the speed and duplex can be set to any valid value. The driver will "remember" them and report them back in virtnet_get_link_ksettings. However, the supported link modes (link_modes.supported in struct ethtool_link_ksettings) is

[PATCH][next] net/mlx4_core: fix incorrect size allocation for dev->caps.spec_qps

From: Colin Ian King The current allocation for dev->caps.spec_qps is for the size of the pointer and not the size of the actual mlx4_spec_qps structure. Fix this by using the correct size. Also splint allocation over a few lines to make it cppcheck clean on overly

Re: [RFC PATCH] net: frag limit checks need to use percpu_counter_compare

On Thu, 31 Aug 2017 12:20:19 +0200 Jesper Dangaard Brouer wrote: > +static inline bool frag_mem_over_limit(struct netns_frags *nf, int thresh) > { > - return percpu_counter_read(>mem); > + /* When reading counter here, __percpu_counter_compare() call > + * will

Re: [RFC PATCH] net: frag limit checks need to use percpu_counter_compare

On Thu, Aug 31, 2017 at 12:20:19PM +0200, Jesper Dangaard Brouer wrote: > To: Liujian can you please test this patch? > I want to understand if using __percpu_counter_compare() solves > the problem correctness wise (even-though this will be slower > than using a simple atomic_t on your big

[PATCH][next] net/mlx4_core: fix memory leaks on error exit path

From: Colin Ian King The structures hca_param and func_cap are not being kfree'd on an error exit path causing two memory leaks. Fix this by jumping to the existing free memory error exit path. Detected by CoverityScan, CID#1455219, CID#1455224 ("Resource Leak")

Re: [PATCH net] Revert "net: phy: Correctly process PHY_HALTED in phy_stop_machine()"

On 08/31/2017 09:36 AM, David Daney wrote: > On 08/31/2017 05:29 AM, Marc Gonzalez wrote: >> On 31/08/2017 02:49, Florian Fainelli wrote: >> >>> This reverts commit 7ad813f208533cebfcc32d3d7474dc1677d1b09a ("net: phy: >>> Correctly process PHY_HALTED in phy_stop_machine()") because it is >>>

Re: [PATCH net] Revert "net: phy: Correctly process PHY_HALTED in phy_stop_machine()"

On 08/31/2017 05:29 AM, Marc Gonzalez wrote: > On 31/08/2017 02:49, Florian Fainelli wrote: > >> This reverts commit 7ad813f208533cebfcc32d3d7474dc1677d1b09a ("net: phy: >> Correctly process PHY_HALTED in phy_stop_machine()") because it is >> creating the possibility for a NULL pointer

Re: [PATCH net-next] samples/bpf: Fix compilation issue in redirect dummy program

On Thu, Aug 31, 2017 at 4:43 AM, Daniel Borkmann wrote: > On 08/31/2017 01:27 PM, Jesper Dangaard Brouer wrote: >> >> On Thu, 31 Aug 2017 14:16:39 +0300 >> Tariq Toukan wrote: >> >>> Fix compilation error below: >>> >>> $ make samples/bpf/ >>> >>> LLVM

Re: [PATCH net-next] samples/bpf: Fix compilation issue in redirect dummy program

On 08/31/2017 05:54 PM, Y Song wrote: On Thu, Aug 31, 2017 at 4:43 AM, Daniel Borkmann wrote: On 08/31/2017 01:27 PM, Jesper Dangaard Brouer wrote: On Thu, 31 Aug 2017 14:16:39 +0300 Tariq Toukan wrote: Fix compilation error below: $ make

[patch net-next repost 7/8] mlxsw: spectrum_router: Add support for setting counters on IPv6 neighbors

From: Arkadi Sharshevsky Add support for setting counters on IPv6 neighbors based on dpipe's host6 table counter status. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko ---

[patch net-next repost 6/8] mlxsw: spectrum_dpipe: Add support for IPv6 host table dump

From: Arkadi Sharshevsky Add support for IPv6 host table dump. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- .../net/ethernet/mellanox/mlxsw/spectrum_dpipe.c | 75 -- 1 file changed, 70

[patch net-next repost 4/8] mlxsw: spectrum_router: Add IPv6 neighbor access helper

From: Arkadi Sharshevsky Add helper for accessing destination IP in case of IPv6 neighbor. Signed-off-by: Arkadi Sharshevsky Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 9 +

[patch net-next repost 2/8] mlxsw: spectrum_router: Export IPv6 link local address check helper

From: Arkadi Sharshevsky Neighbors with link local addresses are not offloaded to the host table, yet, the are maintained in the driver for adjacency table usage. When dumping the IPv6 host neighbors this link local neighbors should be ignored. This patch exports this

Re: [PATCH net] ipv4: Don't override return code from ip_route_input_noref()

> After ip_route_input() calls ip_route_input_noref(), another > check on skb_dst() is done, but if this fails, we shouldn't > override the return code from ip_route_input_noref(), as it > could have been more specific (i.e. -EHOSTUNREACH). > > This also saves one call to skb_dst_force_safe() and

[PATCH net-next v5 0/2] report TCP MD5 signing keys and addresses

Allow userspace to retrieve MD5 signature keys and addresses configured on TCP sockets through inet_diag. Thanks to Eric Dumazet and Stephen Hemminger for their useful explanations and feedback. v5: - memset the whole netlink payload after it has been nla_reserve-d in tcp_diag_put_md5sig

[PATCH net-next v5 2/2] tcp_diag: report TCP MD5 signing keys and addresses

Report TCP MD5 (RFC2385) signing keys, addresses and address prefixes to processes with CAP_NET_ADMIN requesting INET_DIAG_INFO. Currently it is not possible to retrieve these from the kernel once they have been configured on sockets. Signed-off-by: Ivan Delalande ---

  1   2   3   >