Re: [PATCH 16/16] thunderbolt: Add support for networking over Thunderbolt cable

On Tue, Sep 19, 2017 at 01:21:44AM +0200, Andrew Lunn wrote: > On Mon, Sep 18, 2017 at 06:30:49PM +0300, Mika Westerberg wrote: > > From: Amir Levy > > > > ThunderboltIP is a protocol created by Apple to tunnel IP/ethernet > > traffic over a Thunderbolt cable. The

[PATCH,net-next,2/2] tun: enable napi_gro_frags() for TUN/TAP driver

Add a TUN/TAP receive mode that exercises the napi_gro_frags() interface. This mode is available only in TAP mode, as the interface expects packets with Ethernet headers. Furthermore, packets follow the layout of the iovec_iter that was received. The first iovec is the linear data, and every one

Re: [PATCH net-next 04/14] gtp: udp recv clean up

Hi Tom, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Tom-Herbert/gtp-Additional-feature-support/20170919-143920 config: i386-randconfig-x016-201738 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save

[PATCH,net-next,1/2] tun: enable NAPI for TUN/TAP driver

Changes TUN driver to use napi_gro_receive() upon receiving packets rather than netif_rx_ni(). Adds flag CONFIG_TUN_NAPI that enables these changes and operation is not affected if the flag is disabled. SKBs are constructed upon packet arrival and are queued to be processed later. The new path

[PATCH net-next 1/4] qed: Add iWARP enablement support

This patch is the last of the initial iWARP patch series. It adds the possiblity to actually detect iWARP from the device and enable it in the critical locations which basically make iWARP available. It wasn't submitted until now as iWARP hadn't been accepted into the rdma tree. Signed-off-by:

[PATCH net-next 2/4] qed: Add iWARP out of order support

iWARP requires OOO support which is already provided by the ll2 interface (until now was used only for iSCSI offload). The changes mostly include opening a ll2 dedicated connection for OOO and notifiying the FW about the handle id. Signed-off-by: Michal Kalderon

[PATCH net-next 0/4] qed: iWARP fixes and enhancements

This patch series includes several fixes and enhancements related to iWARP. Patch #1 is actually the last of the initial iWARP submission. It has been delayed until now as I wanted to make sure that qedr supports iWARP prior to enabling iWARP device detection. iWARP changes in RDMA tree have

[PATCH net-next 4/4] qed: iWARP - Add check for errors on a SYN packet

A SYN packet which arrives with errors from FW should be dropped. This required adding an additional field to the ll2 rx completion data. Signed-off-by: Michal Kalderon Signed-off-by: Ariel Elior ---

[PATCH] net: compat: assert the size of cmsg copied in is as expected

The actual length of cmsg fetched in during the second loop (i.e., kcmsg - kcmsg_base) could be different from what we get from the first loop (i.e., kcmlen). The main reason is that the two get_user() calls in the two loops (i.e., get_user(ucmlen, >cmsg_len) and __get_user(ucmlen, >cmsg_len))

[PATCH] net: emac: Fix napi poll list corruption

This patch is pretty much a carbon copy of commit 3079c652141f ("caif: Fix napi poll list corruption") with "caif" replaced by "emac". The commit d75b1ade567f ("net: less interrupt masking in NAPI") breaks emac. It is now required that if the entire budget is consumed when poll returns, the napi

Re: [PATCH net] MAINTAINERS: Remove Yuval Mintz from maintainers list

From: Date: Tue, 19 Sep 2017 12:54:34 +0300 > From: Ariel Elior > > Remove Yuval from maintaining the bnx2x & qed* modules as he is no longer > working for the company. Thanks Yuval for your huge contributions and > tireless efforts over the many years and

Re: [PATCH net-next v3 1/4] bpf: add helper bpf_perf_event_read_value for perf event array map

Hi Yonghong, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Yonghong-Song/bpf-add-two-helpers-to-read-perf-event-enabled-running-time/20170919-134113 config: m68k-allyesconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 4.9.0 reproduce

Re: Page allocator bottleneck

On Mon, Sep 18, 2017 at 06:33:20PM +0300, Tariq Toukan wrote: > > > On 18/09/2017 10:44 AM, Aaron Lu wrote: > > On Mon, Sep 18, 2017 at 03:34:47PM +0800, Aaron Lu wrote: > > > On Sun, Sep 17, 2017 at 07:16:15PM +0300, Tariq Toukan wrote: > > > > > > > > It's nice to have the option to

Re: [PATCH net] bpf: fix ri->map prog pointer on bpf_prog_realloc

On 09/19/2017 03:43 AM, Alexei Starovoitov wrote: On Tue, Sep 19, 2017 at 03:16:44AM +0200, Daniel Borkmann wrote: Commit 109980b894e9 ("bpf: don't select potentially stale ri->map from buggy xdp progs") passed the pointer to the prog itself to be loaded into r4 prior on bpf_redirect_map()

Re: [PATCH v2] net: stmmac: dwmac-sun8i: Use reset exclusive

On Mon, Sep 18, 2017 at 08:30:43PM +0200, Corentin Labbe wrote: > The current dwmac_sun8i module cannot be rmmod/modprobe due to that > the reset controller was not released when removed. > > This patch remove ambiguity, by using of_reset_control_get_exclusive and > add the missing

Re: [PATCH RFC V1 net-next 0/6] Time based packet transmission

On Tue, Sep 19, 2017 at 04:43:02PM +0200, Miroslav Lichvar wrote: > If I understand it correctly, this also allows us to make a PTP/NTP > "one-step" clock with HW that doesn't support it directly. Cool, yeah, I hadn't thought of that, but it would work... Thanks, Richard

[PATCH net] tcp: fastopen: fix on syn-data transmit failure

From: Eric Dumazet Our recent change exposed a bug in TCP Fastopen Client that syzkaller found right away [1] When we prepare skb with SYN+DATA, we attempt to transmit it, and we update socket state as if the transmit was a success. In socket RTX queue we have two skbs,

[PATCH net-next 3/4] qed: Fix maximum number of CQs for iWARP

The maximum number of CQs supported is bound to the number of connections supported, which differs between RoCE and iWARP. This fixes a crash that occurred in iWARP when running 1000 sessions using perftest. Signed-off-by: Michal Kalderon Signed-off-by: Ariel Elior

Re: [PATCH net] bpf: do not disable/enable BH in bpf_map_free_id()

On Tue, Sep 19, 2017 at 04:15:59PM +, Eric Dumazet wrote: > From: Eric Dumazet > > syzkaller reported following splat [1] > > Since hard irq are disabled by the caller, bpf_map_free_id() > should not try to enable/disable BH. > > Another solution would be to change

Re: [PATCH] VSOCK: fix uapi/linux/vm_sockets.h incomplete types

From: Stefan Hajnoczi Date: Mon, 18 Sep 2017 16:21:00 +0100 > On Fri, Sep 15, 2017 at 02:14:32PM -0700, David Miller wrote: >> > diff --git a/include/uapi/linux/vm_sockets.h >> > b/include/uapi/linux/vm_sockets.h >> > index b4ed5d895699..4ae5c625ac56 100644 >> > ---

[PATCH net-next 4/4] net: dsa: move master ethtool code

DSA overrides the master device ethtool ops, so that it can inject stats from its dedicated switch CPU port as well. The related code is currently split in dsa.c and slave.c, but it only scopes the master net device. Move it to a new master.c DSA core file. This file will be later extented with

[PATCH net-next 3/4] net: dsa: setup master ethtool after dsa_ptr

DSA overrides the master's ethtool ops so that we can inject its CPU port's statistics. Because of that, we need to setup the ethtool ops after the master's dsa_ptr pointer has been assigned, not before. This patch setups the ethtool ops after dsa_ptr is assigned, and restores them before it gets

[PATCH net-next 2/4] net: dsa: setup master ethtool unconditionally

When a DSA switch tree is meant to be applied, it already has a CPU port. Thus remove the condition of dst->cpu_dp. Moreover, the next lines access dst->cpu_dp unconditionally. Signed-off-by: Vivien Didelot --- net/dsa/dsa2.c | 14 +- 1 file

[PATCH net-next 0/4] net: dsa: move master ethtool code

The DSA core overrides the master device's ethtool_ops structure so that it can inject statistics and such of its dedicated switch CPU port. This ethtool code is currently called on unnecessary conditions or before the master interface and its switch CPU port get wired up. This patchset fixes

Re: Re: [PATCH] net/packet: fix race condition between fanout_add and __unregister_prot_hook

On Tue, Sep 19, 2017 at 3:21 AM, Nixiaoming wrote: > On Fri, Sep 15, 2017 at 10:46 AM, Willem de Bruijn > > wrote: > >> > >> In case of failure we also need to unlink and free match. I > >> sent the following: > >> > >>

RE: [PATCH net-next 05/12] net: dsa: b53: Use a macro to define I/O operations

> >>> +#define b53_build_op(type, op_size, val_type)\ > >>> +static inline int b53_##type##op_size(struct b53_device *dev, u8 > >page,\ > >>> + u8 reg, val_type val) > >>> \ > >>> +{

[RFC PATCH 1/3] usbnet: Get rid of spammy usbnet "kevent X may have been dropped"

Every once in a while when my system is under a bit of stress I see some spammy messages show up in my logs that say: kevent X may have been dropped As far as I can tell these messages aren't terribly useful. The comments around the messages make me think that either workqueues used to work

[PATCH V2 net 4/7] net: hns3: Fixes the initialization of MAC address in hardware

From: Lipeng This patch fixes the initialization of MAC address, fetched from HNS3 firmware i.e. when it is not randomly generated, to the HNS3 hardware. Fixes: ca60906d2795 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Signed-off-by: Lipeng

[PATCH V2 net 6/7] net: hns3: Fixes the default VLAN-id of PF

From: Lipeng When there is no vlan id in the packets, hardware will treat the vlan id as 0 and look for the mac_vlan table. This patch set the default vlan id of PF as 0. Without this config, it will fail when look for mac_vlan table, and hardware will drop packets. Fixes:

[PATCH V2 net 0/7] Bug fixes for the HNS3 Ethernet Driver for Hip08 SoC

This patch set presents some bug fixes for the HNS3 Ethernet driver identified during internal testing & stabilization efforts. Change Log: Patch V2: Resolved comments from Leon Romanovsky Patch V1: Initial Submit Lipeng (6): net: hns3: Fixes initialization of phy address from firmware net:

[PATCH V2 net 2/7] net: hns3: Fixes the command used to unmap ring from vector

From: Lipeng This patch fixes the IMP command being used to unmap the vector from the corresponding ring. Fixes: 6427264ef330 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") Signed-off-by: Lipeng Signed-off-by: Salil Mehta

[PATCH V2 net 3/7] net: hns3: Fixes ring-to-vector map-and-unmap command

From: Lipeng This patch fixes the vector-to-ring map and unmap command and adds INT_GL(for, Gap Limiting Interrupts) and VF id to it as required by the hardware interface. Fixes: 6427264ef330 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support")

[PATCH V2 net 5/7] net: hns3: Fixes the ether address copy with appropriate API

This patch replaces the ethernet address copy instance with more appropriate ether_addr_copy() function. Fixes: 6427264ef330 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") Signed-off-by: Salil Mehta ---

Re: [RFC net-next v2] bridge lwtunnel, VPLS & NVGRE

Hi David, What's next ? do you plan to send a v3 or should I do it ? On 09/11/2017 10:02 AM, Amine Kherbouche wrote: Hi David, Do you plan to send a v3? On 21/08/2017 18:15, David Lamparter wrote: Hi all, this is an update on the earlier "[RFC net-next] VPLS support". Note I've changed

Re: [PATCH net-next v2 12/12] net: dsa: bcm_sf2: Utilize b53_{enable,disable}_port

Florian Fainelli writes: > Export b53_{enable,disable}_port and use these two functions in > bcm_sf2_port_setup and bcm_sf2_port_disable. The generic functions > cannot be used without wrapping because we need to manage additional > switch integration details (PHY, Broadcom

Re: [PATCH net-next 4/4] test_rhashtable: add test case for rhl_table interface

Hi Florian, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Westphal/test_rhashtable-add-test-case-for-rhl-table/20170919-135550 config: x86_64-randconfig-a0-09192105 (attached as .config) compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7 reproduce

Re: [PATCH net-next 00/14] gtp: Additional feature support

On Tue, Sep 19, 2017 at 5:43 AM, Harald Welte wrote: > Hi Tom, > > first of all, thanks a lot for your patch series. It makes me happy to > see contributions on the GTP code :) > > On Mon, Sep 18, 2017 at 05:38:50PM -0700, Tom Herbert wrote: >> - IPv6 support > > see my

[PATCH net-next 1/4] net: dsa: remove copy of master ethtool_ops

There is no need to store a copy of the master ethtool ops, storing the original pointer in DSA and the new one in the master netdev itself is enough. In the meantime, set orig_ethtool_ops to NULL when restoring the master ethtool ops and check the presence of the master original ethtool ops as

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

And 2 more events: === $ dmesg --time-format iso | grep RIP … 2017-09-19T16:52:21,623328+0200 RIP: 0010:tcp_undo_cwnd_reduction+0xbd/0xd0 2017-09-19T16:52:40,455296+0200 RIP: 0010:tcp_fastretrans_alert+0x7c8/0x990 2017-09-19T16:52:41,047378+0200 RIP: 0010:tcp_undo_cwnd_reduction+0xbd/0xd0 …

Re: [PATCH net-next 03/14] gtp: Call common functions to get tunnel routes and add dst_cache

On Mon, Sep 18, 2017 at 9:17 PM, David Miller wrote: > From: Tom Herbert > Date: Mon, 18 Sep 2017 17:38:53 -0700 > >> Call ip_tunnel_get_route and dst_cache to pdp context which should >> improve performance by obviating the need to perform a route

Re: [PATCH net-next 1/3] bpf: Implement map_delete_elem for BPF_MAP_TYPE_LPM_TRIE

On 09/19/2017 05:08 PM, Craig Gallek wrote: On Mon, Sep 18, 2017 at 6:53 PM, Alexei Starovoitov wrote: On 9/18/17 12:30 PM, Craig Gallek wrote: [...] + + next_bit = extract_bit(key->data, node->prefixlen); + /* If we hit a node that has more than one

Re: [PATCH net-next 3/3] bpf: Test deletion in BPF_MAP_TYPE_LPM_TRIE

On 09/18/2017 09:30 PM, Craig Gallek wrote: From: Craig Gallek Extend the 'random' operation tests to include a delete operation (delete half of the nodes from both lpm implementions and ensure that lookups are still equivalent). Also, add a simple IPv4 test which verifies

Re: Re: [PATCH] net/packet: fix race condition between fanout_add and __unregister_prot_hook

On Tue, Sep 19, 2017 at 12:09 PM, Willem de Bruijn wrote: > On Tue, Sep 19, 2017 at 3:21 AM, Nixiaoming wrote: >> On Fri, Sep 15, 2017 at 10:46 AM, Willem de Bruijn >> >> wrote: >> >>> >> >>> In case of

Re: [PATCH net-next 2/3] bpf: Add uniqueness invariant to trivial lpm test implementation

On 09/18/2017 09:30 PM, Craig Gallek wrote: From: Craig Gallek The 'trivial' lpm implementation in this test allows equivalent nodes to be added (that is, nodes consisting of the same prefix and prefix length). For lookup operations, this is fine because insertion happens at

[RFC PATCH 3/3] usbnet: Fix memory leak when rx_submit() fails

If rx_submit() returns an error code then nobody calls usb_free_urb(). That means it's leaked. NOTE: This problem was found solely by code inspection and not due to any failing test cases. Signed-off-by: Douglas Anderson --- drivers/net/usb/usbnet.c | 9 ++--- 1

[PATCH net] bpf: do not disable/enable BH in bpf_map_free_id()

From: Eric Dumazet syzkaller reported following splat [1] Since hard irq are disabled by the caller, bpf_map_free_id() should not try to enable/disable BH. Another solution would be to change htab_map_delete_elem() to defer the free_htab_elem() call after

[RFC PATCH 2/3] usbnet: Avoid potential races in usbnet_deferred_kevent()

In general when you've got a flag communicating that "something needs to be done" you want to clear that flag _before_ doing the task. If you clear the flag _after_ doing the task you end up with the risk that this will happen: 1. Requester sets flag saying task A needs to be done. 2. Worker

[PATCH V2 net 7/7] net: hns3: Fixes the premature exit of loop when matching clients

From: Lipeng When register/unregister ae_dev, ae_dev should match all client in the client_list. Enet and roce can co-exists together so we should continue checking for enet and roce presence together. So break should not be there. Above caused problems in loading and

[PATCH V2 net 1/7] net: hns3: Fixes initialization of phy address from firmware

From: Lipeng Default phy address of every port is 0. Therefore, phy address for each port need to be fetched from firmware and device initialized with fetched non-default phy address. Fixes: 6427264ef330 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer

Re: [PATCH net v2] l2tp: fix race condition in l2tp_tunnel_delete

On Tue, Sep 19, 2017 at 03:40:40PM +0200, Sabrina Dubroca wrote: > If we try to delete the same tunnel twice, the first delete operation > does a lookup (l2tp_tunnel_get), finds the tunnel, calls > l2tp_tunnel_delete, which queues it for deletion by > l2tp_tunnel_del_work. > > The second delete

Re: [RFC PATCH 1/3] usbnet: Get rid of spammy usbnet "kevent X may have been dropped"

On Tue, Sep 19, 2017 at 9:15 AM, Douglas Anderson wrote: > Every once in a while when my system is under a bit of stress I see > some spammy messages show up in my logs that say: > > kevent X may have been dropped > > As far as I can tell these messages aren't terribly

Re: [PATCH net-next v2 08/12] net: dsa: b53: Move EEE functions to b53

Florian Fainelli writes: > Move the bcm_sf2 EEE-related functions to the b53 driver because this is > shared > code amongst Gigabit capable switch, only 5325 and 5365 are too old to support > that. > > Signed-off-by: Florian Fainelli Reviewed-by:

Re: [PATCH net-next v2 09/12] net: dsa: b53: Wire-up EEE

Florian Fainelli writes: > Add support for enabling and disabling EEE, as well as re-negotiating it in > .adjust_link() and in .port_enable(). > > Signed-off-by: Florian Fainelli Reviewed-by: Vivien Didelot

Re: [PATCH net-next v2 10/12] net: dsa: b53: Export b53_imp_vlan_setup()

Florian Fainelli writes: > bcm_sf2 and b53 do exactly the same thing, so share that piece. > > Signed-off-by: Florian Fainelli Reviewed-by: Vivien Didelot

Re: software interrupts close to 100 with 9000 tc filter entries

> Eric Dumazet wrote: > > On Tue, 2017-09-19 at 15:28 +0200, Marco Berizzi wrote: > > > Hi Folks, > > > > I'm running linux 4.12.10 x86_64 on a Slackware 14.2 64bit > > as a simple 4 NIC router. Network throughput processed by > > this machine is less than 200Mbit/s > > The cpu model is

Re: [PATCH net-next v2 11/12] net: dsa: bcm_sf2: Use SF2_NUM_EGRESS_QUEUES for CFP

Florian Fainelli writes: > The magic number 8 in 3 locations in bcm_sf2_cfp.c actually designates the > number of switch port egress queues, so use that define instead of open-coding > it. > > Signed-off-by: Florian Fainelli Reviewed-by: Vivien

[RFC 1/1] net/smc: add SMC rendezvous protocol

The SMC protocol [1] uses a rendezvous protocol to negotiate SMC capability between peers. The current Linux implementation does not use this rendezvous protocol and, thus, is not compliant to RFC7609 and incompatible with other SMC implementations like in zOS. This patch adds support for the SMC

Re: [PATCH net-next 1/3] bpf: Implement map_delete_elem for BPF_MAP_TYPE_LPM_TRIE

On Mon, Sep 18, 2017 at 6:53 PM, Alexei Starovoitov wrote: Thanks for the review! Please correct me if I'm wrong... > On 9/18/17 12:30 PM, Craig Gallek wrote: >> >> From: Craig Gallek >> >> This is a simple non-recursive delete operation. It prunes paths >> of

Re: [PATCH RFC V1 net-next 0/6] Time based packet transmission

On Mon, Sep 18, 2017 at 09:41:15AM +0200, Richard Cochran wrote: > This series is an early RFC that introduces a new socket option > allowing time based transmission of packets. This option will be > useful in implementing various real time protocols over Ethernet, > including but not limited to

Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6 packets

From: Harald Welte Date: Tue, 19 Sep 2017 20:12:45 +0800 > Hi Dave, > > On Mon, Sep 18, 2017 at 09:19:08PM -0700, David Miller wrote: > >> > +static inline u32 ipv6_hashfn(const struct in6_addr *a) >> > +{ >> > + return __ipv6_addr_jhash(a, gtp_h_initval); >> > +} >> >>

Re: [PATCH net-next 2/4] qed: Add iWARP out of order support

On Tue, Sep 19, 2017 at 08:26:17PM +0300, Michal Kalderon wrote: > iWARP requires OOO support which is already provided by the ll2 > interface (until now was used only for iSCSI offload). > The changes mostly include opening a ll2 dedicated connection for > OOO and notifiying the FW about the

Re: [PATCH net-next 03/14] gtp: Call common functions to get tunnel routes and add dst_cache

From: Harald Welte Date: Tue, 19 Sep 2017 20:09:42 +0800 > So I guess you're asking us to document that rationale as form of a > source code comment ? Yes that would make ignoring the potential changing of the non-const 'saddr' argument at least be documented.

Re: [PATCH net-next 3/4] qed: Fix maximum number of CQs for iWARP

On Tue, Sep 19, 2017 at 08:26:18PM +0300, Michal Kalderon wrote: > The maximum number of CQs supported is bound to the number > of connections supported, which differs between RoCE and iWARP. > > This fixes a crash that occurred in iWARP when running 1000 sessions > using perftest. > >

[PATCH net] net: change skb->mac_header when Generic XDP calls adjust_head

Since XDP's view of the packet includes the MAC header, moving the start- of-packet with bpf_xdp_adjust_head needs to also update the offset of the MAC header (which is relative to skb->head, not to the skb->data that was changed). Without this, tcpdump sees packets starting from the old MAC

[PATCH net-next v3 02/12] net: dsa: b53: Make b53_enable_cpu_port() take a port argument

In preparation for future changes allowing the configuring of multiple CPU ports, make b53_enable_cpu_port() take a port argument. Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 11

Re: [PATCH net-next 2/4] net: dsa: setup master ethtool unconditionally

On 09/19/2017 08:56 AM, Vivien Didelot wrote: > When a DSA switch tree is meant to be applied, it already has a CPU > port. Thus remove the condition of dst->cpu_dp. > > Moreover, the next lines access dst->cpu_dp unconditionally. > > Signed-off-by: Vivien Didelot

[PATCH net-next v3 05/12] net: dsa: b53: Use a macro to define I/O operations

Instead of repeating the same pattern: acquire mutex, read/write, release mutex, define a macro: b53_build_op() which takes the type (read|write), I/O size, and value (scalar or pointer). This helps with fixing bugs that could exist (e.g: missing barrier, lock etc.). Reviewed-by: Vivien Didelot

[PATCH net-next v3 01/12] net: dsa: b53: Remove is_cpu_port()

This is not used anywhere, so remove it. Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_priv.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/dsa/b53/b53_priv.h

Re: pull-request: mac80211 2017-11-19

From: Johannes Berg Date: Tue, 19 Sep 2017 09:20:47 +0200 > Here's a new set of two small changes to prevent null pointer > dereferences on malformed netlink messages. > > Please pull and let me know if there's any problem. Pulled, thank you.

Re: [PATCH net-next 05/14] gtp: Remove special mtu handling

On Tue, Sep 19, 2017 at 4:42 AM, Harald Welte wrote: > Hi Tom, > > On Mon, Sep 18, 2017 at 05:38:55PM -0700, Tom Herbert wrote: >> Removes MTU handling in gtp_build_skb_ip4. This is non standard relative >> to how other tunneling protocols handle MTU. The model espoused is

Re: [RFC PATCH 3/3] usbnet: Fix memory leak when rx_submit() fails

Douglas Anderson writes: > If rx_submit() returns an error code then nobody calls usb_free_urb(). > That means it's leaked. Nope. rx_submit() will call usb_free_urb() before returning an error: static int rx_submit (struct usbnet *dev, struct urb *urb, gfp_t flags) ..

[PATCH net-next v3 07/12] net: dsa: b53: Define EEE register page

In preparation for migrating the EEE code from bcm_sf2 to b53, define the full EEE register page and offsets within that page. Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_regs.h | 41

[PATCH net-next v3 08/12] net: dsa: b53: Move EEE functions to b53

Move the bcm_sf2 EEE-related functions to the b53 driver because this is shared code amongst Gigabit capable switch, only 5325 and 5365 are too old to support that. Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli ---

[PATCH net-next v3 12/12] net: dsa: bcm_sf2: Utilize b53_{enable,disable}_port

Export b53_{enable,disable}_port and use these two functions in bcm_sf2_port_setup and bcm_sf2_port_disable. The generic functions cannot be used without wrapping because we need to manage additional switch integration details (PHY, Broadcom tag etc.). Reviewed-by: Vivien Didelot

[PATCH net-next v3 03/12] net: dsa: b53: Defer port enabling to calling port_enable

There is no need to configure the enabled ports once in b53_setup() and then a second time around when dsa_switch_ops::port_enable is called, just do it when port_enable is called which is better in terms of power consumption and correctness. Reviewed-by: Vivien Didelot

[PATCH net-next v3 09/12] net: dsa: b53: Wire-up EEE

Add support for enabling and disabling EEE, as well as re-negotiating it in .adjust_link() and in .port_enable(). Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 10 ++ 1 file

[PATCH net-next v3 11/12] net: dsa: bcm_sf2: Use SF2_NUM_EGRESS_QUEUES for CFP

The magic number 8 in 3 locations in bcm_sf2_cfp.c actually designates the number of switch port egress queues, so use that define instead of open-coding it. Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli ---

[PATCH net-next v3 10/12] net: dsa: b53: Export b53_imp_vlan_setup()

bcm_sf2 and b53 do exactly the same thing, so share that piece. Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 3 ++- drivers/net/dsa/b53/b53_priv.h | 1 +

[PATCH net-next v3 04/12] net: dsa: bcm_sf2: Defer port enabling to calling port_enable

There is no need to configure the enabled ports once in bcm_sf2_sw_setup() and then a second time around when dsa_switch_ops::port_enable is called, just do it when port_enable is called which is better in terms of power consumption and correctness. Reviewed-by: Vivien Didelot

[PATCH net-next v3 06/12] net: dsa: b53: Move Broadcom header setup to b53

The code to enable Broadcom tags/headers is largely switch independent, and in preparation for enabling it for multiple devices with b53, move the code we have in bcm_sf2.c to b53_common.c Reviewed-by: Vivien Didelot Signed-off-by: Florian Fainelli

[PATCH net-next v3 00/12] net: dsa: b53/bcm_sf2 cleanups

Hi all, This patch series is a first pass set of clean-ups to reduce the number of LOCs between b53 and bcm_sf2 and sharing as many functions as possible. There is a number of additional cleanups queued up locally that require more thorough testing. Thanks! Changes in v3: - remove one extra

Re: [RFC PATCH 1/3] usbnet: Get rid of spammy usbnet "kevent X may have been dropped"

Douglas Anderson writes: > Every once in a while when my system is under a bit of stress I see > some spammy messages show up in my logs that say: > > kevent X may have been dropped > > As far as I can tell these messages aren't terribly useful. I agree, FWIW. These

Re: [PATCH net-next 3/4] net: dsa: setup master ethtool after dsa_ptr

On 09/19/2017 08:56 AM, Vivien Didelot wrote: > DSA overrides the master's ethtool ops so that we can inject its CPU > port's statistics. Because of that, we need to setup the ethtool ops > after the master's dsa_ptr pointer has been assigned, not before. Yes, good point, technically this is a

Re: [PATCH 2/3] selftests: actually run the various net selftests

On Tue, Sep 19, 2017 at 9:34 AM, Josef Bacik wrote: > On Mon, Sep 18, 2017 at 04:14:41PM -0600, Shuah Khan wrote: >> On 09/18/2017 11:32 AM, jo...@toxicpanda.com wrote: >> > From: Josef Bacik >> > >> > These self tests are just self contained binaries, they

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

On Tue, Sep 19, 2017 at 4:04 AM, Oleksandr Natalenko wrote: > Hi. > > 18.09.2017 23:40, Yuchung Cheng wrote: >> >> I assume this kernel does not have the patch that Neal proposed in his >> first reply? > > > Correct. > >> The main warning needs to be triggered by another

Re: [PATCH v2 net-next] net: sk_buff rbnode reorg

On Tue, Sep 19, 2017 at 8:14 AM, Eric Dumazet wrote: > From: Eric Dumazet > > skb->rbnode shares space with skb->next, skb->prev and skb->tstamp > > Current uses (TCP receive ofo queue and netem) need to save/restore > tstamp, while skb->dev is either

[patch net-next] team: fall back to hash if table entry is empty

If the hash to port mapping table does not have a valid port (i.e. when a port goes down), fall back to the simple hashing mechanism to avoid dropping packets. Signed-off-by: Jim Hanko Acked-by: Jiri Pirko --- drivers/net/team/team_mode_loadbalance.c |

[PATCH] isdn/i4l: check the message proto does not change across fetches

In isdn_ppp_write(), the header (i.e., protobuf) of the buffer is fetched twice from userspace. The first fetch is used to peek at the protocol of the message and reset the huptimer if necessary; while the second fetch copies in the whole buffer. However, given that buf resides in userspace

Re: [5/5] e1000e: Avoid receiver overrun interrupt bursts

Hi. We’ve been running this patchset (all 5) for about as long as they’ve been under review… about 2 months. And in a burn-in lab with heavy traffic. We’ve not seen a single link-flap in hundreds of ours of saturated traffic. Would love to see some resolution soon on this as we don’t want to

<    1   2   3