Re: [PATCH] net/ipv4: Update sk_for_each_entry_offset_rcu macro to utilize rcu methods hlist_next_rcu. This fixes the warnings thrown by sparse regarding net/ipv4/udp.c on line 1974.

2017-09-27 Thread Tim Hansen
> Tue, Sep 26, 2017 at 08:03:39PM -0700, David Miller wrote: > From: Tim Hansen > Date: Tue, 26 Sep 2017 20:54:05 -0400 > > > Signed-off-by: Tim Hansen > > This is a poor patch submission on many levels. > Apologies Dave, this is my first patch. I

Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation

2017-09-27 Thread Amine Kherbouche
On 09/27/2017 06:20 PM, Roopa Prabhu wrote: I think its better to bring the patch back in. Sounds good, ok

[PATCH net-next] tcp: fix under-evaluated ssthresh in TCP Vegas

2017-09-27 Thread Hoang Tran
With the commit 76174004a0f19785 (tcp: do not slow start when cwnd equals ssthresh), the comparison to the reduced cwnd in tcp_vegas_ssthresh() would under-evaluate the ssthresh. Signed-off-by: Hoang Tran --- net/ipv4/tcp_vegas.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id

2017-09-27 Thread Grant Grundler
On Wed, Sep 27, 2017 at 12:15 AM, Oliver Neukum wrote: > Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson: >> >> I know that for at least some of the adapters in the CDC Ethernet >> blacklist it was claimed that the CDC Ethernet support in the adapter >> was kinda

Re: [PATCH net-next] ipv6: do lazy dst->__use update when per cpu dst is available

2017-09-27 Thread Eric Dumazet
>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c > > Hi Paolo, > > Eric and I discussed about this issue recently as well :). > > What about the following change: > > diff --git a/include/net/dst.h b/include/net/dst.h > index 93568bd0a352..33e1d86bcef6 100644 > --- a/include/net/dst.h > +++

Re: tc H/W offload issue with vxlan tunnels [was: nfp: flower vxlan tunnel offload]

2017-09-27 Thread Jiri Benc
On Wed, 27 Sep 2017 14:55:09 +0200, Jiri Pirko wrote: > So where do you attach the tc filter instead of eth0? vxlan0? Yes, vxlan0. I'm pasting the example from earlier in this thread again: This will match: ip link add vxlan0 type vxlan dstport 4789 dev eth0 external ip link set dev vxlan0 up

Re: [PATCH net-next 1/6] net: dsa: Fix SWITCHDEV_ATTR_ID_PORT_PARENT_ID

2017-09-27 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > @@ -354,13 +354,16 @@ static int dsa_slave_port_attr_get(struct net_device > *dev, > struct switchdev_attr *attr) > { > struct dsa_slave_priv *p = netdev_priv(dev); > - struct dsa_switch *ds =

Re: tc H/W offload issue with vxlan tunnels [was: nfp: flower vxlan tunnel offload]

2017-09-27 Thread Jiri Pirko
Wed, Sep 27, 2017 at 05:27:29PM CEST, jb...@redhat.com wrote: >On Wed, 27 Sep 2017 14:55:09 +0200, Jiri Pirko wrote: >> So where do you attach the tc filter instead of eth0? vxlan0? > >Yes, vxlan0. I'm pasting the example from earlier in this thread again: > >This will match: > >ip link add vxlan0

Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation

2017-09-27 Thread Roopa Prabhu
On Wed, Sep 27, 2017 at 2:37 AM, Amine Kherbouche wrote: > This commit introduces the MPLSoGRE support (RFC 4023), using ip tunnel > API. > > Encap: > - Add a new iptunnel type mpls. > - Share tx path: gre type mpls loaded from skb->protocol. > > Decap: > - pull

Re: [PATCH v2 net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key

2017-09-27 Thread Jiri Benc
On Wed, 27 Sep 2017 10:16:32 +0200, Simon Horman wrote: > * Geneve > > In the case of Geneve options are TLVs[1]. My reading is that in collect > metadata mode the kernel does not appear to do anything other than pass > them around as a bytestring. > > [1]

RE: [PATCH v2 02/16] thunderbolt: Add support for XDomain properties

2017-09-27 Thread David Laight
From: Mika Westerberg > Sent: 27 September 2017 12:33 ... > Just for my education, is there some rule which tells when __packed is > to be used? For example the above structures are all 32-bit aligned but > how about something like: > > struct foo { > u32 value1; > u8 value2; > }; >

Re: [iproute PATCH v2 0/3] Check user supplied interface name lengths

2017-09-27 Thread Phil Sutter
On Wed, Sep 27, 2017 at 08:42:49AM +0100, Stephen Hemminger wrote: > On Tue, 26 Sep 2017 18:35:45 +0200 > Phil Sutter wrote: > > > This series adds explicit checks for user-supplied interface names to > > make sure their length fits Linux's requirements. > > > > The first two

[PATCH net-next] ipv6: do lazy dst->__use update when per cpu dst is available

2017-09-27 Thread Paolo Abeni
When a host is under high ipv6 load, the updates of the ingress route '__use' field are a source of relevant contention: such field is updated for each packet and several cores can access concurrently the dst, even if percpu dst entries are available and used. The __use value is just a rough

Re: [PATCH net-next 2/6] bpf: add meta pointer for direct access

2017-09-27 Thread Alexei Starovoitov
On Wed, Sep 27, 2017 at 04:54:57PM +0200, Jesper Dangaard Brouer wrote: > On Wed, 27 Sep 2017 06:35:40 -0700 > John Fastabend wrote: > > > On 09/27/2017 02:26 AM, Jesper Dangaard Brouer wrote: > > > On Tue, 26 Sep 2017 21:58:53 +0200 > > > Daniel Borkmann

Re: [PATCH net-next] ipv6: do lazy dst->__use update when per cpu dst is available

2017-09-27 Thread Wei Wang
On Wed, Sep 27, 2017 at 10:14 AM, Paolo Abeni wrote: > When a host is under high ipv6 load, the updates of the ingress > route '__use' field are a source of relevant contention: such > field is updated for each packet and several cores can access > concurrently the dst, even if

Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation

2017-09-27 Thread Amine Kherbouche
On 09/27/2017 05:36 PM, Roopa Prabhu wrote: Amine, one small nit here.., if you define mpls_gre_rcv in gre header (like you had initially), you could do the below... #if IS_ENABLED(CONFIG_MPLS) mpls_gre_rcv() { /* real func */ } #else mpls_gre_rcv() { kfree_skb(skb) return

Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation

2017-09-27 Thread Roopa Prabhu
On Wed, Sep 27, 2017 at 9:08 AM, Amine Kherbouche wrote: > > > On 09/27/2017 05:36 PM, Roopa Prabhu wrote: >> >> Amine, one small nit here.., if you define mpls_gre_rcv in gre header >> (like you had initially), you could do the below... >> >> #if

RE: [PATCH net v2] net: dsa: mv88e6xxx: lock mutex when freeing IRQs

2017-09-27 Thread David Laight
From: Andrew Lunn > Sent: 27 September 2017 14:07 > To: David Laight > On Wed, Sep 27, 2017 at 09:06:01AM +, David Laight wrote: > > From: Vivien Didelot > > > Sent: 26 September 2017 19:57 > > > mv88e6xxx_g2_irq_free locks the registers mutex, but not > > > mv88e6xxx_g1_irq_free, which

Re: [PATCH net-next 5/6] net: dsa: mv88e6xxx: Move mv88e6xxx_port_db_load_purge()

2017-09-27 Thread Vivien Didelot
Andrew Lunn writes: > This function is going to be needed by a soon to be added new > function. Move it earlier so we can avoid a forward declaration. > No code changes. s/code/functional/ > Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot

Re: [PATCH net-next] libbpf: use map_flags when creating maps

2017-09-27 Thread Alexei Starovoitov
On 9/27/17 7:04 AM, Craig Gallek wrote: From: Craig Gallek This extends struct bpf_map_def to include a flags field. Note that this has the potential to break the validation logic in bpf_object__validate_maps and bpf_object__init_maps as they use sizeof(struct bpf_map_def)

[PATCH V3] r8152: add Linksys USB3GIGV1 id

2017-09-27 Thread Grant Grundler
This linksys dongle by default comes up in cdc_ether mode. This patch allows r8152 to claim the device: Bus 002 Device 002: ID 13b1:0041 Linksys Signed-off-by: Grant Grundler --- drivers/net/usb/cdc_ether.c | 10 ++ drivers/net/usb/r8152.c | 2 ++ 2 files

Re: [PATCH v2 16/16] net: Add support for networking over Thunderbolt cable

2017-09-27 Thread David Miller
From: Mika Westerberg Date: Wed, 27 Sep 2017 16:42:38 +0300 > Using build_skb() then would require to allocate larger buffer, that > includes NET_SKB_PAD + SKB_DATA_ALIGN(skb_shared_info) and that exceeds > page size. Is this something supported by build_skb()?

Re: [patch net-next v3 00/12] mlxsw: Add support for offloading IPv4 multicast routes

2017-09-27 Thread David Miller
From: Jiri Pirko Date: Wed, 27 Sep 2017 08:23:10 +0200 > This patch-set introduces offloading of the kernel IPv4 multicast router > logic in the Spectrum driver. Series applied, thank you.

RTL8169 vs low-latency (was: Re: Re: RTL 8169 linux driver question)

2017-09-27 Thread Kirill Smelkov
+ klaus, ivan, ... On Mon, Nov 26, 2012 at 09:15:19AM -, David Laight wrote: > On Fri, Nov 23, 2012 at 08:14:37PM +0100, Stéphane ANCELOT wrote: > > I had problem with it, my application sends a frame that is immediately > > transmitted back by some slaves, there was abnormally 100us lost >

Re: [PATCH v2 2/2] ip_tunnel: add mpls over gre encapsulation

2017-09-27 Thread kbuild test robot
Hi Amine, [auto build test ERROR on net/master] [also build test ERROR on v4.14-rc2 next-20170927] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Amine-Kherbouche/mpls-expose-stack-entry

Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames in hardware

2017-09-27 Thread Andrew Lunn
> Adding the broadcast address to an Ethernet switch's FDB is pretty > generic and mv88e6xxx mustn't be the only driver doing this. Actually, it is. All the others seem to do this in hardware without needing an FDB. Since mv88e6xxx is the only one requiring it, it has to be done in the mv88e6xxx

Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames in hardware

2017-09-27 Thread Florian Fainelli
On 09/27/2017 11:24 AM, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > >> +static int mv88e6xxx_port_add_broadcast(struct mv88e6xxx_chip *chip, int >> port, >> +u16 vid) >> +{ >> +const char broadcast[6] = { 0xff, 0xff,

Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames in hardware

2017-09-27 Thread Andrew Lunn
> What if I don't have CONFIG_BRIDGE_VLAN_FILTERING enabled, what happens > in that case, would not this result in not programming the broadcast > address? Hi Florian It took me a while to make this work with CONFIG_BRIDGE_VLAN_FILTERING enabled. Any change to enable hardware flooding needs

Re: [PATCH v2 16/16] net: Add support for networking over Thunderbolt cable

2017-09-27 Thread David Miller
From: Mika Westerberg Date: Wed, 27 Sep 2017 20:27:02 +0300 > On Wed, Sep 27, 2017 at 09:27:09AM -0700, David Miller wrote: >> From: Mika Westerberg >> Date: Wed, 27 Sep 2017 16:42:38 +0300 >> >> > Using build_skb() then would

Re: [PATCH net-next] ipv6: do lazy dst->__use update when per cpu dst is available

2017-09-27 Thread Cong Wang
On Wed, Sep 27, 2017 at 10:44 AM, Wei Wang wrote: > Another thing is that I don't really see any places making use of > dst->__use. So maybe we can also get rid of this dst->__use field? It is used in rtnl_put_cacheinfo(): struct rta_cacheinfo ci = {

Re: [PATCH net-next 2/6] net: dsa: {e}dsa: set offload_fwd_mark on received packets

2017-09-27 Thread Andrew Lunn
On Wed, Sep 27, 2017 at 12:46:35PM -0700, Florian Fainelli wrote: > On 09/26/2017 03:25 PM, Andrew Lunn wrote: > > The software bridge needs to know if a packet has already been bridged > > by hardware offload to ports in the same hardware offload, in order > > that it does not re-flood them,

Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames in hardware

2017-09-27 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > +static int mv88e6xxx_port_add_broadcast(struct mv88e6xxx_chip *chip, int > port, > + u16 vid) > +{ > + const char broadcast[6] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }; > + > + return

Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames in hardware

2017-09-27 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> Adding the broadcast address to an Ethernet switch's FDB is pretty >> generic and mv88e6xxx mustn't be the only driver doing this. > > Actually, it is. All the others seem to do this in hardware without > needing an FDB. Since mv88e6xxx is the

Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames in hardware

2017-09-27 Thread Vivien Didelot
Hi Andrew, Florian, Andrew Lunn writes: > It took me a while to make this work with CONFIG_BRIDGE_VLAN_FILTERING > enabled. Any change to enable hardware flooding needs careful testing > for lots of different configurations. This is another reason i don't > want to do it at the

Re: [next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-09-27 Thread Cong Wang
On Tue, Sep 26, 2017 at 4:39 PM, Vinicius Costa Gomes wrote: > +static int cbs_init(struct Qdisc *sch, struct nlattr *opt) > +{ > + struct cbs_sched_data *q = qdisc_priv(sch); > + struct net_device *dev = qdisc_dev(sch); > + > + if (!opt) > +

Re: [PATCH net-next 0/6] mv88e6xxx broadcast flooding in hardware

2017-09-27 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > This patchset makes the mv88e6xxx driver perform flooding in hardware, > rather than let the software bridge perform the flooding. This is a > prerequisite for IGMP snooping on the bridge interface. > > In order to make hardware broadcasting

Re: [PATCH net-next] ipv6: do lazy dst->__use update when per cpu dst is available

2017-09-27 Thread Martin KaFai Lau
On Wed, Sep 27, 2017 at 06:03:33PM +, Eric Dumazet wrote: > >> diff --git a/net/ipv6/route.c b/net/ipv6/route.c > > > > > Hi Paolo, > > > > Eric and I discussed about this issue recently as well :). > > > > What about the following change: > > > > diff --git a/include/net/dst.h

Re: [PATCH net-next 2/6] net: dsa: {e}dsa: set offload_fwd_mark on received packets

2017-09-27 Thread Florian Fainelli
On 09/26/2017 03:25 PM, Andrew Lunn wrote: > The software bridge needs to know if a packet has already been bridged > by hardware offload to ports in the same hardware offload, in order > that it does not re-flood them, causing duplicates. This is > particularly true for broadcast and multicast

Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames in hardware

2017-09-27 Thread Florian Fainelli
On 09/27/2017 12:19 PM, Vivien Didelot wrote: > Hi Andrew, Florian, > > Andrew Lunn writes: > >> It took me a while to make this work with CONFIG_BRIDGE_VLAN_FILTERING >> enabled. Any change to enable hardware flooding needs careful testing >> for lots of different

Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames in hardware

2017-09-27 Thread Andrew Lunn
On Wed, Sep 27, 2017 at 12:33:29PM -0700, Florian Fainelli wrote: > On 09/27/2017 12:19 PM, Vivien Didelot wrote: > > Hi Andrew, Florian, > > > > Andrew Lunn writes: > > > >> It took me a while to make this work with CONFIG_BRIDGE_VLAN_FILTERING > >> enabled. Any change to

Re: [PATCH net-next RFC 5/5] vhost_net: basic tx virtqueue batched processing

2017-09-27 Thread Michael S. Tsirkin
On Wed, Sep 27, 2017 at 10:04:18AM +0800, Jason Wang wrote: > > > On 2017年09月27日 03:25, Michael S. Tsirkin wrote: > > On Fri, Sep 22, 2017 at 04:02:35PM +0800, Jason Wang wrote: > > > This patch implements basic batched processing of tx virtqueue by > > > prefetching desc indices and updating

[PATCH v2] netlink: do not proceed if dump's start() errs

2017-09-27 Thread Jason A. Donenfeld
Drivers that use the start method for netlink dumping rely on dumpit not being called if start fails. For example, ila_xlat.c allocates memory and assigns it to cb->args[0] in its start() function. It might fail to do that and return -ENOMEM instead. However, even when returning an error, dumpit

[PATCH net-next 3/5] bpf: libbpf: Provide basic API support to specify BPF obj name

2017-09-27 Thread Martin KaFai Lau
This patch extends the libbpf to provide API support to allow specifying BPF object name. In tools/lib/bpf/libbpf, the C symbol of the function and the map is used. Regarding section name, all maps are under the same section named "maps". Hence, section name is not a good choice for map's name.

[PATCH net-next 2/5] bpf: Add map_name to bpf_map_info

2017-09-27 Thread Martin KaFai Lau
This patch allows userspace to specify a name for a map during BPF_MAP_CREATE. The map's name can later be exported to user space via BPF_OBJ_GET_INFO_BY_FD. Signed-off-by: Martin KaFai Lau Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann

[PATCH net-next 1/5] bpf: Add name, load_time, uid and map_ids to bpf_prog_info

2017-09-27 Thread Martin KaFai Lau
The patch adds name and load_time to struct bpf_prog_aux. They are also exported to bpf_prog_info. The bpf_prog's name is passed by userspace during BPF_PROG_LOAD. The kernel only stores the first (BPF_PROG_NAME_LEN - 1) bytes and the name stored in the kernel is always \0 terminated. The

[PATCH] mkiss: remove redundant check on len being zero

2017-09-27 Thread Colin King
From: Colin Ian King The check on len is redundant as it is always greater than 1, so just remove it and make the printk less complex. Detected by CoverityScan, CID#1226729 ("Logically dead code") Signed-off-by: Colin Ian King ---

Re: [PATCH net-next 0/3] support changing steering policies in tuntap

2017-09-27 Thread Michael S. Tsirkin
On Wed, Sep 27, 2017 at 04:23:54PM +0800, Jason Wang wrote: > Hi all: > > We use flow caches based flow steering policy now. This is good for > connection-oriented communication such as TCP but not for the others > e.g connectionless unidirectional workload which cares only about > pps. This

Re: [PATCH net-next RFC 0/5] batched tx processing in vhost_net

2017-09-27 Thread Michael S. Tsirkin
On Wed, Sep 27, 2017 at 08:27:37AM +0800, Jason Wang wrote: > > > On 2017年09月26日 21:45, Michael S. Tsirkin wrote: > > On Fri, Sep 22, 2017 at 04:02:30PM +0800, Jason Wang wrote: > > > Hi: > > > > > > This series tries to implement basic tx batched processing. This is > > > done by prefetching

[PATCH next] bonding: speed/duplex update at NETDEV_UP event

2017-09-27 Thread Mahesh Bandewar
From: Mahesh Bandewar Some NIC drivers don't have correct speed/duplex settings at the time they send NETDEV_UP notification and that messes up the bonding state. Especially 802.3ad mode which is very sensitive to these settings. In the current implementation we invoke

[PATCH net v2] i40e: Fix limit imprecise of the number of MAC/VLAN that can be added for VFs

2017-09-27 Thread w00273186
From: Yunjian Wang Now it doesn't limit the number of MAC/VLAN strictly. When there is more elements in the virtchnl MAC/VLAN list, it can still add successfully. Signed-off-by: Yunjian Wang --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c

Re: [PATCH net-next RFC 5/5] vhost_net: basic tx virtqueue batched processing

2017-09-27 Thread Willem de Bruijn
> @@ -461,6 +460,7 @@ static void handle_tx(struct vhost_net *net) > struct socket *sock; > struct vhost_net_ubuf_ref *uninitialized_var(ubufs); > bool zcopy, zcopy_used; > + int i, batched = VHOST_NET_BATCH; > > mutex_lock(>mutex); > sock =

Re: [PATCH net-next RFC 3/5] vhost: introduce vhost_add_used_idx()

2017-09-27 Thread Willem de Bruijn
>> > > @@ -199,6 +199,7 @@ int __vhost_get_vq_desc(struct vhost_virtqueue *vq, >> > > void vhost_discard_vq_desc(struct vhost_virtqueue *, int n); >> > > int vhost_vq_init_access(struct vhost_virtqueue *); >> > > +int vhost_add_used_idx(struct vhost_virtqueue *vq, int n); >> > > int

RE: [PATCH net] i40e: Fix limit imprecise of the number of MAC/VLAN that can be added for VFs

2017-09-27 Thread wangyunjian
Thanks, I will send the v2 later. > -Original Message- > From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] > Sent: Wednesday, September 27, 2017 7:34 PM > To: wangyunjian ; da...@davemloft.net; > jeffrey.t.kirs...@intel.com > Cc:

[PATCH net-next] net: ipv4: remove fib_weight

2017-09-27 Thread David Ahern
fib_weight in fib_info is set but not used. Remove it and the helpers for setting it. Signed-off-by: David Ahern --- include/net/ip_fib.h | 3 --- net/ipv4/fib_semantics.c | 9 - 2 files changed, 12 deletions(-) diff --git a/include/net/ip_fib.h

Re: [PATCH net-next 4/6] net: dsa: mv88e6xxx: Print offending port when vlan check fails

2017-09-27 Thread Vivien Didelot
Andrew Lunn writes: > When testing if a VLAN is one more than one bridge, we print an error > message that the VLAN is already in use somewhere else. Print both the > new port which would like the VLAN, and the port which already has it, > to aid debugging. > > Signed-off-by:

Re: [PATCH v2 02/16] thunderbolt: Add support for XDomain properties

2017-09-27 Thread David Miller
From: Mika Westerberg Date: Wed, 27 Sep 2017 14:32:41 +0300 > Just for my education, is there some rule which tells when __packed is > to be used? For example the above structures are all 32-bit aligned but > how about something like: > > struct foo { >

Re: [PATCH 2/2] uapi: add a compatibility layer between linux/uio.h and glibc

2017-09-27 Thread Lee Duncan
Ping? I never saw any response to this. On Wed, 22 Feb 2017 05:29:47 +0300, Dmitry V Levin wrote: > Do not define struct iovec in linux/uio.h when or > is already included and provides these definitions. > > This fixes the following compilation error when or > is included before : > >

Re: [PATCH v2 16/16] net: Add support for networking over Thunderbolt cable

2017-09-27 Thread Mika Westerberg
On Wed, Sep 27, 2017 at 09:27:09AM -0700, David Miller wrote: > From: Mika Westerberg > Date: Wed, 27 Sep 2017 16:42:38 +0300 > > > Using build_skb() then would require to allocate larger buffer, that > > includes NET_SKB_PAD + SKB_DATA_ALIGN(skb_shared_info) and

Re: [PATCH net-next RFC 2/5] vhost: introduce helper to prefetch desc index

2017-09-27 Thread Michael S. Tsirkin
On Wed, Sep 27, 2017 at 08:35:47AM +0800, Jason Wang wrote: > > > On 2017年09月27日 03:19, Michael S. Tsirkin wrote: > > On Fri, Sep 22, 2017 at 04:02:32PM +0800, Jason Wang wrote: > > > This patch introduces vhost_prefetch_desc_indices() which could batch > > > descriptor indices fetching and used

Re: [next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-09-27 Thread Jesus Sanchez-Palencia
Hi, On 09/27/2017 02:14 PM, Vinicius Costa Gomes wrote: > Hi, > > Cong Wang writes: > >> On Tue, Sep 26, 2017 at 4:39 PM, Vinicius Costa Gomes >> wrote: >>> +static int cbs_init(struct Qdisc *sch, struct nlattr *opt) >>> +{ >>> +

Re: [PATCH V3] r8152: add Linksys USB3GIGV1 id

2017-09-27 Thread Doug Anderson
Hi, On Wed, Sep 27, 2017 at 10:28 AM, Grant Grundler wrote: > This linksys dongle by default comes up in cdc_ether mode. > This patch allows r8152 to claim the device: >Bus 002 Device 002: ID 13b1:0041 Linksys > > Signed-off-by: Grant Grundler >

[PATCH net-next] vhost_net: do not stall on zerocopy depletion

2017-09-27 Thread Willem de Bruijn
From: Willem de Bruijn Vhost-net has a hard limit on the number of zerocopy skbs in flight. When reached, transmission stalls. Stalls cause latency, as well as head-of-line blocking of other flows that do not use zerocopy. Instead of stalling, revert to copy-based

Re: [PATCH net-next RFC 3/5] vhost: introduce vhost_add_used_idx()

2017-09-27 Thread Michael S. Tsirkin
On Wed, Sep 27, 2017 at 08:38:24AM +0800, Jason Wang wrote: > > > On 2017年09月27日 03:13, Michael S. Tsirkin wrote: > > On Fri, Sep 22, 2017 at 04:02:33PM +0800, Jason Wang wrote: > > > This patch introduces a helper which just increase the used idx. This > > > will be used in pair with

Re: [PATCH v4 net-next 00/12] gtp: Additional feature support - Part I

2017-09-27 Thread Tom Herbert
On Wed, Sep 27, 2017 at 5:24 AM, Harald Welte wrote: > Hi Tom, > > thanks for your updated series! > > I'll revie as soon as I a, but that may likely not be before next > week. As indicated before, I'm on a motorbike roadtrip on vacation, > with very limited connectivity

Re: [next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-09-27 Thread Guedes, Andre
On Wed, 2017-09-27 at 15:57 -0700, Jesus Sanchez-Palencia wrote: > Hi, > > > On 09/27/2017 02:14 PM, Vinicius Costa Gomes wrote: > > Hi, > > > > Cong Wang writes: > > > > > On Tue, Sep 26, 2017 at 4:39 PM, Vinicius Costa Gomes > > > wrote:

Re: [PATCH V3] r8152: add Linksys USB3GIGV1 id

2017-09-27 Thread Grant Grundler
Hi Doug! On Wed, Sep 27, 2017 at 4:47 PM, Doug Anderson wrote: > Hi, > > On Wed, Sep 27, 2017 at 10:28 AM, Grant Grundler > wrote: >> This linksys dongle by default comes up in cdc_ether mode. >> This patch allows r8152 to claim the device: >>

Re: [PATCH net-next] vhost_net: do not stall on zerocopy depletion

2017-09-27 Thread Willem de Bruijn
On Wed, Sep 27, 2017 at 8:25 PM, Willem de Bruijn wrote: > From: Willem de Bruijn > > Vhost-net has a hard limit on the number of zerocopy skbs in flight. > When reached, transmission stalls. Stalls cause latency, as well as > head-of-line

Re: [PATCH net-next RFC 2/5] vhost: introduce helper to prefetch desc index

2017-09-27 Thread Willem de Bruijn
On Fri, Sep 22, 2017 at 4:02 AM, Jason Wang wrote: > This patch introduces vhost_prefetch_desc_indices() which could batch > descriptor indices fetching and used ring updating. This intends to > reduce the cache misses of indices fetching and updating and reduce > cache line

Re: [PATCH net-next 0/3] support changing steering policies in tuntap

2017-09-27 Thread Willem de Bruijn
>> In the future, both simple and sophisticated policy like RSS or other guest >> driven steering policies could be done on top. > > IMHO there should be a more practical example before adding all this > indirection. And it would be nice to understand why this queue selection > needs to be tun

Re: [PATCH net] ipv6: remove incorrect WARN_ON() in fib6_del()

2017-09-27 Thread Wei Wang
On Tue, Sep 26, 2017 at 6:20 AM, Eric Dumazet wrote: > On Mon, Sep 25, 2017 at 10:52 PM, Wei Wang wrote: >> On Mon, Sep 25, 2017 at 7:23 PM, Eric Dumazet wrote: >>> On Mon, Sep 25, 2017 at 7:07 PM, Martin KaFai Lau

Re: [next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-09-27 Thread Vinicius Costa Gomes
Hi, Cong Wang writes: > On Tue, Sep 26, 2017 at 4:39 PM, Vinicius Costa Gomes > wrote: >> +static int cbs_init(struct Qdisc *sch, struct nlattr *opt) >> +{ >> + struct cbs_sched_data *q = qdisc_priv(sch); >> + struct net_device

[PATCH] rndis_host: support Novatel Verizon USB730L

2017-09-27 Thread Aleksander Morgado
Treat the ef/04/01 interface class/subclass/protocol combination used by the Novatel Verizon USB730L (1410:9030) as a possible RNDIS interface. T: Bus=01 Lev=02 Prnt=02 Port=01 Cnt=02 Dev#= 17 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 3 P: Vendor=1410

[PATCH net-next 5/5] bpf: Test new fields in bpf_attr and bpf_{prog,map}_info

2017-09-27 Thread Martin KaFai Lau
This patch tests newly added fields of the bpf_attr, bpf_prog_info and bpf_map_info. Signed-off-by: Martin KaFai Lau Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- tools/testing/selftests/bpf/test_progs.c | 143

[PATCH net-next 4/5] bpf: Swap the order of checking prog_info and map_info

2017-09-27 Thread Martin KaFai Lau
This patch swaps the checking order. It now checks the map_info first and then prog_info. It is a prep work for adding test to the newly added fields (the map_ids of prog_info field in particular). Signed-off-by: Martin KaFai Lau Acked-by: Alexei Starovoitov

[PATCH net-next 0/5] bpf: Extend bpf_{prog,map}_info

2017-09-27 Thread Martin KaFai Lau
This patch series adds more fields to bpf_prog_info and bpf_map_info. Please see individual patch for details. Martin KaFai Lau (5): bpf: Add name, load_time, uid and map_ids to bpf_prog_info bpf: Add map_name to bpf_map_info bpf: libbpf: Provide basic API support to specify BPF obj name

Re: [PATCH net-next] libbpf: use map_flags when creating maps

2017-09-27 Thread Daniel Borkmann
On 09/27/2017 06:29 PM, Alexei Starovoitov wrote: On 9/27/17 7:04 AM, Craig Gallek wrote: From: Craig Gallek This extends struct bpf_map_def to include a flags field. Note that this has the potential to break the validation logic in bpf_object__validate_maps and

Re: [PATCH net-next 0/3] support changing steering policies in tuntap

2017-09-27 Thread Tom Herbert
On Wed, Sep 27, 2017 at 4:25 PM, Willem de Bruijn wrote: >>> In the future, both simple and sophisticated policy like RSS or other guest >>> driven steering policies could be done on top. >> >> IMHO there should be a more practical example before adding all this

[PATCH net] ip6_gre: ip6gre_tap device should keep dst

2017-09-27 Thread Xin Long
The patch 'ip_gre: ipgre_tap device should keep dst' fixed a issue that ipgre_tap mtu couldn't be updated in tx path. The same fix is needed for ip6gre_tap as well. Signed-off-by: Xin Long --- net/ipv6/ip6_gre.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH net] ip_gre: ipgre_tap device should keep dst

2017-09-27 Thread Xin Long
Without keeping dst, the tunnel will not update any mtu/pmtu info, since it does not have a dst on the skb. Reproducer: client(ipgre_tap1 - eth1) <-> (eth1 - ipgre_tap1)server After reducing eth1's mtu on client, then perforamnce became 0. This patch is to netif_keep_dst in gre_tap_init,

[PATCH net] ip6_tunnel: update mtu properly for ARPHRD_ETHER tunnel device in tx path

2017-09-27 Thread Xin Long
Now when updating mtu in tx path, it doesn't consider ARPHRD_ETHER tunnel device, like ip6gre_tap tunnel, for which it should also subtract ether header to get the correct mtu. Signed-off-by: Xin Long --- net/ipv6/ip6_tunnel.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH net-next] net: ipv4: remove fib_info arg to fib_check_nh

2017-09-27 Thread David Ahern
fib_check_nh does not use the fib_info arg; remove t. Signed-off-by: David Ahern --- net/ipv4/fib_semantics.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c index 57a5d48acee8..79989124607e 100644

Re: [PATCH iproute2] tc: fix ipv6 filter selector attribute for some prefix lengths

2017-09-27 Thread Yulia Kartseva
Hello Stephen, Sending as an attachment. Thank you! On Wed, Sep 27, 2017 at 1:26 AM, Stephen Hemminger wrote: > On Mon, 25 Sep 2017 11:12:38 -0700 > Yulia Kartseva wrote: > >> Wrong TCA_U32_SEL attribute packing if prefixLen AND 0x1f equals

[pull request][net 00/11] Mellanox, mlx5 fixes 2017-09-28

2017-09-27 Thread Saeed Mahameed
Hi Dave, This series provides misc fixes for mlx5 dirver. Please pull and let me know if there's any problem. for -stable: net/mlx5e: IPoIB, Fix access to invalid memory address (Kernels >= 4.12) Thanks, Saeed. -- The following changes since commit

[net 04/11] net/mlx5e: Fix erroneous freeing of encap header buffer

2017-09-27 Thread Saeed Mahameed
From: Paul Blakey In case the neighbour for the tunnel destination isn't valid, we send a neighbour update request but we free the encap header buffer. This is wrong, because we still need it for allocating a HW encap entry once the neighbour is available. Fix that by

[net 01/11] net/mlx5e: IPoIB, Fix access to invalid memory address

2017-09-27 Thread Saeed Mahameed
From: Roi Dayan When cleaning rdma netdevice we need to save the mdev pointer because priv is released when we release netdev. This bug was found using the kernel address sanitizer (KASAN). use-after-free in mlx5_rdma_netdev_free+0xe3/0x100 [mlx5_core] Fixes: 48935bbb7ae8

[net 09/11] net/mlx5e: Fix calculated checksum offloads counters

2017-09-27 Thread Saeed Mahameed
From: Gal Pressman Instead of calculating the offloads counters, count them explicitly. The calculations done for these counters would result in bugs in some cases, for example: When running TCP traffic over a VXLAN tunnel with TSO enabled the following counters would

[net 10/11] net/mlx5: Fix static checker warning on steering tracepoints code

2017-09-27 Thread Saeed Mahameed
From: Matan Barak Fix this sparse complaint: drivers/net/ethernet/mellanox/mlx5/core/./diag/fs_tracepoint.h:172:1: warning: odd constant _Bool cast ( becomes 1) Fixes: d9fea79171ee ('net/mlx5: Add tracepoints') Signed-off-by: Matan Barak

[net 11/11] net/mlx5: Fix wrong indentation in enable SRIOV code

2017-09-27 Thread Saeed Mahameed
From: Or Gerlitz Smatch is screaming: drivers/net/ethernet/mellanox/mlx5/core/sriov.c:112 mlx5_device_enable_sriov() warn: inconsistent indenting fix that. Fixes: 7ecf6d8ff154 ('IB/mlx5: Restore IB guid/policy for virtual functions') Signed-off-by: Or Gerlitz

[net 05/11] net/mlx5e: Disallow TC offloading of unsupported match/action combinations

2017-09-27 Thread Saeed Mahameed
From: Or Gerlitz When offloading header re-write, the HW may need to adjust checksums along the packet. For IP traffic, and a case where we are asked to modify fields in the IP header, current HW supports that only for TCP and UDP. Enforce it, in this case fail the

[net 03/11] net/mlx5: Check device capability for maximum flow counters

2017-09-27 Thread Saeed Mahameed
From: Raed Salem Added check for the maximal number of flow counters attached to rule (FTE). Fixes: bd5251dbf156b ('net/mlx5_core: Introduce flow steering destination of type counter') Signed-off-by: Raed Salem Reviewed-by: Maor Gottlieb

Re: [PATCH net-next] net: ipv4: remove fib_weight

2017-09-27 Thread David Miller
From: David Ahern Date: Wed, 27 Sep 2017 19:08:00 -0700 > fib_weight in fib_info is set but not used. Remove it and the > helpers for setting it. > > Signed-off-by: David Ahern Hmmm, I wonder then what Peter intended in commit

Re: [PATCH v6 11/11] of: mdio: Prevent of_mdiobus_register from scanning mdio-mux nodes

2017-09-27 Thread Florian Fainelli
On 09/27/2017 07:12 AM, Andrew Lunn wrote: > On Wed, Sep 27, 2017 at 09:34:14AM +0200, Corentin Labbe wrote: >> Each child node of an MDIO node is scanned as a PHY when calling >> of_mdiobus_register() givint the following result: >> [ 18.175379] mdio_bus stmmac-0:

[net 06/11] net/mlx5e: Check encap entry state when offloading tunneled flows

2017-09-27 Thread Saeed Mahameed
From: Vlad Buslov Encap entries cached by the driver could be invalidated due to tunnel destination neighbour state changes. When attempting to offload a flow that uses a cached encap entry, we must check the entry validity and defer the offloading if the entry exists but

[net 07/11] net/mlx5e: Print netdev features correctly in error message

2017-09-27 Thread Saeed Mahameed
From: Gal Pressman Use the correct formatting for netdev features. Fixes: 0e405443e803 ("net/mlx5e: Improve set features ndo resiliency") Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed ---

[net 02/11] net/mlx5: Fix FPGA capability location

2017-09-27 Thread Saeed Mahameed
From: Inbar Karmy Currently, FPGA capability is located in (mdev)->caps.hca_cur, change the location to be (mdev)->caps.fpga, since hca_cur is reserved for HCA device capabilities. Fixes: e29341fb3a5b ("net/mlx5: FPGA, Add basic support for Innova") Signed-off-by: Inbar

[net 08/11] net/mlx5e: Don't add/remove 802.1ad rules when changing 802.1Q VLAN filter

2017-09-27 Thread Saeed Mahameed
From: Gal Pressman Toggling of C-tag VLAN filter should not affect the "any S-tag" steering rule. Fixes: 8a271746a264 ("net/mlx5e: Receive s-tagged packets in promiscuous mode") Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed

Re: [PATCH net] ipv6: fix net.ipv6.conf.all interface DAD handlers

2017-09-27 Thread Erik Kline
> Erik, please review. I apologize for the delay. I see that you've already applied this, and it's mostly LGTM except I have one thing I'm not seeing clearly. The documentation accept_dad now claims: DAD operation and mode on a given interface will be selected according to the maximum

Re: [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-09-27 Thread Florian Fainelli
On 09/27/2017 12:34 AM, Corentin Labbe wrote: > This patch add documentation about the MDIO switch used on sun8i-h3-emac > for integrated PHY. > > Signed-off-by: Corentin Labbe > --- > .../devicetree/bindings/net/dwmac-sun8i.txt| 138 > +++--

Re: [PATCH net] net: Set sk_prot_creator when cloning sockets to the right proto

2017-09-27 Thread Eric Dumazet
On Tue, 2017-09-26 at 17:38 -0700, Christoph Paasch wrote: > sk->sk_prot and sk->sk_prot_creator can differ when the app uses > IPV6_ADDRFORM (transforming an IPv6-socket to an IPv4-one). > Which is why sk_prot_creator is there to make sure that sk_prot_free() > does the kmem_cache_free() on the

[patch net-next v3 04/12] ipmr: Send FIB notifications on MFC and VIF entries

2017-09-27 Thread Jiri Pirko
From: Yotam Gigi Use the newly introduced notification chain to send events upon VIF and MFC addition and deletion. The MFC notifications are sent only on resolved MFC entries, as unresolved cannot be offloaded. Signed-off-by: Yotam Gigi Reviewed-by:

  1   2   3   >