Re: [PATCH net-next 2/2] tools: bpf: add bpftool

2017-09-28 Thread David Miller
From: Jakub Kicinski Date: Thu, 28 Sep 2017 06:59:12 -0700 > On Tue, 26 Sep 2017 08:35:22 -0700, Jakub Kicinski wrote: >> Add a simple tool for querying and updating BPF objects on the system. >> >> Signed-off-by: Jakub Kicinski >> Reviewed-by:

Re: [PATCH net v2 0/3] net: mvpp2: various fixes

2017-09-28 Thread David Miller
From: Antoine Tenart Date: Mon, 25 Sep 2017 14:59:45 +0200 > This series contains 3 fixes for the Marvell PPv2 driver. Series applied, thanks.

Re: [Patch net-next v2] net_sched: use idr to allocate u32 filter handles

2017-09-28 Thread David Miller
From: Cong Wang Date: Mon, 25 Sep 2017 10:13:51 -0700 > Instead of calling u32_lookup_ht() in a loop to find > a unused handle, just switch to idr API to allocate > new handles. u32 filters are special as the handle > could contain a hash table id and a key id, so we >

Re: [Patch net-next v2] net_sched: use idr to allocate bpf filter handles

2017-09-28 Thread David Miller
From: Cong Wang Date: Mon, 25 Sep 2017 10:13:49 -0700 > Instead of calling cls_bpf_get() in a loop to find > a unused handle, just switch to idr API to allocate > new handles. > > Cc: Daniel Borkmann > Cc: Chris Mi > Cc:

Re: [Patch net-next v2] net_sched: use idr to allocate basic filter handles

2017-09-28 Thread David Miller
From: Cong Wang Date: Mon, 25 Sep 2017 10:13:50 -0700 > Instead of calling basic_get() in a loop to find > a unused handle, just switch to idr API to allocate > new handles. > > Cc: Chris Mi > Cc: Jamal Hadi Salim >

Re: [PATCH net-next RFC 2/9] net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock

2017-09-28 Thread Andrew Lunn
On Thu, Sep 28, 2017 at 10:25:34AM -0500, Brandon Streiff wrote: > This patch adds basic support for exposing the 32-bit timestamp counter > inside the mv88e6xxx switch code as a ptp_clock. > > Signed-off-by: Brandon Streiff > --- > drivers/net/dsa/mv88e6xxx/Kconfig |

Re: EBPF-triggered WARNING at mm/percpu.c:1361 in v4-14-rc2

2017-09-28 Thread Mark Rutland
On Thu, Sep 28, 2017 at 04:37:46PM +0200, Daniel Borkmann wrote: > On 09/28/2017 01:27 PM, Mark Rutland wrote: > >Hi, > > > >While fuzzing v4.14-rc2 with Syzkaller, I found it was possible to trigger > >the > >warning at mm/percpu.c:1361, on both arm64 and x86_64. This appears to > >require >

Re: [PATCH V3] r8152: add Linksys USB3GIGV1 id

2017-09-28 Thread Doug Anderson
Hi, On Wed, Sep 27, 2017 at 5:07 PM, Grant Grundler wrote: >>> #define DELL_VENDOR_ID 0x413C >>> #define REALTEK_VENDOR_ID 0x0bda >>> #define SAMSUNG_VENDOR_ID 0x04e8 >>> +#define LINKSYS_VENDOR_ID 0x13b1 >>> #define LENOVO_VENDOR_ID 0x17ef

Re: [PATCH net-next 0/3] support changing steering policies in tuntap

2017-09-28 Thread Willem de Bruijn
On Thu, Sep 28, 2017 at 3:23 AM, Jason Wang wrote: > > > On 2017年09月28日 07:25, Willem de Bruijn wrote: In the future, both simple and sophisticated policy like RSS or other guest driven steering policies could be done on top. >>> >>> IMHO there should be a

Re: EBPF-triggered WARNING at mm/percpu.c:1361 in v4-14-rc2

2017-09-28 Thread Tejun Heo
Hello, On Thu, Sep 28, 2017 at 12:27:28PM +0100, Mark Rutland wrote: > diff --git a/mm/percpu.c b/mm/percpu.c > index 59d44d6..f731c45 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -1355,8 +1355,13 @@ static void __percpu *pcpu_alloc(size_t size, size_t > align, bool reserved, >

Re: EBPF-triggered WARNING at mm/percpu.c:1361 in v4-14-rc2

2017-09-28 Thread Daniel Borkmann
On 09/28/2017 04:45 PM, Mark Rutland wrote: On Thu, Sep 28, 2017 at 04:37:46PM +0200, Daniel Borkmann wrote: On 09/28/2017 01:27 PM, Mark Rutland wrote: Hi, While fuzzing v4.14-rc2 with Syzkaller, I found it was possible to trigger the warning at mm/percpu.c:1361, on both arm64 and x86_64.

[PATCH net-next RFC 6/9] net: dsa: forward timestamping callbacks to switch drivers

2017-09-28 Thread Brandon Streiff
Forward the rx/tx timestamp machinery from the dsa infrastructure to the switch driver. On the rx side, defer delivery of skbs until we have an rx timestamp. This mimicks the behavior of skb_defer_rx_timestamp. The implementation does have to thread through the tagging protocol handlers because

[PATCH net-next RFC 0/9] net: dsa: PTP timestamping for mv88e6xxx

2017-09-28 Thread Brandon Streiff
This patch series adds support for PTP timestamping through the DSA framework, as well as an implementation for mv8e6xxx switches. This implementation was targeted at a National Instruments platform that uses the Marvell 88E6341 (Topaz). I've tried to enable support on other Marvell switches

[PATCH net-next RFC 1/9] net: dsa: mv88e6xxx: add accessors for PTP/TAI registers

2017-09-28 Thread Brandon Streiff
This patch implements support for accessing PTP/TAI registers through the AVB register interface in the Global 2 register. The register interface differs slightly between different models; older models use a 3-bit operations field, while newer models use a 2-bit field. The operations values and

[PATCH net-next RFC 2/9] net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock

2017-09-28 Thread Brandon Streiff
This patch adds basic support for exposing the 32-bit timestamp counter inside the mv88e6xxx switch code as a ptp_clock. Signed-off-by: Brandon Streiff --- drivers/net/dsa/mv88e6xxx/Kconfig | 10 +++ drivers/net/dsa/mv88e6xxx/Makefile | 1 +

[PATCH net-next RFC 7/9] ptp: add offset for reserved field to header

2017-09-28 Thread Brandon Streiff
There is a four-byte "reserved" field at octet 16 in PTPv2. Signed-off-by: Brandon Streiff --- include/linux/ptp_classify.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/ptp_classify.h b/include/linux/ptp_classify.h index a079656..b9b0073 100644 ---

Re: [Intel-wired-lan] [PATCH net v2] i40e: Fix limit imprecise of the number of MAC/VLAN that can be added for VFs

2017-09-28 Thread Alexander Duyck
On Wed, Sep 27, 2017 at 7:01 PM, w00273186 wrote: > From: Yunjian Wang > > Now it doesn't limit the number of MAC/VLAN strictly. When there is more > elements in the virtchnl MAC/VLAN list, it can still add successfully. You could still add but

Re: [PATCH v4 1/2] expose stack entry function

2017-09-28 Thread David Miller
From: Amine Kherbouche Date: Thu, 28 Sep 2017 11:34:19 +0200 > Exporting mpls_forward() function to be able to be called from elsewhere > such as MPLSoverGRE in the next commit. > > Signed-off-by: Amine Kherbouche > Acked-by: Roopa Prabhu

Re: [PATCH v3] tun: bail out from tun_get_user() if the skb is empty

2017-09-28 Thread David Miller
From: Alexander Potapenko Date: Thu, 28 Sep 2017 11:32:37 +0200 > KMSAN (https://github.com/google/kmsan) reported accessing uninitialized > skb->data[0] in the case the skb is empty (i.e. skb->len is 0): ... > Make sure tun_get_user() doesn't touch skb->data[0] unless there

[PATCH net] ppp: fix __percpu annotation

2017-09-28 Thread Guillaume Nault
Move sparse annotation right after pointer type. Fixes sparse warning: drivers/net/ppp/ppp_generic.c:1422:13: warning: incorrect type in initializer (different address spaces) drivers/net/ppp/ppp_generic.c:1422:13:expected void const [noderef] *__vpp_verify

Re: EBPF-triggered WARNING at mm/percpu.c:1361 in v4-14-rc2

2017-09-28 Thread Tejun Heo
Hello, On Thu, Sep 28, 2017 at 03:45:38PM +0100, Mark Rutland wrote: > > Perhaps the pr_warn() should be ratelimited; or could there be an > > option where we only return NULL, not triggering a warn at all (which > > would likely be what callers might do anyway when checking against > >

[PATCH 1/4] dt-bindings: net: ravb: Document optional reset-gpios property

2017-09-28 Thread Geert Uytterhoeven
The optional "reset-gpios" property (part of the generic MDIO bus properties) lets us describe the GPIO used for resetting the Ethernet PHY. Signed-off-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/net/renesas,ravb.txt | 2 ++ 1 file changed, 2

[PATCH 3/4] arm64: dts: renesas: salvator-common: Add EthernetAVB PHY reset

2017-09-28 Thread Geert Uytterhoeven
Describe the GPIO used to reset the Ethernet PHY for EthernetAVB. This allows the driver to reset the PHY during probe and after system resume. This fixes Ethernet operation after resume from s2ram on Salvator-XS, where the enable pin of the regulator providing PHY power is connected to PRESETn,

[PATCH 4/4] arm64: dts: renesas: ulcb: Add EthernetAVB PHY reset

2017-09-28 Thread Geert Uytterhoeven
Describe the GPIO used to reset the Ethernet PHY for EthernetAVB. This allows the driver to reset the PHY during probe and after system resume. On ULCB, the enable pin of the regulator providing PHY power is always pulled high, but the driver may still need to reset the PHY if this wasn't done by

[PATCH 0/4] ravb: Add PHY reset support

2017-09-28 Thread Geert Uytterhoeven
Hi all, This patch series adds optional PHY reset support during EthernetAVB driver probe and system resume on the Renesas Salvator-X/XS development boards. The rationale behind this is twofold: 1. On Salvator-XS, the enable pin of the regulator providing PHY power is connected to

Re: [PATCH net] net: mvpp2: Fix clock resource by adding an optional bus clock

2017-09-28 Thread Gregory CLEMENT
Hi Thomas, On jeu., sept. 28 2017, Thomas Petazzoni wrote: >> /* List of pointers to port structures */ >> struct mvpp2_port **port_list; >> @@ -7963,6 +7964,16 @@ static int mvpp2_probe(struct platform_device *pdev) >> err =

Re: [PATCH net-next RFC 1/9] net: dsa: mv88e6xxx: add accessors for PTP/TAI registers

2017-09-28 Thread Vivien Didelot
Hi Brandon, Brandon Streiff writes: > + .port_ptp_read = mv88e6352_port_ptp_read, > + .port_ptp_write = mv88e6352_port_ptp_write, > + .ptp_read = mv88e6352_ptp_read, > + .ptp_write = mv88e6352_ptp_write, > +

Re: [PATCH net-next] inetpeer: speed up inetpeer_invalidate_tree()

2017-09-28 Thread David Miller
From: Eric Dumazet Date: Mon, 25 Sep 2017 09:14:14 -0700 > From: Eric Dumazet > > As measured in my prior patch ("sch_netem: faster rb tree removal"), > rbtree_postorder_for_each_entry_safe() is nice looking but much slower > than using rb_next()

Re: [PATCH net] l2tp: fix l2tp_eth module loading

2017-09-28 Thread Guillaume Nault
On Thu, Sep 28, 2017 at 03:17:28PM +0100, Tom Parkin wrote: > On Thu, Sep 28, 2017 at 03:44:38PM +0200, Guillaume Nault wrote: > > The l2tp_eth module crashes if its netlink callbacks are run when the > > pernet data aren't initialised. > > > > We should normally register_pernet_device() before

Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers.

2017-09-28 Thread Pavel Machek
Hi! > > > drivers/net/dsa/microchip/Makefile |2 +- > > > drivers/net/dsa/microchip/ksz9477.c| 1317 > > > > > > We already have ksz_9477_reg.h. So should this be ksz_9477.c for > > consistency? > > The product name is KSZ9477 and other switches are

Re: [PATCH RFC 3/5] Add KSZ8795 switch driver

2017-09-28 Thread Pavel Machek
> > > > Similar code will be needed by other drivers, right? > > > > > > Although KSZ8795 and KSZ8895 may use the same code, the other > > > chips will have different code. > > > > Ok, please make sure code is shared between these two. > > The exact function probably cannot be shared between

[PATCH net-next RFC 8/9] net: dsa: mv88e6xxx: add rx/tx timestamping support

2017-09-28 Thread Brandon Streiff
This patch implements RX/TX timestamping support. The Marvell PTP hardware supports RX timestamping individual message types, but for simplicity we only support the EVENT receive filter since few if any clients bother with the more specific filter types. We also utilize a feature of the

[PATCH net-next RFC 4/9] net: dsa: mv88e6xxx: add support for event capture

2017-09-28 Thread Brandon Streiff
This patch adds support for configuring mv88e6xxx GPIO lines as PTP pins, so that they may be used for time stamping external events or for periodic output. Signed-off-by: Brandon Streiff --- drivers/net/dsa/mv88e6xxx/chip.h | 4 + drivers/net/dsa/mv88e6xxx/ptp.c |

[PATCH net-next RFC 3/9] net: dsa: mv88e6xxx: add support for GPIO configuration

2017-09-28 Thread Brandon Streiff
The Scratch/Misc register is a windowed interface that provides access to the GPIO configuration. Provide a new method for configuration of GPIO functions. Signed-off-by: Brandon Streiff --- drivers/net/dsa/mv88e6xxx/chip.c| 13 +++

[PATCH net] net: mvpp2: Fix clock resource by adding an optional bus clock

2017-09-28 Thread Gregory CLEMENT
On Armada 7K/8K we need to explicitly enable the bus clock. The bus clock is optional because not all the SoCs need them but at least for Armada 7K/8K it is actually mandatory. The binding documentation is updating accordingly. Signed-off-by: Gregory CLEMENT

[PATCH 2/4] ravb: Add optional PHY reset during system resume

2017-09-28 Thread Geert Uytterhoeven
If the optional "reset-gpios" property is specified in DT, the generic MDIO bus code takes care of resetting the PHY during device probe. However, the PHY may still have to be reset explicitly after system resume. This allows to restore Ethernet operation after resume from s2ram on Salvator-XS,

[PATCH net-next RFC 9/9] net: dsa: mv88e6xxx: add workaround for 6341 timestamping

2017-09-28 Thread Brandon Streiff
88E6341 devices default to timestamping at the PHY, but due to a hardware issue, timestamps via this component are unreliable. For this family, configure the PTP hardware to force the timestamping to occur at the MAC. Signed-off-by: Brandon Streiff ---

Re: [PATCH net-next] vhost_net: do not stall on zerocopy depletion

2017-09-28 Thread Willem de Bruijn
On Thu, Sep 28, 2017 at 3:41 AM, Jason Wang wrote: > > > On 2017年09月28日 08:25, Willem de Bruijn wrote: >> >> From: Willem de Bruijn >> >> Vhost-net has a hard limit on the number of zerocopy skbs in flight. >> When reached, transmission stalls. Stalls

[PATCH v5 1/2] mpls: export mpls_forward()

2017-09-28 Thread Amine Kherbouche
Exporting mpls_forward() function to be able to be called from elsewhere such as MPLSoverGRE in the next commit. Signed-off-by: Amine Kherbouche Acked-by: Roopa Prabhu --- include/linux/mpls.h | 4 net/mpls/af_mpls.c | 5 +++-- 2

Re: [PATCH] isdn/eicon: do integrity check on cmd->adapter == a->controller early

2017-09-28 Thread David Miller
From: Meng Xu Date: Sun, 24 Sep 2017 11:14:41 -0400 > + /* do the integrity check early */ > + if(((diva_xdi_um_cfg_cmd_t *)data)->adapter != a->controller){ > + DBG_ERR(("A: A(%d) write, invalid controller=%d != %d", > +

[PATCH v5 2/2] ip_tunnel: add mpls over gre encapsulation

2017-09-28 Thread Amine Kherbouche
This commit introduces the MPLSoGRE support (RFC 4023), using ip tunnel API. Encap: - Add a new iptunnel type mpls. - Share tx path: gre type mpls loaded from skb->protocol. Decap: - pull gre hdr and call mpls_forward(). Signed-off-by: Amine Kherbouche

[PATCH v5 0/2] Introduce MPLS over GRE

2017-09-28 Thread Amine Kherbouche
This series introduces the MPLS over GRE encapsulation (RFC 4023). Various applications of MPLS make use of label stacks with multiple entries. In some cases, it is possible to replace the top label of the stack with an IP-based encapsulation, thereby, it is possible for two LSRs that are

Re: [patch net] net: dsa: mv88e6xxx: Allow dsa and cpu ports in multiple vlans

2017-09-28 Thread David Miller
From: Andrew Lunn Date: Mon, 25 Sep 2017 23:32:20 +0200 > Ports with the same VLAN must all be in the same bridge. However the > CPU and DSA ports need to be in multiple VLANs spread over multiple > bridges. So exclude them when performing this test. > > Fixes: b2f81d304cee

[PATCH net-next RFC 5/9] net: dsa: forward hardware timestamping ioctls to switch driver

2017-09-28 Thread Brandon Streiff
This patch adds support to the dsa slave network device so that switch drivers can implement the SIOC[GS]HWTSTAMP ioctls and the ethtool timestamp-info interface. Signed-off-by: Brandon Streiff --- include/net/dsa.h | 15 +++ net/dsa/slave.c | 39

Re: [PATCH net] inetpeer: fix RCU lookup() again

2017-09-28 Thread David Miller
From: Eric Dumazet Date: Mon, 25 Sep 2017 08:40:02 -0700 > From: Eric Dumazet > > My prior fix was not complete, as we were dereferencing a pointer > three times per node, not twice as I initially thought. > > Fixes: 4cc5b44b29a9 ("inetpeer: fix

Re: [PATCH net-next RFC 2/9] net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock

2017-09-28 Thread Andrew Lunn
> +/* The 32-bit timestamp counter overflows every ~34.3 seconds; this task > + * forces periodic reads so that we don't miss any wraparounds. > + */ > +#define MV88E6XXX_TAI_OVERFLOW_PERIOD (34 * HZ / 2) > +static void mv88e6xxx_ptp_overflow_check(struct work_struct *work) > +{ > + struct

Re: [PATCH] net-ipv6: remove unused IP6_ECN_clear() function

2017-09-28 Thread David Miller
From: Maciej Żenczykowski Date: Tue, 26 Sep 2017 20:37:22 -0700 > From: Maciej Żenczykowski > > This function is unused, and furthermore it is buggy since it suffers > from the same issue that requires IP6_ECN_set_ce() to take a pointer > to the skb so

Re: [patch net-next 1/7] skbuff: Add the offload_mr_fwd_mark field

2017-09-28 Thread Andrew Lunn
On Thu, Sep 28, 2017 at 07:34:09PM +0200, Jiri Pirko wrote: > From: Yotam Gigi > > Similarly to the offload_fwd_mark field, the offload_mr_fwd_mark field is > used to allow partial offloading of MFC multicast routes. > The reason why the already existing "offload_fwd_mark"

Re: [PATCH v5 1/4] ipv4: Namespaceify tcp_fastopen knob

2017-09-28 Thread David Miller
From: Haishuang Yan Date: Wed, 27 Sep 2017 11:35:40 +0800 > Different namespace application might require enable TCP Fast Open > feature independently of the host. > > This patch series continues making more of the TCP Fast Open related > sysctl knobs be per

Re: [PATCH net-next RFC 0/9] net: dsa: PTP timestamping for mv88e6xxx

2017-09-28 Thread Florian Fainelli
On 09/28/2017 10:36 AM, Andrew Lunn wrote: >> - Patch #3: The GPIO config support is handled in a very simple manner. >> I suspect a longer term goal would be to use pinctrl here. > > I assume ptp already has the core code to use pinctrl and Linux > standard GPIOs? What does the device tree

Re: [PATCH RFC 3/5] Add KSZ8795 switch driver

2017-09-28 Thread Pavel Machek
Hi! On Mon 2017-09-18 20:27:13, tristram...@microchip.com wrote: > > > +/** > > > + * Some counters do not need to be read too often because they are less > > likely > > > + * to increase much. > > > + */ > > > > What does comment mean? Are you caching statistics, and updating > > different

Re: [PATCH RFC 3/5] Add KSZ8795 switch driver

2017-09-28 Thread Florian Fainelli
On 09/28/2017 11:40 AM, Pavel Machek wrote: > Hi! > > On Mon 2017-09-18 20:27:13, tristram...@microchip.com wrote: +/** + * Some counters do not need to be read too often because they are less >>> likely + * to increase much. + */ >>> >>> What does comment mean? Are you

Re: [PATCH 2/4] ravb: Add optional PHY reset during system resume

2017-09-28 Thread Geert Uytterhoeven
Hi Florian, On Thu, Sep 28, 2017 at 7:22 PM, Florian Fainelli wrote: > On 09/28/2017 08:53 AM, Geert Uytterhoeven wrote: >> If the optional "reset-gpios" property is specified in DT, the generic >> MDIO bus code takes care of resetting the PHY during device probe. >>

Re: [RFC PATCH v3 7/7] i40e: Enable cloud filters via tc-flower

2017-09-28 Thread Nambiar, Amritha
On 9/14/2017 1:00 AM, Nambiar, Amritha wrote: > On 9/13/2017 6:26 AM, Jiri Pirko wrote: >> Wed, Sep 13, 2017 at 11:59:50AM CEST, amritha.namb...@intel.com wrote: >>> This patch enables tc-flower based hardware offloads. tc flower >>> filter provided by the kernel is configured as driver specific

Re: [PATCH net-next RFC 5/9] net: dsa: forward hardware timestamping ioctls to switch driver

2017-09-28 Thread Florian Fainelli
On 09/28/2017 08:25 AM, Brandon Streiff wrote: > This patch adds support to the dsa slave network device so that > switch drivers can implement the SIOC[GS]HWTSTAMP ioctls and the > ethtool timestamp-info interface. > > Signed-off-by: Brandon Streiff > --- > struct

Re: [PATCH net-next RFC 3/9] net: dsa: mv88e6xxx: add support for GPIO configuration

2017-09-28 Thread Florian Fainelli
On 09/28/2017 08:25 AM, Brandon Streiff wrote: > The Scratch/Misc register is a windowed interface that provides access > to the GPIO configuration. Provide a new method for configuration of > GPIO functions. > > Signed-off-by: Brandon Streiff > --- > +/* Offset 0x1A:

Re: [PATCH v5 4/4] ipv4: Namespaceify tcp_fastopen_blackhole_timeout knob

2017-09-28 Thread David Miller
From: Haishuang Yan Date: Wed, 27 Sep 2017 11:35:43 +0800 > Different namespace application might require different time period in > second to disable Fastopen on active TCP sockets. > > Tested: > Simulate following similar situation that the server's data

Re: [PATCH v5 2/4] ipv4: Remove the 'publish' logic in tcp_fastopen_init_key_once

2017-09-28 Thread David Miller
From: Haishuang Yan Date: Wed, 27 Sep 2017 11:35:41 +0800 > The 'publish' logic is not necessary after commit dfea2aa65424 ("tcp: > Do not call tcp_fastopen_reset_cipher from interrupt context"), because > in tcp_fastopen_cookie_gen,it wouldn't call

Re: [PATCH v5 3/4] ipv4: Namespaceify tcp_fastopen_key knob

2017-09-28 Thread David Miller
From: Haishuang Yan Date: Wed, 27 Sep 2017 11:35:42 +0800 > Different namespace application might require different tcp_fastopen_key > independently of the host. > > David Miller pointed out there is a leak without releasing the context > of tcp_fastopen_key

Re: [PATCH] Add a driver for Renesas uPD60620 and uPD60620A PHYs

2017-09-28 Thread Bernd Edlinger
On 09/22/17 19:59, Andrew Lunn wrote: > On Fri, Sep 22, 2017 at 05:08:45PM +, Bernd Edlinger wrote: >> >> +config RENESAS_PHY >> +tristate "Driver for Renesas PHYs" >> +---help--- >> + Supports the uPD60620 and uPD60620A PHYs. >> + > > Hi Bernd > > Please call this "Reneseas

Re: [PATCH 3/4] arm64: dts: renesas: salvator-common: Add EthernetAVB PHY reset

2017-09-28 Thread Florian Fainelli
On 09/28/2017 08:53 AM, Geert Uytterhoeven wrote: > Describe the GPIO used to reset the Ethernet PHY for EthernetAVB. > This allows the driver to reset the PHY during probe and after system > resume. > > This fixes Ethernet operation after resume from s2ram on Salvator-XS, > where the enable pin

Re: [PATCH] net: stmmac: dwc-qos: Add suspend / resume support

2017-09-28 Thread David Miller
From: Ed Blake Date: Tue, 26 Sep 2017 11:43:46 +0100 > Add hook to stmmac_pltfr_pm_ops for suspend / resume handling. > > Signed-off-by: Ed Blake Applied.

Re: [PATCH net-next v4 0/4] rtnetlink: preparation patches for further rtnl lock pushdown/removal

2017-09-28 Thread David Miller
From: Florian Westphal Date: Tue, 26 Sep 2017 13:58:39 +0200 > Patches split large rtnl_fill_ifinfo into smaller chunks > to better see which parts > > 1. require rtnl > 2. do not require it at all > 3. rely on rtnl locking now but could be converted > > Changes since v3: > >

Re: [PATCH] net: stmmac: dwmac4: Re-enable MAC Rx before powering down

2017-09-28 Thread David Miller
From: Ed Blake Date: Tue, 26 Sep 2017 11:44:53 +0100 > Re-enable the MAC receiver by setting CONFIG_RE before powering down, > as instructed in section 6.3.5.1 of [1]. Without this the MAC fails > to receive WoL packets and never wakes up. > > [1] DWC Ethernet QoS

Re: [PATCH 2/4] ravb: Add optional PHY reset during system resume

2017-09-28 Thread Florian Fainelli
On 09/28/2017 08:53 AM, Geert Uytterhoeven wrote: > If the optional "reset-gpios" property is specified in DT, the generic > MDIO bus code takes care of resetting the PHY during device probe. > However, the PHY may still have to be reset explicitly after system > resume. > > This allows to

Re: [PATCH][next] cxgb4: make function ch_flower_stats_cb, fixes warning

2017-09-28 Thread David Miller
From: Colin King Date: Tue, 26 Sep 2017 16:14:09 +0100 > From: Colin Ian King > > The function ch_flower_stats_cb is local to the source and does not need > to be in global scope, so make it static. > > Cleans up sparse warnings: > symbol

[patch net-next 1/7] skbuff: Add the offload_mr_fwd_mark field

2017-09-28 Thread Jiri Pirko
From: Yotam Gigi Similarly to the offload_fwd_mark field, the offload_mr_fwd_mark field is used to allow partial offloading of MFC multicast routes. Switchdev drivers can offload MFC multicast routes to the hardware by registering to the FIB notification chain. When one of

[patch net-next 3/7] ipv4: ipmr: Don't forward packets already forwarded by hardware

2017-09-28 Thread Jiri Pirko
From: Yotam Gigi Change the ipmr module to not forward packets if: - The packet is marked with the offload_mr_fwd_mark, and - Both input interface and output interface share the same parent ID. This way, a packet can go through partial multicast forwarding in the

[iproute PATCH] ip-route: Fix for listing routes with RTAX_LOCK attribute

2017-09-28 Thread Phil Sutter
This fixes a corner-case for routes with a certain metric locked to zero: | ip route add 192.168.7.0/24 dev eth0 window 0 | ip route add 192.168.7.0/24 dev eth0 window lock 0 Since the kernel doesn't dump the attribute if it is zero, both routes added above would appear as if they were equal

Re: [PATCH v3 net-next 00/10] Add support for DCB feature in hns3 driver

2017-09-28 Thread David Miller
From: Yunsheng Lin Date: Wed, 27 Sep 2017 09:45:22 +0800 > The patchset contains some enhancement related to DCB before > adding support for DCB feature. Series applied, thanks.

Re: [PATCH net] net: Set sk_prot_creator when cloning sockets to the right proto

2017-09-28 Thread David Miller
From: Christoph Paasch Date: Tue, 26 Sep 2017 17:38:50 -0700 > sk->sk_prot and sk->sk_prot_creator can differ when the app uses > IPV6_ADDRFORM (transforming an IPv6-socket to an IPv4-one). > Which is why sk_prot_creator is there to make sure that sk_prot_free() > does the

[patch net-next 7/7] mlxsw: spectrum: mr: Support trap-and-forward routes

2017-09-28 Thread Jiri Pirko
From: Yotam Gigi Add the support of trap-and-forward route action in the multicast routing offloading logic. A route will be set to trap-and-forward action if one (or more) of its output interfaces is not offload-able, i.e. does not have a valid Spectrum RIF. This way, a

[patch net-next 4/7] mlxsw: acl: Introduce ACL trap and forward action

2017-09-28 Thread Jiri Pirko
From: Yotam Gigi Use trap/discard flex action to implement trap and forward. The action will later be used for multicast routing, as the multicast routing mechanism is done using ACL flexible actions in Spectrum hardware. Using that action, it will be possible to implement a

[patch net-next 5/7] mlxsw: spectrum: Add trap for multicast trap-and-forward routes

2017-09-28 Thread Jiri Pirko
From: Yotam Gigi When a multicast route is configured with trap-and-forward action, the packets should be marked with skb->offload_mr_fwd_mark, in order to prevent the packets from being forwarded again by the kernel ipmr module. Due to this, it is not possible to use the

[patch net-next 0/7] mlxsw: Add support for partial multicast route offload

2017-09-28 Thread Jiri Pirko
From: Jiri Pirko Yotam says: Previous patchset introduced support for offloading multicast MFC routes to the Spectrum hardware. As described in that patchset, no partial offloading is supported, i.e if a route has one output interface which is not a valid offloadable device

[patch net-next 2/7] ipv4: ipmr: Add the parent ID field to VIF struct

2017-09-28 Thread Jiri Pirko
From: Yotam Gigi In order to allow the ipmr module to do partial multicast forwarding according to the device parent ID, add the device parent ID field to the VIF struct. This way, the forwarding path can use the parent ID field without invoking switchdev calls, which

[patch net-next 6/7] mlxsw: spectrum: mr_tcam: Add trap-and-forward multicast route

2017-09-28 Thread Jiri Pirko
From: Yotam Gigi In addition to the current multicast route actions, which include trap route action and a forward route action, add the trap-and-forward multicast route action, and implement it in the multicast routing hardware logic. To implement that, add a

[PATCH V4] r8152: add Linksys USB3GIGV1 id

2017-09-28 Thread Grant Grundler
This linksys dongle by default comes up in cdc_ether mode. This patch allows r8152 to claim the device: Bus 002 Device 002: ID 13b1:0041 Linksys Signed-off-by: Grant Grundler --- drivers/net/usb/cdc_ether.c | 10 ++ drivers/net/usb/r8152.c | 2 ++ 2 files

Re: [PATCH net-next] net-next/hinic: Fix a case of Tx Queue is Stopped forever

2017-09-28 Thread David Miller
From: Aviad Krawczyk Date: Wed, 27 Sep 2017 02:11:33 +0800 > Fix the following scenario: > 1. tx_free_poll is running on cpu X > 2. xmit function is running on cpu Y and fails to get sq wqe > 3. tx_free_poll frees wqes on cpu X and checks the queue is not stopped > 4.

Re: [PATCH net-next] net-next/hinic: Set Rxq irq to specific cpu for NUMA

2017-09-28 Thread David Miller
From: Aviad Krawczyk Date: Wed, 27 Sep 2017 01:57:50 +0800 > Set Rxq irq to specific cpu for allocating and receiving the skb from > the same node. > > Signed-off-by: Aviad Krawczyk Applied.

Re: [PATCH net-next] libbpf: use map_flags when creating maps

2017-09-28 Thread Craig Gallek
On Wed, Sep 27, 2017 at 6:03 PM, Daniel Borkmann wrote: > On 09/27/2017 06:29 PM, Alexei Starovoitov wrote: >> >> On 9/27/17 7:04 AM, Craig Gallek wrote: >>> >>> From: Craig Gallek >>> >>> This extends struct bpf_map_def to include a flags field. Note

Re: [PATCH net-next RFC 6/9] net: dsa: forward timestamping callbacks to switch drivers

2017-09-28 Thread Florian Fainelli
On 09/28/2017 08:25 AM, Brandon Streiff wrote: > Forward the rx/tx timestamp machinery from the dsa infrastructure to the > switch driver. > > On the rx side, defer delivery of skbs until we have an rx timestamp. > This mimicks the behavior of skb_defer_rx_timestamp. The implementation > does

Re: [patch net-next 3/7] ipv4: ipmr: Don't forward packets already forwarded by hardware

2017-09-28 Thread Florian Fainelli
On 09/28/2017 10:34 AM, Jiri Pirko wrote: > From: Yotam Gigi > > Change the ipmr module to not forward packets if: > - The packet is marked with the offload_mr_fwd_mark, and > - Both input interface and output interface share the same parent ID. > > This way, a packet can

Re: [PATCH net-next RFC 5/9] net: dsa: forward hardware timestamping ioctls to switch driver

2017-09-28 Thread Vivien Didelot
Hi Brandon, Brandon Streiff writes: > static int dsa_slave_ioctl(struct net_device *dev, struct ifreq *ifr, int > cmd) > { > + struct dsa_slave_priv *p = netdev_priv(dev); > + struct dsa_switch *ds = p->dp->ds; > + int port = p->dp->index; > + > if

Re: [PATCH net] net: dsa: Fix network device registration order

2017-09-28 Thread David Miller
From: Florian Fainelli Date: Mon, 25 Sep 2017 15:55:53 -0700 > We cannot be registering the network device first, then setting its > carrier off and finally connecting it to a PHY, doing that leaves a > window during which the carrier is at best inconsistent, and at worse >

Re: [PATCH net] packet: only test po->has_vnet_hdr once in packet_snd

2017-09-28 Thread David Miller
aFrom: Willem de Bruijn Date: Tue, 26 Sep 2017 12:20:17 -0400 > From: Willem de Bruijn > > Packet socket option po->has_vnet_hdr can be updated concurrently with > other operations if no ring is attached. > > Do not test the option twice in

Re: [PATCH net] packet: in packet_do_bind, test fanout with bind_lock held

2017-09-28 Thread David Miller
From: Willem de Bruijn Date: Tue, 26 Sep 2017 12:19:37 -0400 > From: Willem de Bruijn > > Once a socket has po->fanout set, it remains a member of the group > until it is destroyed. The prot_hook must be constant and identical > across

Re: [PATCH v2 net-next 0/2] bpf/verifier: disassembly improvements

2017-09-28 Thread David Miller
From: Edward Cree Date: Tue, 26 Sep 2017 16:32:15 +0100 > Fix the output of print_bpf_insn() for ALU ops that don't look like > compound assignment (i.e. BPF_END and BPF_NEG). > > Sample output for a short test program: > 0: (b4) (u32) r0 = (u32) 0 > 1: (dc) r0 = be32 r0

Re: [PATCH net v2] net: dsa: mv88e6xxx: lock mutex when freeing IRQs

2017-09-28 Thread David Miller
From: Vivien Didelot Date: Tue, 26 Sep 2017 14:57:21 -0400 > mv88e6xxx_g2_irq_free locks the registers mutex, but not > mv88e6xxx_g1_irq_free, which results in a stack trace from > assert_reg_lock when unloading the mv88e6xxx module. Fix this. > > Fixes:

Re: [PATCH] arp: make arp_hdr_len() return unsigned int

2017-09-28 Thread David Miller
From: Alexey Dobriyan Date: Tue, 26 Sep 2017 23:12:28 +0300 > Negative ARP header length are not a thing. > > Constify arguments while I'm at it. > > Space savings: > > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-3 (-3) > functionold

[PATCH net-next] Revert "net: dsa: bcm_sf2: Defer port enabling to calling port_enable"

2017-09-28 Thread Florian Fainelli
This reverts commit e85ec74ace29 ("net: dsa: bcm_sf2: Defer port enabling to calling port_enable") because this now makes an unbind followed by a bind to fail connecting to the ingrated PHY. What this patch missed is that we need the PHY to be enabled with bcm_sf2_gphy_enable_set() before probing

Re: [PATCH net-next v4] selftests: rtnetlink.sh: add rudimentary vrf test

2017-09-28 Thread David Miller
From: Florian Westphal Date: Tue, 26 Sep 2017 07:40:42 +0200 > Acked-by: David Ahern > Signed-off-by: Florian Westphal > --- > Changes since v1: indent all lines with tabs, not spaces > > detaching this from the series, I want to avoid

Re: [PATCH net-next RFC 0/9] net: dsa: PTP timestamping for mv88e6xxx

2017-09-28 Thread Andrew Lunn
> - Patch #3: The GPIO config support is handled in a very simple manner. > I suspect a longer term goal would be to use pinctrl here. I assume ptp already has the core code to use pinctrl and Linux standard GPIOs? What does the device tree binding look like? How do you specify the GPIOs to

[PATCH v2] lib: fix multiple strlcpy definition

2017-09-28 Thread Baruch Siach
Some C libraries, like uClibc and musl, provide BSD compatible strlcpy(). Add check_strlcpy() to configure, and avoid defining strlcpy and strlcat when the C library provides them. This fixes the following static link error with uClibc-ng: .../sysroot/usr/lib/libc.a(strlcpy.os): In function

Re: [PATCH net-next RFC 3/9] net: dsa: mv88e6xxx: add support for GPIO configuration

2017-09-28 Thread Andrew Lunn
On Thu, Sep 28, 2017 at 10:45:03AM -0700, Florian Fainelli wrote: > On 09/28/2017 08:25 AM, Brandon Streiff wrote: > > The Scratch/Misc register is a windowed interface that provides access > > to the GPIO configuration. Provide a new method for configuration of > > GPIO functions. > > > >

Re: [PATCH net-next v9] openvswitch: enable NSH support

2017-09-28 Thread Pravin Shelar
On Tue, Sep 26, 2017 at 6:39 PM, Yang, Yi wrote: > On Tue, Sep 26, 2017 at 06:49:14PM +0800, Jiri Benc wrote: >> On Tue, 26 Sep 2017 12:55:39 +0800, Yang, Yi wrote: >> > After push_nsh, the packet won't be recirculated to flow pipeline, so >> > key->eth.type must be set

Re: [PATCH 2/4] ravb: Add optional PHY reset during system resume

2017-09-28 Thread Florian Fainelli
On 09/28/2017 11:45 AM, Geert Uytterhoeven wrote: > Hi Florian, > > On Thu, Sep 28, 2017 at 7:22 PM, Florian Fainelli > wrote: >> On 09/28/2017 08:53 AM, Geert Uytterhoeven wrote: >>> If the optional "reset-gpios" property is specified in DT, the generic >>> MDIO bus code

Re: [PATCH RFC 3/5] Add KSZ8795 switch driver

2017-09-28 Thread Andrew Lunn
On Mon, Sep 18, 2017 at 08:27:13PM +, tristram...@microchip.com wrote: > > > +/** > > > + * Some counters do not need to be read too often because they are less > > likely > > > + * to increase much. > > > + */ > > > > What does comment mean? Are you caching statistics, and updating > >

Re: [PATCH 1/4] dt-bindings: net: ravb: Document optional reset-gpios property

2017-09-28 Thread Sergei Shtylyov
Hello! On 09/28/2017 06:53 PM, Geert Uytterhoeven wrote: The optional "reset-gpios" property (part of the generic MDIO bus properties) lets us describe the GPIO used for resetting the Ethernet PHY. Signed-off-by: Geert Uytterhoeven ---

[PATCH net-next 03/10] sctp: factor out stream->in allocation

2017-09-28 Thread Marcelo Ricardo Leitner
Same idea as previous patch. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/stream.c | 36 1 file changed, 28 insertions(+), 8 deletions(-) diff --git a/net/sctp/stream.c b/net/sctp/stream.c index

  1   2   3   >